Kernel/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2025-01-09 22:50:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

firmware: use 'kernel_read()' to read firmware into kernel buffer

Browse Source 
Fengguang correctly points out that the firmware reading should not use
vfs_read(), since the buffer is in kernel space.

The vfs_read() just happened to work for kernel threads, but sparse
warns about the incorrect address spaces, and it's definitely incorrect
and could fail for other users of the firmware loading.

Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Linus Torvalds 2012-10-04 09:19:02 -07:00
parent e1cc485262
commit ce57e981f2
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/base/firmware_class.c
View File

@ -58,7 +58,6 @@ static noinline long fw_file_size(struct file *file)
static bool fw_read_file_contents(struct file *file, struct firmware *fw) static bool fw_read_file_contents(struct file *file, struct firmware *fw)
{ {
loff_t pos;
long size; long size;
char *buf; char *buf;
@ -68,8 +67,7 @@ static bool fw_read_file_contents(struct file *file, struct firmware *fw)
buf = vmalloc(size); buf = vmalloc(size);
if (!buf) if (!buf)
return false; return false;
pos = 0; if (kernel_read(file, 0, buf, size) != size) {
if (vfs_read(file, buf, size, &pos) != size) {
vfree(buf); vfree(buf);
return false; return false;
} }