Kernel/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2025-01-16 02:14:58 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

hwmon: (aspeed-pwm-tacho): Simplify with scoped for each OF child loop

Browse Source 
Use scoped for_each_child_of_node_scoped() when iterating over device
nodes to make code a bit simpler.

Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
Reviewed-by: Andrew Jeffery <andrew@codeconstruct.com.au>
Message-ID: <20240822062956.3490387-3-ruanjinjie@huawei.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
This commit is contained in:
Jinjie Ruan 2024-08-22 14:29:50 +08:00 committed by Guenter Roeck
parent 24b070d7d8
commit d5733a9387
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/hwmon/aspeed-pwm-tacho.c
View File

@ -907,7 +907,7 @@ static void aspeed_pwm_tacho_remove(void *data)
static int aspeed_pwm_tacho_probe(struct platform_device *pdev) static int aspeed_pwm_tacho_probe(struct platform_device *pdev)
{ {
struct device *dev = &pdev->dev; struct device *dev = &pdev->dev;
struct device_node *np, *child; struct device_node *np;
struct aspeed_pwm_tacho_data *priv; struct aspeed_pwm_tacho_data *priv;
void __iomem *regs; void __iomem *regs;
struct device *hwmon; struct device *hwmon;
@ -951,13 +951,11 @@ static int aspeed_pwm_tacho_probe(struct platform_device *pdev)
aspeed_create_type(priv); aspeed_create_type(priv);
for_each_child_of_node(np, child) { for_each_child_of_node_scoped(np, child) {
ret = aspeed_create_fan(dev, child, priv); ret = aspeed_create_fan(dev, child, priv);
if (ret) { if (ret)
of_node_put(child);
return ret; return ret;
} }
}
priv->groups[0] = &pwm_dev_group; priv->groups[0] = &pwm_dev_group;
priv->groups[1] = &fan_dev_group; priv->groups[1] = &fan_dev_group;