mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2025-01-04 04:06:26 +00:00
crypto: omap-aes - Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
This commit is contained in:
parent
a0061b93c6
commit
e0dffa0ea9
@ -1255,7 +1255,7 @@ static int omap_aes_probe(struct platform_device *pdev)
|
||||
return err;
|
||||
}
|
||||
|
||||
static int omap_aes_remove(struct platform_device *pdev)
|
||||
static void omap_aes_remove(struct platform_device *pdev)
|
||||
{
|
||||
struct omap_aes_dev *dd = platform_get_drvdata(pdev);
|
||||
struct aead_engine_alg *aalg;
|
||||
@ -1285,8 +1285,6 @@ static int omap_aes_remove(struct platform_device *pdev)
|
||||
pm_runtime_disable(dd->dev);
|
||||
|
||||
sysfs_remove_group(&dd->dev->kobj, &omap_aes_attr_group);
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
#ifdef CONFIG_PM_SLEEP
|
||||
@ -1307,7 +1305,7 @@ static SIMPLE_DEV_PM_OPS(omap_aes_pm_ops, omap_aes_suspend, omap_aes_resume);
|
||||
|
||||
static struct platform_driver omap_aes_driver = {
|
||||
.probe = omap_aes_probe,
|
||||
.remove = omap_aes_remove,
|
||||
.remove_new = omap_aes_remove,
|
||||
.driver = {
|
||||
.name = "omap-aes",
|
||||
.pm = &omap_aes_pm_ops,
|
||||
|
Loading…
Reference in New Issue
Block a user