Kernel/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2025-01-06 05:06:29 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

overlayfs, locking: Remove smp_mb__before_spinlock() usage

Browse Source 
While we could replace the smp_mb__before_spinlock() with the new
smp_mb__after_spinlock(), the normal pattern is to use
smp_store_release() to publish an object that is used for
lockless_dereference() -- and mirrors the regular rcu_assign_pointer()
/ rcu_dereference() patterns.

Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
This commit is contained in:
Peter Zijlstra 2017-06-07 17:43:46 +02:00 committed by Ingo Molnar
parent 8b1b436dd1
commit ff7a5fb0f1
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
fs/overlayfs/readdir.c
View File

@ -446,14 +446,14 @@ static int ovl_dir_fsync(struct file *file, loff_t start, loff_t end,
ovl_path_upper(dentry, &upperpath); ovl_path_upper(dentry, &upperpath);
realfile = ovl_path_open(&upperpath, O_RDONLY); realfile = ovl_path_open(&upperpath, O_RDONLY);
smp_mb__before_spinlock();
inode_lock(inode); inode_lock(inode);
if (!od->upperfile) { if (!od->upperfile) {
if (IS_ERR(realfile)) { if (IS_ERR(realfile)) {
inode_unlock(inode); inode_unlock(inode);
return PTR_ERR(realfile); return PTR_ERR(realfile);
} }
od->upperfile = realfile; smp_store_release(&od->upperfile, realfile);
} else { } else {
/* somebody has beaten us to it */ /* somebody has beaten us to it */
if (!IS_ERR(realfile)) if (!IS_ERR(realfile))