Benno Lossin 0c54a877aa rust: macros: fix soundness issue in module! macro ... [ Upstream commit 7044dcff83 ] The `module!` macro creates glue code that are called by C to initialize the Rust modules using the `Module::init` function. Part of this glue code are the local functions `__init` and `__exit` that are used to initialize/destroy the Rust module. These functions are safe and also visible to the Rust mod in which the `module!` macro is invoked. This means that they can be called by other safe Rust code. But since they contain `unsafe` blocks that rely on only being called at the right time, this is a soundness issue. Wrap these generated functions inside of two private modules, this guarantees that the public functions cannot be called from the outside. Make the safe functions `unsafe` and add SAFETY comments. Cc: stable@vger.kernel.org Reported-by: Björn Roy Baron <bjorn3_gh@protonmail.com> Closes: https://github.com/Rust-for-Linux/linux/issues/629 Fixes: 1fbde52bde ("rust: add `macros` crate") Signed-off-by: Benno Lossin <benno.lossin@proton.me> Reviewed-by: Wedson Almeida Filho <walmeida@microsoft.com> Link: https://lore.kernel.org/r/20240401185222.12015-1-benno.lossin@proton.me [ Moved `THIS_MODULE` out of the private-in-private modules since it should remain public, as Dirk Behme noticed [1]. Capitalized comments, avoided newline in non-list SAFETY comments and reworded to add Reported-by and newline. ] Link: https://rust-for-linux.zulipchat.com/#narrow/stream/291565-Help/topic/x/near/433512583 [1] Signed-off-by: Miguel Ojeda <ojeda@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2024-05-17 12:14:22 +02:00
..
alloc	rust: upgrade to Rust 1.74.1	2023-12-21 19:40:26 +01:00
bindings	Rust changes for v6.8	2024-01-11 13:05:41 -08:00
kernel	rust: init: remove impl Zeroable for Infallible	2024-05-02 16:35:25 +02:00
macros	rust: macros: fix soundness issue in module! macro	2024-05-17 12:14:22 +02:00
uapi	net: phy: add Rust Asix PHY driver	2023-12-15 09:35:50 +00:00
.gitignore	rust: support running Rust documentation tests as KUnit ones	2023-07-19 09:32:53 -06:00
bindgen_parameters	rust: Ignore preserve-most functions	2023-12-13 01:09:55 +01:00
build_error.rs	rust: add build_error crate	2022-12-04 01:59:16 +01:00
compiler_builtins.rs	rust: upgrade to Rust 1.73.0	2023-10-15 21:25:08 +02:00
exports.c	rust: replace <linux/module.h> with <linux/export.h> in rust/exports.c	2023-12-13 01:09:55 +01:00
helpers.c	rust: workqueue: add helper for defining work_struct fields	2023-09-25 09:46:42 -10:00
Makefile	kbuild: rust: remove unneeded @rustc_cfg to avoid ICE	2024-05-02 16:35:25 +02:00