Kernel/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2025-01-16 02:14:58 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
linux-stable/crypto
History
Lukas Wunner c82bb825f9 crypto: ecdsa - Avoid signed integer overflow on signature decoding 
[ Upstream commit 3b0565c703503f832d6cd7ba805aafa3b330cb9d ]

When extracting a signature component r or s from an ASN.1-encoded
integer, ecdsa_get_signature_rs() subtracts the expected length
"bufsize" from the ASN.1 length "vlen" (both of unsigned type size_t)
and stores the result in "diff" (of signed type ssize_t).

This results in a signed integer overflow if vlen > SSIZE_MAX + bufsize.

The kernel is compiled with -fno-strict-overflow, which implies -fwrapv,
meaning signed integer overflow is not undefined behavior.  And the
function does check for overflow:

       if (-diff >= bufsize)
               return -EINVAL;

So the code is fine in principle but not very obvious.  In the future it
might trigger a false-positive with CONFIG_UBSAN_SIGNED_WRAP=y.

Avoid by comparing the two unsigned variables directly and erroring out
if "vlen" is too large.

Signed-off-by: Lukas Wunner <lukas@wunner.de>
Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2024-12-14 20:03:36 +01:00
..
asymmetric_keys
KEYS: prevent NULL pointer dereference in find_asymmetric_key()
2024-09-20 19:49:49 +03:00
async_tx
async_tx: fix kernel-doc notation warnings
2023-03-24 18:22:28 +08:00
842.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157
2019-05-30 11:26:37 -07:00
acompress.c
crypto: remove CONFIG_CRYPTO_STATS
2024-04-02 10:49:38 +08:00
adiantum.c
crypto: adiantum - flush destination page before unmapping
2023-11-01 12:58:42 +08:00
aead.c
crypto: aead,cipher - zeroize key buffer after use
2024-04-26 17:26:09 +08:00
aegis128-core.c
crypto: aegis128 - Fix indentation issue in crypto_aegis128_process_crypt()
2024-09-13 18:26:52 +08:00
aegis128-neon-inner.c
crypto: aegis128-neon - add header for internal prototypes
2023-05-24 18:12:33 +08:00
aegis128-neon.c
crypto: aegis128-neon - add header for internal prototypes
2023-05-24 18:12:33 +08:00
aegis-neon.h
crypto: aegis128-neon - add header for internal prototypes
2023-05-24 18:12:33 +08:00
aegis.h
crypto: aegis128 - Move simd prototypes into aegis.h
2021-03-19 21:59:45 +11:00
aes_generic.c
move asm/unaligned.h to linux/unaligned.h
2024-10-02 17:23:23 -04:00
aes_ti.c
crypto: Prepare to move crypto_tfm_ctx
2022-12-02 18:12:40 +08:00
af_alg.c
crypto: Add missing MODULE_DESCRIPTION() macros
2024-05-31 17:34:56 +08:00
ahash.c
crypto: remove CONFIG_CRYPTO_STATS
2024-04-02 10:49:38 +08:00
akcipher.c
crypto: remove CONFIG_CRYPTO_STATS
2024-04-02 10:49:38 +08:00
algapi.c
crypto: api - Fix liveliness check in crypto_alg_tested
2024-10-10 17:03:35 +08:00
algboss.c
crypto: algboss - Pass instance creation error up
2024-09-06 14:50:46 +08:00
algif_aead.c
sock: Remove ->sendpage*() in favour of sendmsg(MSG_SPLICE_PAGES)
2023-06-24 15:50:13 -07:00
algif_hash.c
crypto: Add missing MODULE_DESCRIPTION() macros
2024-05-31 17:34:56 +08:00
algif_rng.c
sock: Remove ->sendpage*() in favour of sendmsg(MSG_SPLICE_PAGES)
2023-06-24 15:50:13 -07:00
algif_skcipher.c
crypto: Add missing MODULE_DESCRIPTION() macros
2024-05-31 17:34:56 +08:00
ansi_cprng.c
crypto: remove cipher routines from public crypto API
2021-01-03 08:41:35 +11:00
anubis.c
crypto: Prepare to move crypto_tfm_ctx
2022-12-02 18:12:40 +08:00
api.c
crypto: api - Fix generic algorithm self-test races
2024-09-06 14:50:46 +08:00
arc4.c
crypto: arc4 - Add internal state
2023-12-08 11:59:46 +08:00
aria_generic.c
crypto: x86/aria - do not use magic number offsets of aria_ctx
2023-01-06 17:15:47 +08:00
authenc.c
crypto: authenc - stop using alignmask of ahash
2023-10-27 18:04:29 +08:00
authencesn.c
crypto: authencesn - stop using alignmask of ahash
2023-10-27 18:04:29 +08:00
blake2b_generic.c
move asm/unaligned.h to linux/unaligned.h
2024-10-02 17:23:23 -04:00
blowfish_common.c
crypto: Prepare to move crypto_tfm_ctx
2022-12-02 18:12:40 +08:00
blowfish_generic.c
move asm/unaligned.h to linux/unaligned.h
2024-10-02 17:23:23 -04:00
bpf_crypto_skcipher.c
bpf: crypto: add skcipher to bpf crypto
2024-04-24 16:01:10 -07:00
camellia_generic.c
move asm/unaligned.h to linux/unaligned.h
2024-10-02 17:23:23 -04:00
cast5_generic.c
move asm/unaligned.h to linux/unaligned.h
2024-10-02 17:23:23 -04:00
cast6_generic.c
move asm/unaligned.h to linux/unaligned.h
2024-10-02 17:23:23 -04:00
cast_common.c
crypto: Add missing MODULE_DESCRIPTION() macros
2024-05-31 17:34:56 +08:00
cbc.c
crypto: cbc - Ensure statesize is zero
2024-02-02 18:08:12 +08:00
ccm.c
crypto: ccm - stop using alignmask of ahash
2023-10-27 18:04:29 +08:00
chacha20poly1305.c
crypto: chacha20poly1305 - Annotate struct chachapoly_ctx with __counted_by()
2024-08-17 13:55:49 +08:00
chacha_generic.c
move asm/unaligned.h to linux/unaligned.h
2024-10-02 17:23:23 -04:00
cipher.c
crypto: aead,cipher - zeroize key buffer after use
2024-04-26 17:26:09 +08:00
cmac.c
crypto: cmac - remove unnecessary alignment logic
2023-10-27 18:04:24 +08:00
compress.c
crypto: compress - remove crt_u.compress (struct compress_tfm)
2019-12-11 16:37:01 +08:00
compress.h
crypto: remove CONFIG_CRYPTO_STATS
2024-04-02 10:49:38 +08:00
crc32_generic.c
move asm/unaligned.h to linux/unaligned.h
2024-10-02 17:23:23 -04:00
crc32c_generic.c
move asm/unaligned.h to linux/unaligned.h
2024-10-02 17:23:23 -04:00
crc64_rocksoft_generic.c
move asm/unaligned.h to linux/unaligned.h
2024-10-02 17:23:23 -04:00
crct10dif_common.c
crypto: crct10dif - Add fallback for broken initrds
2013-09-12 15:31:34 +10:00
crct10dif_generic.c
crypto: crct10dif_generic - fix duplicated words
2020-08-21 14:45:25 +10:00
cryptd.c
crypto: cryptd - Only access common skcipher fields on spawn
2023-10-13 18:27:26 +08:00
crypto_engine.c
crypto: engine - Make crypto_engine_exit() return void
2023-10-01 16:28:15 +08:00
crypto_null.c
Merge branch 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6
2019-07-08 20:57:08 -07:00
crypto_user.c
crypto: remove CONFIG_CRYPTO_STATS
2024-04-02 10:49:38 +08:00
ctr.c
crypto: ctr - Only access common skcipher fields on spawn
2023-10-13 18:27:27 +08:00
cts.c
crypto: cts - Only access common skcipher fields on spawn
2023-10-13 18:27:27 +08:00
curve25519-generic.c
crypto: Add missing MODULE_DESCRIPTION() macros
2024-05-31 17:34:56 +08:00
deflate.c
crypto: deflate - Add aliases to deflate
2024-06-28 11:35:47 +10:00
des_generic.c
crypto: Prepare to move crypto_tfm_ctx
2022-12-02 18:12:40 +08:00
dh_helper.c
crypto: dh - split out deserialization code from crypto_dh_decode()
2022-03-03 10:47:50 +12:00
dh.c
crypto: dh - Check mpi_rshift errors
2024-08-17 13:55:50 +08:00
drbg.c
crypto: drbg - Remove SHA1 from drbg
2023-11-17 19:16:29 +08:00
ecb.c
crypto: skcipher - Add internal state support
2023-12-08 11:59:46 +08:00
ecc_curve_defs.h
crypto: ecc - Add NIST P521 curve parameters
2024-04-12 15:07:52 +08:00
ecc.c
move asm/unaligned.h to linux/unaligned.h
2024-10-02 17:23:23 -04:00
ecdh_helper.c
crypto: ecdh - move curve_id of ECDH from the key to algorithm name
2021-03-13 00:04:03 +11:00
ecdh.c
crypto: ecdh - Initialize ctx->private_key in proper byte order
2024-04-26 17:26:09 +08:00
ecdsa.c
crypto: ecdsa - Avoid signed integer overflow on signature decoding
2024-12-14 20:03:36 +01:00
ecdsasignature.asn1
crypto: ecdsa - Add support for ECDSA signature verification
2021-03-26 19:41:58 +11:00
echainiv.c
crypto: geniv - remove unneeded arguments from aead_geniv_alloc()
2020-07-16 21:49:07 +10:00
ecrdsa_defs.h
crypto: ecc - Add nbits field to ecc_curve structure
2024-04-12 15:07:52 +08:00
ecrdsa_params.asn1
crypto: ecrdsa - add EC-RDSA (GOST 34.10) algorithm
2019-04-18 22:15:02 +08:00
ecrdsa_pub_key.asn1
crypto: ecrdsa - add EC-RDSA (GOST 34.10) algorithm
2019-04-18 22:15:02 +08:00
ecrdsa.c
crypto: ecrdsa - Fix module auto-load on add_key
2024-04-02 10:49:38 +08:00
essiv.c
crypto: essiv - Handle lskcipher spawns
2023-10-13 18:27:26 +08:00
fcrypt.c
crypto: Prepare to move crypto_tfm_ctx
2022-12-02 18:12:40 +08:00
fips.c
crypto: fips - Remove the now superfluous sentinel element from ctl_table array
2024-04-05 15:46:33 +08:00
gcm.c
crypto: gcm - stop using alignmask of ahash
2023-10-27 18:04:29 +08:00
geniv.c
crypto: algapi - use common mechanism for inheriting flags
2020-07-16 21:49:08 +10:00
ghash-generic.c
crypto: remove CRYPTO_TFM_RES_BAD_KEY_LEN
2020-01-09 11:30:53 +08:00
hash_info.c
crypto: FIPS 202 SHA-3 register in hash info for IMA
2023-10-27 18:04:30 +08:00
hash.h
crypto: remove CONFIG_CRYPTO_STATS
2024-04-02 10:49:38 +08:00
hctr2.c
crypto: hctr2 - stop using alignmask of shash_alg
2023-10-27 18:04:25 +08:00
hmac.c
crypto: hmac - remove unnecessary alignment logic
2023-10-27 18:04:24 +08:00
internal.h
crypto: api - Do not wait for tests during registration
2024-08-24 21:39:15 +08:00
jitterentropy-kcapi.c
crypto: jitter - Use kvfree_sensitive() to fix Coccinelle warning
2024-04-05 15:46:33 +08:00
jitterentropy-testing.c
crypto: jitter - add interface for gathering of raw entropy
2023-05-12 18:48:01 +08:00
jitterentropy.c
crypto: jitter - Use min() to simplify jent_read_entropy()
2024-08-30 18:22:30 +08:00
jitterentropy.h
crypto: jitter - reuse allocated entropy collector
2023-10-13 18:31:07 +08:00
Kconfig
crypto: jitter - set default OSR to 3
2024-08-24 21:36:07 +08:00
kdf_sp800108.c
crypto: kdf - silence noisy self-test
2022-11-25 17:39:18 +08:00
keywrap.c
crypto: keywrap - Remove else after break statement
2021-04-02 18:28:13 +11:00
khazad.c
crypto: Prepare to move crypto_tfm_ctx
2022-12-02 18:12:40 +08:00
kpp.c
crypto: remove CONFIG_CRYPTO_STATS
2024-04-02 10:49:38 +08:00
lrw.c
crypto: lrw - Only access common skcipher fields on spawn
2023-10-13 18:27:27 +08:00
lskcipher.c
crypto: remove CONFIG_CRYPTO_STATS
2024-04-02 10:49:38 +08:00
lz4.c
Merge branch 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6
2019-07-08 20:57:08 -07:00
lz4hc.c
Merge branch 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6
2019-07-08 20:57:08 -07:00
lzo-rle.c
Merge branch 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6
2019-07-08 20:57:08 -07:00
lzo.c
Merge branch 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6
2019-07-08 20:57:08 -07:00
Makefile
crypto: sm2 - Remove sm2 algorithm
2024-06-07 19:46:39 +08:00
md4.c
crypto: make all generic algorithms set cra_driver_name
2019-06-13 14:31:39 +08:00
md5.c
crypto: md5 - remove unused macros
2020-02-28 08:43:21 +08:00
michael_mic.c
move asm/unaligned.h to linux/unaligned.h
2024-10-02 17:23:23 -04:00
nhpoly1305.c
move asm/unaligned.h to linux/unaligned.h
2024-10-02 17:23:23 -04:00
pcbc.c
crypto: pcbc - remove redundant assignment to nbytes
2024-01-26 16:39:32 +08:00
pcrypt.c
crypto: pcrypt - Call crypto layer directly when padata_do_parallel() return -EBUSY
2024-12-05 14:01:18 +01:00
poly1305_generic.c
move asm/unaligned.h to linux/unaligned.h
2024-10-02 17:23:23 -04:00
polyval-generic.c
move asm/unaligned.h to linux/unaligned.h
2024-10-02 17:23:23 -04:00
proc.c
crypto: proc - Print fips status
2023-02-14 13:39:33 +08:00
ripemd.h
crypto: rmd320 - remove RIPE-MD 320 hash algorithm
2021-01-29 16:07:04 +11:00
rmd160.c
Merge branch 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6
2019-07-08 20:57:08 -07:00
rng.c
crypto: remove CONFIG_CRYPTO_STATS
2024-04-02 10:49:38 +08:00
rsa_helper.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
rsa-pkcs1pad.c
crypto: rsa-pkcs1pad - Add FIPS 202 SHA-3 support
2023-10-27 18:04:30 +08:00
rsa.c
crypto: rsa - Check MPI allocation errors
2024-08-17 13:55:50 +08:00
rsaprivkey.asn1
treewide: Add SPDX identifier to IETF ASN.1 modules
2023-10-27 18:04:28 +08:00
rsapubkey.asn1
treewide: Add SPDX identifier to IETF ASN.1 modules
2023-10-27 18:04:28 +08:00
scatterwalk.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
scompress.c
crypto: remove CONFIG_CRYPTO_STATS
2024-04-02 10:49:38 +08:00
seed.c
crypto: Prepare to move crypto_tfm_ctx
2022-12-02 18:12:40 +08:00
seqiv.c
crypto: api - Use data directly in completion function
2023-02-13 18:35:14 +08:00
serpent_generic.c
move asm/unaligned.h to linux/unaligned.h
2024-10-02 17:23:23 -04:00
sha1_generic.c
crypto: sha - split sha.h into sha1.h and sha2.h
2020-11-20 14:45:33 +11:00
sha3_generic.c
move asm/unaligned.h to linux/unaligned.h
2024-10-02 17:23:23 -04:00
sha256_generic.c
move asm/unaligned.h to linux/unaligned.h
2024-10-02 17:23:23 -04:00
sha512_generic.c
move asm/unaligned.h to linux/unaligned.h
2024-10-02 17:23:23 -04:00
shash.c
crypto: remove CONFIG_CRYPTO_STATS
2024-04-02 10:49:38 +08:00
sig.c
crypto: remove CONFIG_CRYPTO_STATS
2024-04-02 10:49:38 +08:00
simd.c
crypto: simd - Do not call crypto_alloc_tfm during registration
2024-08-24 21:39:15 +08:00
skcipher.c
crypto: remove CONFIG_CRYPTO_STATS
2024-04-02 10:49:38 +08:00
skcipher.h
crypto: remove CONFIG_CRYPTO_STATS
2024-04-02 10:49:38 +08:00
sm3_generic.c
move asm/unaligned.h to linux/unaligned.h
2024-10-02 17:23:23 -04:00
sm3.c
move asm/unaligned.h to linux/unaligned.h
2024-10-02 17:23:23 -04:00
sm4_generic.c
move asm/unaligned.h to linux/unaligned.h
2024-10-02 17:23:23 -04:00
sm4.c
move asm/unaligned.h to linux/unaligned.h
2024-10-02 17:23:23 -04:00
streebog_generic.c
crypto: streebog - remove two unused variables
2019-08-15 21:52:14 +10:00
tcrypt.c
crypto: tcrypt - add skcipher speed for given alg
2024-06-28 11:35:46 +10:00
tcrypt.h
crypto: tcrypt - include larger key sizes in RFC4106 benchmark
2023-01-20 18:29:31 +08:00
tea.c
crypto: Prepare to move crypto_tfm_ctx
2022-12-02 18:12:40 +08:00
testmgr.c
crypto: testmgr - Hide ENOENT errors better
2024-10-10 17:03:35 +08:00
testmgr.h
crypto: sm2 - Remove sm2 algorithm
2024-06-07 19:46:39 +08:00
twofish_common.c
crypto: Prepare to move crypto_tfm_ctx
2022-12-02 18:12:40 +08:00
twofish_generic.c
move asm/unaligned.h to linux/unaligned.h
2024-10-02 17:23:23 -04:00
vmac.c
move asm/unaligned.h to linux/unaligned.h
2024-10-02 17:23:23 -04:00
wp512.c
crypto: wp512 - disable kmsan checks in wp512_process_buffer()
2022-12-30 22:56:27 +08:00
xcbc.c
crypto: xcbc - remove unnecessary alignment logic
2023-10-27 18:04:25 +08:00
xctr.c
crypto: xctr - Add XCTR support
2022-06-10 16:40:16 +08:00
xor.c
crypto: xor - fix template benchmarking
2024-08-02 20:53:25 +08:00
xts.c
crypto: xts - use 'spawn' for underlying single-block cipher
2023-10-20 13:39:25 +08:00
xxhash_generic.c
move asm/unaligned.h to linux/unaligned.h
2024-10-02 17:23:23 -04:00
zstd.c
lib: zstd: Add kernel-specific API
2021-11-08 16:55:21 -08:00