mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-12-28 16:56:26 +00:00
fe73965d07
By allowing the drivers to return a "const *" they can constify their static report arrays. This makes it clear to driver authors that the HID core will not modify those reports and they can be reused for multiple devices. Furthermore security is slightly improved as those reports are protected against accidental or malicious modifications. [bentiss: fixup hid-cougar.c and hid-multitouch.c for latest version of the master branch] Signed-off-by: Thomas Weißschuh <linux@weissschuh.net> Link: https://patch.msgid.link/20240803-hid-const-fixup-v2-6-f53d7a7b29d8@weissschuh.net Signed-off-by: Benjamin Tissoires <bentiss@kernel.org>
42 lines
1.1 KiB
C
42 lines
1.1 KiB
C
// SPDX-License-Identifier: GPL-2.0-or-later
|
|
/*
|
|
* HID driver for Semitek keyboards
|
|
*
|
|
* Copyright (c) 2021 Benjamin Moody
|
|
*/
|
|
|
|
#include <linux/device.h>
|
|
#include <linux/hid.h>
|
|
#include <linux/module.h>
|
|
|
|
#include "hid-ids.h"
|
|
|
|
static const __u8 *semitek_report_fixup(struct hid_device *hdev, __u8 *rdesc,
|
|
unsigned int *rsize)
|
|
{
|
|
/* In the report descriptor for interface 2, fix the incorrect
|
|
description of report ID 0x04 (the report contains a
|
|
bitmask, not an array of keycodes.) */
|
|
if (*rsize == 0xcb && rdesc[0x83] == 0x81 && rdesc[0x84] == 0x00) {
|
|
hid_info(hdev, "fixing up Semitek report descriptor\n");
|
|
rdesc[0x84] = 0x02;
|
|
}
|
|
return rdesc;
|
|
}
|
|
|
|
static const struct hid_device_id semitek_devices[] = {
|
|
{ HID_USB_DEVICE(USB_VENDOR_ID_SEMITEK, USB_DEVICE_ID_SEMITEK_KEYBOARD) },
|
|
{ }
|
|
};
|
|
MODULE_DEVICE_TABLE(hid, semitek_devices);
|
|
|
|
static struct hid_driver semitek_driver = {
|
|
.name = "semitek",
|
|
.id_table = semitek_devices,
|
|
.report_fixup = semitek_report_fixup,
|
|
};
|
|
module_hid_driver(semitek_driver);
|
|
|
|
MODULE_DESCRIPTION("HID driver for Semitek keyboards");
|
|
MODULE_LICENSE("GPL");
|