John Garry
0c028b6a11
scsi: scsi_debug: Abort commands from scsi_debug_device_reset() ...
Currently scsi_debug_device_reset() does not do much apart from setting the
SDEBUG_UA_POR ("Power on, reset, or bus device reset") flag, which is
eventually passed back to the SCSI midlayer later for a "unit attention"
command.
There is a report that blktest scsi/007 test fails due to commit
1107c7b24ee3 ("scsi: scsi_debug: Dynamically allocate sdebug_queued_cmd").
The problem there is that there are dangling scsi_debug queued commands
when we attempt to remove the driver.
scsi/007 test triggers SCSI EH and attempts to abort a timed-out command.
Function scsi_debug_device_reset() is called as part of the EH, but does
not deal with outstanding erroneous command. Prior to the named commit,
removing the driver caused all dangling queued commands to be stopped -
this should have not been necessary.
Fix by aborting outstanding commands on a scsi_device basis from
scsi_debug_device_reset().
Fixes: 1107c7b24ee3 ("scsi: scsi_debug: Dynamically allocate sdebug_queued_cmd")
Reported-by: kernel test robot <yujie.liu@intel.com>
Link: https://lore.kernel.org/oe-lkp/202304071111.e762fcbd-yujie.liu@intel.com
Signed-off-by: John Garry <john.g.garry@oracle.com>
Link: https://lore.kernel.org/r/20230416175654.159163-1-john.g.garry@oracle.com
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
2023-04-18 22:58:50 -04:00
2023-03-24 20:13:03 -04:00
2022-09-15 22:01:24 -04:00
2023-03-24 19:19:21 -04:00
2023-03-24 20:13:03 -04:00
2023-03-24 19:19:21 -04:00
2023-03-24 20:13:03 -04:00
2023-03-09 22:00:38 -05:00
2022-05-16 21:26:50 -04:00
2023-03-24 19:19:57 -04:00
2023-03-09 22:00:38 -05:00
2023-03-24 19:19:57 -04:00
2023-04-11 21:27:03 -04:00
2023-03-16 23:02:23 -04:00
2023-03-24 20:13:03 -04:00
2023-03-24 19:19:22 -04:00
2023-03-24 19:19:22 -04:00
2023-03-24 20:13:03 -04:00
2023-04-11 21:13:22 -04:00
2023-03-24 19:19:56 -04:00
2023-03-16 23:36:36 -04:00
2023-03-24 19:19:57 -04:00
2022-12-01 03:03:36 +00:00
2023-04-02 21:19:12 -04:00
2023-04-11 21:23:48 -04:00
2023-03-31 21:45:14 -04:00
2023-04-11 21:17:56 -04:00
2023-04-11 21:00:37 -04:00
2023-03-24 19:19:57 -04:00
2023-03-24 19:19:58 -04:00
2023-03-24 19:19:58 -04:00
2023-04-02 21:45:46 -04:00
2023-03-24 19:19:57 -04:00
2023-03-31 21:45:14 -04:00
2023-04-02 21:48:46 -04:00
2023-03-24 19:19:59 -04:00
2023-04-02 21:47:36 -04:00
2023-03-24 19:19:59 -04:00
2023-03-24 19:19:20 -04:00
2023-03-24 19:19:20 -04:00
2023-01-12 00:09:52 -05:00
2023-03-24 19:19:20 -04:00
2022-09-25 13:06:00 -04:00
2022-02-22 21:11:03 -05:00
2023-03-24 19:19:20 -04:00
2023-03-24 19:19:20 -04:00
2023-03-24 19:19:20 -04:00
2023-03-24 19:19:20 -04:00
2023-03-24 19:19:20 -04:00
2023-03-24 19:19:21 -04:00
2023-03-24 19:19:21 -04:00
2023-03-24 19:19:22 -04:00
2022-02-22 21:11:03 -05:00
2023-03-24 19:19:21 -04:00
2023-03-24 19:19:20 -04:00
2023-01-13 21:34:08 -05:00
2023-03-24 19:19:21 -04:00
2023-03-24 19:19:22 -04:00
2023-03-24 19:19:22 -04:00
2023-03-24 19:19:22 -04:00
2023-03-24 19:19:22 -04:00
2022-08-01 19:52:03 -04:00
2023-03-24 19:19:22 -04:00
2023-03-24 19:19:22 -04:00
2023-03-31 21:45:14 -04:00
2023-03-24 20:13:03 -04:00
2023-03-24 19:19:56 -04:00
2022-09-25 13:04:17 -04:00
2023-03-24 19:19:56 -04:00
2022-02-22 21:11:04 -05:00
2023-03-24 19:19:56 -04:00
2022-02-22 21:11:05 -05:00
2023-03-24 19:19:57 -04:00
2023-01-18 18:41:12 -05:00
2023-03-24 19:19:57 -04:00
2022-09-25 14:27:47 -04:00
2023-03-24 19:19:22 -04:00
2022-09-25 12:46:59 -04:00
2021-08-30 10:18:25 +02:00
2022-06-21 21:19:23 -04:00
2023-03-24 19:19:57 -04:00
2023-03-24 19:19:57 -04:00
2022-02-27 21:35:30 -05:00
2023-03-24 19:19:22 -04:00
2022-02-22 21:11:03 -05:00
2022-06-27 22:56:21 -04:00
2023-03-24 20:27:17 -04:00
2022-02-22 21:11:05 -05:00
2023-03-24 19:19:57 -04:00
2022-02-27 21:34:02 -05:00
2023-03-24 19:19:57 -04:00
2023-03-24 19:19:58 -04:00
2023-01-12 00:11:11 -05:00
2023-03-24 19:19:58 -04:00
2023-03-24 19:19:58 -04:00
2022-02-22 21:11:07 -05:00
2022-02-22 21:11:07 -05:00
2022-11-08 02:57:01 +00:00
2022-02-22 21:11:03 -05:00
2023-03-24 19:19:58 -04:00
2022-02-22 21:11:06 -05:00
2023-03-24 19:19:58 -04:00
2022-03-29 23:32:26 -04:00
2023-03-24 19:19:58 -04:00
2023-03-24 19:19:58 -04:00
2023-03-24 19:19:59 -04:00
2022-02-22 21:11:06 -05:00
2022-02-22 21:11:02 -05:00
2022-02-22 21:11:02 -05:00
2023-03-24 20:13:03 -04:00
2022-03-15 14:05:02 -04:00
2021-07-28 22:24:27 -04:00
2023-04-18 22:58:50 -04:00
2022-03-01 22:21:50 -05:00
2023-03-16 22:54:43 -04:00
2023-03-24 19:19:19 -04:00
2023-01-13 21:34:09 -05:00
2023-02-21 22:00:51 -05:00
2022-03-29 23:29:19 -04:00
2021-12-22 23:38:29 -05:00
2022-10-18 03:17:09 +00:00
2022-10-18 03:17:09 +00:00
2023-03-09 20:57:58 -05:00
2023-03-24 19:19:19 -04:00
2023-04-02 21:37:57 -04:00
2022-12-30 16:29:34 +00:00
2022-11-08 01:52:52 +00:00
2023-01-13 21:34:09 -05:00
2022-10-22 03:25:59 +00:00
2023-03-24 21:01:32 -04:00
2022-05-08 14:28:18 -04:00
2023-02-21 22:00:32 -05:00
2022-12-01 03:13:55 +00:00
2023-03-06 18:33:13 -05:00
2023-03-06 18:33:13 -05:00
2022-08-22 22:45:25 -04:00
2023-02-21 17:44:06 -05:00
2023-02-09 16:51:39 -08:00
2023-03-24 19:19:59 -04:00
2023-01-13 21:34:09 -05:00
2021-12-22 23:41:13 -05:00
2023-04-02 21:36:47 -04:00
2022-03-08 19:40:01 -07:00
2022-10-07 12:33:18 -07:00
2022-03-08 19:40:00 -07:00
2023-03-24 19:19:59 -04:00
2023-03-06 18:33:13 -05:00
2022-02-22 21:11:03 -05:00
2023-03-24 19:19:22 -04:00
2023-03-24 20:13:03 -04:00
2023-03-24 19:19:59 -04:00
2022-04-06 23:01:54 -04:00
2022-06-07 21:30:56 -04:00
2022-09-25 13:29:53 -04:00
2022-09-25 13:29:53 -04:00
2023-03-24 19:19:59 -04:00
2022-02-22 21:11:07 -05:00
2023-03-24 19:20:00 -04:00
2022-02-22 21:11:07 -05:00
2022-03-30 00:05:42 -04:00
2023-03-24 19:19:22 -04:00
0c028b6a11