Jan Kara f814bdda77 blk-wbt: Fix detection of dirty-throttled tasks
The detection of dirty-throttled tasks in blk-wbt has been subtly broken
since its beginning in 2016. Namely if we are doing cgroup writeback and
the throttled task is not in the root cgroup, balance_dirty_pages() will
set dirty_sleep for the non-root bdi_writeback structure. However
blk-wbt checks dirty_sleep only in the root cgroup bdi_writeback
structure. Thus detection of recently throttled tasks is not working in
this case (we noticed this when we switched to cgroup v2 and suddently
writeback was slow).

Since blk-wbt has no easy way to get to proper bdi_writeback and
furthermore its intention has always been to work on the whole device
rather than on individual cgroups, just move the dirty_sleep timestamp
from bdi_writeback to backing_dev_info. That fixes the checking for
recently throttled task and saves memory for everybody as a bonus.

CC: stable@vger.kernel.org
Fixes: b57d74aff9ab ("writeback: track if we're sleeping on progress in balance_dirty_pages()")
Signed-off-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20240123175826.21452-1-jack@suse.cz
[axboe: fixup indentation errors]
Signed-off-by: Jens Axboe <axboe@kernel.dk>
2024-02-06 09:44:03 -07:00
..
2024-01-12 15:20:45 -08:00
2024-01-17 13:03:37 -08:00
2024-01-19 09:10:23 -08:00
2023-12-12 10:11:32 +01:00
2024-01-18 15:16:57 -08:00
2024-01-10 16:43:55 -08:00
2023-04-12 17:36:23 -07:00
2024-01-10 08:45:22 -08:00
2024-01-17 13:03:37 -08:00
2022-10-03 14:02:43 -07:00
2024-01-11 10:07:29 -08:00
2024-01-10 16:43:55 -08:00
2023-06-23 16:59:30 -07:00
2024-01-10 16:43:55 -08:00
2023-04-12 17:36:23 -07:00