mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2025-01-06 05:06:29 +00:00
1af2dface5
syzbot reported use-after-free in unix_del_edges(). [0] What the repro does is basically repeat the following quickly. 1. pass a fd of an AF_UNIX socket to itself socketpair(AF_UNIX, SOCK_DGRAM, 0, [3, 4]) = 0 sendmsg(3, {..., msg_control=[{cmsg_len=20, cmsg_level=SOL_SOCKET, cmsg_type=SCM_RIGHTS, cmsg_data=[4]}], ...}, 0) = 0 2. pass other fds of AF_UNIX sockets to the socket above socketpair(AF_UNIX, SOCK_SEQPACKET, 0, [5, 6]) = 0 sendmsg(3, {..., msg_control=[{cmsg_len=48, cmsg_level=SOL_SOCKET, cmsg_type=SCM_RIGHTS, cmsg_data=[5, 6]}], ...}, 0) = 0 3. close all sockets Here, two skb are created, and every unix_edge->successor is the first socket. Then, __unix_gc() will garbage-collect the two skb: (a) free skb with self-referencing fd (b) free skb holding other sockets After (a), the self-referencing socket will be scheduled to be freed later by the delayed_fput() task. syzbot repeated the sequences above (1. ~ 3.) quickly and triggered the task concurrently while GC was running. So, at (b), the socket was already freed, and accessing it was illegal. unix_del_edges() accesses the receiver socket as edge->successor to optimise GC. However, we should not do it during GC. Garbage-collecting sockets does not change the shape of the rest of the graph, so we need not call unix_update_graph() to update unix_graph_grouped when we purge skb. However, if we clean up all loops in the unix_walk_scc_fast() path, unix_graph_maybe_cyclic remains unchanged (true), and __unix_gc() will call unix_walk_scc_fast() continuously even though there is no socket to garbage-collect. To keep that optimisation while fixing UAF, let's add the same updating logic of unix_graph_maybe_cyclic in unix_walk_scc_fast() as done in unix_walk_scc() and __unix_walk_scc(). Note that when unix_del_edges() is called from other places, the receiver socket is always alive: - sendmsg: the successor's sk_refcnt is bumped by sock_hold() unix_find_other() for SOCK_DGRAM, connect() for SOCK_STREAM - recvmsg: the successor is the receiver, and its fd is alive [0]: BUG: KASAN: slab-use-after-free in unix_edge_successor net/unix/garbage.c:109 [inline] BUG: KASAN: slab-use-after-free in unix_del_edge net/unix/garbage.c:165 [inline] BUG: KASAN: slab-use-after-free in unix_del_edges+0x148/0x630 net/unix/garbage.c:237 Read of size 8 at addr ffff888079c6e640 by task kworker/u8:6/1099 CPU: 0 PID: 1099 Comm: kworker/u8:6 Not tainted 6.9.0-rc4-next-20240418-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/27/2024 Workqueue: events_unbound __unix_gc Call Trace: <TASK> __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x241/0x360 lib/dump_stack.c:114 print_address_description mm/kasan/report.c:377 [inline] print_report+0x169/0x550 mm/kasan/report.c:488 kasan_report+0x143/0x180 mm/kasan/report.c:601 unix_edge_successor net/unix/garbage.c:109 [inline] unix_del_edge net/unix/garbage.c:165 [inline] unix_del_edges+0x148/0x630 net/unix/garbage.c:237 unix_destroy_fpl+0x59/0x210 net/unix/garbage.c:298 unix_detach_fds net/unix/af_unix.c:1811 [inline] unix_destruct_scm+0x13e/0x210 net/unix/af_unix.c:1826 skb_release_head_state+0x100/0x250 net/core/skbuff.c:1127 skb_release_all net/core/skbuff.c:1138 [inline] __kfree_skb net/core/skbuff.c:1154 [inline] kfree_skb_reason+0x16d/0x3b0 net/core/skbuff.c:1190 __skb_queue_purge_reason include/linux/skbuff.h:3251 [inline] __skb_queue_purge include/linux/skbuff.h:3256 [inline] __unix_gc+0x1732/0x1830 net/unix/garbage.c:575 process_one_work kernel/workqueue.c:3218 [inline] process_scheduled_works+0xa2c/0x1830 kernel/workqueue.c:3299 worker_thread+0x86d/0xd70 kernel/workqueue.c:3380 kthread+0x2f0/0x390 kernel/kthread.c:389 ret_from_fork+0x4b/0x80 arch/x86/kernel/process.c:147 ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244 </TASK> Allocated by task 14427: kasan_save_stack mm/kasan/common.c:47 [inline] kasan_save_track+0x3f/0x80 mm/kasan/common.c:68 unpoison_slab_object mm/kasan/common.c:312 [inline] __kasan_slab_alloc+0x66/0x80 mm/kasan/common.c:338 kasan_slab_alloc include/linux/kasan.h:201 [inline] slab_post_alloc_hook mm/slub.c:3897 [inline] slab_alloc_node mm/slub.c:3957 [inline] kmem_cache_alloc_noprof+0x135/0x290 mm/slub.c:3964 sk_prot_alloc+0x58/0x210 net/core/sock.c:2074 sk_alloc+0x38/0x370 net/core/sock.c:2133 unix_create1+0xb4/0x770 unix_create+0x14e/0x200 net/unix/af_unix.c:1034 __sock_create+0x490/0x920 net/socket.c:1571 sock_create net/socket.c:1622 [inline] __sys_socketpair+0x33e/0x720 net/socket.c:1773 __do_sys_socketpair net/socket.c:1822 [inline] __se_sys_socketpair net/socket.c:1819 [inline] __x64_sys_socketpair+0x9b/0xb0 net/socket.c:1819 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf5/0x240 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f Freed by task 1805: kasan_save_stack mm/kasan/common.c:47 [inline] kasan_save_track+0x3f/0x80 mm/kasan/common.c:68 kasan_save_free_info+0x40/0x50 mm/kasan/generic.c:579 poison_slab_object+0xe0/0x150 mm/kasan/common.c:240 __kasan_slab_free+0x37/0x60 mm/kasan/common.c:256 kasan_slab_free include/linux/kasan.h:184 [inline] slab_free_hook mm/slub.c:2190 [inline] slab_free mm/slub.c:4393 [inline] kmem_cache_free+0x145/0x340 mm/slub.c:4468 sk_prot_free net/core/sock.c:2114 [inline] __sk_destruct+0x467/0x5f0 net/core/sock.c:2208 sock_put include/net/sock.h:1948 [inline] unix_release_sock+0xa8b/0xd20 net/unix/af_unix.c:665 unix_release+0x91/0xc0 net/unix/af_unix.c:1049 __sock_release net/socket.c:659 [inline] sock_close+0xbc/0x240 net/socket.c:1421 __fput+0x406/0x8b0 fs/file_table.c:422 delayed_fput+0x59/0x80 fs/file_table.c:445 process_one_work kernel/workqueue.c:3218 [inline] process_scheduled_works+0xa2c/0x1830 kernel/workqueue.c:3299 worker_thread+0x86d/0xd70 kernel/workqueue.c:3380 kthread+0x2f0/0x390 kernel/kthread.c:389 ret_from_fork+0x4b/0x80 arch/x86/kernel/process.c:147 ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244 The buggy address belongs to the object at ffff888079c6e000 which belongs to the cache UNIX of size 1920 The buggy address is located 1600 bytes inside of freed 1920-byte region [ffff888079c6e000, ffff888079c6e780) Reported-by: syzbot+f3f3eef1d2100200e593@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=f3f3eef1d2100200e593 Fixes:77e5593aeb
("af_unix: Skip GC if no cycle exists.") Fixes:fd86344823
("af_unix: Try not to hold unix_gc_lock during accept().") Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com> Link: https://lore.kernel.org/r/20240419235102.31707-1-kuniyu@amazon.com Signed-off-by: Paolo Abeni <pabeni@redhat.com>
620 lines
16 KiB
C
620 lines
16 KiB
C
// SPDX-License-Identifier: GPL-2.0-or-later
|
|
/*
|
|
* NET3: Garbage Collector For AF_UNIX sockets
|
|
*
|
|
* Garbage Collector:
|
|
* Copyright (C) Barak A. Pearlmutter.
|
|
*
|
|
* Chopped about by Alan Cox 22/3/96 to make it fit the AF_UNIX socket problem.
|
|
* If it doesn't work blame me, it worked when Barak sent it.
|
|
*
|
|
* Assumptions:
|
|
*
|
|
* - object w/ a bit
|
|
* - free list
|
|
*
|
|
* Current optimizations:
|
|
*
|
|
* - explicit stack instead of recursion
|
|
* - tail recurse on first born instead of immediate push/pop
|
|
* - we gather the stuff that should not be killed into tree
|
|
* and stack is just a path from root to the current pointer.
|
|
*
|
|
* Future optimizations:
|
|
*
|
|
* - don't just push entire root set; process in place
|
|
*
|
|
* Fixes:
|
|
* Alan Cox 07 Sept 1997 Vmalloc internal stack as needed.
|
|
* Cope with changing max_files.
|
|
* Al Viro 11 Oct 1998
|
|
* Graph may have cycles. That is, we can send the descriptor
|
|
* of foo to bar and vice versa. Current code chokes on that.
|
|
* Fix: move SCM_RIGHTS ones into the separate list and then
|
|
* skb_free() them all instead of doing explicit fput's.
|
|
* Another problem: since fput() may block somebody may
|
|
* create a new unix_socket when we are in the middle of sweep
|
|
* phase. Fix: revert the logic wrt MARKED. Mark everything
|
|
* upon the beginning and unmark non-junk ones.
|
|
*
|
|
* [12 Oct 1998] AAARGH! New code purges all SCM_RIGHTS
|
|
* sent to connect()'ed but still not accept()'ed sockets.
|
|
* Fixed. Old code had slightly different problem here:
|
|
* extra fput() in situation when we passed the descriptor via
|
|
* such socket and closed it (descriptor). That would happen on
|
|
* each unix_gc() until the accept(). Since the struct file in
|
|
* question would go to the free list and might be reused...
|
|
* That might be the reason of random oopses on filp_close()
|
|
* in unrelated processes.
|
|
*
|
|
* AV 28 Feb 1999
|
|
* Kill the explicit allocation of stack. Now we keep the tree
|
|
* with root in dummy + pointer (gc_current) to one of the nodes.
|
|
* Stack is represented as path from gc_current to dummy. Unmark
|
|
* now means "add to tree". Push == "make it a son of gc_current".
|
|
* Pop == "move gc_current to parent". We keep only pointers to
|
|
* parents (->gc_tree).
|
|
* AV 1 Mar 1999
|
|
* Damn. Added missing check for ->dead in listen queues scanning.
|
|
*
|
|
* Miklos Szeredi 25 Jun 2007
|
|
* Reimplement with a cycle collecting algorithm. This should
|
|
* solve several problems with the previous code, like being racy
|
|
* wrt receive and holding up unrelated socket operations.
|
|
*/
|
|
|
|
#include <linux/kernel.h>
|
|
#include <linux/string.h>
|
|
#include <linux/socket.h>
|
|
#include <linux/un.h>
|
|
#include <linux/net.h>
|
|
#include <linux/fs.h>
|
|
#include <linux/skbuff.h>
|
|
#include <linux/netdevice.h>
|
|
#include <linux/file.h>
|
|
#include <linux/proc_fs.h>
|
|
#include <linux/mutex.h>
|
|
#include <linux/wait.h>
|
|
|
|
#include <net/sock.h>
|
|
#include <net/af_unix.h>
|
|
#include <net/scm.h>
|
|
#include <net/tcp_states.h>
|
|
|
|
struct unix_sock *unix_get_socket(struct file *filp)
|
|
{
|
|
struct inode *inode = file_inode(filp);
|
|
|
|
/* Socket ? */
|
|
if (S_ISSOCK(inode->i_mode) && !(filp->f_mode & FMODE_PATH)) {
|
|
struct socket *sock = SOCKET_I(inode);
|
|
const struct proto_ops *ops;
|
|
struct sock *sk = sock->sk;
|
|
|
|
ops = READ_ONCE(sock->ops);
|
|
|
|
/* PF_UNIX ? */
|
|
if (sk && ops && ops->family == PF_UNIX)
|
|
return unix_sk(sk);
|
|
}
|
|
|
|
return NULL;
|
|
}
|
|
|
|
static struct unix_vertex *unix_edge_successor(struct unix_edge *edge)
|
|
{
|
|
/* If an embryo socket has a fd,
|
|
* the listener indirectly holds the fd's refcnt.
|
|
*/
|
|
if (edge->successor->listener)
|
|
return unix_sk(edge->successor->listener)->vertex;
|
|
|
|
return edge->successor->vertex;
|
|
}
|
|
|
|
static bool unix_graph_maybe_cyclic;
|
|
static bool unix_graph_grouped;
|
|
|
|
static void unix_update_graph(struct unix_vertex *vertex)
|
|
{
|
|
/* If the receiver socket is not inflight, no cyclic
|
|
* reference could be formed.
|
|
*/
|
|
if (!vertex)
|
|
return;
|
|
|
|
unix_graph_maybe_cyclic = true;
|
|
unix_graph_grouped = false;
|
|
}
|
|
|
|
static LIST_HEAD(unix_unvisited_vertices);
|
|
|
|
enum unix_vertex_index {
|
|
UNIX_VERTEX_INDEX_MARK1,
|
|
UNIX_VERTEX_INDEX_MARK2,
|
|
UNIX_VERTEX_INDEX_START,
|
|
};
|
|
|
|
static unsigned long unix_vertex_unvisited_index = UNIX_VERTEX_INDEX_MARK1;
|
|
|
|
static void unix_add_edge(struct scm_fp_list *fpl, struct unix_edge *edge)
|
|
{
|
|
struct unix_vertex *vertex = edge->predecessor->vertex;
|
|
|
|
if (!vertex) {
|
|
vertex = list_first_entry(&fpl->vertices, typeof(*vertex), entry);
|
|
vertex->index = unix_vertex_unvisited_index;
|
|
vertex->out_degree = 0;
|
|
INIT_LIST_HEAD(&vertex->edges);
|
|
INIT_LIST_HEAD(&vertex->scc_entry);
|
|
|
|
list_move_tail(&vertex->entry, &unix_unvisited_vertices);
|
|
edge->predecessor->vertex = vertex;
|
|
}
|
|
|
|
vertex->out_degree++;
|
|
list_add_tail(&edge->vertex_entry, &vertex->edges);
|
|
|
|
unix_update_graph(unix_edge_successor(edge));
|
|
}
|
|
|
|
static bool gc_in_progress;
|
|
|
|
static void unix_del_edge(struct scm_fp_list *fpl, struct unix_edge *edge)
|
|
{
|
|
struct unix_vertex *vertex = edge->predecessor->vertex;
|
|
|
|
if (!gc_in_progress)
|
|
unix_update_graph(unix_edge_successor(edge));
|
|
|
|
list_del(&edge->vertex_entry);
|
|
vertex->out_degree--;
|
|
|
|
if (!vertex->out_degree) {
|
|
edge->predecessor->vertex = NULL;
|
|
list_move_tail(&vertex->entry, &fpl->vertices);
|
|
}
|
|
}
|
|
|
|
static void unix_free_vertices(struct scm_fp_list *fpl)
|
|
{
|
|
struct unix_vertex *vertex, *next_vertex;
|
|
|
|
list_for_each_entry_safe(vertex, next_vertex, &fpl->vertices, entry) {
|
|
list_del(&vertex->entry);
|
|
kfree(vertex);
|
|
}
|
|
}
|
|
|
|
static DEFINE_SPINLOCK(unix_gc_lock);
|
|
unsigned int unix_tot_inflight;
|
|
|
|
void unix_add_edges(struct scm_fp_list *fpl, struct unix_sock *receiver)
|
|
{
|
|
int i = 0, j = 0;
|
|
|
|
spin_lock(&unix_gc_lock);
|
|
|
|
if (!fpl->count_unix)
|
|
goto out;
|
|
|
|
do {
|
|
struct unix_sock *inflight = unix_get_socket(fpl->fp[j++]);
|
|
struct unix_edge *edge;
|
|
|
|
if (!inflight)
|
|
continue;
|
|
|
|
edge = fpl->edges + i++;
|
|
edge->predecessor = inflight;
|
|
edge->successor = receiver;
|
|
|
|
unix_add_edge(fpl, edge);
|
|
} while (i < fpl->count_unix);
|
|
|
|
receiver->scm_stat.nr_unix_fds += fpl->count_unix;
|
|
WRITE_ONCE(unix_tot_inflight, unix_tot_inflight + fpl->count_unix);
|
|
out:
|
|
WRITE_ONCE(fpl->user->unix_inflight, fpl->user->unix_inflight + fpl->count);
|
|
|
|
spin_unlock(&unix_gc_lock);
|
|
|
|
fpl->inflight = true;
|
|
|
|
unix_free_vertices(fpl);
|
|
}
|
|
|
|
void unix_del_edges(struct scm_fp_list *fpl)
|
|
{
|
|
struct unix_sock *receiver;
|
|
int i = 0;
|
|
|
|
spin_lock(&unix_gc_lock);
|
|
|
|
if (!fpl->count_unix)
|
|
goto out;
|
|
|
|
do {
|
|
struct unix_edge *edge = fpl->edges + i++;
|
|
|
|
unix_del_edge(fpl, edge);
|
|
} while (i < fpl->count_unix);
|
|
|
|
if (!gc_in_progress) {
|
|
receiver = fpl->edges[0].successor;
|
|
receiver->scm_stat.nr_unix_fds -= fpl->count_unix;
|
|
}
|
|
WRITE_ONCE(unix_tot_inflight, unix_tot_inflight - fpl->count_unix);
|
|
out:
|
|
WRITE_ONCE(fpl->user->unix_inflight, fpl->user->unix_inflight - fpl->count);
|
|
|
|
spin_unlock(&unix_gc_lock);
|
|
|
|
fpl->inflight = false;
|
|
}
|
|
|
|
void unix_update_edges(struct unix_sock *receiver)
|
|
{
|
|
/* nr_unix_fds is only updated under unix_state_lock().
|
|
* If it's 0 here, the embryo socket is not part of the
|
|
* inflight graph, and GC will not see it, so no lock needed.
|
|
*/
|
|
if (!receiver->scm_stat.nr_unix_fds) {
|
|
receiver->listener = NULL;
|
|
} else {
|
|
spin_lock(&unix_gc_lock);
|
|
unix_update_graph(unix_sk(receiver->listener)->vertex);
|
|
receiver->listener = NULL;
|
|
spin_unlock(&unix_gc_lock);
|
|
}
|
|
}
|
|
|
|
int unix_prepare_fpl(struct scm_fp_list *fpl)
|
|
{
|
|
struct unix_vertex *vertex;
|
|
int i;
|
|
|
|
if (!fpl->count_unix)
|
|
return 0;
|
|
|
|
for (i = 0; i < fpl->count_unix; i++) {
|
|
vertex = kmalloc(sizeof(*vertex), GFP_KERNEL);
|
|
if (!vertex)
|
|
goto err;
|
|
|
|
list_add(&vertex->entry, &fpl->vertices);
|
|
}
|
|
|
|
fpl->edges = kvmalloc_array(fpl->count_unix, sizeof(*fpl->edges),
|
|
GFP_KERNEL_ACCOUNT);
|
|
if (!fpl->edges)
|
|
goto err;
|
|
|
|
return 0;
|
|
|
|
err:
|
|
unix_free_vertices(fpl);
|
|
return -ENOMEM;
|
|
}
|
|
|
|
void unix_destroy_fpl(struct scm_fp_list *fpl)
|
|
{
|
|
if (fpl->inflight)
|
|
unix_del_edges(fpl);
|
|
|
|
kvfree(fpl->edges);
|
|
unix_free_vertices(fpl);
|
|
}
|
|
|
|
static bool unix_vertex_dead(struct unix_vertex *vertex)
|
|
{
|
|
struct unix_edge *edge;
|
|
struct unix_sock *u;
|
|
long total_ref;
|
|
|
|
list_for_each_entry(edge, &vertex->edges, vertex_entry) {
|
|
struct unix_vertex *next_vertex = unix_edge_successor(edge);
|
|
|
|
/* The vertex's fd can be received by a non-inflight socket. */
|
|
if (!next_vertex)
|
|
return false;
|
|
|
|
/* The vertex's fd can be received by an inflight socket in
|
|
* another SCC.
|
|
*/
|
|
if (next_vertex->scc_index != vertex->scc_index)
|
|
return false;
|
|
}
|
|
|
|
/* No receiver exists out of the same SCC. */
|
|
|
|
edge = list_first_entry(&vertex->edges, typeof(*edge), vertex_entry);
|
|
u = edge->predecessor;
|
|
total_ref = file_count(u->sk.sk_socket->file);
|
|
|
|
/* If not close()d, total_ref > out_degree. */
|
|
if (total_ref != vertex->out_degree)
|
|
return false;
|
|
|
|
return true;
|
|
}
|
|
|
|
enum unix_recv_queue_lock_class {
|
|
U_RECVQ_LOCK_NORMAL,
|
|
U_RECVQ_LOCK_EMBRYO,
|
|
};
|
|
|
|
static void unix_collect_skb(struct list_head *scc, struct sk_buff_head *hitlist)
|
|
{
|
|
struct unix_vertex *vertex;
|
|
|
|
list_for_each_entry_reverse(vertex, scc, scc_entry) {
|
|
struct sk_buff_head *queue;
|
|
struct unix_edge *edge;
|
|
struct unix_sock *u;
|
|
|
|
edge = list_first_entry(&vertex->edges, typeof(*edge), vertex_entry);
|
|
u = edge->predecessor;
|
|
queue = &u->sk.sk_receive_queue;
|
|
|
|
spin_lock(&queue->lock);
|
|
|
|
if (u->sk.sk_state == TCP_LISTEN) {
|
|
struct sk_buff *skb;
|
|
|
|
skb_queue_walk(queue, skb) {
|
|
struct sk_buff_head *embryo_queue = &skb->sk->sk_receive_queue;
|
|
|
|
/* listener -> embryo order, the inversion never happens. */
|
|
spin_lock_nested(&embryo_queue->lock, U_RECVQ_LOCK_EMBRYO);
|
|
skb_queue_splice_init(embryo_queue, hitlist);
|
|
spin_unlock(&embryo_queue->lock);
|
|
}
|
|
} else {
|
|
skb_queue_splice_init(queue, hitlist);
|
|
|
|
#if IS_ENABLED(CONFIG_AF_UNIX_OOB)
|
|
if (u->oob_skb) {
|
|
kfree_skb(u->oob_skb);
|
|
u->oob_skb = NULL;
|
|
}
|
|
#endif
|
|
}
|
|
|
|
spin_unlock(&queue->lock);
|
|
}
|
|
}
|
|
|
|
static bool unix_scc_cyclic(struct list_head *scc)
|
|
{
|
|
struct unix_vertex *vertex;
|
|
struct unix_edge *edge;
|
|
|
|
/* SCC containing multiple vertices ? */
|
|
if (!list_is_singular(scc))
|
|
return true;
|
|
|
|
vertex = list_first_entry(scc, typeof(*vertex), scc_entry);
|
|
|
|
/* Self-reference or a embryo-listener circle ? */
|
|
list_for_each_entry(edge, &vertex->edges, vertex_entry) {
|
|
if (unix_edge_successor(edge) == vertex)
|
|
return true;
|
|
}
|
|
|
|
return false;
|
|
}
|
|
|
|
static LIST_HEAD(unix_visited_vertices);
|
|
static unsigned long unix_vertex_grouped_index = UNIX_VERTEX_INDEX_MARK2;
|
|
|
|
static void __unix_walk_scc(struct unix_vertex *vertex, unsigned long *last_index,
|
|
struct sk_buff_head *hitlist)
|
|
{
|
|
LIST_HEAD(vertex_stack);
|
|
struct unix_edge *edge;
|
|
LIST_HEAD(edge_stack);
|
|
|
|
next_vertex:
|
|
/* Push vertex to vertex_stack and mark it as on-stack
|
|
* (index >= UNIX_VERTEX_INDEX_START).
|
|
* The vertex will be popped when finalising SCC later.
|
|
*/
|
|
list_add(&vertex->scc_entry, &vertex_stack);
|
|
|
|
vertex->index = *last_index;
|
|
vertex->scc_index = *last_index;
|
|
(*last_index)++;
|
|
|
|
/* Explore neighbour vertices (receivers of the current vertex's fd). */
|
|
list_for_each_entry(edge, &vertex->edges, vertex_entry) {
|
|
struct unix_vertex *next_vertex = unix_edge_successor(edge);
|
|
|
|
if (!next_vertex)
|
|
continue;
|
|
|
|
if (next_vertex->index == unix_vertex_unvisited_index) {
|
|
/* Iterative deepening depth first search
|
|
*
|
|
* 1. Push a forward edge to edge_stack and set
|
|
* the successor to vertex for the next iteration.
|
|
*/
|
|
list_add(&edge->stack_entry, &edge_stack);
|
|
|
|
vertex = next_vertex;
|
|
goto next_vertex;
|
|
|
|
/* 2. Pop the edge directed to the current vertex
|
|
* and restore the ancestor for backtracking.
|
|
*/
|
|
prev_vertex:
|
|
edge = list_first_entry(&edge_stack, typeof(*edge), stack_entry);
|
|
list_del_init(&edge->stack_entry);
|
|
|
|
next_vertex = vertex;
|
|
vertex = edge->predecessor->vertex;
|
|
|
|
/* If the successor has a smaller scc_index, two vertices
|
|
* are in the same SCC, so propagate the smaller scc_index
|
|
* to skip SCC finalisation.
|
|
*/
|
|
vertex->scc_index = min(vertex->scc_index, next_vertex->scc_index);
|
|
} else if (next_vertex->index != unix_vertex_grouped_index) {
|
|
/* Loop detected by a back/cross edge.
|
|
*
|
|
* The successor is on vertex_stack, so two vertices are in
|
|
* the same SCC. If the successor has a smaller *scc_index*,
|
|
* propagate it to skip SCC finalisation.
|
|
*/
|
|
vertex->scc_index = min(vertex->scc_index, next_vertex->scc_index);
|
|
} else {
|
|
/* The successor was already grouped as another SCC */
|
|
}
|
|
}
|
|
|
|
if (vertex->index == vertex->scc_index) {
|
|
struct list_head scc;
|
|
bool scc_dead = true;
|
|
|
|
/* SCC finalised.
|
|
*
|
|
* If the scc_index was not updated, all the vertices above on
|
|
* vertex_stack are in the same SCC. Group them using scc_entry.
|
|
*/
|
|
__list_cut_position(&scc, &vertex_stack, &vertex->scc_entry);
|
|
|
|
list_for_each_entry_reverse(vertex, &scc, scc_entry) {
|
|
/* Don't restart DFS from this vertex in unix_walk_scc(). */
|
|
list_move_tail(&vertex->entry, &unix_visited_vertices);
|
|
|
|
/* Mark vertex as off-stack. */
|
|
vertex->index = unix_vertex_grouped_index;
|
|
|
|
if (scc_dead)
|
|
scc_dead = unix_vertex_dead(vertex);
|
|
}
|
|
|
|
if (scc_dead)
|
|
unix_collect_skb(&scc, hitlist);
|
|
else if (!unix_graph_maybe_cyclic)
|
|
unix_graph_maybe_cyclic = unix_scc_cyclic(&scc);
|
|
|
|
list_del(&scc);
|
|
}
|
|
|
|
/* Need backtracking ? */
|
|
if (!list_empty(&edge_stack))
|
|
goto prev_vertex;
|
|
}
|
|
|
|
static void unix_walk_scc(struct sk_buff_head *hitlist)
|
|
{
|
|
unsigned long last_index = UNIX_VERTEX_INDEX_START;
|
|
|
|
unix_graph_maybe_cyclic = false;
|
|
|
|
/* Visit every vertex exactly once.
|
|
* __unix_walk_scc() moves visited vertices to unix_visited_vertices.
|
|
*/
|
|
while (!list_empty(&unix_unvisited_vertices)) {
|
|
struct unix_vertex *vertex;
|
|
|
|
vertex = list_first_entry(&unix_unvisited_vertices, typeof(*vertex), entry);
|
|
__unix_walk_scc(vertex, &last_index, hitlist);
|
|
}
|
|
|
|
list_replace_init(&unix_visited_vertices, &unix_unvisited_vertices);
|
|
swap(unix_vertex_unvisited_index, unix_vertex_grouped_index);
|
|
|
|
unix_graph_grouped = true;
|
|
}
|
|
|
|
static void unix_walk_scc_fast(struct sk_buff_head *hitlist)
|
|
{
|
|
unix_graph_maybe_cyclic = false;
|
|
|
|
while (!list_empty(&unix_unvisited_vertices)) {
|
|
struct unix_vertex *vertex;
|
|
struct list_head scc;
|
|
bool scc_dead = true;
|
|
|
|
vertex = list_first_entry(&unix_unvisited_vertices, typeof(*vertex), entry);
|
|
list_add(&scc, &vertex->scc_entry);
|
|
|
|
list_for_each_entry_reverse(vertex, &scc, scc_entry) {
|
|
list_move_tail(&vertex->entry, &unix_visited_vertices);
|
|
|
|
if (scc_dead)
|
|
scc_dead = unix_vertex_dead(vertex);
|
|
}
|
|
|
|
if (scc_dead)
|
|
unix_collect_skb(&scc, hitlist);
|
|
else if (!unix_graph_maybe_cyclic)
|
|
unix_graph_maybe_cyclic = unix_scc_cyclic(&scc);
|
|
|
|
list_del(&scc);
|
|
}
|
|
|
|
list_replace_init(&unix_visited_vertices, &unix_unvisited_vertices);
|
|
}
|
|
|
|
static void __unix_gc(struct work_struct *work)
|
|
{
|
|
struct sk_buff_head hitlist;
|
|
|
|
spin_lock(&unix_gc_lock);
|
|
|
|
if (!unix_graph_maybe_cyclic) {
|
|
spin_unlock(&unix_gc_lock);
|
|
goto skip_gc;
|
|
}
|
|
|
|
__skb_queue_head_init(&hitlist);
|
|
|
|
if (unix_graph_grouped)
|
|
unix_walk_scc_fast(&hitlist);
|
|
else
|
|
unix_walk_scc(&hitlist);
|
|
|
|
spin_unlock(&unix_gc_lock);
|
|
|
|
__skb_queue_purge(&hitlist);
|
|
skip_gc:
|
|
WRITE_ONCE(gc_in_progress, false);
|
|
}
|
|
|
|
static DECLARE_WORK(unix_gc_work, __unix_gc);
|
|
|
|
void unix_gc(void)
|
|
{
|
|
WRITE_ONCE(gc_in_progress, true);
|
|
queue_work(system_unbound_wq, &unix_gc_work);
|
|
}
|
|
|
|
#define UNIX_INFLIGHT_TRIGGER_GC 16000
|
|
#define UNIX_INFLIGHT_SANE_USER (SCM_MAX_FD * 8)
|
|
|
|
void wait_for_unix_gc(struct scm_fp_list *fpl)
|
|
{
|
|
/* If number of inflight sockets is insane,
|
|
* force a garbage collect right now.
|
|
*
|
|
* Paired with the WRITE_ONCE() in unix_inflight(),
|
|
* unix_notinflight(), and __unix_gc().
|
|
*/
|
|
if (READ_ONCE(unix_tot_inflight) > UNIX_INFLIGHT_TRIGGER_GC &&
|
|
!READ_ONCE(gc_in_progress))
|
|
unix_gc();
|
|
|
|
/* Penalise users who want to send AF_UNIX sockets
|
|
* but whose sockets have not been received yet.
|
|
*/
|
|
if (!fpl || !fpl->count_unix ||
|
|
READ_ONCE(fpl->user->unix_inflight) < UNIX_INFLIGHT_SANE_USER)
|
|
return;
|
|
|
|
if (READ_ONCE(gc_in_progress))
|
|
flush_work(&unix_gc_work);
|
|
}
|