mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2025-01-18 03:06:43 +00:00
1f855c5e68
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Link: https://lore.kernel.org/r/91311e53e9432ae84d5720485c3b436fb7f06227.1709886922.git.u.kleine-koenig@pengutronix.de Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
113 lines
2.7 KiB
C
113 lines
2.7 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
// Copyright (c) 2023 Nuvoton Technology corporation.
|
|
|
|
#include <linux/module.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/pm_runtime.h>
|
|
#include <linux/usb/chipidea.h>
|
|
#include <linux/clk.h>
|
|
#include <linux/io.h>
|
|
#include <linux/reset-controller.h>
|
|
#include <linux/of.h>
|
|
|
|
#include "ci.h"
|
|
|
|
struct npcm_udc_data {
|
|
struct platform_device *ci;
|
|
struct clk *core_clk;
|
|
struct ci_hdrc_platform_data pdata;
|
|
};
|
|
|
|
static int npcm_udc_notify_event(struct ci_hdrc *ci, unsigned event)
|
|
{
|
|
struct device *dev = ci->dev->parent;
|
|
|
|
switch (event) {
|
|
case CI_HDRC_CONTROLLER_RESET_EVENT:
|
|
/* clear all mode bits */
|
|
hw_write(ci, OP_USBMODE, 0xffffffff, 0x0);
|
|
break;
|
|
default:
|
|
dev_dbg(dev, "unknown ci_hdrc event (%d)\n",event);
|
|
break;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int npcm_udc_probe(struct platform_device *pdev)
|
|
{
|
|
int ret;
|
|
struct npcm_udc_data *ci;
|
|
struct platform_device *plat_ci;
|
|
struct device *dev = &pdev->dev;
|
|
|
|
ci = devm_kzalloc(&pdev->dev, sizeof(*ci), GFP_KERNEL);
|
|
if (!ci)
|
|
return -ENOMEM;
|
|
platform_set_drvdata(pdev, ci);
|
|
|
|
ci->core_clk = devm_clk_get_optional(dev, NULL);
|
|
if (IS_ERR(ci->core_clk))
|
|
return PTR_ERR(ci->core_clk);
|
|
|
|
ret = clk_prepare_enable(ci->core_clk);
|
|
if (ret)
|
|
return dev_err_probe(dev, ret, "failed to enable the clock: %d\n", ret);
|
|
|
|
ci->pdata.name = dev_name(dev);
|
|
ci->pdata.capoffset = DEF_CAPOFFSET;
|
|
ci->pdata.flags = CI_HDRC_REQUIRES_ALIGNED_DMA |
|
|
CI_HDRC_FORCE_VBUS_ACTIVE_ALWAYS;
|
|
ci->pdata.phy_mode = USBPHY_INTERFACE_MODE_UTMI;
|
|
ci->pdata.notify_event = npcm_udc_notify_event;
|
|
|
|
plat_ci = ci_hdrc_add_device(dev, pdev->resource, pdev->num_resources,
|
|
&ci->pdata);
|
|
if (IS_ERR(plat_ci)) {
|
|
ret = PTR_ERR(plat_ci);
|
|
dev_err(dev, "failed to register HDRC NPCM device: %d\n", ret);
|
|
goto clk_err;
|
|
}
|
|
|
|
pm_runtime_no_callbacks(dev);
|
|
pm_runtime_enable(dev);
|
|
|
|
return 0;
|
|
|
|
clk_err:
|
|
clk_disable_unprepare(ci->core_clk);
|
|
return ret;
|
|
}
|
|
|
|
static void npcm_udc_remove(struct platform_device *pdev)
|
|
{
|
|
struct npcm_udc_data *ci = platform_get_drvdata(pdev);
|
|
|
|
pm_runtime_disable(&pdev->dev);
|
|
ci_hdrc_remove_device(ci->ci);
|
|
clk_disable_unprepare(ci->core_clk);
|
|
}
|
|
|
|
static const struct of_device_id npcm_udc_dt_match[] = {
|
|
{ .compatible = "nuvoton,npcm750-udc", },
|
|
{ .compatible = "nuvoton,npcm845-udc", },
|
|
{ }
|
|
};
|
|
MODULE_DEVICE_TABLE(of, npcm_udc_dt_match);
|
|
|
|
static struct platform_driver npcm_udc_driver = {
|
|
.probe = npcm_udc_probe,
|
|
.remove_new = npcm_udc_remove,
|
|
.driver = {
|
|
.name = "npcm_udc",
|
|
.of_match_table = npcm_udc_dt_match,
|
|
},
|
|
};
|
|
|
|
module_platform_driver(npcm_udc_driver);
|
|
|
|
MODULE_DESCRIPTION("NPCM USB device controller driver");
|
|
MODULE_AUTHOR("Tomer Maimon <tomer.maimon@nuvoton.com>");
|
|
MODULE_LICENSE("GPL v2");
|