mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2025-01-07 13:43:51 +00:00
c9ead908d7
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Link: https://lore.kernel.org/r/20231031222851.3126434-19-u.kleine-koenig@pengutronix.de Signed-off-by: Georgi Djakov <djakov@kernel.org>
95 lines
2.2 KiB
C
95 lines
2.2 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
/*
|
|
* RPM over SMD communication wrapper for interconnects
|
|
*
|
|
* Copyright (C) 2019 Linaro Ltd
|
|
* Author: Georgi Djakov <georgi.djakov@linaro.org>
|
|
*/
|
|
|
|
#include <linux/interconnect-provider.h>
|
|
#include <linux/module.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/soc/qcom/smd-rpm.h>
|
|
|
|
#include "icc-rpm.h"
|
|
|
|
#define RPM_KEY_BW 0x00007762
|
|
#define QCOM_RPM_SMD_KEY_RATE 0x007a484b
|
|
|
|
static struct qcom_smd_rpm *icc_smd_rpm;
|
|
|
|
struct icc_rpm_smd_req {
|
|
__le32 key;
|
|
__le32 nbytes;
|
|
__le32 value;
|
|
};
|
|
|
|
bool qcom_icc_rpm_smd_available(void)
|
|
{
|
|
return !!icc_smd_rpm;
|
|
}
|
|
EXPORT_SYMBOL_GPL(qcom_icc_rpm_smd_available);
|
|
|
|
int qcom_icc_rpm_smd_send(int ctx, int rsc_type, int id, u32 val)
|
|
{
|
|
struct icc_rpm_smd_req req = {
|
|
.key = cpu_to_le32(RPM_KEY_BW),
|
|
.nbytes = cpu_to_le32(sizeof(u32)),
|
|
.value = cpu_to_le32(val),
|
|
};
|
|
|
|
return qcom_rpm_smd_write(icc_smd_rpm, ctx, rsc_type, id, &req,
|
|
sizeof(req));
|
|
}
|
|
EXPORT_SYMBOL_GPL(qcom_icc_rpm_smd_send);
|
|
|
|
int qcom_icc_rpm_set_bus_rate(const struct rpm_clk_resource *clk, int ctx, u32 rate)
|
|
{
|
|
struct clk_smd_rpm_req req = {
|
|
.key = cpu_to_le32(QCOM_RPM_SMD_KEY_RATE),
|
|
.nbytes = cpu_to_le32(sizeof(u32)),
|
|
};
|
|
|
|
/* Branch clocks are only on/off */
|
|
if (clk->branch)
|
|
rate = !!rate;
|
|
|
|
req.value = cpu_to_le32(rate);
|
|
return qcom_rpm_smd_write(icc_smd_rpm,
|
|
ctx,
|
|
clk->resource_type,
|
|
clk->clock_id,
|
|
&req, sizeof(req));
|
|
}
|
|
EXPORT_SYMBOL_GPL(qcom_icc_rpm_set_bus_rate);
|
|
|
|
static void qcom_icc_rpm_smd_remove(struct platform_device *pdev)
|
|
{
|
|
icc_smd_rpm = NULL;
|
|
}
|
|
|
|
static int qcom_icc_rpm_smd_probe(struct platform_device *pdev)
|
|
{
|
|
icc_smd_rpm = dev_get_drvdata(pdev->dev.parent);
|
|
|
|
if (!icc_smd_rpm) {
|
|
dev_err(&pdev->dev, "unable to retrieve handle to RPM\n");
|
|
return -ENODEV;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static struct platform_driver qcom_interconnect_rpm_smd_driver = {
|
|
.driver = {
|
|
.name = "icc_smd_rpm",
|
|
},
|
|
.probe = qcom_icc_rpm_smd_probe,
|
|
.remove_new = qcom_icc_rpm_smd_remove,
|
|
};
|
|
module_platform_driver(qcom_interconnect_rpm_smd_driver);
|
|
MODULE_AUTHOR("Georgi Djakov <georgi.djakov@linaro.org>");
|
|
MODULE_DESCRIPTION("Qualcomm SMD RPM interconnect proxy driver");
|
|
MODULE_LICENSE("GPL v2");
|
|
MODULE_ALIAS("platform:icc_smd_rpm");
|