Oleg Nesterov
4e0621a07e
exec: don't retry if request_module() fails ...
A separate one-liner for better documentation.
It doesn't make sense to retry if request_module() fails to exec
/sbin/modprobe, add the additional "request_module() < 0" check.
However, this logic still doesn't look exactly right:
1. It would be better to check "request_module() != 0", the user
space modprobe process should report the correct exit code.
But I didn't dare to add the user-visible change.
2. The whole ENOEXEC logic looks suboptimal. Suppose that we try
to exec a "#!path-to-unsupported-binary" script. In this case
request_module() + "retry" will be done twice: first by the
"depth == 1" code, and then again by the "depth == 0" caller
which doesn't make sense.
3. And note that in the case above bprm->buf was already changed
by load_script()->prepare_binprm(), so this looks even more
ugly.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Kees Cook <keescook@chromium.org>
Cc: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Evgeniy Polyakov <zbr@ioremap.net>
Cc: Zach Levis <zml@linux.vnet.ibm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2013-09-11 15:59:07 -07:00
2013-07-11 10:21:23 -07:00
2013-06-29 12:57:36 +04:00
2013-06-29 12:57:36 +04:00
2013-09-07 19:54:55 -04:00
2013-09-08 22:07:47 -04:00
2013-06-29 12:56:55 +04:00
2013-08-24 12:10:22 -04:00
2013-09-06 09:36:28 -07:00
2013-09-06 09:17:30 +01:00
2013-09-06 12:55:29 -07:00
2013-09-04 09:23:46 -04:00
2013-07-05 18:59:33 +04:00
2013-07-14 11:42:26 -07:00
2013-06-29 12:56:46 +04:00
2013-07-31 12:16:31 -04:00
2013-03-07 01:08:55 -08:00
2013-08-12 15:22:43 -05:00
2013-07-11 10:20:18 -07:00
2013-07-14 17:48:35 +04:00
2013-08-24 12:10:22 -04:00
2013-07-02 09:39:34 -07:00
2013-09-07 19:54:55 -04:00
2013-06-29 12:57:10 +04:00
2013-09-06 09:06:02 -07:00
2013-09-06 09:36:28 -07:00
2013-09-05 13:50:32 +09:00
2013-07-09 10:33:25 -07:00
2013-06-29 12:56:53 +04:00
2013-09-06 09:17:30 +01:00
2013-09-11 15:58:04 -07:00
2013-09-09 09:16:51 -07:00
2013-06-29 12:57:36 +04:00
2013-09-11 15:59:01 -07:00
2013-09-07 10:38:29 +02:00
2013-07-04 11:22:55 -07:00
2013-07-03 16:07:41 -07:00
2013-08-24 12:10:17 -04:00
2013-07-31 22:14:50 +02:00
2013-08-09 10:49:00 +02:00
2013-08-28 14:59:58 -04:00
2013-06-29 12:56:47 +04:00
2013-08-15 17:22:29 -05:00
2013-08-05 15:03:46 -04:00
2013-07-02 09:39:34 -07:00
2013-06-29 12:57:35 +04:00
2013-07-09 10:33:25 -07:00
2013-09-09 09:19:15 -07:00
2013-02-13 06:15:14 -08:00
2013-09-10 20:04:59 -07:00
2013-09-05 08:50:26 -07:00
2013-07-09 10:33:20 -07:00
2013-07-02 09:39:34 -07:00
2013-09-11 15:56:53 -07:00
2013-06-29 12:56:37 +04:00
2013-06-29 12:56:32 +04:00
2013-09-11 15:59:03 -07:00
2013-08-30 15:57:01 -07:00
2013-06-29 12:56:38 +04:00
2013-06-29 12:56:39 +04:00
2013-09-09 11:19:09 -07:00
2013-02-26 20:16:07 -08:00
2013-09-06 09:06:02 -07:00
2013-06-29 12:56:29 +04:00
2013-06-29 12:56:28 +04:00
2013-09-07 14:36:57 -07:00
2013-06-29 12:57:36 +04:00
2013-07-05 12:08:47 -07:00
2013-07-31 22:14:51 +02:00
2013-06-29 12:46:47 +04:00
2013-09-09 11:19:09 -07:00
2013-07-03 16:08:06 -07:00
2013-02-26 02:46:11 -05:00
2012-11-20 04:17:24 -08:00
2013-06-29 12:57:04 +04:00
2013-07-10 18:11:34 -07:00
2013-05-02 10:16:16 -07:00
2013-07-10 18:11:34 -07:00
2012-12-17 17:15:23 -08:00
2013-04-29 15:40:23 -04:00
2013-04-30 17:04:03 -07:00
2012-12-20 17:40:19 -08:00
2012-11-28 21:53:38 -05:00
2013-09-11 15:58:21 -07:00
2013-09-03 18:25:03 -07:00
2013-09-04 09:23:46 -04:00
2013-07-03 16:07:29 -07:00
2012-10-22 08:50:37 +03:00
2012-10-06 03:05:17 +09:00
2013-06-29 12:46:44 +04:00
2013-06-29 12:57:05 +04:00
2013-09-11 15:59:01 -07:00
2012-10-06 03:05:15 +09:00
2013-09-10 12:44:24 -07:00
2013-03-03 23:00:23 -05:00
2013-09-09 10:47:42 -07:00
2012-12-17 17:15:27 -08:00
2013-09-11 15:58:50 -07:00
2013-09-11 15:59:07 -07:00
2013-08-05 18:25:32 +04:00
2012-12-20 14:04:11 -08:00
2013-09-11 15:59:01 -07:00
2013-05-01 17:31:42 -04:00
2013-03-03 19:36:31 -08:00
2013-03-01 23:51:07 -05:00
2013-09-11 15:58:13 -07:00
2012-09-18 01:01:35 -07:00
2013-09-03 22:52:45 -04:00
2013-09-08 20:20:21 -04:00
2013-02-22 23:31:31 -05:00
2013-04-17 13:25:09 +01:00
2013-04-30 17:04:04 -07:00
2013-07-14 17:43:25 +04:00
2013-07-08 13:36:42 +04:00
2013-05-01 17:51:54 -07:00
2013-04-09 14:12:52 -04:00
2013-09-10 12:44:24 -07:00
2013-09-08 20:20:21 -04:00
2013-09-07 14:35:32 -07:00
2013-05-07 20:16:25 -07:00
2013-05-31 15:16:33 -04:00
2013-08-26 18:42:15 -07:00
2012-09-18 01:01:35 -07:00
2013-07-03 16:23:27 +04:00
2013-06-29 12:57:05 +04:00
2013-07-10 17:08:27 -07:00
2013-07-08 13:36:41 +04:00
2013-03-03 22:58:46 -05:00
2013-07-03 09:10:19 -07:00
2013-08-17 09:32:32 -04:00
2012-12-20 18:50:07 -05:00
2013-09-07 19:54:56 -04:00
2013-03-03 22:46:22 -05:00
2013-05-29 12:57:34 -07:00
2012-12-20 18:50:08 -05:00
2012-10-12 13:16:48 -07:00
2012-12-20 18:50:11 -05:00
4e0621a07e