Kernel/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2025-01-17 02:36:21 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
linux-stable/fs
History
Miklos Szeredi 4ed5e82fe7 vfs: protect remounting superblock read-only 
Currently remouting superblock read-only is racy in a major way.

With the per mount read-only infrastructure it is now possible to
prevent most races, which this patch attempts.

Before starting the remount read-only, iterate through all mounts
belonging to the superblock and if none of them have any pending
writes, set sb->s_readonly_remount.  This indicates that remount is in
progress and no further write requests are allowed.  If the remount
succeeds set MS_RDONLY and reset s_readonly_remount.

If the remounting is unsuccessful just reset s_readonly_remount.
This can result in transient EROFS errors, despite the fact the
remount failed.  Unfortunately hodling off writes is difficult as
remount itself may touch the filesystem (e.g. through load_nls())
which would deadlock.

A later patch deals with delayed writes due to nlink going to zero.

Signed-off-by: Miklos Szeredi <mszeredi@suse.cz>
Tested-by: Toshiyuki Okajima <toshi.okajima@jp.fujitsu.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2012-01-06 23:20:12 -05:00
..
9p
9p: propagate umode_t
2012-01-03 22:55:01 -05:00
adfs
vfs: switch ->show_options() to struct dentry *
2012-01-06 23:19:54 -05:00
affs
affs: propagate umode_t
2012-01-03 22:55:04 -05:00
afs
switch ->create() to umode_t
2012-01-03 22:54:53 -05:00
autofs4
vfs: switch ->show_options() to struct dentry *
2012-01-06 23:19:54 -05:00
befs
vfs: fix the stupidity with i_dentry in inode destructors
2012-01-03 22:52:40 -05:00
bfs
switch ->create() to umode_t
2012-01-03 22:54:53 -05:00
btrfs
vfs: switch ->show_options() to struct dentry *
2012-01-06 23:19:54 -05:00
cachefiles
fs: move code out of buffer.c
2012-01-03 22:54:07 -05:00
ceph
vfs: switch ->show_options() to struct dentry *
2012-01-06 23:19:54 -05:00
cifs
vfs: switch ->show_options() to struct dentry *
2012-01-06 23:19:54 -05:00
coda
switch ->create() to umode_t
2012-01-03 22:54:53 -05:00
configfs
configfs: convert to umode_t
2012-01-03 22:54:57 -05:00
cramfs
Merge branches 'vfsmount-guts', 'umode_t' and 'partitions' into Z
2012-01-06 23:15:54 -05:00
debugfs
switch debugfs to umode_t
2012-01-03 22:54:56 -05:00
devpts
vfs: switch ->show_options() to struct dentry *
2012-01-06 23:19:54 -05:00
dlm
Merge branch 'for-3.1' of git://linux-nfs.org/~bfields/linux
2011-07-25 22:49:19 -07:00
ecryptfs
vfs: switch ->show_options() to struct dentry *
2012-01-06 23:19:54 -05:00
efs
vfs: fix the stupidity with i_dentry in inode destructors
2012-01-03 22:52:40 -05:00
exofs
exofs: propagate umode_t
2012-01-03 22:55:05 -05:00
exportfs
vfs: Add open by file handle support
2011-03-15 02:21:44 -04:00
ext2
vfs: switch ->show_options() to struct dentry *
2012-01-06 23:19:54 -05:00
ext3
vfs: switch ->show_options() to struct dentry *
2012-01-06 23:19:54 -05:00
ext4
vfs: switch ->show_options() to struct dentry *
2012-01-06 23:19:54 -05:00
fat
vfs: switch ->show_options() to struct dentry *
2012-01-06 23:19:54 -05:00
freevxfs
fs: propagate umode_t, misc bits
2012-01-03 22:55:10 -05:00
fscache
FS-Cache: Fix __fscache_uncache_all_inode_pages()'s outer loop
2011-07-21 10:59:16 -07:00
fuse
vfs: switch ->show_options() to struct dentry *
2012-01-06 23:19:54 -05:00
gfs2
vfs: switch ->show_options() to struct dentry *
2012-01-06 23:19:54 -05:00
hfs
vfs: switch ->show_options() to struct dentry *
2012-01-06 23:19:54 -05:00
hfsplus
vfs: switch ->show_options() to struct dentry *
2012-01-06 23:19:54 -05:00
hostfs
vfs: switch ->show_options() to struct dentry *
2012-01-06 23:19:54 -05:00
hpfs
switch ->mknod() to umode_t
2012-01-03 22:54:54 -05:00
hppfs
vfs: for usbfs, etc. internal vfsmounts ->mnt_sb->s_root == ->mnt_root
2012-01-03 22:52:41 -05:00
hugetlbfs
hugetlbfs: propagate umode_t
2012-01-03 22:55:05 -05:00
isofs
isofs: propagate umode_t
2012-01-03 22:55:08 -05:00
jbd
jbd/jbd2: validate sb->s_first in journal_get_superblock()
2011-11-01 19:04:59 -04:00
jbd2
jbd2: Unify log messages in jbd2 code
2011-11-01 19:09:18 -04:00
jffs2
vfs: switch ->show_options() to struct dentry *
2012-01-06 23:19:54 -05:00
jfs
vfs: switch ->show_options() to struct dentry *
2012-01-06 23:19:54 -05:00
lockd
vfs: prefer ->dentry->d_sb to ->mnt->mnt_sb
2012-01-06 23:16:53 -05:00
logfs
logfs: propagate umode_t
2012-01-03 22:55:06 -05:00
minix
minix: propagate umode_t
2012-01-03 22:54:59 -05:00
ncpfs
vfs: switch ->show_options() to struct dentry *
2012-01-06 23:19:54 -05:00
nfs
vfs: switch ->show_options() to struct dentry *
2012-01-06 23:19:54 -05:00
nfs_common
Fix common misspellings
2011-03-31 11:26:23 -03:00
nfsd
vfs: prefer ->dentry->d_sb to ->mnt->mnt_sb
2012-01-06 23:16:53 -05:00
nilfs2
vfs: switch ->show_options() to struct dentry *
2012-01-06 23:19:54 -05:00
nls
…
notify
vfs: move fsnotify junk to struct mount
2012-01-03 22:57:12 -05:00
ntfs
vfs: switch ->show_options() to struct dentry *
2012-01-06 23:19:54 -05:00
ocfs2
vfs: switch ->show_options() to struct dentry *
2012-01-06 23:19:54 -05:00
omfs
omfs: propagate umode_t
2012-01-03 22:55:01 -05:00
openpromfs
vfs: fix the stupidity with i_dentry in inode destructors
2012-01-03 22:52:40 -05:00
proc
Merge branches 'vfsmount-guts', 'umode_t' and 'partitions' into Z
2012-01-06 23:15:54 -05:00
pstore
pstore: pass allocated memory region back to caller
2011-11-17 12:58:07 -08:00
qnx4
vfs: fix the stupidity with i_dentry in inode destructors
2012-01-03 22:52:40 -05:00
quota
vfs: prefer ->dentry->d_sb to ->mnt->mnt_sb
2012-01-06 23:16:53 -05:00
ramfs
pohmelfs: propagate umode_t
2012-01-03 22:55:07 -05:00
reiserfs
vfs: prefer ->dentry->d_sb to ->mnt->mnt_sb
2012-01-06 23:16:53 -05:00
romfs
vfs: fix the stupidity with i_dentry in inode destructors
2012-01-03 22:52:40 -05:00
squashfs
vfs: fix the stupidity with i_dentry in inode destructors
2012-01-03 22:52:40 -05:00
sysfs
sysfs: propagate umode_t
2012-01-03 22:55:03 -05:00
sysv
vfs: prefer ->dentry->d_sb to ->mnt->mnt_sb
2012-01-06 23:16:53 -05:00
ubifs
vfs: switch ->show_options() to struct dentry *
2012-01-06 23:19:54 -05:00
udf
vfs: switch ->show_options() to struct dentry *
2012-01-06 23:19:54 -05:00
ufs
vfs: switch ->show_options() to struct dentry *
2012-01-06 23:19:54 -05:00
xfs
vfs: switch ->show_options() to struct dentry *
2012-01-06 23:19:54 -05:00
aio.c
aio: allocate kiocbs in batches
2011-11-02 16:07:03 -07:00
anon_inodes.c
vfs: dont chain pipe/anon/socket on superblock s_inodes list
2011-07-26 12:57:09 -04:00
attr.c
switch is_sxid() to umode_t
2012-01-03 22:55:11 -05:00
bad_inode.c
switch ->mknod() to umode_t
2012-01-03 22:54:54 -05:00
binfmt_aout.c
…
binfmt_elf_fdpic.c
consolidate BINPRM_FLAGS_ENFORCE_NONDUMP handling
2011-07-20 01:43:10 -04:00
binfmt_elf.c
binfmt_elf: fix PIE execution with randomization disabled
2011-11-02 16:06:58 -07:00
binfmt_em86.c
…
binfmt_flat.c
CRED: Fix load_flat_shared_library() to initialise bprm correctly
2011-05-03 10:10:51 +10:00
binfmt_misc.c
vfs: prefer ->dentry->d_sb to ->mnt->mnt_sb
2012-01-06 23:16:53 -05:00
binfmt_script.c
…
binfmt_som.c
…
bio-integrity.c
fs: add export.h to files using EXPORT_SYMBOL/THIS_MODULE macros
2011-10-31 19:30:31 -04:00
bio.c
bio: change some signed vars to unsigned
2011-11-16 09:21:50 +01:00
block_dev.c
fs: move code out of buffer.c
2012-01-03 22:54:07 -05:00
buffer.c
fs: move code out of buffer.c
2012-01-03 22:54:07 -05:00
char_dev.c
Merge branch 'for-2.6.38/core' of git://git.kernel.dk/linux-2.6-block
2011-01-13 10:45:01 -08:00
compat_binfmt_elf.c
…
compat_ioctl.c
compat_ioctl: add compat handler for PPPIOCGL2TPSTATS
2011-08-07 22:24:41 -07:00
compat.c
switch open and mkdir syscalls to umode_t
2012-01-03 22:55:19 -05:00
dcache.c
vfs: mnt_ns moved to struct mount
2012-01-03 22:57:09 -05:00
dcookies.c
oprofile, dcookies: Fix possible circular locking dependency
2011-05-31 16:33:35 +02:00
direct-io.c
direct-io: merge direct_io_walker into __blockdev_direct_IO
2011-10-28 14:58:58 +02:00
drop_caches.c
vmscan: change shrinker API by passing shrink_control struct
2011-05-25 08:39:26 -07:00
eventfd.c
Docbook: add fs/eventfd.c and fix typos in it
2011-02-21 15:07:04 -08:00
eventpoll.c
epoll: fix spurious lockdep warnings
2011-10-31 17:30:57 -07:00
exec.c
trim fs/internal.h
2012-01-03 22:52:35 -05:00
fcntl.c
userns: rename is_owner_or_cap to inode_owner_or_capable
2011-03-23 19:47:13 -07:00
fhandle.c
vfs: prefer ->dentry->d_sb to ->mnt->mnt_sb
2012-01-06 23:16:53 -05:00
fifo.c
Filesystem: fifo: Fixed coding style issue.
2011-03-21 00:16:09 -04:00
file_table.c
atomic: use <linux/atomic.h>
2011-07-26 16:49:47 -07:00
file.c
vfs: avoid large kmalloc()s for the fdtable
2011-04-28 11:28:20 -07:00
filesystems.c
vfs: convert fs_supers to hlist
2012-01-03 22:52:39 -05:00
fs_struct.c
sanitize vfsmount refcounting changes
2011-01-16 13:47:07 -05:00
fs-writeback.c
fs: move code out of buffer.c
2012-01-03 22:54:07 -05:00
generic_acl.c
switch posix_acl_equiv_mode() to umode_t *
2011-08-01 02:10:06 -04:00
inode.c
switch inode_init_owner() to umode_t
2012-01-03 22:55:11 -05:00
internal.h
vfs: protect remounting superblock read-only
2012-01-06 23:20:12 -05:00
ioctl.c
vfs: cleanup do_vfs_ioctl()
2011-03-21 00:16:08 -04:00
ioprio.c
fs: add export.h to files using EXPORT_SYMBOL/THIS_MODULE macros
2011-10-31 19:30:31 -04:00
Kconfig
move fs/partitions to block/
2012-01-03 22:54:06 -05:00
Kconfig.binfmt
…
libfs.c
fs: move code out of buffer.c
2012-01-03 22:54:07 -05:00
locks.c
vfs: fix handling of lock allocation failure in lease-break case
2011-12-26 10:25:26 -08:00
Makefile
Merge branches 'vfsmount-guts', 'umode_t' and 'partitions' into Z
2012-01-06 23:15:54 -05:00
mbcache.c
vmscan: change shrinker API by passing shrink_control struct
2011-05-25 08:39:26 -07:00
mount.h
vfs: keep list of mounts for each superblock
2012-01-06 23:20:12 -05:00
mpage.c
mm/fs: add hooks to support cleancache
2011-05-26 10:01:43 -06:00
namei.c
Merge branches 'vfsmount-guts', 'umode_t' and 'partitions' into Z
2012-01-06 23:15:54 -05:00
namespace.c
vfs: protect remounting superblock read-only
2012-01-06 23:20:12 -05:00
no-block.c
…
open.c
switch security_path_chmod() to struct path *
2012-01-06 23:16:53 -05:00
pipe.c
vfs: pipe.c is really non-modular
2012-01-03 22:52:41 -05:00
pnode.c
vfs: switch pnode.h macros to struct mount *
2012-01-03 22:57:11 -05:00
pnode.h
vfs: switch pnode.h macros to struct mount *
2012-01-03 22:57:11 -05:00
posix_acl.c
vfs: pass all mask flags check_acl and posix_acl_permission
2011-10-28 14:58:54 +02:00
proc_namespace.c
vfs: switch ->show_options() to struct dentry *
2012-01-06 23:19:54 -05:00
read_write.c
Cross Memory Attach
2011-10-31 17:30:44 -07:00
read_write.h
…
readdir.c
…
select.c
select: remove unused MAX_SELECT_SECONDS
2011-03-21 00:16:08 -04:00
seq_file.c
constify seq_file stuff
2012-01-03 22:52:40 -05:00
signalfd.c
…
splice.c
fs: move code out of buffer.c
2012-01-03 22:54:07 -05:00
stack.c
filesystems: add set_nlink()
2011-11-02 12:53:43 +01:00
stat.c
readlinkat: ensure we return ENOENT for the empty pathname for normal lookups
2011-11-02 12:53:42 +01:00
statfs.c
vfs: new helper - vfs_ustat()
2012-01-03 22:53:07 -05:00
super.c
vfs: protect remounting superblock read-only
2012-01-06 23:20:12 -05:00
sync.c
fs: move code out of buffer.c
2012-01-03 22:54:07 -05:00
timerfd.c
timerfd: Fix wakeup of processes when timer is cancelled on clock change
2011-06-14 11:46:14 +02:00
utimes.c
userns: rename is_owner_or_cap to inode_owner_or_capable
2011-03-23 19:47:13 -07:00
xattr_acl.c
…
xattr.c
vfs: mnt_drop_write_file()
2012-01-03 22:52:40 -05:00