Phil Sutter 70b6f46a4e netfilter: ipset: Fix for recursive locking warning
With CONFIG_PROVE_LOCKING, when creating a set of type bitmap:ip, adding
it to a set of type list:set and populating it from iptables SET target
triggers a kernel warning:

| WARNING: possible recursive locking detected
| 6.12.0-rc7-01692-g5e9a28f41134-dirty #594 Not tainted
| --------------------------------------------
| ping/4018 is trying to acquire lock:
| ffff8881094a6848 (&set->lock){+.-.}-{2:2}, at: ip_set_add+0x28c/0x360 [ip_set]
|
| but task is already holding lock:
| ffff88811034c048 (&set->lock){+.-.}-{2:2}, at: ip_set_add+0x28c/0x360 [ip_set]

This is a false alarm: ipset does not allow nested list:set type, so the
loop in list_set_kadd() can never encounter the outer set itself. No
other set type supports embedded sets, so this is the only case to
consider.

To avoid the false report, create a distinct lock class for list:set
type ipset locks.

Fixes: f830837f0eed ("netfilter: ipset: list:set set type support")
Signed-off-by: Phil Sutter <phil@nwl.cc>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
2024-12-19 00:28:47 +01:00
..
2024-11-11 10:32:06 -08:00
2024-10-04 12:42:32 +01:00
2024-06-14 19:08:50 -07:00
2024-10-08 15:33:49 -07:00
2024-10-15 18:52:26 -07:00
2024-12-10 18:44:25 -08:00
2024-11-21 08:28:08 -08:00
2024-12-10 18:44:25 -08:00
2024-11-18 11:52:49 +00:00
2024-10-10 08:30:21 -07:00
2024-10-08 15:16:59 +02:00
2024-10-10 08:30:21 -07:00
2024-11-21 08:28:08 -08:00