Oleg Nesterov
fb4214db50
llist: fix/simplify llist_add() and llist_add_batch()
...
1. This is mostly theoretical, but llist_add*() need ACCESS_ONCE().
Otherwise it is not guaranteed that the first cmpxchg() uses the
same value for old_entry and new_last->next.
2. These helpers cache the result of cmpxchg() and read the initial
value of head->first before the main loop. I do not think this
makes sense. In the likely case cmpxchg() succeeds, otherwise
it doesn't hurt to reload head->first.
I think it would be better to simplify the code and simply read
->first before cmpxchg().
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Andrey Vagin <avagin@openvz.org>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: David Howells <dhowells@redhat.com>
Cc: Huang Ying <ying.huang@intel.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2013-07-13 13:29:24 +04:00
..
2013-06-28 10:28:22 +02:00
2013-02-20 19:36:01 +01:00
2013-06-12 16:29:44 -07:00
2012-12-13 19:51:04 +11:00
2008-04-18 22:17:17 -04:00
2013-03-13 15:21:48 -07:00
2011-03-22 17:44:17 -07:00
2010-03-12 15:52:44 -08:00
2012-10-08 13:50:18 +10:30
2013-04-29 18:28:19 -07:00
2012-12-19 07:55:08 -08:00
2012-07-30 17:25:16 -07:00
2012-12-20 13:50:16 -08:00
2011-05-04 14:41:28 -04:00
2012-03-07 15:04:04 -05:00
2012-09-10 11:13:16 -07:00
2011-03-11 14:25:50 +00:00
2012-12-06 10:39:54 +01:00
2008-06-06 11:29:10 -07:00
2012-03-07 15:04:04 -05:00
2012-06-07 14:43:55 -07:00
2013-01-21 17:17:57 +10:30
2013-06-19 17:54:06 +02:00
2013-03-22 16:41:20 -07:00
2012-03-07 15:04:04 -05:00
2013-02-11 20:00:33 +05:30
2012-02-02 10:34:23 +11:00
2012-03-07 15:04:04 -05:00
2011-10-29 21:20:22 +02:00
2013-01-11 14:54:54 -08:00
2012-07-30 17:25:22 -07:00
2012-12-11 17:22:28 -08:00
2007-07-17 10:23:04 -07:00
2011-06-03 15:01:06 -04:00
2012-10-06 03:04:46 +09:00
2012-03-23 16:58:38 -07:00
2008-07-12 08:22:32 -05:00
2012-03-07 15:04:04 -05:00
2013-06-26 12:10:56 +02:00
2013-02-27 19:10:24 -08:00
2012-03-07 15:04:04 -05:00
2011-12-06 10:00:05 +01:00
2011-01-13 08:03:25 -08:00
2011-12-06 09:53:40 +01:00
2013-02-20 19:36:00 +01:00
2011-03-31 11:26:23 -03:00
2013-04-30 17:04:09 -07:00
2013-02-27 19:10:09 -08:00
2013-02-21 08:18:12 -08:00
2013-04-30 19:13:05 +02:00
2013-03-22 16:41:20 -07:00
2013-07-03 16:07:41 -07:00
2013-04-30 17:04:03 -07:00
2012-05-31 18:18:17 -04:00
2012-09-30 18:02:20 -07:00
2009-06-12 21:47:04 +09:30
2013-06-03 13:55:01 -07:00
2012-07-23 13:54:52 +01:00
2012-07-23 13:54:52 +01:00
2012-07-23 13:54:52 +01:00
2012-07-23 13:54:52 +01:00
2012-07-23 13:54:52 +01:00
2012-07-23 13:54:52 +01:00
2012-03-07 15:04:04 -05:00
2012-03-07 15:04:04 -05:00
2012-03-07 15:04:04 -05:00
2012-09-25 08:59:21 -07:00
2012-10-06 03:04:57 +09:00
2012-10-06 03:04:46 +09:00
2013-04-29 18:28:13 -07:00
2012-03-07 15:04:04 -05:00
2013-01-17 12:19:09 -08:00
2012-03-07 15:04:04 -05:00
2013-07-03 16:08:04 -07:00
2010-08-12 09:51:35 -07:00
2013-04-29 18:28:19 -07:00
2012-12-17 17:15:26 -08:00
2012-10-09 16:22:40 +09:00
2012-03-07 15:04:04 -05:00
2012-03-07 15:04:04 -05:00
2012-03-24 10:24:31 -07:00
2012-03-07 15:04:04 -05:00
2013-05-20 10:24:22 +09:30
2012-03-07 15:04:04 -05:00
2009-07-17 09:11:31 +10:00
2012-05-02 00:04:06 -07:00
2012-10-11 08:50:15 +09:00
2013-07-03 11:12:08 -07:00
2013-07-04 11:25:51 -07:00
2013-06-18 13:48:45 +02:00
2009-07-01 22:28:44 +02:00
2013-02-27 19:10:23 -08:00
2013-05-21 10:16:39 -07:00
2012-09-08 18:46:30 -04:00
2013-06-07 16:05:50 -07:00
2012-12-17 17:15:22 -08:00
2011-10-31 17:30:56 -07:00
2012-03-07 15:04:04 -05:00
2008-12-25 11:01:42 +11:00
2012-07-06 06:01:49 -07:00
2013-04-29 18:28:42 -07:00
2013-07-13 13:29:24 +04:00
2013-06-26 12:10:59 +02:00
2013-03-22 22:17:36 -06:00
2013-07-03 11:12:08 -07:00
2012-03-07 15:04:04 -05:00
2012-07-30 17:25:22 -07:00
2012-07-30 17:25:16 -07:00
2013-06-05 12:00:27 -07:00
2012-08-30 13:11:46 -04:00
2013-04-09 14:13:05 -04:00
2012-07-30 17:25:22 -07:00
2012-12-14 10:32:52 +11:00
2013-05-05 14:38:00 -07:00
2013-02-21 17:22:25 -08:00
2012-01-31 23:19:47 +02:00
2013-07-03 16:07:43 -07:00
2013-06-16 16:12:26 -07:00
2012-12-17 17:15:18 -08:00
2012-10-06 03:04:58 +09:00
2012-07-30 17:25:22 -07:00
2009-01-06 15:59:11 -08:00
2011-09-13 11:11:50 +02:00
2012-06-05 10:46:40 -07:00
2012-12-17 17:15:26 -08:00
2012-03-07 15:04:04 -05:00
2012-05-17 15:18:37 +02:00
2013-04-30 17:04:07 -07:00
2013-01-11 14:54:56 -08:00
2011-12-08 19:52:43 -05:00
2013-05-07 07:20:16 -07:00
2013-05-07 16:11:51 -07:00
2013-03-27 17:13:44 +01:00
2012-03-07 15:04:04 -05:00
2013-04-29 15:54:28 -07:00
2012-03-07 15:04:04 -05:00
2009-01-08 08:31:14 -08:00
2012-10-06 03:04:57 +09:00
2012-04-20 23:27:08 +02:00
2013-04-30 17:04:03 -07:00
2012-03-24 10:24:31 -07:00
2012-05-26 11:33:40 -07:00
2012-05-27 20:59:46 -07:00
2013-04-17 12:35:32 -07:00
2012-03-07 15:04:04 -05:00
2012-05-29 16:22:32 -07:00
2013-04-30 17:04:03 -07:00
2011-01-24 23:33:30 -08:00
2012-03-24 10:24:31 -07:00
2008-07-08 02:37:54 -07:00
2008-07-08 02:38:27 -07:00
2008-07-08 02:38:09 -07:00
2013-04-15 21:23:03 +01:00
2013-04-30 17:04:09 -07:00
2013-04-29 18:28:42 -07:00
2013-05-29 01:14:46 +02:00