Asmaa Mnebhi
aad4183232
gpio: mlxbf3: Support shutdown() function
...
During Linux graceful reboot, the GPIO interrupts are not disabled.
Since the drivers are not removed during graceful reboot,
the logic to call mlxbf3_gpio_irq_disable() is not triggered.
Interrupts that remain enabled can cause issues on subsequent boots.
For example, the mlxbf-gige driver contains PHY logic to bring up the link.
If the gpio-mlxbf3 driver loads first, the mlxbf-gige driver
will use a GPIO interrupt to bring up the link.
Otherwise, it will use polling.
The next time Linux boots and loads the drivers in this order, we encounter the issue:
- mlxbf-gige loads first and uses polling while the GPIO10
interrupt is still enabled from the previous boot. So if
the interrupt triggers, there is nothing to clear it.
- gpio-mlxbf3 loads.
- i2c-mlxbf loads. The interrupt doesn't trigger for I2C
because it is shared with the GPIO interrupt line which
was not cleared.
The solution is to add a shutdown function to the GPIO driver to clear and disable
all interrupts. Also clear the interrupt after disabling it in mlxbf3_gpio_irq_disable().
Fixes: 38a700efc510 ("gpio: mlxbf3: Add gpio driver support")
Signed-off-by: Asmaa Mnebhi <asmaa@nvidia.com>
Reviewed-by: David Thompson <davthompson@nvidia.com>
Reviewed-by: Andy Shevchenko <andy@kernel.org>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/20240611171509.22151-1-asmaa@nvidia.com
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
2024-08-10 21:35:16 +02:00
..
2024-03-01 08:23:08 +01:00
2023-07-29 16:03:17 +02:00
2023-07-27 09:37:33 +02:00
2023-04-11 21:08:31 +02:00
2023-08-11 14:23:29 +02:00
2023-05-23 10:09:11 +02:00
2021-05-21 15:29:53 +02:00
2023-06-16 11:02:07 +02:00
2023-08-03 15:58:45 +02:00
2023-10-02 08:53:57 +02:00
2024-05-30 11:20:53 +02:00
2020-09-28 12:22:04 +02:00
2023-10-02 08:54:09 +02:00
2022-10-19 17:03:55 +03:00
2023-03-10 16:17:20 +01:00
2023-11-04 10:23:22 +01:00
2024-06-26 10:39:08 +02:00
2023-07-19 13:26:22 +02:00
2021-05-21 15:43:26 +02:00
2021-04-14 10:19:22 +01:00
2021-12-17 17:39:35 +01:00
2024-07-25 06:53:47 -05:00
2020-12-08 09:41:32 +01:00
2023-10-02 08:54:26 +02:00
2023-08-03 15:58:46 +02:00
2023-07-19 13:24:01 +02:00
2024-04-02 10:58:21 +02:00
2024-04-05 20:12:39 +03:00
2020-12-12 01:37:46 +01:00
2022-10-19 17:03:55 +03:00
2021-05-21 14:45:57 +02:00
2024-06-24 13:24:59 +02:00
2023-10-02 08:54:31 +02:00
2023-07-29 15:56:33 +02:00
2024-01-02 14:16:17 +01:00
2024-02-12 10:12:41 +01:00
2023-11-13 17:59:48 +02:00
2023-11-04 10:23:23 +01:00
2024-01-15 23:15:35 +01:00
2023-01-27 14:05:38 +01:00
2023-07-29 16:04:38 +02:00
2023-09-11 09:03:44 +02:00
2023-10-02 08:54:36 +02:00
2023-10-02 08:58:01 +02:00
2023-07-27 09:33:07 +02:00
2023-01-30 15:55:28 +01:00
2024-06-26 10:18:19 +02:00
2023-10-02 08:54:41 +02:00
2024-06-07 10:05:21 +02:00
2023-10-13 08:39:30 +02:00
2023-07-19 13:24:01 +02:00
2019-11-07 09:27:48 +01:00
2023-01-30 15:55:28 +01:00
2023-01-30 15:55:28 +01:00
2023-03-09 16:08:39 +02:00
2023-08-11 14:23:32 +02:00
2023-08-11 14:23:32 +02:00
2023-03-10 16:17:30 +01:00
2023-08-11 16:20:02 +02:00
2021-05-05 16:07:41 +02:00
2023-12-01 10:48:32 +01:00
2019-07-09 09:07:00 -07:00
2019-11-07 09:27:48 +01:00
2022-10-26 14:52:01 +02:00
2023-10-11 11:33:38 +02:00
2023-07-29 16:05:50 +02:00
2023-03-23 14:31:18 +01:00
2023-09-27 09:06:50 +02:00
2019-10-31 15:03:10 -07:00
2022-06-10 14:51:36 +02:00
2023-08-01 21:14:48 +02:00
2022-06-10 14:51:36 +02:00
2023-10-02 08:54:50 +02:00
2024-04-12 21:30:58 +02:00
2019-11-07 09:27:48 +01:00
2023-12-07 09:24:08 +01:00
2023-08-03 15:56:30 +02:00
2023-08-03 15:58:50 +02:00
2023-05-23 10:09:11 +02:00
2022-02-09 13:00:45 +00:00
2023-08-01 21:15:23 +02:00
2019-07-29 00:03:52 +02:00
2023-10-02 08:54:55 +02:00
2024-07-15 17:53:24 -07:00
2022-04-25 12:10:02 +02:00
2023-03-06 17:10:46 +02:00
2022-05-20 19:20:35 +02:00
2023-03-10 16:17:32 +01:00
2024-08-10 21:35:16 +02:00
2020-07-08 09:24:08 +02:00
2023-10-02 08:55:00 +02:00
2024-07-03 15:27:59 +02:00
2023-11-20 14:24:50 +01:00
2021-04-09 14:54:23 -07:00
2023-10-02 08:55:09 +02:00
2023-10-02 08:55:04 +02:00
2023-07-19 13:24:01 +02:00
2022-10-08 09:46:29 -07:00
2024-02-22 14:39:28 +01:00
2023-08-21 14:11:16 +02:00
2023-08-11 16:21:46 +02:00
2024-03-12 12:53:35 +01:00
2024-05-07 09:44:33 +02:00
2019-04-05 00:04:27 +07:00
2023-10-04 11:37:25 +02:00
2023-08-01 21:22:38 +02:00
2024-07-15 17:53:24 -07:00
2023-08-21 10:39:58 +02:00
2024-06-07 10:05:21 +02:00
2022-06-21 18:01:11 +03:00
2023-08-11 14:23:31 +02:00
2024-04-12 21:36:18 +02:00
2023-07-20 17:22:10 +02:00
2024-06-07 10:05:21 +02:00
2024-01-03 09:50:47 +01:00
2023-11-04 10:23:22 +01:00
2023-08-03 15:58:52 +02:00
2023-08-01 21:26:48 +02:00
2023-11-04 10:23:21 +01:00
2023-03-23 14:31:18 +01:00
2024-05-30 11:21:05 +02:00
2022-08-31 17:46:30 +02:00
2023-03-06 12:33:02 +02:00
2024-04-12 21:36:40 +02:00
2023-11-04 10:23:22 +01:00
2024-01-15 11:07:46 +01:00
2023-05-17 11:56:24 +02:00
2023-08-01 21:27:38 +02:00
2023-05-17 11:52:14 +02:00
2024-04-15 16:12:18 +03:00
2023-11-15 15:39:40 +01:00
2024-07-04 09:25:59 +02:00
2023-03-23 14:31:18 +01:00
2022-11-15 15:41:45 +01:00
2024-07-01 10:54:11 +02:00
2021-08-12 11:39:38 +01:00
2022-06-10 14:51:35 +02:00
2023-07-19 13:24:01 +02:00
2023-12-08 09:26:28 +01:00
2023-07-19 13:24:01 +02:00
2024-05-29 13:18:12 +02:00
2024-04-12 23:41:05 +03:00
2023-11-13 17:59:48 +02:00
2023-10-31 17:21:54 -10:00
2022-10-03 20:56:46 +02:00
2024-04-24 15:31:41 +02:00
2023-11-04 10:23:23 +01:00
2023-03-23 14:31:18 +01:00
2023-09-27 08:51:28 +02:00
2022-02-25 09:59:35 +01:00
2023-05-23 10:09:11 +02:00
2023-07-19 13:24:01 +02:00
2023-05-17 11:40:40 +02:00
2023-08-03 15:55:34 +02:00
2023-12-27 15:56:48 +01:00
2023-07-19 13:24:01 +02:00
2021-05-24 20:58:46 +02:00
2023-07-19 13:22:13 +02:00
2024-06-03 14:13:13 +02:00
2023-07-19 13:24:01 +02:00
2023-07-19 13:24:01 +02:00
2023-10-02 08:55:27 +02:00
2023-05-31 17:01:34 +02:00
2021-12-17 17:50:46 +01:00
2023-10-02 08:55:32 +02:00
2023-11-04 10:23:22 +01:00
2021-08-31 11:29:28 +02:00
2024-07-17 05:20:58 -04:00
2024-07-19 16:56:27 +02:00
2023-03-23 14:31:18 +01:00
2023-08-03 15:48:15 +02:00
2023-07-19 13:24:01 +02:00
2024-04-05 20:12:03 +03:00
2022-06-23 16:29:55 +02:00
2023-12-08 09:26:20 +01:00
2022-10-24 12:29:41 +03:00
2023-12-08 09:26:25 +01:00
2023-08-29 10:21:56 -07:00
2023-10-02 08:55:38 +02:00
2021-05-23 20:30:26 +02:00
2023-10-02 08:55:42 +02:00
2023-12-18 09:56:21 +01:00
2023-03-23 14:31:19 +01:00
2023-08-03 15:58:54 +02:00
2019-12-09 10:40:18 +01:00
2023-08-03 15:48:27 +02:00
2023-10-02 08:55:50 +02:00
2021-09-23 10:09:58 +02:00
2024-06-14 09:14:58 +02:00
2024-03-01 09:08:34 +01:00
2024-07-15 17:53:24 -07:00
2020-11-05 15:35:40 +01:00
2024-02-27 14:17:38 +01:00
2024-04-17 22:46:44 +02:00
2024-07-15 17:53:24 -07:00
2024-03-01 09:07:21 +01:00
2024-04-16 20:00:27 +09:00
2022-11-15 11:21:43 +01:00
2024-04-17 22:46:44 +02:00
2024-01-17 09:52:37 +01:00
2024-07-25 10:42:22 -07:00
2024-07-02 11:40:37 +02:00
2024-07-15 17:53:24 -07:00
2024-07-09 09:39:54 +02:00
2023-03-06 12:33:01 +02:00