Kernel/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2025-01-09 14:43:16 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
linux-stable/fs/btrfs
History
Boris Burkov 9e65bfca24 btrfs: fix qgroup_free_reserved_data int overflow 
The reserved data counter and input parameter is a u64, but we
inadvertently accumulate it in an int. Overflowing that int results in
freeing the wrong amount of data and breaking reserve accounting.

Unfortunately, this overflow rot spreads from there, as the qgroup
release/free functions rely on returning an int to take advantage of
negative values for error codes.

Therefore, the full fix is to return the "released" or "freed" amount by
a u64 argument and to return 0 or negative error code via the return
value.

Most of the call sites simply ignore the return value, though some
of them handle the error and count the returned bytes. Change all of
them accordingly.

CC: stable@vger.kernel.org # 6.1+
Reviewed-by: Qu Wenruo <wqu@suse.com>
Signed-off-by: Boris Burkov <boris@bur.io>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
2023-12-06 22:32:46 +01:00
..
tests
btrfs: abort transaction on generation mismatch when marking eb as dirty
2023-10-12 16:44:07 +02:00
accessors.c
btrfs: add eb to btrfs_node_key_ptr_offset
2022-12-05 18:00:58 +01:00
accessors.h
btrfs: qgroup: check generation when recording simple quota delta
2023-10-12 16:44:11 +02:00
acl.c
fs: port acl to mnt_idmap
2023-01-19 09:24:28 +01:00
acl.h
fs: port ->set_acl() to pass mnt_idmap
2023-01-19 09:24:27 +01:00
async-thread.c
btrfs: merge ordered work callbacks in btrfs_work into one
2023-10-12 16:44:10 +02:00
async-thread.h
btrfs: merge ordered work callbacks in btrfs_work into one
2023-10-12 16:44:10 +02:00
backref.c
btrfs: switch btrfs_backref_cache::is_reloc to bool
2023-10-12 16:44:13 +02:00
backref.h
btrfs: switch btrfs_backref_cache::is_reloc to bool
2023-10-12 16:44:13 +02:00
bio.c
btrfs: merge ordered work callbacks in btrfs_work into one
2023-10-12 16:44:10 +02:00
bio.h
btrfs: add an ordered_extent pointer to struct btrfs_bio
2023-06-19 13:59:36 +02:00
block-group.c
btrfs: stop reserving excessive space for block group item insertions
2023-10-12 16:44:16 +02:00
block-group.h
btrfs: rename add_new_free_space() to btrfs_add_new_free_space()
2023-08-21 14:52:12 +02:00
block-rsv.c
btrfs: read raid stripe tree from disk
2023-10-12 16:44:09 +02:00
block-rsv.h
btrfs: move btrfs_check_trunc_cache_free_space into block-rsv.c
2023-06-19 13:59:24 +02:00
btrfs_inode.h
btrfs: open code timespec64 in struct btrfs_inode
2023-10-12 16:44:19 +02:00
compression.c
btrfs: rename errno identifiers to error
2023-10-12 16:44:07 +02:00
compression.h
btrfs: pass an ordered_extent to btrfs_submit_compressed_write
2023-06-19 13:59:36 +02:00
ctree.c
btrfs: get correct owning_root when dropping snapshot
2023-11-03 16:39:06 +01:00
ctree.h
btrfs: add and use helpers for reading and writing log_transid
2023-10-12 16:44:17 +02:00
defrag.c
btrfs: add specific helper for range bit test exists
2023-10-12 16:44:14 +02:00
defrag.h
btrfs: move btrfs_defrag_root() to defrag.{c,h}
2023-10-12 16:44:13 +02:00
delalloc-space.c
btrfs: fix qgroup_free_reserved_data int overflow
2023-12-06 22:32:46 +01:00
delalloc-space.h
btrfs: move delalloc space related prototypes to delalloc-space.h
2022-12-05 18:00:44 +01:00
delayed-inode.c
btrfs: open code timespec64 in struct btrfs_inode
2023-10-12 16:44:19 +02:00
delayed-inode.h
btrfs: remove redundant root argument from btrfs_delayed_update_inode()
2023-10-12 16:44:12 +02:00
delayed-ref.c
btrfs: fix qgroup record leaks when using simple quotas
2023-11-09 14:01:59 +01:00
delayed-ref.h
btrfs: stop reserving excessive space for block group item insertions
2023-10-12 16:44:16 +02:00
dev-replace.c
btrfs: abort transaction on generation mismatch when marking eb as dirty
2023-10-12 16:44:07 +02:00
dev-replace.h
btrfs: move dev-replace prototypes into dev-replace.h
2022-12-05 18:00:47 +01:00
dir-item.c
btrfs: abort transaction on generation mismatch when marking eb as dirty
2023-10-12 16:44:07 +02:00
dir-item.h
btrfs: add fscrypt related dependencies to respective headers
2023-10-12 16:44:02 +02:00
discard.c
btrfs: unexport btrfs_run_discard_work and make it static
2023-06-19 13:59:25 +02:00
discard.h
btrfs: unexport btrfs_run_discard_work and make it static
2023-06-19 13:59:25 +02:00
disk-io.c
btrfs: add dmesg output for first mount and last unmount of a filesystem
2023-11-23 22:27:26 +01:00
disk-io.h
btrfs: abort transaction on generation mismatch when marking eb as dirty
2023-10-12 16:44:07 +02:00
export.c
btrfs: move super_block specific helpers into super.h
2022-12-05 18:00:47 +01:00
export.h
btrfs: simplify generation check in btrfs_get_dentry
2022-12-05 18:00:41 +01:00
extent_io.c
btrfs: free the allocated memory if btrfs_alloc_page_array() fails
2023-11-24 18:50:49 +01:00
extent_io.h
btrfs: move extent_buffer::lock_owner to debug section
2023-10-12 16:44:05 +02:00
extent_map.c
btrfs: fix incorrect splitting in btrfs_drop_extent_map_range
2023-08-18 14:38:10 +02:00
extent_map.h
btrfs: pass the new logical address to split_extent_map
2023-06-19 13:59:33 +02:00
extent-io-tree.c
btrfs: make sure we cache next state in find_first_extent_bit()
2023-10-12 16:44:15 +02:00
extent-io-tree.h
btrfs: make wait_extent_bit() static
2023-10-12 16:44:15 +02:00
extent-tree.c
btrfs: get correct owning_root when dropping snapshot
2023-11-03 16:39:06 +01:00
extent-tree.h
btrfs: get correct owning_root when dropping snapshot
2023-11-03 16:39:06 +01:00
file-item.c
btrfs: abort transaction on generation mismatch when marking eb as dirty
2023-10-12 16:44:07 +02:00
file-item.h
btrfs: scrub: avoid unnecessary csum tree search preparing stripes
2023-08-21 14:54:48 +02:00
file.c
btrfs: fix qgroup_free_reserved_data int overflow
2023-12-06 22:32:46 +01:00
file.h
btrfs: use cached state when looking for delalloc ranges with fiemap
2022-12-05 18:00:56 +01:00
free-space-cache.c
btrfs: remove redundant root argument from btrfs_update_inode()
2023-10-12 16:44:12 +02:00
free-space-cache.h
btrfs: move btrfs_check_trunc_cache_free_space into block-rsv.c
2023-06-19 13:59:24 +02:00
free-space-tree.c
btrfs: abort transaction on generation mismatch when marking eb as dirty
2023-10-12 16:44:07 +02:00
free-space-tree.h
btrfs: make clear_cache mount option to rebuild FST without disabling it
2023-05-10 14:51:27 +02:00
fs.c
btrfs: sysfs: update fs features directory asynchronously
2023-02-13 17:50:35 +01:00
fs.h
btrfs: add and use helpers for reading and writing last_trans_committed
2023-10-12 16:44:17 +02:00
inode-item.c
btrfs: track owning root in btrfs_ref
2023-10-12 16:44:11 +02:00
inode-item.h
btrfs: add fscrypt related dependencies to respective headers
2023-10-12 16:44:02 +02:00
inode.c
btrfs: fix qgroup_free_reserved_data int overflow
2023-12-06 22:32:46 +01:00
ioctl.c
btrfs: fix 64bit compat send ioctl arguments not initializing version member
2023-11-24 18:50:42 +01:00
ioctl.h
fs: port ->fileattr_set() to pass mnt_idmap
2023-01-19 09:24:27 +01:00
Kconfig
btrfs: check-integrity: remove CONFIG_BTRFS_FS_CHECK_INTEGRITY option
2023-10-12 16:44:05 +02:00
locking.c
btrfs: add raid stripe tree definitions
2023-10-12 16:44:09 +02:00
locking.h
btrfs: do not block starts waiting on previous transaction commit
2023-09-08 14:10:49 +02:00
lru_cache.c
btrfs: send: cache utimes operations for directories if possible
2023-02-15 19:38:50 +01:00
lru_cache.h
btrfs: remove btrfs_lru_cache_is_full() inline function
2023-04-17 18:01:18 +02:00
lzo.c
btrfs: disable allocation warnings for compression workspaces
2023-06-19 13:59:34 +02:00
Makefile
btrfs: add support for inserting raid stripe extents
2023-10-12 16:44:09 +02:00
messages.c
btrfs: rename errno identifiers to error
2023-10-12 16:44:07 +02:00
messages.h
btrfs: rename errno identifiers to error
2023-10-12 16:44:07 +02:00
misc.h
minmax: add in_range() macro
2023-08-24 16:20:18 -07:00
ordered-data.c
btrfs: fix qgroup_free_reserved_data int overflow
2023-12-06 22:32:46 +01:00
ordered-data.h
btrfs: open code btrfs_ordered_inode_tree in btrfs_inode
2023-10-12 16:44:16 +02:00
orphan.c
btrfs: move orphan prototypes into orphan.h
2022-12-05 18:00:47 +01:00
orphan.h
btrfs: move orphan prototypes into orphan.h
2022-12-05 18:00:47 +01:00
print-tree.c
btrfs: new inline ref storing owning subvol of data extents
2023-10-12 16:44:11 +02:00
print-tree.h
btrfs: print-tree: pass const extent buffer pointer
2023-06-19 13:59:22 +02:00
props.c
btrfs: move btrfs_name_hash to dir-item.h
2023-10-12 16:44:02 +02:00
props.h
btrfs: make module init/exit match their sequence
2022-12-05 18:00:40 +01:00
qgroup.c
btrfs: fix qgroup_free_reserved_data int overflow
2023-12-06 22:32:46 +01:00
qgroup.h
btrfs: fix qgroup_free_reserved_data int overflow
2023-12-06 22:32:46 +01:00
raid56.c
btrfs: scrub: avoid unnecessary csum tree search preparing stripes
2023-08-21 14:54:48 +02:00
raid56.h
btrfs: raid56: remove unused BTRFS_RBIO_REBUILD_MISSING
2023-08-21 14:52:12 +02:00
raid-stripe-tree.c
btrfs: directly return 0 on no error code in btrfs_insert_raid_extent()
2023-11-03 16:38:51 +01:00
raid-stripe-tree.h
btrfs: zoned: support RAID0/1/10 on top of raid stripe tree
2023-10-12 16:44:09 +02:00
rcu-string.h
btrfs: replace strncpy() with strscpy()
2022-12-05 18:00:59 +01:00
ref-verify.c
btrfs: ref-verify: fix memory leaks in btrfs_ref_tree_mod()
2023-11-23 22:27:34 +01:00
ref-verify.h
btrfs: ref-verify: Use btrfs_ref to refactor btrfs_ref_tree_mod()
2019-04-29 19:02:49 +02:00
reflink.c
btrfs: remove redundant root argument from btrfs_update_inode()
2023-10-12 16:44:12 +02:00
reflink.h
Btrfs: move all reflink implementation code into its own file
2020-03-23 17:01:54 +01:00
relocation.c
btrfs: change test_range_bit to scan the whole range
2023-10-12 16:44:14 +02:00
relocation.h
btrfs: relocation: constify parameters where possible
2023-10-12 16:44:13 +02:00
root-tree.c
btrfs: qgroup: add new quota mode for simple quotas
2023-10-12 16:44:10 +02:00
root-tree.h
btrfs: drop __must_check annotations
2023-10-12 16:44:04 +02:00
scrub.c
btrfs: make found_logical_ret parameter mandatory for function queue_scrub_stripe()
2023-11-03 16:40:15 +01:00
scrub.h
btrfs: scrub: remove scrub_bio structure
2023-04-17 18:01:24 +02:00
send.c
btrfs: send: ensure send_fd is writable
2023-11-24 18:50:53 +01:00
send.h
btrfs: send add define for v2 buffer size
2022-12-05 18:00:41 +01:00
space-info.c
btrfs: adjust overcommit logic when very close to full
2023-10-12 16:44:16 +02:00
space-info.h
btrfs: pass a space_info argument to btrfs_reserve_metadata_bytes()
2023-10-12 16:44:05 +02:00
subpage.c
btrfs: stop setting PageError in the data I/O path
2023-06-19 13:59:35 +02:00
subpage.h
btrfs: stop setting PageError in the data I/O path
2023-06-19 13:59:35 +02:00
super.c
btrfs: add dmesg output for first mount and last unmount of a filesystem
2023-11-23 22:27:26 +01:00
super.h
btrfs: move super_block specific helpers into super.h
2022-12-05 18:00:47 +01:00
sysfs.c
btrfs: sysfs: show temp_fsid feature
2023-10-12 16:44:18 +02:00
sysfs.h
btrfs: sysfs: update fs features directory asynchronously
2023-02-13 17:50:35 +01:00
transaction.c
btrfs: do not abort transaction if there is already an existing qgroup
2023-11-15 17:08:14 +01:00
transaction.h
btrfs: add and use helpers for reading and writing log_transid
2023-10-12 16:44:17 +02:00
tree-checker.c
btrfs: tree-checker: add type and sequence check for inline backrefs
2023-11-15 17:08:09 +01:00
tree-checker.h
btrfs: move btrfs_verify_level_key into tree-checker.c
2023-06-19 13:59:25 +02:00
tree-log.c
btrfs: remove redundant log root tree index assignment during log sync
2023-10-12 16:44:19 +02:00
tree-log.h
btrfs: change for_rename argument of btrfs_record_unlink_dir() to bool
2023-06-19 13:59:26 +02:00
tree-mod-log.c
btrfs: avoid tree mod log ENOMEM failures when we don't need to log
2023-06-19 13:59:38 +02:00
tree-mod-log.h
btrfs: fix SPDX comment in tree-mod-log.h
2022-12-05 18:00:48 +01:00
ulist.c
btrfs: reformat remaining kdoc style comments
2023-10-12 16:44:04 +02:00
ulist.h
btrfs: constify ulist parameter of ulist_next()
2022-12-05 18:00:50 +01:00
uuid-tree.c
btrfs: abort transaction on generation mismatch when marking eb as dirty
2023-10-12 16:44:07 +02:00
uuid-tree.h
btrfs: move uuid tree prototypes to uuid-tree.h
2022-12-05 18:00:46 +01:00
verity.c
btrfs: remove redundant root argument from btrfs_update_inode()
2023-10-12 16:44:12 +02:00
verity.h
btrfs: move verity prototypes into verity.h
2022-12-05 18:00:47 +01:00
volumes.c
btrfs: make error messages more clear when getting a chunk map
2023-11-23 22:27:46 +01:00
volumes.h
btrfs: update comment for temp-fsid, fsid, and metadata_uuid
2023-10-12 16:44:18 +02:00
xattr.c
btrfs: remove redundant root argument from btrfs_update_inode()
2023-10-12 16:44:12 +02:00
xattr.h
btrfs: cleanup btrfs_setxattr_trans and drop transaction parameter
2019-04-29 19:02:44 +02:00
zlib.c
btrfs: disable allocation warnings for compression workspaces
2023-06-19 13:59:34 +02:00
zoned.c
btrfs: zoned: drop no longer valid write pointer check
2023-11-03 16:38:56 +01:00
zoned.h
btrfs: zoned: reserve zones for an active metadata/system block group
2023-08-21 14:52:19 +02:00
zstd.c
btrfs: reformat remaining kdoc style comments
2023-10-12 16:44:04 +02:00