Jarkko Sakkinen 050bf3c793 KEYS: trusted: Do not use WARN when encode fails ...

When asn1_encode_sequence() fails, WARN is not the correct solution.

1. asn1_encode_sequence() is not an internal function (located
   in lib/asn1_encode.c).
2. Location is known, which makes the stack trace useless.
3. Results a crash if panic_on_warn is set.

It is also noteworthy that the use of WARN is undocumented, and it
should be avoided unless there is a carefully considered rationale to
use it.

Replace WARN with pr_err, and print the return value instead, which is
only useful piece of information.

Cc: stable@vger.kernel.org # v5.13+
Fixes: f2219745250f ("security: keys: trusted: use ASN.1 TPM2 key format for the blobs")
Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>

2024-05-21 02:35:10 +03:00

..

encrypted-keys

Revert "KEYS: encrypted: Add check for strsep"

2024-01-24 16:11:59 -05:00

trusted-keys

KEYS: trusted: Do not use WARN when encode fails

2024-05-21 02:35:10 +03:00

big_key.c

big_keys: Use struct for internal payload

2022-05-16 16:02:21 -07:00

compat_dh.c

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152

2019-05-30 11:26:32 -07:00

compat.c

security/keys: remove compat_keyctl_instantiate_key_iov

2020-10-03 00:02:16 -04:00

dh.c

KEYS: DH: Use crypto_wait_req

2023-02-13 18:34:48 +08:00

gc.c

keys: update key quotas in key_put()

2024-05-09 16:28:58 +03:00

internal.h

keys, dns: Allow key types (eg. DNS) to be reclaimed immediately on expiry

2023-12-21 13:47:38 +00:00

Kconfig

KEYS: trusted: allow use of TEE as backend without TCG_TPM support

2022-05-23 18:47:50 +03:00

key.c

keys: Fix overwrite of key expiration on instantiation

2024-05-09 16:28:58 +03:00

keyctl_pkey.c

KEYS: fix length validation in keyctl_pkey_params_get_2()

2022-03-08 10:33:18 +02:00

keyctl.c

keys: update key quotas in key_put()

2024-05-09 16:28:58 +03:00

keyring.c

security/keys: Remove inconsistent __user annotation

2022-10-05 00:25:56 +03:00

Makefile

KEYS: remove CONFIG_KEYS_COMPAT

2019-12-12 23:41:17 +02:00

permission.c

keys: Make the KEY_NEED_* perms an enum rather than a mask

2020-05-19 15:42:22 +01:00

persistent.c

Revert "Merge tag 'keys-acl-20190703' of git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs"

2019-07-10 18:43:43 -07:00

proc.c

keys, dns: Allow key types (eg. DNS) to be reclaimed immediately on expiry

2023-12-21 13:47:38 +00:00

process_keys.c

ucounts: Move get_ucounts from cred_alloc_blank to key_change_session_keyring

2021-10-20 10:34:20 -05:00

request_key_auth.c

KEYS: Replace all non-returning strlcpy with strscpy

2023-08-17 20:12:35 +00:00

request_key.c

keys: Fix linking a duplicate key to a keyring's assoc_array

2023-07-17 19:32:30 +00:00

sysctl.c

lsm: remove the now superfluous sentinel element from ctl_table array

2024-04-15 15:00:00 -04:00

user_defined.c

mm, treewide: rename kzfree() to kfree_sensitive()

2020-08-07 11:33:22 -07:00