Oleg Nesterov a872ff0cb2 [PATCH] simplify/fix first_tid() ...

first_tid:

	/* If nr exceeds the number of threads there is nothing todo */
	if (nr) {
		if (nr >= get_nr_threads(leader))
			goto done;
	}

This is not reliable: sub-threads can exit after this check, so the
'for' loop below can overlap and proc_task_readdir() can return an
already filldir'ed dirents.

	for (; pos && pid_alive(pos); pos = next_thread(pos)) {
		if (--nr > 0)
			continue;

Off-by-one error, will return 'leader' when nr == 1.

This patch tries to fix these problems and simplify the code.

Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

2006-06-26 09:58:26 -07:00

..

array.c

[PATCH] hrtimers: remove it_real_value calculation from proc/*/stat

2006-03-26 08:57:02 -08:00

base.c

[PATCH] simplify/fix first_tid()

2006-06-26 09:58:26 -07:00

generic.c

[PATCH] mark f_ops const in the inode

2006-03-28 09:16:05 -08:00

inode-alloc.txt

Linux-2.6.12-rc2

2005-04-16 15:20:36 -07:00

inode.c

[PATCH] proc: Use struct pid not struct task_ref

2006-06-26 09:58:26 -07:00

internal.h

[PATCH] proc: Use struct pid not struct task_ref

2006-06-26 09:58:26 -07:00

kcore.c

[PATCH] Make most file operations structs in fs/ const

2006-03-28 09:16:06 -08:00

kmsg.c

[PATCH] Make most file operations structs in fs/ const

2006-03-28 09:16:06 -08:00

Makefile

[PATCH] kdump: Access dump file in elf format (/proc/vmcore)

2005-06-25 16:24:53 -07:00

mmu.c

[PATCH] fix impossible VmallocChunk

2005-05-17 07:59:10 -07:00

nommu.c

[PATCH] output of /proc/maps on nommu systems is incomplete

2005-10-17 17:03:57 -07:00

proc_devtree.c

[PATCH] powerpc: Cope with duplicate node & property names in /proc/device-tree

2006-03-28 16:45:23 +11:00

proc_misc.c

[PATCH] Simplify proc/devices and fix early termination regression

2006-03-31 12:18:53 -08:00

proc_tty.c

Linux-2.6.12-rc2

2005-04-16 15:20:36 -07:00

root.c

[PATCH] VFS: Permit filesystem to override root dentry on mount

2006-06-23 07:42:45 -07:00

task_mmu.c

[PATCH] proc: Use struct pid not struct task_ref

2006-06-26 09:58:26 -07:00

task_nommu.c

[PATCH] proc: Move proc_maps_operations into task_mmu.c

2006-06-26 09:58:24 -07:00

vmcore.c

[PATCH] kdump proc vmcore size oveflow fix

2006-04-11 06:18:42 -07:00