mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2025-01-16 18:26:42 +00:00
94dfc73e7c
There is a regular need in the kernel to provide a way to declare
having a dynamically sized set of trailing elements in a structure.
Kernel code should always use “flexible array members”[1] for these
cases. The older style of one-element or zero-length arrays should
no longer be used[2].
This code was transformed with the help of Coccinelle:
(linux-5.19-rc2$ spatch --jobs $(getconf _NPROCESSORS_ONLN) --sp-file script.cocci --include-headers --dir . > output.patch)
@@
identifier S, member, array;
type T1, T2;
@@
struct S {
...
T1 member;
T2 array[
- 0
];
};
-fstrict-flex-arrays=3 is coming and we need to land these changes
to prevent issues like these in the short future:
../fs/minix/dir.c:337:3: warning: 'strcpy' will always overflow; destination buffer has size 0,
but the source string has length 2 (including NUL byte) [-Wfortify-source]
strcpy(de3->name, ".");
^
Since these are all [0] to [] changes, the risk to UAPI is nearly zero. If
this breaks anything, we can use a union with a new member name.
[1] https://en.wikipedia.org/wiki/Flexible_array_member
[2] https://www.kernel.org/doc/html/v5.16/process/deprecated.html#zero-length-and-one-element-arrays
Link: https://github.com/KSPP/linux/issues/78
Build-tested-by: kernel test robot <lkp@intel.com>
Link: https://lore.kernel.org/lkml/62b675ec.wKX6AOZ6cbE71vtF%25lkp@intel.com/
Acked-by: Dan Williams <dan.j.williams@intel.com> # For ndctl.h
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
82 lines
2.2 KiB
C
82 lines
2.2 KiB
C
/* SPDX-License-Identifier: GPL-2.0+ WITH Linux-syscall-note */
|
|
/*
|
|
* connector.h
|
|
*
|
|
* 2004-2005 Copyright (c) Evgeniy Polyakov <zbr@ioremap.net>
|
|
* All rights reserved.
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, write to the Free Software
|
|
* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
|
|
*/
|
|
|
|
#ifndef _UAPI__CONNECTOR_H
|
|
#define _UAPI__CONNECTOR_H
|
|
|
|
#include <linux/types.h>
|
|
|
|
/*
|
|
* Process Events connector unique ids -- used for message routing
|
|
*/
|
|
#define CN_IDX_PROC 0x1
|
|
#define CN_VAL_PROC 0x1
|
|
#define CN_IDX_CIFS 0x2
|
|
#define CN_VAL_CIFS 0x1
|
|
#define CN_W1_IDX 0x3 /* w1 communication */
|
|
#define CN_W1_VAL 0x1
|
|
#define CN_IDX_V86D 0x4
|
|
#define CN_VAL_V86D_UVESAFB 0x1
|
|
#define CN_IDX_BB 0x5 /* BlackBoard, from the TSP GPL sampling framework */
|
|
#define CN_DST_IDX 0x6
|
|
#define CN_DST_VAL 0x1
|
|
#define CN_IDX_DM 0x7 /* Device Mapper */
|
|
#define CN_VAL_DM_USERSPACE_LOG 0x1
|
|
#define CN_IDX_DRBD 0x8
|
|
#define CN_VAL_DRBD 0x1
|
|
#define CN_KVP_IDX 0x9 /* HyperV KVP */
|
|
#define CN_KVP_VAL 0x1 /* queries from the kernel */
|
|
#define CN_VSS_IDX 0xA /* HyperV VSS */
|
|
#define CN_VSS_VAL 0x1 /* queries from the kernel */
|
|
|
|
|
|
#define CN_NETLINK_USERS 11 /* Highest index + 1 */
|
|
|
|
/*
|
|
* Maximum connector's message size.
|
|
*/
|
|
#define CONNECTOR_MAX_MSG_SIZE 16384
|
|
|
|
/*
|
|
* idx and val are unique identifiers which
|
|
* are used for message routing and
|
|
* must be registered in connector.h for in-kernel usage.
|
|
*/
|
|
|
|
struct cb_id {
|
|
__u32 idx;
|
|
__u32 val;
|
|
};
|
|
|
|
struct cn_msg {
|
|
struct cb_id id;
|
|
|
|
__u32 seq;
|
|
__u32 ack;
|
|
|
|
__u16 len; /* Length of the following data */
|
|
__u16 flags;
|
|
__u8 data[];
|
|
};
|
|
|
|
#endif /* _UAPI__CONNECTOR_H */
|