Borislav Petkov
2c8fc86760
ide-disk: Fix request requeuing ...
Simon Kirby reported that on his RAID setup with idedisk underneath
the box OOMs after a couple of days of runtime. Running with
CONFIG_DEBUG_KMEMLEAK pointed to idedisk_prep_fn() which unconditionally
allocates an ide_cmd struct. However, ide_requeue_and_plug() can be
called more than once per request, either from the request issue or the
IRQ handler path and do blk_peek_request() ends up in idedisk_prep_fn()
repeatedly, allocating a struct ide_cmd everytime and "forgetting" the
previous pointer.
Make sure the code reuses the old allocated chunk.
Reported-and-tested-by: Simon Kirby <sim@hostway.ca>
Cc: <stable@kernel.org> [ 39.x, 3.0.x ]
Link: http://marc.info/?l=linux-kernel&m=131667641517919
Link: http://lkml.kernel.org/r/20110922072643.GA27232@hostway.ca
Signed-off-by: Borislav Petkov <bp@alien8.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
2011-10-03 14:28:18 -04:00
2010-01-19 01:45:29 -08:00
2010-01-19 01:44:41 -08:00
2010-01-19 01:52:31 -08:00
2010-01-19 01:52:32 -08:00
2010-01-19 01:44:41 -08:00
2010-01-19 01:45:29 -08:00
2010-03-04 08:24:06 -08:00
2009-06-15 18:52:58 +02:00
2010-01-19 01:52:32 -08:00
2010-05-11 00:08:03 -07:00
2010-01-19 01:45:29 -08:00
2010-01-19 01:45:29 -08:00
2010-01-19 01:52:33 -08:00
2010-01-19 01:52:33 -08:00
2011-08-04 01:30:34 -07:00
2009-05-17 19:12:25 +02:00
2010-01-19 01:44:41 -08:00
2009-06-15 18:52:58 +02:00
2010-05-26 19:51:09 +02:00
2010-10-26 10:17:29 -07:00
2010-10-18 11:03:14 +02:00
2010-03-02 23:57:59 -08:00
2011-08-04 01:29:51 -07:00
2009-05-17 19:12:25 +02:00
2010-11-22 11:37:21 -08:00
2011-03-10 08:52:07 +01:00
2011-04-21 19:43:59 +02:00
2008-04-29 14:48:55 +02:00
2011-06-11 15:06:48 -07:00
2011-03-09 19:54:27 +01:00
2011-05-06 07:46:22 +02:00
2010-03-30 22:02:32 +09:00
2010-10-05 15:01:10 +02:00
2010-03-30 22:02:32 +09:00
2011-10-03 14:28:18 -04:00
2008-10-21 07:47:30 -04:00
2009-04-08 14:12:49 +02:00
2010-10-26 10:17:30 -07:00
2010-08-07 18:17:56 +02:00
2010-10-05 15:01:10 +02:00
2009-09-01 17:52:57 -07:00
2011-05-22 22:08:32 -07:00
2008-10-21 07:47:30 -04:00
2011-04-21 19:43:59 +02:00
2009-03-27 12:46:34 +01:00
2009-05-17 19:12:25 +02:00
2009-05-17 19:12:25 +02:00
2009-04-08 14:13:03 +02:00
2011-04-05 23:52:49 +02:00
2010-03-30 22:02:32 +09:00
2010-01-19 01:41:57 -08:00
2009-05-17 19:12:25 +02:00
2009-05-22 20:28:35 +02:00
2011-03-10 08:52:07 +01:00
2009-12-03 14:35:31 -05:00
2008-07-16 20:33:39 +02:00
2010-08-07 18:17:56 +02:00
2009-05-17 19:12:25 +02:00
2010-09-13 21:34:25 -07:00
2010-03-30 22:02:32 +09:00
2011-05-16 14:24:46 -07:00
2009-01-02 16:12:48 +01:00
2010-10-22 10:52:56 -07:00
2011-03-31 11:26:23 -03:00
2010-01-19 11:30:09 -08:00
2010-01-19 01:52:36 -08:00
2010-08-11 23:04:39 +09:30
2010-03-30 22:02:32 +09:00
2010-01-19 01:45:29 -08:00
2010-01-19 01:45:29 -08:00
2010-01-19 01:45:29 -08:00
2011-01-20 17:02:05 -08:00
2009-06-15 18:52:58 +02:00
2011-03-17 14:05:34 +01:00
2009-04-08 14:13:03 +02:00
2010-01-19 01:44:41 -08:00
2011-06-10 14:55:36 +02:00
2010-01-19 01:45:29 -08:00
2010-04-22 19:11:24 -07:00
2011-03-31 11:26:23 -03:00
2010-11-22 11:38:08 -08:00
2009-06-15 18:52:58 +02:00
2010-01-19 01:44:41 -08:00
2009-06-15 22:13:44 +02:00
2010-03-30 22:02:32 +09:00
2008-12-29 20:27:33 +01:00
2010-03-30 22:02:32 +09:00
2010-03-02 23:57:59 -08:00
2010-01-19 01:45:29 -08:00
2009-06-10 14:37:21 +02:00
2010-01-19 01:45:29 -08:00
2010-01-19 01:52:35 -08:00
2011-03-31 11:26:23 -03:00
2010-01-19 01:45:29 -08:00
2010-01-19 01:45:29 -08:00
2010-01-19 01:45:29 -08:00
2011-03-31 11:26:23 -03:00
2009-03-31 20:15:32 +02:00
2010-08-09 03:17:55 -07:00
2011-06-10 14:55:36 +02:00
2010-01-19 01:44:41 -08:00
2011-03-31 11:26:23 -03:00
2c8fc86760