David Jeffery d0709f1e66 Don't leak a key reference if request_key() tries to use a revoked keyring ...

If a request_key() call to allocate and fill out a key attempts to insert the
key structure into a revoked keyring, the key will leak, using memory and part
of the user's key quota until the system reboots. This is from a failure of
construct_alloc_key() to decrement the key's reference count after the attempt
to insert into the requested keyring is rejected.

key_put() needs to be called in the link_prealloc_failed callpath to ensure
the unused key is released.

Signed-off-by: David Jeffery <djeffery@redhat.com>
Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: James Morris <james.l.morris@oracle.com>

2015-02-16 13:45:16 +11:00

..

encrypted-keys

KEYS: Fix stale key registration at error path

2014-12-06 21:50:36 -05:00

big_key.c

KEYS: Remove key_type::match in favour of overriding default by match_preparse

2014-09-16 17:36:06 +01:00

compat.c

security/compat: convert to COMPAT_SYSCALL_DEFINE

2014-03-06 16:30:42 +01:00

gc.c

KEYS: close race between key lookup and freeing

2015-01-05 15:58:01 +00:00

internal.h

KEYS: request_key() should reget expired keys rather than give EKEYEXPIRED

2014-12-01 22:52:53 +00:00

Kconfig

KEYS: Make /proc/keys unconditional if CONFIG_KEYS=y

2015-01-22 22:34:32 +00:00

key.c

KEYS: remove a bogus NULL check

2014-12-16 18:05:20 +11:00

keyctl.c

KEYS: Fix the size of the key description passed to/from userspace

2014-12-01 22:52:45 +00:00

keyring.c

KEYS: request_key() should reget expired keys rather than give EKEYEXPIRED

2014-12-01 22:52:53 +00:00

Makefile

KEYS: Add per-user_namespace registers for persistent per-UID kerberos caches

2013-09-24 10:35:19 +01:00

permission.c

KEYS: Move the flags representing required permission to linux/key.h

2014-03-14 17:44:49 +00:00

persistent.c

KEYS: Move the flags representing required permission to linux/key.h

2014-03-14 17:44:49 +00:00

proc.c

KEYS: Make /proc/keys unconditional if CONFIG_KEYS=y

2015-01-22 22:34:32 +00:00

process_keys.c

KEYS: Make the key matching functions return bool

2014-09-16 17:36:08 +01:00

request_key_auth.c

KEYS: Simplify KEYRING_SEARCH_{NO,DO}_STATE_CHECK flags

2014-12-01 22:52:50 +00:00

request_key.c

Don't leak a key reference if request_key() tries to use a revoked keyring

2015-02-16 13:45:16 +11:00

sysctl.c

security: Convert use of typedef ctl_table to struct ctl_table

2014-04-15 13:39:58 +10:00

trusted.c

KEYS: Remove key_type::match in favour of overriding default by match_preparse

2014-09-16 17:36:06 +01:00

trusted.h

trusted-keys: rename trusted_defined files to trusted

2011-01-24 10:14:22 +11:00

user_defined.c

KEYS: Remove key_type::match in favour of overriding default by match_preparse

2014-09-16 17:36:06 +01:00