Atsushi Nemoto
7dbfb315b2
drivers/rtc/rtc-rs5c348.c: fix hour decoding in 12-hour mode ...
Correct the offset by subtracting 20 from tm_hour before taking the
modulo 12.
[ "Why 20?" I hear you ask. Or at least I did.
Here's the reason why: RS5C348_BIT_PM is 32, and is - stupidly -
included in the RS5C348_HOURS_MASK define. So it's really subtracting
out that bit to get "hour+12". But then because it does things modulo
12, it needs to add the 12 in again afterwards anyway.
This code is confused. It would be much clearer if RS5C348_HOURS_MASK
just didn't include the RS5C348_BIT_PM bit at all, then it wouldn't
need to do the silly subtract either.
Whatever. It's all just math, the end result is the same. - Linus ]
Reported-by: James Nute <newten82@gmail.com>
Tested-by: James Nute <newten82@gmail.com>
Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2012-08-21 16:45:03 -07:00
2011-12-05 16:53:43 -08:00
2010-03-12 15:52:28 -08:00
2012-08-08 20:49:16 +02:00
2012-07-30 17:25:34 -07:00
2012-07-09 15:17:43 +02:00
2012-07-31 18:42:50 -07:00
2012-04-05 15:30:34 -07:00
2010-09-22 17:22:39 -07:00
2012-07-30 17:25:18 -07:00
2011-06-10 14:55:36 +02:00
2012-07-04 13:56:48 +02:00
2012-03-27 16:47:35 -07:00
2009-02-11 14:25:36 -08:00
2012-01-10 16:30:53 -08:00
2012-03-23 16:58:39 -07:00
2012-01-10 16:30:53 -08:00
2012-08-08 20:49:16 +02:00
2012-07-30 17:25:17 -07:00
2007-05-08 11:15:18 -07:00
2012-07-30 17:25:18 -07:00
2012-03-23 16:58:39 -07:00
2011-06-01 19:29:39 -07:00
2012-01-10 16:30:53 -08:00
2010-03-30 22:02:32 +09:00
2012-01-10 16:30:53 -08:00
2010-10-29 19:06:53 +09:00
2012-03-23 16:58:39 -07:00
2012-05-29 16:22:33 -07:00
2012-03-23 16:58:39 -07:00
2012-03-23 16:58:39 -07:00
2012-03-23 16:58:39 -07:00
2012-03-23 16:58:39 -07:00
2012-03-23 16:58:39 -07:00
2012-01-10 16:30:53 -08:00
2012-03-23 16:58:39 -07:00
2012-03-23 16:58:39 -07:00
2012-04-12 13:12:12 -07:00
2012-03-23 16:58:39 -07:00
2012-05-29 16:22:33 -07:00
2012-03-23 16:58:39 -07:00
2009-04-02 01:05:31 +00:00
2012-04-25 17:03:44 +02:00
2012-03-23 16:58:39 -07:00
2012-03-23 16:58:39 -07:00
2012-01-10 16:30:53 -08:00
2011-08-26 17:26:35 -07:00
2012-05-29 16:22:34 -07:00
2012-03-23 16:58:39 -07:00
2012-03-23 16:58:39 -07:00
2012-05-29 16:22:33 -07:00
2012-03-23 16:58:39 -07:00
2012-01-10 16:30:53 -08:00
2012-01-10 16:30:53 -08:00
2012-01-10 16:30:53 -08:00
2012-03-23 16:58:39 -07:00
2012-03-23 16:58:39 -07:00
2012-07-09 00:16:10 +02:00
2012-01-10 16:30:53 -08:00
2012-07-30 17:25:18 -07:00
2012-04-26 11:17:01 +02:00
2012-03-23 16:58:39 -07:00
2011-05-06 18:02:03 -07:00
2012-07-25 17:06:23 +02:00
2012-07-11 16:04:46 -07:00
2012-03-23 16:58:39 -07:00
2012-03-23 16:58:39 -07:00
2011-05-06 18:02:04 -07:00
2012-08-21 16:45:03 -07:00
2012-07-30 17:25:19 -07:00
2012-03-23 16:58:39 -07:00
2012-01-10 16:30:53 -08:00
2012-03-23 17:36:29 -07:00
2012-07-30 17:25:18 -07:00
2012-03-23 16:58:39 -07:00
2011-03-09 11:25:04 -08:00
2009-04-02 01:05:32 +00:00
2012-01-10 10:29:42 +08:00
2012-03-23 16:58:39 -07:00
2012-07-30 17:25:18 -07:00
2011-05-06 18:02:05 -07:00
2010-10-27 15:30:32 +09:00
2012-08-21 16:45:03 -07:00
2012-03-23 16:58:39 -07:00
2012-03-23 16:58:39 -07:00
2012-03-23 16:58:39 -07:00
2012-03-23 16:58:39 -07:00
2012-07-30 17:25:18 -07:00
2012-03-23 16:58:39 -07:00
2012-03-29 18:02:10 -07:00
2012-03-23 16:58:39 -07:00
2012-07-11 16:04:41 -07:00
2008-11-21 01:24:38 -08:00
2012-03-23 16:58:39 -07:00
2012-07-03 13:22:36 +08:00
2008-11-14 16:37:54 -08:00
2010-03-12 15:52:28 -08:00
2012-05-29 16:22:34 -07:00
2011-03-09 11:25:07 -08:00
2011-05-17 14:44:36 -04:00
2012-07-11 16:04:48 -07:00
2012-03-23 16:58:39 -07:00
2012-01-10 16:30:53 -08:00
2012-03-23 16:58:39 -07:00
2012-01-10 16:30:53 -08:00
2012-07-19 10:38:31 -04:00
2012-01-10 16:30:53 -08:00
2012-03-23 16:58:39 -07:00
7dbfb315b2