Vladimir Oltean deab6b1cd9 net: dsa: tag_ocelot: break circular dependency with ocelot switch lib driver ... As explained here: https://lore.kernel.org/netdev/20210908220834.d7gmtnwrorhharna@skbuf/ DSA tagging protocol drivers cannot depend on symbols exported by switch drivers, because this creates a circular dependency that breaks module autoloading. The tag_ocelot.c file depends on the ocelot_ptp_rew_op() function exported by the common ocelot switch lib. This function looks at OCELOT_SKB_CB(skb) and computes how to populate the REW_OP field of the DSA tag, for PTP timestamping (the command: one-step/two-step, and the TX timestamp identifier). None of that requires deep insight into the driver, it is quite stateless, as it only depends upon the skb->cb. So let's make it a static inline function and put it in include/linux/dsa/ocelot.h, a file that despite its name is used by the ocelot switch driver for populating the injection header too - since commit 40d3f295b5 ("net: mscc: ocelot: use common tag parsing code with DSA"). With that function declared as static inline, its body is expanded inside each call site, so the dependency is broken and the DSA tagger can be built without the switch library, upon which the felix driver depends. Fixes: 39e5308b32 ("net: mscc: ocelot: support PTP Sync one-step timestamping") Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> Signed-off-by: Jakub Kicinski <kuba@kernel.org>		2021-10-12 17:35:18 -07:00
..
8021q.h	net: dsa: sja1105: add bridge TX data plane offload based on tag_8021q	2021-07-26 22:35:22 +01:00
brcm.h	net: dsa: move the Broadcom tag information in a separate header file	2021-01-07 15:42:07 -08:00
lan9303.h	net: dsa: lan9303: phy_addr_sel_strap rename and retype	2018-01-04 13:35:07 -05:00
loop.h	net: dsa: loop: Wire-up MTU callbacks	2020-08-03 18:19:23 -07:00
mv88e6xxx.h	net: dsa: mv88e6xxx: isolate the ATU databases of standalone and bridged ports	2021-10-08 15:47:46 -07:00
ocelot.h	net: dsa: tag_ocelot: break circular dependency with ocelot switch lib driver	2021-10-12 17:35:18 -07:00
sja1105.h	net: dsa: sja1105: break dependency between dsa_port_is_sja1105 and switch driver	2021-10-12 17:33:36 -07:00