Maurizio Lombardi f6fe0b2d35 nvme-pci: fix sleeping function called from interrupt context ...

the nvme_handle_cqe() interrupt handler calls nvme_complete_async_event()
but the latter may call nvme_auth_stop() which is a blocking function.
Sleeping functions can't be called in interrupt context

 BUG: sleeping function called from invalid context
 in_atomic(): 1, irqs_disabled(): 1, non_block: 0, pid: 0, name: swapper/15
  Call Trace:
     <IRQ>
      __cancel_work_timer+0x31e/0x460
      ? nvme_change_ctrl_state+0xcf/0x3c0 [nvme_core]
      ? nvme_change_ctrl_state+0xcf/0x3c0 [nvme_core]
      nvme_complete_async_event+0x365/0x480 [nvme_core]
      nvme_poll_cq+0x262/0xe50 [nvme]

Fix the bug by moving nvme_auth_stop() to fw_act_work
(executed by the nvme_wq workqueue)

Fixes: f50fff73d620 ("nvme: implement In-Band authentication")
Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>
Reviewed-by: Jens Axboe <axboe@kernel.dk>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Keith Busch <kbusch@kernel.org>

2023-12-19 12:41:05 -08:00

..

common

nvme: keyring: fix conditional compilation

2023-11-08 08:07:08 -08:00

host

nvme-pci: fix sleeping function called from interrupt context

2023-12-19 12:41:05 -08:00

target

nvme: prevent potential spectre v1 gadget

2023-12-04 08:39:04 -08:00

Kconfig

nvme: implement In-Band authentication

2022-08-02 17:14:49 -06:00

Makefile

nvme: common: make keyring and auth separate modules

2023-11-07 10:05:15 -08:00