Isaku Yamahata e6fb7d6eb4 KVM: Make hardware_enable_failed a local variable in the "enable all" path ... Rework detecting hardware enabling errors to use a local variable in the "enable all" path to track whether or not enabling was successful across all CPUs. Using a global variable complicates paths that enable hardware only on the current CPU, e.g. kvm_resume() and kvm_online_cpu(). Opportunistically add a WARN if hardware enabling fails during kvm_resume(), KVM is all kinds of hosed if CPU0 fails to enable hardware. The WARN is largely futile in the current code, as KVM BUG()s on spurious faults on VMX instructions, e.g. attempting to run a vCPU on CPU if hardware enabling fails will explode. ------------[ cut here ]------------ kernel BUG at arch/x86/kvm/x86.c:508! invalid opcode: 0000 [#1] SMP CPU: 3 PID: 1009 Comm: CPU 4/KVM Not tainted 6.1.0-rc1+ #11 Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 0.0.0 02/06/2015 RIP: 0010:kvm_spurious_fault+0xa/0x10 Call Trace: vmx_vcpu_load_vmcs+0x192/0x230 [kvm_intel] vmx_vcpu_load+0x16/0x60 [kvm_intel] kvm_arch_vcpu_load+0x32/0x1f0 vcpu_load+0x2f/0x40 kvm_arch_vcpu_ioctl_run+0x19/0x9d0 kvm_vcpu_ioctl+0x271/0x660 __x64_sys_ioctl+0x80/0xb0 do_syscall_64+0x2b/0x50 entry_SYSCALL_64_after_hwframe+0x46/0xb0 But, the WARN may provide a breadcrumb to understand what went awry, and someday KVM may fix one or both of those bugs, e.g. by finding a way to eat spurious faults no matter the context (easier said than done due to side effects of certain operations, e.g. Intel's VMCLEAR). Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com> [sean: rebase, WARN on failure in kvm_resume()] Signed-off-by: Sean Christopherson <seanjc@google.com> Message-Id: <20221130230934.1014142-48-seanjc@google.com> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>		2022-12-29 15:48:35 -05:00
..
async_pf.c	KVM: Add helpers to wake/query blocking vCPU	2021-12-08 04:24:54 -05:00
async_pf.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 504	2019-06-19 17:09:56 +02:00
binary_stats.c	KVM: stats: remove dead stores	2021-08-13 03:35:15 -04:00
coalesced_mmio.c	KVM: mmio: Fix use-after-free Read in kvm_vm_ioctl_unregister_coalesced_mmio	2021-07-14 12:17:56 -04:00
coalesced_mmio.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
dirty_ring.c	KVM: Support dirty ring in conjunction with bitmap	2022-11-10 13:11:58 +00:00
eventfd.c	KVM: eventfd: Fix false positive RCU usage warning	2022-05-20 09:10:33 -04:00
irqchip.c	KVM: replace direct irq.h inclusion	2022-11-09 12:31:37 -05:00
Kconfig	KVM: Support dirty ring in conjunction with bitmap	2022-11-10 13:11:58 +00:00
kvm_main.c	KVM: Make hardware_enable_failed a local variable in the "enable all" path	2022-12-29 15:48:35 -05:00
kvm_mm.h	kvm: Remove the unused macro KVM_MMU_READ_{,UN}LOCK()	2022-12-27 06:00:51 -05:00
Makefile.kvm	KVM: Reinstate gfn_to_pfn_cache with invalidation support	2022-01-07 10:44:44 -05:00
pfncache.c	KVM: Skip unnecessary "unmap" if gpc is already valid during refresh	2022-11-30 19:25:24 +00:00
vfio.c	vfio: Hold a reference to the iommu_group in kvm for SPAPR	2022-10-07 08:10:52 -06:00
vfio.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00