Peter Zijlstra
3ac6487e58
perf: Fix sys_perf_event_open() race against self ...
Norbert reported that it's possible to race sys_perf_event_open() such
that the looser ends up in another context from the group leader,
triggering many WARNs.
The move_group case checks for races against itself, but the
!move_group case doesn't, seemingly relying on the previous
group_leader->ctx == ctx check. However, that check is racy due to not
holding any locks at that time.
Therefore, re-check the result after acquiring locks and bailing
if they no longer match.
Additionally, clarify the not_move_group case from the
move_group-vs-move_group race.
Fixes: f63a8daa5812 ("perf: Fix event->ctx locking")
Reported-by: Norbert Slusarek <nslusarek@gmx.net>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2022-05-20 08:44:00 -10:00
2022-03-28 19:08:17 -07:00
2022-05-05 08:57:00 -10:00
2022-03-28 12:27:35 -07:00
2022-03-24 16:39:47 +00:00
2022-04-14 06:30:39 +02:00
2022-04-05 09:59:36 +02:00
2022-05-20 08:44:00 -10:00
2022-03-21 12:59:01 -04:00
2021-12-02 17:25:21 +09:00
2022-05-11 02:22:52 +02:00
2022-01-11 09:51:26 -08:00
2022-03-28 17:29:53 -07:00
2022-03-22 13:44:21 -07:00
2022-03-21 16:48:55 -07:00
2022-03-23 10:54:27 -07:00
2022-03-22 14:39:12 -07:00
2022-05-12 00:37:11 +02:00
2022-04-29 00:07:53 +02:00
2022-05-12 00:37:11 +02:00
2021-05-02 00:43:35 +09:00
2021-10-18 06:17:01 -06:00
2022-02-03 11:20:34 -08:00
2021-10-27 12:32:34 +02:00
2021-12-14 17:39:42 -05:00
2021-11-06 16:43:20 -07:00
2022-01-25 13:22:51 -05:00
2022-02-22 13:51:40 -05:00
2022-01-11 13:08:21 -08:00
2022-05-17 15:03:36 -04:00
2022-03-09 10:32:06 -08:00
2021-08-11 13:11:12 -07:00
2021-09-08 15:32:35 -07:00
2021-08-16 18:55:32 +02:00
2022-04-13 21:25:40 +02:00
2021-12-25 12:20:55 -08:00
2022-03-15 10:32:44 +01:00
2022-01-20 08:52:55 +02:00
2022-03-28 17:29:53 -07:00
2022-02-16 23:25:12 +11:00
2022-05-01 10:17:17 +02:00
2021-06-18 11:43:08 +02:00
2021-05-27 04:01:50 +09:00
2022-01-22 08:33:34 +02:00
2022-04-15 14:49:55 -07:00
2021-07-05 10:46:20 +02:00
2022-03-17 20:17:18 -07:00
2021-08-17 17:50:51 +02:00
2022-03-31 10:36:55 +02:00
2022-04-21 20:01:10 -07:00
2021-12-13 12:04:45 -06:00
2021-11-06 13:30:42 -07:00
2021-09-08 15:32:34 -07:00
2021-05-07 00:26:33 -07:00
2022-04-26 16:09:36 +02:00
2022-03-23 19:00:33 -07:00
2022-03-23 18:03:08 -07:00
2022-04-05 09:59:38 +02:00
2022-02-16 12:51:32 -08:00
2022-01-11 18:45:02 -08:00
2022-02-28 10:26:40 -05:00
2021-12-29 10:37:33 +01:00
2021-09-03 09:58:12 -07:00
2022-01-31 11:21:46 +11:00
2022-03-23 19:00:35 -07:00
2021-12-28 11:26:18 +01:00
2021-09-03 09:58:12 -07:00
2021-10-14 13:29:18 +02:00
2022-01-08 12:43:57 -06:00
2022-03-22 13:06:05 -05:00
2021-11-12 11:53:16 -08:00
2022-03-23 19:00:35 -07:00
2022-02-02 13:11:34 +01:00
2021-12-07 16:36:17 -08:00
2022-03-24 19:06:48 -07:00
2022-03-28 17:29:53 -07:00
2022-03-31 10:36:55 +02:00
2022-04-13 18:44:35 +02:00
2021-08-10 14:57:42 +02:00
2022-02-02 21:34:19 +01:00
2022-02-03 17:02:21 -08:00
2022-02-25 09:36:06 +01:00
2022-04-05 09:59:38 +02:00
2022-04-05 09:59:38 +02:00
2022-01-15 16:30:30 +02:00
2022-03-08 14:33:36 -06:00
2021-06-23 16:41:24 -06:00
2022-03-22 16:11:53 -07:00
2022-03-10 16:51:50 -06:00
2022-03-23 19:00:35 -07:00
2022-02-01 17:24:39 -08:00
2021-08-16 11:39:51 -04:00
2022-01-08 12:43:57 -06:00
2022-02-17 09:11:57 -06:00
2021-05-07 00:26:34 -07:00
2021-05-09 13:07:03 -07:00
2022-02-25 10:40:14 -06:00
2021-09-08 11:50:27 -07:00
2021-07-03 11:41:14 -07:00
2022-04-02 10:37:39 -07:00
2022-02-16 15:57:55 +01:00
2021-08-17 07:49:10 -10:00
2022-03-23 12:40:51 -07:00
3ac6487e58