Eric Dumazet ef1148d448 ipv6: remove nexthop_fib6_nh_bh() ... After blamed commit, nexthop_fib6_nh_bh() and nexthop_fib6_nh() are the same. Delete nexthop_fib6_nh_bh(), and convert /proc/net/ipv6_route to standard rcu to avoid this splat: [ 5723.180080] WARNING: suspicious RCU usage [ 5723.180083] ----------------------------- [ 5723.180084] include/net/nexthop.h:516 suspicious rcu_dereference_check() usage! [ 5723.180086] other info that might help us debug this: [ 5723.180087] rcu_scheduler_active = 2, debug_locks = 1 [ 5723.180089] 2 locks held by cat/55856: [ 5723.180091] #0: ffff9440a582afa8 (&p->lock){+.+.}-{3:3}, at: seq_read_iter (fs/seq_file.c:188) [ 5723.180100] #1: ffffffffaac07040 (rcu_read_lock_bh){....}-{1:2}, at: rcu_lock_acquire (include/linux/rcupdate.h:326) [ 5723.180109] stack backtrace: [ 5723.180111] CPU: 14 PID: 55856 Comm: cat Tainted: G S I 6.3.0-dbx-DEV #528 [ 5723.180115] Call Trace: [ 5723.180117] <TASK> [ 5723.180119] dump_stack_lvl (lib/dump_stack.c:107) [ 5723.180124] dump_stack (lib/dump_stack.c:114) [ 5723.180126] lockdep_rcu_suspicious (include/linux/context_tracking.h:122) [ 5723.180132] ipv6_route_seq_show (include/net/nexthop.h:?) [ 5723.180135] ? ipv6_route_seq_next (net/ipv6/ip6_fib.c:2605) [ 5723.180140] seq_read_iter (fs/seq_file.c:272) [ 5723.180145] seq_read (fs/seq_file.c:163) [ 5723.180151] proc_reg_read (fs/proc/inode.c:316 fs/proc/inode.c:328) [ 5723.180155] vfs_read (fs/read_write.c:468) [ 5723.180160] ? up_read (kernel/locking/rwsem.c:1617) [ 5723.180164] ksys_read (fs/read_write.c:613) [ 5723.180168] __x64_sys_read (fs/read_write.c:621) [ 5723.180170] do_syscall_64 (arch/x86/entry/common.c:?) [ 5723.180174] entry_SYSCALL_64_after_hwframe (arch/x86/entry/entry_64.S:120) [ 5723.180177] RIP: 0033:0x7fa455677d2a Fixes: 09eed1192c ("neighbour: switch to standard rcu, instead of rcu_bh") Reported-by: syzbot <syzkaller@googlegroups.com> Signed-off-by: Eric Dumazet <edumazet@google.com> Reviewed-by: David Ahern <dsahern@kernel.org> Link: https://lore.kernel.org/r/20230510154646.370659-1-edumazet@google.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>		2023-05-11 18:07:05 -07:00
..
ila	ila: do not generate empty messages in ila_xlat_nl_cmd_get_mapping()	2023-03-01 08:48:46 +00:00
netfilter	xtables: move icmp/icmpv6 logic to xt_tcpudp	2023-03-22 21:48:59 +01:00
addrconf_core.c	net: rename reference+tracking helpers	2022-06-09 21:52:55 -07:00
addrconf.c	ipv6: prevent router_solicitations for team port	2023-03-24 08:57:06 +00:00
addrlabel.c	ipv6: addrlabel: fix infoleak when sending struct ifaddrlblmsg to network	2022-11-07 12:26:15 +00:00
af_inet6.c	ipv6: add icmpv6_error_anycast_as_unicast for ICMPv6	2023-04-20 20:07:50 -07:00
ah6.c	net: ipv6: Remove completion function scaffolding	2023-02-13 18:35:15 +08:00
anycast.c	ipv6: fix memory leaks on IPV6_ADDRFORM path	2020-07-30 16:30:55 -07:00
calipso.c	cipso,calipso: resolve a number of problems with the DOI refcounts	2021-03-04 15:26:57 -08:00
datagram.c	ipv6: Fix datagram socket connection with DSCP.	2023-02-09 22:49:04 -08:00
esp6_offload.c	Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec-next	2022-11-29 20:50:51 -08:00
esp6.c	net: ipv6: Remove completion function scaffolding	2023-02-13 18:35:15 +08:00
exthdrs_core.c	ipv6: remove printk	2019-07-27 14:23:48 -07:00
exthdrs_offload.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
exthdrs.c	net: ipv6: add skb drop reasons to TLV parse	2022-04-13 13:09:57 +01:00
fib6_notifier.c	net: fib_notifier: propagate extack down to the notifier block callback	2019-10-04 11:10:56 -07:00
fib6_rules.c	ipv6: change fib6_rules_net_exit() to batch mode	2022-02-08 20:41:34 -08:00
fou6.c	net: Add MODULE_DESCRIPTION entries to network modules	2020-06-20 21:33:57 -07:00
icmp.c	ipv6: add icmpv6_error_anycast_as_unicast for ICMPv6	2023-04-20 20:07:50 -07:00
inet6_connection_sock.c	net: annotate lockless accesses to sk->sk_err_soft	2023-03-17 08:25:05 +00:00
inet6_hashtables.c	tcp: Access &tcp_hashinfo via net.	2022-09-20 10:21:49 -07:00
ioam6_iptunnel.c	ipv6: ioam: Insertion frequency in lwtunnel output	2022-02-04 20:24:45 -08:00
ioam6.c	genetlink: start to validate reserved header bytes	2022-08-29 12:47:15 +01:00
ip6_checksum.c	net: udp: fix handling of CHECKSUM_COMPLETE packets	2018-10-24 14:18:16 -07:00
ip6_fib.c	ipv6: remove nexthop_fib6_nh_bh()	2023-05-11 18:07:05 -07:00
ip6_flowlabel.c	ipv6: flowlabel: do not disable BH where not needed	2023-03-21 21:32:18 -07:00
ip6_gre.c	erspan: do not use skb_mac_header() in ndo_start_xmit()	2023-03-21 21:16:26 -07:00
ip6_icmp.c	net: icmp: pass zeroed opts from icmp{,v6}_ndo_send before sending	2021-02-23 11:29:52 -08:00
ip6_input.c	netfilter: keep conntrack reference until IPsecv6 policy checks are done	2023-03-22 21:50:23 +01:00
ip6_offload.c	IPv6/GRO: generic helper to remove temporary HBH/jumbo header in driver	2022-12-12 15:41:44 -08:00
ip6_offload.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
ip6_output.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2023-04-06 12:01:20 -07:00
ip6_tunnel.c	net: tunnels: annotate lockless accesses to dev->needed_headroom	2023-03-15 00:04:04 -07:00
ip6_udp_tunnel.c	net: Make locking in sock_bindtoindex optional	2020-06-01 14:57:14 -07:00
ip6_vti.c	ipv6: tunnels: use DEV_STATS_INC()	2022-11-16 12:48:44 +00:00
ip6mr.c	treewide: Convert del_timer*() to timer_shutdown*()	2022-12-25 13:38:09 -08:00
ipcomp6.c	xfrm: ipcomp: add extack to ipcomp{4,6}_init_state	2022-09-29 07:18:00 +02:00
ipv6_sockglue.c	net/ipv6: Initialise msg_control_is_user	2023-04-14 11:09:27 +01:00
Kconfig	crypto: lib - make the sha1 library optional	2022-07-15 16:43:59 +08:00
Makefile	net: ipv6: use ipv6-y directly instead of ipv6-objs	2021-09-28 13:13:40 +01:00
mcast_snoop.c	net: bridge: mcast: fix broken length + header check for MRDv6 Adv.	2021-04-27 14:02:06 -07:00
mcast.c	ipv6: constify inet6_mc_check()	2023-03-17 08:56:37 +00:00
mip6.c	xfrm: mip6: add extack to mip6_destopt_init_state, mip6_rthdr_init_state	2022-09-29 07:18:01 +02:00
ndisc.c	neighbour: annotate lockless accesses to n->nud_state	2023-03-15 00:37:32 -07:00
netfilter.c	netfilter: Use l3mdev flow key when re-routing mangled packets	2022-05-16 13:03:29 +02:00
output_core.c	treewide: use get_random_u32_{above,below}() instead of manual loop	2022-11-18 02:15:22 +01:00
ping.c	inet: preserve const qualifier in inet_sk()	2023-03-17 08:56:37 +00:00
proc.c	icmp: Add counters for rate limits	2023-01-26 10:52:18 +01:00
protocol.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
raw.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2023-04-06 12:01:20 -07:00
reassembly.c	net: dropreason: add SKB_DROP_REASON_DUP_FRAG	2022-10-31 20:14:26 -07:00
route.c	net: dst: fix missing initialization of rt_uncached	2023-04-21 20:26:56 -07:00
rpl_iptunnel.c	net: ipv6: rpl_iptunnel: Replace 0-length arrays with flexible arrays	2023-01-06 19:28:01 -08:00
rpl.c	net: rpl: fix rpl header size calculation	2023-04-19 09:04:16 +01:00
seg6_hmac.c	net: ipv6: unexport __init-annotated seg6_hmac_net_init()	2022-06-28 21:23:30 -07:00
seg6_iptunnel.c	seg6: add support for SRv6 H.L2Encaps.Red behavior	2022-07-29 12:14:03 +01:00
seg6_local.c	seg6: add PSP flavor support for SRv6 End behavior	2023-02-16 13:18:06 +01:00
seg6.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2022-09-08 18:38:30 +02:00
sit.c	sit: update dev->needed_headroom in ipip6_tunnel_bind_dev()	2023-04-28 09:48:14 +01:00
syncookies.c	tcp: Fix data-races around sysctl_tcp_syncookies.	2022-07-18 12:21:54 +01:00
sysctl_net_ipv6.c	net: sysctl: introduce sysctl SYSCTL_THREE	2022-05-03 10:15:06 +02:00
tcp_ipv6.c	net: ipv6: fix skb hash for some RST packets	2023-04-28 09:53:43 +01:00
tcpv6_offload.c	net: move gro definitions to include/net/gro.h	2021-11-16 13:16:54 +00:00
tunnel6.c	tunnel6: add tunnel6_input_afinfo for ipip and ipv6 tunnels	2020-07-09 12:52:37 +02:00
udp_impl.h	tcp/udp: Call inet6_destroy_sock() in IPv6 sk->sk_destruct().	2022-10-12 17:50:37 -07:00
udp_offload.c	udp: allow header check for dodgy GSO_UDP_L4 packets.	2022-12-12 09:29:56 +00:00
udp.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2023-04-13 16:04:28 -07:00
udplite.c	tcp/udp: Call inet6_destroy_sock() in IPv6 sk->sk_destruct().	2022-10-12 17:50:37 -07:00
xfrm6_input.c	xfrm: state: remove extract_input indirection from xfrm_state_afinfo	2020-05-06 09:40:08 +02:00
xfrm6_output.c	xfrm: fix tunnel model fragmentation behavior	2022-03-01 12:08:40 +01:00
xfrm6_policy.c	net: dst: fix missing initialization of rt_uncached	2023-04-21 20:26:56 -07:00
xfrm6_protocol.c	xfrm: add support for UDPv6 encapsulation of ESP	2020-04-28 11:28:36 +02:00
xfrm6_state.c	xfrm: remove output_finish indirection from xfrm_state_afinfo	2020-05-06 09:40:08 +02:00
xfrm6_tunnel.c	xfrm: tunnel: add extack to ipip_init_state, xfrm6_tunnel_init_state	2022-09-29 07:18:00 +02:00