mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2025-01-16 18:26:42 +00:00
fd6f52e3fa
Patch series "Treewide: enable -Wmissing-prototypes", v3. At this point, there are five architectures with a number of known regressions: alpha, nios2, mips, sh and sparc. In the previous version of this patch, I had turned off the missing prototype warnings for the 15 architectures that still had issues, but since there are only five left, I think we can leave the rest to the maintainers (Cc'd here) as well. The series is also likely to cause occasional build regressions on linux-next as developers add new code that misses prototypes. Hopefully this should be resolved by the time the patches make it into a release and everyone gets the warnings right away. This patch (of 6): There is no global declaration for ida_dump() and no other callers, so make it static to avoid this warning: lib/test_ida.c:16:6: error: no previous prototype for 'ida_dump' Link: https://lkml.kernel.org/r/20231123110506.707903-1-arnd@kernel.org Link: https://lkml.kernel.org/r/20231123110506.707903-2-arnd@kernel.org Fixes: 8ab8ba38d488 ("ida: Start new test_ida module") Signed-off-by: Arnd Bergmann <arnd@arndb.de> Cc: "David S. Miller" <davem@davemloft.net> Cc: David Woodhouse <dwmw2@infradead.org> Cc: Dinh Nguyen <dinguyen@kernel.org> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Ivan Kokshaysky <ink@jurassic.park.msu.ru> Cc: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> Cc: Masahiro Yamada <masahiroy@kernel.org> Cc: Matt Turner <mattst88@gmail.com> Cc: Michael Ellerman <mpe@ellerman.id.au> Cc: Nathan Chancellor <nathan@kernel.org> Cc: Nicolas Schier <nicolas@fjasle.eu> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Richard Henderson <richard.henderson@linaro.org> Cc: Richard Weinberger <richard@nod.at> Cc: Rich Felker <dalias@libc.org> Cc: Stephen Rothwell <sfr@canb.auug.org.au> Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de> Cc: Tudor Ambarus <tudor.ambarus@linaro.org> Cc: Yoshinori Sato <ysato@users.sourceforge.jp> Cc: Kees Cook <keescook@chromium.org> Cc: Palmer Dabbelt <palmer@rivosinc.com> Cc: Zhihao Cheng <chengzhihao1@huawei.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
178 lines
4.3 KiB
C
178 lines
4.3 KiB
C
// SPDX-License-Identifier: GPL-2.0+
|
|
/*
|
|
* test_ida.c: Test the IDA API
|
|
* Copyright (c) 2016-2018 Microsoft Corporation
|
|
* Copyright (c) 2018 Oracle Corporation
|
|
* Author: Matthew Wilcox <willy@infradead.org>
|
|
*/
|
|
|
|
#include <linux/idr.h>
|
|
#include <linux/module.h>
|
|
|
|
static unsigned int tests_run;
|
|
static unsigned int tests_passed;
|
|
|
|
#ifdef __KERNEL__
|
|
static void ida_dump(struct ida *ida) { }
|
|
#endif
|
|
#define IDA_BUG_ON(ida, x) do { \
|
|
tests_run++; \
|
|
if (x) { \
|
|
ida_dump(ida); \
|
|
dump_stack(); \
|
|
} else { \
|
|
tests_passed++; \
|
|
} \
|
|
} while (0)
|
|
|
|
/*
|
|
* Straightforward checks that allocating and freeing IDs work.
|
|
*/
|
|
static void ida_check_alloc(struct ida *ida)
|
|
{
|
|
int i, id;
|
|
|
|
for (i = 0; i < 10000; i++)
|
|
IDA_BUG_ON(ida, ida_alloc(ida, GFP_KERNEL) != i);
|
|
|
|
ida_free(ida, 20);
|
|
ida_free(ida, 21);
|
|
for (i = 0; i < 3; i++) {
|
|
id = ida_alloc(ida, GFP_KERNEL);
|
|
IDA_BUG_ON(ida, id < 0);
|
|
if (i == 2)
|
|
IDA_BUG_ON(ida, id != 10000);
|
|
}
|
|
|
|
for (i = 0; i < 5000; i++)
|
|
ida_free(ida, i);
|
|
|
|
IDA_BUG_ON(ida, ida_alloc_min(ida, 5000, GFP_KERNEL) != 10001);
|
|
ida_destroy(ida);
|
|
|
|
IDA_BUG_ON(ida, !ida_is_empty(ida));
|
|
}
|
|
|
|
/* Destroy an IDA with a single entry at @base */
|
|
static void ida_check_destroy_1(struct ida *ida, unsigned int base)
|
|
{
|
|
IDA_BUG_ON(ida, ida_alloc_min(ida, base, GFP_KERNEL) != base);
|
|
IDA_BUG_ON(ida, ida_is_empty(ida));
|
|
ida_destroy(ida);
|
|
IDA_BUG_ON(ida, !ida_is_empty(ida));
|
|
}
|
|
|
|
/* Check that ida_destroy and ida_is_empty work */
|
|
static void ida_check_destroy(struct ida *ida)
|
|
{
|
|
/* Destroy an already-empty IDA */
|
|
IDA_BUG_ON(ida, !ida_is_empty(ida));
|
|
ida_destroy(ida);
|
|
IDA_BUG_ON(ida, !ida_is_empty(ida));
|
|
|
|
ida_check_destroy_1(ida, 0);
|
|
ida_check_destroy_1(ida, 1);
|
|
ida_check_destroy_1(ida, 1023);
|
|
ida_check_destroy_1(ida, 1024);
|
|
ida_check_destroy_1(ida, 12345678);
|
|
}
|
|
|
|
/*
|
|
* Check what happens when we fill a leaf and then delete it. This may
|
|
* discover mishandling of IDR_FREE.
|
|
*/
|
|
static void ida_check_leaf(struct ida *ida, unsigned int base)
|
|
{
|
|
unsigned long i;
|
|
|
|
for (i = 0; i < IDA_BITMAP_BITS; i++) {
|
|
IDA_BUG_ON(ida, ida_alloc_min(ida, base, GFP_KERNEL) !=
|
|
base + i);
|
|
}
|
|
|
|
ida_destroy(ida);
|
|
IDA_BUG_ON(ida, !ida_is_empty(ida));
|
|
|
|
IDA_BUG_ON(ida, ida_alloc(ida, GFP_KERNEL) != 0);
|
|
IDA_BUG_ON(ida, ida_is_empty(ida));
|
|
ida_free(ida, 0);
|
|
IDA_BUG_ON(ida, !ida_is_empty(ida));
|
|
}
|
|
|
|
/*
|
|
* Check allocations up to and slightly above the maximum allowed (2^31-1) ID.
|
|
* Allocating up to 2^31-1 should succeed, and then allocating the next one
|
|
* should fail.
|
|
*/
|
|
static void ida_check_max(struct ida *ida)
|
|
{
|
|
unsigned long i, j;
|
|
|
|
for (j = 1; j < 65537; j *= 2) {
|
|
unsigned long base = (1UL << 31) - j;
|
|
for (i = 0; i < j; i++) {
|
|
IDA_BUG_ON(ida, ida_alloc_min(ida, base, GFP_KERNEL) !=
|
|
base + i);
|
|
}
|
|
IDA_BUG_ON(ida, ida_alloc_min(ida, base, GFP_KERNEL) !=
|
|
-ENOSPC);
|
|
ida_destroy(ida);
|
|
IDA_BUG_ON(ida, !ida_is_empty(ida));
|
|
}
|
|
}
|
|
|
|
/*
|
|
* Check handling of conversions between exceptional entries and full bitmaps.
|
|
*/
|
|
static void ida_check_conv(struct ida *ida)
|
|
{
|
|
unsigned long i;
|
|
|
|
for (i = 0; i < IDA_BITMAP_BITS * 2; i += IDA_BITMAP_BITS) {
|
|
IDA_BUG_ON(ida, ida_alloc_min(ida, i + 1, GFP_KERNEL) != i + 1);
|
|
IDA_BUG_ON(ida, ida_alloc_min(ida, i + BITS_PER_LONG,
|
|
GFP_KERNEL) != i + BITS_PER_LONG);
|
|
ida_free(ida, i + 1);
|
|
ida_free(ida, i + BITS_PER_LONG);
|
|
IDA_BUG_ON(ida, !ida_is_empty(ida));
|
|
}
|
|
|
|
for (i = 0; i < IDA_BITMAP_BITS * 2; i++)
|
|
IDA_BUG_ON(ida, ida_alloc(ida, GFP_KERNEL) != i);
|
|
for (i = IDA_BITMAP_BITS * 2; i > 0; i--)
|
|
ida_free(ida, i - 1);
|
|
IDA_BUG_ON(ida, !ida_is_empty(ida));
|
|
|
|
for (i = 0; i < IDA_BITMAP_BITS + BITS_PER_LONG - 4; i++)
|
|
IDA_BUG_ON(ida, ida_alloc(ida, GFP_KERNEL) != i);
|
|
for (i = IDA_BITMAP_BITS + BITS_PER_LONG - 4; i > 0; i--)
|
|
ida_free(ida, i - 1);
|
|
IDA_BUG_ON(ida, !ida_is_empty(ida));
|
|
}
|
|
|
|
static DEFINE_IDA(ida);
|
|
|
|
static int ida_checks(void)
|
|
{
|
|
IDA_BUG_ON(&ida, !ida_is_empty(&ida));
|
|
ida_check_alloc(&ida);
|
|
ida_check_destroy(&ida);
|
|
ida_check_leaf(&ida, 0);
|
|
ida_check_leaf(&ida, 1024);
|
|
ida_check_leaf(&ida, 1024 * 64);
|
|
ida_check_max(&ida);
|
|
ida_check_conv(&ida);
|
|
|
|
printk("IDA: %u of %u tests passed\n", tests_passed, tests_run);
|
|
return (tests_run != tests_passed) ? 0 : -EINVAL;
|
|
}
|
|
|
|
static void ida_exit(void)
|
|
{
|
|
}
|
|
|
|
module_init(ida_checks);
|
|
module_exit(ida_exit);
|
|
MODULE_AUTHOR("Matthew Wilcox <willy@infradead.org>");
|
|
MODULE_LICENSE("GPL");
|