2019-05-28 16:57:16 +00:00
|
|
|
/* SPDX-License-Identifier: GPL-2.0-only */
|
2005-09-09 20:04:20 +00:00
|
|
|
/*
|
|
|
|
|
* V9FS definitions.
|
|
|
|
|
*
|
2008-02-07 01:25:03 +00:00
|
|
|
* Copyright (C) 2004-2008 by Eric Van Hensbergen <ericvh@gmail.com>
|
2005-09-09 20:04:20 +00:00
|
|
|
* Copyright (C) 2002 by Ron Minnich <rminnich@lanl.gov>
|
|
|
|
|
*/
|
2011-02-28 11:34:09 +00:00
|
|
|
#ifndef FS_9P_V9FS_H
|
|
|
|
|
#define FS_9P_V9FS_H
|
|
|
|
|
|
2010-04-22 09:42:00 +00:00
|
|
|
#include <linux/backing-dev.h>
|
2021-06-29 21:37:05 +00:00
|
|
|
#include <linux/netfs.h>
|
2005-09-09 20:04:20 +00:00
|
|
|
|
2008-03-05 13:08:09 +00:00
|
|
|
/**
|
|
|
|
|
* enum p9_session_flags - option flags for each 9P session
|
2010-03-05 18:48:00 +00:00
|
|
|
* @V9FS_PROTO_2000U: whether or not to use 9P2000.u extensions
|
2010-03-08 17:33:04 +00:00
|
|
|
* @V9FS_PROTO_2000L: whether or not to use 9P2000.l extensions
|
2008-03-05 13:08:09 +00:00
|
|
|
* @V9FS_ACCESS_SINGLE: only the mounting user can access the hierarchy
|
|
|
|
|
* @V9FS_ACCESS_USER: a new attach will be issued for every user (default)
|
2011-01-25 23:40:54 +00:00
|
|
|
* @V9FS_ACCESS_CLIENT: Just like user, but access check is performed on client.
|
2008-03-05 13:08:09 +00:00
|
|
|
* @V9FS_ACCESS_ANY: use a single attach for all users
|
|
|
|
|
* @V9FS_ACCESS_MASK: bit mask of different ACCESS options
|
2011-01-25 23:40:54 +00:00
|
|
|
* @V9FS_POSIX_ACL: POSIX ACLs are enforced
|
2008-03-05 13:08:09 +00:00
|
|
|
*
|
|
|
|
|
* Session flags reflect options selected by users at mount time
|
|
|
|
|
*/
|
2010-09-27 18:57:41 +00:00
|
|
|
#define V9FS_ACCESS_ANY (V9FS_ACCESS_SINGLE | \
|
|
|
|
|
V9FS_ACCESS_USER | \
|
|
|
|
|
V9FS_ACCESS_CLIENT)
|
|
|
|
|
#define V9FS_ACCESS_MASK V9FS_ACCESS_ANY
|
2011-01-25 23:40:54 +00:00
|
|
|
#define V9FS_ACL_MASK V9FS_POSIX_ACL
|
2010-09-27 18:57:41 +00:00
|
|
|
|
2008-03-05 13:08:09 +00:00
|
|
|
enum p9_session_flags {
|
2023-03-27 01:53:10 +00:00
|
|
|
V9FS_PROTO_2000U = 0x01,
|
|
|
|
|
V9FS_PROTO_2000L = 0x02,
|
|
|
|
|
V9FS_ACCESS_SINGLE = 0x04,
|
|
|
|
|
V9FS_ACCESS_USER = 0x08,
|
|
|
|
|
V9FS_ACCESS_CLIENT = 0x10,
|
|
|
|
|
V9FS_POSIX_ACL = 0x20,
|
|
|
|
|
V9FS_NO_XATTR = 0x40,
|
|
|
|
|
V9FS_IGNORE_QV = 0x80, /* ignore qid.version for cache hints */
|
|
|
|
|
V9FS_DIRECT_IO = 0x100,
|
|
|
|
|
V9FS_SYNC = 0x200
|
2008-03-05 13:08:09 +00:00
|
|
|
};
|
|
|
|
|
|
|
|
|
|
/**
|
2023-03-27 01:53:10 +00:00
|
|
|
* enum p9_cache_shortcuts - human readable cache preferences
|
|
|
|
|
* @CACHE_SC_NONE: disable all caches
|
|
|
|
|
* @CACHE_SC_READAHEAD: only provide caching for readahead
|
|
|
|
|
* @CACHE_SC_MMAP: provide caching to enable mmap
|
|
|
|
|
* @CACHE_SC_LOOSE: non-coherent caching for files and meta data
|
|
|
|
|
* @CACHE_SC_FSCACHE: persistent non-coherent caching for files and meta-data
|
2008-03-05 13:08:09 +00:00
|
|
|
*
|
|
|
|
|
*/
|
|
|
|
|
|
2023-03-27 01:53:10 +00:00
|
|
|
enum p9_cache_shortcuts {
|
|
|
|
|
CACHE_SC_NONE = 0b00000000,
|
|
|
|
|
CACHE_SC_READAHEAD = 0b00000001,
|
|
|
|
|
CACHE_SC_MMAP = 0b00000101,
|
|
|
|
|
CACHE_SC_LOOSE = 0b00001111,
|
|
|
|
|
CACHE_SC_FSCACHE = 0b10001111,
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* enum p9_cache_bits - possible values of ->cache
|
|
|
|
|
* @CACHE_NONE: caches disabled
|
|
|
|
|
* @CACHE_FILE: file caching (open to close)
|
|
|
|
|
* @CACHE_META: meta-data and directory caching
|
|
|
|
|
* @CACHE_WRITEBACK: write-back caching for files
|
|
|
|
|
* @CACHE_LOOSE: don't check cache consistency
|
|
|
|
|
* @CACHE_FSCACHE: local persistent caches
|
|
|
|
|
*
|
|
|
|
|
*/
|
|
|
|
|
|
|
|
|
|
enum p9_cache_bits {
|
|
|
|
|
CACHE_NONE = 0b00000000,
|
|
|
|
|
CACHE_FILE = 0b00000001,
|
|
|
|
|
CACHE_META = 0b00000010,
|
|
|
|
|
CACHE_WRITEBACK = 0b00000100,
|
|
|
|
|
CACHE_LOOSE = 0b00001000,
|
|
|
|
|
CACHE_FSCACHE = 0b10000000,
|
2008-03-05 13:08:09 +00:00
|
|
|
};
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* struct v9fs_session_info - per-instance session information
|
|
|
|
|
* @flags: session options of type &p9_session_flags
|
|
|
|
|
* @nodev: set to 1 to disable device mapping
|
|
|
|
|
* @debug: debug level
|
|
|
|
|
* @afid: authentication handle
|
2023-03-27 01:53:10 +00:00
|
|
|
* @cache: cache mode of type &p9_cache_bits
|
2009-09-23 18:00:27 +00:00
|
|
|
* @cachetag: the tag of the cache associated with this session
|
|
|
|
|
* @fscache: session cookie associated with FS-Cache
|
2008-03-05 13:08:09 +00:00
|
|
|
* @uname: string user name to mount hierarchy as
|
|
|
|
|
* @aname: mount specifier for remote hierarchy
|
|
|
|
|
* @maxdata: maximum data to be sent/recvd per protocol message
|
|
|
|
|
* @dfltuid: default numeric userid to mount hierarchy as
|
|
|
|
|
* @dfltgid: default numeric groupid to mount hierarchy as
|
|
|
|
|
* @uid: if %V9FS_ACCESS_SINGLE, the numeric uid which mounted the hierarchy
|
|
|
|
|
* @clnt: reference to 9P network client instantiated for this session
|
2009-09-23 18:00:27 +00:00
|
|
|
* @slist: reference to list of registered 9p sessions
|
2008-03-05 13:08:09 +00:00
|
|
|
*
|
|
|
|
|
* This structure holds state for each session instance established during
|
|
|
|
|
* a sys_mount() .
|
|
|
|
|
*
|
|
|
|
|
* Bugs: there seems to be a lot of state which could be condensed and/or
|
|
|
|
|
* removed.
|
|
|
|
|
*/
|
2005-09-09 20:04:20 +00:00
|
|
|
|
|
|
|
|
struct v9fs_session_info {
|
|
|
|
|
/* options */
|
2023-04-25 06:47:27 +00:00
|
|
|
unsigned int flags;
|
2008-03-05 13:08:09 +00:00
|
|
|
unsigned char nodev;
|
|
|
|
|
unsigned short debug;
|
|
|
|
|
unsigned int afid;
|
|
|
|
|
unsigned int cache;
|
2009-09-23 18:00:27 +00:00
|
|
|
#ifdef CONFIG_9P_FSCACHE
|
|
|
|
|
char *cachetag;
|
2020-11-18 09:06:42 +00:00
|
|
|
struct fscache_volume *fscache;
|
2009-09-23 18:00:27 +00:00
|
|
|
#endif
|
2005-09-09 20:04:20 +00:00
|
|
|
|
2007-10-17 19:31:07 +00:00
|
|
|
char *uname; /* user name to mount as */
|
|
|
|
|
char *aname; /* name of remote hierarchy being mounted */
|
2008-02-07 01:25:03 +00:00
|
|
|
unsigned int maxdata; /* max data for client interface */
|
2013-01-30 19:57:40 +00:00
|
|
|
kuid_t dfltuid; /* default uid/muid for legacy support */
|
|
|
|
|
kgid_t dfltgid; /* default gid for legacy support */
|
|
|
|
|
kuid_t uid; /* if ACCESS_SINGLE, the uid that has access */
|
2007-07-10 22:57:28 +00:00
|
|
|
struct p9_client *clnt; /* 9p client */
|
2009-09-23 18:00:27 +00:00
|
|
|
struct list_head slist; /* list of sessions registered with v9fs */
|
2010-06-30 13:48:50 +00:00
|
|
|
struct rw_semaphore rename_sem;
|
2018-09-05 07:44:12 +00:00
|
|
|
long session_lock_timeout; /* retry interval for blocking locks */
|
2005-09-09 20:04:20 +00:00
|
|
|
};
|
|
|
|
|
|
2011-02-28 11:34:06 +00:00
|
|
|
/* cache_validity flags */
|
|
|
|
|
#define V9FS_INO_INVALID_ATTR 0x01
|
|
|
|
|
|
2011-02-28 11:34:02 +00:00
|
|
|
struct v9fs_inode {
|
netfs: Fix gcc-12 warning by embedding vfs inode in netfs_i_context
While randstruct was satisfied with using an open-coded "void *" offset
cast for the netfs_i_context <-> inode casting, __builtin_object_size() as
used by FORTIFY_SOURCE was not as easily fooled. This was causing the
following complaint[1] from gcc v12:
In file included from include/linux/string.h:253,
from include/linux/ceph/ceph_debug.h:7,
from fs/ceph/inode.c:2:
In function 'fortify_memset_chk',
inlined from 'netfs_i_context_init' at include/linux/netfs.h:326:2,
inlined from 'ceph_alloc_inode' at fs/ceph/inode.c:463:2:
include/linux/fortify-string.h:242:25: warning: call to '__write_overflow_field' declared with attribute warning: detected write beyond size of field (1st parameter); maybe use struct_group()? [-Wattribute-warning]
242 | __write_overflow_field(p_size_field, size);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Fix this by embedding a struct inode into struct netfs_i_context (which
should perhaps be renamed to struct netfs_inode). The struct inode
vfs_inode fields are then removed from the 9p, afs, ceph and cifs inode
structs and vfs_inode is then simply changed to "netfs.inode" in those
filesystems.
Further, rename netfs_i_context to netfs_inode, get rid of the
netfs_inode() function that converted a netfs_i_context pointer to an
inode pointer (that can now be done with &ctx->inode) and rename the
netfs_i_context() function to netfs_inode() (which is now a wrapper
around container_of()).
Most of the changes were done with:
perl -p -i -e 's/vfs_inode/netfs.inode/'g \
`git grep -l 'vfs_inode' -- fs/{9p,afs,ceph,cifs}/*.[ch]`
Kees suggested doing it with a pair structure[2] and a special
declarator to insert that into the network filesystem's inode
wrapper[3], but I think it's cleaner to embed it - and then it doesn't
matter if struct randomisation reorders things.
Dave Chinner suggested using a filesystem-specific VFS_I() function in
each filesystem to convert that filesystem's own inode wrapper struct
into the VFS inode struct[4].
Version #2:
- Fix a couple of missed name changes due to a disabled cifs option.
- Rename nfs_i_context to nfs_inode
- Use "netfs" instead of "nic" as the member name in per-fs inode wrapper
structs.
[ This also undoes commit 507160f46c55 ("netfs: gcc-12: temporarily
disable '-Wattribute-warning' for now") that is no longer needed ]
Fixes: bc899ee1c898 ("netfs: Add a netfs inode context")
Reported-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: David Howells <dhowells@redhat.com>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Reviewed-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Xiubo Li <xiubli@redhat.com>
cc: Jonathan Corbet <corbet@lwn.net>
cc: Eric Van Hensbergen <ericvh@gmail.com>
cc: Latchesar Ionkov <lucho@ionkov.net>
cc: Dominique Martinet <asmadeus@codewreck.org>
cc: Christian Schoenebeck <linux_oss@crudebyte.com>
cc: Marc Dionne <marc.dionne@auristor.com>
cc: Ilya Dryomov <idryomov@gmail.com>
cc: Steve French <smfrench@gmail.com>
cc: William Kucharski <william.kucharski@oracle.com>
cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>
cc: Dave Chinner <david@fromorbit.com>
cc: linux-doc@vger.kernel.org
cc: v9fs-developer@lists.sourceforge.net
cc: linux-afs@lists.infradead.org
cc: ceph-devel@vger.kernel.org
cc: linux-cifs@vger.kernel.org
cc: samba-technical@lists.samba.org
cc: linux-fsdevel@vger.kernel.org
cc: linux-hardening@vger.kernel.org
Link: https://lore.kernel.org/r/d2ad3a3d7bdd794c6efb562d2f2b655fb67756b9.camel@kernel.org/ [1]
Link: https://lore.kernel.org/r/20220517210230.864239-1-keescook@chromium.org/ [2]
Link: https://lore.kernel.org/r/20220518202212.2322058-1-keescook@chromium.org/ [3]
Link: https://lore.kernel.org/r/20220524101205.GI2306852@dread.disaster.area/ [4]
Link: https://lore.kernel.org/r/165296786831.3591209.12111293034669289733.stgit@warthog.procyon.org.uk/ # v1
Link: https://lore.kernel.org/r/165305805651.4094995.7763502506786714216.stgit@warthog.procyon.org.uk # v2
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2022-06-09 20:46:04 +00:00
|
|
|
struct netfs_inode netfs; /* Netfslib context and vfs inode */
|
2011-07-11 16:40:59 +00:00
|
|
|
struct p9_qid qid;
|
2011-02-28 11:34:06 +00:00
|
|
|
unsigned int cache_validity;
|
2011-03-08 11:09:46 +00:00
|
|
|
struct mutex v_mutex;
|
2011-02-28 11:34:02 +00:00
|
|
|
};
|
|
|
|
|
|
|
|
|
|
static inline struct v9fs_inode *V9FS_I(const struct inode *inode)
|
|
|
|
|
{
|
netfs: Fix gcc-12 warning by embedding vfs inode in netfs_i_context
While randstruct was satisfied with using an open-coded "void *" offset
cast for the netfs_i_context <-> inode casting, __builtin_object_size() as
used by FORTIFY_SOURCE was not as easily fooled. This was causing the
following complaint[1] from gcc v12:
In file included from include/linux/string.h:253,
from include/linux/ceph/ceph_debug.h:7,
from fs/ceph/inode.c:2:
In function 'fortify_memset_chk',
inlined from 'netfs_i_context_init' at include/linux/netfs.h:326:2,
inlined from 'ceph_alloc_inode' at fs/ceph/inode.c:463:2:
include/linux/fortify-string.h:242:25: warning: call to '__write_overflow_field' declared with attribute warning: detected write beyond size of field (1st parameter); maybe use struct_group()? [-Wattribute-warning]
242 | __write_overflow_field(p_size_field, size);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Fix this by embedding a struct inode into struct netfs_i_context (which
should perhaps be renamed to struct netfs_inode). The struct inode
vfs_inode fields are then removed from the 9p, afs, ceph and cifs inode
structs and vfs_inode is then simply changed to "netfs.inode" in those
filesystems.
Further, rename netfs_i_context to netfs_inode, get rid of the
netfs_inode() function that converted a netfs_i_context pointer to an
inode pointer (that can now be done with &ctx->inode) and rename the
netfs_i_context() function to netfs_inode() (which is now a wrapper
around container_of()).
Most of the changes were done with:
perl -p -i -e 's/vfs_inode/netfs.inode/'g \
`git grep -l 'vfs_inode' -- fs/{9p,afs,ceph,cifs}/*.[ch]`
Kees suggested doing it with a pair structure[2] and a special
declarator to insert that into the network filesystem's inode
wrapper[3], but I think it's cleaner to embed it - and then it doesn't
matter if struct randomisation reorders things.
Dave Chinner suggested using a filesystem-specific VFS_I() function in
each filesystem to convert that filesystem's own inode wrapper struct
into the VFS inode struct[4].
Version #2:
- Fix a couple of missed name changes due to a disabled cifs option.
- Rename nfs_i_context to nfs_inode
- Use "netfs" instead of "nic" as the member name in per-fs inode wrapper
structs.
[ This also undoes commit 507160f46c55 ("netfs: gcc-12: temporarily
disable '-Wattribute-warning' for now") that is no longer needed ]
Fixes: bc899ee1c898 ("netfs: Add a netfs inode context")
Reported-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: David Howells <dhowells@redhat.com>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Reviewed-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Xiubo Li <xiubli@redhat.com>
cc: Jonathan Corbet <corbet@lwn.net>
cc: Eric Van Hensbergen <ericvh@gmail.com>
cc: Latchesar Ionkov <lucho@ionkov.net>
cc: Dominique Martinet <asmadeus@codewreck.org>
cc: Christian Schoenebeck <linux_oss@crudebyte.com>
cc: Marc Dionne <marc.dionne@auristor.com>
cc: Ilya Dryomov <idryomov@gmail.com>
cc: Steve French <smfrench@gmail.com>
cc: William Kucharski <william.kucharski@oracle.com>
cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>
cc: Dave Chinner <david@fromorbit.com>
cc: linux-doc@vger.kernel.org
cc: v9fs-developer@lists.sourceforge.net
cc: linux-afs@lists.infradead.org
cc: ceph-devel@vger.kernel.org
cc: linux-cifs@vger.kernel.org
cc: samba-technical@lists.samba.org
cc: linux-fsdevel@vger.kernel.org
cc: linux-hardening@vger.kernel.org
Link: https://lore.kernel.org/r/d2ad3a3d7bdd794c6efb562d2f2b655fb67756b9.camel@kernel.org/ [1]
Link: https://lore.kernel.org/r/20220517210230.864239-1-keescook@chromium.org/ [2]
Link: https://lore.kernel.org/r/20220518202212.2322058-1-keescook@chromium.org/ [3]
Link: https://lore.kernel.org/r/20220524101205.GI2306852@dread.disaster.area/ [4]
Link: https://lore.kernel.org/r/165296786831.3591209.12111293034669289733.stgit@warthog.procyon.org.uk/ # v1
Link: https://lore.kernel.org/r/165305805651.4094995.7763502506786714216.stgit@warthog.procyon.org.uk # v2
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2022-06-09 20:46:04 +00:00
|
|
|
return container_of(inode, struct v9fs_inode, netfs.inode);
|
2011-02-28 11:34:02 +00:00
|
|
|
}
|
|
|
|
|
|
2021-11-02 08:29:55 +00:00
|
|
|
static inline struct fscache_cookie *v9fs_inode_cookie(struct v9fs_inode *v9inode)
|
|
|
|
|
{
|
|
|
|
|
#ifdef CONFIG_9P_FSCACHE
|
2022-06-09 22:04:01 +00:00
|
|
|
return netfs_i_cookie(&v9inode->netfs);
|
2021-11-02 08:29:55 +00:00
|
|
|
#else
|
|
|
|
|
return NULL;
|
|
|
|
|
#endif
|
|
|
|
|
}
|
|
|
|
|
|
2020-11-18 09:06:42 +00:00
|
|
|
static inline struct fscache_volume *v9fs_session_cache(struct v9fs_session_info *v9ses)
|
|
|
|
|
{
|
|
|
|
|
#ifdef CONFIG_9P_FSCACHE
|
|
|
|
|
return v9ses->fscache;
|
|
|
|
|
#else
|
|
|
|
|
return NULL;
|
|
|
|
|
#endif
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
2017-07-05 15:25:37 +00:00
|
|
|
extern int v9fs_show_options(struct seq_file *m, struct dentry *root);
|
|
|
|
|
|
2021-10-01 06:34:44 +00:00
|
|
|
struct p9_fid *v9fs_session_init(struct v9fs_session_info *v9ses,
|
|
|
|
|
const char *dev_name, char *data);
|
2011-01-10 19:51:47 +00:00
|
|
|
extern void v9fs_session_close(struct v9fs_session_info *v9ses);
|
|
|
|
|
extern void v9fs_session_cancel(struct v9fs_session_info *v9ses);
|
|
|
|
|
extern void v9fs_session_begin_cancel(struct v9fs_session_info *v9ses);
|
|
|
|
|
extern struct dentry *v9fs_vfs_lookup(struct inode *dir, struct dentry *dentry,
|
2021-10-01 06:34:44 +00:00
|
|
|
unsigned int flags);
|
2011-01-10 19:51:47 +00:00
|
|
|
extern int v9fs_vfs_unlink(struct inode *i, struct dentry *d);
|
|
|
|
|
extern int v9fs_vfs_rmdir(struct inode *i, struct dentry *d);
|
2023-01-13 11:49:17 +00:00
|
|
|
extern int v9fs_vfs_rename(struct mnt_idmap *idmap,
|
2021-01-21 13:19:43 +00:00
|
|
|
struct inode *old_dir, struct dentry *old_dentry,
|
fs: make remaining filesystems use .rename2
This is trivial to do:
- add flags argument to foo_rename()
- check if flags is zero
- assign foo_rename() to .rename2 instead of .rename
This doesn't mean it's impossible to support RENAME_NOREPLACE for these
filesystems, but it is not trivial, like for local filesystems.
RENAME_NOREPLACE must guarantee atomicity (i.e. it shouldn't be possible
for a file to be created on one host while it is overwritten by rename on
another host).
Filesystems converted:
9p, afs, ceph, coda, ecryptfs, kernfs, lustre, ncpfs, nfs, ocfs2, orangefs.
After this, we can get rid of the duplicate interfaces for rename.
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Acked-by: David Howells <dhowells@redhat.com> [AFS]
Acked-by: Mike Marshall <hubcap@omnibond.com>
Cc: Eric Van Hensbergen <ericvh@gmail.com>
Cc: Ilya Dryomov <idryomov@gmail.com>
Cc: Jan Harkes <jaharkes@cs.cmu.edu>
Cc: Tyler Hicks <tyhicks@canonical.com>
Cc: Oleg Drokin <oleg.drokin@intel.com>
Cc: Trond Myklebust <trond.myklebust@primarydata.com>
Cc: Mark Fasheh <mfasheh@suse.com>
2016-09-27 09:03:58 +00:00
|
|
|
struct inode *new_dir, struct dentry *new_dentry,
|
|
|
|
|
unsigned int flags);
|
Revert "fs/9p: simplify iget to remove unnecessary paths"
This reverts commit 724a08450f74b02bd89078a596fd24857827c012.
This code simplification introduced significant regressions on servers
that do not remap inode numbers when exporting multiple underlying
filesystems with colliding inodes, as can be illustrated with simple
tmpfs exports in qemu with remapping disabled:
```
# host side
cd /tmp/linux-test
mkdir m1 m2
mount -t tmpfs tmpfs m1
mount -t tmpfs tmpfs m2
mkdir m1/dir m2/dir
echo foo > m1/dir/foo
echo bar > m2/dir/bar
# guest side
# started with -virtfs local,path=/tmp/linux-test,mount_tag=tmp,security_model=mapped-file
mount -t 9p -o trans=virtio,debug=1 tmp /mnt/t
ls /mnt/t/m1/dir
# foo
ls /mnt/t/m2/dir
# bar (works ok if directry isn't open)
# cd to keep first dir's inode alive
cd /mnt/t/m1/dir
ls /mnt/t/m2/dir
# foo (should be bar)
```
Other examples can be crafted with regular files with fscache enabled,
in which case I/Os just happen to the wrong file leading to
corruptions, or guest failing to boot with:
| VFS: Lookup of 'com.android.runtime' in 9p 9p would have caused loop
In theory, we'd want the servers to be smart enough and ensure they
never send us two different files with the same 'qid.path', but while
qemu has an option to remap that is recommended (and qemu prints a
warning if this case happens), there are many other servers which do
not (kvmtool, nfs-ganesha, probably diod...), we should at least ensure
we don't cause regressions on this:
- assume servers can't be trusted and operations that should get a 'new'
inode properly do so. commit d05dcfdf5e16 (" fs/9p: mitigate inode
collisions") attempted to do this, but v9fs_fid_iget_dotl() was not
called so some higher level of caching got in the way; this needs to be
fixed properly before we can re-apply the patches.
- if we ever want to really simplify this code, we will need to add some
negotiation with the server at mount time where the server could claim
they handle this properly, at which point we could optimize this out.
(but that might not be needed at all if we properly handle the 'new'
check?)
Fixes: 724a08450f74 ("fs/9p: simplify iget to remove unnecessary paths")
Reported-by: Will Deacon <will@kernel.org>
Link: https://lore.kernel.org/all/20240408141436.GA17022@redhat.com/
Link: https://lkml.kernel.org/r/20240923100508.GA32066@willie-the-truck
Cc: stable@vger.kernel.org # v6.9+
Message-ID: <20241024-revert_iget-v1-4-4cac63d25f72@codewreck.org>
Signed-off-by: Dominique Martinet <asmadeus@codewreck.org>
2024-10-23 23:52:13 +00:00
|
|
|
extern struct inode *v9fs_inode_from_fid(struct v9fs_session_info *v9ses,
|
|
|
|
|
struct p9_fid *fid,
|
|
|
|
|
struct super_block *sb, int new);
|
2011-01-10 19:51:47 +00:00
|
|
|
extern const struct inode_operations v9fs_dir_inode_operations_dotl;
|
|
|
|
|
extern const struct inode_operations v9fs_file_inode_operations_dotl;
|
|
|
|
|
extern const struct inode_operations v9fs_symlink_inode_operations_dotl;
|
2021-06-29 21:37:05 +00:00
|
|
|
extern const struct netfs_request_ops v9fs_req_ops;
|
Revert "fs/9p: simplify iget to remove unnecessary paths"
This reverts commit 724a08450f74b02bd89078a596fd24857827c012.
This code simplification introduced significant regressions on servers
that do not remap inode numbers when exporting multiple underlying
filesystems with colliding inodes, as can be illustrated with simple
tmpfs exports in qemu with remapping disabled:
```
# host side
cd /tmp/linux-test
mkdir m1 m2
mount -t tmpfs tmpfs m1
mount -t tmpfs tmpfs m2
mkdir m1/dir m2/dir
echo foo > m1/dir/foo
echo bar > m2/dir/bar
# guest side
# started with -virtfs local,path=/tmp/linux-test,mount_tag=tmp,security_model=mapped-file
mount -t 9p -o trans=virtio,debug=1 tmp /mnt/t
ls /mnt/t/m1/dir
# foo
ls /mnt/t/m2/dir
# bar (works ok if directry isn't open)
# cd to keep first dir's inode alive
cd /mnt/t/m1/dir
ls /mnt/t/m2/dir
# foo (should be bar)
```
Other examples can be crafted with regular files with fscache enabled,
in which case I/Os just happen to the wrong file leading to
corruptions, or guest failing to boot with:
| VFS: Lookup of 'com.android.runtime' in 9p 9p would have caused loop
In theory, we'd want the servers to be smart enough and ensure they
never send us two different files with the same 'qid.path', but while
qemu has an option to remap that is recommended (and qemu prints a
warning if this case happens), there are many other servers which do
not (kvmtool, nfs-ganesha, probably diod...), we should at least ensure
we don't cause regressions on this:
- assume servers can't be trusted and operations that should get a 'new'
inode properly do so. commit d05dcfdf5e16 (" fs/9p: mitigate inode
collisions") attempted to do this, but v9fs_fid_iget_dotl() was not
called so some higher level of caching got in the way; this needs to be
fixed properly before we can re-apply the patches.
- if we ever want to really simplify this code, we will need to add some
negotiation with the server at mount time where the server could claim
they handle this properly, at which point we could optimize this out.
(but that might not be needed at all if we properly handle the 'new'
check?)
Fixes: 724a08450f74 ("fs/9p: simplify iget to remove unnecessary paths")
Reported-by: Will Deacon <will@kernel.org>
Link: https://lore.kernel.org/all/20240408141436.GA17022@redhat.com/
Link: https://lkml.kernel.org/r/20240923100508.GA32066@willie-the-truck
Cc: stable@vger.kernel.org # v6.9+
Message-ID: <20241024-revert_iget-v1-4-4cac63d25f72@codewreck.org>
Signed-off-by: Dominique Martinet <asmadeus@codewreck.org>
2024-10-23 23:52:13 +00:00
|
|
|
extern struct inode *v9fs_inode_from_fid_dotl(struct v9fs_session_info *v9ses,
|
|
|
|
|
struct p9_fid *fid,
|
|
|
|
|
struct super_block *sb, int new);
|
2005-09-09 20:04:20 +00:00
|
|
|
|
|
|
|
|
/* other default globals */
|
2007-10-17 19:31:07 +00:00
|
|
|
#define V9FS_PORT 564
|
2005-09-09 20:04:20 +00:00
|
|
|
#define V9FS_DEFUSER "nobody"
|
|
|
|
|
#define V9FS_DEFANAME ""
|
2013-01-30 19:57:40 +00:00
|
|
|
#define V9FS_DEFUID KUIDT_INIT(-2)
|
|
|
|
|
#define V9FS_DEFGID KGIDT_INIT(-2)
|
2005-09-09 20:04:20 +00:00
|
|
|
|
2007-07-10 22:57:28 +00:00
|
|
|
static inline struct v9fs_session_info *v9fs_inode2v9ses(struct inode *inode)
|
|
|
|
|
{
|
2021-10-01 06:34:44 +00:00
|
|
|
return inode->i_sb->s_fs_info;
|
2007-07-10 22:57:28 +00:00
|
|
|
}
|
2007-10-17 19:31:07 +00:00
|
|
|
|
2011-03-08 11:09:50 +00:00
|
|
|
static inline struct v9fs_session_info *v9fs_dentry2v9ses(struct dentry *dentry)
|
|
|
|
|
{
|
|
|
|
|
return dentry->d_sb->s_fs_info;
|
|
|
|
|
}
|
|
|
|
|
|
2010-03-05 18:48:00 +00:00
|
|
|
static inline int v9fs_proto_dotu(struct v9fs_session_info *v9ses)
|
2007-10-17 19:31:07 +00:00
|
|
|
{
|
2010-03-05 18:48:00 +00:00
|
|
|
return v9ses->flags & V9FS_PROTO_2000U;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static inline int v9fs_proto_dotl(struct v9fs_session_info *v9ses)
|
|
|
|
|
{
|
2010-03-08 17:33:04 +00:00
|
|
|
return v9ses->flags & V9FS_PROTO_2000L;
|
2007-10-17 19:31:07 +00:00
|
|
|
}
|
2011-01-10 19:51:47 +00:00
|
|
|
|
|
|
|
|
/**
|
2011-02-28 11:34:02 +00:00
|
|
|
* v9fs_get_inode_from_fid - Helper routine to populate an inode by
|
2011-01-10 19:51:47 +00:00
|
|
|
* issuing a attribute request
|
|
|
|
|
* @v9ses: session information
|
|
|
|
|
* @fid: fid to issue attribute request for
|
|
|
|
|
* @sb: superblock on which to create inode
|
|
|
|
|
*
|
|
|
|
|
*/
|
|
|
|
|
static inline struct inode *
|
2011-02-28 11:34:02 +00:00
|
|
|
v9fs_get_inode_from_fid(struct v9fs_session_info *v9ses, struct p9_fid *fid,
|
2024-10-23 23:52:10 +00:00
|
|
|
struct super_block *sb)
|
2011-01-10 19:51:47 +00:00
|
|
|
{
|
|
|
|
|
if (v9fs_proto_dotl(v9ses))
|
Revert "fs/9p: simplify iget to remove unnecessary paths"
This reverts commit 724a08450f74b02bd89078a596fd24857827c012.
This code simplification introduced significant regressions on servers
that do not remap inode numbers when exporting multiple underlying
filesystems with colliding inodes, as can be illustrated with simple
tmpfs exports in qemu with remapping disabled:
```
# host side
cd /tmp/linux-test
mkdir m1 m2
mount -t tmpfs tmpfs m1
mount -t tmpfs tmpfs m2
mkdir m1/dir m2/dir
echo foo > m1/dir/foo
echo bar > m2/dir/bar
# guest side
# started with -virtfs local,path=/tmp/linux-test,mount_tag=tmp,security_model=mapped-file
mount -t 9p -o trans=virtio,debug=1 tmp /mnt/t
ls /mnt/t/m1/dir
# foo
ls /mnt/t/m2/dir
# bar (works ok if directry isn't open)
# cd to keep first dir's inode alive
cd /mnt/t/m1/dir
ls /mnt/t/m2/dir
# foo (should be bar)
```
Other examples can be crafted with regular files with fscache enabled,
in which case I/Os just happen to the wrong file leading to
corruptions, or guest failing to boot with:
| VFS: Lookup of 'com.android.runtime' in 9p 9p would have caused loop
In theory, we'd want the servers to be smart enough and ensure they
never send us two different files with the same 'qid.path', but while
qemu has an option to remap that is recommended (and qemu prints a
warning if this case happens), there are many other servers which do
not (kvmtool, nfs-ganesha, probably diod...), we should at least ensure
we don't cause regressions on this:
- assume servers can't be trusted and operations that should get a 'new'
inode properly do so. commit d05dcfdf5e16 (" fs/9p: mitigate inode
collisions") attempted to do this, but v9fs_fid_iget_dotl() was not
called so some higher level of caching got in the way; this needs to be
fixed properly before we can re-apply the patches.
- if we ever want to really simplify this code, we will need to add some
negotiation with the server at mount time where the server could claim
they handle this properly, at which point we could optimize this out.
(but that might not be needed at all if we properly handle the 'new'
check?)
Fixes: 724a08450f74 ("fs/9p: simplify iget to remove unnecessary paths")
Reported-by: Will Deacon <will@kernel.org>
Link: https://lore.kernel.org/all/20240408141436.GA17022@redhat.com/
Link: https://lkml.kernel.org/r/20240923100508.GA32066@willie-the-truck
Cc: stable@vger.kernel.org # v6.9+
Message-ID: <20241024-revert_iget-v1-4-4cac63d25f72@codewreck.org>
Signed-off-by: Dominique Martinet <asmadeus@codewreck.org>
2024-10-23 23:52:13 +00:00
|
|
|
return v9fs_inode_from_fid_dotl(v9ses, fid, sb, 0);
|
2011-01-10 19:51:47 +00:00
|
|
|
else
|
Revert "fs/9p: simplify iget to remove unnecessary paths"
This reverts commit 724a08450f74b02bd89078a596fd24857827c012.
This code simplification introduced significant regressions on servers
that do not remap inode numbers when exporting multiple underlying
filesystems with colliding inodes, as can be illustrated with simple
tmpfs exports in qemu with remapping disabled:
```
# host side
cd /tmp/linux-test
mkdir m1 m2
mount -t tmpfs tmpfs m1
mount -t tmpfs tmpfs m2
mkdir m1/dir m2/dir
echo foo > m1/dir/foo
echo bar > m2/dir/bar
# guest side
# started with -virtfs local,path=/tmp/linux-test,mount_tag=tmp,security_model=mapped-file
mount -t 9p -o trans=virtio,debug=1 tmp /mnt/t
ls /mnt/t/m1/dir
# foo
ls /mnt/t/m2/dir
# bar (works ok if directry isn't open)
# cd to keep first dir's inode alive
cd /mnt/t/m1/dir
ls /mnt/t/m2/dir
# foo (should be bar)
```
Other examples can be crafted with regular files with fscache enabled,
in which case I/Os just happen to the wrong file leading to
corruptions, or guest failing to boot with:
| VFS: Lookup of 'com.android.runtime' in 9p 9p would have caused loop
In theory, we'd want the servers to be smart enough and ensure they
never send us two different files with the same 'qid.path', but while
qemu has an option to remap that is recommended (and qemu prints a
warning if this case happens), there are many other servers which do
not (kvmtool, nfs-ganesha, probably diod...), we should at least ensure
we don't cause regressions on this:
- assume servers can't be trusted and operations that should get a 'new'
inode properly do so. commit d05dcfdf5e16 (" fs/9p: mitigate inode
collisions") attempted to do this, but v9fs_fid_iget_dotl() was not
called so some higher level of caching got in the way; this needs to be
fixed properly before we can re-apply the patches.
- if we ever want to really simplify this code, we will need to add some
negotiation with the server at mount time where the server could claim
they handle this properly, at which point we could optimize this out.
(but that might not be needed at all if we properly handle the 'new'
check?)
Fixes: 724a08450f74 ("fs/9p: simplify iget to remove unnecessary paths")
Reported-by: Will Deacon <will@kernel.org>
Link: https://lore.kernel.org/all/20240408141436.GA17022@redhat.com/
Link: https://lkml.kernel.org/r/20240923100508.GA32066@willie-the-truck
Cc: stable@vger.kernel.org # v6.9+
Message-ID: <20241024-revert_iget-v1-4-4cac63d25f72@codewreck.org>
Signed-off-by: Dominique Martinet <asmadeus@codewreck.org>
2024-10-23 23:52:13 +00:00
|
|
|
return v9fs_inode_from_fid(v9ses, fid, sb, 0);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* v9fs_get_new_inode_from_fid - Helper routine to populate an inode by
|
|
|
|
|
* issuing a attribute request
|
|
|
|
|
* @v9ses: session information
|
|
|
|
|
* @fid: fid to issue attribute request for
|
|
|
|
|
* @sb: superblock on which to create inode
|
|
|
|
|
*
|
|
|
|
|
*/
|
|
|
|
|
static inline struct inode *
|
|
|
|
|
v9fs_get_new_inode_from_fid(struct v9fs_session_info *v9ses, struct p9_fid *fid,
|
|
|
|
|
struct super_block *sb)
|
|
|
|
|
{
|
|
|
|
|
if (v9fs_proto_dotl(v9ses))
|
|
|
|
|
return v9fs_inode_from_fid_dotl(v9ses, fid, sb, 1);
|
|
|
|
|
else
|
|
|
|
|
return v9fs_inode_from_fid(v9ses, fid, sb, 1);
|
2011-07-06 11:02:31 +00:00
|
|
|
}
|
|
|
|
|
|
2011-02-28 11:34:09 +00:00
|
|
|
#endif
|