License cleanup: add SPDX GPL-2.0 license identifier to files with no license
Many source files in the tree are missing licensing information, which
makes it harder for compliance tools to determine the correct license.
By default all files without license information are under the default
license of the kernel, which is GPL version 2.
Update the files which contain no license information with the 'GPL-2.0'
SPDX license identifier. The SPDX identifier is a legally binding
shorthand, which can be used instead of the full boiler plate text.
This patch is based on work done by Thomas Gleixner and Kate Stewart and
Philippe Ombredanne.
How this work was done:
Patches were generated and checked against linux-4.14-rc6 for a subset of
the use cases:
- file had no licensing information it it.
- file was a */uapi/* one with no licensing information in it,
- file was a */uapi/* one with existing licensing information,
Further patches will be generated in subsequent months to fix up cases
where non-standard license headers were used, and references to license
had to be inferred by heuristics based on keywords.
The analysis to determine which SPDX License Identifier to be applied to
a file was done in a spreadsheet of side by side results from of the
output of two independent scanners (ScanCode & Windriver) producing SPDX
tag:value files created by Philippe Ombredanne. Philippe prepared the
base worksheet, and did an initial spot review of a few 1000 files.
The 4.13 kernel was the starting point of the analysis with 60,537 files
assessed. Kate Stewart did a file by file comparison of the scanner
results in the spreadsheet to determine which SPDX license identifier(s)
to be applied to the file. She confirmed any determination that was not
immediately clear with lawyers working with the Linux Foundation.
Criteria used to select files for SPDX license identifier tagging was:
- Files considered eligible had to be source code files.
- Make and config files were included as candidates if they contained >5
lines of source
- File already had some variant of a license header in it (even if <5
lines).
All documentation files were explicitly excluded.
The following heuristics were used to determine which SPDX license
identifiers to apply.
- when both scanners couldn't find any license traces, file was
considered to have no license information in it, and the top level
COPYING file license applied.
For non */uapi/* files that summary was:
SPDX license identifier # files
---------------------------------------------------|-------
GPL-2.0 11139
and resulted in the first patch in this series.
If that file was a */uapi/* path one, it was "GPL-2.0 WITH
Linux-syscall-note" otherwise it was "GPL-2.0". Results of that was:
SPDX license identifier # files
---------------------------------------------------|-------
GPL-2.0 WITH Linux-syscall-note 930
and resulted in the second patch in this series.
- if a file had some form of licensing information in it, and was one
of the */uapi/* ones, it was denoted with the Linux-syscall-note if
any GPL family license was found in the file or had no licensing in
it (per prior point). Results summary:
SPDX license identifier # files
---------------------------------------------------|------
GPL-2.0 WITH Linux-syscall-note 270
GPL-2.0+ WITH Linux-syscall-note 169
((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause) 21
((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) 17
LGPL-2.1+ WITH Linux-syscall-note 15
GPL-1.0+ WITH Linux-syscall-note 14
((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause) 5
LGPL-2.0+ WITH Linux-syscall-note 4
LGPL-2.1 WITH Linux-syscall-note 3
((GPL-2.0 WITH Linux-syscall-note) OR MIT) 3
((GPL-2.0 WITH Linux-syscall-note) AND MIT) 1
and that resulted in the third patch in this series.
- when the two scanners agreed on the detected license(s), that became
the concluded license(s).
- when there was disagreement between the two scanners (one detected a
license but the other didn't, or they both detected different
licenses) a manual inspection of the file occurred.
- In most cases a manual inspection of the information in the file
resulted in a clear resolution of the license that should apply (and
which scanner probably needed to revisit its heuristics).
- When it was not immediately clear, the license identifier was
confirmed with lawyers working with the Linux Foundation.
- If there was any question as to the appropriate license identifier,
the file was flagged for further research and to be revisited later
in time.
In total, over 70 hours of logged manual review was done on the
spreadsheet to determine the SPDX license identifiers to apply to the
source files by Kate, Philippe, Thomas and, in some cases, confirmation
by lawyers working with the Linux Foundation.
Kate also obtained a third independent scan of the 4.13 code base from
FOSSology, and compared selected files where the other two scanners
disagreed against that SPDX file, to see if there was new insights. The
Windriver scanner is based on an older version of FOSSology in part, so
they are related.
Thomas did random spot checks in about 500 files from the spreadsheets
for the uapi headers and agreed with SPDX license identifier in the
files he inspected. For the non-uapi files Thomas did random spot checks
in about 15000 files.
In initial set of patches against 4.14-rc6, 3 files were found to have
copy/paste license identifier errors, and have been fixed to reflect the
correct identifier.
Additionally Philippe spent 10 hours this week doing a detailed manual
inspection and review of the 12,461 patched files from the initial patch
version early this week with:
- a full scancode scan run, collecting the matched texts, detected
license ids and scores
- reviewing anything where there was a license detected (about 500+
files) to ensure that the applied SPDX license was correct
- reviewing anything where there was no detection but the patch license
was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied
SPDX license was correct
This produced a worksheet with 20 files needing minor correction. This
worksheet was then exported into 3 different .csv files for the
different types of files to be modified.
These .csv files were then reviewed by Greg. Thomas wrote a script to
parse the csv files and add the proper SPDX tag to the file, in the
format that the file expected. This script was further refined by Greg
based on the output to detect more types of files automatically and to
distinguish between header and source .c files (which need different
comment types.) Finally Greg ran the script using the .csv files to
generate the patches.
Reviewed-by: Kate Stewart <kstewart@linuxfoundation.org>
Reviewed-by: Philippe Ombredanne <pombredanne@nexb.com>
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-11-01 14:07:57 +00:00
|
|
|
// SPDX-License-Identifier: GPL-2.0
|
2006-10-11 08:20:50 +00:00
|
|
|
/*
|
2006-10-11 08:20:53 +00:00
|
|
|
* linux/fs/ext4/inode.c
|
2006-10-11 08:20:50 +00:00
|
|
|
*
|
|
|
|
* Copyright (C) 1992, 1993, 1994, 1995
|
|
|
|
* Remy Card (card@masi.ibp.fr)
|
|
|
|
* Laboratoire MASI - Institut Blaise Pascal
|
|
|
|
* Universite Pierre et Marie Curie (Paris VI)
|
|
|
|
*
|
|
|
|
* from
|
|
|
|
*
|
|
|
|
* linux/fs/minix/inode.c
|
|
|
|
*
|
|
|
|
* Copyright (C) 1991, 1992 Linus Torvalds
|
|
|
|
*
|
|
|
|
* 64-bit file support on 64-bit platforms by Jakub Jelinek
|
|
|
|
* (jj@sunsite.ms.mff.cuni.cz)
|
|
|
|
*
|
2006-10-11 08:20:53 +00:00
|
|
|
* Assorted race fixes, rewrite of ext4_get_block() by Al Viro, 2000
|
2006-10-11 08:20:50 +00:00
|
|
|
*/
|
|
|
|
|
|
|
|
#include <linux/fs.h>
|
2021-01-21 13:19:57 +00:00
|
|
|
#include <linux/mount.h>
|
2006-10-11 08:20:50 +00:00
|
|
|
#include <linux/time.h>
|
|
|
|
#include <linux/highuid.h>
|
|
|
|
#include <linux/pagemap.h>
|
2015-09-08 21:58:40 +00:00
|
|
|
#include <linux/dax.h>
|
2006-10-11 08:20:50 +00:00
|
|
|
#include <linux/quotaops.h>
|
|
|
|
#include <linux/string.h>
|
|
|
|
#include <linux/buffer_head.h>
|
|
|
|
#include <linux/writeback.h>
|
2008-07-11 23:27:31 +00:00
|
|
|
#include <linux/pagevec.h>
|
2006-10-11 08:20:50 +00:00
|
|
|
#include <linux/mpage.h>
|
2008-12-19 20:47:15 +00:00
|
|
|
#include <linux/namei.h>
|
2006-10-11 08:20:50 +00:00
|
|
|
#include <linux/uio.h>
|
|
|
|
#include <linux/bio.h>
|
2009-09-28 19:48:41 +00:00
|
|
|
#include <linux/workqueue.h>
|
2010-03-04 21:14:02 +00:00
|
|
|
#include <linux/kernel.h>
|
2011-01-13 00:59:13 +00:00
|
|
|
#include <linux/printk.h>
|
include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
percpu.h is included by sched.h and module.h and thus ends up being
included when building most .c files. percpu.h includes slab.h which
in turn includes gfp.h making everything defined by the two files
universally available and complicating inclusion dependencies.
percpu.h -> slab.h dependency is about to be removed. Prepare for
this change by updating users of gfp and slab facilities include those
headers directly instead of assuming availability. As this conversion
needs to touch large number of source files, the following script is
used as the basis of conversion.
http://userweb.kernel.org/~tj/misc/slabh-sweep.py
The script does the followings.
* Scan files for gfp and slab usages and update includes such that
only the necessary includes are there. ie. if only gfp is used,
gfp.h, if slab is used, slab.h.
* When the script inserts a new include, it looks at the include
blocks and try to put the new include such that its order conforms
to its surrounding. It's put in the include block which contains
core kernel includes, in the same order that the rest are ordered -
alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
doesn't seem to be any matching order.
* If the script can't find a place to put a new include (mostly
because the file doesn't have fitting include block), it prints out
an error message indicating which .h file needs to be added to the
file.
The conversion was done in the following steps.
1. The initial automatic conversion of all .c files updated slightly
over 4000 files, deleting around 700 includes and adding ~480 gfp.h
and ~3000 slab.h inclusions. The script emitted errors for ~400
files.
2. Each error was manually checked. Some didn't need the inclusion,
some needed manual addition while adding it to implementation .h or
embedding .c file was more appropriate for others. This step added
inclusions to around 150 files.
3. The script was run again and the output was compared to the edits
from #2 to make sure no file was left behind.
4. Several build tests were done and a couple of problems were fixed.
e.g. lib/decompress_*.c used malloc/free() wrappers around slab
APIs requiring slab.h to be added manually.
5. The script was run on all .h files but without automatically
editing them as sprinkling gfp.h and slab.h inclusions around .h
files could easily lead to inclusion dependency hell. Most gfp.h
inclusion directives were ignored as stuff from gfp.h was usually
wildly available and often used in preprocessor macros. Each
slab.h inclusion directive was examined and added manually as
necessary.
6. percpu.h was updated not to include slab.h.
7. Build test were done on the following configurations and failures
were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
distributed build env didn't work with gcov compiles) and a few
more options had to be turned off depending on archs to make things
build (like ipr on powerpc/64 which failed due to missing writeq).
* x86 and x86_64 UP and SMP allmodconfig and a custom test config.
* powerpc and powerpc64 SMP allmodconfig
* sparc and sparc64 SMP allmodconfig
* ia64 SMP allmodconfig
* s390 SMP allmodconfig
* alpha SMP allmodconfig
* um on x86_64 SMP allmodconfig
8. percpu.h modifications were reverted so that it could be applied as
a separate patch and serve as bisection point.
Given the fact that I had only a couple of failures from tests on step
6, I'm fairly confident about the coverage of this conversion patch.
If there is a breakage, it's likely to be something in one of the arch
headers which should be easily discoverable easily on most builds of
the specific arch.
Signed-off-by: Tejun Heo <tj@kernel.org>
Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
2010-03-24 08:04:11 +00:00
|
|
|
#include <linux/slab.h>
|
2014-03-30 14:20:01 +00:00
|
|
|
#include <linux/bitops.h>
|
2016-11-20 22:36:06 +00:00
|
|
|
#include <linux/iomap.h>
|
2018-01-29 11:41:30 +00:00
|
|
|
#include <linux/iversion.h>
|
2009-06-17 15:48:11 +00:00
|
|
|
|
2008-04-29 22:13:32 +00:00
|
|
|
#include "ext4_jbd2.h"
|
2006-10-11 08:20:50 +00:00
|
|
|
#include "xattr.h"
|
|
|
|
#include "acl.h"
|
2011-06-27 23:16:04 +00:00
|
|
|
#include "truncate.h"
|
2006-10-11 08:20:50 +00:00
|
|
|
|
2009-06-17 15:48:11 +00:00
|
|
|
#include <trace/events/ext4.h>
|
|
|
|
|
2024-08-30 05:37:38 +00:00
|
|
|
static void ext4_journalled_zero_new_buffers(handle_t *handle,
|
|
|
|
struct inode *inode,
|
|
|
|
struct folio *folio,
|
|
|
|
unsigned from, unsigned to);
|
|
|
|
|
2012-04-29 22:31:10 +00:00
|
|
|
static __u32 ext4_inode_csum(struct inode *inode, struct ext4_inode *raw,
|
|
|
|
struct ext4_inode_info *ei)
|
|
|
|
{
|
|
|
|
struct ext4_sb_info *sbi = EXT4_SB(inode->i_sb);
|
|
|
|
__u32 csum;
|
2016-07-03 21:51:39 +00:00
|
|
|
__u16 dummy_csum = 0;
|
|
|
|
int offset = offsetof(struct ext4_inode, i_checksum_lo);
|
|
|
|
unsigned int csum_size = sizeof(dummy_csum);
|
2012-04-29 22:31:10 +00:00
|
|
|
|
2016-07-03 21:51:39 +00:00
|
|
|
csum = ext4_chksum(sbi, ei->i_csum_seed, (__u8 *)raw, offset);
|
|
|
|
csum = ext4_chksum(sbi, csum, (__u8 *)&dummy_csum, csum_size);
|
|
|
|
offset += csum_size;
|
|
|
|
csum = ext4_chksum(sbi, csum, (__u8 *)raw + offset,
|
|
|
|
EXT4_GOOD_OLD_INODE_SIZE - offset);
|
2012-04-29 22:31:10 +00:00
|
|
|
|
2016-07-03 21:51:39 +00:00
|
|
|
if (EXT4_INODE_SIZE(inode->i_sb) > EXT4_GOOD_OLD_INODE_SIZE) {
|
|
|
|
offset = offsetof(struct ext4_inode, i_checksum_hi);
|
|
|
|
csum = ext4_chksum(sbi, csum, (__u8 *)raw +
|
|
|
|
EXT4_GOOD_OLD_INODE_SIZE,
|
|
|
|
offset - EXT4_GOOD_OLD_INODE_SIZE);
|
|
|
|
if (EXT4_FITS_IN_INODE(raw, ei, i_checksum_hi)) {
|
|
|
|
csum = ext4_chksum(sbi, csum, (__u8 *)&dummy_csum,
|
|
|
|
csum_size);
|
|
|
|
offset += csum_size;
|
|
|
|
}
|
2016-12-01 16:49:12 +00:00
|
|
|
csum = ext4_chksum(sbi, csum, (__u8 *)raw + offset,
|
|
|
|
EXT4_INODE_SIZE(inode->i_sb) - offset);
|
2012-04-29 22:31:10 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
return csum;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int ext4_inode_csum_verify(struct inode *inode, struct ext4_inode *raw,
|
|
|
|
struct ext4_inode_info *ei)
|
|
|
|
{
|
|
|
|
__u32 provided, calculated;
|
|
|
|
|
|
|
|
if (EXT4_SB(inode->i_sb)->s_es->s_creator_os !=
|
|
|
|
cpu_to_le32(EXT4_OS_LINUX) ||
|
2014-10-13 07:36:16 +00:00
|
|
|
!ext4_has_metadata_csum(inode->i_sb))
|
2012-04-29 22:31:10 +00:00
|
|
|
return 1;
|
|
|
|
|
|
|
|
provided = le16_to_cpu(raw->i_checksum_lo);
|
|
|
|
calculated = ext4_inode_csum(inode, raw, ei);
|
|
|
|
if (EXT4_INODE_SIZE(inode->i_sb) > EXT4_GOOD_OLD_INODE_SIZE &&
|
|
|
|
EXT4_FITS_IN_INODE(raw, ei, i_checksum_hi))
|
|
|
|
provided |= ((__u32)le16_to_cpu(raw->i_checksum_hi)) << 16;
|
|
|
|
else
|
|
|
|
calculated &= 0xFFFF;
|
|
|
|
|
|
|
|
return provided == calculated;
|
|
|
|
}
|
|
|
|
|
2020-10-15 20:37:59 +00:00
|
|
|
void ext4_inode_csum_set(struct inode *inode, struct ext4_inode *raw,
|
|
|
|
struct ext4_inode_info *ei)
|
2012-04-29 22:31:10 +00:00
|
|
|
{
|
|
|
|
__u32 csum;
|
|
|
|
|
|
|
|
if (EXT4_SB(inode->i_sb)->s_es->s_creator_os !=
|
|
|
|
cpu_to_le32(EXT4_OS_LINUX) ||
|
2014-10-13 07:36:16 +00:00
|
|
|
!ext4_has_metadata_csum(inode->i_sb))
|
2012-04-29 22:31:10 +00:00
|
|
|
return;
|
|
|
|
|
|
|
|
csum = ext4_inode_csum(inode, raw, ei);
|
|
|
|
raw->i_checksum_lo = cpu_to_le16(csum & 0xFFFF);
|
|
|
|
if (EXT4_INODE_SIZE(inode->i_sb) > EXT4_GOOD_OLD_INODE_SIZE &&
|
|
|
|
EXT4_FITS_IN_INODE(raw, ei, i_checksum_hi))
|
|
|
|
raw->i_checksum_hi = cpu_to_le16(csum >> 16);
|
|
|
|
}
|
|
|
|
|
2008-07-11 23:27:31 +00:00
|
|
|
static inline int ext4_begin_ordered_truncate(struct inode *inode,
|
|
|
|
loff_t new_size)
|
|
|
|
{
|
2010-11-08 18:51:33 +00:00
|
|
|
trace_ext4_begin_ordered_truncate(inode, new_size);
|
2011-01-10 17:29:43 +00:00
|
|
|
/*
|
|
|
|
* If jinode is zero, then we never opened the file for
|
|
|
|
* writing, so there's no need to call
|
|
|
|
* jbd2_journal_begin_ordered_truncate() since there's no
|
|
|
|
* outstanding writes we need to flush.
|
|
|
|
*/
|
|
|
|
if (!EXT4_I(inode)->jinode)
|
|
|
|
return 0;
|
|
|
|
return jbd2_journal_begin_ordered_truncate(EXT4_JOURNAL(inode),
|
|
|
|
EXT4_I(inode)->jinode,
|
|
|
|
new_size);
|
2008-07-11 23:27:31 +00:00
|
|
|
}
|
|
|
|
|
2017-06-22 15:44:55 +00:00
|
|
|
static int ext4_meta_trans_blocks(struct inode *inode, int lblocks,
|
|
|
|
int pextents);
|
2008-07-11 23:27:31 +00:00
|
|
|
|
2006-10-11 08:20:50 +00:00
|
|
|
/*
|
|
|
|
* Test whether an inode is a fast symlink.
|
2017-07-04 04:11:21 +00:00
|
|
|
* A fast symlink has its symlink data stored in ext4_inode_info->i_data.
|
2006-10-11 08:20:50 +00:00
|
|
|
*/
|
2015-04-16 05:55:00 +00:00
|
|
|
int ext4_inode_is_fast_symlink(struct inode *inode)
|
2006-10-11 08:20:50 +00:00
|
|
|
{
|
2017-12-04 01:38:01 +00:00
|
|
|
if (!(EXT4_I(inode)->i_flags & EXT4_EA_INODE_FL)) {
|
|
|
|
int ea_blocks = EXT4_I(inode)->i_file_acl ?
|
|
|
|
EXT4_CLUSTER_SIZE(inode->i_sb) >> 9 : 0;
|
|
|
|
|
|
|
|
if (ext4_has_inline_data(inode))
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
return (S_ISLNK(inode->i_mode) && inode->i_blocks - ea_blocks == 0);
|
|
|
|
}
|
2017-07-04 04:11:21 +00:00
|
|
|
return S_ISLNK(inode->i_mode) && inode->i_size &&
|
|
|
|
(inode->i_size < EXT4_N_BLOCKS * 4);
|
2006-10-11 08:20:50 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Called at the last iput() if i_nlink is zero.
|
|
|
|
*/
|
2010-06-07 17:16:22 +00:00
|
|
|
void ext4_evict_inode(struct inode *inode)
|
2006-10-11 08:20:50 +00:00
|
|
|
{
|
|
|
|
handle_t *handle;
|
2008-08-03 01:10:38 +00:00
|
|
|
int err;
|
2019-11-05 16:44:12 +00:00
|
|
|
/*
|
|
|
|
* Credits for final inode cleanup and freeing:
|
|
|
|
* sb + inode (ext4_orphan_del()), block bitmap, group descriptor
|
|
|
|
* (xattr block freeing), bitmap, group descriptor (inode freeing)
|
|
|
|
*/
|
|
|
|
int extra_credits = 6;
|
2017-06-22 14:26:31 +00:00
|
|
|
struct ext4_xattr_inode_array *ea_inode_array = NULL;
|
2020-11-27 11:06:49 +00:00
|
|
|
bool freeze_protected = false;
|
2006-10-11 08:20:50 +00:00
|
|
|
|
2010-11-08 18:51:33 +00:00
|
|
|
trace_ext4_evict_inode(inode);
|
2011-08-13 16:17:13 +00:00
|
|
|
|
2022-07-12 10:54:22 +00:00
|
|
|
if (EXT4_I(inode)->i_flags & EXT4_EA_INODE_FL)
|
|
|
|
ext4_evict_ea_inode(inode);
|
2010-06-07 17:16:22 +00:00
|
|
|
if (inode->i_nlink) {
|
2014-04-03 21:47:49 +00:00
|
|
|
truncate_inode_pages_final(&inode->i_data);
|
2013-06-04 18:46:12 +00:00
|
|
|
|
2010-06-07 17:16:22 +00:00
|
|
|
goto no_delete;
|
|
|
|
}
|
|
|
|
|
ext4: don't orphan or truncate the boot loader inode
The boot loader inode (inode #5) should never be visible in the
directory hierarchy, but it's possible if the file system is corrupted
that there will be a directory entry that points at inode #5. In
order to avoid accidentally trashing it, when such a directory inode
is opened, the inode will be marked as a bad inode, so that it's not
possible to modify (or read) the inode from userspace.
Unfortunately, when we unlink this (invalid/illegal) directory entry,
we will put the bad inode on the ophan list, and then when try to
unlink the directory, we don't actually remove the bad inode from the
orphan list before freeing in-memory inode structure. This means the
in-memory orphan list is corrupted, leading to a kernel oops.
In addition, avoid truncating a bad inode in ext4_destroy_inode(),
since truncating the boot loader inode is not a smart thing to do.
Reported-by: Sami Liedes <sami.liedes@iki.fi>
Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@vger.kernel.org
2014-10-06 02:47:07 +00:00
|
|
|
if (is_bad_inode(inode))
|
|
|
|
goto no_delete;
|
|
|
|
dquot_initialize(inode);
|
2010-03-03 14:05:06 +00:00
|
|
|
|
2008-07-11 23:27:31 +00:00
|
|
|
if (ext4_should_order_data(inode))
|
|
|
|
ext4_begin_ordered_truncate(inode, 0);
|
2014-04-03 21:47:49 +00:00
|
|
|
truncate_inode_pages_final(&inode->i_data);
|
2006-10-11 08:20:50 +00:00
|
|
|
|
2020-04-21 08:54:45 +00:00
|
|
|
/*
|
|
|
|
* For inodes with journalled data, transaction commit could have
|
2022-06-29 11:26:46 +00:00
|
|
|
* dirtied the inode. And for inodes with dioread_nolock, unwritten
|
|
|
|
* extents converting worker could merge extents and also have dirtied
|
|
|
|
* the inode. Flush worker is ignoring it because of I_FREEING flag but
|
|
|
|
* we still need to remove the inode from the writeback lists.
|
2020-04-21 08:54:45 +00:00
|
|
|
*/
|
2022-06-29 11:26:46 +00:00
|
|
|
if (!list_empty_careful(&inode->i_io_list))
|
2020-04-21 08:54:45 +00:00
|
|
|
inode_io_list_del(inode);
|
|
|
|
|
2012-06-12 14:20:38 +00:00
|
|
|
/*
|
|
|
|
* Protect us against freezing - iput() caller didn't have to have any
|
2020-11-27 11:06:49 +00:00
|
|
|
* protection against it. When we are in a running transaction though,
|
|
|
|
* we are already protected against freezing and we cannot grab further
|
|
|
|
* protection due to lock ordering constraints.
|
2012-06-12 14:20:38 +00:00
|
|
|
*/
|
2020-11-27 11:06:49 +00:00
|
|
|
if (!ext4_journal_current_handle()) {
|
|
|
|
sb_start_intwrite(inode->i_sb);
|
|
|
|
freeze_protected = true;
|
|
|
|
}
|
2017-06-22 01:10:32 +00:00
|
|
|
|
2017-06-22 15:42:09 +00:00
|
|
|
if (!IS_NOQUOTA(inode))
|
|
|
|
extra_credits += EXT4_MAXQUOTAS_DEL_BLOCKS(inode->i_sb);
|
|
|
|
|
2019-11-05 16:44:12 +00:00
|
|
|
/*
|
|
|
|
* Block bitmap, group descriptor, and inode are accounted in both
|
|
|
|
* ext4_blocks_for_truncate() and extra_credits. So subtract 3.
|
|
|
|
*/
|
2017-06-22 15:42:09 +00:00
|
|
|
handle = ext4_journal_start(inode, EXT4_HT_TRUNCATE,
|
2019-11-05 16:44:12 +00:00
|
|
|
ext4_blocks_for_truncate(inode) + extra_credits - 3);
|
2006-10-11 08:20:50 +00:00
|
|
|
if (IS_ERR(handle)) {
|
2008-08-03 01:10:38 +00:00
|
|
|
ext4_std_error(inode->i_sb, PTR_ERR(handle));
|
2006-10-11 08:20:50 +00:00
|
|
|
/*
|
|
|
|
* If we're going to skip the normal cleanup, we still need to
|
|
|
|
* make sure that the in-core orphan linked list is properly
|
|
|
|
* cleaned up.
|
|
|
|
*/
|
2006-10-11 08:20:53 +00:00
|
|
|
ext4_orphan_del(NULL, inode);
|
2020-11-27 11:06:49 +00:00
|
|
|
if (freeze_protected)
|
|
|
|
sb_end_intwrite(inode->i_sb);
|
2006-10-11 08:20:50 +00:00
|
|
|
goto no_delete;
|
|
|
|
}
|
2017-06-22 15:42:09 +00:00
|
|
|
|
2006-10-11 08:20:50 +00:00
|
|
|
if (IS_SYNC(inode))
|
2009-01-07 05:06:22 +00:00
|
|
|
ext4_handle_sync(handle);
|
2017-07-04 04:11:21 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Set inode->i_size to 0 before calling ext4_truncate(). We need
|
|
|
|
* special handling of symlinks here because i_size is used to
|
|
|
|
* determine whether ext4_inode_info->i_data contains symlink data or
|
|
|
|
* block mappings. Setting i_size to 0 will remove its fast symlink
|
|
|
|
* status. Erase i_data so that it becomes a valid empty block map.
|
|
|
|
*/
|
|
|
|
if (ext4_inode_is_fast_symlink(inode))
|
|
|
|
memset(EXT4_I(inode)->i_data, 0, sizeof(EXT4_I(inode)->i_data));
|
2006-10-11 08:20:50 +00:00
|
|
|
inode->i_size = 0;
|
2008-08-03 01:10:38 +00:00
|
|
|
err = ext4_mark_inode_dirty(handle, inode);
|
|
|
|
if (err) {
|
2010-02-15 19:19:27 +00:00
|
|
|
ext4_warning(inode->i_sb,
|
2008-08-03 01:10:38 +00:00
|
|
|
"couldn't mark inode dirty (err %d)", err);
|
|
|
|
goto stop_handle;
|
|
|
|
}
|
2016-11-14 03:02:26 +00:00
|
|
|
if (inode->i_blocks) {
|
|
|
|
err = ext4_truncate(inode);
|
|
|
|
if (err) {
|
2020-03-28 23:33:43 +00:00
|
|
|
ext4_error_err(inode->i_sb, -err,
|
|
|
|
"couldn't truncate inode %lu (err %d)",
|
|
|
|
inode->i_ino, err);
|
2016-11-14 03:02:26 +00:00
|
|
|
goto stop_handle;
|
|
|
|
}
|
|
|
|
}
|
2008-08-03 01:10:38 +00:00
|
|
|
|
2017-06-22 15:42:09 +00:00
|
|
|
/* Remove xattr references. */
|
|
|
|
err = ext4_xattr_delete_inode(handle, inode, &ea_inode_array,
|
|
|
|
extra_credits);
|
|
|
|
if (err) {
|
|
|
|
ext4_warning(inode->i_sb, "xattr delete (err %d)", err);
|
|
|
|
stop_handle:
|
|
|
|
ext4_journal_stop(handle);
|
|
|
|
ext4_orphan_del(NULL, inode);
|
2020-11-27 11:06:49 +00:00
|
|
|
if (freeze_protected)
|
|
|
|
sb_end_intwrite(inode->i_sb);
|
2017-06-22 15:42:09 +00:00
|
|
|
ext4_xattr_inode_array_free(ea_inode_array);
|
|
|
|
goto no_delete;
|
2008-08-03 01:10:38 +00:00
|
|
|
}
|
|
|
|
|
2006-10-11 08:20:50 +00:00
|
|
|
/*
|
2006-10-11 08:20:53 +00:00
|
|
|
* Kill off the orphan record which ext4_truncate created.
|
2006-10-11 08:20:50 +00:00
|
|
|
* AKPM: I think this can be inside the above `if'.
|
2006-10-11 08:20:53 +00:00
|
|
|
* Note that ext4_orphan_del() has to be able to cope with the
|
2006-10-11 08:20:50 +00:00
|
|
|
* deletion of a non-existent orphan - this is because we don't
|
2006-10-11 08:20:53 +00:00
|
|
|
* know if ext4_truncate() actually created an orphan record.
|
2006-10-11 08:20:50 +00:00
|
|
|
* (Well, we could do this if we need to, but heck - it works)
|
|
|
|
*/
|
2006-10-11 08:20:53 +00:00
|
|
|
ext4_orphan_del(handle, inode);
|
2018-07-29 19:50:00 +00:00
|
|
|
EXT4_I(inode)->i_dtime = (__u32)ktime_get_real_seconds();
|
2006-10-11 08:20:50 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* One subtle ordering requirement: if anything has gone wrong
|
|
|
|
* (transaction abort, IO errors, whatever), then we can still
|
|
|
|
* do these next steps (the fs will already have been marked as
|
|
|
|
* having errors), but we can't free the inode if the mark_dirty
|
|
|
|
* fails.
|
|
|
|
*/
|
2006-10-11 08:20:53 +00:00
|
|
|
if (ext4_mark_inode_dirty(handle, inode))
|
2006-10-11 08:20:50 +00:00
|
|
|
/* If that failed, just do the required in-core inode clear. */
|
2010-06-07 17:16:22 +00:00
|
|
|
ext4_clear_inode(inode);
|
2006-10-11 08:20:50 +00:00
|
|
|
else
|
2006-10-11 08:20:53 +00:00
|
|
|
ext4_free_inode(handle, inode);
|
|
|
|
ext4_journal_stop(handle);
|
2020-11-27 11:06:49 +00:00
|
|
|
if (freeze_protected)
|
|
|
|
sb_end_intwrite(inode->i_sb);
|
2017-06-22 14:26:31 +00:00
|
|
|
ext4_xattr_inode_array_free(ea_inode_array);
|
2006-10-11 08:20:50 +00:00
|
|
|
return;
|
|
|
|
no_delete:
|
2022-06-29 11:26:47 +00:00
|
|
|
/*
|
|
|
|
* Check out some where else accidentally dirty the evicting inode,
|
|
|
|
* which may probably cause inode use-after-free issues later.
|
|
|
|
*/
|
|
|
|
WARN_ON_ONCE(!list_empty_careful(&inode->i_io_list));
|
|
|
|
|
2020-11-06 03:58:51 +00:00
|
|
|
if (!list_empty(&EXT4_I(inode)->i_fc_list))
|
2022-01-17 09:36:54 +00:00
|
|
|
ext4_fc_mark_ineligible(inode->i_sb, EXT4_FC_REASON_NOMEM, NULL);
|
2010-06-07 17:16:22 +00:00
|
|
|
ext4_clear_inode(inode); /* We must guarantee clearing of inode... */
|
2006-10-11 08:20:50 +00:00
|
|
|
}
|
|
|
|
|
2009-12-14 12:21:14 +00:00
|
|
|
#ifdef CONFIG_QUOTA
|
|
|
|
qsize_t *ext4_get_reserved_space(struct inode *inode)
|
2009-01-22 17:13:05 +00:00
|
|
|
{
|
2009-12-14 12:21:14 +00:00
|
|
|
return &EXT4_I(inode)->i_reserved_quota;
|
2009-01-22 17:13:05 +00:00
|
|
|
}
|
2009-12-14 12:21:14 +00:00
|
|
|
#endif
|
2010-01-01 07:41:30 +00:00
|
|
|
|
2009-12-30 19:20:45 +00:00
|
|
|
/*
|
|
|
|
* Called with i_data_sem down, which is important since we can call
|
|
|
|
* ext4_discard_preallocations() from here.
|
|
|
|
*/
|
2010-01-25 09:00:31 +00:00
|
|
|
void ext4_da_update_reserve_space(struct inode *inode,
|
|
|
|
int used, int quota_claim)
|
2008-07-17 20:12:08 +00:00
|
|
|
{
|
|
|
|
struct ext4_sb_info *sbi = EXT4_SB(inode->i_sb);
|
2009-12-30 19:20:45 +00:00
|
|
|
struct ext4_inode_info *ei = EXT4_I(inode);
|
|
|
|
|
|
|
|
spin_lock(&ei->i_block_reservation_lock);
|
2011-09-09 23:18:51 +00:00
|
|
|
trace_ext4_da_update_reserve_space(inode, used, quota_claim);
|
2009-12-30 19:20:45 +00:00
|
|
|
if (unlikely(used > ei->i_reserved_data_blocks)) {
|
2013-02-14 20:11:41 +00:00
|
|
|
ext4_warning(inode->i_sb, "%s: ino %lu, used %d "
|
2012-03-20 03:13:43 +00:00
|
|
|
"with only %d reserved data blocks",
|
2009-12-30 19:20:45 +00:00
|
|
|
__func__, inode->i_ino, used,
|
|
|
|
ei->i_reserved_data_blocks);
|
|
|
|
WARN_ON(1);
|
|
|
|
used = ei->i_reserved_data_blocks;
|
|
|
|
}
|
2008-07-17 20:12:08 +00:00
|
|
|
|
2009-12-30 19:20:45 +00:00
|
|
|
/* Update per-inode reservations */
|
|
|
|
ei->i_reserved_data_blocks -= used;
|
2014-07-15 10:02:38 +00:00
|
|
|
percpu_counter_sub(&sbi->s_dirtyclusters_counter, used);
|
2008-10-10 13:39:00 +00:00
|
|
|
|
2021-05-26 05:29:30 +00:00
|
|
|
spin_unlock(&ei->i_block_reservation_lock);
|
2009-01-22 17:13:05 +00:00
|
|
|
|
2010-05-16 15:00:00 +00:00
|
|
|
/* Update quota subsystem for data blocks */
|
|
|
|
if (quota_claim)
|
2011-09-09 23:04:51 +00:00
|
|
|
dquot_claim_block(inode, EXT4_C2B(sbi, used));
|
2010-05-16 15:00:00 +00:00
|
|
|
else {
|
2010-01-25 09:00:31 +00:00
|
|
|
/*
|
|
|
|
* We did fallocate with an offset that is already delayed
|
|
|
|
* allocated. So on delayed allocated writeback we should
|
2010-05-16 15:00:00 +00:00
|
|
|
* not re-claim the quota for fallocated blocks.
|
2010-01-25 09:00:31 +00:00
|
|
|
*/
|
2011-09-09 23:04:51 +00:00
|
|
|
dquot_release_reservation_block(inode, EXT4_C2B(sbi, used));
|
2010-01-25 09:00:31 +00:00
|
|
|
}
|
2009-03-28 02:36:43 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* If we have done all the pending block allocations and if
|
|
|
|
* there aren't any writers on the inode, we can discard the
|
|
|
|
* inode's preallocations.
|
|
|
|
*/
|
2009-12-30 19:20:45 +00:00
|
|
|
if ((ei->i_reserved_data_blocks == 0) &&
|
2019-02-11 04:04:16 +00:00
|
|
|
!inode_is_open_for_write(inode))
|
2024-01-05 09:21:01 +00:00
|
|
|
ext4_discard_preallocations(inode);
|
2008-07-17 20:12:08 +00:00
|
|
|
}
|
|
|
|
|
2010-06-29 16:54:28 +00:00
|
|
|
static int __check_block_validity(struct inode *inode, const char *func,
|
2010-07-27 15:56:40 +00:00
|
|
|
unsigned int line,
|
|
|
|
struct ext4_map_blocks *map)
|
2009-05-17 19:38:01 +00:00
|
|
|
{
|
2019-04-10 03:37:08 +00:00
|
|
|
if (ext4_has_feature_journal(inode->i_sb) &&
|
|
|
|
(inode->i_ino ==
|
|
|
|
le32_to_cpu(EXT4_SB(inode->i_sb)->s_es->s_journal_inum)))
|
|
|
|
return 0;
|
2020-07-28 13:04:34 +00:00
|
|
|
if (!ext4_inode_block_valid(inode, map->m_pblk, map->m_len)) {
|
2010-07-27 15:56:40 +00:00
|
|
|
ext4_error_inode(inode, func, line, map->m_pblk,
|
2018-06-15 16:27:16 +00:00
|
|
|
"lblock %lu mapped to illegal pblock %llu "
|
2010-07-27 15:56:40 +00:00
|
|
|
"(length %d)", (unsigned long) map->m_lblk,
|
2018-06-15 16:27:16 +00:00
|
|
|
map->m_pblk, map->m_len);
|
2015-10-17 20:16:04 +00:00
|
|
|
return -EFSCORRUPTED;
|
2009-05-17 19:38:01 +00:00
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2015-12-07 20:09:35 +00:00
|
|
|
int ext4_issue_zeroout(struct inode *inode, ext4_lblk_t lblk, ext4_fsblk_t pblk,
|
|
|
|
ext4_lblk_t len)
|
|
|
|
{
|
|
|
|
int ret;
|
|
|
|
|
2019-12-26 16:10:22 +00:00
|
|
|
if (IS_ENCRYPTED(inode) && S_ISREG(inode->i_mode))
|
2016-07-10 18:01:03 +00:00
|
|
|
return fscrypt_zeroout_range(inode, lblk, pblk, len);
|
2015-12-07 20:09:35 +00:00
|
|
|
|
|
|
|
ret = sb_issue_zeroout(inode->i_sb, pblk, len, GFP_NOFS);
|
|
|
|
if (ret > 0)
|
|
|
|
ret = 0;
|
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2010-06-29 16:54:28 +00:00
|
|
|
#define check_block_validity(inode, map) \
|
2010-07-27 15:56:40 +00:00
|
|
|
__check_block_validity((inode), __func__, __LINE__, (map))
|
2010-06-29 16:54:28 +00:00
|
|
|
|
2013-03-11 01:01:03 +00:00
|
|
|
#ifdef ES_AGGRESSIVE_TEST
|
|
|
|
static void ext4_map_blocks_es_recheck(handle_t *handle,
|
|
|
|
struct inode *inode,
|
|
|
|
struct ext4_map_blocks *es_map,
|
|
|
|
struct ext4_map_blocks *map,
|
|
|
|
int flags)
|
|
|
|
{
|
|
|
|
int retval;
|
|
|
|
|
|
|
|
map->m_flags = 0;
|
|
|
|
/*
|
|
|
|
* There is a race window that the result is not the same.
|
|
|
|
* e.g. xfstests #223 when dioread_nolock enables. The reason
|
|
|
|
* is that we lookup a block mapping in extent status tree with
|
|
|
|
* out taking i_data_sem. So at the time the unwritten extent
|
|
|
|
* could be converted.
|
|
|
|
*/
|
2015-12-07 20:04:57 +00:00
|
|
|
down_read(&EXT4_I(inode)->i_data_sem);
|
2013-03-11 01:01:03 +00:00
|
|
|
if (ext4_test_inode_flag(inode, EXT4_INODE_EXTENTS)) {
|
2020-04-15 20:31:39 +00:00
|
|
|
retval = ext4_ext_map_blocks(handle, inode, map, 0);
|
2013-03-11 01:01:03 +00:00
|
|
|
} else {
|
2020-04-15 20:31:39 +00:00
|
|
|
retval = ext4_ind_map_blocks(handle, inode, map, 0);
|
2013-03-11 01:01:03 +00:00
|
|
|
}
|
2015-12-07 20:04:57 +00:00
|
|
|
up_read((&EXT4_I(inode)->i_data_sem));
|
2013-03-11 01:01:03 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* We don't check m_len because extent will be collpased in status
|
|
|
|
* tree. So the m_len might not equal.
|
|
|
|
*/
|
|
|
|
if (es_map->m_lblk != map->m_lblk ||
|
|
|
|
es_map->m_flags != map->m_flags ||
|
|
|
|
es_map->m_pblk != map->m_pblk) {
|
2013-07-13 04:40:31 +00:00
|
|
|
printk("ES cache assertion failed for inode: %lu "
|
2013-03-11 01:01:03 +00:00
|
|
|
"es_cached ex [%d/%d/%llu/%x] != "
|
|
|
|
"found ex [%d/%d/%llu/%x] retval %d flags %x\n",
|
|
|
|
inode->i_ino, es_map->m_lblk, es_map->m_len,
|
|
|
|
es_map->m_pblk, es_map->m_flags, map->m_lblk,
|
|
|
|
map->m_len, map->m_pblk, map->m_flags,
|
|
|
|
retval, flags);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
#endif /* ES_AGGRESSIVE_TEST */
|
|
|
|
|
2024-05-17 12:39:56 +00:00
|
|
|
static int ext4_map_query_blocks(handle_t *handle, struct inode *inode,
|
|
|
|
struct ext4_map_blocks *map)
|
|
|
|
{
|
|
|
|
unsigned int status;
|
|
|
|
int retval;
|
|
|
|
|
|
|
|
if (ext4_test_inode_flag(inode, EXT4_INODE_EXTENTS))
|
|
|
|
retval = ext4_ext_map_blocks(handle, inode, map, 0);
|
|
|
|
else
|
|
|
|
retval = ext4_ind_map_blocks(handle, inode, map, 0);
|
|
|
|
|
|
|
|
if (retval <= 0)
|
|
|
|
return retval;
|
|
|
|
|
|
|
|
if (unlikely(retval != map->m_len)) {
|
|
|
|
ext4_warning(inode->i_sb,
|
|
|
|
"ES len assertion failed for inode "
|
|
|
|
"%lu: retval %d != map->m_len %d",
|
|
|
|
inode->i_ino, retval, map->m_len);
|
|
|
|
WARN_ON(1);
|
|
|
|
}
|
|
|
|
|
|
|
|
status = map->m_flags & EXT4_MAP_UNWRITTEN ?
|
|
|
|
EXTENT_STATUS_UNWRITTEN : EXTENT_STATUS_WRITTEN;
|
|
|
|
ext4_es_insert_extent(inode, map->m_lblk, map->m_len,
|
2024-09-06 06:14:01 +00:00
|
|
|
map->m_pblk, status, false);
|
2024-05-17 12:39:56 +00:00
|
|
|
return retval;
|
|
|
|
}
|
|
|
|
|
2024-08-13 12:34:41 +00:00
|
|
|
static int ext4_map_create_blocks(handle_t *handle, struct inode *inode,
|
|
|
|
struct ext4_map_blocks *map, int flags)
|
|
|
|
{
|
|
|
|
struct extent_status es;
|
|
|
|
unsigned int status;
|
|
|
|
int err, retval = 0;
|
|
|
|
|
ext4: optimize the EXT4_GET_BLOCKS_DELALLOC_RESERVE flag set
When doing block allocation, magic EXT4_GET_BLOCKS_DELALLOC_RESERVE
means the allocating range covers a range of delayed allocated clusters,
the blocks and quotas have already been reserved in ext4_da_map_blocks(),
we should update the reserved space and don't need to claim them again.
At the moment, we only set this magic in mpage_map_one_extent() when
allocating a range of delayed allocated clusters in the write back path,
it makes things complicated since we have to notice and deal with the
case of allocating non-delayed allocated clusters separately in
ext4_ext_map_blocks(). For example, it we fallocate some blocks that
have been delayed allocated, free space would be claimed again in
ext4_mb_new_blocks() (this is wrong exactily), and we can't claim quota
space again, we have to release the quota reservations made for that
previously delayed allocated clusters.
Move the position thats set the EXT4_GET_BLOCKS_DELALLOC_RESERVE to
where we actually do block allocation, it could simplify above handling
a lot, it means that we always set this magic once the allocation range
covers delalloc blocks, no need to take care of the allocation path.
Signed-off-by: Zhang Yi <yi.zhang@huawei.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://patch.msgid.link/20240813123452.2824659-3-yi.zhang@huaweicloud.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
2024-08-13 12:34:42 +00:00
|
|
|
/*
|
|
|
|
* We pass in the magic EXT4_GET_BLOCKS_DELALLOC_RESERVE
|
|
|
|
* indicates that the blocks and quotas has already been
|
|
|
|
* checked when the data was copied into the page cache.
|
|
|
|
*/
|
|
|
|
if (map->m_flags & EXT4_MAP_DELAYED)
|
|
|
|
flags |= EXT4_GET_BLOCKS_DELALLOC_RESERVE;
|
|
|
|
|
2024-08-13 12:34:41 +00:00
|
|
|
/*
|
|
|
|
* Here we clear m_flags because after allocating an new extent,
|
|
|
|
* it will be set again.
|
|
|
|
*/
|
|
|
|
map->m_flags &= ~EXT4_MAP_FLAGS;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* We need to check for EXT4 here because migrate could have
|
|
|
|
* changed the inode type in between.
|
|
|
|
*/
|
|
|
|
if (ext4_test_inode_flag(inode, EXT4_INODE_EXTENTS)) {
|
|
|
|
retval = ext4_ext_map_blocks(handle, inode, map, flags);
|
|
|
|
} else {
|
|
|
|
retval = ext4_ind_map_blocks(handle, inode, map, flags);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* We allocated new blocks which will result in i_data's
|
|
|
|
* format changing. Force the migrate to fail by clearing
|
|
|
|
* migrate flags.
|
|
|
|
*/
|
|
|
|
if (retval > 0 && map->m_flags & EXT4_MAP_NEW)
|
|
|
|
ext4_clear_inode_state(inode, EXT4_STATE_EXT_MIGRATE);
|
|
|
|
}
|
|
|
|
if (retval <= 0)
|
|
|
|
return retval;
|
|
|
|
|
|
|
|
if (unlikely(retval != map->m_len)) {
|
|
|
|
ext4_warning(inode->i_sb,
|
|
|
|
"ES len assertion failed for inode %lu: "
|
|
|
|
"retval %d != map->m_len %d",
|
|
|
|
inode->i_ino, retval, map->m_len);
|
|
|
|
WARN_ON(1);
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* We have to zeroout blocks before inserting them into extent
|
|
|
|
* status tree. Otherwise someone could look them up there and
|
|
|
|
* use them before they are really zeroed. We also have to
|
|
|
|
* unmap metadata before zeroing as otherwise writeback can
|
|
|
|
* overwrite zeros with stale data from block device.
|
|
|
|
*/
|
|
|
|
if (flags & EXT4_GET_BLOCKS_ZERO &&
|
|
|
|
map->m_flags & EXT4_MAP_MAPPED && map->m_flags & EXT4_MAP_NEW) {
|
|
|
|
err = ext4_issue_zeroout(inode, map->m_lblk, map->m_pblk,
|
|
|
|
map->m_len);
|
|
|
|
if (err)
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* If the extent has been zeroed out, we don't need to update
|
|
|
|
* extent status tree.
|
|
|
|
*/
|
|
|
|
if (flags & EXT4_GET_BLOCKS_PRE_IO &&
|
|
|
|
ext4_es_lookup_extent(inode, map->m_lblk, NULL, &es)) {
|
|
|
|
if (ext4_es_is_written(&es))
|
|
|
|
return retval;
|
|
|
|
}
|
|
|
|
|
|
|
|
status = map->m_flags & EXT4_MAP_UNWRITTEN ?
|
|
|
|
EXTENT_STATUS_UNWRITTEN : EXTENT_STATUS_WRITTEN;
|
2024-09-06 06:14:01 +00:00
|
|
|
ext4_es_insert_extent(inode, map->m_lblk, map->m_len, map->m_pblk,
|
|
|
|
status, flags & EXT4_GET_BLOCKS_DELALLOC_RESERVE);
|
2024-08-13 12:34:41 +00:00
|
|
|
|
2024-05-17 12:39:56 +00:00
|
|
|
return retval;
|
|
|
|
}
|
|
|
|
|
2008-02-25 20:29:55 +00:00
|
|
|
/*
|
2010-05-16 23:00:00 +00:00
|
|
|
* The ext4_map_blocks() function tries to look up the requested blocks,
|
2008-07-26 20:15:44 +00:00
|
|
|
* and returns if the blocks are already mapped.
|
2008-02-25 20:29:55 +00:00
|
|
|
*
|
|
|
|
* Otherwise it takes the write lock of the i_data_sem and allocate blocks
|
|
|
|
* and store the allocated blocks in the result buffer head and mark it
|
|
|
|
* mapped.
|
|
|
|
*
|
2010-05-16 23:00:00 +00:00
|
|
|
* If file type is extents based, it will call ext4_ext_map_blocks(),
|
|
|
|
* Otherwise, call with ext4_ind_map_blocks() to handle indirect mapping
|
2008-02-25 20:29:55 +00:00
|
|
|
* based files
|
|
|
|
*
|
2024-01-18 06:25:11 +00:00
|
|
|
* On success, it returns the number of blocks being mapped or allocated.
|
|
|
|
* If flags doesn't contain EXT4_GET_BLOCKS_CREATE the blocks are
|
|
|
|
* pre-allocated and unwritten, the resulting @map is marked as unwritten.
|
|
|
|
* If the flags contain EXT4_GET_BLOCKS_CREATE, it will mark @map as mapped.
|
2008-02-25 20:29:55 +00:00
|
|
|
*
|
|
|
|
* It returns 0 if plain look up failed (blocks have not been allocated), in
|
2016-03-10 03:54:00 +00:00
|
|
|
* that case, @map is returned as unmapped but we still do fill map->m_len to
|
|
|
|
* indicate the length of a hole starting at map->m_lblk.
|
2008-02-25 20:29:55 +00:00
|
|
|
*
|
|
|
|
* It returns the error in case of allocation failure.
|
|
|
|
*/
|
2010-05-16 23:00:00 +00:00
|
|
|
int ext4_map_blocks(handle_t *handle, struct inode *inode,
|
|
|
|
struct ext4_map_blocks *map, int flags)
|
2008-01-29 04:58:26 +00:00
|
|
|
{
|
2013-02-18 05:29:59 +00:00
|
|
|
struct extent_status es;
|
2008-01-29 04:58:26 +00:00
|
|
|
int retval;
|
2014-03-18 22:05:35 +00:00
|
|
|
int ret = 0;
|
2013-03-11 01:01:03 +00:00
|
|
|
#ifdef ES_AGGRESSIVE_TEST
|
|
|
|
struct ext4_map_blocks orig_map;
|
|
|
|
|
|
|
|
memcpy(&orig_map, map, sizeof(*map));
|
|
|
|
#endif
|
2008-02-25 20:29:55 +00:00
|
|
|
|
2010-05-16 23:00:00 +00:00
|
|
|
map->m_flags = 0;
|
2020-05-10 06:24:55 +00:00
|
|
|
ext_debug(inode, "flag 0x%x, max_blocks %u, logical block %lu\n",
|
|
|
|
flags, map->m_len, (unsigned long) map->m_lblk);
|
2013-02-18 05:29:59 +00:00
|
|
|
|
ext4: avoid possible overflow in ext4_map_blocks()
The ext4_map_blocks() function returns the number of blocks which
satisfying the caller's request. This number of blocks requested by
the caller is specified by an unsigned integer, but the return value
of ext4_map_blocks() is a signed integer (to accomodate error codes
per the kernel's standard error signalling convention).
Historically, overflows could never happen since mballoc() will refuse
to allocate more than 2048 blocks at a time (which is something we
should fix), and if the blocks were already allocated, the fact that
there would be some number of intervening metadata blocks pretty much
guaranteed that there could never be a contiguous region of data
blocks that was greater than 2**31 blocks.
However, this is now possible if there is a file system which is a bit
bigger than 8TB, and is created using the new mke2fs hugeblock
feature, which can create a perfectly contiguous file. In that case,
if a userspace program attempted to call fallocate() on this already
fully allocated file, it's possible that ext4_map_blocks() could
return a number large enough that it would overflow a signed integer,
resulting in a ext4 thinking that the ext4_map_blocks() call had
failed with some strange error code.
Since ext4_map_blocks() is always free to return a smaller number of
blocks than what was requested by the caller, fix this by capping the
number of blocks that ext4_map_blocks() will ever try to map to 2**31
- 1. In practice this should never get hit, except by someone
deliberately trying to provke the above-described bug.
Thanks to the PaX team for asking whethre this could possibly happen
in some off-line discussions about using some static code checking
technology they are developing to find bugs in kernel code.
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2014-02-20 17:54:05 +00:00
|
|
|
/*
|
|
|
|
* ext4_map_blocks returns an int, and m_len is an unsigned int
|
|
|
|
*/
|
|
|
|
if (unlikely(map->m_len > INT_MAX))
|
|
|
|
map->m_len = INT_MAX;
|
|
|
|
|
2014-04-07 14:53:28 +00:00
|
|
|
/* We can handle the block number less than EXT_MAX_BLOCKS */
|
|
|
|
if (unlikely(map->m_lblk >= EXT_MAX_BLOCKS))
|
2015-10-17 20:16:04 +00:00
|
|
|
return -EFSCORRUPTED;
|
2014-04-07 14:53:28 +00:00
|
|
|
|
2013-02-18 05:29:59 +00:00
|
|
|
/* Lookup extent status tree firstly */
|
2020-10-15 20:37:59 +00:00
|
|
|
if (!(EXT4_SB(inode->i_sb)->s_mount_state & EXT4_FC_REPLAY) &&
|
|
|
|
ext4_es_lookup_extent(inode, map->m_lblk, NULL, &es)) {
|
2013-02-18 05:29:59 +00:00
|
|
|
if (ext4_es_is_written(&es) || ext4_es_is_unwritten(&es)) {
|
|
|
|
map->m_pblk = ext4_es_pblock(&es) +
|
|
|
|
map->m_lblk - es.es_lblk;
|
|
|
|
map->m_flags |= ext4_es_is_written(&es) ?
|
|
|
|
EXT4_MAP_MAPPED : EXT4_MAP_UNWRITTEN;
|
|
|
|
retval = es.es_len - (map->m_lblk - es.es_lblk);
|
|
|
|
if (retval > map->m_len)
|
|
|
|
retval = map->m_len;
|
|
|
|
map->m_len = retval;
|
|
|
|
} else if (ext4_es_is_delayed(&es) || ext4_es_is_hole(&es)) {
|
2016-03-10 03:54:00 +00:00
|
|
|
map->m_pblk = 0;
|
2024-01-27 01:58:04 +00:00
|
|
|
map->m_flags |= ext4_es_is_delayed(&es) ?
|
|
|
|
EXT4_MAP_DELAYED : 0;
|
2016-03-10 03:54:00 +00:00
|
|
|
retval = es.es_len - (map->m_lblk - es.es_lblk);
|
|
|
|
if (retval > map->m_len)
|
|
|
|
retval = map->m_len;
|
|
|
|
map->m_len = retval;
|
2013-02-18 05:29:59 +00:00
|
|
|
retval = 0;
|
|
|
|
} else {
|
2019-04-07 16:24:43 +00:00
|
|
|
BUG();
|
2013-02-18 05:29:59 +00:00
|
|
|
}
|
2022-04-24 14:09:35 +00:00
|
|
|
|
|
|
|
if (flags & EXT4_GET_BLOCKS_CACHED_NOWAIT)
|
|
|
|
return retval;
|
2013-03-11 01:01:03 +00:00
|
|
|
#ifdef ES_AGGRESSIVE_TEST
|
|
|
|
ext4_map_blocks_es_recheck(handle, inode, map,
|
|
|
|
&orig_map, flags);
|
|
|
|
#endif
|
2013-02-18 05:29:59 +00:00
|
|
|
goto found;
|
|
|
|
}
|
2022-04-24 14:09:35 +00:00
|
|
|
/*
|
|
|
|
* In the query cache no-wait mode, nothing we can do more if we
|
|
|
|
* cannot find extent in the cache.
|
|
|
|
*/
|
|
|
|
if (flags & EXT4_GET_BLOCKS_CACHED_NOWAIT)
|
|
|
|
return 0;
|
2013-02-18 05:29:59 +00:00
|
|
|
|
2008-01-29 04:58:29 +00:00
|
|
|
/*
|
2009-05-14 04:54:29 +00:00
|
|
|
* Try to see if we can get the block without requesting a new
|
|
|
|
* file system block.
|
2008-01-29 04:58:29 +00:00
|
|
|
*/
|
2015-12-07 20:04:57 +00:00
|
|
|
down_read(&EXT4_I(inode)->i_data_sem);
|
2024-08-13 12:34:48 +00:00
|
|
|
retval = ext4_map_query_blocks(handle, inode, map);
|
2015-12-07 20:04:57 +00:00
|
|
|
up_read((&EXT4_I(inode)->i_data_sem));
|
2008-02-25 20:29:55 +00:00
|
|
|
|
2013-02-18 05:29:59 +00:00
|
|
|
found:
|
2010-05-16 23:00:00 +00:00
|
|
|
if (retval > 0 && map->m_flags & EXT4_MAP_MAPPED) {
|
2014-03-18 22:05:35 +00:00
|
|
|
ret = check_block_validity(inode, map);
|
2009-05-17 19:38:01 +00:00
|
|
|
if (ret != 0)
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2008-02-25 20:29:55 +00:00
|
|
|
/* If it is only a block(s) look up */
|
2009-05-14 04:58:52 +00:00
|
|
|
if ((flags & EXT4_GET_BLOCKS_CREATE) == 0)
|
2008-02-25 20:29:55 +00:00
|
|
|
return retval;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Returns if the blocks have already allocated
|
|
|
|
*
|
|
|
|
* Note that if blocks have been preallocated
|
2024-01-18 06:25:11 +00:00
|
|
|
* ext4_ext_map_blocks() returns with buffer head unmapped
|
2008-02-25 20:29:55 +00:00
|
|
|
*/
|
2010-05-16 23:00:00 +00:00
|
|
|
if (retval > 0 && map->m_flags & EXT4_MAP_MAPPED)
|
2014-03-18 22:05:35 +00:00
|
|
|
/*
|
|
|
|
* If we need to convert extent to unwritten
|
|
|
|
* we continue and do the actual work in
|
|
|
|
* ext4_ext_map_blocks()
|
|
|
|
*/
|
|
|
|
if (!(flags & EXT4_GET_BLOCKS_CONVERT_UNWRITTEN))
|
|
|
|
return retval;
|
2008-01-29 04:58:29 +00:00
|
|
|
|
|
|
|
/*
|
2014-04-21 03:45:47 +00:00
|
|
|
* New blocks allocate and/or writing to unwritten extent
|
2008-02-25 20:29:55 +00:00
|
|
|
* will possibly result in updating i_data, so we take
|
2014-09-02 02:15:30 +00:00
|
|
|
* the write lock of i_data_sem, and call get_block()
|
2008-02-25 20:29:55 +00:00
|
|
|
* with create == 1 flag.
|
2008-01-29 04:58:29 +00:00
|
|
|
*/
|
2014-05-12 16:55:07 +00:00
|
|
|
down_write(&EXT4_I(inode)->i_data_sem);
|
2024-08-13 12:34:41 +00:00
|
|
|
retval = ext4_map_create_blocks(handle, inode, map, flags);
|
2008-01-29 04:58:29 +00:00
|
|
|
up_write((&EXT4_I(inode)->i_data_sem));
|
2010-05-16 23:00:00 +00:00
|
|
|
if (retval > 0 && map->m_flags & EXT4_MAP_MAPPED) {
|
2014-03-18 22:05:35 +00:00
|
|
|
ret = check_block_validity(inode, map);
|
2009-05-17 19:38:01 +00:00
|
|
|
if (ret != 0)
|
|
|
|
return ret;
|
2016-04-24 04:56:03 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Inodes with freshly allocated blocks where contents will be
|
|
|
|
* visible after transaction commit must be on transaction's
|
|
|
|
* ordered data list.
|
|
|
|
*/
|
|
|
|
if (map->m_flags & EXT4_MAP_NEW &&
|
|
|
|
!(map->m_flags & EXT4_MAP_UNWRITTEN) &&
|
|
|
|
!(flags & EXT4_GET_BLOCKS_ZERO) &&
|
2017-06-22 15:31:25 +00:00
|
|
|
!ext4_is_quota_file(inode) &&
|
2016-04-24 04:56:03 +00:00
|
|
|
ext4_should_order_data(inode)) {
|
2019-06-20 21:26:26 +00:00
|
|
|
loff_t start_byte =
|
|
|
|
(loff_t)map->m_lblk << inode->i_blkbits;
|
|
|
|
loff_t length = (loff_t)map->m_len << inode->i_blkbits;
|
|
|
|
|
2016-04-24 04:56:08 +00:00
|
|
|
if (flags & EXT4_GET_BLOCKS_IO_SUBMIT)
|
2019-06-20 21:26:26 +00:00
|
|
|
ret = ext4_jbd2_inode_add_wait(handle, inode,
|
|
|
|
start_byte, length);
|
2016-04-24 04:56:08 +00:00
|
|
|
else
|
2019-06-20 21:26:26 +00:00
|
|
|
ret = ext4_jbd2_inode_add_write(handle, inode,
|
|
|
|
start_byte, length);
|
2016-04-24 04:56:03 +00:00
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
}
|
2009-05-17 19:38:01 +00:00
|
|
|
}
|
2021-12-21 02:28:39 +00:00
|
|
|
if (retval > 0 && (map->m_flags & EXT4_MAP_UNWRITTEN ||
|
|
|
|
map->m_flags & EXT4_MAP_MAPPED))
|
|
|
|
ext4_fc_track_range(handle, inode, map->m_lblk,
|
|
|
|
map->m_lblk + map->m_len - 1);
|
2020-05-10 06:24:52 +00:00
|
|
|
if (retval < 0)
|
2020-05-10 06:24:55 +00:00
|
|
|
ext_debug(inode, "failed with err %d\n", retval);
|
2008-01-29 04:58:26 +00:00
|
|
|
return retval;
|
|
|
|
}
|
|
|
|
|
2016-02-19 05:18:25 +00:00
|
|
|
/*
|
|
|
|
* Update EXT4_MAP_FLAGS in bh->b_state. For buffer heads attached to pages
|
|
|
|
* we have to be careful as someone else may be manipulating b_state as well.
|
|
|
|
*/
|
|
|
|
static void ext4_update_bh_state(struct buffer_head *bh, unsigned long flags)
|
|
|
|
{
|
|
|
|
unsigned long old_state;
|
|
|
|
unsigned long new_state;
|
|
|
|
|
|
|
|
flags &= EXT4_MAP_FLAGS;
|
|
|
|
|
|
|
|
/* Dummy buffer_head? Set non-atomically. */
|
|
|
|
if (!bh->b_page) {
|
|
|
|
bh->b_state = (bh->b_state & ~EXT4_MAP_FLAGS) | flags;
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
/*
|
|
|
|
* Someone else may be modifying b_state. Be careful! This is ugly but
|
|
|
|
* once we get rid of using bh as a container for mapping information
|
|
|
|
* to pass to / from get_block functions, this can go away.
|
|
|
|
*/
|
2022-11-02 07:11:47 +00:00
|
|
|
old_state = READ_ONCE(bh->b_state);
|
2016-02-19 05:18:25 +00:00
|
|
|
do {
|
|
|
|
new_state = (old_state & ~EXT4_MAP_FLAGS) | flags;
|
2022-11-02 07:11:47 +00:00
|
|
|
} while (unlikely(!try_cmpxchg(&bh->b_state, &old_state, new_state)));
|
2016-02-19 05:18:25 +00:00
|
|
|
}
|
|
|
|
|
2010-05-17 00:00:00 +00:00
|
|
|
static int _ext4_get_block(struct inode *inode, sector_t iblock,
|
|
|
|
struct buffer_head *bh, int flags)
|
2006-10-11 08:20:50 +00:00
|
|
|
{
|
2010-05-17 00:00:00 +00:00
|
|
|
struct ext4_map_blocks map;
|
2016-03-09 04:35:46 +00:00
|
|
|
int ret = 0;
|
2006-10-11 08:20:50 +00:00
|
|
|
|
2012-12-10 19:04:52 +00:00
|
|
|
if (ext4_has_inline_data(inode))
|
|
|
|
return -ERANGE;
|
|
|
|
|
2010-05-17 00:00:00 +00:00
|
|
|
map.m_lblk = iblock;
|
|
|
|
map.m_len = bh->b_size >> inode->i_blkbits;
|
|
|
|
|
2016-03-09 04:35:46 +00:00
|
|
|
ret = ext4_map_blocks(ext4_journal_current_handle(), inode, &map,
|
|
|
|
flags);
|
2008-02-10 06:08:38 +00:00
|
|
|
if (ret > 0) {
|
2010-05-17 00:00:00 +00:00
|
|
|
map_bh(bh, inode->i_sb, map.m_pblk);
|
2016-02-19 05:18:25 +00:00
|
|
|
ext4_update_bh_state(bh, map.m_flags);
|
2010-05-17 00:00:00 +00:00
|
|
|
bh->b_size = inode->i_sb->s_blocksize * map.m_len;
|
2008-02-10 06:08:38 +00:00
|
|
|
ret = 0;
|
2016-11-08 00:30:58 +00:00
|
|
|
} else if (ret == 0) {
|
|
|
|
/* hole case, need to fill in bh->b_size */
|
|
|
|
bh->b_size = inode->i_sb->s_blocksize * map.m_len;
|
2006-10-11 08:20:50 +00:00
|
|
|
}
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2010-05-17 00:00:00 +00:00
|
|
|
int ext4_get_block(struct inode *inode, sector_t iblock,
|
|
|
|
struct buffer_head *bh, int create)
|
|
|
|
{
|
|
|
|
return _ext4_get_block(inode, iblock, bh,
|
|
|
|
create ? EXT4_GET_BLOCKS_CREATE : 0);
|
|
|
|
}
|
|
|
|
|
2016-03-09 04:08:10 +00:00
|
|
|
/*
|
|
|
|
* Get block function used when preparing for buffered write if we require
|
|
|
|
* creating an unwritten extent if blocks haven't been allocated. The extent
|
|
|
|
* will be converted to written after the IO is complete.
|
|
|
|
*/
|
|
|
|
int ext4_get_block_unwritten(struct inode *inode, sector_t iblock,
|
|
|
|
struct buffer_head *bh_result, int create)
|
|
|
|
{
|
ext4: mark buffer new if it is unwritten to avoid stale data exposure
** Short Version **
In ext4 with dioread_nolock, we could have a scenario where the bh returned by
get_blocks (ext4_get_block_unwritten()) in __block_write_begin_int() has
UNWRITTEN and MAPPED flag set. Since such a bh does not have NEW flag set we
never zero out the range of bh that is not under write, causing whatever stale
data is present in the folio at that time to be written out to disk. To fix this
mark the buffer as new, in case it is unwritten, in ext4_get_block_unwritten().
** Long Version **
The issue mentioned above was resulting in two different bugs:
1. On block size < page size case in ext4, generic/269 was reliably
failing with dioread_nolock. The state of the write was as follows:
* The write was extending i_size.
* The last block of the file was fallocated and had an unwritten extent
* We were near ENOSPC and hence we were switching to non-delayed alloc
allocation.
In this case, the back trace that triggers the bug is as follows:
ext4_da_write_begin()
/* switch to nodelalloc due to low space */
ext4_write_begin()
ext4_should_dioread_nolock() // true since mount flags still have delalloc
__block_write_begin(..., ext4_get_block_unwritten)
__block_write_begin_int()
for(each buffer head in page) {
/* first iteration, this is bh1 which contains i_size */
if (!buffer_mapped)
get_block() /* returns bh with only UNWRITTEN and MAPPED */
/* second iteration, bh2 */
if (!buffer_mapped)
get_block() /* we fail here, could be ENOSPC */
}
if (err)
/*
* this would zero out all new buffers and mark them uptodate.
* Since bh1 was never marked new, we skip it here which causes
* the bug later.
*/
folio_zero_new_buffers();
/* ext4_wrte_begin() error handling */
ext4_truncate_failed_write()
ext4_truncate()
ext4_block_truncate_page()
__ext4_block_zero_page_range()
if(!buffer_uptodate())
ext4_read_bh_lock()
ext4_read_bh() -> ... ext4_submit_bh_wbc()
BUG_ON(buffer_unwritten(bh)); /* !!! */
2. The second issue is stale data exposure with page size >= blocksize
with dioread_nolock. The conditions needed for it to happen are same as
the previous issue ie dioread_nolock around ENOSPC condition. The issue
is also similar where in __block_write_begin_int() when we call
ext4_get_block_unwritten() on the buffer_head and the underlying extent
is unwritten, we get an unwritten and mapped buffer head. Since it is
not new, we never zero out the partial range which is not under write,
thus writing stale data to disk. This can be easily observed with the
following reproducer:
fallocate -l 4k testfile
xfs_io -c "pwrite 2k 2k" testfile
# hexdump output will have stale data in from byte 0 to 2k in testfile
hexdump -C testfile
NOTE: To trigger this, we need dioread_nolock enabled and write happening via
ext4_write_begin(), which is usually used when we have -o nodealloc. Since
dioread_nolock is disabled with nodelalloc, the only alternate way to call
ext4_write_begin() is to ensure that delayed alloc switches to nodelalloc ie
ext4_da_write_begin() calls ext4_write_begin(). This will usually happen when
ext4 is almost full like the way generic/269 was triggering it in Issue 1 above.
This might make the issue harder to hit. Hence, for reliable replication, I used
the below patch to temporarily allow dioread_nolock with nodelalloc and then
mount the disk with -o nodealloc,dioread_nolock. With this you can hit the stale
data issue 100% of times:
@@ -508,8 +508,8 @@ static inline int ext4_should_dioread_nolock(struct inode *inode)
if (ext4_should_journal_data(inode))
return 0;
/* temporary fix to prevent generic/422 test failures */
- if (!test_opt(inode->i_sb, DELALLOC))
- return 0;
+ // if (!test_opt(inode->i_sb, DELALLOC))
+ // return 0;
return 1;
}
After applying this patch to mark buffer as NEW, both the above issues are
fixed.
Signed-off-by: Ojaswin Mujoo <ojaswin@linux.ibm.com>
Cc: stable@kernel.org
Reviewed-by: Jan Kara <jack@suse.cz>
Reviewed-by: "Ritesh Harjani (IBM)" <ritesh.list@gmail.com>
Link: https://lore.kernel.org/r/d0ed09d70a9733fbb5349c5c7b125caac186ecdf.1695033645.git.ojaswin@linux.ibm.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
2023-09-18 10:45:50 +00:00
|
|
|
int ret = 0;
|
|
|
|
|
2016-03-09 04:08:10 +00:00
|
|
|
ext4_debug("ext4_get_block_unwritten: inode %lu, create flag %d\n",
|
|
|
|
inode->i_ino, create);
|
ext4: mark buffer new if it is unwritten to avoid stale data exposure
** Short Version **
In ext4 with dioread_nolock, we could have a scenario where the bh returned by
get_blocks (ext4_get_block_unwritten()) in __block_write_begin_int() has
UNWRITTEN and MAPPED flag set. Since such a bh does not have NEW flag set we
never zero out the range of bh that is not under write, causing whatever stale
data is present in the folio at that time to be written out to disk. To fix this
mark the buffer as new, in case it is unwritten, in ext4_get_block_unwritten().
** Long Version **
The issue mentioned above was resulting in two different bugs:
1. On block size < page size case in ext4, generic/269 was reliably
failing with dioread_nolock. The state of the write was as follows:
* The write was extending i_size.
* The last block of the file was fallocated and had an unwritten extent
* We were near ENOSPC and hence we were switching to non-delayed alloc
allocation.
In this case, the back trace that triggers the bug is as follows:
ext4_da_write_begin()
/* switch to nodelalloc due to low space */
ext4_write_begin()
ext4_should_dioread_nolock() // true since mount flags still have delalloc
__block_write_begin(..., ext4_get_block_unwritten)
__block_write_begin_int()
for(each buffer head in page) {
/* first iteration, this is bh1 which contains i_size */
if (!buffer_mapped)
get_block() /* returns bh with only UNWRITTEN and MAPPED */
/* second iteration, bh2 */
if (!buffer_mapped)
get_block() /* we fail here, could be ENOSPC */
}
if (err)
/*
* this would zero out all new buffers and mark them uptodate.
* Since bh1 was never marked new, we skip it here which causes
* the bug later.
*/
folio_zero_new_buffers();
/* ext4_wrte_begin() error handling */
ext4_truncate_failed_write()
ext4_truncate()
ext4_block_truncate_page()
__ext4_block_zero_page_range()
if(!buffer_uptodate())
ext4_read_bh_lock()
ext4_read_bh() -> ... ext4_submit_bh_wbc()
BUG_ON(buffer_unwritten(bh)); /* !!! */
2. The second issue is stale data exposure with page size >= blocksize
with dioread_nolock. The conditions needed for it to happen are same as
the previous issue ie dioread_nolock around ENOSPC condition. The issue
is also similar where in __block_write_begin_int() when we call
ext4_get_block_unwritten() on the buffer_head and the underlying extent
is unwritten, we get an unwritten and mapped buffer head. Since it is
not new, we never zero out the partial range which is not under write,
thus writing stale data to disk. This can be easily observed with the
following reproducer:
fallocate -l 4k testfile
xfs_io -c "pwrite 2k 2k" testfile
# hexdump output will have stale data in from byte 0 to 2k in testfile
hexdump -C testfile
NOTE: To trigger this, we need dioread_nolock enabled and write happening via
ext4_write_begin(), which is usually used when we have -o nodealloc. Since
dioread_nolock is disabled with nodelalloc, the only alternate way to call
ext4_write_begin() is to ensure that delayed alloc switches to nodelalloc ie
ext4_da_write_begin() calls ext4_write_begin(). This will usually happen when
ext4 is almost full like the way generic/269 was triggering it in Issue 1 above.
This might make the issue harder to hit. Hence, for reliable replication, I used
the below patch to temporarily allow dioread_nolock with nodelalloc and then
mount the disk with -o nodealloc,dioread_nolock. With this you can hit the stale
data issue 100% of times:
@@ -508,8 +508,8 @@ static inline int ext4_should_dioread_nolock(struct inode *inode)
if (ext4_should_journal_data(inode))
return 0;
/* temporary fix to prevent generic/422 test failures */
- if (!test_opt(inode->i_sb, DELALLOC))
- return 0;
+ // if (!test_opt(inode->i_sb, DELALLOC))
+ // return 0;
return 1;
}
After applying this patch to mark buffer as NEW, both the above issues are
fixed.
Signed-off-by: Ojaswin Mujoo <ojaswin@linux.ibm.com>
Cc: stable@kernel.org
Reviewed-by: Jan Kara <jack@suse.cz>
Reviewed-by: "Ritesh Harjani (IBM)" <ritesh.list@gmail.com>
Link: https://lore.kernel.org/r/d0ed09d70a9733fbb5349c5c7b125caac186ecdf.1695033645.git.ojaswin@linux.ibm.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
2023-09-18 10:45:50 +00:00
|
|
|
ret = _ext4_get_block(inode, iblock, bh_result,
|
2022-05-20 11:14:02 +00:00
|
|
|
EXT4_GET_BLOCKS_CREATE_UNWRIT_EXT);
|
ext4: mark buffer new if it is unwritten to avoid stale data exposure
** Short Version **
In ext4 with dioread_nolock, we could have a scenario where the bh returned by
get_blocks (ext4_get_block_unwritten()) in __block_write_begin_int() has
UNWRITTEN and MAPPED flag set. Since such a bh does not have NEW flag set we
never zero out the range of bh that is not under write, causing whatever stale
data is present in the folio at that time to be written out to disk. To fix this
mark the buffer as new, in case it is unwritten, in ext4_get_block_unwritten().
** Long Version **
The issue mentioned above was resulting in two different bugs:
1. On block size < page size case in ext4, generic/269 was reliably
failing with dioread_nolock. The state of the write was as follows:
* The write was extending i_size.
* The last block of the file was fallocated and had an unwritten extent
* We were near ENOSPC and hence we were switching to non-delayed alloc
allocation.
In this case, the back trace that triggers the bug is as follows:
ext4_da_write_begin()
/* switch to nodelalloc due to low space */
ext4_write_begin()
ext4_should_dioread_nolock() // true since mount flags still have delalloc
__block_write_begin(..., ext4_get_block_unwritten)
__block_write_begin_int()
for(each buffer head in page) {
/* first iteration, this is bh1 which contains i_size */
if (!buffer_mapped)
get_block() /* returns bh with only UNWRITTEN and MAPPED */
/* second iteration, bh2 */
if (!buffer_mapped)
get_block() /* we fail here, could be ENOSPC */
}
if (err)
/*
* this would zero out all new buffers and mark them uptodate.
* Since bh1 was never marked new, we skip it here which causes
* the bug later.
*/
folio_zero_new_buffers();
/* ext4_wrte_begin() error handling */
ext4_truncate_failed_write()
ext4_truncate()
ext4_block_truncate_page()
__ext4_block_zero_page_range()
if(!buffer_uptodate())
ext4_read_bh_lock()
ext4_read_bh() -> ... ext4_submit_bh_wbc()
BUG_ON(buffer_unwritten(bh)); /* !!! */
2. The second issue is stale data exposure with page size >= blocksize
with dioread_nolock. The conditions needed for it to happen are same as
the previous issue ie dioread_nolock around ENOSPC condition. The issue
is also similar where in __block_write_begin_int() when we call
ext4_get_block_unwritten() on the buffer_head and the underlying extent
is unwritten, we get an unwritten and mapped buffer head. Since it is
not new, we never zero out the partial range which is not under write,
thus writing stale data to disk. This can be easily observed with the
following reproducer:
fallocate -l 4k testfile
xfs_io -c "pwrite 2k 2k" testfile
# hexdump output will have stale data in from byte 0 to 2k in testfile
hexdump -C testfile
NOTE: To trigger this, we need dioread_nolock enabled and write happening via
ext4_write_begin(), which is usually used when we have -o nodealloc. Since
dioread_nolock is disabled with nodelalloc, the only alternate way to call
ext4_write_begin() is to ensure that delayed alloc switches to nodelalloc ie
ext4_da_write_begin() calls ext4_write_begin(). This will usually happen when
ext4 is almost full like the way generic/269 was triggering it in Issue 1 above.
This might make the issue harder to hit. Hence, for reliable replication, I used
the below patch to temporarily allow dioread_nolock with nodelalloc and then
mount the disk with -o nodealloc,dioread_nolock. With this you can hit the stale
data issue 100% of times:
@@ -508,8 +508,8 @@ static inline int ext4_should_dioread_nolock(struct inode *inode)
if (ext4_should_journal_data(inode))
return 0;
/* temporary fix to prevent generic/422 test failures */
- if (!test_opt(inode->i_sb, DELALLOC))
- return 0;
+ // if (!test_opt(inode->i_sb, DELALLOC))
+ // return 0;
return 1;
}
After applying this patch to mark buffer as NEW, both the above issues are
fixed.
Signed-off-by: Ojaswin Mujoo <ojaswin@linux.ibm.com>
Cc: stable@kernel.org
Reviewed-by: Jan Kara <jack@suse.cz>
Reviewed-by: "Ritesh Harjani (IBM)" <ritesh.list@gmail.com>
Link: https://lore.kernel.org/r/d0ed09d70a9733fbb5349c5c7b125caac186ecdf.1695033645.git.ojaswin@linux.ibm.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
2023-09-18 10:45:50 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* If the buffer is marked unwritten, mark it as new to make sure it is
|
|
|
|
* zeroed out correctly in case of partial writes. Otherwise, there is
|
|
|
|
* a chance of stale data getting exposed.
|
|
|
|
*/
|
|
|
|
if (ret == 0 && buffer_unwritten(bh_result))
|
|
|
|
set_buffer_new(bh_result);
|
|
|
|
|
|
|
|
return ret;
|
2016-03-09 04:08:10 +00:00
|
|
|
}
|
|
|
|
|
2016-03-09 04:35:46 +00:00
|
|
|
/* Maximum number of blocks we map for direct IO at once. */
|
|
|
|
#define DIO_MAX_BLOCKS 4096
|
|
|
|
|
2006-10-11 08:20:50 +00:00
|
|
|
/*
|
|
|
|
* `handle' can be NULL if create is zero
|
|
|
|
*/
|
2006-10-11 08:20:53 +00:00
|
|
|
struct buffer_head *ext4_getblk(handle_t *handle, struct inode *inode,
|
2015-06-21 05:25:29 +00:00
|
|
|
ext4_lblk_t block, int map_flags)
|
2006-10-11 08:20:50 +00:00
|
|
|
{
|
2010-05-17 00:00:00 +00:00
|
|
|
struct ext4_map_blocks map;
|
|
|
|
struct buffer_head *bh;
|
2015-06-21 05:25:29 +00:00
|
|
|
int create = map_flags & EXT4_GET_BLOCKS_CREATE;
|
2022-04-24 14:09:35 +00:00
|
|
|
bool nowait = map_flags & EXT4_GET_BLOCKS_CACHED_NOWAIT;
|
2014-08-30 00:51:32 +00:00
|
|
|
int err;
|
2006-10-11 08:20:50 +00:00
|
|
|
|
2020-11-07 15:58:11 +00:00
|
|
|
ASSERT((EXT4_SB(inode->i_sb)->s_mount_state & EXT4_FC_REPLAY)
|
|
|
|
|| handle != NULL || create == 0);
|
2022-04-24 14:09:35 +00:00
|
|
|
ASSERT(create == 0 || !nowait);
|
2006-10-11 08:20:50 +00:00
|
|
|
|
2010-05-17 00:00:00 +00:00
|
|
|
map.m_lblk = block;
|
|
|
|
map.m_len = 1;
|
2015-06-21 05:25:29 +00:00
|
|
|
err = ext4_map_blocks(handle, inode, &map, map_flags);
|
2006-10-11 08:20:50 +00:00
|
|
|
|
2014-08-30 00:51:32 +00:00
|
|
|
if (err == 0)
|
|
|
|
return create ? ERR_PTR(-ENOSPC) : NULL;
|
2010-05-17 00:00:00 +00:00
|
|
|
if (err < 0)
|
2014-08-30 00:51:32 +00:00
|
|
|
return ERR_PTR(err);
|
2010-05-17 00:00:00 +00:00
|
|
|
|
2022-04-24 14:09:35 +00:00
|
|
|
if (nowait)
|
|
|
|
return sb_find_get_block(inode->i_sb, map.m_pblk);
|
|
|
|
|
fs: ext4: Don't use CMA for buffer_head
cma_alloc() keep failed in our system which thanks to a jh->bh->b_page
can not be migrated out of CMA area[1] as the jh has one cp_transaction
pending on it because of j_free > j_max_transaction_buffers[2][3][4][5][6].
We temporarily solve this by launching jbd2_log_do_checkpoint forcefully
somewhere. Since journal is common mechanism to all JFSs and
cp_transaction has a little fewer opportunity to be launched, the
cma_alloc() could be affected under the same scenario. This patch
would like to have buffer_head of ext4 not use CMA pages when doing
sb_getblk.
[1]
crash_arm64_v8.0.4++> kmem -p|grep ffffff808f0aa150(sb->s_bdev->bd_inode->i_mapping)
fffffffe01a51c00 e9470000 ffffff808f0aa150 3 2 8000000008020 lru,private
fffffffe03d189c0 174627000 ffffff808f0aa150 4 2 2004000000008020 lru,private
fffffffe03d88e00 176238000 ffffff808f0aa150 3f9 2 2008000000008020 lru,private
fffffffe03d88e40 176239000 ffffff808f0aa150 6 2 2008000000008020 lru,private
fffffffe03d88e80 17623a000 ffffff808f0aa150 5 2 2008000000008020 lru,private
fffffffe03d88ec0 17623b000 ffffff808f0aa150 1 2 2008000000008020 lru,private
fffffffe03d88f00 17623c000 ffffff808f0aa150 0 2 2008000000008020 lru,private
fffffffe040e6540 183995000 ffffff808f0aa150 3f4 2 2004000000008020 lru,private
[2] page -> buffer_head
crash_arm64_v8.0.4++> struct page.private fffffffe01a51c00 -x
private = 0xffffff802fca0c00
[3] buffer_head -> journal_head
crash_arm64_v8.0.4++> struct buffer_head.b_private 0xffffff802fca0c00
b_private = 0xffffff8041338e10,
[4] journal_head -> b_cp_transaction
crash_arm64_v8.0.4++> struct journal_head.b_cp_transaction 0xffffff8041338e10 -x
b_cp_transaction = 0xffffff80410f1900,
[5] transaction_t -> journal
crash_arm64_v8.0.4++> struct transaction_t.t_journal 0xffffff80410f1900 -x
t_journal = 0xffffff80e70f3000,
[6] j_free & j_max_transaction_buffers
crash_arm64_v8.0.4++> struct journal_t.j_free,j_max_transaction_buffers 0xffffff80e70f3000 -x
j_free = 0x3f1,
j_max_transaction_buffers = 0x100,
Suggested-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Zhaoyang Huang <zhaoyang.huang@unisoc.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://patch.msgid.link/20240904075300.1148836-1-zhaoyang.huang@unisoc.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
2024-09-04 07:53:00 +00:00
|
|
|
/*
|
|
|
|
* Since bh could introduce extra ref count such as referred by
|
|
|
|
* journal_head etc. Try to avoid using __GFP_MOVABLE here
|
|
|
|
* as it may fail the migration when journal_head remains.
|
|
|
|
*/
|
|
|
|
bh = getblk_unmovable(inode->i_sb->s_bdev, map.m_pblk,
|
|
|
|
inode->i_sb->s_blocksize);
|
|
|
|
|
2014-08-30 00:51:32 +00:00
|
|
|
if (unlikely(!bh))
|
|
|
|
return ERR_PTR(-ENOMEM);
|
2010-05-17 00:00:00 +00:00
|
|
|
if (map.m_flags & EXT4_MAP_NEW) {
|
2020-11-07 15:58:11 +00:00
|
|
|
ASSERT(create != 0);
|
|
|
|
ASSERT((EXT4_SB(inode->i_sb)->s_mount_state & EXT4_FC_REPLAY)
|
|
|
|
|| (handle != NULL));
|
2006-10-11 08:20:50 +00:00
|
|
|
|
2010-05-17 00:00:00 +00:00
|
|
|
/*
|
|
|
|
* Now that we do not always journal data, we should
|
|
|
|
* keep in mind whether this should always journal the
|
|
|
|
* new buffer as metadata. For now, regular file
|
|
|
|
* writes use ext4_get_block instead, so it's not a
|
|
|
|
* problem.
|
|
|
|
*/
|
|
|
|
lock_buffer(bh);
|
|
|
|
BUFFER_TRACE(bh, "call get_create_access");
|
2021-08-16 09:57:04 +00:00
|
|
|
err = ext4_journal_get_create_access(handle, inode->i_sb, bh,
|
|
|
|
EXT4_JTR_NONE);
|
2014-08-30 00:51:32 +00:00
|
|
|
if (unlikely(err)) {
|
|
|
|
unlock_buffer(bh);
|
|
|
|
goto errout;
|
|
|
|
}
|
|
|
|
if (!buffer_uptodate(bh)) {
|
2010-05-17 00:00:00 +00:00
|
|
|
memset(bh->b_data, 0, inode->i_sb->s_blocksize);
|
|
|
|
set_buffer_uptodate(bh);
|
2006-10-11 08:20:50 +00:00
|
|
|
}
|
2010-05-17 00:00:00 +00:00
|
|
|
unlock_buffer(bh);
|
|
|
|
BUFFER_TRACE(bh, "call ext4_handle_dirty_metadata");
|
|
|
|
err = ext4_handle_dirty_metadata(handle, inode, bh);
|
2014-08-30 00:51:32 +00:00
|
|
|
if (unlikely(err))
|
|
|
|
goto errout;
|
|
|
|
} else
|
2010-05-17 00:00:00 +00:00
|
|
|
BUFFER_TRACE(bh, "not a new buffer");
|
|
|
|
return bh;
|
2014-08-30 00:51:32 +00:00
|
|
|
errout:
|
|
|
|
brelse(bh);
|
|
|
|
return ERR_PTR(err);
|
2006-10-11 08:20:50 +00:00
|
|
|
}
|
|
|
|
|
2006-10-11 08:20:53 +00:00
|
|
|
struct buffer_head *ext4_bread(handle_t *handle, struct inode *inode,
|
2015-06-21 05:25:29 +00:00
|
|
|
ext4_lblk_t block, int map_flags)
|
2006-10-11 08:20:50 +00:00
|
|
|
{
|
2008-09-09 02:25:24 +00:00
|
|
|
struct buffer_head *bh;
|
2020-09-24 07:33:33 +00:00
|
|
|
int ret;
|
2006-10-11 08:20:50 +00:00
|
|
|
|
2015-06-21 05:25:29 +00:00
|
|
|
bh = ext4_getblk(handle, inode, block, map_flags);
|
2014-08-30 00:52:15 +00:00
|
|
|
if (IS_ERR(bh))
|
2006-10-11 08:20:50 +00:00
|
|
|
return bh;
|
2019-08-23 03:00:32 +00:00
|
|
|
if (!bh || ext4_buffer_uptodate(bh))
|
2006-10-11 08:20:50 +00:00
|
|
|
return bh;
|
2020-09-24 07:33:33 +00:00
|
|
|
|
|
|
|
ret = ext4_read_bh_lock(bh, REQ_META | REQ_PRIO, true);
|
|
|
|
if (ret) {
|
|
|
|
put_bh(bh);
|
|
|
|
return ERR_PTR(ret);
|
|
|
|
}
|
|
|
|
return bh;
|
2006-10-11 08:20:50 +00:00
|
|
|
}
|
|
|
|
|
2017-08-06 04:07:01 +00:00
|
|
|
/* Read a contiguous batch of blocks. */
|
|
|
|
int ext4_bread_batch(struct inode *inode, ext4_lblk_t block, int bh_count,
|
|
|
|
bool wait, struct buffer_head **bhs)
|
|
|
|
{
|
|
|
|
int i, err;
|
|
|
|
|
|
|
|
for (i = 0; i < bh_count; i++) {
|
|
|
|
bhs[i] = ext4_getblk(NULL, inode, block + i, 0 /* map_flags */);
|
|
|
|
if (IS_ERR(bhs[i])) {
|
|
|
|
err = PTR_ERR(bhs[i]);
|
|
|
|
bh_count = i;
|
|
|
|
goto out_brelse;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
for (i = 0; i < bh_count; i++)
|
|
|
|
/* Note that NULL bhs[i] is valid because of holes. */
|
2020-09-24 07:33:33 +00:00
|
|
|
if (bhs[i] && !ext4_buffer_uptodate(bhs[i]))
|
|
|
|
ext4_read_bh_lock(bhs[i], REQ_META | REQ_PRIO, false);
|
2017-08-06 04:07:01 +00:00
|
|
|
|
|
|
|
if (!wait)
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
for (i = 0; i < bh_count; i++)
|
|
|
|
if (bhs[i])
|
|
|
|
wait_on_buffer(bhs[i]);
|
|
|
|
|
|
|
|
for (i = 0; i < bh_count; i++) {
|
|
|
|
if (bhs[i] && !buffer_uptodate(bhs[i])) {
|
|
|
|
err = -EIO;
|
|
|
|
goto out_brelse;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
out_brelse:
|
|
|
|
for (i = 0; i < bh_count; i++) {
|
|
|
|
brelse(bhs[i]);
|
|
|
|
bhs[i] = NULL;
|
|
|
|
}
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
2021-08-16 09:57:04 +00:00
|
|
|
int ext4_walk_page_buffers(handle_t *handle, struct inode *inode,
|
2012-12-10 19:05:51 +00:00
|
|
|
struct buffer_head *head,
|
|
|
|
unsigned from,
|
|
|
|
unsigned to,
|
|
|
|
int *partial,
|
2021-08-16 09:57:04 +00:00
|
|
|
int (*fn)(handle_t *handle, struct inode *inode,
|
2012-12-10 19:05:51 +00:00
|
|
|
struct buffer_head *bh))
|
2006-10-11 08:20:50 +00:00
|
|
|
{
|
|
|
|
struct buffer_head *bh;
|
|
|
|
unsigned block_start, block_end;
|
|
|
|
unsigned blocksize = head->b_size;
|
|
|
|
int err, ret = 0;
|
|
|
|
struct buffer_head *next;
|
|
|
|
|
2008-09-09 02:25:24 +00:00
|
|
|
for (bh = head, block_start = 0;
|
|
|
|
ret == 0 && (bh != head || !block_start);
|
2009-06-14 21:45:34 +00:00
|
|
|
block_start = block_end, bh = next) {
|
2006-10-11 08:20:50 +00:00
|
|
|
next = bh->b_this_page;
|
|
|
|
block_end = block_start + blocksize;
|
|
|
|
if (block_end <= from || block_start >= to) {
|
|
|
|
if (partial && !buffer_uptodate(bh))
|
|
|
|
*partial = 1;
|
|
|
|
continue;
|
|
|
|
}
|
2021-08-16 09:57:04 +00:00
|
|
|
err = (*fn)(handle, inode, bh);
|
2006-10-11 08:20:50 +00:00
|
|
|
if (!ret)
|
|
|
|
ret = err;
|
|
|
|
}
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2023-03-29 15:49:33 +00:00
|
|
|
/*
|
|
|
|
* Helper for handling dirtying of journalled data. We also mark the folio as
|
|
|
|
* dirty so that writeback code knows about this page (and inode) contains
|
|
|
|
* dirty data. ext4_writepages() then commits appropriate transaction to
|
|
|
|
* make data stable.
|
|
|
|
*/
|
|
|
|
static int ext4_dirty_journalled_data(handle_t *handle, struct buffer_head *bh)
|
|
|
|
{
|
|
|
|
folio_mark_dirty(bh->b_folio);
|
|
|
|
return ext4_handle_dirty_metadata(handle, NULL, bh);
|
|
|
|
}
|
|
|
|
|
2021-08-16 09:57:04 +00:00
|
|
|
int do_journal_get_write_access(handle_t *handle, struct inode *inode,
|
2012-12-10 19:05:51 +00:00
|
|
|
struct buffer_head *bh)
|
2006-10-11 08:20:50 +00:00
|
|
|
{
|
|
|
|
if (!buffer_mapped(bh) || buffer_freed(bh))
|
|
|
|
return 0;
|
2014-05-13 02:06:43 +00:00
|
|
|
BUFFER_TRACE(bh, "get write access");
|
2024-08-30 05:37:39 +00:00
|
|
|
return ext4_journal_get_write_access(handle, inode->i_sb, bh,
|
2021-08-16 09:57:04 +00:00
|
|
|
EXT4_JTR_NONE);
|
2006-10-11 08:20:50 +00:00
|
|
|
}
|
|
|
|
|
2024-08-30 05:37:38 +00:00
|
|
|
int ext4_block_write_begin(handle_t *handle, struct folio *folio,
|
|
|
|
loff_t pos, unsigned len,
|
2024-08-30 05:37:37 +00:00
|
|
|
get_block_t *get_block)
|
2015-04-12 04:55:10 +00:00
|
|
|
{
|
mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros
PAGE_CACHE_{SIZE,SHIFT,MASK,ALIGN} macros were introduced *long* time
ago with promise that one day it will be possible to implement page
cache with bigger chunks than PAGE_SIZE.
This promise never materialized. And unlikely will.
We have many places where PAGE_CACHE_SIZE assumed to be equal to
PAGE_SIZE. And it's constant source of confusion on whether
PAGE_CACHE_* or PAGE_* constant should be used in a particular case,
especially on the border between fs and mm.
Global switching to PAGE_CACHE_SIZE != PAGE_SIZE would cause to much
breakage to be doable.
Let's stop pretending that pages in page cache are special. They are
not.
The changes are pretty straight-forward:
- <foo> << (PAGE_CACHE_SHIFT - PAGE_SHIFT) -> <foo>;
- <foo> >> (PAGE_CACHE_SHIFT - PAGE_SHIFT) -> <foo>;
- PAGE_CACHE_{SIZE,SHIFT,MASK,ALIGN} -> PAGE_{SIZE,SHIFT,MASK,ALIGN};
- page_cache_get() -> get_page();
- page_cache_release() -> put_page();
This patch contains automated changes generated with coccinelle using
script below. For some reason, coccinelle doesn't patch header files.
I've called spatch for them manually.
The only adjustment after coccinelle is revert of changes to
PAGE_CAHCE_ALIGN definition: we are going to drop it later.
There are few places in the code where coccinelle didn't reach. I'll
fix them manually in a separate patch. Comments and documentation also
will be addressed with the separate patch.
virtual patch
@@
expression E;
@@
- E << (PAGE_CACHE_SHIFT - PAGE_SHIFT)
+ E
@@
expression E;
@@
- E >> (PAGE_CACHE_SHIFT - PAGE_SHIFT)
+ E
@@
@@
- PAGE_CACHE_SHIFT
+ PAGE_SHIFT
@@
@@
- PAGE_CACHE_SIZE
+ PAGE_SIZE
@@
@@
- PAGE_CACHE_MASK
+ PAGE_MASK
@@
expression E;
@@
- PAGE_CACHE_ALIGN(E)
+ PAGE_ALIGN(E)
@@
expression E;
@@
- page_cache_get(E)
+ get_page(E)
@@
expression E;
@@
- page_cache_release(E)
+ put_page(E)
Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Acked-by: Michal Hocko <mhocko@suse.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2016-04-01 12:29:47 +00:00
|
|
|
unsigned from = pos & (PAGE_SIZE - 1);
|
2015-04-12 04:55:10 +00:00
|
|
|
unsigned to = from + len;
|
2023-03-24 18:01:24 +00:00
|
|
|
struct inode *inode = folio->mapping->host;
|
2015-04-12 04:55:10 +00:00
|
|
|
unsigned block_start, block_end;
|
|
|
|
sector_t block;
|
|
|
|
int err = 0;
|
|
|
|
unsigned blocksize = inode->i_sb->s_blocksize;
|
|
|
|
unsigned bbits;
|
2019-05-20 16:29:50 +00:00
|
|
|
struct buffer_head *bh, *head, *wait[2];
|
|
|
|
int nr_wait = 0;
|
|
|
|
int i;
|
2024-08-30 05:37:38 +00:00
|
|
|
bool should_journal_data = ext4_should_journal_data(inode);
|
2015-04-12 04:55:10 +00:00
|
|
|
|
2023-03-24 18:01:24 +00:00
|
|
|
BUG_ON(!folio_test_locked(folio));
|
mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros
PAGE_CACHE_{SIZE,SHIFT,MASK,ALIGN} macros were introduced *long* time
ago with promise that one day it will be possible to implement page
cache with bigger chunks than PAGE_SIZE.
This promise never materialized. And unlikely will.
We have many places where PAGE_CACHE_SIZE assumed to be equal to
PAGE_SIZE. And it's constant source of confusion on whether
PAGE_CACHE_* or PAGE_* constant should be used in a particular case,
especially on the border between fs and mm.
Global switching to PAGE_CACHE_SIZE != PAGE_SIZE would cause to much
breakage to be doable.
Let's stop pretending that pages in page cache are special. They are
not.
The changes are pretty straight-forward:
- <foo> << (PAGE_CACHE_SHIFT - PAGE_SHIFT) -> <foo>;
- <foo> >> (PAGE_CACHE_SHIFT - PAGE_SHIFT) -> <foo>;
- PAGE_CACHE_{SIZE,SHIFT,MASK,ALIGN} -> PAGE_{SIZE,SHIFT,MASK,ALIGN};
- page_cache_get() -> get_page();
- page_cache_release() -> put_page();
This patch contains automated changes generated with coccinelle using
script below. For some reason, coccinelle doesn't patch header files.
I've called spatch for them manually.
The only adjustment after coccinelle is revert of changes to
PAGE_CAHCE_ALIGN definition: we are going to drop it later.
There are few places in the code where coccinelle didn't reach. I'll
fix them manually in a separate patch. Comments and documentation also
will be addressed with the separate patch.
virtual patch
@@
expression E;
@@
- E << (PAGE_CACHE_SHIFT - PAGE_SHIFT)
+ E
@@
expression E;
@@
- E >> (PAGE_CACHE_SHIFT - PAGE_SHIFT)
+ E
@@
@@
- PAGE_CACHE_SHIFT
+ PAGE_SHIFT
@@
@@
- PAGE_CACHE_SIZE
+ PAGE_SIZE
@@
@@
- PAGE_CACHE_MASK
+ PAGE_MASK
@@
expression E;
@@
- PAGE_CACHE_ALIGN(E)
+ PAGE_ALIGN(E)
@@
expression E;
@@
- page_cache_get(E)
+ get_page(E)
@@
expression E;
@@
- page_cache_release(E)
+ put_page(E)
Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Acked-by: Michal Hocko <mhocko@suse.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2016-04-01 12:29:47 +00:00
|
|
|
BUG_ON(from > PAGE_SIZE);
|
|
|
|
BUG_ON(to > PAGE_SIZE);
|
2015-04-12 04:55:10 +00:00
|
|
|
BUG_ON(from > to);
|
|
|
|
|
2023-03-24 18:01:24 +00:00
|
|
|
head = folio_buffers(folio);
|
2023-10-16 20:10:51 +00:00
|
|
|
if (!head)
|
2023-10-16 20:11:14 +00:00
|
|
|
head = create_empty_buffers(folio, blocksize, 0);
|
2015-04-12 04:55:10 +00:00
|
|
|
bbits = ilog2(blocksize);
|
2023-03-24 18:01:24 +00:00
|
|
|
block = (sector_t)folio->index << (PAGE_SHIFT - bbits);
|
2015-04-12 04:55:10 +00:00
|
|
|
|
|
|
|
for (bh = head, block_start = 0; bh != head || !block_start;
|
|
|
|
block++, block_start = block_end, bh = bh->b_this_page) {
|
|
|
|
block_end = block_start + blocksize;
|
|
|
|
if (block_end <= from || block_start >= to) {
|
2023-03-24 18:01:24 +00:00
|
|
|
if (folio_test_uptodate(folio)) {
|
2021-04-01 07:03:30 +00:00
|
|
|
set_buffer_uptodate(bh);
|
2015-04-12 04:55:10 +00:00
|
|
|
}
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
if (buffer_new(bh))
|
|
|
|
clear_buffer_new(bh);
|
|
|
|
if (!buffer_mapped(bh)) {
|
|
|
|
WARN_ON(bh->b_size != blocksize);
|
|
|
|
err = get_block(inode, block, bh, 1);
|
|
|
|
if (err)
|
|
|
|
break;
|
|
|
|
if (buffer_new(bh)) {
|
2024-08-30 05:37:38 +00:00
|
|
|
/*
|
|
|
|
* We may be zeroing partial buffers or all new
|
|
|
|
* buffers in case of failure. Prepare JBD2 for
|
|
|
|
* that.
|
|
|
|
*/
|
|
|
|
if (should_journal_data)
|
|
|
|
do_journal_get_write_access(handle,
|
|
|
|
inode, bh);
|
2023-03-24 18:01:24 +00:00
|
|
|
if (folio_test_uptodate(folio)) {
|
2024-08-30 05:37:38 +00:00
|
|
|
/*
|
|
|
|
* Unlike __block_write_begin() we leave
|
|
|
|
* dirtying of new uptodate buffers to
|
|
|
|
* ->write_end() time or
|
|
|
|
* folio_zero_new_buffers().
|
|
|
|
*/
|
2015-04-12 04:55:10 +00:00
|
|
|
set_buffer_uptodate(bh);
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
if (block_end > to || block_start < from)
|
2023-03-24 18:01:24 +00:00
|
|
|
folio_zero_segments(folio, to,
|
|
|
|
block_end,
|
|
|
|
block_start, from);
|
2015-04-12 04:55:10 +00:00
|
|
|
continue;
|
|
|
|
}
|
|
|
|
}
|
2023-03-24 18:01:24 +00:00
|
|
|
if (folio_test_uptodate(folio)) {
|
2021-04-01 07:03:30 +00:00
|
|
|
set_buffer_uptodate(bh);
|
2015-04-12 04:55:10 +00:00
|
|
|
continue;
|
|
|
|
}
|
|
|
|
if (!buffer_uptodate(bh) && !buffer_delay(bh) &&
|
|
|
|
!buffer_unwritten(bh) &&
|
|
|
|
(block_start < from || block_end > to)) {
|
2020-09-24 07:33:33 +00:00
|
|
|
ext4_read_bh_lock(bh, 0, false);
|
2019-05-20 16:29:50 +00:00
|
|
|
wait[nr_wait++] = bh;
|
2015-04-12 04:55:10 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
/*
|
|
|
|
* If we issued read requests, let them complete.
|
|
|
|
*/
|
2019-05-20 16:29:50 +00:00
|
|
|
for (i = 0; i < nr_wait; i++) {
|
|
|
|
wait_on_buffer(wait[i]);
|
|
|
|
if (!buffer_uptodate(wait[i]))
|
2015-04-12 04:55:10 +00:00
|
|
|
err = -EIO;
|
|
|
|
}
|
2019-05-20 16:29:49 +00:00
|
|
|
if (unlikely(err)) {
|
2024-08-30 05:37:38 +00:00
|
|
|
if (should_journal_data)
|
|
|
|
ext4_journalled_zero_new_buffers(handle, inode, folio,
|
|
|
|
from, to);
|
|
|
|
else
|
|
|
|
folio_zero_new_buffers(folio, from, to);
|
2020-07-02 01:56:07 +00:00
|
|
|
} else if (fscrypt_inode_uses_fs_layer_crypto(inode)) {
|
2019-05-20 16:29:50 +00:00
|
|
|
for (i = 0; i < nr_wait; i++) {
|
|
|
|
int err2;
|
|
|
|
|
2023-03-24 18:01:24 +00:00
|
|
|
err2 = fscrypt_decrypt_pagecache_blocks(folio,
|
|
|
|
blocksize, bh_offset(wait[i]));
|
2019-05-20 16:29:50 +00:00
|
|
|
if (err2) {
|
|
|
|
clear_buffer_uptodate(wait[i]);
|
|
|
|
err = err2;
|
|
|
|
}
|
|
|
|
}
|
2019-05-20 16:29:49 +00:00
|
|
|
}
|
|
|
|
|
2015-04-12 04:55:10 +00:00
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
2023-02-28 05:13:13 +00:00
|
|
|
/*
|
|
|
|
* To preserve ordering, it is essential that the hole instantiation and
|
|
|
|
* the data write be encapsulated in a single transaction. We cannot
|
|
|
|
* close off a transaction and start a new one between the ext4_get_block()
|
|
|
|
* and the ext4_write_end(). So doing the jbd2_journal_start at the start of
|
|
|
|
* ext4_write_begin() is the right place.
|
|
|
|
*/
|
2007-10-16 08:25:05 +00:00
|
|
|
static int ext4_write_begin(struct file *file, struct address_space *mapping,
|
2022-02-22 19:31:43 +00:00
|
|
|
loff_t pos, unsigned len,
|
2024-07-15 18:24:01 +00:00
|
|
|
struct folio **foliop, void **fsdata)
|
2006-10-11 08:20:50 +00:00
|
|
|
{
|
2008-09-09 02:25:24 +00:00
|
|
|
struct inode *inode = mapping->host;
|
2009-06-05 05:00:26 +00:00
|
|
|
int ret, needed_blocks;
|
2006-10-11 08:20:50 +00:00
|
|
|
handle_t *handle;
|
|
|
|
int retries = 0;
|
2023-03-24 18:01:16 +00:00
|
|
|
struct folio *folio;
|
2009-06-14 21:45:34 +00:00
|
|
|
pgoff_t index;
|
2008-09-09 02:25:24 +00:00
|
|
|
unsigned from, to;
|
2007-10-16 08:25:05 +00:00
|
|
|
|
2023-06-16 16:50:49 +00:00
|
|
|
if (unlikely(ext4_forced_shutdown(inode->i_sb)))
|
2017-02-05 06:28:48 +00:00
|
|
|
return -EIO;
|
|
|
|
|
2022-02-22 19:31:43 +00:00
|
|
|
trace_ext4_write_begin(inode, pos, len);
|
2009-06-05 05:00:26 +00:00
|
|
|
/*
|
|
|
|
* Reserve one block more for addition to orphan list in case
|
|
|
|
* we allocate blocks but write fails for some reason
|
|
|
|
*/
|
|
|
|
needed_blocks = ext4_writepage_trans_blocks(inode) + 1;
|
mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros
PAGE_CACHE_{SIZE,SHIFT,MASK,ALIGN} macros were introduced *long* time
ago with promise that one day it will be possible to implement page
cache with bigger chunks than PAGE_SIZE.
This promise never materialized. And unlikely will.
We have many places where PAGE_CACHE_SIZE assumed to be equal to
PAGE_SIZE. And it's constant source of confusion on whether
PAGE_CACHE_* or PAGE_* constant should be used in a particular case,
especially on the border between fs and mm.
Global switching to PAGE_CACHE_SIZE != PAGE_SIZE would cause to much
breakage to be doable.
Let's stop pretending that pages in page cache are special. They are
not.
The changes are pretty straight-forward:
- <foo> << (PAGE_CACHE_SHIFT - PAGE_SHIFT) -> <foo>;
- <foo> >> (PAGE_CACHE_SHIFT - PAGE_SHIFT) -> <foo>;
- PAGE_CACHE_{SIZE,SHIFT,MASK,ALIGN} -> PAGE_{SIZE,SHIFT,MASK,ALIGN};
- page_cache_get() -> get_page();
- page_cache_release() -> put_page();
This patch contains automated changes generated with coccinelle using
script below. For some reason, coccinelle doesn't patch header files.
I've called spatch for them manually.
The only adjustment after coccinelle is revert of changes to
PAGE_CAHCE_ALIGN definition: we are going to drop it later.
There are few places in the code where coccinelle didn't reach. I'll
fix them manually in a separate patch. Comments and documentation also
will be addressed with the separate patch.
virtual patch
@@
expression E;
@@
- E << (PAGE_CACHE_SHIFT - PAGE_SHIFT)
+ E
@@
expression E;
@@
- E >> (PAGE_CACHE_SHIFT - PAGE_SHIFT)
+ E
@@
@@
- PAGE_CACHE_SHIFT
+ PAGE_SHIFT
@@
@@
- PAGE_CACHE_SIZE
+ PAGE_SIZE
@@
@@
- PAGE_CACHE_MASK
+ PAGE_MASK
@@
expression E;
@@
- PAGE_CACHE_ALIGN(E)
+ PAGE_ALIGN(E)
@@
expression E;
@@
- page_cache_get(E)
+ get_page(E)
@@
expression E;
@@
- page_cache_release(E)
+ put_page(E)
Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Acked-by: Michal Hocko <mhocko@suse.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2016-04-01 12:29:47 +00:00
|
|
|
index = pos >> PAGE_SHIFT;
|
|
|
|
from = pos & (PAGE_SIZE - 1);
|
2008-09-09 02:25:24 +00:00
|
|
|
to = from + len;
|
2006-10-11 08:20:50 +00:00
|
|
|
|
2012-12-10 19:05:51 +00:00
|
|
|
if (ext4_test_inode_state(inode, EXT4_STATE_MAY_INLINE_DATA)) {
|
|
|
|
ret = ext4_try_to_write_inline_data(mapping, inode, pos, len,
|
2024-07-15 18:24:01 +00:00
|
|
|
foliop);
|
2012-12-10 19:05:51 +00:00
|
|
|
if (ret < 0)
|
2013-02-09 14:24:14 +00:00
|
|
|
return ret;
|
|
|
|
if (ret == 1)
|
|
|
|
return 0;
|
2012-12-10 19:05:51 +00:00
|
|
|
}
|
|
|
|
|
2013-02-09 14:24:14 +00:00
|
|
|
/*
|
2023-03-24 18:01:16 +00:00
|
|
|
* __filemap_get_folio() can take a long time if the
|
|
|
|
* system is thrashing due to memory pressure, or if the folio
|
2013-02-09 14:24:14 +00:00
|
|
|
* is being written back. So grab it first before we start
|
|
|
|
* the transaction handle. This also allows us to allocate
|
2023-03-24 18:01:16 +00:00
|
|
|
* the folio (if needed) without using GFP_NOFS.
|
2013-02-09 14:24:14 +00:00
|
|
|
*/
|
|
|
|
retry_grab:
|
2023-03-24 18:01:16 +00:00
|
|
|
folio = __filemap_get_folio(mapping, index, FGP_WRITEBEGIN,
|
|
|
|
mapping_gfp_mask(mapping));
|
- Nick Piggin's "shoot lazy tlbs" series, to improve the peformance of
switching from a user process to a kernel thread.
- More folio conversions from Kefeng Wang, Zhang Peng and Pankaj Raghav.
- zsmalloc performance improvements from Sergey Senozhatsky.
- Yue Zhao has found and fixed some data race issues around the
alteration of memcg userspace tunables.
- VFS rationalizations from Christoph Hellwig:
- removal of most of the callers of write_one_page().
- make __filemap_get_folio()'s return value more useful
- Luis Chamberlain has changed tmpfs so it no longer requires swap
backing. Use `mount -o noswap'.
- Qi Zheng has made the slab shrinkers operate locklessly, providing
some scalability benefits.
- Keith Busch has improved dmapool's performance, making part of its
operations O(1) rather than O(n).
- Peter Xu adds the UFFD_FEATURE_WP_UNPOPULATED feature to userfaultd,
permitting userspace to wr-protect anon memory unpopulated ptes.
- Kirill Shutemov has changed MAX_ORDER's meaning to be inclusive rather
than exclusive, and has fixed a bunch of errors which were caused by its
unintuitive meaning.
- Axel Rasmussen give userfaultfd the UFFDIO_CONTINUE_MODE_WP feature,
which causes minor faults to install a write-protected pte.
- Vlastimil Babka has done some maintenance work on vma_merge():
cleanups to the kernel code and improvements to our userspace test
harness.
- Cleanups to do_fault_around() by Lorenzo Stoakes.
- Mike Rapoport has moved a lot of initialization code out of various
mm/ files and into mm/mm_init.c.
- Lorenzo Stoakes removd vmf_insert_mixed_prot(), which was added for
DRM, but DRM doesn't use it any more.
- Lorenzo has also coverted read_kcore() and vread() to use iterators
and has thereby removed the use of bounce buffers in some cases.
- Lorenzo has also contributed further cleanups of vma_merge().
- Chaitanya Prakash provides some fixes to the mmap selftesting code.
- Matthew Wilcox changes xfs and afs so they no longer take sleeping
locks in ->map_page(), a step towards RCUification of pagefaults.
- Suren Baghdasaryan has improved mmap_lock scalability by switching to
per-VMA locking.
- Frederic Weisbecker has reworked the percpu cache draining so that it
no longer causes latency glitches on cpu isolated workloads.
- Mike Rapoport cleans up and corrects the ARCH_FORCE_MAX_ORDER Kconfig
logic.
- Liu Shixin has changed zswap's initialization so we no longer waste a
chunk of memory if zswap is not being used.
- Yosry Ahmed has improved the performance of memcg statistics flushing.
- David Stevens has fixed several issues involving khugepaged,
userfaultfd and shmem.
- Christoph Hellwig has provided some cleanup work to zram's IO-related
code paths.
- David Hildenbrand has fixed up some issues in the selftest code's
testing of our pte state changing.
- Pankaj Raghav has made page_endio() unneeded and has removed it.
- Peter Xu contributed some rationalizations of the userfaultfd
selftests.
- Yosry Ahmed has fixed an issue around memcg's page recalim accounting.
- Chaitanya Prakash has fixed some arm-related issues in the
selftests/mm code.
- Longlong Xia has improved the way in which KSM handles hwpoisoned
pages.
- Peter Xu fixes a few issues with uffd-wp at fork() time.
- Stefan Roesch has changed KSM so that it may now be used on a
per-process and per-cgroup basis.
-----BEGIN PGP SIGNATURE-----
iHUEABYIAB0WIQTTMBEPP41GrTpTJgfdBJ7gKXxAjgUCZEr3zQAKCRDdBJ7gKXxA
jlLoAP0fpQBipwFxED0Us4SKQfupV6z4caXNJGPeay7Aj11/kQD/aMRC2uPfgr96
eMG3kwn2pqkB9ST2QpkaRbxA//eMbQY=
=J+Dj
-----END PGP SIGNATURE-----
Merge tag 'mm-stable-2023-04-27-15-30' of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
Pull MM updates from Andrew Morton:
- Nick Piggin's "shoot lazy tlbs" series, to improve the peformance of
switching from a user process to a kernel thread.
- More folio conversions from Kefeng Wang, Zhang Peng and Pankaj
Raghav.
- zsmalloc performance improvements from Sergey Senozhatsky.
- Yue Zhao has found and fixed some data race issues around the
alteration of memcg userspace tunables.
- VFS rationalizations from Christoph Hellwig:
- removal of most of the callers of write_one_page()
- make __filemap_get_folio()'s return value more useful
- Luis Chamberlain has changed tmpfs so it no longer requires swap
backing. Use `mount -o noswap'.
- Qi Zheng has made the slab shrinkers operate locklessly, providing
some scalability benefits.
- Keith Busch has improved dmapool's performance, making part of its
operations O(1) rather than O(n).
- Peter Xu adds the UFFD_FEATURE_WP_UNPOPULATED feature to userfaultd,
permitting userspace to wr-protect anon memory unpopulated ptes.
- Kirill Shutemov has changed MAX_ORDER's meaning to be inclusive
rather than exclusive, and has fixed a bunch of errors which were
caused by its unintuitive meaning.
- Axel Rasmussen give userfaultfd the UFFDIO_CONTINUE_MODE_WP feature,
which causes minor faults to install a write-protected pte.
- Vlastimil Babka has done some maintenance work on vma_merge():
cleanups to the kernel code and improvements to our userspace test
harness.
- Cleanups to do_fault_around() by Lorenzo Stoakes.
- Mike Rapoport has moved a lot of initialization code out of various
mm/ files and into mm/mm_init.c.
- Lorenzo Stoakes removd vmf_insert_mixed_prot(), which was added for
DRM, but DRM doesn't use it any more.
- Lorenzo has also coverted read_kcore() and vread() to use iterators
and has thereby removed the use of bounce buffers in some cases.
- Lorenzo has also contributed further cleanups of vma_merge().
- Chaitanya Prakash provides some fixes to the mmap selftesting code.
- Matthew Wilcox changes xfs and afs so they no longer take sleeping
locks in ->map_page(), a step towards RCUification of pagefaults.
- Suren Baghdasaryan has improved mmap_lock scalability by switching to
per-VMA locking.
- Frederic Weisbecker has reworked the percpu cache draining so that it
no longer causes latency glitches on cpu isolated workloads.
- Mike Rapoport cleans up and corrects the ARCH_FORCE_MAX_ORDER Kconfig
logic.
- Liu Shixin has changed zswap's initialization so we no longer waste a
chunk of memory if zswap is not being used.
- Yosry Ahmed has improved the performance of memcg statistics
flushing.
- David Stevens has fixed several issues involving khugepaged,
userfaultfd and shmem.
- Christoph Hellwig has provided some cleanup work to zram's IO-related
code paths.
- David Hildenbrand has fixed up some issues in the selftest code's
testing of our pte state changing.
- Pankaj Raghav has made page_endio() unneeded and has removed it.
- Peter Xu contributed some rationalizations of the userfaultfd
selftests.
- Yosry Ahmed has fixed an issue around memcg's page recalim
accounting.
- Chaitanya Prakash has fixed some arm-related issues in the
selftests/mm code.
- Longlong Xia has improved the way in which KSM handles hwpoisoned
pages.
- Peter Xu fixes a few issues with uffd-wp at fork() time.
- Stefan Roesch has changed KSM so that it may now be used on a
per-process and per-cgroup basis.
* tag 'mm-stable-2023-04-27-15-30' of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm: (369 commits)
mm,unmap: avoid flushing TLB in batch if PTE is inaccessible
shmem: restrict noswap option to initial user namespace
mm/khugepaged: fix conflicting mods to collapse_file()
sparse: remove unnecessary 0 values from rc
mm: move 'mmap_min_addr' logic from callers into vm_unmapped_area()
hugetlb: pte_alloc_huge() to replace huge pte_alloc_map()
maple_tree: fix allocation in mas_sparse_area()
mm: do not increment pgfault stats when page fault handler retries
zsmalloc: allow only one active pool compaction context
selftests/mm: add new selftests for KSM
mm: add new KSM process and sysfs knobs
mm: add new api to enable ksm per process
mm: shrinkers: fix debugfs file permissions
mm: don't check VMA write permissions if the PTE/PMD indicates write permissions
migrate_pages_batch: fix statistics for longterm pin retry
userfaultfd: use helper function range_in_vma()
lib/show_mem.c: use for_each_populated_zone() simplify code
mm: correct arg in reclaim_pages()/reclaim_clean_pages_from_list()
fs/buffer: convert create_page_buffers to folio_create_buffers
fs/buffer: add folio_create_empty_buffers helper
...
2023-04-28 02:42:02 +00:00
|
|
|
if (IS_ERR(folio))
|
|
|
|
return PTR_ERR(folio);
|
2022-09-03 01:24:29 +00:00
|
|
|
/*
|
|
|
|
* The same as page allocation, we prealloc buffer heads before
|
|
|
|
* starting the handle.
|
|
|
|
*/
|
2023-03-24 18:01:16 +00:00
|
|
|
if (!folio_buffers(folio))
|
2023-10-16 20:11:14 +00:00
|
|
|
create_empty_buffers(folio, inode->i_sb->s_blocksize, 0);
|
2022-09-03 01:24:29 +00:00
|
|
|
|
2023-03-24 18:01:16 +00:00
|
|
|
folio_unlock(folio);
|
2013-02-09 14:24:14 +00:00
|
|
|
|
|
|
|
retry_journal:
|
2013-02-09 02:59:22 +00:00
|
|
|
handle = ext4_journal_start(inode, EXT4_HT_WRITE_PAGE, needed_blocks);
|
2008-09-09 02:25:24 +00:00
|
|
|
if (IS_ERR(handle)) {
|
2023-03-24 18:01:16 +00:00
|
|
|
folio_put(folio);
|
2013-02-09 14:24:14 +00:00
|
|
|
return PTR_ERR(handle);
|
2007-04-02 06:49:44 +00:00
|
|
|
}
|
2006-10-11 08:20:50 +00:00
|
|
|
|
2023-03-24 18:01:16 +00:00
|
|
|
folio_lock(folio);
|
|
|
|
if (folio->mapping != mapping) {
|
|
|
|
/* The folio got truncated from under us */
|
|
|
|
folio_unlock(folio);
|
|
|
|
folio_put(folio);
|
2008-07-11 23:27:31 +00:00
|
|
|
ext4_journal_stop(handle);
|
2013-02-09 14:24:14 +00:00
|
|
|
goto retry_grab;
|
2008-07-11 23:27:31 +00:00
|
|
|
}
|
2023-03-24 18:01:16 +00:00
|
|
|
/* In case writeback began while the folio was unlocked */
|
|
|
|
folio_wait_stable(folio);
|
2008-07-11 23:27:31 +00:00
|
|
|
|
2015-04-12 04:55:10 +00:00
|
|
|
if (ext4_should_dioread_nolock(inode))
|
2024-08-30 05:37:38 +00:00
|
|
|
ret = ext4_block_write_begin(handle, folio, pos, len,
|
2016-03-09 04:08:10 +00:00
|
|
|
ext4_get_block_unwritten);
|
2015-04-12 04:55:10 +00:00
|
|
|
else
|
2024-08-30 05:37:38 +00:00
|
|
|
ret = ext4_block_write_begin(handle, folio, pos, len,
|
|
|
|
ext4_get_block);
|
2007-10-16 08:25:05 +00:00
|
|
|
if (!ret && ext4_should_journal_data(inode)) {
|
2021-08-16 09:57:04 +00:00
|
|
|
ret = ext4_walk_page_buffers(handle, inode,
|
2023-03-24 18:01:16 +00:00
|
|
|
folio_buffers(folio), from, to,
|
|
|
|
NULL, do_journal_get_write_access);
|
2006-10-11 08:20:50 +00:00
|
|
|
}
|
2007-10-16 08:25:05 +00:00
|
|
|
|
|
|
|
if (ret) {
|
2019-07-22 16:26:24 +00:00
|
|
|
bool extended = (pos + len > inode->i_size) &&
|
|
|
|
!ext4_verity_in_progress(inode);
|
|
|
|
|
2023-03-24 18:01:16 +00:00
|
|
|
folio_unlock(folio);
|
2008-09-13 17:10:25 +00:00
|
|
|
/*
|
2024-08-30 05:37:37 +00:00
|
|
|
* ext4_block_write_begin may have instantiated a few blocks
|
2008-09-13 17:10:25 +00:00
|
|
|
* outside i_size. Trim these off again. Don't need
|
2022-01-21 07:06:11 +00:00
|
|
|
* i_size_read because we hold i_rwsem.
|
2009-06-05 05:00:26 +00:00
|
|
|
*
|
|
|
|
* Add inode to orphan list in case we crash before
|
|
|
|
* truncate finishes
|
2008-09-13 17:10:25 +00:00
|
|
|
*/
|
2019-07-22 16:26:24 +00:00
|
|
|
if (extended && ext4_can_truncate(inode))
|
2009-06-05 05:00:26 +00:00
|
|
|
ext4_orphan_add(handle, inode);
|
|
|
|
|
|
|
|
ext4_journal_stop(handle);
|
2019-07-22 16:26:24 +00:00
|
|
|
if (extended) {
|
2009-12-09 02:24:33 +00:00
|
|
|
ext4_truncate_failed_write(inode);
|
2009-06-14 21:45:34 +00:00
|
|
|
/*
|
2009-07-13 20:22:22 +00:00
|
|
|
* If truncate failed early the inode might
|
2009-06-05 05:00:26 +00:00
|
|
|
* still be on the orphan list; we need to
|
|
|
|
* make sure the inode is removed from the
|
|
|
|
* orphan list in that case.
|
|
|
|
*/
|
|
|
|
if (inode->i_nlink)
|
|
|
|
ext4_orphan_del(NULL, inode);
|
|
|
|
}
|
2007-10-16 08:25:05 +00:00
|
|
|
|
2013-02-09 14:24:14 +00:00
|
|
|
if (ret == -ENOSPC &&
|
|
|
|
ext4_should_retry_alloc(inode->i_sb, &retries))
|
|
|
|
goto retry_journal;
|
2023-03-24 18:01:16 +00:00
|
|
|
folio_put(folio);
|
2013-02-09 14:24:14 +00:00
|
|
|
return ret;
|
|
|
|
}
|
2024-07-15 18:24:01 +00:00
|
|
|
*foliop = folio;
|
2006-10-11 08:20:50 +00:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2007-10-16 08:25:05 +00:00
|
|
|
/* For write_end() in data=journal mode */
|
2021-08-16 09:57:04 +00:00
|
|
|
static int write_end_fn(handle_t *handle, struct inode *inode,
|
|
|
|
struct buffer_head *bh)
|
2006-10-11 08:20:50 +00:00
|
|
|
{
|
2013-04-21 20:45:54 +00:00
|
|
|
int ret;
|
2006-10-11 08:20:50 +00:00
|
|
|
if (!buffer_mapped(bh) || buffer_freed(bh))
|
|
|
|
return 0;
|
|
|
|
set_buffer_uptodate(bh);
|
2023-03-29 15:49:33 +00:00
|
|
|
ret = ext4_dirty_journalled_data(handle, bh);
|
2013-04-21 20:45:54 +00:00
|
|
|
clear_buffer_meta(bh);
|
|
|
|
clear_buffer_prio(bh);
|
|
|
|
return ret;
|
2006-10-11 08:20:50 +00:00
|
|
|
}
|
|
|
|
|
2013-04-03 16:41:17 +00:00
|
|
|
/*
|
|
|
|
* We need to pick up the new inode size which generic_commit_write gave us
|
|
|
|
* `file' can be NULL - eg, when called from page_symlink().
|
|
|
|
*
|
2023-11-17 21:58:23 +00:00
|
|
|
* ext4 never places buffers on inode->i_mapping->i_private_list. metadata
|
2013-04-03 16:41:17 +00:00
|
|
|
* buffers are managed internally.
|
|
|
|
*/
|
|
|
|
static int ext4_write_end(struct file *file,
|
|
|
|
struct address_space *mapping,
|
|
|
|
loff_t pos, unsigned len, unsigned copied,
|
2024-07-10 19:45:32 +00:00
|
|
|
struct folio *folio, void *fsdata)
|
2009-06-05 04:56:49 +00:00
|
|
|
{
|
|
|
|
handle_t *handle = ext4_journal_current_handle();
|
2013-04-03 16:41:17 +00:00
|
|
|
struct inode *inode = mapping->host;
|
2015-02-13 04:00:17 +00:00
|
|
|
loff_t old_size = inode->i_size;
|
2013-04-03 16:41:17 +00:00
|
|
|
int ret = 0, ret2;
|
|
|
|
int i_size_changed = 0;
|
2019-07-22 16:26:24 +00:00
|
|
|
bool verity = ext4_verity_in_progress(inode);
|
2013-04-03 16:41:17 +00:00
|
|
|
|
|
|
|
trace_ext4_write_end(inode, pos, len, copied);
|
2021-07-16 12:20:23 +00:00
|
|
|
|
2022-12-06 14:41:34 +00:00
|
|
|
if (ext4_has_inline_data(inode) &&
|
|
|
|
ext4_test_inode_state(inode, EXT4_STATE_MAY_INLINE_DATA))
|
2023-05-15 10:40:44 +00:00
|
|
|
return ext4_write_inline_data_end(inode, pos, len, copied,
|
|
|
|
folio);
|
2021-07-16 12:20:23 +00:00
|
|
|
|
2024-07-10 18:51:11 +00:00
|
|
|
copied = block_write_end(file, mapping, pos, len, copied, folio, fsdata);
|
2009-06-05 04:56:49 +00:00
|
|
|
/*
|
2023-03-24 18:01:17 +00:00
|
|
|
* it's important to update i_size while still holding folio lock:
|
2009-06-05 04:56:49 +00:00
|
|
|
* page writeout could otherwise come in and zero beyond i_size.
|
2019-07-22 16:26:24 +00:00
|
|
|
*
|
|
|
|
* If FS_IOC_ENABLE_VERITY is running on this inode, then Merkle tree
|
|
|
|
* blocks are being written past EOF, so skip the i_size update.
|
2009-06-05 04:56:49 +00:00
|
|
|
*/
|
2019-07-22 16:26:24 +00:00
|
|
|
if (!verity)
|
|
|
|
i_size_changed = ext4_update_inode_size(inode, pos + copied);
|
2023-03-24 18:01:17 +00:00
|
|
|
folio_unlock(folio);
|
|
|
|
folio_put(folio);
|
2009-06-05 04:56:49 +00:00
|
|
|
|
2024-09-19 16:07:40 +00:00
|
|
|
if (old_size < pos && !verity) {
|
2015-02-13 04:00:17 +00:00
|
|
|
pagecache_isize_extended(inode, old_size, pos);
|
2024-09-19 16:07:40 +00:00
|
|
|
ext4_zero_partial_blocks(handle, inode, old_size, pos - old_size);
|
|
|
|
}
|
2009-06-05 04:56:49 +00:00
|
|
|
/*
|
2023-03-24 18:01:17 +00:00
|
|
|
* Don't mark the inode dirty under folio lock. First, it unnecessarily
|
|
|
|
* makes the holding time of folio lock longer. Second, it forces lock
|
|
|
|
* ordering of folio lock and transaction start for journaling
|
2009-06-05 04:56:49 +00:00
|
|
|
* filesystems.
|
|
|
|
*/
|
2021-07-16 12:20:23 +00:00
|
|
|
if (i_size_changed)
|
2020-04-27 01:34:37 +00:00
|
|
|
ret = ext4_mark_inode_dirty(handle, inode);
|
2009-06-05 04:56:49 +00:00
|
|
|
|
2019-07-22 16:26:24 +00:00
|
|
|
if (pos + len > inode->i_size && !verity && ext4_can_truncate(inode))
|
2009-06-05 04:56:49 +00:00
|
|
|
/* if we have allocated more blocks and copied
|
|
|
|
* less. We will have blocks allocated outside
|
|
|
|
* inode->i_size. So truncate them
|
|
|
|
*/
|
|
|
|
ext4_orphan_add(handle, inode);
|
2021-07-16 12:20:22 +00:00
|
|
|
|
2006-10-11 08:20:53 +00:00
|
|
|
ret2 = ext4_journal_stop(handle);
|
2006-10-11 08:20:50 +00:00
|
|
|
if (!ret)
|
|
|
|
ret = ret2;
|
2007-10-16 08:25:05 +00:00
|
|
|
|
2019-07-22 16:26:24 +00:00
|
|
|
if (pos + len > inode->i_size && !verity) {
|
2009-12-09 02:24:33 +00:00
|
|
|
ext4_truncate_failed_write(inode);
|
2009-06-14 21:45:34 +00:00
|
|
|
/*
|
2009-07-13 20:22:22 +00:00
|
|
|
* If truncate failed early the inode might still be
|
2009-06-05 04:56:49 +00:00
|
|
|
* on the orphan list; we need to make sure the inode
|
|
|
|
* is removed from the orphan list in that case.
|
|
|
|
*/
|
|
|
|
if (inode->i_nlink)
|
|
|
|
ext4_orphan_del(NULL, inode);
|
|
|
|
}
|
|
|
|
|
2007-10-16 08:25:05 +00:00
|
|
|
return ret ? ret : copied;
|
2006-10-11 08:20:50 +00:00
|
|
|
}
|
|
|
|
|
2015-10-15 14:29:05 +00:00
|
|
|
/*
|
2023-06-12 21:01:36 +00:00
|
|
|
* This is a private version of folio_zero_new_buffers() which doesn't
|
2015-10-15 14:29:05 +00:00
|
|
|
* set the buffer to be dirty, since in data=journalled mode we need
|
2023-03-29 15:49:33 +00:00
|
|
|
* to call ext4_dirty_journalled_data() instead.
|
2015-10-15 14:29:05 +00:00
|
|
|
*/
|
2017-01-27 19:35:38 +00:00
|
|
|
static void ext4_journalled_zero_new_buffers(handle_t *handle,
|
2021-08-16 09:57:04 +00:00
|
|
|
struct inode *inode,
|
2023-03-24 18:01:19 +00:00
|
|
|
struct folio *folio,
|
2017-01-27 19:35:38 +00:00
|
|
|
unsigned from, unsigned to)
|
2015-10-15 14:29:05 +00:00
|
|
|
{
|
|
|
|
unsigned int block_start = 0, block_end;
|
|
|
|
struct buffer_head *head, *bh;
|
|
|
|
|
2023-03-24 18:01:19 +00:00
|
|
|
bh = head = folio_buffers(folio);
|
2015-10-15 14:29:05 +00:00
|
|
|
do {
|
|
|
|
block_end = block_start + bh->b_size;
|
|
|
|
if (buffer_new(bh)) {
|
|
|
|
if (block_end > from && block_start < to) {
|
2023-03-24 18:01:19 +00:00
|
|
|
if (!folio_test_uptodate(folio)) {
|
2015-10-15 14:29:05 +00:00
|
|
|
unsigned start, size;
|
|
|
|
|
|
|
|
start = max(from, block_start);
|
|
|
|
size = min(to, block_end) - start;
|
|
|
|
|
2023-03-24 18:01:19 +00:00
|
|
|
folio_zero_range(folio, start, size);
|
2015-10-15 14:29:05 +00:00
|
|
|
}
|
|
|
|
clear_buffer_new(bh);
|
2024-08-30 05:37:36 +00:00
|
|
|
write_end_fn(handle, inode, bh);
|
2015-10-15 14:29:05 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
block_start = block_end;
|
|
|
|
bh = bh->b_this_page;
|
|
|
|
} while (bh != head);
|
|
|
|
}
|
|
|
|
|
2007-10-16 08:25:05 +00:00
|
|
|
static int ext4_journalled_write_end(struct file *file,
|
2009-06-14 21:45:34 +00:00
|
|
|
struct address_space *mapping,
|
|
|
|
loff_t pos, unsigned len, unsigned copied,
|
2024-07-10 19:45:32 +00:00
|
|
|
struct folio *folio, void *fsdata)
|
2006-10-11 08:20:50 +00:00
|
|
|
{
|
2006-10-11 08:20:53 +00:00
|
|
|
handle_t *handle = ext4_journal_current_handle();
|
2007-10-16 08:25:05 +00:00
|
|
|
struct inode *inode = mapping->host;
|
2015-02-13 04:00:17 +00:00
|
|
|
loff_t old_size = inode->i_size;
|
2006-10-11 08:20:50 +00:00
|
|
|
int ret = 0, ret2;
|
|
|
|
int partial = 0;
|
2007-10-16 08:25:05 +00:00
|
|
|
unsigned from, to;
|
2014-08-23 21:48:28 +00:00
|
|
|
int size_changed = 0;
|
2019-07-22 16:26:24 +00:00
|
|
|
bool verity = ext4_verity_in_progress(inode);
|
2006-10-11 08:20:50 +00:00
|
|
|
|
2009-06-17 15:48:11 +00:00
|
|
|
trace_ext4_journalled_write_end(inode, pos, len, copied);
|
mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros
PAGE_CACHE_{SIZE,SHIFT,MASK,ALIGN} macros were introduced *long* time
ago with promise that one day it will be possible to implement page
cache with bigger chunks than PAGE_SIZE.
This promise never materialized. And unlikely will.
We have many places where PAGE_CACHE_SIZE assumed to be equal to
PAGE_SIZE. And it's constant source of confusion on whether
PAGE_CACHE_* or PAGE_* constant should be used in a particular case,
especially on the border between fs and mm.
Global switching to PAGE_CACHE_SIZE != PAGE_SIZE would cause to much
breakage to be doable.
Let's stop pretending that pages in page cache are special. They are
not.
The changes are pretty straight-forward:
- <foo> << (PAGE_CACHE_SHIFT - PAGE_SHIFT) -> <foo>;
- <foo> >> (PAGE_CACHE_SHIFT - PAGE_SHIFT) -> <foo>;
- PAGE_CACHE_{SIZE,SHIFT,MASK,ALIGN} -> PAGE_{SIZE,SHIFT,MASK,ALIGN};
- page_cache_get() -> get_page();
- page_cache_release() -> put_page();
This patch contains automated changes generated with coccinelle using
script below. For some reason, coccinelle doesn't patch header files.
I've called spatch for them manually.
The only adjustment after coccinelle is revert of changes to
PAGE_CAHCE_ALIGN definition: we are going to drop it later.
There are few places in the code where coccinelle didn't reach. I'll
fix them manually in a separate patch. Comments and documentation also
will be addressed with the separate patch.
virtual patch
@@
expression E;
@@
- E << (PAGE_CACHE_SHIFT - PAGE_SHIFT)
+ E
@@
expression E;
@@
- E >> (PAGE_CACHE_SHIFT - PAGE_SHIFT)
+ E
@@
@@
- PAGE_CACHE_SHIFT
+ PAGE_SHIFT
@@
@@
- PAGE_CACHE_SIZE
+ PAGE_SIZE
@@
@@
- PAGE_CACHE_MASK
+ PAGE_MASK
@@
expression E;
@@
- PAGE_CACHE_ALIGN(E)
+ PAGE_ALIGN(E)
@@
expression E;
@@
- page_cache_get(E)
+ get_page(E)
@@
expression E;
@@
- page_cache_release(E)
+ put_page(E)
Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Acked-by: Michal Hocko <mhocko@suse.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2016-04-01 12:29:47 +00:00
|
|
|
from = pos & (PAGE_SIZE - 1);
|
2007-10-16 08:25:05 +00:00
|
|
|
to = from + len;
|
|
|
|
|
ext4: Fix ext4_should_writeback_data() for no-journal mode
ext4_should_writeback_data() had an incorrect sequence of
tests to determine if it should return 0 or 1: in
particular, even in no-journal mode, 0 was being returned
for a non-regular-file inode.
This meant that, in non-journal mode, we would use
ext4_journalled_aops for directories, symlinks, and other
non-regular files. However, calling journalled aop
callbacks when there is no valid handle, can cause problems.
This would cause a kernel crash with Jan Kara's commit
2d859db3e4 ("ext4: fix data corruption in inodes with
journalled data"), because we now dereference 'handle' in
ext4_journalled_write_end().
I also added BUG_ONs to check for a valid handle in the
obviously journal-only aops callbacks.
I tested this running xfstests with a scratch device in
these modes:
- no-journal
- data=ordered
- data=writeback
- data=journal
All work fine; the data=journal run has many failures and a
crash in xfstests 074, but this is no different from a
vanilla kernel.
Signed-off-by: Curt Wohlgemuth <curtw@google.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Cc: stable@kernel.org
2011-08-13 15:25:18 +00:00
|
|
|
BUG_ON(!ext4_handle_valid(handle));
|
|
|
|
|
2021-07-16 12:20:23 +00:00
|
|
|
if (ext4_has_inline_data(inode))
|
2023-05-15 10:40:44 +00:00
|
|
|
return ext4_write_inline_data_end(inode, pos, len, copied,
|
|
|
|
folio);
|
2021-07-16 12:20:23 +00:00
|
|
|
|
2023-03-24 18:01:18 +00:00
|
|
|
if (unlikely(copied < len) && !folio_test_uptodate(folio)) {
|
2017-01-27 19:35:38 +00:00
|
|
|
copied = 0;
|
2023-03-24 18:01:19 +00:00
|
|
|
ext4_journalled_zero_new_buffers(handle, inode, folio,
|
|
|
|
from, to);
|
2017-01-27 19:35:38 +00:00
|
|
|
} else {
|
|
|
|
if (unlikely(copied < len))
|
2023-03-24 18:01:19 +00:00
|
|
|
ext4_journalled_zero_new_buffers(handle, inode, folio,
|
2017-01-27 19:35:38 +00:00
|
|
|
from + copied, to);
|
2023-03-24 18:01:18 +00:00
|
|
|
ret = ext4_walk_page_buffers(handle, inode,
|
|
|
|
folio_buffers(folio),
|
2021-08-16 09:57:04 +00:00
|
|
|
from, from + copied, &partial,
|
2017-01-27 19:35:38 +00:00
|
|
|
write_end_fn);
|
2012-12-10 19:05:57 +00:00
|
|
|
if (!partial)
|
2023-03-24 18:01:18 +00:00
|
|
|
folio_mark_uptodate(folio);
|
2012-12-10 19:05:57 +00:00
|
|
|
}
|
2019-07-22 16:26:24 +00:00
|
|
|
if (!verity)
|
|
|
|
size_changed = ext4_update_inode_size(inode, pos + copied);
|
2011-07-26 13:07:11 +00:00
|
|
|
EXT4_I(inode)->i_datasync_tid = handle->h_transaction->t_tid;
|
2023-03-24 18:01:18 +00:00
|
|
|
folio_unlock(folio);
|
|
|
|
folio_put(folio);
|
2014-08-23 21:48:28 +00:00
|
|
|
|
2024-09-19 16:07:40 +00:00
|
|
|
if (old_size < pos && !verity) {
|
2015-02-13 04:00:17 +00:00
|
|
|
pagecache_isize_extended(inode, old_size, pos);
|
2024-09-19 16:07:40 +00:00
|
|
|
ext4_zero_partial_blocks(handle, inode, old_size, pos - old_size);
|
|
|
|
}
|
2015-02-13 04:00:17 +00:00
|
|
|
|
2021-07-16 12:20:23 +00:00
|
|
|
if (size_changed) {
|
2006-10-11 08:20:53 +00:00
|
|
|
ret2 = ext4_mark_inode_dirty(handle, inode);
|
2006-10-11 08:20:50 +00:00
|
|
|
if (!ret)
|
|
|
|
ret = ret2;
|
|
|
|
}
|
2007-10-16 08:25:05 +00:00
|
|
|
|
2019-07-22 16:26:24 +00:00
|
|
|
if (pos + len > inode->i_size && !verity && ext4_can_truncate(inode))
|
2009-06-05 04:56:49 +00:00
|
|
|
/* if we have allocated more blocks and copied
|
|
|
|
* less. We will have blocks allocated outside
|
|
|
|
* inode->i_size. So truncate them
|
|
|
|
*/
|
|
|
|
ext4_orphan_add(handle, inode);
|
|
|
|
|
2006-10-11 08:20:53 +00:00
|
|
|
ret2 = ext4_journal_stop(handle);
|
2006-10-11 08:20:50 +00:00
|
|
|
if (!ret)
|
|
|
|
ret = ret2;
|
2019-07-22 16:26:24 +00:00
|
|
|
if (pos + len > inode->i_size && !verity) {
|
2009-12-09 02:24:33 +00:00
|
|
|
ext4_truncate_failed_write(inode);
|
2009-06-14 21:45:34 +00:00
|
|
|
/*
|
2009-07-13 20:22:22 +00:00
|
|
|
* If truncate failed early the inode might still be
|
2009-06-05 04:56:49 +00:00
|
|
|
* on the orphan list; we need to make sure the inode
|
|
|
|
* is removed from the orphan list in that case.
|
|
|
|
*/
|
|
|
|
if (inode->i_nlink)
|
|
|
|
ext4_orphan_del(NULL, inode);
|
|
|
|
}
|
2007-10-16 08:25:05 +00:00
|
|
|
|
|
|
|
return ret ? ret : copied;
|
2006-10-11 08:20:50 +00:00
|
|
|
}
|
2008-07-14 21:52:37 +00:00
|
|
|
|
2010-01-01 07:41:30 +00:00
|
|
|
/*
|
2024-05-17 12:40:02 +00:00
|
|
|
* Reserve space for 'nr_resv' clusters
|
2010-01-01 07:41:30 +00:00
|
|
|
*/
|
2024-05-17 12:40:02 +00:00
|
|
|
static int ext4_da_reserve_space(struct inode *inode, int nr_resv)
|
2008-07-14 21:52:37 +00:00
|
|
|
{
|
2009-01-22 17:13:05 +00:00
|
|
|
struct ext4_sb_info *sbi = EXT4_SB(inode->i_sb);
|
2009-12-30 19:20:45 +00:00
|
|
|
struct ext4_inode_info *ei = EXT4_I(inode);
|
2010-03-03 14:05:00 +00:00
|
|
|
int ret;
|
2012-07-23 04:00:20 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* We will charge metadata quota at writeout time; this saves
|
|
|
|
* us from metadata over-estimation, though we may go over by
|
|
|
|
* a small amount in the end. Here we just reserve for data.
|
|
|
|
*/
|
2024-05-17 12:40:02 +00:00
|
|
|
ret = dquot_reserve_block(inode, EXT4_C2B(sbi, nr_resv));
|
2012-07-23 04:00:20 +00:00
|
|
|
if (ret)
|
|
|
|
return ret;
|
2008-07-14 21:52:37 +00:00
|
|
|
|
2009-12-30 19:20:45 +00:00
|
|
|
spin_lock(&ei->i_block_reservation_lock);
|
2024-05-17 12:40:02 +00:00
|
|
|
if (ext4_claim_free_clusters(sbi, nr_resv, 0)) {
|
2012-07-23 04:00:20 +00:00
|
|
|
spin_unlock(&ei->i_block_reservation_lock);
|
2024-05-17 12:40:02 +00:00
|
|
|
dquot_release_reservation_block(inode, EXT4_C2B(sbi, nr_resv));
|
2008-07-14 21:52:37 +00:00
|
|
|
return -ENOSPC;
|
|
|
|
}
|
2024-05-17 12:40:02 +00:00
|
|
|
ei->i_reserved_data_blocks += nr_resv;
|
|
|
|
trace_ext4_da_reserve_space(inode, nr_resv);
|
2009-12-30 19:20:45 +00:00
|
|
|
spin_unlock(&ei->i_block_reservation_lock);
|
2009-12-10 16:36:27 +00:00
|
|
|
|
2008-07-14 21:52:37 +00:00
|
|
|
return 0; /* success */
|
|
|
|
}
|
|
|
|
|
2018-10-01 18:33:24 +00:00
|
|
|
void ext4_da_release_space(struct inode *inode, int to_free)
|
2008-07-14 21:52:37 +00:00
|
|
|
{
|
|
|
|
struct ext4_sb_info *sbi = EXT4_SB(inode->i_sb);
|
2009-12-30 19:20:45 +00:00
|
|
|
struct ext4_inode_info *ei = EXT4_I(inode);
|
2008-07-14 21:52:37 +00:00
|
|
|
|
2008-08-20 02:16:59 +00:00
|
|
|
if (!to_free)
|
|
|
|
return; /* Nothing to release, exit */
|
|
|
|
|
2008-07-14 21:52:37 +00:00
|
|
|
spin_lock(&EXT4_I(inode)->i_block_reservation_lock);
|
2008-08-20 02:16:59 +00:00
|
|
|
|
2010-05-17 06:00:00 +00:00
|
|
|
trace_ext4_da_release_space(inode, to_free);
|
2009-12-30 19:20:45 +00:00
|
|
|
if (unlikely(to_free > ei->i_reserved_data_blocks)) {
|
2008-08-20 02:16:59 +00:00
|
|
|
/*
|
2009-12-30 19:20:45 +00:00
|
|
|
* if there aren't enough reserved blocks, then the
|
|
|
|
* counter is messed up somewhere. Since this
|
|
|
|
* function is called from invalidate page, it's
|
|
|
|
* harmless to return without any action.
|
2008-08-20 02:16:59 +00:00
|
|
|
*/
|
2013-02-14 20:11:41 +00:00
|
|
|
ext4_warning(inode->i_sb, "ext4_da_release_space: "
|
2009-12-30 19:20:45 +00:00
|
|
|
"ino %lu, to_free %d with only %d reserved "
|
2012-03-20 03:13:43 +00:00
|
|
|
"data blocks", inode->i_ino, to_free,
|
2009-12-30 19:20:45 +00:00
|
|
|
ei->i_reserved_data_blocks);
|
|
|
|
WARN_ON(1);
|
|
|
|
to_free = ei->i_reserved_data_blocks;
|
2008-08-20 02:16:59 +00:00
|
|
|
}
|
2009-12-30 19:20:45 +00:00
|
|
|
ei->i_reserved_data_blocks -= to_free;
|
2008-08-20 02:16:59 +00:00
|
|
|
|
2010-05-16 15:00:00 +00:00
|
|
|
/* update fs dirty data blocks counter */
|
2011-09-09 22:56:51 +00:00
|
|
|
percpu_counter_sub(&sbi->s_dirtyclusters_counter, to_free);
|
2008-07-14 21:52:37 +00:00
|
|
|
|
|
|
|
spin_unlock(&EXT4_I(inode)->i_block_reservation_lock);
|
2009-01-22 17:13:05 +00:00
|
|
|
|
2011-09-09 23:04:51 +00:00
|
|
|
dquot_release_reservation_block(inode, EXT4_C2B(sbi, to_free));
|
2008-07-14 21:52:37 +00:00
|
|
|
}
|
|
|
|
|
2008-07-11 23:27:31 +00:00
|
|
|
/*
|
|
|
|
* Delayed allocation stuff
|
|
|
|
*/
|
|
|
|
|
2013-06-04 17:17:40 +00:00
|
|
|
struct mpage_da_data {
|
2022-12-07 11:27:09 +00:00
|
|
|
/* These are input fields for ext4_do_writepages() */
|
2013-06-04 17:17:40 +00:00
|
|
|
struct inode *inode;
|
|
|
|
struct writeback_control *wbc;
|
2022-12-07 11:27:09 +00:00
|
|
|
unsigned int can_map:1; /* Can writepages call map blocks? */
|
2013-06-04 17:21:11 +00:00
|
|
|
|
2022-12-07 11:27:09 +00:00
|
|
|
/* These are internal state of ext4_do_writepages() */
|
2013-06-04 17:17:40 +00:00
|
|
|
pgoff_t first_page; /* The first page to write */
|
|
|
|
pgoff_t next_page; /* Current page to examine */
|
|
|
|
pgoff_t last_page; /* Last page to examine */
|
2009-01-06 02:50:43 +00:00
|
|
|
/*
|
2013-06-04 17:17:40 +00:00
|
|
|
* Extent to map - this can be after first_page because that can be
|
|
|
|
* fully mapped. We somewhat abuse m_flags to store whether the extent
|
|
|
|
* is delalloc or unwritten.
|
2009-01-06 02:50:43 +00:00
|
|
|
*/
|
2013-06-04 17:17:40 +00:00
|
|
|
struct ext4_map_blocks map;
|
|
|
|
struct ext4_io_submit io_submit; /* IO submission data */
|
ext4: avoid unnecessary transaction stalls during writeback
Currently ext4_writepages() submits all pages with transaction started.
When no page needs block allocation or extent conversion we can submit
all dirty pages in the inode while holding a single transaction handle
and when device is congested this can take significant amount of time.
Thus ext4_writepages() can block transaction commits for extended
periods of time.
Take for example a simple benchmark simulating PostgreSQL database
(pgioperf in mmtest). The benchmark runs 16 processes doing random reads
from a huge file, one process doing random writes to the huge file, and
one process doing sequential writes to a small files and frequently
running fsync. With unpatched kernel transaction commits take on average
~18s with standard deviation of ~41s, top 5 commit times are:
274.466639s, 126.467347s, 86.992429s, 34.351563s, 31.517653s.
After this patch transaction commits take on average 0.1s with standard
deviation of 0.15s, top 5 commit times are:
0.563792s, 0.519980s, 0.509841s, 0.471700s, 0.469899s
[ Modified so we use an explicit do_map flag instead of relying on
io_end not being allocated, the since io_end->inode is needed for I/O
error handling. -- tytso ]
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
2017-04-30 22:29:10 +00:00
|
|
|
unsigned int do_map:1;
|
2020-05-25 08:12:15 +00:00
|
|
|
unsigned int scanned_until_end:1;
|
2023-03-29 15:49:36 +00:00
|
|
|
unsigned int journalled_more_data:1;
|
2013-06-04 17:17:40 +00:00
|
|
|
};
|
2008-07-11 23:27:31 +00:00
|
|
|
|
2013-06-04 17:17:40 +00:00
|
|
|
static void mpage_release_unused_pages(struct mpage_da_data *mpd,
|
|
|
|
bool invalidate)
|
2008-08-20 01:08:18 +00:00
|
|
|
{
|
2022-06-03 19:36:49 +00:00
|
|
|
unsigned nr, i;
|
2008-08-20 01:08:18 +00:00
|
|
|
pgoff_t index, end;
|
2022-06-03 19:36:49 +00:00
|
|
|
struct folio_batch fbatch;
|
2008-08-20 01:08:18 +00:00
|
|
|
struct inode *inode = mpd->inode;
|
|
|
|
struct address_space *mapping = inode->i_mapping;
|
2013-06-04 17:17:40 +00:00
|
|
|
|
|
|
|
/* This is necessary when next_page == 0. */
|
|
|
|
if (mpd->first_page >= mpd->next_page)
|
|
|
|
return;
|
2008-08-20 01:08:18 +00:00
|
|
|
|
2020-05-25 08:12:15 +00:00
|
|
|
mpd->scanned_until_end = 0;
|
2011-02-26 17:27:52 +00:00
|
|
|
index = mpd->first_page;
|
|
|
|
end = mpd->next_page - 1;
|
2013-06-04 17:17:40 +00:00
|
|
|
if (invalidate) {
|
|
|
|
ext4_lblk_t start, last;
|
mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros
PAGE_CACHE_{SIZE,SHIFT,MASK,ALIGN} macros were introduced *long* time
ago with promise that one day it will be possible to implement page
cache with bigger chunks than PAGE_SIZE.
This promise never materialized. And unlikely will.
We have many places where PAGE_CACHE_SIZE assumed to be equal to
PAGE_SIZE. And it's constant source of confusion on whether
PAGE_CACHE_* or PAGE_* constant should be used in a particular case,
especially on the border between fs and mm.
Global switching to PAGE_CACHE_SIZE != PAGE_SIZE would cause to much
breakage to be doable.
Let's stop pretending that pages in page cache are special. They are
not.
The changes are pretty straight-forward:
- <foo> << (PAGE_CACHE_SHIFT - PAGE_SHIFT) -> <foo>;
- <foo> >> (PAGE_CACHE_SHIFT - PAGE_SHIFT) -> <foo>;
- PAGE_CACHE_{SIZE,SHIFT,MASK,ALIGN} -> PAGE_{SIZE,SHIFT,MASK,ALIGN};
- page_cache_get() -> get_page();
- page_cache_release() -> put_page();
This patch contains automated changes generated with coccinelle using
script below. For some reason, coccinelle doesn't patch header files.
I've called spatch for them manually.
The only adjustment after coccinelle is revert of changes to
PAGE_CAHCE_ALIGN definition: we are going to drop it later.
There are few places in the code where coccinelle didn't reach. I'll
fix them manually in a separate patch. Comments and documentation also
will be addressed with the separate patch.
virtual patch
@@
expression E;
@@
- E << (PAGE_CACHE_SHIFT - PAGE_SHIFT)
+ E
@@
expression E;
@@
- E >> (PAGE_CACHE_SHIFT - PAGE_SHIFT)
+ E
@@
@@
- PAGE_CACHE_SHIFT
+ PAGE_SHIFT
@@
@@
- PAGE_CACHE_SIZE
+ PAGE_SIZE
@@
@@
- PAGE_CACHE_MASK
+ PAGE_MASK
@@
expression E;
@@
- PAGE_CACHE_ALIGN(E)
+ PAGE_ALIGN(E)
@@
expression E;
@@
- page_cache_get(E)
+ get_page(E)
@@
expression E;
@@
- page_cache_release(E)
+ put_page(E)
Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Acked-by: Michal Hocko <mhocko@suse.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2016-04-01 12:29:47 +00:00
|
|
|
start = index << (PAGE_SHIFT - inode->i_blkbits);
|
|
|
|
last = end << (PAGE_SHIFT - inode->i_blkbits);
|
2022-06-15 16:05:30 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* avoid racing with extent status tree scans made by
|
|
|
|
* ext4_insert_delayed_block()
|
|
|
|
*/
|
|
|
|
down_write(&EXT4_I(inode)->i_data_sem);
|
2013-06-04 17:17:40 +00:00
|
|
|
ext4_es_remove_extent(inode, start, last - start + 1);
|
2022-06-15 16:05:30 +00:00
|
|
|
up_write(&EXT4_I(inode)->i_data_sem);
|
2013-06-04 17:17:40 +00:00
|
|
|
}
|
2012-11-09 02:57:32 +00:00
|
|
|
|
2022-06-03 19:36:49 +00:00
|
|
|
folio_batch_init(&fbatch);
|
2008-08-20 01:08:18 +00:00
|
|
|
while (index <= end) {
|
2022-06-03 19:36:49 +00:00
|
|
|
nr = filemap_get_folios(mapping, &index, end, &fbatch);
|
|
|
|
if (nr == 0)
|
2008-08-20 01:08:18 +00:00
|
|
|
break;
|
2022-06-03 19:36:49 +00:00
|
|
|
for (i = 0; i < nr; i++) {
|
|
|
|
struct folio *folio = fbatch.folios[i];
|
2017-09-06 23:21:30 +00:00
|
|
|
|
2022-06-03 19:36:49 +00:00
|
|
|
if (folio->index < mpd->first_page)
|
|
|
|
continue;
|
2023-06-27 17:43:49 +00:00
|
|
|
if (folio_next_index(folio) - 1 > end)
|
2022-06-03 19:36:49 +00:00
|
|
|
continue;
|
2022-02-09 20:21:34 +00:00
|
|
|
BUG_ON(!folio_test_locked(folio));
|
|
|
|
BUG_ON(folio_test_writeback(folio));
|
2013-06-04 17:17:40 +00:00
|
|
|
if (invalidate) {
|
2022-02-09 20:21:34 +00:00
|
|
|
if (folio_mapped(folio))
|
|
|
|
folio_clear_dirty_for_io(folio);
|
|
|
|
block_invalidate_folio(folio, 0,
|
|
|
|
folio_size(folio));
|
|
|
|
folio_clear_uptodate(folio);
|
2013-06-04 17:17:40 +00:00
|
|
|
}
|
2022-02-09 20:21:34 +00:00
|
|
|
folio_unlock(folio);
|
2008-08-20 01:08:18 +00:00
|
|
|
}
|
2022-06-03 19:36:49 +00:00
|
|
|
folio_batch_release(&fbatch);
|
2008-08-20 01:08:18 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2008-09-09 03:05:34 +00:00
|
|
|
static void ext4_print_free_blocks(struct inode *inode)
|
|
|
|
{
|
|
|
|
struct ext4_sb_info *sbi = EXT4_SB(inode->i_sb);
|
2012-03-20 03:41:49 +00:00
|
|
|
struct super_block *sb = inode->i_sb;
|
2013-04-04 03:33:30 +00:00
|
|
|
struct ext4_inode_info *ei = EXT4_I(inode);
|
2012-03-20 03:41:49 +00:00
|
|
|
|
|
|
|
ext4_msg(sb, KERN_CRIT, "Total free blocks count %lld",
|
2011-09-09 23:10:51 +00:00
|
|
|
EXT4_C2B(EXT4_SB(inode->i_sb),
|
2013-04-04 03:33:30 +00:00
|
|
|
ext4_count_free_clusters(sb)));
|
2012-03-20 03:41:49 +00:00
|
|
|
ext4_msg(sb, KERN_CRIT, "Free/Dirty block details");
|
|
|
|
ext4_msg(sb, KERN_CRIT, "free_blocks=%lld",
|
2013-04-04 03:33:30 +00:00
|
|
|
(long long) EXT4_C2B(EXT4_SB(sb),
|
2011-09-09 22:56:51 +00:00
|
|
|
percpu_counter_sum(&sbi->s_freeclusters_counter)));
|
2012-03-20 03:41:49 +00:00
|
|
|
ext4_msg(sb, KERN_CRIT, "dirty_blocks=%lld",
|
2013-04-04 03:33:30 +00:00
|
|
|
(long long) EXT4_C2B(EXT4_SB(sb),
|
2011-09-09 23:04:51 +00:00
|
|
|
percpu_counter_sum(&sbi->s_dirtyclusters_counter)));
|
2012-03-20 03:41:49 +00:00
|
|
|
ext4_msg(sb, KERN_CRIT, "Block reservation details");
|
|
|
|
ext4_msg(sb, KERN_CRIT, "i_reserved_data_blocks=%u",
|
2013-04-04 03:33:30 +00:00
|
|
|
ei->i_reserved_data_blocks);
|
2008-09-09 03:05:34 +00:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2024-05-17 12:40:03 +00:00
|
|
|
/*
|
|
|
|
* Check whether the cluster containing lblk has been allocated or has
|
|
|
|
* delalloc reservation.
|
|
|
|
*
|
|
|
|
* Returns 0 if the cluster doesn't have either, 1 if it has delalloc
|
|
|
|
* reservation, 2 if it's already been allocated, negative error code on
|
|
|
|
* failure.
|
|
|
|
*/
|
|
|
|
static int ext4_clu_alloc_state(struct inode *inode, ext4_lblk_t lblk)
|
|
|
|
{
|
|
|
|
struct ext4_sb_info *sbi = EXT4_SB(inode->i_sb);
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
/* Has delalloc reservation? */
|
2024-08-13 12:34:51 +00:00
|
|
|
if (ext4_es_scan_clu(inode, &ext4_es_is_delayed, lblk))
|
2024-05-17 12:40:03 +00:00
|
|
|
return 1;
|
|
|
|
|
|
|
|
/* Already been allocated? */
|
|
|
|
if (ext4_es_scan_clu(inode, &ext4_es_is_mapped, lblk))
|
|
|
|
return 2;
|
|
|
|
ret = ext4_clu_mapped(inode, EXT4_B2C(sbi, lblk));
|
|
|
|
if (ret < 0)
|
|
|
|
return ret;
|
|
|
|
if (ret > 0)
|
|
|
|
return 2;
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2018-10-01 18:19:37 +00:00
|
|
|
/*
|
2024-05-17 12:40:04 +00:00
|
|
|
* ext4_insert_delayed_blocks - adds a multiple delayed blocks to the extents
|
|
|
|
* status tree, incrementing the reserved
|
|
|
|
* cluster/block count or making pending
|
|
|
|
* reservations where needed
|
2018-10-01 18:19:37 +00:00
|
|
|
*
|
|
|
|
* @inode - file containing the newly added block
|
2024-05-17 12:40:04 +00:00
|
|
|
* @lblk - start logical block to be added
|
|
|
|
* @len - length of blocks to be added
|
2018-10-01 18:19:37 +00:00
|
|
|
*
|
|
|
|
* Returns 0 on success, negative error code on failure.
|
|
|
|
*/
|
2024-05-17 12:40:04 +00:00
|
|
|
static int ext4_insert_delayed_blocks(struct inode *inode, ext4_lblk_t lblk,
|
|
|
|
ext4_lblk_t len)
|
2018-10-01 18:19:37 +00:00
|
|
|
{
|
|
|
|
struct ext4_sb_info *sbi = EXT4_SB(inode->i_sb);
|
|
|
|
int ret;
|
2024-05-17 12:40:04 +00:00
|
|
|
bool lclu_allocated = false;
|
|
|
|
bool end_allocated = false;
|
|
|
|
ext4_lblk_t resv_clu;
|
|
|
|
ext4_lblk_t end = lblk + len - 1;
|
2018-10-01 18:19:37 +00:00
|
|
|
|
|
|
|
/*
|
2024-05-17 12:40:04 +00:00
|
|
|
* If the cluster containing lblk or end is shared with a delayed,
|
2018-10-01 18:19:37 +00:00
|
|
|
* written, or unwritten extent in a bigalloc file system, it's
|
|
|
|
* already been accounted for and does not need to be reserved.
|
|
|
|
* A pending reservation must be made for the cluster if it's
|
|
|
|
* shared with a written or unwritten extent and doesn't already
|
|
|
|
* have one. Written and unwritten extents can be purged from the
|
|
|
|
* extents status tree if the system is under memory pressure, so
|
|
|
|
* it's necessary to examine the extent tree if a search of the
|
|
|
|
* extents status tree doesn't get a match.
|
|
|
|
*/
|
|
|
|
if (sbi->s_cluster_ratio == 1) {
|
2024-05-17 12:40:04 +00:00
|
|
|
ret = ext4_da_reserve_space(inode, len);
|
2018-10-01 18:19:37 +00:00
|
|
|
if (ret != 0) /* ENOSPC */
|
2023-04-24 03:38:44 +00:00
|
|
|
return ret;
|
2018-10-01 18:19:37 +00:00
|
|
|
} else { /* bigalloc */
|
2024-05-17 12:40:04 +00:00
|
|
|
resv_clu = EXT4_B2C(sbi, end) - EXT4_B2C(sbi, lblk) + 1;
|
|
|
|
|
2024-05-17 12:40:03 +00:00
|
|
|
ret = ext4_clu_alloc_state(inode, lblk);
|
|
|
|
if (ret < 0)
|
|
|
|
return ret;
|
2024-05-17 12:40:04 +00:00
|
|
|
if (ret > 0) {
|
|
|
|
resv_clu--;
|
|
|
|
lclu_allocated = (ret == 2);
|
|
|
|
}
|
|
|
|
|
|
|
|
if (EXT4_B2C(sbi, lblk) != EXT4_B2C(sbi, end)) {
|
|
|
|
ret = ext4_clu_alloc_state(inode, end);
|
|
|
|
if (ret < 0)
|
|
|
|
return ret;
|
|
|
|
if (ret > 0) {
|
|
|
|
resv_clu--;
|
|
|
|
end_allocated = (ret == 2);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (resv_clu) {
|
|
|
|
ret = ext4_da_reserve_space(inode, resv_clu);
|
2024-05-17 12:40:03 +00:00
|
|
|
if (ret != 0) /* ENOSPC */
|
|
|
|
return ret;
|
2018-10-01 18:19:37 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2024-05-17 12:40:04 +00:00
|
|
|
ext4_es_insert_delayed_extent(inode, lblk, len, lclu_allocated,
|
|
|
|
end_allocated);
|
2023-04-24 03:38:44 +00:00
|
|
|
return 0;
|
2018-10-01 18:19:37 +00:00
|
|
|
}
|
|
|
|
|
2011-09-09 23:20:51 +00:00
|
|
|
/*
|
2024-05-17 12:40:05 +00:00
|
|
|
* Looks up the requested blocks and sets the delalloc extent map.
|
|
|
|
* First try to look up for the extent entry that contains the requested
|
|
|
|
* blocks in the extent status tree without i_data_sem, then try to look
|
|
|
|
* up for the ondisk extent mapping with i_data_sem in read mode,
|
|
|
|
* finally hold i_data_sem in write mode, looks up again and add a
|
|
|
|
* delalloc extent entry if it still couldn't find any extent. Pass out
|
|
|
|
* the mapped extent through @map and return 0 on success.
|
2011-09-09 23:20:51 +00:00
|
|
|
*/
|
2024-05-17 12:40:05 +00:00
|
|
|
static int ext4_da_map_blocks(struct inode *inode, struct ext4_map_blocks *map)
|
2011-09-09 23:20:51 +00:00
|
|
|
{
|
2013-02-18 05:29:59 +00:00
|
|
|
struct extent_status es;
|
2011-09-09 23:20:51 +00:00
|
|
|
int retval;
|
2013-03-11 01:01:03 +00:00
|
|
|
#ifdef ES_AGGRESSIVE_TEST
|
|
|
|
struct ext4_map_blocks orig_map;
|
|
|
|
|
|
|
|
memcpy(&orig_map, map, sizeof(*map));
|
|
|
|
#endif
|
2011-09-09 23:20:51 +00:00
|
|
|
|
|
|
|
map->m_flags = 0;
|
2020-05-10 06:24:55 +00:00
|
|
|
ext_debug(inode, "max_blocks %u, logical block %lu\n", map->m_len,
|
2011-09-09 23:20:51 +00:00
|
|
|
(unsigned long) map->m_lblk);
|
2013-02-18 05:29:59 +00:00
|
|
|
|
|
|
|
/* Lookup extent status tree firstly */
|
2024-05-17 12:40:00 +00:00
|
|
|
if (ext4_es_lookup_extent(inode, map->m_lblk, NULL, &es)) {
|
2024-05-17 12:40:05 +00:00
|
|
|
map->m_len = min_t(unsigned int, map->m_len,
|
|
|
|
es.es_len - (map->m_lblk - es.es_lblk));
|
ext4: trim delalloc extent
In ext4_da_map_blocks(), we could find four kind of extents in the
extent status tree: hole, unwritten, written and delayed extent. Now we
only trim the map len if we found an unwritten extent or a written
extent. This is okay now since map->m_len is always set to one and we
always insert one delayed block at a time. But this will become isn't
okay for other two cases if ext4_insert_delayed_block() and
ext4_da_map_blocks() support inserting multiple map->len blocks later.
1. If we found a hole in the extent status tree which es->es_len is
shorter than the length we want to write, we should trim the
map->m_len to prevent adding extra delay more blocks than we
expected. For example, assume we write data [A, C) to a file that
contains a hole extent [A, B) and a written extent [B, D) in the
cache.
A B C D
before da write: ...hhhhhh|wwwwww....
Then we will get extent [A, B), we should trim map->m_len to B-A
before inserting new delalloc blocks, if not, the range [B, C) will
be duplicated.
2. If we found a delayed extent in the extent status tree which
es->es_len is shorter than the length we want to write, we should
trim the map->m_len to es->es_len and return directly since the front
part of this map has been delayed, we can't insert the delalloc
extent that contains the latter part in this round, we should return
the delayed length and the caller should increase the position and
call ext4_da_map_blocks() again. For example, assume we write data
[A, C) to a file that contains a delayed extent [A, B) in the cache.
A B C
before da write: ...dddddd|hhh....
Then we will get delayed extent [A, B), we should also trim map->m_len
to B-A and return, if not, we will incorrectly assume that the write
is complete and won't insert [B, C).
So we need to always trim the map->m_len if the found es->es_len in the
extent status tree is shorter than the map->m_len, prearing for
inserting a extent with multiple delalloc blocks. This patch only does a
pre-fix, the handle is crude and ext4_da_map_blocks() deserve a cleanup,
we will do that later.
Signed-off-by: Zhang Yi <yi.zhang@huawei.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://patch.msgid.link/20240517124005.347221-5-yi.zhang@huaweicloud.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
2024-05-17 12:39:59 +00:00
|
|
|
|
2024-01-27 01:58:01 +00:00
|
|
|
if (ext4_es_is_hole(&es))
|
2013-02-18 05:29:59 +00:00
|
|
|
goto add_delayed;
|
|
|
|
|
2024-05-17 12:39:57 +00:00
|
|
|
found:
|
2013-02-18 05:29:59 +00:00
|
|
|
/*
|
2021-10-12 17:19:01 +00:00
|
|
|
* Delayed extent could be allocated by fallocate.
|
|
|
|
* So we need to check it.
|
2013-02-18 05:29:59 +00:00
|
|
|
*/
|
2024-08-13 12:34:51 +00:00
|
|
|
if (ext4_es_is_delayed(&es)) {
|
2024-05-17 12:40:05 +00:00
|
|
|
map->m_flags |= EXT4_MAP_DELAYED;
|
2013-02-18 05:29:59 +00:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2024-05-17 12:40:00 +00:00
|
|
|
map->m_pblk = ext4_es_pblock(&es) + map->m_lblk - es.es_lblk;
|
2013-02-18 05:29:59 +00:00
|
|
|
if (ext4_es_is_written(&es))
|
|
|
|
map->m_flags |= EXT4_MAP_MAPPED;
|
|
|
|
else if (ext4_es_is_unwritten(&es))
|
|
|
|
map->m_flags |= EXT4_MAP_UNWRITTEN;
|
|
|
|
else
|
2019-04-07 16:24:43 +00:00
|
|
|
BUG();
|
2013-02-18 05:29:59 +00:00
|
|
|
|
2013-03-11 01:01:03 +00:00
|
|
|
#ifdef ES_AGGRESSIVE_TEST
|
|
|
|
ext4_map_blocks_es_recheck(NULL, inode, map, &orig_map, 0);
|
|
|
|
#endif
|
2024-05-17 12:40:05 +00:00
|
|
|
return 0;
|
2013-02-18 05:29:59 +00:00
|
|
|
}
|
|
|
|
|
2011-09-09 23:20:51 +00:00
|
|
|
/*
|
|
|
|
* Try to see if we can get the block without requesting a new
|
|
|
|
* file system block.
|
|
|
|
*/
|
2014-05-12 16:55:07 +00:00
|
|
|
down_read(&EXT4_I(inode)->i_data_sem);
|
2014-11-25 16:41:49 +00:00
|
|
|
if (ext4_has_inline_data(inode))
|
2012-12-10 19:05:57 +00:00
|
|
|
retval = 0;
|
2011-09-09 23:20:51 +00:00
|
|
|
else
|
2024-05-17 12:39:56 +00:00
|
|
|
retval = ext4_map_query_blocks(NULL, inode, map);
|
2024-01-27 01:58:01 +00:00
|
|
|
up_read(&EXT4_I(inode)->i_data_sem);
|
2024-05-17 12:39:56 +00:00
|
|
|
if (retval)
|
2024-05-17 12:40:05 +00:00
|
|
|
return retval < 0 ? retval : 0;
|
2011-09-09 23:20:51 +00:00
|
|
|
|
2024-01-27 01:58:00 +00:00
|
|
|
add_delayed:
|
2024-01-27 01:58:01 +00:00
|
|
|
down_write(&EXT4_I(inode)->i_data_sem);
|
2024-05-17 12:39:57 +00:00
|
|
|
/*
|
|
|
|
* Page fault path (ext4_page_mkwrite does not take i_rwsem)
|
|
|
|
* and fallocate path (no folio lock) can race. Make sure we
|
|
|
|
* lookup the extent status tree here again while i_data_sem
|
|
|
|
* is held in write mode, before inserting a new da entry in
|
|
|
|
* the extent status tree.
|
|
|
|
*/
|
2024-05-17 12:40:00 +00:00
|
|
|
if (ext4_es_lookup_extent(inode, map->m_lblk, NULL, &es)) {
|
2024-05-17 12:40:05 +00:00
|
|
|
map->m_len = min_t(unsigned int, map->m_len,
|
|
|
|
es.es_len - (map->m_lblk - es.es_lblk));
|
ext4: trim delalloc extent
In ext4_da_map_blocks(), we could find four kind of extents in the
extent status tree: hole, unwritten, written and delayed extent. Now we
only trim the map len if we found an unwritten extent or a written
extent. This is okay now since map->m_len is always set to one and we
always insert one delayed block at a time. But this will become isn't
okay for other two cases if ext4_insert_delayed_block() and
ext4_da_map_blocks() support inserting multiple map->len blocks later.
1. If we found a hole in the extent status tree which es->es_len is
shorter than the length we want to write, we should trim the
map->m_len to prevent adding extra delay more blocks than we
expected. For example, assume we write data [A, C) to a file that
contains a hole extent [A, B) and a written extent [B, D) in the
cache.
A B C D
before da write: ...hhhhhh|wwwwww....
Then we will get extent [A, B), we should trim map->m_len to B-A
before inserting new delalloc blocks, if not, the range [B, C) will
be duplicated.
2. If we found a delayed extent in the extent status tree which
es->es_len is shorter than the length we want to write, we should
trim the map->m_len to es->es_len and return directly since the front
part of this map has been delayed, we can't insert the delalloc
extent that contains the latter part in this round, we should return
the delayed length and the caller should increase the position and
call ext4_da_map_blocks() again. For example, assume we write data
[A, C) to a file that contains a delayed extent [A, B) in the cache.
A B C
before da write: ...dddddd|hhh....
Then we will get delayed extent [A, B), we should also trim map->m_len
to B-A and return, if not, we will incorrectly assume that the write
is complete and won't insert [B, C).
So we need to always trim the map->m_len if the found es->es_len in the
extent status tree is shorter than the map->m_len, prearing for
inserting a extent with multiple delalloc blocks. This patch only does a
pre-fix, the handle is crude and ext4_da_map_blocks() deserve a cleanup,
we will do that later.
Signed-off-by: Zhang Yi <yi.zhang@huawei.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://patch.msgid.link/20240517124005.347221-5-yi.zhang@huaweicloud.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
2024-05-17 12:39:59 +00:00
|
|
|
|
2024-05-17 12:39:57 +00:00
|
|
|
if (!ext4_es_is_hole(&es)) {
|
|
|
|
up_write(&EXT4_I(inode)->i_data_sem);
|
|
|
|
goto found;
|
|
|
|
}
|
|
|
|
} else if (!ext4_has_inline_data(inode)) {
|
|
|
|
retval = ext4_map_query_blocks(NULL, inode, map);
|
|
|
|
if (retval) {
|
|
|
|
up_write(&EXT4_I(inode)->i_data_sem);
|
2024-05-17 12:40:05 +00:00
|
|
|
return retval < 0 ? retval : 0;
|
2024-05-17 12:39:57 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2024-05-17 12:40:05 +00:00
|
|
|
map->m_flags |= EXT4_MAP_DELAYED;
|
2024-05-17 12:40:04 +00:00
|
|
|
retval = ext4_insert_delayed_blocks(inode, map->m_lblk, map->m_len);
|
2024-01-27 01:58:01 +00:00
|
|
|
up_write(&EXT4_I(inode)->i_data_sem);
|
2024-01-27 01:58:00 +00:00
|
|
|
|
2011-09-09 23:20:51 +00:00
|
|
|
return retval;
|
|
|
|
}
|
|
|
|
|
2008-07-11 23:27:31 +00:00
|
|
|
/*
|
2014-09-02 02:15:30 +00:00
|
|
|
* This is a special get_block_t callback which is used by
|
2009-05-14 04:54:29 +00:00
|
|
|
* ext4_da_write_begin(). It will either return mapped block or
|
|
|
|
* reserve space for a single block.
|
2009-05-12 20:30:27 +00:00
|
|
|
*
|
|
|
|
* For delayed buffer_head we have BH_Mapped, BH_New, BH_Delay set.
|
|
|
|
* We also have b_blocknr = -1 and b_bdev initialized properly
|
|
|
|
*
|
|
|
|
* For unwritten buffer_head we have BH_Mapped, BH_New, BH_Unwritten set.
|
|
|
|
* We also have b_blocknr = physicalblock mapping unwritten extent and b_bdev
|
|
|
|
* initialized properly.
|
2008-07-11 23:27:31 +00:00
|
|
|
*/
|
2012-12-10 19:05:57 +00:00
|
|
|
int ext4_da_get_block_prep(struct inode *inode, sector_t iblock,
|
|
|
|
struct buffer_head *bh, int create)
|
2008-07-11 23:27:31 +00:00
|
|
|
{
|
2010-05-17 00:00:00 +00:00
|
|
|
struct ext4_map_blocks map;
|
2024-05-17 12:40:05 +00:00
|
|
|
sector_t invalid_block = ~((sector_t) 0xffff);
|
2008-07-11 23:27:31 +00:00
|
|
|
int ret = 0;
|
|
|
|
|
|
|
|
BUG_ON(create == 0);
|
2010-05-17 00:00:00 +00:00
|
|
|
BUG_ON(bh->b_size != inode->i_sb->s_blocksize);
|
|
|
|
|
2024-05-17 12:40:05 +00:00
|
|
|
if (invalid_block < ext4_blocks_count(EXT4_SB(inode->i_sb)->s_es))
|
|
|
|
invalid_block = ~0;
|
|
|
|
|
2010-05-17 00:00:00 +00:00
|
|
|
map.m_lblk = iblock;
|
|
|
|
map.m_len = 1;
|
2008-07-11 23:27:31 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* first, we need to know whether the block is allocated already
|
|
|
|
* preallocated blocks are unmapped but should treated
|
|
|
|
* the same as allocated blocks.
|
|
|
|
*/
|
2024-05-17 12:40:05 +00:00
|
|
|
ret = ext4_da_map_blocks(inode, &map);
|
|
|
|
if (ret < 0)
|
2010-05-17 00:00:00 +00:00
|
|
|
return ret;
|
2008-07-11 23:27:31 +00:00
|
|
|
|
2024-05-17 12:40:05 +00:00
|
|
|
if (map.m_flags & EXT4_MAP_DELAYED) {
|
|
|
|
map_bh(bh, inode->i_sb, invalid_block);
|
|
|
|
set_buffer_new(bh);
|
|
|
|
set_buffer_delay(bh);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2010-05-17 00:00:00 +00:00
|
|
|
map_bh(bh, inode->i_sb, map.m_pblk);
|
2016-02-19 05:18:25 +00:00
|
|
|
ext4_update_bh_state(bh, map.m_flags);
|
2010-05-17 00:00:00 +00:00
|
|
|
|
|
|
|
if (buffer_unwritten(bh)) {
|
|
|
|
/* A delayed write to unwritten bh should be marked
|
|
|
|
* new and mapped. Mapped ensures that we don't do
|
|
|
|
* get_block multiple times when we write to the same
|
|
|
|
* offset and new ensures that we do proper zero out
|
|
|
|
* for partial write.
|
|
|
|
*/
|
|
|
|
set_buffer_new(bh);
|
2011-04-11 02:30:07 +00:00
|
|
|
set_buffer_mapped(bh);
|
2010-05-17 00:00:00 +00:00
|
|
|
}
|
|
|
|
return 0;
|
2008-07-11 23:27:31 +00:00
|
|
|
}
|
2008-07-11 23:27:31 +00:00
|
|
|
|
2023-03-24 18:01:07 +00:00
|
|
|
static void mpage_folio_done(struct mpage_da_data *mpd, struct folio *folio)
|
2023-02-28 05:13:17 +00:00
|
|
|
{
|
2023-03-24 18:01:07 +00:00
|
|
|
mpd->first_page += folio_nr_pages(folio);
|
|
|
|
folio_unlock(folio);
|
2023-02-28 05:13:17 +00:00
|
|
|
}
|
|
|
|
|
2023-03-24 18:01:06 +00:00
|
|
|
static int mpage_submit_folio(struct mpage_da_data *mpd, struct folio *folio)
|
2013-08-17 14:02:33 +00:00
|
|
|
{
|
2023-03-24 18:01:06 +00:00
|
|
|
size_t len;
|
2017-05-26 21:45:45 +00:00
|
|
|
loff_t size;
|
2013-08-17 14:02:33 +00:00
|
|
|
int err;
|
|
|
|
|
2023-03-24 18:01:06 +00:00
|
|
|
BUG_ON(folio->index != mpd->first_page);
|
|
|
|
folio_clear_dirty_for_io(folio);
|
2017-05-26 21:45:45 +00:00
|
|
|
/*
|
|
|
|
* We have to be very careful here! Nothing protects writeback path
|
|
|
|
* against i_size changes and the page can be writeably mapped into
|
|
|
|
* page tables. So an application can be growing i_size and writing
|
2023-03-24 18:01:06 +00:00
|
|
|
* data through mmap while writeback runs. folio_clear_dirty_for_io()
|
2017-05-26 21:45:45 +00:00
|
|
|
* write-protects our page in page tables and the page cannot get
|
2023-03-24 18:01:06 +00:00
|
|
|
* written to again until we release folio lock. So only after
|
|
|
|
* folio_clear_dirty_for_io() we are safe to sample i_size for
|
2023-03-24 18:01:08 +00:00
|
|
|
* ext4_bio_write_folio() to zero-out tail of the written page. We rely
|
|
|
|
* on the barrier provided by folio_test_clear_dirty() in
|
2023-03-24 18:01:06 +00:00
|
|
|
* folio_clear_dirty_for_io() to make sure i_size is really sampled only
|
2017-05-26 21:45:45 +00:00
|
|
|
* after page tables are updated.
|
|
|
|
*/
|
|
|
|
size = i_size_read(mpd->inode);
|
2023-03-24 18:01:06 +00:00
|
|
|
len = folio_size(folio);
|
|
|
|
if (folio_pos(folio) + len > size &&
|
2019-07-22 16:26:24 +00:00
|
|
|
!ext4_verity_in_progress(mpd->inode))
|
2024-02-29 06:10:14 +00:00
|
|
|
len = size & (len - 1);
|
2023-03-24 18:01:08 +00:00
|
|
|
err = ext4_bio_write_folio(&mpd->io_submit, folio, len);
|
2013-08-17 14:02:33 +00:00
|
|
|
if (!err)
|
|
|
|
mpd->wbc->nr_to_write--;
|
|
|
|
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
2020-05-10 06:24:51 +00:00
|
|
|
#define BH_FLAGS (BIT(BH_Unwritten) | BIT(BH_Delay))
|
2013-06-04 17:17:40 +00:00
|
|
|
|
2008-07-11 23:27:31 +00:00
|
|
|
/*
|
2013-06-04 17:01:11 +00:00
|
|
|
* mballoc gives us at most this number of blocks...
|
|
|
|
* XXX: That seems to be only a limitation of ext4_mb_normalize_request().
|
2013-08-28 18:40:12 +00:00
|
|
|
* The rest of mballoc seems to handle chunks up to full group size.
|
2008-07-11 23:27:31 +00:00
|
|
|
*/
|
2013-06-04 17:01:11 +00:00
|
|
|
#define MAX_WRITEPAGES_EXTENT_LEN 2048
|
2008-08-20 02:15:58 +00:00
|
|
|
|
2013-06-04 17:17:40 +00:00
|
|
|
/*
|
|
|
|
* mpage_add_bh_to_extent - try to add bh to extent of blocks to map
|
|
|
|
*
|
|
|
|
* @mpd - extent of blocks
|
|
|
|
* @lblk - logical number of the block in the file
|
2013-08-17 13:57:56 +00:00
|
|
|
* @bh - buffer head we want to add to the extent
|
2013-06-04 17:17:40 +00:00
|
|
|
*
|
2013-08-17 13:57:56 +00:00
|
|
|
* The function is used to collect contig. blocks in the same state. If the
|
|
|
|
* buffer doesn't require mapping for writeback and we haven't started the
|
|
|
|
* extent of buffers to map yet, the function returns 'true' immediately - the
|
|
|
|
* caller can write the buffer right away. Otherwise the function returns true
|
|
|
|
* if the block has been added to the extent, false if the block couldn't be
|
|
|
|
* added.
|
2013-06-04 17:17:40 +00:00
|
|
|
*/
|
2013-08-17 13:57:56 +00:00
|
|
|
static bool mpage_add_bh_to_extent(struct mpage_da_data *mpd, ext4_lblk_t lblk,
|
|
|
|
struct buffer_head *bh)
|
2013-06-04 17:17:40 +00:00
|
|
|
{
|
|
|
|
struct ext4_map_blocks *map = &mpd->map;
|
|
|
|
|
2013-08-17 13:57:56 +00:00
|
|
|
/* Buffer that doesn't need mapping for writeback? */
|
|
|
|
if (!buffer_dirty(bh) || !buffer_mapped(bh) ||
|
|
|
|
(!buffer_delay(bh) && !buffer_unwritten(bh))) {
|
|
|
|
/* So far no extent to map => we write the buffer right away */
|
|
|
|
if (map->m_len == 0)
|
|
|
|
return true;
|
|
|
|
return false;
|
|
|
|
}
|
2013-06-04 17:17:40 +00:00
|
|
|
|
|
|
|
/* First block in the extent? */
|
|
|
|
if (map->m_len == 0) {
|
ext4: avoid unnecessary transaction stalls during writeback
Currently ext4_writepages() submits all pages with transaction started.
When no page needs block allocation or extent conversion we can submit
all dirty pages in the inode while holding a single transaction handle
and when device is congested this can take significant amount of time.
Thus ext4_writepages() can block transaction commits for extended
periods of time.
Take for example a simple benchmark simulating PostgreSQL database
(pgioperf in mmtest). The benchmark runs 16 processes doing random reads
from a huge file, one process doing random writes to the huge file, and
one process doing sequential writes to a small files and frequently
running fsync. With unpatched kernel transaction commits take on average
~18s with standard deviation of ~41s, top 5 commit times are:
274.466639s, 126.467347s, 86.992429s, 34.351563s, 31.517653s.
After this patch transaction commits take on average 0.1s with standard
deviation of 0.15s, top 5 commit times are:
0.563792s, 0.519980s, 0.509841s, 0.471700s, 0.469899s
[ Modified so we use an explicit do_map flag instead of relying on
io_end not being allocated, the since io_end->inode is needed for I/O
error handling. -- tytso ]
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
2017-04-30 22:29:10 +00:00
|
|
|
/* We cannot map unless handle is started... */
|
|
|
|
if (!mpd->do_map)
|
|
|
|
return false;
|
2013-06-04 17:17:40 +00:00
|
|
|
map->m_lblk = lblk;
|
|
|
|
map->m_len = 1;
|
2013-08-17 13:57:56 +00:00
|
|
|
map->m_flags = bh->b_state & BH_FLAGS;
|
|
|
|
return true;
|
2013-06-04 17:17:40 +00:00
|
|
|
}
|
|
|
|
|
2013-08-17 13:57:56 +00:00
|
|
|
/* Don't go larger than mballoc is willing to allocate */
|
|
|
|
if (map->m_len >= MAX_WRITEPAGES_EXTENT_LEN)
|
|
|
|
return false;
|
|
|
|
|
2013-06-04 17:17:40 +00:00
|
|
|
/* Can we merge the block to our big extent? */
|
|
|
|
if (lblk == map->m_lblk + map->m_len &&
|
2013-08-17 13:57:56 +00:00
|
|
|
(bh->b_state & BH_FLAGS) == map->m_flags) {
|
2013-06-04 17:17:40 +00:00
|
|
|
map->m_len++;
|
2013-08-17 13:57:56 +00:00
|
|
|
return true;
|
2013-06-04 17:17:40 +00:00
|
|
|
}
|
2013-08-17 13:57:56 +00:00
|
|
|
return false;
|
2013-06-04 17:17:40 +00:00
|
|
|
}
|
|
|
|
|
2013-08-17 14:02:33 +00:00
|
|
|
/*
|
|
|
|
* mpage_process_page_bufs - submit page buffers for IO or add them to extent
|
|
|
|
*
|
|
|
|
* @mpd - extent of blocks for mapping
|
|
|
|
* @head - the first buffer in the page
|
|
|
|
* @bh - buffer we should start processing from
|
|
|
|
* @lblk - logical number of the block in the file corresponding to @bh
|
|
|
|
*
|
|
|
|
* Walk through page buffers from @bh upto @head (exclusive) and either submit
|
|
|
|
* the page for IO if all buffers in this page were mapped and there's no
|
|
|
|
* accumulated extent of buffers to map or add buffers in the page to the
|
|
|
|
* extent of buffers to map. The function returns 1 if the caller can continue
|
|
|
|
* by processing the next page, 0 if it should stop adding buffers to the
|
|
|
|
* extent to map because we cannot extend it anymore. It can also return value
|
|
|
|
* < 0 in case of error during IO submission.
|
|
|
|
*/
|
|
|
|
static int mpage_process_page_bufs(struct mpage_da_data *mpd,
|
|
|
|
struct buffer_head *head,
|
|
|
|
struct buffer_head *bh,
|
|
|
|
ext4_lblk_t lblk)
|
2013-06-04 17:17:40 +00:00
|
|
|
{
|
|
|
|
struct inode *inode = mpd->inode;
|
2013-08-17 14:02:33 +00:00
|
|
|
int err;
|
2017-02-27 22:28:32 +00:00
|
|
|
ext4_lblk_t blocks = (i_size_read(inode) + i_blocksize(inode) - 1)
|
2013-06-04 17:17:40 +00:00
|
|
|
>> inode->i_blkbits;
|
|
|
|
|
2019-07-22 16:26:24 +00:00
|
|
|
if (ext4_verity_in_progress(inode))
|
|
|
|
blocks = EXT_MAX_BLOCKS;
|
|
|
|
|
2013-06-04 17:17:40 +00:00
|
|
|
do {
|
|
|
|
BUG_ON(buffer_locked(bh));
|
|
|
|
|
2013-08-17 13:57:56 +00:00
|
|
|
if (lblk >= blocks || !mpage_add_bh_to_extent(mpd, lblk, bh)) {
|
2013-06-04 17:17:40 +00:00
|
|
|
/* Found extent to map? */
|
|
|
|
if (mpd->map.m_len)
|
2013-08-17 14:02:33 +00:00
|
|
|
return 0;
|
ext4: avoid unnecessary transaction stalls during writeback
Currently ext4_writepages() submits all pages with transaction started.
When no page needs block allocation or extent conversion we can submit
all dirty pages in the inode while holding a single transaction handle
and when device is congested this can take significant amount of time.
Thus ext4_writepages() can block transaction commits for extended
periods of time.
Take for example a simple benchmark simulating PostgreSQL database
(pgioperf in mmtest). The benchmark runs 16 processes doing random reads
from a huge file, one process doing random writes to the huge file, and
one process doing sequential writes to a small files and frequently
running fsync. With unpatched kernel transaction commits take on average
~18s with standard deviation of ~41s, top 5 commit times are:
274.466639s, 126.467347s, 86.992429s, 34.351563s, 31.517653s.
After this patch transaction commits take on average 0.1s with standard
deviation of 0.15s, top 5 commit times are:
0.563792s, 0.519980s, 0.509841s, 0.471700s, 0.469899s
[ Modified so we use an explicit do_map flag instead of relying on
io_end not being allocated, the since io_end->inode is needed for I/O
error handling. -- tytso ]
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
2017-04-30 22:29:10 +00:00
|
|
|
/* Buffer needs mapping and handle is not started? */
|
|
|
|
if (!mpd->do_map)
|
|
|
|
return 0;
|
2013-08-17 13:57:56 +00:00
|
|
|
/* Everything mapped so far and we hit EOF */
|
2013-08-17 14:02:33 +00:00
|
|
|
break;
|
2013-06-04 17:17:40 +00:00
|
|
|
}
|
|
|
|
} while (lblk++, (bh = bh->b_this_page) != head);
|
2013-08-17 14:02:33 +00:00
|
|
|
/* So far everything mapped? Submit the page for IO. */
|
|
|
|
if (mpd->map.m_len == 0) {
|
2023-03-24 18:01:06 +00:00
|
|
|
err = mpage_submit_folio(mpd, head->b_folio);
|
2013-08-17 14:02:33 +00:00
|
|
|
if (err < 0)
|
|
|
|
return err;
|
2023-03-24 18:01:07 +00:00
|
|
|
mpage_folio_done(mpd, head->b_folio);
|
2013-08-17 14:02:33 +00:00
|
|
|
}
|
2020-05-25 08:12:15 +00:00
|
|
|
if (lblk >= blocks) {
|
|
|
|
mpd->scanned_until_end = 1;
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
return 1;
|
2013-06-04 17:17:40 +00:00
|
|
|
}
|
|
|
|
|
2019-10-16 07:37:09 +00:00
|
|
|
/*
|
2023-03-24 18:01:05 +00:00
|
|
|
* mpage_process_folio - update folio buffers corresponding to changed extent
|
|
|
|
* and may submit fully mapped page for IO
|
|
|
|
* @mpd: description of extent to map, on return next extent to map
|
|
|
|
* @folio: Contains these buffers.
|
|
|
|
* @m_lblk: logical block mapping.
|
|
|
|
* @m_pblk: corresponding physical mapping.
|
|
|
|
* @map_bh: determines on return whether this page requires any further
|
2019-10-16 07:37:09 +00:00
|
|
|
* mapping or not.
|
2023-03-24 18:01:05 +00:00
|
|
|
*
|
|
|
|
* Scan given folio buffers corresponding to changed extent and update buffer
|
2019-10-16 07:37:09 +00:00
|
|
|
* state according to new extent state.
|
|
|
|
* We map delalloc buffers to their physical location, clear unwritten bits.
|
2023-03-24 18:01:05 +00:00
|
|
|
* If the given folio is not fully mapped, we update @mpd to the next extent in
|
|
|
|
* the given folio that needs mapping & return @map_bh as true.
|
2019-10-16 07:37:09 +00:00
|
|
|
*/
|
2023-03-24 18:01:05 +00:00
|
|
|
static int mpage_process_folio(struct mpage_da_data *mpd, struct folio *folio,
|
2019-10-16 07:37:09 +00:00
|
|
|
ext4_lblk_t *m_lblk, ext4_fsblk_t *m_pblk,
|
|
|
|
bool *map_bh)
|
|
|
|
{
|
|
|
|
struct buffer_head *head, *bh;
|
|
|
|
ext4_io_end_t *io_end = mpd->io_submit.io_end;
|
|
|
|
ext4_lblk_t lblk = *m_lblk;
|
|
|
|
ext4_fsblk_t pblock = *m_pblk;
|
|
|
|
int err = 0;
|
2019-10-16 07:37:10 +00:00
|
|
|
int blkbits = mpd->inode->i_blkbits;
|
|
|
|
ssize_t io_end_size = 0;
|
|
|
|
struct ext4_io_end_vec *io_end_vec = ext4_last_io_end_vec(io_end);
|
2019-10-16 07:37:09 +00:00
|
|
|
|
2023-03-24 18:01:05 +00:00
|
|
|
bh = head = folio_buffers(folio);
|
2019-10-16 07:37:09 +00:00
|
|
|
do {
|
|
|
|
if (lblk < mpd->map.m_lblk)
|
|
|
|
continue;
|
|
|
|
if (lblk >= mpd->map.m_lblk + mpd->map.m_len) {
|
|
|
|
/*
|
|
|
|
* Buffer after end of mapped extent.
|
2023-03-24 18:01:05 +00:00
|
|
|
* Find next buffer in the folio to map.
|
2019-10-16 07:37:09 +00:00
|
|
|
*/
|
|
|
|
mpd->map.m_len = 0;
|
|
|
|
mpd->map.m_flags = 0;
|
2019-10-16 07:37:10 +00:00
|
|
|
io_end_vec->size += io_end_size;
|
2019-10-16 07:37:09 +00:00
|
|
|
|
|
|
|
err = mpage_process_page_bufs(mpd, head, bh, lblk);
|
|
|
|
if (err > 0)
|
|
|
|
err = 0;
|
2019-10-16 07:37:10 +00:00
|
|
|
if (!err && mpd->map.m_len && mpd->map.m_lblk > lblk) {
|
|
|
|
io_end_vec = ext4_alloc_io_end_vec(io_end);
|
2019-11-06 09:38:09 +00:00
|
|
|
if (IS_ERR(io_end_vec)) {
|
|
|
|
err = PTR_ERR(io_end_vec);
|
|
|
|
goto out;
|
|
|
|
}
|
2020-10-08 15:02:48 +00:00
|
|
|
io_end_vec->offset = (loff_t)mpd->map.m_lblk << blkbits;
|
2019-10-16 07:37:10 +00:00
|
|
|
}
|
2019-10-16 07:37:09 +00:00
|
|
|
*map_bh = true;
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
if (buffer_delay(bh)) {
|
|
|
|
clear_buffer_delay(bh);
|
|
|
|
bh->b_blocknr = pblock++;
|
|
|
|
}
|
|
|
|
clear_buffer_unwritten(bh);
|
2019-10-16 07:37:10 +00:00
|
|
|
io_end_size += (1 << blkbits);
|
2019-10-16 07:37:09 +00:00
|
|
|
} while (lblk++, (bh = bh->b_this_page) != head);
|
2019-10-16 07:37:10 +00:00
|
|
|
|
|
|
|
io_end_vec->size += io_end_size;
|
2019-10-16 07:37:09 +00:00
|
|
|
*map_bh = false;
|
|
|
|
out:
|
|
|
|
*m_lblk = lblk;
|
|
|
|
*m_pblk = pblock;
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
2013-06-04 17:17:40 +00:00
|
|
|
/*
|
|
|
|
* mpage_map_buffers - update buffers corresponding to changed extent and
|
|
|
|
* submit fully mapped pages for IO
|
|
|
|
*
|
|
|
|
* @mpd - description of extent to map, on return next extent to map
|
|
|
|
*
|
|
|
|
* Scan buffers corresponding to changed extent (we expect corresponding pages
|
|
|
|
* to be already locked) and update buffer state according to new extent state.
|
|
|
|
* We map delalloc buffers to their physical location, clear unwritten bits,
|
2014-04-21 03:45:47 +00:00
|
|
|
* and mark buffers as uninit when we perform writes to unwritten extents
|
2013-06-04 17:17:40 +00:00
|
|
|
* and do extent conversion after IO is finished. If the last page is not fully
|
|
|
|
* mapped, we update @map to the next extent in the last page that needs
|
|
|
|
* mapping. Otherwise we submit the page for IO.
|
|
|
|
*/
|
|
|
|
static int mpage_map_and_submit_buffers(struct mpage_da_data *mpd)
|
|
|
|
{
|
2022-06-04 20:26:01 +00:00
|
|
|
struct folio_batch fbatch;
|
|
|
|
unsigned nr, i;
|
2013-06-04 17:17:40 +00:00
|
|
|
struct inode *inode = mpd->inode;
|
mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros
PAGE_CACHE_{SIZE,SHIFT,MASK,ALIGN} macros were introduced *long* time
ago with promise that one day it will be possible to implement page
cache with bigger chunks than PAGE_SIZE.
This promise never materialized. And unlikely will.
We have many places where PAGE_CACHE_SIZE assumed to be equal to
PAGE_SIZE. And it's constant source of confusion on whether
PAGE_CACHE_* or PAGE_* constant should be used in a particular case,
especially on the border between fs and mm.
Global switching to PAGE_CACHE_SIZE != PAGE_SIZE would cause to much
breakage to be doable.
Let's stop pretending that pages in page cache are special. They are
not.
The changes are pretty straight-forward:
- <foo> << (PAGE_CACHE_SHIFT - PAGE_SHIFT) -> <foo>;
- <foo> >> (PAGE_CACHE_SHIFT - PAGE_SHIFT) -> <foo>;
- PAGE_CACHE_{SIZE,SHIFT,MASK,ALIGN} -> PAGE_{SIZE,SHIFT,MASK,ALIGN};
- page_cache_get() -> get_page();
- page_cache_release() -> put_page();
This patch contains automated changes generated with coccinelle using
script below. For some reason, coccinelle doesn't patch header files.
I've called spatch for them manually.
The only adjustment after coccinelle is revert of changes to
PAGE_CAHCE_ALIGN definition: we are going to drop it later.
There are few places in the code where coccinelle didn't reach. I'll
fix them manually in a separate patch. Comments and documentation also
will be addressed with the separate patch.
virtual patch
@@
expression E;
@@
- E << (PAGE_CACHE_SHIFT - PAGE_SHIFT)
+ E
@@
expression E;
@@
- E >> (PAGE_CACHE_SHIFT - PAGE_SHIFT)
+ E
@@
@@
- PAGE_CACHE_SHIFT
+ PAGE_SHIFT
@@
@@
- PAGE_CACHE_SIZE
+ PAGE_SIZE
@@
@@
- PAGE_CACHE_MASK
+ PAGE_MASK
@@
expression E;
@@
- PAGE_CACHE_ALIGN(E)
+ PAGE_ALIGN(E)
@@
expression E;
@@
- page_cache_get(E)
+ get_page(E)
@@
expression E;
@@
- page_cache_release(E)
+ put_page(E)
Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Acked-by: Michal Hocko <mhocko@suse.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2016-04-01 12:29:47 +00:00
|
|
|
int bpp_bits = PAGE_SHIFT - inode->i_blkbits;
|
2013-06-04 17:17:40 +00:00
|
|
|
pgoff_t start, end;
|
|
|
|
ext4_lblk_t lblk;
|
2019-10-16 07:37:09 +00:00
|
|
|
ext4_fsblk_t pblock;
|
2013-06-04 17:17:40 +00:00
|
|
|
int err;
|
2019-10-16 07:37:09 +00:00
|
|
|
bool map_bh = false;
|
2013-06-04 17:17:40 +00:00
|
|
|
|
|
|
|
start = mpd->map.m_lblk >> bpp_bits;
|
|
|
|
end = (mpd->map.m_lblk + mpd->map.m_len - 1) >> bpp_bits;
|
|
|
|
lblk = start << bpp_bits;
|
|
|
|
pblock = mpd->map.m_pblk;
|
|
|
|
|
2022-06-04 20:26:01 +00:00
|
|
|
folio_batch_init(&fbatch);
|
2013-06-04 17:17:40 +00:00
|
|
|
while (start <= end) {
|
2022-06-04 20:26:01 +00:00
|
|
|
nr = filemap_get_folios(inode->i_mapping, &start, end, &fbatch);
|
|
|
|
if (nr == 0)
|
2013-06-04 17:17:40 +00:00
|
|
|
break;
|
2022-06-04 20:26:01 +00:00
|
|
|
for (i = 0; i < nr; i++) {
|
2023-03-24 18:01:05 +00:00
|
|
|
struct folio *folio = fbatch.folios[i];
|
2013-06-04 17:17:40 +00:00
|
|
|
|
2023-03-24 18:01:05 +00:00
|
|
|
err = mpage_process_folio(mpd, folio, &lblk, &pblock,
|
2019-10-16 07:37:09 +00:00
|
|
|
&map_bh);
|
2013-06-04 17:17:40 +00:00
|
|
|
/*
|
2019-10-16 07:37:09 +00:00
|
|
|
* If map_bh is true, means page may require further bh
|
|
|
|
* mapping, or maybe the page was submitted for IO.
|
|
|
|
* So we return to call further extent mapping.
|
2013-06-04 17:17:40 +00:00
|
|
|
*/
|
2020-04-20 04:29:18 +00:00
|
|
|
if (err < 0 || map_bh)
|
2019-10-16 07:37:09 +00:00
|
|
|
goto out;
|
2013-06-04 17:17:40 +00:00
|
|
|
/* Page fully mapped - let IO run! */
|
2023-03-24 18:01:06 +00:00
|
|
|
err = mpage_submit_folio(mpd, folio);
|
2019-10-16 07:37:09 +00:00
|
|
|
if (err < 0)
|
|
|
|
goto out;
|
2023-03-24 18:01:07 +00:00
|
|
|
mpage_folio_done(mpd, folio);
|
2013-06-04 17:17:40 +00:00
|
|
|
}
|
2022-06-04 20:26:01 +00:00
|
|
|
folio_batch_release(&fbatch);
|
2013-06-04 17:17:40 +00:00
|
|
|
}
|
|
|
|
/* Extent fully mapped and matches with page boundary. We are done. */
|
|
|
|
mpd->map.m_len = 0;
|
|
|
|
mpd->map.m_flags = 0;
|
|
|
|
return 0;
|
2019-10-16 07:37:09 +00:00
|
|
|
out:
|
2022-06-04 20:26:01 +00:00
|
|
|
folio_batch_release(&fbatch);
|
2019-10-16 07:37:09 +00:00
|
|
|
return err;
|
2013-06-04 17:17:40 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static int mpage_map_one_extent(handle_t *handle, struct mpage_da_data *mpd)
|
|
|
|
{
|
|
|
|
struct inode *inode = mpd->inode;
|
|
|
|
struct ext4_map_blocks *map = &mpd->map;
|
|
|
|
int get_blocks_flags;
|
2014-04-21 03:44:47 +00:00
|
|
|
int err, dioread_nolock;
|
2013-06-04 17:17:40 +00:00
|
|
|
|
|
|
|
trace_ext4_da_write_pages_extent(inode, map);
|
|
|
|
/*
|
|
|
|
* Call ext4_map_blocks() to allocate any delayed allocation blocks, or
|
2014-04-21 03:45:47 +00:00
|
|
|
* to convert an unwritten extent to be initialized (in the case
|
2013-06-04 17:17:40 +00:00
|
|
|
* where we have written into one or more preallocated blocks). It is
|
|
|
|
* possible that we're going to need more metadata blocks than
|
|
|
|
* previously reserved. However we must not fail because we're in
|
|
|
|
* writeback and there is nothing we can do about it so it might result
|
|
|
|
* in data loss. So use reserved blocks to allocate metadata if
|
|
|
|
* possible.
|
|
|
|
*/
|
|
|
|
get_blocks_flags = EXT4_GET_BLOCKS_CREATE |
|
2016-04-24 04:56:08 +00:00
|
|
|
EXT4_GET_BLOCKS_METADATA_NOFAIL |
|
|
|
|
EXT4_GET_BLOCKS_IO_SUBMIT;
|
2014-04-21 03:44:47 +00:00
|
|
|
dioread_nolock = ext4_should_dioread_nolock(inode);
|
|
|
|
if (dioread_nolock)
|
2013-06-04 17:17:40 +00:00
|
|
|
get_blocks_flags |= EXT4_GET_BLOCKS_IO_CREATE_EXT;
|
|
|
|
|
|
|
|
err = ext4_map_blocks(handle, inode, map, get_blocks_flags);
|
|
|
|
if (err < 0)
|
|
|
|
return err;
|
2014-04-21 03:44:47 +00:00
|
|
|
if (dioread_nolock && (map->m_flags & EXT4_MAP_UNWRITTEN)) {
|
2013-06-04 17:21:11 +00:00
|
|
|
if (!mpd->io_submit.io_end->handle &&
|
|
|
|
ext4_handle_valid(handle)) {
|
|
|
|
mpd->io_submit.io_end->handle = handle->h_rsv_handle;
|
|
|
|
handle->h_rsv_handle = NULL;
|
|
|
|
}
|
2013-06-04 17:19:34 +00:00
|
|
|
ext4_set_io_unwritten_flag(inode, mpd->io_submit.io_end);
|
2013-06-04 17:21:11 +00:00
|
|
|
}
|
2013-06-04 17:17:40 +00:00
|
|
|
|
|
|
|
BUG_ON(map->m_len == 0);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* mpage_map_and_submit_extent - map extent starting at mpd->lblk of length
|
|
|
|
* mpd->len and submit pages underlying it for IO
|
|
|
|
*
|
|
|
|
* @handle - handle for journal operations
|
|
|
|
* @mpd - extent to map
|
2013-10-16 12:26:08 +00:00
|
|
|
* @give_up_on_write - we set this to true iff there is a fatal error and there
|
|
|
|
* is no hope of writing the data. The caller should discard
|
|
|
|
* dirty pages to avoid infinite loops.
|
2013-06-04 17:17:40 +00:00
|
|
|
*
|
|
|
|
* The function maps extent starting at mpd->lblk of length mpd->len. If it is
|
|
|
|
* delayed, blocks are allocated, if it is unwritten, we may need to convert
|
|
|
|
* them to initialized or split the described range from larger unwritten
|
|
|
|
* extent. Note that we need not map all the described range since allocation
|
|
|
|
* can return less blocks or the range is covered by more unwritten extents. We
|
|
|
|
* cannot map more because we are limited by reserved transaction credits. On
|
|
|
|
* the other hand we always make sure that the last touched page is fully
|
|
|
|
* mapped so that it can be written out (and thus forward progress is
|
|
|
|
* guaranteed). After mapping we submit all mapped pages for IO.
|
|
|
|
*/
|
|
|
|
static int mpage_map_and_submit_extent(handle_t *handle,
|
2013-07-01 12:12:40 +00:00
|
|
|
struct mpage_da_data *mpd,
|
|
|
|
bool *give_up_on_write)
|
2013-06-04 17:17:40 +00:00
|
|
|
{
|
|
|
|
struct inode *inode = mpd->inode;
|
|
|
|
struct ext4_map_blocks *map = &mpd->map;
|
|
|
|
int err;
|
|
|
|
loff_t disksize;
|
2014-08-27 22:40:03 +00:00
|
|
|
int progress = 0;
|
2019-10-16 07:37:10 +00:00
|
|
|
ext4_io_end_t *io_end = mpd->io_submit.io_end;
|
2019-11-06 09:38:09 +00:00
|
|
|
struct ext4_io_end_vec *io_end_vec;
|
2013-06-04 17:17:40 +00:00
|
|
|
|
2019-11-06 09:38:09 +00:00
|
|
|
io_end_vec = ext4_alloc_io_end_vec(io_end);
|
|
|
|
if (IS_ERR(io_end_vec))
|
|
|
|
return PTR_ERR(io_end_vec);
|
2019-10-16 07:37:10 +00:00
|
|
|
io_end_vec->offset = ((loff_t)map->m_lblk) << inode->i_blkbits;
|
2013-07-06 01:57:22 +00:00
|
|
|
do {
|
2013-06-04 17:17:40 +00:00
|
|
|
err = mpage_map_one_extent(handle, mpd);
|
|
|
|
if (err < 0) {
|
|
|
|
struct super_block *sb = inode->i_sb;
|
|
|
|
|
2023-06-16 16:50:51 +00:00
|
|
|
if (ext4_forced_shutdown(sb))
|
2013-07-01 12:12:40 +00:00
|
|
|
goto invalidate_dirty_pages;
|
2013-06-04 17:17:40 +00:00
|
|
|
/*
|
2013-07-01 12:12:40 +00:00
|
|
|
* Let the uper layers retry transient errors.
|
|
|
|
* In the case of ENOSPC, if ext4_count_free_blocks()
|
|
|
|
* is non-zero, a commit should free up blocks.
|
2013-06-04 17:17:40 +00:00
|
|
|
*/
|
2013-07-01 12:12:40 +00:00
|
|
|
if ((err == -ENOMEM) ||
|
2014-08-27 22:40:03 +00:00
|
|
|
(err == -ENOSPC && ext4_count_free_clusters(sb))) {
|
|
|
|
if (progress)
|
|
|
|
goto update_disksize;
|
2013-07-01 12:12:40 +00:00
|
|
|
return err;
|
2014-08-27 22:40:03 +00:00
|
|
|
}
|
2013-07-01 12:12:40 +00:00
|
|
|
ext4_msg(sb, KERN_CRIT,
|
|
|
|
"Delayed block allocation failed for "
|
|
|
|
"inode %lu at logical offset %llu with"
|
|
|
|
" max blocks %u with error %d",
|
|
|
|
inode->i_ino,
|
|
|
|
(unsigned long long)map->m_lblk,
|
|
|
|
(unsigned)map->m_len, -err);
|
|
|
|
ext4_msg(sb, KERN_CRIT,
|
|
|
|
"This should not happen!! Data will "
|
|
|
|
"be lost\n");
|
|
|
|
if (err == -ENOSPC)
|
|
|
|
ext4_print_free_blocks(inode);
|
|
|
|
invalidate_dirty_pages:
|
|
|
|
*give_up_on_write = true;
|
2013-06-04 17:17:40 +00:00
|
|
|
return err;
|
|
|
|
}
|
2014-08-27 22:40:03 +00:00
|
|
|
progress = 1;
|
2013-06-04 17:17:40 +00:00
|
|
|
/*
|
|
|
|
* Update buffer state, submit mapped pages, and get us new
|
|
|
|
* extent to map
|
|
|
|
*/
|
|
|
|
err = mpage_map_and_submit_buffers(mpd);
|
|
|
|
if (err < 0)
|
2014-08-27 22:40:03 +00:00
|
|
|
goto update_disksize;
|
2013-07-06 01:57:22 +00:00
|
|
|
} while (map->m_len);
|
2013-06-04 17:17:40 +00:00
|
|
|
|
2014-08-27 22:40:03 +00:00
|
|
|
update_disksize:
|
2014-04-11 14:35:17 +00:00
|
|
|
/*
|
|
|
|
* Update on-disk size after IO is submitted. Races with
|
|
|
|
* truncate are avoided by checking i_size under i_data_sem.
|
|
|
|
*/
|
mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros
PAGE_CACHE_{SIZE,SHIFT,MASK,ALIGN} macros were introduced *long* time
ago with promise that one day it will be possible to implement page
cache with bigger chunks than PAGE_SIZE.
This promise never materialized. And unlikely will.
We have many places where PAGE_CACHE_SIZE assumed to be equal to
PAGE_SIZE. And it's constant source of confusion on whether
PAGE_CACHE_* or PAGE_* constant should be used in a particular case,
especially on the border between fs and mm.
Global switching to PAGE_CACHE_SIZE != PAGE_SIZE would cause to much
breakage to be doable.
Let's stop pretending that pages in page cache are special. They are
not.
The changes are pretty straight-forward:
- <foo> << (PAGE_CACHE_SHIFT - PAGE_SHIFT) -> <foo>;
- <foo> >> (PAGE_CACHE_SHIFT - PAGE_SHIFT) -> <foo>;
- PAGE_CACHE_{SIZE,SHIFT,MASK,ALIGN} -> PAGE_{SIZE,SHIFT,MASK,ALIGN};
- page_cache_get() -> get_page();
- page_cache_release() -> put_page();
This patch contains automated changes generated with coccinelle using
script below. For some reason, coccinelle doesn't patch header files.
I've called spatch for them manually.
The only adjustment after coccinelle is revert of changes to
PAGE_CAHCE_ALIGN definition: we are going to drop it later.
There are few places in the code where coccinelle didn't reach. I'll
fix them manually in a separate patch. Comments and documentation also
will be addressed with the separate patch.
virtual patch
@@
expression E;
@@
- E << (PAGE_CACHE_SHIFT - PAGE_SHIFT)
+ E
@@
expression E;
@@
- E >> (PAGE_CACHE_SHIFT - PAGE_SHIFT)
+ E
@@
@@
- PAGE_CACHE_SHIFT
+ PAGE_SHIFT
@@
@@
- PAGE_CACHE_SIZE
+ PAGE_SIZE
@@
@@
- PAGE_CACHE_MASK
+ PAGE_MASK
@@
expression E;
@@
- PAGE_CACHE_ALIGN(E)
+ PAGE_ALIGN(E)
@@
expression E;
@@
- page_cache_get(E)
+ get_page(E)
@@
expression E;
@@
- page_cache_release(E)
+ put_page(E)
Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Acked-by: Michal Hocko <mhocko@suse.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2016-04-01 12:29:47 +00:00
|
|
|
disksize = ((loff_t)mpd->first_page) << PAGE_SHIFT;
|
2020-02-07 14:29:11 +00:00
|
|
|
if (disksize > READ_ONCE(EXT4_I(inode)->i_disksize)) {
|
2013-06-04 17:17:40 +00:00
|
|
|
int err2;
|
2014-04-11 14:35:17 +00:00
|
|
|
loff_t i_size;
|
|
|
|
|
|
|
|
down_write(&EXT4_I(inode)->i_data_sem);
|
|
|
|
i_size = i_size_read(inode);
|
|
|
|
if (disksize > i_size)
|
|
|
|
disksize = i_size;
|
|
|
|
if (disksize > EXT4_I(inode)->i_disksize)
|
|
|
|
EXT4_I(inode)->i_disksize = disksize;
|
|
|
|
up_write(&EXT4_I(inode)->i_data_sem);
|
2017-01-12 03:14:49 +00:00
|
|
|
err2 = ext4_mark_inode_dirty(handle, inode);
|
2019-11-20 02:54:15 +00:00
|
|
|
if (err2) {
|
2020-03-28 23:33:43 +00:00
|
|
|
ext4_error_err(inode->i_sb, -err2,
|
|
|
|
"Failed to mark inode %lu dirty",
|
|
|
|
inode->i_ino);
|
2019-11-20 02:54:15 +00:00
|
|
|
}
|
2013-06-04 17:17:40 +00:00
|
|
|
if (!err)
|
|
|
|
err = err2;
|
|
|
|
}
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
2013-06-04 17:01:11 +00:00
|
|
|
/*
|
|
|
|
* Calculate the total number of credits to reserve for one writepages
|
2013-06-06 18:00:46 +00:00
|
|
|
* iteration. This is called from ext4_writepages(). We map an extent of
|
2013-08-28 18:40:12 +00:00
|
|
|
* up to MAX_WRITEPAGES_EXTENT_LEN blocks and then we go on and finish mapping
|
2013-06-04 17:01:11 +00:00
|
|
|
* the last partial page. So in total we can map MAX_WRITEPAGES_EXTENT_LEN +
|
|
|
|
* bpp - 1 blocks in bpp different extents.
|
|
|
|
*/
|
2008-08-20 02:15:58 +00:00
|
|
|
static int ext4_da_writepages_trans_blocks(struct inode *inode)
|
|
|
|
{
|
2013-06-04 17:01:11 +00:00
|
|
|
int bpp = ext4_journal_blocks_per_page(inode);
|
2008-08-20 02:15:58 +00:00
|
|
|
|
2013-06-04 17:01:11 +00:00
|
|
|
return ext4_meta_trans_blocks(inode,
|
|
|
|
MAX_WRITEPAGES_EXTENT_LEN + bpp - 1, bpp);
|
2008-08-20 02:15:58 +00:00
|
|
|
}
|
2008-07-11 23:27:31 +00:00
|
|
|
|
2023-05-15 10:40:43 +00:00
|
|
|
static int ext4_journal_folio_buffers(handle_t *handle, struct folio *folio,
|
|
|
|
size_t len)
|
2023-02-28 05:13:19 +00:00
|
|
|
{
|
2023-05-15 10:40:43 +00:00
|
|
|
struct buffer_head *page_bufs = folio_buffers(folio);
|
|
|
|
struct inode *inode = folio->mapping->host;
|
2023-02-28 05:13:19 +00:00
|
|
|
int ret, err;
|
|
|
|
|
|
|
|
ret = ext4_walk_page_buffers(handle, inode, page_bufs, 0, len,
|
|
|
|
NULL, do_journal_get_write_access);
|
|
|
|
err = ext4_walk_page_buffers(handle, inode, page_bufs, 0, len,
|
|
|
|
NULL, write_end_fn);
|
|
|
|
if (ret == 0)
|
|
|
|
ret = err;
|
2023-05-15 10:40:43 +00:00
|
|
|
err = ext4_jbd2_inode_add_write(handle, inode, folio_pos(folio), len);
|
2023-02-28 05:13:19 +00:00
|
|
|
if (ret == 0)
|
|
|
|
ret = err;
|
|
|
|
EXT4_I(inode)->i_datasync_tid = handle->h_transaction->t_tid;
|
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int mpage_journal_page_buffers(handle_t *handle,
|
|
|
|
struct mpage_da_data *mpd,
|
2023-05-15 10:40:43 +00:00
|
|
|
struct folio *folio)
|
2023-02-28 05:13:19 +00:00
|
|
|
{
|
|
|
|
struct inode *inode = mpd->inode;
|
|
|
|
loff_t size = i_size_read(inode);
|
2023-05-15 10:40:43 +00:00
|
|
|
size_t len = folio_size(folio);
|
2023-02-28 05:13:19 +00:00
|
|
|
|
2023-05-15 10:40:43 +00:00
|
|
|
folio_clear_checked(folio);
|
2023-02-28 05:13:19 +00:00
|
|
|
mpd->wbc->nr_to_write--;
|
|
|
|
|
2023-05-15 10:40:43 +00:00
|
|
|
if (folio_pos(folio) + len > size &&
|
2023-02-28 05:13:19 +00:00
|
|
|
!ext4_verity_in_progress(inode))
|
2024-02-29 06:10:13 +00:00
|
|
|
len = size & (len - 1);
|
2023-02-28 05:13:19 +00:00
|
|
|
|
2023-05-15 10:40:43 +00:00
|
|
|
return ext4_journal_folio_buffers(handle, folio, len);
|
2023-02-28 05:13:19 +00:00
|
|
|
}
|
|
|
|
|
2010-05-16 22:00:00 +00:00
|
|
|
/*
|
2013-06-04 17:17:40 +00:00
|
|
|
* mpage_prepare_extent_to_map - find & lock contiguous range of dirty pages
|
2022-12-07 11:27:08 +00:00
|
|
|
* needing mapping, submit mapped pages
|
2013-06-04 17:17:40 +00:00
|
|
|
*
|
|
|
|
* @mpd - where to look for pages
|
|
|
|
*
|
|
|
|
* Walk dirty pages in the mapping. If they are fully mapped, submit them for
|
2022-12-07 11:27:08 +00:00
|
|
|
* IO immediately. If we cannot map blocks, we submit just already mapped
|
|
|
|
* buffers in the page for IO and keep page dirty. When we can map blocks and
|
|
|
|
* we find a page which isn't mapped we start accumulating extent of buffers
|
|
|
|
* underlying these pages that needs mapping (formed by either delayed or
|
|
|
|
* unwritten buffers). We also lock the pages containing these buffers. The
|
|
|
|
* extent found is returned in @mpd structure (starting at mpd->lblk with
|
|
|
|
* length mpd->len blocks).
|
2013-06-04 17:17:40 +00:00
|
|
|
*
|
|
|
|
* Note that this function can attach bios to one io_end structure which are
|
|
|
|
* neither logically nor physically contiguous. Although it may seem as an
|
|
|
|
* unnecessary complication, it is actually inevitable in blocksize < pagesize
|
|
|
|
* case as we need to track IO to all buffers underlying a page in one io_end.
|
2010-05-16 22:00:00 +00:00
|
|
|
*/
|
2013-06-04 17:17:40 +00:00
|
|
|
static int mpage_prepare_extent_to_map(struct mpage_da_data *mpd)
|
2010-05-16 22:00:00 +00:00
|
|
|
{
|
2013-06-04 17:17:40 +00:00
|
|
|
struct address_space *mapping = mpd->inode->i_mapping;
|
2023-01-04 21:14:35 +00:00
|
|
|
struct folio_batch fbatch;
|
|
|
|
unsigned int nr_folios;
|
2013-06-04 17:17:40 +00:00
|
|
|
pgoff_t index = mpd->first_page;
|
|
|
|
pgoff_t end = mpd->last_page;
|
2017-12-05 22:30:38 +00:00
|
|
|
xa_mark_t tag;
|
2013-06-04 17:17:40 +00:00
|
|
|
int i, err = 0;
|
|
|
|
int blkbits = mpd->inode->i_blkbits;
|
|
|
|
ext4_lblk_t lblk;
|
|
|
|
struct buffer_head *head;
|
2023-02-28 05:13:19 +00:00
|
|
|
handle_t *handle = NULL;
|
|
|
|
int bpp = ext4_journal_blocks_per_page(mpd->inode);
|
2010-05-16 22:00:00 +00:00
|
|
|
|
2013-06-04 17:17:40 +00:00
|
|
|
if (mpd->wbc->sync_mode == WB_SYNC_ALL || mpd->wbc->tagged_writepages)
|
ext4: implement writeback livelock avoidance using page tagging
This is analogous to Jan Kara's commit,
f446daaea9d4a420d16c606f755f3689dcb2d0ce
mm: implement writeback livelock avoidance using page tagging
but since we forked write_cache_pages, we need to reimplement
it there (and in ext4_da_writepages, since range_cyclic handling
was moved to there)
If you start a large buffered IO to a file, and then set
fsync after it, you'll find that fsync does not complete
until the other IO stops.
If you continue re-dirtying the file (say, putting dd
with conv=notrunc in a loop), when fsync finally completes
(after all IO is done), it reports via tracing that
it has written many more pages than the file contains;
in other words it has synced and re-synced pages in
the file multiple times.
This then leads to problems with our writeback_index
update, since it advances it by pages written, and
essentially sets writeback_index off the end of the
file...
With the following patch, we only sync as much as was
dirty at the time of the sync.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2010-10-28 01:30:13 +00:00
|
|
|
tag = PAGECACHE_TAG_TOWRITE;
|
|
|
|
else
|
|
|
|
tag = PAGECACHE_TAG_DIRTY;
|
2023-02-28 05:13:19 +00:00
|
|
|
|
2023-03-08 14:25:28 +00:00
|
|
|
mpd->map.m_len = 0;
|
|
|
|
mpd->next_page = index;
|
2023-03-29 15:49:44 +00:00
|
|
|
if (ext4_should_journal_data(mpd->inode)) {
|
2023-02-28 05:13:19 +00:00
|
|
|
handle = ext4_journal_start(mpd->inode, EXT4_HT_WRITE_PAGE,
|
|
|
|
bpp);
|
|
|
|
if (IS_ERR(handle))
|
|
|
|
return PTR_ERR(handle);
|
|
|
|
}
|
2023-01-04 21:14:35 +00:00
|
|
|
folio_batch_init(&fbatch);
|
2011-02-26 19:07:37 +00:00
|
|
|
while (index <= end) {
|
2023-01-04 21:14:35 +00:00
|
|
|
nr_folios = filemap_get_folios_tag(mapping, &index, end,
|
|
|
|
tag, &fbatch);
|
|
|
|
if (nr_folios == 0)
|
2020-05-25 08:12:15 +00:00
|
|
|
break;
|
2010-05-16 22:00:00 +00:00
|
|
|
|
2023-01-04 21:14:35 +00:00
|
|
|
for (i = 0; i < nr_folios; i++) {
|
|
|
|
struct folio *folio = fbatch.folios[i];
|
2010-05-16 22:00:00 +00:00
|
|
|
|
2013-10-17 22:56:16 +00:00
|
|
|
/*
|
|
|
|
* Accumulated enough dirty pages? This doesn't apply
|
|
|
|
* to WB_SYNC_ALL mode. For integrity sync we have to
|
|
|
|
* keep going because someone may be concurrently
|
|
|
|
* dirtying pages, and we might have synced a lot of
|
|
|
|
* newly appeared dirty pages, but have not synced all
|
|
|
|
* of the old dirty pages.
|
|
|
|
*/
|
2023-02-28 05:13:14 +00:00
|
|
|
if (mpd->wbc->sync_mode == WB_SYNC_NONE &&
|
|
|
|
mpd->wbc->nr_to_write <=
|
|
|
|
mpd->map.m_len >> (PAGE_SHIFT - blkbits))
|
2013-10-17 22:56:16 +00:00
|
|
|
goto out;
|
|
|
|
|
2013-06-04 17:17:40 +00:00
|
|
|
/* If we can't merge this page, we are done. */
|
2023-01-04 21:14:35 +00:00
|
|
|
if (mpd->map.m_len > 0 && mpd->next_page != folio->index)
|
2013-06-04 17:17:40 +00:00
|
|
|
goto out;
|
2011-02-26 19:09:14 +00:00
|
|
|
|
2023-02-28 05:13:19 +00:00
|
|
|
if (handle) {
|
|
|
|
err = ext4_journal_ensure_credits(handle, bpp,
|
|
|
|
0);
|
|
|
|
if (err < 0)
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
2023-01-04 21:14:35 +00:00
|
|
|
folio_lock(folio);
|
2010-05-16 22:00:00 +00:00
|
|
|
/*
|
2013-06-04 17:17:40 +00:00
|
|
|
* If the page is no longer dirty, or its mapping no
|
|
|
|
* longer corresponds to inode we are writing (which
|
|
|
|
* means it has been truncated or invalidated), or the
|
|
|
|
* page is already under writeback and we are not doing
|
|
|
|
* a data integrity writeback, skip the page
|
2010-05-16 22:00:00 +00:00
|
|
|
*/
|
2023-01-04 21:14:35 +00:00
|
|
|
if (!folio_test_dirty(folio) ||
|
|
|
|
(folio_test_writeback(folio) &&
|
2013-06-04 17:17:40 +00:00
|
|
|
(mpd->wbc->sync_mode == WB_SYNC_NONE)) ||
|
2023-01-04 21:14:35 +00:00
|
|
|
unlikely(folio->mapping != mapping)) {
|
|
|
|
folio_unlock(folio);
|
2010-05-16 22:00:00 +00:00
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
2023-01-04 21:14:35 +00:00
|
|
|
folio_wait_writeback(folio);
|
|
|
|
BUG_ON(folio_test_writeback(folio));
|
2010-05-16 22:00:00 +00:00
|
|
|
|
2022-03-03 14:38:47 +00:00
|
|
|
/*
|
|
|
|
* Should never happen but for buggy code in
|
|
|
|
* other subsystems that call
|
|
|
|
* set_page_dirty() without properly warning
|
|
|
|
* the file system first. See [1] for more
|
|
|
|
* information.
|
|
|
|
*
|
|
|
|
* [1] https://lore.kernel.org/linux-mm/20180103100430.GE4911@quack2.suse.cz
|
|
|
|
*/
|
2023-01-04 21:14:35 +00:00
|
|
|
if (!folio_buffers(folio)) {
|
|
|
|
ext4_warning_inode(mpd->inode, "page %lu does not have buffers attached", folio->index);
|
|
|
|
folio_clear_dirty(folio);
|
|
|
|
folio_unlock(folio);
|
2022-03-03 14:38:47 +00:00
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
2013-06-04 17:17:40 +00:00
|
|
|
if (mpd->map.m_len == 0)
|
2023-01-04 21:14:35 +00:00
|
|
|
mpd->first_page = folio->index;
|
2023-06-27 17:43:49 +00:00
|
|
|
mpd->next_page = folio_next_index(folio);
|
2022-12-07 11:27:08 +00:00
|
|
|
/*
|
2023-02-28 05:13:19 +00:00
|
|
|
* Writeout when we cannot modify metadata is simple.
|
|
|
|
* Just submit the page. For data=journal mode we
|
|
|
|
* first handle writeout of the page for checkpoint and
|
|
|
|
* only after that handle delayed page dirtying. This
|
2023-03-29 15:49:43 +00:00
|
|
|
* makes sure current data is checkpointed to the final
|
|
|
|
* location before possibly journalling it again which
|
|
|
|
* is desirable when the page is frequently dirtied
|
|
|
|
* through a pin.
|
2022-12-07 11:27:08 +00:00
|
|
|
*/
|
|
|
|
if (!mpd->can_map) {
|
2023-03-29 15:49:35 +00:00
|
|
|
err = mpage_submit_folio(mpd, folio);
|
|
|
|
if (err < 0)
|
|
|
|
goto out;
|
2023-02-28 05:13:19 +00:00
|
|
|
/* Pending dirtying of journalled data? */
|
2023-03-24 18:01:06 +00:00
|
|
|
if (folio_test_checked(folio)) {
|
2023-02-28 05:13:19 +00:00
|
|
|
err = mpage_journal_page_buffers(handle,
|
2023-05-15 10:40:43 +00:00
|
|
|
mpd, folio);
|
2023-02-28 05:13:19 +00:00
|
|
|
if (err < 0)
|
|
|
|
goto out;
|
2023-03-29 15:49:36 +00:00
|
|
|
mpd->journalled_more_data = 1;
|
2023-02-28 05:13:19 +00:00
|
|
|
}
|
2023-03-24 18:01:07 +00:00
|
|
|
mpage_folio_done(mpd, folio);
|
2022-12-07 11:27:08 +00:00
|
|
|
} else {
|
|
|
|
/* Add all dirty buffers to mpd */
|
2023-01-04 21:14:35 +00:00
|
|
|
lblk = ((ext4_lblk_t)folio->index) <<
|
2022-12-07 11:27:08 +00:00
|
|
|
(PAGE_SHIFT - blkbits);
|
2023-01-04 21:14:35 +00:00
|
|
|
head = folio_buffers(folio);
|
2022-12-07 11:27:08 +00:00
|
|
|
err = mpage_process_page_bufs(mpd, head, head,
|
2023-01-04 21:14:35 +00:00
|
|
|
lblk);
|
2022-12-07 11:27:08 +00:00
|
|
|
if (err <= 0)
|
|
|
|
goto out;
|
|
|
|
err = 0;
|
|
|
|
}
|
2010-05-16 22:00:00 +00:00
|
|
|
}
|
2023-01-04 21:14:35 +00:00
|
|
|
folio_batch_release(&fbatch);
|
2010-05-16 22:00:00 +00:00
|
|
|
cond_resched();
|
|
|
|
}
|
2020-05-25 08:12:15 +00:00
|
|
|
mpd->scanned_until_end = 1;
|
2023-02-28 05:13:19 +00:00
|
|
|
if (handle)
|
|
|
|
ext4_journal_stop(handle);
|
2011-02-26 19:07:37 +00:00
|
|
|
return 0;
|
2011-02-26 19:07:31 +00:00
|
|
|
out:
|
2023-01-04 21:14:35 +00:00
|
|
|
folio_batch_release(&fbatch);
|
2023-02-28 05:13:19 +00:00
|
|
|
if (handle)
|
|
|
|
ext4_journal_stop(handle);
|
2013-06-04 17:17:40 +00:00
|
|
|
return err;
|
2010-05-16 22:00:00 +00:00
|
|
|
}
|
|
|
|
|
2022-12-07 11:27:09 +00:00
|
|
|
static int ext4_do_writepages(struct mpage_da_data *mpd)
|
2008-07-11 23:27:31 +00:00
|
|
|
{
|
2022-12-07 11:27:09 +00:00
|
|
|
struct writeback_control *wbc = mpd->wbc;
|
2013-06-04 17:17:40 +00:00
|
|
|
pgoff_t writeback_index = 0;
|
|
|
|
long nr_to_write = wbc->nr_to_write;
|
2008-10-16 14:10:36 +00:00
|
|
|
int range_whole = 0;
|
2013-06-04 17:17:40 +00:00
|
|
|
int cycled = 1;
|
2008-07-11 23:27:31 +00:00
|
|
|
handle_t *handle = NULL;
|
2022-12-07 11:27:09 +00:00
|
|
|
struct inode *inode = mpd->inode;
|
|
|
|
struct address_space *mapping = inode->i_mapping;
|
2013-06-04 17:21:11 +00:00
|
|
|
int needed_blocks, rsv_blocks = 0, ret = 0;
|
2008-08-18 22:00:57 +00:00
|
|
|
struct ext4_sb_info *sbi = EXT4_SB(mapping->host->i_sb);
|
2011-10-18 14:55:51 +00:00
|
|
|
struct blk_plug plug;
|
2013-07-01 12:12:40 +00:00
|
|
|
bool give_up_on_write = false;
|
2008-07-11 23:27:31 +00:00
|
|
|
|
2013-06-06 18:00:46 +00:00
|
|
|
trace_ext4_writepages(inode, wbc);
|
2009-01-04 01:03:21 +00:00
|
|
|
|
2008-07-11 23:27:31 +00:00
|
|
|
/*
|
|
|
|
* No pages to write? This is mainly a kludge to avoid starting
|
|
|
|
* a transaction for special inodes like journal inode on last iput()
|
|
|
|
* because that could violate lock ordering on umount
|
|
|
|
*/
|
2008-08-20 01:55:02 +00:00
|
|
|
if (!mapping->nrpages || !mapping_tagged(mapping, PAGECACHE_TAG_DIRTY))
|
2013-10-30 11:27:16 +00:00
|
|
|
goto out_writepages;
|
2008-11-05 14:22:24 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* If the filesystem has aborted, it is read-only, so return
|
|
|
|
* right away instead of dumping stack traces later on that
|
|
|
|
* will obscure the real source of the problem. We test
|
2023-06-16 16:50:51 +00:00
|
|
|
* fs shutdown state instead of sb->s_flag's SB_RDONLY because
|
2008-11-05 14:22:24 +00:00
|
|
|
* the latter could be true if the filesystem is mounted
|
2013-06-06 18:00:46 +00:00
|
|
|
* read-only, and in that case, ext4_writepages should
|
2008-11-05 14:22:24 +00:00
|
|
|
* *never* be called, so if that ever happens, we would want
|
|
|
|
* the stack trace.
|
|
|
|
*/
|
2023-06-16 16:50:51 +00:00
|
|
|
if (unlikely(ext4_forced_shutdown(mapping->host->i_sb))) {
|
2013-10-30 11:27:16 +00:00
|
|
|
ret = -EROFS;
|
|
|
|
goto out_writepages;
|
|
|
|
}
|
2008-11-05 14:22:24 +00:00
|
|
|
|
2013-06-04 17:17:40 +00:00
|
|
|
/*
|
|
|
|
* If we have inline data and arrive here, it means that
|
|
|
|
* we will soon create the block for the 1st page, so
|
|
|
|
* we'd better clear the inline data here.
|
|
|
|
*/
|
|
|
|
if (ext4_has_inline_data(inode)) {
|
|
|
|
/* Just inode will be modified... */
|
|
|
|
handle = ext4_journal_start(inode, EXT4_HT_INODE, 1);
|
|
|
|
if (IS_ERR(handle)) {
|
|
|
|
ret = PTR_ERR(handle);
|
|
|
|
goto out_writepages;
|
|
|
|
}
|
|
|
|
BUG_ON(ext4_test_inode_state(inode,
|
|
|
|
EXT4_STATE_MAY_INLINE_DATA));
|
|
|
|
ext4_destroy_inline_data(handle, inode);
|
|
|
|
ext4_journal_stop(handle);
|
|
|
|
}
|
|
|
|
|
2023-02-28 05:13:19 +00:00
|
|
|
/*
|
|
|
|
* data=journal mode does not do delalloc so we just need to writeout /
|
2023-03-29 15:49:36 +00:00
|
|
|
* journal already mapped buffers. On the other hand we need to commit
|
|
|
|
* transaction to make data stable. We expect all the data to be
|
|
|
|
* already in the journal (the only exception are DMA pinned pages
|
|
|
|
* dirtied behind our back) so we commit transaction here and run the
|
|
|
|
* writeback loop to checkpoint them. The checkpointing is not actually
|
|
|
|
* necessary to make data persistent *but* quite a few places (extent
|
|
|
|
* shifting operations, fsverity, ...) depend on being able to drop
|
|
|
|
* pagecache pages after calling filemap_write_and_wait() and for that
|
|
|
|
* checkpointing needs to happen.
|
2023-02-28 05:13:19 +00:00
|
|
|
*/
|
2023-03-29 15:49:36 +00:00
|
|
|
if (ext4_should_journal_data(inode)) {
|
2023-02-28 05:13:19 +00:00
|
|
|
mpd->can_map = 0;
|
2023-03-29 15:49:36 +00:00
|
|
|
if (wbc->sync_mode == WB_SYNC_ALL)
|
|
|
|
ext4_fc_commit(sbi->s_journal,
|
|
|
|
EXT4_I(inode)->i_datasync_tid);
|
|
|
|
}
|
|
|
|
mpd->journalled_more_data = 0;
|
2023-02-28 05:13:19 +00:00
|
|
|
|
2019-08-11 20:27:41 +00:00
|
|
|
if (ext4_should_dioread_nolock(inode)) {
|
|
|
|
/*
|
|
|
|
* We may need to convert up to one extent per block in
|
|
|
|
* the page and we may dirty the inode.
|
|
|
|
*/
|
|
|
|
rsv_blocks = 1 + ext4_chunk_trans_blocks(inode,
|
|
|
|
PAGE_SIZE >> inode->i_blkbits);
|
|
|
|
}
|
|
|
|
|
2008-10-16 14:10:36 +00:00
|
|
|
if (wbc->range_start == 0 && wbc->range_end == LLONG_MAX)
|
|
|
|
range_whole = 1;
|
2008-07-11 23:27:31 +00:00
|
|
|
|
2009-02-14 15:42:58 +00:00
|
|
|
if (wbc->range_cyclic) {
|
2013-06-04 17:17:40 +00:00
|
|
|
writeback_index = mapping->writeback_index;
|
|
|
|
if (writeback_index)
|
2009-02-14 15:42:58 +00:00
|
|
|
cycled = 0;
|
2022-12-07 11:27:09 +00:00
|
|
|
mpd->first_page = writeback_index;
|
|
|
|
mpd->last_page = -1;
|
ext4: implement writeback livelock avoidance using page tagging
This is analogous to Jan Kara's commit,
f446daaea9d4a420d16c606f755f3689dcb2d0ce
mm: implement writeback livelock avoidance using page tagging
but since we forked write_cache_pages, we need to reimplement
it there (and in ext4_da_writepages, since range_cyclic handling
was moved to there)
If you start a large buffered IO to a file, and then set
fsync after it, you'll find that fsync does not complete
until the other IO stops.
If you continue re-dirtying the file (say, putting dd
with conv=notrunc in a loop), when fsync finally completes
(after all IO is done), it reports via tracing that
it has written many more pages than the file contains;
in other words it has synced and re-synced pages in
the file multiple times.
This then leads to problems with our writeback_index
update, since it advances it by pages written, and
essentially sets writeback_index off the end of the
file...
With the following patch, we only sync as much as was
dirty at the time of the sync.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2010-10-28 01:30:13 +00:00
|
|
|
} else {
|
2022-12-07 11:27:09 +00:00
|
|
|
mpd->first_page = wbc->range_start >> PAGE_SHIFT;
|
|
|
|
mpd->last_page = wbc->range_end >> PAGE_SHIFT;
|
ext4: implement writeback livelock avoidance using page tagging
This is analogous to Jan Kara's commit,
f446daaea9d4a420d16c606f755f3689dcb2d0ce
mm: implement writeback livelock avoidance using page tagging
but since we forked write_cache_pages, we need to reimplement
it there (and in ext4_da_writepages, since range_cyclic handling
was moved to there)
If you start a large buffered IO to a file, and then set
fsync after it, you'll find that fsync does not complete
until the other IO stops.
If you continue re-dirtying the file (say, putting dd
with conv=notrunc in a loop), when fsync finally completes
(after all IO is done), it reports via tracing that
it has written many more pages than the file contains;
in other words it has synced and re-synced pages in
the file multiple times.
This then leads to problems with our writeback_index
update, since it advances it by pages written, and
essentially sets writeback_index off the end of the
file...
With the following patch, we only sync as much as was
dirty at the time of the sync.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2010-10-28 01:30:13 +00:00
|
|
|
}
|
2008-08-20 01:55:02 +00:00
|
|
|
|
2022-12-07 11:27:09 +00:00
|
|
|
ext4_io_submit_init(&mpd->io_submit, wbc);
|
2009-02-14 15:42:58 +00:00
|
|
|
retry:
|
2010-06-06 16:38:15 +00:00
|
|
|
if (wbc->sync_mode == WB_SYNC_ALL || wbc->tagged_writepages)
|
2022-12-07 11:27:09 +00:00
|
|
|
tag_pages_for_writeback(mapping, mpd->first_page,
|
|
|
|
mpd->last_page);
|
2011-10-18 14:55:51 +00:00
|
|
|
blk_start_plug(&plug);
|
ext4: avoid unnecessary transaction stalls during writeback
Currently ext4_writepages() submits all pages with transaction started.
When no page needs block allocation or extent conversion we can submit
all dirty pages in the inode while holding a single transaction handle
and when device is congested this can take significant amount of time.
Thus ext4_writepages() can block transaction commits for extended
periods of time.
Take for example a simple benchmark simulating PostgreSQL database
(pgioperf in mmtest). The benchmark runs 16 processes doing random reads
from a huge file, one process doing random writes to the huge file, and
one process doing sequential writes to a small files and frequently
running fsync. With unpatched kernel transaction commits take on average
~18s with standard deviation of ~41s, top 5 commit times are:
274.466639s, 126.467347s, 86.992429s, 34.351563s, 31.517653s.
After this patch transaction commits take on average 0.1s with standard
deviation of 0.15s, top 5 commit times are:
0.563792s, 0.519980s, 0.509841s, 0.471700s, 0.469899s
[ Modified so we use an explicit do_map flag instead of relying on
io_end not being allocated, the since io_end->inode is needed for I/O
error handling. -- tytso ]
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
2017-04-30 22:29:10 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* First writeback pages that don't need mapping - we can avoid
|
|
|
|
* starting a transaction unnecessarily and also avoid being blocked
|
|
|
|
* in the block layer on device congestion while having transaction
|
|
|
|
* started.
|
|
|
|
*/
|
2022-12-07 11:27:09 +00:00
|
|
|
mpd->do_map = 0;
|
|
|
|
mpd->scanned_until_end = 0;
|
|
|
|
mpd->io_submit.io_end = ext4_init_io_end(inode, GFP_KERNEL);
|
|
|
|
if (!mpd->io_submit.io_end) {
|
ext4: avoid unnecessary transaction stalls during writeback
Currently ext4_writepages() submits all pages with transaction started.
When no page needs block allocation or extent conversion we can submit
all dirty pages in the inode while holding a single transaction handle
and when device is congested this can take significant amount of time.
Thus ext4_writepages() can block transaction commits for extended
periods of time.
Take for example a simple benchmark simulating PostgreSQL database
(pgioperf in mmtest). The benchmark runs 16 processes doing random reads
from a huge file, one process doing random writes to the huge file, and
one process doing sequential writes to a small files and frequently
running fsync. With unpatched kernel transaction commits take on average
~18s with standard deviation of ~41s, top 5 commit times are:
274.466639s, 126.467347s, 86.992429s, 34.351563s, 31.517653s.
After this patch transaction commits take on average 0.1s with standard
deviation of 0.15s, top 5 commit times are:
0.563792s, 0.519980s, 0.509841s, 0.471700s, 0.469899s
[ Modified so we use an explicit do_map flag instead of relying on
io_end not being allocated, the since io_end->inode is needed for I/O
error handling. -- tytso ]
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
2017-04-30 22:29:10 +00:00
|
|
|
ret = -ENOMEM;
|
|
|
|
goto unplug;
|
|
|
|
}
|
2022-12-07 11:27:09 +00:00
|
|
|
ret = mpage_prepare_extent_to_map(mpd);
|
ext4: unlock unused_pages timely when doing writeback
In mpage_add_bh_to_extent(), when accumulated extents length is greater
than MAX_WRITEPAGES_EXTENT_LEN or buffer head's b_stat is not equal, we
will not continue to search unmapped area for this page, but note this
page is locked, and will only be unlocked in mpage_release_unused_pages()
after ext4_io_submit, if io also is throttled by blk-throttle or similar
io qos, we will hold this page locked for a while, it's unnecessary.
I think the best fix is to refactor mpage_add_bh_to_extent() to let it
return some hints whether to unlock this page, but given that we will
improve dioread_nolock later, we can let it done later, so currently
the simple fix would just call mpage_release_unused_pages() before
ext4_io_submit().
Signed-off-by: Xiaoguang Wang <xiaoguang.wang@linux.alibaba.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
2019-02-11 04:53:21 +00:00
|
|
|
/* Unlock pages we didn't use */
|
2022-12-07 11:27:09 +00:00
|
|
|
mpage_release_unused_pages(mpd, false);
|
ext4: avoid unnecessary transaction stalls during writeback
Currently ext4_writepages() submits all pages with transaction started.
When no page needs block allocation or extent conversion we can submit
all dirty pages in the inode while holding a single transaction handle
and when device is congested this can take significant amount of time.
Thus ext4_writepages() can block transaction commits for extended
periods of time.
Take for example a simple benchmark simulating PostgreSQL database
(pgioperf in mmtest). The benchmark runs 16 processes doing random reads
from a huge file, one process doing random writes to the huge file, and
one process doing sequential writes to a small files and frequently
running fsync. With unpatched kernel transaction commits take on average
~18s with standard deviation of ~41s, top 5 commit times are:
274.466639s, 126.467347s, 86.992429s, 34.351563s, 31.517653s.
After this patch transaction commits take on average 0.1s with standard
deviation of 0.15s, top 5 commit times are:
0.563792s, 0.519980s, 0.509841s, 0.471700s, 0.469899s
[ Modified so we use an explicit do_map flag instead of relying on
io_end not being allocated, the since io_end->inode is needed for I/O
error handling. -- tytso ]
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
2017-04-30 22:29:10 +00:00
|
|
|
/* Submit prepared bio */
|
2022-12-07 11:27:09 +00:00
|
|
|
ext4_io_submit(&mpd->io_submit);
|
|
|
|
ext4_put_io_end_defer(mpd->io_submit.io_end);
|
|
|
|
mpd->io_submit.io_end = NULL;
|
ext4: avoid unnecessary transaction stalls during writeback
Currently ext4_writepages() submits all pages with transaction started.
When no page needs block allocation or extent conversion we can submit
all dirty pages in the inode while holding a single transaction handle
and when device is congested this can take significant amount of time.
Thus ext4_writepages() can block transaction commits for extended
periods of time.
Take for example a simple benchmark simulating PostgreSQL database
(pgioperf in mmtest). The benchmark runs 16 processes doing random reads
from a huge file, one process doing random writes to the huge file, and
one process doing sequential writes to a small files and frequently
running fsync. With unpatched kernel transaction commits take on average
~18s with standard deviation of ~41s, top 5 commit times are:
274.466639s, 126.467347s, 86.992429s, 34.351563s, 31.517653s.
After this patch transaction commits take on average 0.1s with standard
deviation of 0.15s, top 5 commit times are:
0.563792s, 0.519980s, 0.509841s, 0.471700s, 0.469899s
[ Modified so we use an explicit do_map flag instead of relying on
io_end not being allocated, the since io_end->inode is needed for I/O
error handling. -- tytso ]
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
2017-04-30 22:29:10 +00:00
|
|
|
if (ret < 0)
|
|
|
|
goto unplug;
|
|
|
|
|
2022-12-07 11:27:09 +00:00
|
|
|
while (!mpd->scanned_until_end && wbc->nr_to_write > 0) {
|
2013-06-04 17:17:40 +00:00
|
|
|
/* For each extent of pages we use new io_end */
|
2022-12-07 11:27:09 +00:00
|
|
|
mpd->io_submit.io_end = ext4_init_io_end(inode, GFP_KERNEL);
|
|
|
|
if (!mpd->io_submit.io_end) {
|
2013-06-04 17:17:40 +00:00
|
|
|
ret = -ENOMEM;
|
|
|
|
break;
|
|
|
|
}
|
2008-08-20 01:55:02 +00:00
|
|
|
|
2022-12-07 11:27:08 +00:00
|
|
|
WARN_ON_ONCE(!mpd->can_map);
|
2008-08-20 01:55:02 +00:00
|
|
|
/*
|
2013-06-04 17:17:40 +00:00
|
|
|
* We have two constraints: We find one extent to map and we
|
|
|
|
* must always write out whole page (makes a difference when
|
|
|
|
* blocksize < pagesize) so that we don't block on IO when we
|
|
|
|
* try to write out the rest of the page. Journalled mode is
|
|
|
|
* not supported by delalloc.
|
2008-08-20 01:55:02 +00:00
|
|
|
*/
|
|
|
|
BUG_ON(ext4_should_journal_data(inode));
|
2008-08-20 02:15:58 +00:00
|
|
|
needed_blocks = ext4_da_writepages_trans_blocks(inode);
|
2008-08-20 01:55:02 +00:00
|
|
|
|
2013-06-04 17:17:40 +00:00
|
|
|
/* start a new transaction */
|
2013-06-04 17:21:11 +00:00
|
|
|
handle = ext4_journal_start_with_reserve(inode,
|
|
|
|
EXT4_HT_WRITE_PAGE, needed_blocks, rsv_blocks);
|
2008-07-11 23:27:31 +00:00
|
|
|
if (IS_ERR(handle)) {
|
|
|
|
ret = PTR_ERR(handle);
|
2009-09-26 21:43:59 +00:00
|
|
|
ext4_msg(inode->i_sb, KERN_CRIT, "%s: jbd2_start: "
|
2010-05-16 17:00:00 +00:00
|
|
|
"%ld pages, ino %lu; err %d", __func__,
|
2008-08-20 01:55:02 +00:00
|
|
|
wbc->nr_to_write, inode->i_ino, ret);
|
2013-06-04 17:17:40 +00:00
|
|
|
/* Release allocated io_end */
|
2022-12-07 11:27:09 +00:00
|
|
|
ext4_put_io_end(mpd->io_submit.io_end);
|
|
|
|
mpd->io_submit.io_end = NULL;
|
2013-06-04 17:17:40 +00:00
|
|
|
break;
|
2008-07-11 23:27:31 +00:00
|
|
|
}
|
2022-12-07 11:27:09 +00:00
|
|
|
mpd->do_map = 1;
|
2009-02-23 21:42:39 +00:00
|
|
|
|
2022-12-07 11:27:09 +00:00
|
|
|
trace_ext4_da_write_pages(inode, mpd->first_page, wbc);
|
|
|
|
ret = mpage_prepare_extent_to_map(mpd);
|
|
|
|
if (!ret && mpd->map.m_len)
|
|
|
|
ret = mpage_map_and_submit_extent(handle, mpd,
|
2013-07-01 12:12:40 +00:00
|
|
|
&give_up_on_write);
|
2016-07-04 14:14:01 +00:00
|
|
|
/*
|
|
|
|
* Caution: If the handle is synchronous,
|
|
|
|
* ext4_journal_stop() can wait for transaction commit
|
|
|
|
* to finish which may depend on writeback of pages to
|
|
|
|
* complete or on page lock to be released. In that
|
2020-08-05 02:48:50 +00:00
|
|
|
* case, we have to wait until after we have
|
2016-07-04 14:14:01 +00:00
|
|
|
* submitted all the IO, released page locks we hold,
|
|
|
|
* and dropped io_end reference (for extent conversion
|
|
|
|
* to be able to complete) before stopping the handle.
|
|
|
|
*/
|
|
|
|
if (!ext4_handle_valid(handle) || handle->h_sync == 0) {
|
|
|
|
ext4_journal_stop(handle);
|
|
|
|
handle = NULL;
|
2022-12-07 11:27:09 +00:00
|
|
|
mpd->do_map = 0;
|
2016-07-04 14:14:01 +00:00
|
|
|
}
|
2013-06-04 17:17:40 +00:00
|
|
|
/* Unlock pages we didn't use */
|
2022-12-07 11:27:09 +00:00
|
|
|
mpage_release_unused_pages(mpd, give_up_on_write);
|
ext4: unlock unused_pages timely when doing writeback
In mpage_add_bh_to_extent(), when accumulated extents length is greater
than MAX_WRITEPAGES_EXTENT_LEN or buffer head's b_stat is not equal, we
will not continue to search unmapped area for this page, but note this
page is locked, and will only be unlocked in mpage_release_unused_pages()
after ext4_io_submit, if io also is throttled by blk-throttle or similar
io qos, we will hold this page locked for a while, it's unnecessary.
I think the best fix is to refactor mpage_add_bh_to_extent() to let it
return some hints whether to unlock this page, but given that we will
improve dioread_nolock later, we can let it done later, so currently
the simple fix would just call mpage_release_unused_pages() before
ext4_io_submit().
Signed-off-by: Xiaoguang Wang <xiaoguang.wang@linux.alibaba.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
2019-02-11 04:53:21 +00:00
|
|
|
/* Submit prepared bio */
|
2022-12-07 11:27:09 +00:00
|
|
|
ext4_io_submit(&mpd->io_submit);
|
ext4: unlock unused_pages timely when doing writeback
In mpage_add_bh_to_extent(), when accumulated extents length is greater
than MAX_WRITEPAGES_EXTENT_LEN or buffer head's b_stat is not equal, we
will not continue to search unmapped area for this page, but note this
page is locked, and will only be unlocked in mpage_release_unused_pages()
after ext4_io_submit, if io also is throttled by blk-throttle or similar
io qos, we will hold this page locked for a while, it's unnecessary.
I think the best fix is to refactor mpage_add_bh_to_extent() to let it
return some hints whether to unlock this page, but given that we will
improve dioread_nolock later, we can let it done later, so currently
the simple fix would just call mpage_release_unused_pages() before
ext4_io_submit().
Signed-off-by: Xiaoguang Wang <xiaoguang.wang@linux.alibaba.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
2019-02-11 04:53:21 +00:00
|
|
|
|
2016-07-04 14:14:01 +00:00
|
|
|
/*
|
|
|
|
* Drop our io_end reference we got from init. We have
|
|
|
|
* to be careful and use deferred io_end finishing if
|
|
|
|
* we are still holding the transaction as we can
|
|
|
|
* release the last reference to io_end which may end
|
|
|
|
* up doing unwritten extent conversion.
|
|
|
|
*/
|
|
|
|
if (handle) {
|
2022-12-07 11:27:09 +00:00
|
|
|
ext4_put_io_end_defer(mpd->io_submit.io_end);
|
2016-07-04 14:14:01 +00:00
|
|
|
ext4_journal_stop(handle);
|
|
|
|
} else
|
2022-12-07 11:27:09 +00:00
|
|
|
ext4_put_io_end(mpd->io_submit.io_end);
|
|
|
|
mpd->io_submit.io_end = NULL;
|
2013-06-04 17:17:40 +00:00
|
|
|
|
|
|
|
if (ret == -ENOSPC && sbi->s_journal) {
|
|
|
|
/*
|
|
|
|
* Commit the transaction which would
|
2008-10-16 14:10:36 +00:00
|
|
|
* free blocks released in the transaction
|
|
|
|
* and try again
|
|
|
|
*/
|
2008-09-09 03:05:34 +00:00
|
|
|
jbd2_journal_force_commit_nested(sbi->s_journal);
|
2008-10-16 14:10:36 +00:00
|
|
|
ret = 0;
|
2013-06-04 17:17:40 +00:00
|
|
|
continue;
|
|
|
|
}
|
|
|
|
/* Fatal error - ENOMEM, EIO... */
|
|
|
|
if (ret)
|
2008-07-11 23:27:31 +00:00
|
|
|
break;
|
2008-08-20 01:55:02 +00:00
|
|
|
}
|
ext4: avoid unnecessary transaction stalls during writeback
Currently ext4_writepages() submits all pages with transaction started.
When no page needs block allocation or extent conversion we can submit
all dirty pages in the inode while holding a single transaction handle
and when device is congested this can take significant amount of time.
Thus ext4_writepages() can block transaction commits for extended
periods of time.
Take for example a simple benchmark simulating PostgreSQL database
(pgioperf in mmtest). The benchmark runs 16 processes doing random reads
from a huge file, one process doing random writes to the huge file, and
one process doing sequential writes to a small files and frequently
running fsync. With unpatched kernel transaction commits take on average
~18s with standard deviation of ~41s, top 5 commit times are:
274.466639s, 126.467347s, 86.992429s, 34.351563s, 31.517653s.
After this patch transaction commits take on average 0.1s with standard
deviation of 0.15s, top 5 commit times are:
0.563792s, 0.519980s, 0.509841s, 0.471700s, 0.469899s
[ Modified so we use an explicit do_map flag instead of relying on
io_end not being allocated, the since io_end->inode is needed for I/O
error handling. -- tytso ]
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
2017-04-30 22:29:10 +00:00
|
|
|
unplug:
|
2011-10-18 14:55:51 +00:00
|
|
|
blk_finish_plug(&plug);
|
2013-09-16 12:24:26 +00:00
|
|
|
if (!ret && !cycled && wbc->nr_to_write > 0) {
|
2009-02-14 15:42:58 +00:00
|
|
|
cycled = 1;
|
2022-12-07 11:27:09 +00:00
|
|
|
mpd->last_page = writeback_index - 1;
|
|
|
|
mpd->first_page = 0;
|
2009-02-14 15:42:58 +00:00
|
|
|
goto retry;
|
|
|
|
}
|
2008-10-16 14:10:36 +00:00
|
|
|
|
|
|
|
/* Update index */
|
|
|
|
if (wbc->range_cyclic || (range_whole && wbc->nr_to_write > 0))
|
|
|
|
/*
|
2013-06-04 17:17:40 +00:00
|
|
|
* Set the writeback_index so that range_cyclic
|
2008-10-16 14:10:36 +00:00
|
|
|
* mode will write it back later
|
|
|
|
*/
|
2022-12-07 11:27:09 +00:00
|
|
|
mapping->writeback_index = mpd->first_page;
|
2008-08-20 01:55:02 +00:00
|
|
|
|
2008-07-11 23:27:31 +00:00
|
|
|
out_writepages:
|
2013-06-06 18:00:46 +00:00
|
|
|
trace_ext4_writepages_result(inode, wbc, ret,
|
|
|
|
nr_to_write - wbc->nr_to_write);
|
2008-07-11 23:27:31 +00:00
|
|
|
return ret;
|
2008-07-11 23:27:31 +00:00
|
|
|
}
|
|
|
|
|
2022-12-07 11:27:09 +00:00
|
|
|
static int ext4_writepages(struct address_space *mapping,
|
|
|
|
struct writeback_control *wbc)
|
|
|
|
{
|
2022-12-07 11:27:10 +00:00
|
|
|
struct super_block *sb = mapping->host->i_sb;
|
2022-12-07 11:27:09 +00:00
|
|
|
struct mpage_da_data mpd = {
|
|
|
|
.inode = mapping->host,
|
|
|
|
.wbc = wbc,
|
|
|
|
.can_map = 1,
|
|
|
|
};
|
2022-12-07 11:27:10 +00:00
|
|
|
int ret;
|
2023-05-04 12:47:23 +00:00
|
|
|
int alloc_ctx;
|
2022-12-07 11:27:10 +00:00
|
|
|
|
2023-06-16 16:50:49 +00:00
|
|
|
if (unlikely(ext4_forced_shutdown(sb)))
|
2022-12-07 11:27:10 +00:00
|
|
|
return -EIO;
|
2022-12-07 11:27:09 +00:00
|
|
|
|
2023-05-04 12:47:23 +00:00
|
|
|
alloc_ctx = ext4_writepages_down_read(sb);
|
2022-12-07 11:27:10 +00:00
|
|
|
ret = ext4_do_writepages(&mpd);
|
2023-03-29 15:49:36 +00:00
|
|
|
/*
|
|
|
|
* For data=journal writeback we could have come across pages marked
|
|
|
|
* for delayed dirtying (PageChecked) which were just added to the
|
|
|
|
* running transaction. Try once more to get them to stable storage.
|
|
|
|
*/
|
|
|
|
if (!ret && mpd.journalled_more_data)
|
|
|
|
ret = ext4_do_writepages(&mpd);
|
2023-05-04 12:47:23 +00:00
|
|
|
ext4_writepages_up_read(sb, alloc_ctx);
|
2022-12-07 11:27:10 +00:00
|
|
|
|
|
|
|
return ret;
|
2022-12-07 11:27:09 +00:00
|
|
|
}
|
|
|
|
|
2022-12-07 11:27:11 +00:00
|
|
|
int ext4_normal_submit_inode_data_buffers(struct jbd2_inode *jinode)
|
|
|
|
{
|
|
|
|
struct writeback_control wbc = {
|
|
|
|
.sync_mode = WB_SYNC_ALL,
|
|
|
|
.nr_to_write = LONG_MAX,
|
|
|
|
.range_start = jinode->i_dirty_start,
|
|
|
|
.range_end = jinode->i_dirty_end,
|
|
|
|
};
|
|
|
|
struct mpage_da_data mpd = {
|
|
|
|
.inode = jinode->i_vfs_inode,
|
|
|
|
.wbc = &wbc,
|
|
|
|
.can_map = 0,
|
|
|
|
};
|
|
|
|
return ext4_do_writepages(&mpd);
|
|
|
|
}
|
|
|
|
|
2017-12-21 20:25:11 +00:00
|
|
|
static int ext4_dax_writepages(struct address_space *mapping,
|
|
|
|
struct writeback_control *wbc)
|
|
|
|
{
|
|
|
|
int ret;
|
|
|
|
long nr_to_write = wbc->nr_to_write;
|
|
|
|
struct inode *inode = mapping->host;
|
2023-05-04 12:47:23 +00:00
|
|
|
int alloc_ctx;
|
2017-12-21 20:25:11 +00:00
|
|
|
|
2023-06-16 16:50:49 +00:00
|
|
|
if (unlikely(ext4_forced_shutdown(inode->i_sb)))
|
2017-12-21 20:25:11 +00:00
|
|
|
return -EIO;
|
|
|
|
|
2023-05-04 12:47:23 +00:00
|
|
|
alloc_ctx = ext4_writepages_down_read(inode->i_sb);
|
2017-12-21 20:25:11 +00:00
|
|
|
trace_ext4_writepages(inode, wbc);
|
|
|
|
|
2023-06-16 16:50:49 +00:00
|
|
|
ret = dax_writeback_mapping_range(mapping,
|
|
|
|
EXT4_SB(inode->i_sb)->s_daxdev, wbc);
|
2017-12-21 20:25:11 +00:00
|
|
|
trace_ext4_writepages_result(inode, wbc, ret,
|
|
|
|
nr_to_write - wbc->nr_to_write);
|
2023-05-04 12:47:23 +00:00
|
|
|
ext4_writepages_up_read(inode->i_sb, alloc_ctx);
|
2017-12-21 20:25:11 +00:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2008-10-09 03:13:30 +00:00
|
|
|
static int ext4_nonda_switch(struct super_block *sb)
|
|
|
|
{
|
2013-04-09 13:27:31 +00:00
|
|
|
s64 free_clusters, dirty_clusters;
|
2008-10-09 03:13:30 +00:00
|
|
|
struct ext4_sb_info *sbi = EXT4_SB(sb);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* switch to non delalloc mode if we are running low
|
|
|
|
* on free block. The free block accounting via percpu
|
2009-01-06 22:41:04 +00:00
|
|
|
* counters can get slightly wrong with percpu_counter_batch getting
|
2008-10-09 03:13:30 +00:00
|
|
|
* accumulated on each CPU without updating global counters
|
|
|
|
* Delalloc need an accurate free block accounting. So switch
|
|
|
|
* to non delalloc when we are near to error range.
|
|
|
|
*/
|
2013-04-09 13:27:31 +00:00
|
|
|
free_clusters =
|
|
|
|
percpu_counter_read_positive(&sbi->s_freeclusters_counter);
|
|
|
|
dirty_clusters =
|
|
|
|
percpu_counter_read_positive(&sbi->s_dirtyclusters_counter);
|
ext4: fix potential deadlock in ext4_nonda_switch()
In ext4_nonda_switch(), if the file system is getting full we used to
call writeback_inodes_sb_if_idle(). The problem is that we can be
holding i_mutex already, and this causes a potential deadlock when
writeback_inodes_sb_if_idle() when it tries to take s_umount. (See
lockdep output below).
As it turns out we don't need need to hold s_umount; the fact that we
are in the middle of the write(2) system call will keep the superblock
pinned. Unfortunately writeback_inodes_sb() checks to make sure
s_umount is taken, and the VFS uses a different mechanism for making
sure the file system doesn't get unmounted out from under us. The
simplest way of dealing with this is to just simply grab s_umount
using a trylock, and skip kicking the writeback flusher thread in the
very unlikely case that we can't take a read lock on s_umount without
blocking.
Also, we now check the cirteria for kicking the writeback thread
before we decide to whether to fall back to non-delayed writeback, so
if there are any outstanding delayed allocation writes, we try to get
them resolved as soon as possible.
[ INFO: possible circular locking dependency detected ]
3.6.0-rc1-00042-gce894ca #367 Not tainted
-------------------------------------------------------
dd/8298 is trying to acquire lock:
(&type->s_umount_key#18){++++..}, at: [<c02277d4>] writeback_inodes_sb_if_idle+0x28/0x46
but task is already holding lock:
(&sb->s_type->i_mutex_key#8){+.+...}, at: [<c01ddcce>] generic_file_aio_write+0x5f/0xd3
which lock already depends on the new lock.
2 locks held by dd/8298:
#0: (sb_writers#2){.+.+.+}, at: [<c01ddcc5>] generic_file_aio_write+0x56/0xd3
#1: (&sb->s_type->i_mutex_key#8){+.+...}, at: [<c01ddcce>] generic_file_aio_write+0x5f/0xd3
stack backtrace:
Pid: 8298, comm: dd Not tainted 3.6.0-rc1-00042-gce894ca #367
Call Trace:
[<c015b79c>] ? console_unlock+0x345/0x372
[<c06d62a1>] print_circular_bug+0x190/0x19d
[<c019906c>] __lock_acquire+0x86d/0xb6c
[<c01999db>] ? mark_held_locks+0x5c/0x7b
[<c0199724>] lock_acquire+0x66/0xb9
[<c02277d4>] ? writeback_inodes_sb_if_idle+0x28/0x46
[<c06db935>] down_read+0x28/0x58
[<c02277d4>] ? writeback_inodes_sb_if_idle+0x28/0x46
[<c02277d4>] writeback_inodes_sb_if_idle+0x28/0x46
[<c026f3b2>] ext4_nonda_switch+0xe1/0xf4
[<c0271ece>] ext4_da_write_begin+0x27/0x193
[<c01dcdb0>] generic_file_buffered_write+0xc8/0x1bb
[<c01ddc47>] __generic_file_aio_write+0x1dd/0x205
[<c01ddce7>] generic_file_aio_write+0x78/0xd3
[<c026d336>] ext4_file_write+0x480/0x4a6
[<c0198c1d>] ? __lock_acquire+0x41e/0xb6c
[<c0180944>] ? sched_clock_cpu+0x11a/0x13e
[<c01967e9>] ? trace_hardirqs_off+0xb/0xd
[<c018099f>] ? local_clock+0x37/0x4e
[<c0209f2c>] do_sync_write+0x67/0x9d
[<c0209ec5>] ? wait_on_retry_sync_kiocb+0x44/0x44
[<c020a7b9>] vfs_write+0x7b/0xe6
[<c020a9a6>] sys_write+0x3b/0x64
[<c06dd4bd>] syscall_call+0x7/0xb
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Cc: stable@vger.kernel.org
2012-09-20 02:42:36 +00:00
|
|
|
/*
|
|
|
|
* Start pushing delalloc when 1/2 of free blocks are dirty.
|
|
|
|
*/
|
2013-04-09 13:27:31 +00:00
|
|
|
if (dirty_clusters && (free_clusters < 2 * dirty_clusters))
|
2013-01-10 05:47:57 +00:00
|
|
|
try_to_writeback_inodes_sb(sb, WB_REASON_FS_FREE_SPACE);
|
ext4: fix potential deadlock in ext4_nonda_switch()
In ext4_nonda_switch(), if the file system is getting full we used to
call writeback_inodes_sb_if_idle(). The problem is that we can be
holding i_mutex already, and this causes a potential deadlock when
writeback_inodes_sb_if_idle() when it tries to take s_umount. (See
lockdep output below).
As it turns out we don't need need to hold s_umount; the fact that we
are in the middle of the write(2) system call will keep the superblock
pinned. Unfortunately writeback_inodes_sb() checks to make sure
s_umount is taken, and the VFS uses a different mechanism for making
sure the file system doesn't get unmounted out from under us. The
simplest way of dealing with this is to just simply grab s_umount
using a trylock, and skip kicking the writeback flusher thread in the
very unlikely case that we can't take a read lock on s_umount without
blocking.
Also, we now check the cirteria for kicking the writeback thread
before we decide to whether to fall back to non-delayed writeback, so
if there are any outstanding delayed allocation writes, we try to get
them resolved as soon as possible.
[ INFO: possible circular locking dependency detected ]
3.6.0-rc1-00042-gce894ca #367 Not tainted
-------------------------------------------------------
dd/8298 is trying to acquire lock:
(&type->s_umount_key#18){++++..}, at: [<c02277d4>] writeback_inodes_sb_if_idle+0x28/0x46
but task is already holding lock:
(&sb->s_type->i_mutex_key#8){+.+...}, at: [<c01ddcce>] generic_file_aio_write+0x5f/0xd3
which lock already depends on the new lock.
2 locks held by dd/8298:
#0: (sb_writers#2){.+.+.+}, at: [<c01ddcc5>] generic_file_aio_write+0x56/0xd3
#1: (&sb->s_type->i_mutex_key#8){+.+...}, at: [<c01ddcce>] generic_file_aio_write+0x5f/0xd3
stack backtrace:
Pid: 8298, comm: dd Not tainted 3.6.0-rc1-00042-gce894ca #367
Call Trace:
[<c015b79c>] ? console_unlock+0x345/0x372
[<c06d62a1>] print_circular_bug+0x190/0x19d
[<c019906c>] __lock_acquire+0x86d/0xb6c
[<c01999db>] ? mark_held_locks+0x5c/0x7b
[<c0199724>] lock_acquire+0x66/0xb9
[<c02277d4>] ? writeback_inodes_sb_if_idle+0x28/0x46
[<c06db935>] down_read+0x28/0x58
[<c02277d4>] ? writeback_inodes_sb_if_idle+0x28/0x46
[<c02277d4>] writeback_inodes_sb_if_idle+0x28/0x46
[<c026f3b2>] ext4_nonda_switch+0xe1/0xf4
[<c0271ece>] ext4_da_write_begin+0x27/0x193
[<c01dcdb0>] generic_file_buffered_write+0xc8/0x1bb
[<c01ddc47>] __generic_file_aio_write+0x1dd/0x205
[<c01ddce7>] generic_file_aio_write+0x78/0xd3
[<c026d336>] ext4_file_write+0x480/0x4a6
[<c0198c1d>] ? __lock_acquire+0x41e/0xb6c
[<c0180944>] ? sched_clock_cpu+0x11a/0x13e
[<c01967e9>] ? trace_hardirqs_off+0xb/0xd
[<c018099f>] ? local_clock+0x37/0x4e
[<c0209f2c>] do_sync_write+0x67/0x9d
[<c0209ec5>] ? wait_on_retry_sync_kiocb+0x44/0x44
[<c020a7b9>] vfs_write+0x7b/0xe6
[<c020a9a6>] sys_write+0x3b/0x64
[<c06dd4bd>] syscall_call+0x7/0xb
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Cc: stable@vger.kernel.org
2012-09-20 02:42:36 +00:00
|
|
|
|
2013-04-09 13:27:31 +00:00
|
|
|
if (2 * free_clusters < 3 * dirty_clusters ||
|
|
|
|
free_clusters < (dirty_clusters + EXT4_FREECLUSTERS_WATERMARK)) {
|
2008-10-09 03:13:30 +00:00
|
|
|
/*
|
2009-12-23 12:58:12 +00:00
|
|
|
* free block count is less than 150% of dirty blocks
|
|
|
|
* or free blocks is less than watermark
|
2008-10-09 03:13:30 +00:00
|
|
|
*/
|
|
|
|
return 1;
|
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2008-07-11 23:27:31 +00:00
|
|
|
static int ext4_da_write_begin(struct file *file, struct address_space *mapping,
|
2022-02-22 19:31:43 +00:00
|
|
|
loff_t pos, unsigned len,
|
2024-07-15 18:24:01 +00:00
|
|
|
struct folio **foliop, void **fsdata)
|
2008-07-11 23:27:31 +00:00
|
|
|
{
|
2010-05-16 15:00:00 +00:00
|
|
|
int ret, retries = 0;
|
2023-03-24 18:01:22 +00:00
|
|
|
struct folio *folio;
|
2008-07-11 23:27:31 +00:00
|
|
|
pgoff_t index;
|
|
|
|
struct inode *inode = mapping->host;
|
|
|
|
|
2023-06-16 16:50:49 +00:00
|
|
|
if (unlikely(ext4_forced_shutdown(inode->i_sb)))
|
2017-02-05 06:28:48 +00:00
|
|
|
return -EIO;
|
|
|
|
|
mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros
PAGE_CACHE_{SIZE,SHIFT,MASK,ALIGN} macros were introduced *long* time
ago with promise that one day it will be possible to implement page
cache with bigger chunks than PAGE_SIZE.
This promise never materialized. And unlikely will.
We have many places where PAGE_CACHE_SIZE assumed to be equal to
PAGE_SIZE. And it's constant source of confusion on whether
PAGE_CACHE_* or PAGE_* constant should be used in a particular case,
especially on the border between fs and mm.
Global switching to PAGE_CACHE_SIZE != PAGE_SIZE would cause to much
breakage to be doable.
Let's stop pretending that pages in page cache are special. They are
not.
The changes are pretty straight-forward:
- <foo> << (PAGE_CACHE_SHIFT - PAGE_SHIFT) -> <foo>;
- <foo> >> (PAGE_CACHE_SHIFT - PAGE_SHIFT) -> <foo>;
- PAGE_CACHE_{SIZE,SHIFT,MASK,ALIGN} -> PAGE_{SIZE,SHIFT,MASK,ALIGN};
- page_cache_get() -> get_page();
- page_cache_release() -> put_page();
This patch contains automated changes generated with coccinelle using
script below. For some reason, coccinelle doesn't patch header files.
I've called spatch for them manually.
The only adjustment after coccinelle is revert of changes to
PAGE_CAHCE_ALIGN definition: we are going to drop it later.
There are few places in the code where coccinelle didn't reach. I'll
fix them manually in a separate patch. Comments and documentation also
will be addressed with the separate patch.
virtual patch
@@
expression E;
@@
- E << (PAGE_CACHE_SHIFT - PAGE_SHIFT)
+ E
@@
expression E;
@@
- E >> (PAGE_CACHE_SHIFT - PAGE_SHIFT)
+ E
@@
@@
- PAGE_CACHE_SHIFT
+ PAGE_SHIFT
@@
@@
- PAGE_CACHE_SIZE
+ PAGE_SIZE
@@
@@
- PAGE_CACHE_MASK
+ PAGE_MASK
@@
expression E;
@@
- PAGE_CACHE_ALIGN(E)
+ PAGE_ALIGN(E)
@@
expression E;
@@
- page_cache_get(E)
+ get_page(E)
@@
expression E;
@@
- page_cache_release(E)
+ put_page(E)
Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Acked-by: Michal Hocko <mhocko@suse.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2016-04-01 12:29:47 +00:00
|
|
|
index = pos >> PAGE_SHIFT;
|
2008-10-09 03:13:30 +00:00
|
|
|
|
2022-04-24 14:09:36 +00:00
|
|
|
if (ext4_nonda_switch(inode->i_sb) || ext4_verity_in_progress(inode)) {
|
2008-10-09 03:13:30 +00:00
|
|
|
*fsdata = (void *)FALL_BACK_TO_NONDELALLOC;
|
|
|
|
return ext4_write_begin(file, mapping, pos,
|
2024-07-15 18:24:01 +00:00
|
|
|
len, foliop, fsdata);
|
2008-10-09 03:13:30 +00:00
|
|
|
}
|
|
|
|
*fsdata = (void *)0;
|
2022-02-22 19:31:43 +00:00
|
|
|
trace_ext4_da_write_begin(inode, pos, len);
|
2012-12-10 19:05:57 +00:00
|
|
|
|
|
|
|
if (ext4_test_inode_state(inode, EXT4_STATE_MAY_INLINE_DATA)) {
|
2022-02-22 15:36:28 +00:00
|
|
|
ret = ext4_da_write_inline_data_begin(mapping, inode, pos, len,
|
2024-07-15 18:24:01 +00:00
|
|
|
foliop, fsdata);
|
2012-12-10 19:05:57 +00:00
|
|
|
if (ret < 0)
|
2013-02-09 14:24:14 +00:00
|
|
|
return ret;
|
|
|
|
if (ret == 1)
|
|
|
|
return 0;
|
2012-12-10 19:05:57 +00:00
|
|
|
}
|
|
|
|
|
2021-07-16 12:20:24 +00:00
|
|
|
retry:
|
2023-03-24 18:01:22 +00:00
|
|
|
folio = __filemap_get_folio(mapping, index, FGP_WRITEBEGIN,
|
|
|
|
mapping_gfp_mask(mapping));
|
- Nick Piggin's "shoot lazy tlbs" series, to improve the peformance of
switching from a user process to a kernel thread.
- More folio conversions from Kefeng Wang, Zhang Peng and Pankaj Raghav.
- zsmalloc performance improvements from Sergey Senozhatsky.
- Yue Zhao has found and fixed some data race issues around the
alteration of memcg userspace tunables.
- VFS rationalizations from Christoph Hellwig:
- removal of most of the callers of write_one_page().
- make __filemap_get_folio()'s return value more useful
- Luis Chamberlain has changed tmpfs so it no longer requires swap
backing. Use `mount -o noswap'.
- Qi Zheng has made the slab shrinkers operate locklessly, providing
some scalability benefits.
- Keith Busch has improved dmapool's performance, making part of its
operations O(1) rather than O(n).
- Peter Xu adds the UFFD_FEATURE_WP_UNPOPULATED feature to userfaultd,
permitting userspace to wr-protect anon memory unpopulated ptes.
- Kirill Shutemov has changed MAX_ORDER's meaning to be inclusive rather
than exclusive, and has fixed a bunch of errors which were caused by its
unintuitive meaning.
- Axel Rasmussen give userfaultfd the UFFDIO_CONTINUE_MODE_WP feature,
which causes minor faults to install a write-protected pte.
- Vlastimil Babka has done some maintenance work on vma_merge():
cleanups to the kernel code and improvements to our userspace test
harness.
- Cleanups to do_fault_around() by Lorenzo Stoakes.
- Mike Rapoport has moved a lot of initialization code out of various
mm/ files and into mm/mm_init.c.
- Lorenzo Stoakes removd vmf_insert_mixed_prot(), which was added for
DRM, but DRM doesn't use it any more.
- Lorenzo has also coverted read_kcore() and vread() to use iterators
and has thereby removed the use of bounce buffers in some cases.
- Lorenzo has also contributed further cleanups of vma_merge().
- Chaitanya Prakash provides some fixes to the mmap selftesting code.
- Matthew Wilcox changes xfs and afs so they no longer take sleeping
locks in ->map_page(), a step towards RCUification of pagefaults.
- Suren Baghdasaryan has improved mmap_lock scalability by switching to
per-VMA locking.
- Frederic Weisbecker has reworked the percpu cache draining so that it
no longer causes latency glitches on cpu isolated workloads.
- Mike Rapoport cleans up and corrects the ARCH_FORCE_MAX_ORDER Kconfig
logic.
- Liu Shixin has changed zswap's initialization so we no longer waste a
chunk of memory if zswap is not being used.
- Yosry Ahmed has improved the performance of memcg statistics flushing.
- David Stevens has fixed several issues involving khugepaged,
userfaultfd and shmem.
- Christoph Hellwig has provided some cleanup work to zram's IO-related
code paths.
- David Hildenbrand has fixed up some issues in the selftest code's
testing of our pte state changing.
- Pankaj Raghav has made page_endio() unneeded and has removed it.
- Peter Xu contributed some rationalizations of the userfaultfd
selftests.
- Yosry Ahmed has fixed an issue around memcg's page recalim accounting.
- Chaitanya Prakash has fixed some arm-related issues in the
selftests/mm code.
- Longlong Xia has improved the way in which KSM handles hwpoisoned
pages.
- Peter Xu fixes a few issues with uffd-wp at fork() time.
- Stefan Roesch has changed KSM so that it may now be used on a
per-process and per-cgroup basis.
-----BEGIN PGP SIGNATURE-----
iHUEABYIAB0WIQTTMBEPP41GrTpTJgfdBJ7gKXxAjgUCZEr3zQAKCRDdBJ7gKXxA
jlLoAP0fpQBipwFxED0Us4SKQfupV6z4caXNJGPeay7Aj11/kQD/aMRC2uPfgr96
eMG3kwn2pqkB9ST2QpkaRbxA//eMbQY=
=J+Dj
-----END PGP SIGNATURE-----
Merge tag 'mm-stable-2023-04-27-15-30' of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
Pull MM updates from Andrew Morton:
- Nick Piggin's "shoot lazy tlbs" series, to improve the peformance of
switching from a user process to a kernel thread.
- More folio conversions from Kefeng Wang, Zhang Peng and Pankaj
Raghav.
- zsmalloc performance improvements from Sergey Senozhatsky.
- Yue Zhao has found and fixed some data race issues around the
alteration of memcg userspace tunables.
- VFS rationalizations from Christoph Hellwig:
- removal of most of the callers of write_one_page()
- make __filemap_get_folio()'s return value more useful
- Luis Chamberlain has changed tmpfs so it no longer requires swap
backing. Use `mount -o noswap'.
- Qi Zheng has made the slab shrinkers operate locklessly, providing
some scalability benefits.
- Keith Busch has improved dmapool's performance, making part of its
operations O(1) rather than O(n).
- Peter Xu adds the UFFD_FEATURE_WP_UNPOPULATED feature to userfaultd,
permitting userspace to wr-protect anon memory unpopulated ptes.
- Kirill Shutemov has changed MAX_ORDER's meaning to be inclusive
rather than exclusive, and has fixed a bunch of errors which were
caused by its unintuitive meaning.
- Axel Rasmussen give userfaultfd the UFFDIO_CONTINUE_MODE_WP feature,
which causes minor faults to install a write-protected pte.
- Vlastimil Babka has done some maintenance work on vma_merge():
cleanups to the kernel code and improvements to our userspace test
harness.
- Cleanups to do_fault_around() by Lorenzo Stoakes.
- Mike Rapoport has moved a lot of initialization code out of various
mm/ files and into mm/mm_init.c.
- Lorenzo Stoakes removd vmf_insert_mixed_prot(), which was added for
DRM, but DRM doesn't use it any more.
- Lorenzo has also coverted read_kcore() and vread() to use iterators
and has thereby removed the use of bounce buffers in some cases.
- Lorenzo has also contributed further cleanups of vma_merge().
- Chaitanya Prakash provides some fixes to the mmap selftesting code.
- Matthew Wilcox changes xfs and afs so they no longer take sleeping
locks in ->map_page(), a step towards RCUification of pagefaults.
- Suren Baghdasaryan has improved mmap_lock scalability by switching to
per-VMA locking.
- Frederic Weisbecker has reworked the percpu cache draining so that it
no longer causes latency glitches on cpu isolated workloads.
- Mike Rapoport cleans up and corrects the ARCH_FORCE_MAX_ORDER Kconfig
logic.
- Liu Shixin has changed zswap's initialization so we no longer waste a
chunk of memory if zswap is not being used.
- Yosry Ahmed has improved the performance of memcg statistics
flushing.
- David Stevens has fixed several issues involving khugepaged,
userfaultfd and shmem.
- Christoph Hellwig has provided some cleanup work to zram's IO-related
code paths.
- David Hildenbrand has fixed up some issues in the selftest code's
testing of our pte state changing.
- Pankaj Raghav has made page_endio() unneeded and has removed it.
- Peter Xu contributed some rationalizations of the userfaultfd
selftests.
- Yosry Ahmed has fixed an issue around memcg's page recalim
accounting.
- Chaitanya Prakash has fixed some arm-related issues in the
selftests/mm code.
- Longlong Xia has improved the way in which KSM handles hwpoisoned
pages.
- Peter Xu fixes a few issues with uffd-wp at fork() time.
- Stefan Roesch has changed KSM so that it may now be used on a
per-process and per-cgroup basis.
* tag 'mm-stable-2023-04-27-15-30' of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm: (369 commits)
mm,unmap: avoid flushing TLB in batch if PTE is inaccessible
shmem: restrict noswap option to initial user namespace
mm/khugepaged: fix conflicting mods to collapse_file()
sparse: remove unnecessary 0 values from rc
mm: move 'mmap_min_addr' logic from callers into vm_unmapped_area()
hugetlb: pte_alloc_huge() to replace huge pte_alloc_map()
maple_tree: fix allocation in mas_sparse_area()
mm: do not increment pgfault stats when page fault handler retries
zsmalloc: allow only one active pool compaction context
selftests/mm: add new selftests for KSM
mm: add new KSM process and sysfs knobs
mm: add new api to enable ksm per process
mm: shrinkers: fix debugfs file permissions
mm: don't check VMA write permissions if the PTE/PMD indicates write permissions
migrate_pages_batch: fix statistics for longterm pin retry
userfaultfd: use helper function range_in_vma()
lib/show_mem.c: use for_each_populated_zone() simplify code
mm: correct arg in reclaim_pages()/reclaim_clean_pages_from_list()
fs/buffer: convert create_page_buffers to folio_create_buffers
fs/buffer: add folio_create_empty_buffers helper
...
2023-04-28 02:42:02 +00:00
|
|
|
if (IS_ERR(folio))
|
|
|
|
return PTR_ERR(folio);
|
2013-02-09 14:24:14 +00:00
|
|
|
|
2024-08-30 05:37:38 +00:00
|
|
|
ret = ext4_block_write_begin(NULL, folio, pos, len,
|
|
|
|
ext4_da_get_block_prep);
|
2008-07-11 23:27:31 +00:00
|
|
|
if (ret < 0) {
|
2023-03-24 18:01:22 +00:00
|
|
|
folio_unlock(folio);
|
|
|
|
folio_put(folio);
|
2008-09-13 17:10:25 +00:00
|
|
|
/*
|
|
|
|
* block_write_begin may have instantiated a few blocks
|
|
|
|
* outside i_size. Trim these off again. Don't need
|
2021-07-16 12:20:24 +00:00
|
|
|
* i_size_read because we hold inode lock.
|
2008-09-13 17:10:25 +00:00
|
|
|
*/
|
|
|
|
if (pos + len > inode->i_size)
|
2009-12-09 02:24:33 +00:00
|
|
|
ext4_truncate_failed_write(inode);
|
2013-02-09 14:24:14 +00:00
|
|
|
|
|
|
|
if (ret == -ENOSPC &&
|
|
|
|
ext4_should_retry_alloc(inode->i_sb, &retries))
|
2021-07-16 12:20:24 +00:00
|
|
|
goto retry;
|
2013-02-09 14:24:14 +00:00
|
|
|
return ret;
|
2008-07-11 23:27:31 +00:00
|
|
|
}
|
|
|
|
|
2024-07-15 18:24:01 +00:00
|
|
|
*foliop = folio;
|
2008-07-11 23:27:31 +00:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
ext4: fix delalloc i_disksize early update issue
Ext4_da_write_end() used walk_page_buffers() with a callback function of
ext4_bh_unmapped_or_delay() to check if it extended the file size
without allocating any blocks (since in this case i_disksize needs to be
updated). However, this is didn't work proprely because the buffer head
has not been marked dirty yet --- this is done later in
block_commit_write() --- which caused ext4_bh_unmapped_or_delay() to
always return false.
In addition, walk_page_buffers() checks all of the buffer heads covering
the page, and the only buffer_head that should be checked is the one
covering the end of the write. Otherwise, given a 1k blocksize
filesystem and a 4k page size, the buffer head covering the first 1k
stripe of the file could be unmapped (because it was a sparse file), and
the second or third buffer_head covering that page could be mapped, and
using walk_page_buffers() would fail in this case since it would stop at
the first unmapped buffer_head and return true.
The core problem is that walk_page_buffers() was intended to do work in
a callback function, and a non-zero return value indicated a failure,
which termined the walk of the buffer heads covering the page. It was
not intended to be used with a boolean function, such as
ext4_bh_unmapped_or_delay().
Add addtional fix from Aneesh to protect i_disksize update rave with truncate.
Signed-off-by: Mingming Cao <cmm@us.ibm.com>
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2008-07-11 23:27:31 +00:00
|
|
|
/*
|
|
|
|
* Check if we should update i_disksize
|
|
|
|
* when write to the end of file but not require block allocation
|
|
|
|
*/
|
2023-05-15 10:40:44 +00:00
|
|
|
static int ext4_da_should_update_i_disksize(struct folio *folio,
|
2009-06-14 21:45:34 +00:00
|
|
|
unsigned long offset)
|
ext4: fix delalloc i_disksize early update issue
Ext4_da_write_end() used walk_page_buffers() with a callback function of
ext4_bh_unmapped_or_delay() to check if it extended the file size
without allocating any blocks (since in this case i_disksize needs to be
updated). However, this is didn't work proprely because the buffer head
has not been marked dirty yet --- this is done later in
block_commit_write() --- which caused ext4_bh_unmapped_or_delay() to
always return false.
In addition, walk_page_buffers() checks all of the buffer heads covering
the page, and the only buffer_head that should be checked is the one
covering the end of the write. Otherwise, given a 1k blocksize
filesystem and a 4k page size, the buffer head covering the first 1k
stripe of the file could be unmapped (because it was a sparse file), and
the second or third buffer_head covering that page could be mapped, and
using walk_page_buffers() would fail in this case since it would stop at
the first unmapped buffer_head and return true.
The core problem is that walk_page_buffers() was intended to do work in
a callback function, and a non-zero return value indicated a failure,
which termined the walk of the buffer heads covering the page. It was
not intended to be used with a boolean function, such as
ext4_bh_unmapped_or_delay().
Add addtional fix from Aneesh to protect i_disksize update rave with truncate.
Signed-off-by: Mingming Cao <cmm@us.ibm.com>
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2008-07-11 23:27:31 +00:00
|
|
|
{
|
|
|
|
struct buffer_head *bh;
|
2023-05-15 10:40:44 +00:00
|
|
|
struct inode *inode = folio->mapping->host;
|
ext4: fix delalloc i_disksize early update issue
Ext4_da_write_end() used walk_page_buffers() with a callback function of
ext4_bh_unmapped_or_delay() to check if it extended the file size
without allocating any blocks (since in this case i_disksize needs to be
updated). However, this is didn't work proprely because the buffer head
has not been marked dirty yet --- this is done later in
block_commit_write() --- which caused ext4_bh_unmapped_or_delay() to
always return false.
In addition, walk_page_buffers() checks all of the buffer heads covering
the page, and the only buffer_head that should be checked is the one
covering the end of the write. Otherwise, given a 1k blocksize
filesystem and a 4k page size, the buffer head covering the first 1k
stripe of the file could be unmapped (because it was a sparse file), and
the second or third buffer_head covering that page could be mapped, and
using walk_page_buffers() would fail in this case since it would stop at
the first unmapped buffer_head and return true.
The core problem is that walk_page_buffers() was intended to do work in
a callback function, and a non-zero return value indicated a failure,
which termined the walk of the buffer heads covering the page. It was
not intended to be used with a boolean function, such as
ext4_bh_unmapped_or_delay().
Add addtional fix from Aneesh to protect i_disksize update rave with truncate.
Signed-off-by: Mingming Cao <cmm@us.ibm.com>
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2008-07-11 23:27:31 +00:00
|
|
|
unsigned int idx;
|
|
|
|
int i;
|
|
|
|
|
2023-05-15 10:40:44 +00:00
|
|
|
bh = folio_buffers(folio);
|
ext4: fix delalloc i_disksize early update issue
Ext4_da_write_end() used walk_page_buffers() with a callback function of
ext4_bh_unmapped_or_delay() to check if it extended the file size
without allocating any blocks (since in this case i_disksize needs to be
updated). However, this is didn't work proprely because the buffer head
has not been marked dirty yet --- this is done later in
block_commit_write() --- which caused ext4_bh_unmapped_or_delay() to
always return false.
In addition, walk_page_buffers() checks all of the buffer heads covering
the page, and the only buffer_head that should be checked is the one
covering the end of the write. Otherwise, given a 1k blocksize
filesystem and a 4k page size, the buffer head covering the first 1k
stripe of the file could be unmapped (because it was a sparse file), and
the second or third buffer_head covering that page could be mapped, and
using walk_page_buffers() would fail in this case since it would stop at
the first unmapped buffer_head and return true.
The core problem is that walk_page_buffers() was intended to do work in
a callback function, and a non-zero return value indicated a failure,
which termined the walk of the buffer heads covering the page. It was
not intended to be used with a boolean function, such as
ext4_bh_unmapped_or_delay().
Add addtional fix from Aneesh to protect i_disksize update rave with truncate.
Signed-off-by: Mingming Cao <cmm@us.ibm.com>
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2008-07-11 23:27:31 +00:00
|
|
|
idx = offset >> inode->i_blkbits;
|
|
|
|
|
2008-09-09 02:25:24 +00:00
|
|
|
for (i = 0; i < idx; i++)
|
ext4: fix delalloc i_disksize early update issue
Ext4_da_write_end() used walk_page_buffers() with a callback function of
ext4_bh_unmapped_or_delay() to check if it extended the file size
without allocating any blocks (since in this case i_disksize needs to be
updated). However, this is didn't work proprely because the buffer head
has not been marked dirty yet --- this is done later in
block_commit_write() --- which caused ext4_bh_unmapped_or_delay() to
always return false.
In addition, walk_page_buffers() checks all of the buffer heads covering
the page, and the only buffer_head that should be checked is the one
covering the end of the write. Otherwise, given a 1k blocksize
filesystem and a 4k page size, the buffer head covering the first 1k
stripe of the file could be unmapped (because it was a sparse file), and
the second or third buffer_head covering that page could be mapped, and
using walk_page_buffers() would fail in this case since it would stop at
the first unmapped buffer_head and return true.
The core problem is that walk_page_buffers() was intended to do work in
a callback function, and a non-zero return value indicated a failure,
which termined the walk of the buffer heads covering the page. It was
not intended to be used with a boolean function, such as
ext4_bh_unmapped_or_delay().
Add addtional fix from Aneesh to protect i_disksize update rave with truncate.
Signed-off-by: Mingming Cao <cmm@us.ibm.com>
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2008-07-11 23:27:31 +00:00
|
|
|
bh = bh->b_this_page;
|
|
|
|
|
2009-05-12 20:30:27 +00:00
|
|
|
if (!buffer_mapped(bh) || (buffer_delay(bh)) || buffer_unwritten(bh))
|
ext4: fix delalloc i_disksize early update issue
Ext4_da_write_end() used walk_page_buffers() with a callback function of
ext4_bh_unmapped_or_delay() to check if it extended the file size
without allocating any blocks (since in this case i_disksize needs to be
updated). However, this is didn't work proprely because the buffer head
has not been marked dirty yet --- this is done later in
block_commit_write() --- which caused ext4_bh_unmapped_or_delay() to
always return false.
In addition, walk_page_buffers() checks all of the buffer heads covering
the page, and the only buffer_head that should be checked is the one
covering the end of the write. Otherwise, given a 1k blocksize
filesystem and a 4k page size, the buffer head covering the first 1k
stripe of the file could be unmapped (because it was a sparse file), and
the second or third buffer_head covering that page could be mapped, and
using walk_page_buffers() would fail in this case since it would stop at
the first unmapped buffer_head and return true.
The core problem is that walk_page_buffers() was intended to do work in
a callback function, and a non-zero return value indicated a failure,
which termined the walk of the buffer heads covering the page. It was
not intended to be used with a boolean function, such as
ext4_bh_unmapped_or_delay().
Add addtional fix from Aneesh to protect i_disksize update rave with truncate.
Signed-off-by: Mingming Cao <cmm@us.ibm.com>
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2008-07-11 23:27:31 +00:00
|
|
|
return 0;
|
|
|
|
return 1;
|
|
|
|
}
|
|
|
|
|
ext4: do not mark inode dirty every time when appending using delalloc
In the delalloc append write scenario, if inode's i_size is extended due
to buffer write, there are delalloc writes pending in the range up to
i_size, and no need to touch i_disksize since writeback will push
i_disksize up to i_size eventually. Offers significant performance
improvement in high-frequency append write scenarios.
I conducted tests in my 32-core environment by launching 32 concurrent
threads to append write to the same file. Each write operation had a
length of 1024 bytes and was repeated 100000 times. Without using this
patch, the test was completed in 7705 ms. However, with this patch, the
test was completed in 5066 ms, resulting in a performance improvement of
34%.
Moreover, in test scenarios of Kafka version 2.6.2, using packet size of
2K, with this patch resulted in a 10% performance improvement.
Signed-off-by: Liu Song <liusong@linux.alibaba.com>
Suggested-by: Jan Kara <jack@suse.cz>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20230810154333.84921-1-liusong@linux.alibaba.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
2023-08-10 15:43:33 +00:00
|
|
|
static int ext4_da_do_write_end(struct address_space *mapping,
|
|
|
|
loff_t pos, unsigned len, unsigned copied,
|
2023-12-14 05:30:35 +00:00
|
|
|
struct folio *folio)
|
ext4: do not mark inode dirty every time when appending using delalloc
In the delalloc append write scenario, if inode's i_size is extended due
to buffer write, there are delalloc writes pending in the range up to
i_size, and no need to touch i_disksize since writeback will push
i_disksize up to i_size eventually. Offers significant performance
improvement in high-frequency append write scenarios.
I conducted tests in my 32-core environment by launching 32 concurrent
threads to append write to the same file. Each write operation had a
length of 1024 bytes and was repeated 100000 times. Without using this
patch, the test was completed in 7705 ms. However, with this patch, the
test was completed in 5066 ms, resulting in a performance improvement of
34%.
Moreover, in test scenarios of Kafka version 2.6.2, using packet size of
2K, with this patch resulted in a 10% performance improvement.
Signed-off-by: Liu Song <liusong@linux.alibaba.com>
Suggested-by: Jan Kara <jack@suse.cz>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20230810154333.84921-1-liusong@linux.alibaba.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
2023-08-10 15:43:33 +00:00
|
|
|
{
|
|
|
|
struct inode *inode = mapping->host;
|
|
|
|
loff_t old_size = inode->i_size;
|
|
|
|
bool disksize_changed = false;
|
2024-09-19 16:07:40 +00:00
|
|
|
loff_t new_i_size, zero_len = 0;
|
|
|
|
handle_t *handle;
|
ext4: do not mark inode dirty every time when appending using delalloc
In the delalloc append write scenario, if inode's i_size is extended due
to buffer write, there are delalloc writes pending in the range up to
i_size, and no need to touch i_disksize since writeback will push
i_disksize up to i_size eventually. Offers significant performance
improvement in high-frequency append write scenarios.
I conducted tests in my 32-core environment by launching 32 concurrent
threads to append write to the same file. Each write operation had a
length of 1024 bytes and was repeated 100000 times. Without using this
patch, the test was completed in 7705 ms. However, with this patch, the
test was completed in 5066 ms, resulting in a performance improvement of
34%.
Moreover, in test scenarios of Kafka version 2.6.2, using packet size of
2K, with this patch resulted in a 10% performance improvement.
Signed-off-by: Liu Song <liusong@linux.alibaba.com>
Suggested-by: Jan Kara <jack@suse.cz>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20230810154333.84921-1-liusong@linux.alibaba.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
2023-08-10 15:43:33 +00:00
|
|
|
|
ext4: sanity check for NULL pointer after ext4_force_shutdown
Test case: 2 threads write short inline data to a file.
In ext4_page_mkwrite the resulting inline data is converted.
Handling ext4_grp_locked_error with description "block bitmap
and bg descriptor inconsistent: X vs Y free clusters" calls
ext4_force_shutdown. The conversion clears
EXT4_STATE_MAY_INLINE_DATA but fails for
ext4_destroy_inline_data_nolock and ext4_mark_iloc_dirty due
to ext4_forced_shutdown. The restoration of inline data fails
for the same reason not setting EXT4_STATE_MAY_INLINE_DATA.
Without the flag set a regular process path in ext4_da_write_end
follows trying to dereference page folio private pointer that has
not been set. The fix calls early return with -EIO error shall the
pointer to private be NULL.
Sample crash report:
Unable to handle kernel paging request at virtual address dfff800000000004
KASAN: null-ptr-deref in range [0x0000000000000020-0x0000000000000027]
Mem abort info:
ESR = 0x0000000096000005
EC = 0x25: DABT (current EL), IL = 32 bits
SET = 0, FnV = 0
EA = 0, S1PTW = 0
FSC = 0x05: level 1 translation fault
Data abort info:
ISV = 0, ISS = 0x00000005, ISS2 = 0x00000000
CM = 0, WnR = 0, TnD = 0, TagAccess = 0
GCS = 0, Overlay = 0, DirtyBit = 0, Xs = 0
[dfff800000000004] address between user and kernel address ranges
Internal error: Oops: 0000000096000005 [#1] PREEMPT SMP
Modules linked in:
CPU: 1 PID: 20274 Comm: syz-executor185 Not tainted 6.9.0-rc7-syzkaller-gfda5695d692c #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/27/2024
pstate: 80400005 (Nzcv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--)
pc : __block_commit_write+0x64/0x2b0 fs/buffer.c:2167
lr : __block_commit_write+0x3c/0x2b0 fs/buffer.c:2160
sp : ffff8000a1957600
x29: ffff8000a1957610 x28: dfff800000000000 x27: ffff0000e30e34b0
x26: 0000000000000000 x25: dfff800000000000 x24: dfff800000000000
x23: fffffdffc397c9e0 x22: 0000000000000020 x21: 0000000000000020
x20: 0000000000000040 x19: fffffdffc397c9c0 x18: 1fffe000367bd196
x17: ffff80008eead000 x16: ffff80008ae89e3c x15: 00000000200000c0
x14: 1fffe0001cbe4e04 x13: 0000000000000000 x12: 0000000000000000
x11: 0000000000000001 x10: 0000000000ff0100 x9 : 0000000000000000
x8 : 0000000000000004 x7 : 0000000000000000 x6 : 0000000000000000
x5 : fffffdffc397c9c0 x4 : 0000000000000020 x3 : 0000000000000020
x2 : 0000000000000040 x1 : 0000000000000020 x0 : fffffdffc397c9c0
Call trace:
__block_commit_write+0x64/0x2b0 fs/buffer.c:2167
block_write_end+0xb4/0x104 fs/buffer.c:2253
ext4_da_do_write_end fs/ext4/inode.c:2955 [inline]
ext4_da_write_end+0x2c4/0xa40 fs/ext4/inode.c:3028
generic_perform_write+0x394/0x588 mm/filemap.c:3985
ext4_buffered_write_iter+0x2c0/0x4ec fs/ext4/file.c:299
ext4_file_write_iter+0x188/0x1780
call_write_iter include/linux/fs.h:2110 [inline]
new_sync_write fs/read_write.c:497 [inline]
vfs_write+0x968/0xc3c fs/read_write.c:590
ksys_write+0x15c/0x26c fs/read_write.c:643
__do_sys_write fs/read_write.c:655 [inline]
__se_sys_write fs/read_write.c:652 [inline]
__arm64_sys_write+0x7c/0x90 fs/read_write.c:652
__invoke_syscall arch/arm64/kernel/syscall.c:34 [inline]
invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:48
el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:133
do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:152
el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:712
el0t_64_sync_handler+0x84/0xfc arch/arm64/kernel/entry-common.c:730
el0t_64_sync+0x190/0x194 arch/arm64/kernel/entry.S:598
Code: 97f85911 f94002da 91008356 d343fec8 (38796908)
---[ end trace 0000000000000000 ]---
----------------
Code disassembly (best guess):
0: 97f85911 bl 0xffffffffffe16444
4: f94002da ldr x26, [x22]
8: 91008356 add x22, x26, #0x20
c: d343fec8 lsr x8, x22, #3
* 10: 38796908 ldrb w8, [x8, x25] <-- trapping instruction
Reported-by: syzbot+18df508cf00a0598d9a6@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=18df508cf00a0598d9a6
Link: https://lore.kernel.org/all/000000000000f19a1406109eb5c5@google.com/T/
Signed-off-by: Wojciech Gładysz <wojciech.gladysz@infogain.com>
Link: https://patch.msgid.link/20240703070112.10235-1-wojciech.gladysz@infogain.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
2024-07-03 07:01:12 +00:00
|
|
|
if (unlikely(!folio_buffers(folio))) {
|
|
|
|
folio_unlock(folio);
|
|
|
|
folio_put(folio);
|
|
|
|
return -EIO;
|
|
|
|
}
|
ext4: do not mark inode dirty every time when appending using delalloc
In the delalloc append write scenario, if inode's i_size is extended due
to buffer write, there are delalloc writes pending in the range up to
i_size, and no need to touch i_disksize since writeback will push
i_disksize up to i_size eventually. Offers significant performance
improvement in high-frequency append write scenarios.
I conducted tests in my 32-core environment by launching 32 concurrent
threads to append write to the same file. Each write operation had a
length of 1024 bytes and was repeated 100000 times. Without using this
patch, the test was completed in 7705 ms. However, with this patch, the
test was completed in 5066 ms, resulting in a performance improvement of
34%.
Moreover, in test scenarios of Kafka version 2.6.2, using packet size of
2K, with this patch resulted in a 10% performance improvement.
Signed-off-by: Liu Song <liusong@linux.alibaba.com>
Suggested-by: Jan Kara <jack@suse.cz>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20230810154333.84921-1-liusong@linux.alibaba.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
2023-08-10 15:43:33 +00:00
|
|
|
/*
|
|
|
|
* block_write_end() will mark the inode as dirty with I_DIRTY_PAGES
|
|
|
|
* flag, which all that's needed to trigger page writeback.
|
|
|
|
*/
|
2023-12-14 05:30:35 +00:00
|
|
|
copied = block_write_end(NULL, mapping, pos, len, copied,
|
2024-07-10 18:51:11 +00:00
|
|
|
folio, NULL);
|
ext4: do not mark inode dirty every time when appending using delalloc
In the delalloc append write scenario, if inode's i_size is extended due
to buffer write, there are delalloc writes pending in the range up to
i_size, and no need to touch i_disksize since writeback will push
i_disksize up to i_size eventually. Offers significant performance
improvement in high-frequency append write scenarios.
I conducted tests in my 32-core environment by launching 32 concurrent
threads to append write to the same file. Each write operation had a
length of 1024 bytes and was repeated 100000 times. Without using this
patch, the test was completed in 7705 ms. However, with this patch, the
test was completed in 5066 ms, resulting in a performance improvement of
34%.
Moreover, in test scenarios of Kafka version 2.6.2, using packet size of
2K, with this patch resulted in a 10% performance improvement.
Signed-off-by: Liu Song <liusong@linux.alibaba.com>
Suggested-by: Jan Kara <jack@suse.cz>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20230810154333.84921-1-liusong@linux.alibaba.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
2023-08-10 15:43:33 +00:00
|
|
|
new_i_size = pos + copied;
|
|
|
|
|
|
|
|
/*
|
2023-12-14 05:30:35 +00:00
|
|
|
* It's important to update i_size while still holding folio lock,
|
|
|
|
* because folio writeout could otherwise come in and zero beyond
|
ext4: do not mark inode dirty every time when appending using delalloc
In the delalloc append write scenario, if inode's i_size is extended due
to buffer write, there are delalloc writes pending in the range up to
i_size, and no need to touch i_disksize since writeback will push
i_disksize up to i_size eventually. Offers significant performance
improvement in high-frequency append write scenarios.
I conducted tests in my 32-core environment by launching 32 concurrent
threads to append write to the same file. Each write operation had a
length of 1024 bytes and was repeated 100000 times. Without using this
patch, the test was completed in 7705 ms. However, with this patch, the
test was completed in 5066 ms, resulting in a performance improvement of
34%.
Moreover, in test scenarios of Kafka version 2.6.2, using packet size of
2K, with this patch resulted in a 10% performance improvement.
Signed-off-by: Liu Song <liusong@linux.alibaba.com>
Suggested-by: Jan Kara <jack@suse.cz>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20230810154333.84921-1-liusong@linux.alibaba.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
2023-08-10 15:43:33 +00:00
|
|
|
* i_size.
|
|
|
|
*
|
|
|
|
* Since we are holding inode lock, we are sure i_disksize <=
|
|
|
|
* i_size. We also know that if i_disksize < i_size, there are
|
|
|
|
* delalloc writes pending in the range up to i_size. If the end of
|
|
|
|
* the current write is <= i_size, there's no need to touch
|
|
|
|
* i_disksize since writeback will push i_disksize up to i_size
|
|
|
|
* eventually. If the end of the current write is > i_size and
|
|
|
|
* inside an allocated block which ext4_da_should_update_i_disksize()
|
|
|
|
* checked, we need to update i_disksize here as certain
|
|
|
|
* ext4_writepages() paths not allocating blocks and update i_disksize.
|
|
|
|
*/
|
|
|
|
if (new_i_size > inode->i_size) {
|
|
|
|
unsigned long end;
|
|
|
|
|
|
|
|
i_size_write(inode, new_i_size);
|
|
|
|
end = (new_i_size - 1) & (PAGE_SIZE - 1);
|
2023-12-14 05:30:35 +00:00
|
|
|
if (copied && ext4_da_should_update_i_disksize(folio, end)) {
|
ext4: do not mark inode dirty every time when appending using delalloc
In the delalloc append write scenario, if inode's i_size is extended due
to buffer write, there are delalloc writes pending in the range up to
i_size, and no need to touch i_disksize since writeback will push
i_disksize up to i_size eventually. Offers significant performance
improvement in high-frequency append write scenarios.
I conducted tests in my 32-core environment by launching 32 concurrent
threads to append write to the same file. Each write operation had a
length of 1024 bytes and was repeated 100000 times. Without using this
patch, the test was completed in 7705 ms. However, with this patch, the
test was completed in 5066 ms, resulting in a performance improvement of
34%.
Moreover, in test scenarios of Kafka version 2.6.2, using packet size of
2K, with this patch resulted in a 10% performance improvement.
Signed-off-by: Liu Song <liusong@linux.alibaba.com>
Suggested-by: Jan Kara <jack@suse.cz>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20230810154333.84921-1-liusong@linux.alibaba.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
2023-08-10 15:43:33 +00:00
|
|
|
ext4_update_i_disksize(inode, new_i_size);
|
|
|
|
disksize_changed = true;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2023-12-14 05:30:35 +00:00
|
|
|
folio_unlock(folio);
|
|
|
|
folio_put(folio);
|
ext4: do not mark inode dirty every time when appending using delalloc
In the delalloc append write scenario, if inode's i_size is extended due
to buffer write, there are delalloc writes pending in the range up to
i_size, and no need to touch i_disksize since writeback will push
i_disksize up to i_size eventually. Offers significant performance
improvement in high-frequency append write scenarios.
I conducted tests in my 32-core environment by launching 32 concurrent
threads to append write to the same file. Each write operation had a
length of 1024 bytes and was repeated 100000 times. Without using this
patch, the test was completed in 7705 ms. However, with this patch, the
test was completed in 5066 ms, resulting in a performance improvement of
34%.
Moreover, in test scenarios of Kafka version 2.6.2, using packet size of
2K, with this patch resulted in a 10% performance improvement.
Signed-off-by: Liu Song <liusong@linux.alibaba.com>
Suggested-by: Jan Kara <jack@suse.cz>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20230810154333.84921-1-liusong@linux.alibaba.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
2023-08-10 15:43:33 +00:00
|
|
|
|
2024-09-19 16:07:40 +00:00
|
|
|
if (pos > old_size) {
|
ext4: do not mark inode dirty every time when appending using delalloc
In the delalloc append write scenario, if inode's i_size is extended due
to buffer write, there are delalloc writes pending in the range up to
i_size, and no need to touch i_disksize since writeback will push
i_disksize up to i_size eventually. Offers significant performance
improvement in high-frequency append write scenarios.
I conducted tests in my 32-core environment by launching 32 concurrent
threads to append write to the same file. Each write operation had a
length of 1024 bytes and was repeated 100000 times. Without using this
patch, the test was completed in 7705 ms. However, with this patch, the
test was completed in 5066 ms, resulting in a performance improvement of
34%.
Moreover, in test scenarios of Kafka version 2.6.2, using packet size of
2K, with this patch resulted in a 10% performance improvement.
Signed-off-by: Liu Song <liusong@linux.alibaba.com>
Suggested-by: Jan Kara <jack@suse.cz>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20230810154333.84921-1-liusong@linux.alibaba.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
2023-08-10 15:43:33 +00:00
|
|
|
pagecache_isize_extended(inode, old_size, pos);
|
2024-09-19 16:07:40 +00:00
|
|
|
zero_len = pos - old_size;
|
|
|
|
}
|
ext4: do not mark inode dirty every time when appending using delalloc
In the delalloc append write scenario, if inode's i_size is extended due
to buffer write, there are delalloc writes pending in the range up to
i_size, and no need to touch i_disksize since writeback will push
i_disksize up to i_size eventually. Offers significant performance
improvement in high-frequency append write scenarios.
I conducted tests in my 32-core environment by launching 32 concurrent
threads to append write to the same file. Each write operation had a
length of 1024 bytes and was repeated 100000 times. Without using this
patch, the test was completed in 7705 ms. However, with this patch, the
test was completed in 5066 ms, resulting in a performance improvement of
34%.
Moreover, in test scenarios of Kafka version 2.6.2, using packet size of
2K, with this patch resulted in a 10% performance improvement.
Signed-off-by: Liu Song <liusong@linux.alibaba.com>
Suggested-by: Jan Kara <jack@suse.cz>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20230810154333.84921-1-liusong@linux.alibaba.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
2023-08-10 15:43:33 +00:00
|
|
|
|
2024-09-19 16:07:40 +00:00
|
|
|
if (!disksize_changed && !zero_len)
|
|
|
|
return copied;
|
ext4: do not mark inode dirty every time when appending using delalloc
In the delalloc append write scenario, if inode's i_size is extended due
to buffer write, there are delalloc writes pending in the range up to
i_size, and no need to touch i_disksize since writeback will push
i_disksize up to i_size eventually. Offers significant performance
improvement in high-frequency append write scenarios.
I conducted tests in my 32-core environment by launching 32 concurrent
threads to append write to the same file. Each write operation had a
length of 1024 bytes and was repeated 100000 times. Without using this
patch, the test was completed in 7705 ms. However, with this patch, the
test was completed in 5066 ms, resulting in a performance improvement of
34%.
Moreover, in test scenarios of Kafka version 2.6.2, using packet size of
2K, with this patch resulted in a 10% performance improvement.
Signed-off-by: Liu Song <liusong@linux.alibaba.com>
Suggested-by: Jan Kara <jack@suse.cz>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20230810154333.84921-1-liusong@linux.alibaba.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
2023-08-10 15:43:33 +00:00
|
|
|
|
2024-09-19 16:07:40 +00:00
|
|
|
handle = ext4_journal_start(inode, EXT4_HT_INODE, 2);
|
|
|
|
if (IS_ERR(handle))
|
|
|
|
return PTR_ERR(handle);
|
|
|
|
if (zero_len)
|
|
|
|
ext4_zero_partial_blocks(handle, inode, old_size, zero_len);
|
|
|
|
ext4_mark_inode_dirty(handle, inode);
|
|
|
|
ext4_journal_stop(handle);
|
ext4: do not mark inode dirty every time when appending using delalloc
In the delalloc append write scenario, if inode's i_size is extended due
to buffer write, there are delalloc writes pending in the range up to
i_size, and no need to touch i_disksize since writeback will push
i_disksize up to i_size eventually. Offers significant performance
improvement in high-frequency append write scenarios.
I conducted tests in my 32-core environment by launching 32 concurrent
threads to append write to the same file. Each write operation had a
length of 1024 bytes and was repeated 100000 times. Without using this
patch, the test was completed in 7705 ms. However, with this patch, the
test was completed in 5066 ms, resulting in a performance improvement of
34%.
Moreover, in test scenarios of Kafka version 2.6.2, using packet size of
2K, with this patch resulted in a 10% performance improvement.
Signed-off-by: Liu Song <liusong@linux.alibaba.com>
Suggested-by: Jan Kara <jack@suse.cz>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20230810154333.84921-1-liusong@linux.alibaba.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
2023-08-10 15:43:33 +00:00
|
|
|
|
|
|
|
return copied;
|
|
|
|
}
|
|
|
|
|
2008-07-11 23:27:31 +00:00
|
|
|
static int ext4_da_write_end(struct file *file,
|
2009-06-14 21:45:34 +00:00
|
|
|
struct address_space *mapping,
|
|
|
|
loff_t pos, unsigned len, unsigned copied,
|
2024-07-10 19:45:32 +00:00
|
|
|
struct folio *folio, void *fsdata)
|
2008-07-11 23:27:31 +00:00
|
|
|
{
|
|
|
|
struct inode *inode = mapping->host;
|
2008-10-09 03:13:30 +00:00
|
|
|
int write_mode = (int)(unsigned long)fsdata;
|
|
|
|
|
2013-04-03 16:39:17 +00:00
|
|
|
if (write_mode == FALL_BACK_TO_NONDELALLOC)
|
|
|
|
return ext4_write_end(file, mapping, pos,
|
2024-07-10 19:45:32 +00:00
|
|
|
len, copied, folio, fsdata);
|
ext4: fix delalloc i_disksize early update issue
Ext4_da_write_end() used walk_page_buffers() with a callback function of
ext4_bh_unmapped_or_delay() to check if it extended the file size
without allocating any blocks (since in this case i_disksize needs to be
updated). However, this is didn't work proprely because the buffer head
has not been marked dirty yet --- this is done later in
block_commit_write() --- which caused ext4_bh_unmapped_or_delay() to
always return false.
In addition, walk_page_buffers() checks all of the buffer heads covering
the page, and the only buffer_head that should be checked is the one
covering the end of the write. Otherwise, given a 1k blocksize
filesystem and a 4k page size, the buffer head covering the first 1k
stripe of the file could be unmapped (because it was a sparse file), and
the second or third buffer_head covering that page could be mapped, and
using walk_page_buffers() would fail in this case since it would stop at
the first unmapped buffer_head and return true.
The core problem is that walk_page_buffers() was intended to do work in
a callback function, and a non-zero return value indicated a failure,
which termined the walk of the buffer heads covering the page. It was
not intended to be used with a boolean function, such as
ext4_bh_unmapped_or_delay().
Add addtional fix from Aneesh to protect i_disksize update rave with truncate.
Signed-off-by: Mingming Cao <cmm@us.ibm.com>
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2008-07-11 23:27:31 +00:00
|
|
|
|
2009-06-17 15:48:11 +00:00
|
|
|
trace_ext4_da_write_end(inode, pos, len, copied);
|
2021-07-16 12:20:23 +00:00
|
|
|
|
|
|
|
if (write_mode != CONVERT_INLINE_DATA &&
|
|
|
|
ext4_test_inode_state(inode, EXT4_STATE_MAY_INLINE_DATA) &&
|
|
|
|
ext4_has_inline_data(inode))
|
2023-05-15 10:40:44 +00:00
|
|
|
return ext4_write_inline_data_end(inode, pos, len, copied,
|
|
|
|
folio);
|
2021-07-16 12:20:23 +00:00
|
|
|
|
2023-12-14 05:30:35 +00:00
|
|
|
if (unlikely(copied < len) && !folio_test_uptodate(folio))
|
2023-03-21 01:37:21 +00:00
|
|
|
copied = 0;
|
|
|
|
|
2023-12-14 05:30:35 +00:00
|
|
|
return ext4_da_do_write_end(mapping, pos, len, copied, folio);
|
2008-07-11 23:27:31 +00:00
|
|
|
}
|
|
|
|
|
2009-02-26 06:04:07 +00:00
|
|
|
/*
|
|
|
|
* Force all delayed allocation blocks to be allocated for a given inode.
|
|
|
|
*/
|
|
|
|
int ext4_alloc_da_blocks(struct inode *inode)
|
|
|
|
{
|
2009-09-16 23:30:40 +00:00
|
|
|
trace_ext4_alloc_da_blocks(inode);
|
|
|
|
|
2014-07-15 10:02:38 +00:00
|
|
|
if (!EXT4_I(inode)->i_reserved_data_blocks)
|
2009-02-26 06:04:07 +00:00
|
|
|
return 0;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* We do something simple for now. The filemap_flush() will
|
|
|
|
* also start triggering a write of the data blocks, which is
|
|
|
|
* not strictly speaking necessary (and for users of
|
|
|
|
* laptop_mode, not even desirable). However, to do otherwise
|
|
|
|
* would require replicating code paths in:
|
2009-06-14 21:45:34 +00:00
|
|
|
*
|
2013-06-06 18:00:46 +00:00
|
|
|
* ext4_writepages() ->
|
2009-02-26 06:04:07 +00:00
|
|
|
* write_cache_pages() ---> (via passed in callback function)
|
|
|
|
* __mpage_da_writepage() -->
|
|
|
|
* mpage_add_bh_to_extent()
|
|
|
|
* mpage_da_map_blocks()
|
|
|
|
*
|
|
|
|
* The problem is that write_cache_pages(), located in
|
|
|
|
* mm/page-writeback.c, marks pages clean in preparation for
|
|
|
|
* doing I/O, which is not desirable if we're not planning on
|
|
|
|
* doing I/O at all.
|
|
|
|
*
|
|
|
|
* We could call write_cache_pages(), and then redirty all of
|
2010-11-11 11:23:29 +00:00
|
|
|
* the pages by calling redirty_page_for_writepage() but that
|
2009-02-26 06:04:07 +00:00
|
|
|
* would be ugly in the extreme. So instead we would need to
|
|
|
|
* replicate parts of the code in the above functions,
|
2011-03-31 01:57:33 +00:00
|
|
|
* simplifying them because we wouldn't actually intend to
|
2009-02-26 06:04:07 +00:00
|
|
|
* write out the pages, but rather only collect contiguous
|
|
|
|
* logical block extents, call the multi-block allocator, and
|
|
|
|
* then update the buffer heads with the block allocations.
|
2009-06-14 21:45:34 +00:00
|
|
|
*
|
2009-02-26 06:04:07 +00:00
|
|
|
* For now, though, we'll cheat by calling filemap_flush(),
|
|
|
|
* which will map the blocks, and start the I/O, but not
|
|
|
|
* actually wait for the I/O to complete.
|
|
|
|
*/
|
|
|
|
return filemap_flush(inode->i_mapping);
|
|
|
|
}
|
2008-07-11 23:27:31 +00:00
|
|
|
|
2006-10-11 08:20:50 +00:00
|
|
|
/*
|
|
|
|
* bmap() is special. It gets used by applications such as lilo and by
|
|
|
|
* the swapper to find the on-disk block of a specific piece of data.
|
|
|
|
*
|
|
|
|
* Naturally, this is dangerous if the block concerned is still in the
|
2006-10-11 08:20:53 +00:00
|
|
|
* journal. If somebody makes a swapfile on an ext4 data-journaling
|
2006-10-11 08:20:50 +00:00
|
|
|
* filesystem and enables swap, then they may get a nasty shock when the
|
|
|
|
* data getting swapped to that swapfile suddenly gets overwritten by
|
|
|
|
* the original zero's written out previously to the journal and
|
|
|
|
* awaiting writeback in the kernel's buffer cache.
|
|
|
|
*
|
|
|
|
* So, if we see any bmap calls here on a modified, data-journaled file,
|
|
|
|
* take extra steps to flush any blocks which might be in the cache.
|
|
|
|
*/
|
2006-10-11 08:20:53 +00:00
|
|
|
static sector_t ext4_bmap(struct address_space *mapping, sector_t block)
|
2006-10-11 08:20:50 +00:00
|
|
|
{
|
|
|
|
struct inode *inode = mapping->host;
|
2022-06-17 01:39:35 +00:00
|
|
|
sector_t ret = 0;
|
2006-10-11 08:20:50 +00:00
|
|
|
|
2022-06-17 01:39:35 +00:00
|
|
|
inode_lock_shared(inode);
|
2012-12-10 19:04:52 +00:00
|
|
|
/*
|
|
|
|
* We can get here for an inline file via the FIBMAP ioctl
|
|
|
|
*/
|
|
|
|
if (ext4_has_inline_data(inode))
|
2022-06-17 01:39:35 +00:00
|
|
|
goto out;
|
2012-12-10 19:04:52 +00:00
|
|
|
|
2008-07-11 23:27:31 +00:00
|
|
|
if (mapping_tagged(mapping, PAGECACHE_TAG_DIRTY) &&
|
2023-03-29 15:49:42 +00:00
|
|
|
(test_opt(inode->i_sb, DELALLOC) ||
|
|
|
|
ext4_should_journal_data(inode))) {
|
2008-07-11 23:27:31 +00:00
|
|
|
/*
|
2023-03-29 15:49:42 +00:00
|
|
|
* With delalloc or journalled data we want to sync the file so
|
|
|
|
* that we can make sure we allocate blocks for file and data
|
|
|
|
* is in place for the user to see it
|
2008-07-11 23:27:31 +00:00
|
|
|
*/
|
|
|
|
filemap_write_and_wait(mapping);
|
|
|
|
}
|
|
|
|
|
2022-06-17 01:39:35 +00:00
|
|
|
ret = iomap_bmap(mapping, block, &ext4_iomap_ops);
|
|
|
|
|
|
|
|
out:
|
|
|
|
inode_unlock_shared(inode);
|
|
|
|
return ret;
|
2006-10-11 08:20:50 +00:00
|
|
|
}
|
|
|
|
|
2022-04-29 15:12:16 +00:00
|
|
|
static int ext4_read_folio(struct file *file, struct folio *folio)
|
2006-10-11 08:20:50 +00:00
|
|
|
{
|
2012-12-10 19:04:52 +00:00
|
|
|
int ret = -EAGAIN;
|
2023-03-24 18:01:23 +00:00
|
|
|
struct inode *inode = folio->mapping->host;
|
2012-12-10 19:04:52 +00:00
|
|
|
|
2023-05-15 10:40:42 +00:00
|
|
|
trace_ext4_read_folio(inode, folio);
|
2012-12-10 19:04:52 +00:00
|
|
|
|
|
|
|
if (ext4_has_inline_data(inode))
|
2023-03-24 18:01:09 +00:00
|
|
|
ret = ext4_readpage_inline(inode, folio);
|
2012-12-10 19:04:52 +00:00
|
|
|
|
|
|
|
if (ret == -EAGAIN)
|
2023-03-24 18:01:23 +00:00
|
|
|
return ext4_mpage_readpages(inode, NULL, folio);
|
2012-12-10 19:04:52 +00:00
|
|
|
|
|
|
|
return ret;
|
2006-10-11 08:20:50 +00:00
|
|
|
}
|
|
|
|
|
2020-06-02 04:47:16 +00:00
|
|
|
static void ext4_readahead(struct readahead_control *rac)
|
2006-10-11 08:20:50 +00:00
|
|
|
{
|
2020-06-02 04:47:16 +00:00
|
|
|
struct inode *inode = rac->mapping->host;
|
2012-12-10 19:04:52 +00:00
|
|
|
|
2020-06-02 04:47:16 +00:00
|
|
|
/* If the file has inline data, no need to do readahead. */
|
2012-12-10 19:04:52 +00:00
|
|
|
if (ext4_has_inline_data(inode))
|
2020-06-02 04:47:16 +00:00
|
|
|
return;
|
2012-12-10 19:04:52 +00:00
|
|
|
|
2020-06-02 04:47:20 +00:00
|
|
|
ext4_mpage_readpages(inode, rac, NULL);
|
2006-10-11 08:20:50 +00:00
|
|
|
}
|
|
|
|
|
2022-02-09 20:21:34 +00:00
|
|
|
static void ext4_invalidate_folio(struct folio *folio, size_t offset,
|
|
|
|
size_t length)
|
2006-10-11 08:20:50 +00:00
|
|
|
{
|
2022-02-09 20:21:43 +00:00
|
|
|
trace_ext4_invalidate_folio(folio, offset, length);
|
2011-03-22 01:38:05 +00:00
|
|
|
|
2012-12-25 18:28:54 +00:00
|
|
|
/* No journalling happens on data buffers when this function is used */
|
2022-02-09 20:21:34 +00:00
|
|
|
WARN_ON(folio_buffers(folio) && buffer_jbd(folio_buffers(folio)));
|
2012-12-25 18:28:54 +00:00
|
|
|
|
2022-02-09 20:21:34 +00:00
|
|
|
block_invalidate_folio(folio, offset, length);
|
2012-12-25 18:28:54 +00:00
|
|
|
}
|
|
|
|
|
2022-02-09 20:21:43 +00:00
|
|
|
static int __ext4_journalled_invalidate_folio(struct folio *folio,
|
|
|
|
size_t offset, size_t length)
|
2012-12-25 18:28:54 +00:00
|
|
|
{
|
2022-02-09 20:21:43 +00:00
|
|
|
journal_t *journal = EXT4_JOURNAL(folio->mapping->host);
|
2012-12-25 18:28:54 +00:00
|
|
|
|
2022-02-09 20:21:43 +00:00
|
|
|
trace_ext4_journalled_invalidate_folio(folio, offset, length);
|
2012-12-25 18:28:54 +00:00
|
|
|
|
2006-10-11 08:20:50 +00:00
|
|
|
/*
|
|
|
|
* If it's a full truncate we just forget about the pending dirtying
|
|
|
|
*/
|
2022-02-09 20:21:43 +00:00
|
|
|
if (offset == 0 && length == folio_size(folio))
|
|
|
|
folio_clear_checked(folio);
|
2006-10-11 08:20:50 +00:00
|
|
|
|
2022-02-09 20:21:43 +00:00
|
|
|
return jbd2_journal_invalidate_folio(journal, folio, offset, length);
|
2012-12-25 18:29:52 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/* Wrapper for aops... */
|
2022-02-09 20:21:43 +00:00
|
|
|
static void ext4_journalled_invalidate_folio(struct folio *folio,
|
|
|
|
size_t offset,
|
|
|
|
size_t length)
|
2012-12-25 18:29:52 +00:00
|
|
|
{
|
2022-02-09 20:21:43 +00:00
|
|
|
WARN_ON(__ext4_journalled_invalidate_folio(folio, offset, length) < 0);
|
2006-10-11 08:20:50 +00:00
|
|
|
}
|
|
|
|
|
2022-05-01 03:33:38 +00:00
|
|
|
static bool ext4_release_folio(struct folio *folio, gfp_t wait)
|
2006-10-11 08:20:50 +00:00
|
|
|
{
|
2023-05-15 10:40:42 +00:00
|
|
|
struct inode *inode = folio->mapping->host;
|
|
|
|
journal_t *journal = EXT4_JOURNAL(inode);
|
2006-10-11 08:20:50 +00:00
|
|
|
|
2023-05-15 10:40:42 +00:00
|
|
|
trace_ext4_release_folio(inode, folio);
|
2011-03-22 01:38:05 +00:00
|
|
|
|
2013-03-11 02:19:00 +00:00
|
|
|
/* Page has dirty journalled data -> cannot release */
|
2022-05-01 03:33:38 +00:00
|
|
|
if (folio_test_checked(folio))
|
|
|
|
return false;
|
2009-01-07 05:06:22 +00:00
|
|
|
if (journal)
|
2022-05-01 04:46:03 +00:00
|
|
|
return jbd2_journal_try_to_free_buffers(journal, folio);
|
2009-01-07 05:06:22 +00:00
|
|
|
else
|
2022-05-01 05:08:08 +00:00
|
|
|
return try_to_free_buffers(folio);
|
2006-10-11 08:20:50 +00:00
|
|
|
}
|
|
|
|
|
2017-11-01 15:36:45 +00:00
|
|
|
static bool ext4_inode_datasync_dirty(struct inode *inode)
|
|
|
|
{
|
|
|
|
journal_t *journal = EXT4_SB(inode->i_sb)->s_journal;
|
|
|
|
|
2020-10-15 20:37:57 +00:00
|
|
|
if (journal) {
|
|
|
|
if (jbd2_transaction_committed(journal,
|
2020-10-27 04:49:13 +00:00
|
|
|
EXT4_I(inode)->i_datasync_tid))
|
|
|
|
return false;
|
|
|
|
if (test_opt2(inode->i_sb, JOURNAL_FAST_COMMIT))
|
2020-11-06 03:59:06 +00:00
|
|
|
return !list_empty(&EXT4_I(inode)->i_fc_list);
|
2020-10-27 04:49:13 +00:00
|
|
|
return true;
|
2020-10-15 20:37:57 +00:00
|
|
|
}
|
|
|
|
|
2017-11-01 15:36:45 +00:00
|
|
|
/* Any metadata buffers to write? */
|
2023-11-17 21:58:23 +00:00
|
|
|
if (!list_empty(&inode->i_mapping->i_private_list))
|
2017-11-01 15:36:45 +00:00
|
|
|
return true;
|
|
|
|
return inode->i_state & I_DIRTY_DATASYNC;
|
|
|
|
}
|
|
|
|
|
2019-11-05 11:59:56 +00:00
|
|
|
static void ext4_set_iomap(struct inode *inode, struct iomap *iomap,
|
|
|
|
struct ext4_map_blocks *map, loff_t offset,
|
2021-11-29 10:22:00 +00:00
|
|
|
loff_t length, unsigned int flags)
|
2016-11-20 22:36:06 +00:00
|
|
|
{
|
2019-11-05 11:59:56 +00:00
|
|
|
u8 blkbits = inode->i_blkbits;
|
2016-11-20 22:36:06 +00:00
|
|
|
|
2019-11-05 11:59:56 +00:00
|
|
|
/*
|
|
|
|
* Writes that span EOF might trigger an I/O size update on completion,
|
|
|
|
* so consider them to be dirty for the purpose of O_DSYNC, even if
|
|
|
|
* there is no other metadata changes being made or are pending.
|
|
|
|
*/
|
2016-11-20 22:36:06 +00:00
|
|
|
iomap->flags = 0;
|
2019-11-05 11:59:56 +00:00
|
|
|
if (ext4_inode_datasync_dirty(inode) ||
|
|
|
|
offset + length > i_size_read(inode))
|
2017-11-01 15:36:45 +00:00
|
|
|
iomap->flags |= IOMAP_F_DIRTY;
|
2019-11-05 11:59:56 +00:00
|
|
|
|
|
|
|
if (map->m_flags & EXT4_MAP_NEW)
|
|
|
|
iomap->flags |= IOMAP_F_NEW;
|
|
|
|
|
2021-11-29 10:22:00 +00:00
|
|
|
if (flags & IOMAP_DAX)
|
|
|
|
iomap->dax_dev = EXT4_SB(inode->i_sb)->s_daxdev;
|
|
|
|
else
|
|
|
|
iomap->bdev = inode->i_sb->s_bdev;
|
2019-11-05 11:59:56 +00:00
|
|
|
iomap->offset = (u64) map->m_lblk << blkbits;
|
|
|
|
iomap->length = (u64) map->m_len << blkbits;
|
2016-11-20 22:36:06 +00:00
|
|
|
|
2020-02-28 09:26:54 +00:00
|
|
|
if ((map->m_flags & EXT4_MAP_MAPPED) &&
|
|
|
|
!ext4_test_inode_flag(inode, EXT4_INODE_EXTENTS))
|
|
|
|
iomap->flags |= IOMAP_F_MERGED;
|
|
|
|
|
2019-11-05 11:59:56 +00:00
|
|
|
/*
|
|
|
|
* Flags passed to ext4_map_blocks() for direct I/O writes can result
|
|
|
|
* in m_flags having both EXT4_MAP_MAPPED and EXT4_MAP_UNWRITTEN bits
|
|
|
|
* set. In order for any allocated unwritten extents to be converted
|
|
|
|
* into written extents correctly within the ->end_io() handler, we
|
|
|
|
* need to ensure that the iomap->type is set appropriately. Hence, the
|
|
|
|
* reason why we need to check whether the EXT4_MAP_UNWRITTEN bit has
|
|
|
|
* been set first.
|
|
|
|
*/
|
|
|
|
if (map->m_flags & EXT4_MAP_UNWRITTEN) {
|
|
|
|
iomap->type = IOMAP_UNWRITTEN;
|
|
|
|
iomap->addr = (u64) map->m_pblk << blkbits;
|
2021-11-29 10:22:00 +00:00
|
|
|
if (flags & IOMAP_DAX)
|
|
|
|
iomap->addr += EXT4_SB(inode->i_sb)->s_dax_part_off;
|
2019-11-05 11:59:56 +00:00
|
|
|
} else if (map->m_flags & EXT4_MAP_MAPPED) {
|
|
|
|
iomap->type = IOMAP_MAPPED;
|
|
|
|
iomap->addr = (u64) map->m_pblk << blkbits;
|
2021-11-29 10:22:00 +00:00
|
|
|
if (flags & IOMAP_DAX)
|
|
|
|
iomap->addr += EXT4_SB(inode->i_sb)->s_dax_part_off;
|
2024-01-27 01:58:05 +00:00
|
|
|
} else if (map->m_flags & EXT4_MAP_DELAYED) {
|
|
|
|
iomap->type = IOMAP_DELALLOC;
|
|
|
|
iomap->addr = IOMAP_NULL_ADDR;
|
2016-11-20 22:36:06 +00:00
|
|
|
} else {
|
2019-11-05 11:59:56 +00:00
|
|
|
iomap->type = IOMAP_HOLE;
|
|
|
|
iomap->addr = IOMAP_NULL_ADDR;
|
2016-11-20 22:36:06 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2019-11-05 12:00:14 +00:00
|
|
|
static int ext4_iomap_alloc(struct inode *inode, struct ext4_map_blocks *map,
|
|
|
|
unsigned int flags)
|
2016-11-20 23:09:11 +00:00
|
|
|
{
|
|
|
|
handle_t *handle;
|
2019-11-05 12:02:39 +00:00
|
|
|
u8 blkbits = inode->i_blkbits;
|
|
|
|
int ret, dio_credits, m_flags = 0, retries = 0;
|
2016-11-20 23:09:11 +00:00
|
|
|
|
|
|
|
/*
|
2019-11-05 12:00:14 +00:00
|
|
|
* Trim the mapping request to the maximum value that we can map at
|
|
|
|
* once for direct I/O.
|
2016-11-20 23:09:11 +00:00
|
|
|
*/
|
2019-11-05 12:00:14 +00:00
|
|
|
if (map->m_len > DIO_MAX_BLOCKS)
|
|
|
|
map->m_len = DIO_MAX_BLOCKS;
|
|
|
|
dio_credits = ext4_chunk_trans_blocks(inode, map->m_len);
|
2016-11-20 23:09:11 +00:00
|
|
|
|
2019-11-05 12:00:14 +00:00
|
|
|
retry:
|
2016-11-20 23:09:11 +00:00
|
|
|
/*
|
2019-11-05 12:00:14 +00:00
|
|
|
* Either we allocate blocks and then don't get an unwritten extent, so
|
|
|
|
* in that case we have reserved enough credits. Or, the blocks are
|
|
|
|
* already allocated and unwritten. In that case, the extent conversion
|
|
|
|
* fits into the credits as well.
|
2016-11-20 23:09:11 +00:00
|
|
|
*/
|
2019-11-05 12:00:14 +00:00
|
|
|
handle = ext4_journal_start(inode, EXT4_HT_MAP_BLOCKS, dio_credits);
|
|
|
|
if (IS_ERR(handle))
|
|
|
|
return PTR_ERR(handle);
|
2009-09-28 19:48:41 +00:00
|
|
|
|
2019-11-05 12:02:39 +00:00
|
|
|
/*
|
|
|
|
* DAX and direct I/O are the only two operations that are currently
|
|
|
|
* supported with IOMAP_WRITE.
|
|
|
|
*/
|
2021-11-29 10:21:58 +00:00
|
|
|
WARN_ON(!(flags & (IOMAP_DAX | IOMAP_DIRECT)));
|
|
|
|
if (flags & IOMAP_DAX)
|
2019-11-05 12:02:39 +00:00
|
|
|
m_flags = EXT4_GET_BLOCKS_CREATE_ZERO;
|
|
|
|
/*
|
|
|
|
* We use i_size instead of i_disksize here because delalloc writeback
|
|
|
|
* can complete at any point during the I/O and subsequently push the
|
|
|
|
* i_disksize out to i_size. This could be beyond where direct I/O is
|
|
|
|
* happening and thus expose allocated blocks to direct I/O reads.
|
|
|
|
*/
|
2021-04-12 10:23:33 +00:00
|
|
|
else if (((loff_t)map->m_lblk << blkbits) >= i_size_read(inode))
|
2019-11-05 12:02:39 +00:00
|
|
|
m_flags = EXT4_GET_BLOCKS_CREATE;
|
|
|
|
else if (ext4_test_inode_flag(inode, EXT4_INODE_EXTENTS))
|
|
|
|
m_flags = EXT4_GET_BLOCKS_IO_CREATE_EXT;
|
2009-11-03 19:44:54 +00:00
|
|
|
|
2019-11-05 12:02:39 +00:00
|
|
|
ret = ext4_map_blocks(handle, inode, map, m_flags);
|
2009-09-28 19:48:29 +00:00
|
|
|
|
2016-02-28 21:36:38 +00:00
|
|
|
/*
|
2019-11-05 12:02:39 +00:00
|
|
|
* We cannot fill holes in indirect tree based inodes as that could
|
|
|
|
* expose stale data in the case of a crash. Use the magic error code
|
|
|
|
* to fallback to buffered I/O.
|
2016-02-28 21:36:38 +00:00
|
|
|
*/
|
2019-11-05 12:02:39 +00:00
|
|
|
if (!m_flags && !ret)
|
|
|
|
ret = -ENOTBLK;
|
2016-02-08 03:40:51 +00:00
|
|
|
|
2019-11-05 12:00:14 +00:00
|
|
|
ext4_journal_stop(handle);
|
|
|
|
if (ret == -ENOSPC && ext4_should_retry_alloc(inode->i_sb, &retries))
|
|
|
|
goto retry;
|
|
|
|
|
|
|
|
return ret;
|
2009-09-28 19:48:41 +00:00
|
|
|
}
|
2010-03-02 18:28:44 +00:00
|
|
|
|
2019-11-05 12:00:14 +00:00
|
|
|
|
2016-11-20 22:36:06 +00:00
|
|
|
static int ext4_iomap_begin(struct inode *inode, loff_t offset, loff_t length,
|
2019-10-18 23:44:10 +00:00
|
|
|
unsigned flags, struct iomap *iomap, struct iomap *srcmap)
|
2009-09-28 19:48:41 +00:00
|
|
|
{
|
2016-11-20 22:36:06 +00:00
|
|
|
int ret;
|
2019-11-05 12:03:31 +00:00
|
|
|
struct ext4_map_blocks map;
|
|
|
|
u8 blkbits = inode->i_blkbits;
|
2012-07-09 20:29:29 +00:00
|
|
|
|
2018-09-01 16:45:04 +00:00
|
|
|
if ((offset >> blkbits) > EXT4_MAX_LOGICAL_BLOCK)
|
|
|
|
return -EINVAL;
|
2012-07-23 00:19:31 +00:00
|
|
|
|
2019-11-05 12:03:31 +00:00
|
|
|
if (WARN_ON_ONCE(ext4_has_inline_data(inode)))
|
|
|
|
return -ERANGE;
|
2012-07-23 00:19:31 +00:00
|
|
|
|
2013-06-04 18:27:38 +00:00
|
|
|
/*
|
2019-11-05 12:03:31 +00:00
|
|
|
* Calculate the first and last logical blocks respectively.
|
2013-06-04 18:27:38 +00:00
|
|
|
*/
|
2019-11-05 12:03:31 +00:00
|
|
|
map.m_lblk = offset >> blkbits;
|
|
|
|
map.m_len = min_t(loff_t, (offset + length - 1) >> blkbits,
|
|
|
|
EXT4_MAX_LOGICAL_BLOCK) - map.m_lblk + 1;
|
2013-06-04 18:27:38 +00:00
|
|
|
|
2020-09-18 05:06:35 +00:00
|
|
|
if (flags & IOMAP_WRITE) {
|
|
|
|
/*
|
|
|
|
* We check here if the blocks are already allocated, then we
|
|
|
|
* don't need to start a journal txn and we can directly return
|
|
|
|
* the mapping information. This could boost performance
|
|
|
|
* especially in multi-threaded overwrite requests.
|
|
|
|
*/
|
|
|
|
if (offset + length <= i_size_read(inode)) {
|
|
|
|
ret = ext4_map_blocks(NULL, inode, &map, 0);
|
|
|
|
if (ret > 0 && (map.m_flags & EXT4_MAP_MAPPED))
|
|
|
|
goto out;
|
|
|
|
}
|
2019-11-05 12:00:14 +00:00
|
|
|
ret = ext4_iomap_alloc(inode, &map, flags);
|
2020-09-18 05:06:35 +00:00
|
|
|
} else {
|
2017-10-01 21:58:54 +00:00
|
|
|
ret = ext4_map_blocks(NULL, inode, &map, 0);
|
2020-09-18 05:06:35 +00:00
|
|
|
}
|
2012-07-23 00:19:31 +00:00
|
|
|
|
2019-11-05 12:00:14 +00:00
|
|
|
if (ret < 0)
|
|
|
|
return ret;
|
2020-09-18 05:06:35 +00:00
|
|
|
out:
|
ext4: support direct I/O with fscrypt using blk-crypto
Encrypted files traditionally haven't supported DIO, due to the need to
encrypt/decrypt the data. However, when the encryption is implemented
using inline encryption (blk-crypto) instead of the traditional
filesystem-layer encryption, it is straightforward to support DIO.
Therefore, make ext4 support DIO on files that are using inline
encryption. Since ext4 uses iomap for DIO, and fscrypt support was
already added to iomap DIO, this just requires two small changes:
- Let DIO proceed when supported, by checking fscrypt_dio_supported()
instead of assuming that encrypted files never support DIO.
- In ext4_iomap_begin(), use fscrypt_limit_io_blocks() to limit the
length of the mapping in the rare case where a DUN discontiguity
occurs in the middle of an extent. The iomap DIO implementation
requires this, since it assumes that it can submit a bio covering (up
to) the whole mapping, without checking fscrypt constraints itself.
Co-developed-by: Satya Tangirala <satyat@google.com>
Signed-off-by: Satya Tangirala <satyat@google.com>
Acked-by: Theodore Ts'o <tytso@mit.edu>
Reviewed-by: Jaegeuk Kim <jaegeuk@kernel.org>
Link: https://lore.kernel.org/r/20220128233940.79464-4-ebiggers@kernel.org
Signed-off-by: Eric Biggers <ebiggers@google.com>
2022-01-28 23:39:38 +00:00
|
|
|
/*
|
|
|
|
* When inline encryption is enabled, sometimes I/O to an encrypted file
|
|
|
|
* has to be broken up to guarantee DUN contiguity. Handle this by
|
|
|
|
* limiting the length of the mapping returned.
|
|
|
|
*/
|
|
|
|
map.m_len = fscrypt_limit_io_blocks(inode, map.m_lblk, map.m_len);
|
|
|
|
|
2021-11-29 10:22:00 +00:00
|
|
|
ext4_set_iomap(inode, iomap, &map, offset, length, flags);
|
2012-07-23 00:19:31 +00:00
|
|
|
|
2016-11-20 22:36:06 +00:00
|
|
|
return 0;
|
|
|
|
}
|
2009-09-28 19:48:29 +00:00
|
|
|
|
2019-12-18 17:44:33 +00:00
|
|
|
static int ext4_iomap_overwrite_begin(struct inode *inode, loff_t offset,
|
|
|
|
loff_t length, unsigned flags, struct iomap *iomap,
|
|
|
|
struct iomap *srcmap)
|
|
|
|
{
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Even for writes we don't need to allocate blocks, so just pretend
|
|
|
|
* we are reading to save overhead of starting a transaction.
|
|
|
|
*/
|
|
|
|
flags &= ~IOMAP_WRITE;
|
|
|
|
ret = ext4_iomap_begin(inode, offset, length, flags, iomap, srcmap);
|
2023-05-05 13:24:29 +00:00
|
|
|
WARN_ON_ONCE(!ret && iomap->type != IOMAP_MAPPED);
|
2019-12-18 17:44:33 +00:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2024-11-05 00:22:59 +00:00
|
|
|
static inline bool ext4_want_directio_fallback(unsigned flags, ssize_t written)
|
|
|
|
{
|
|
|
|
/* must be a directio to fall back to buffered */
|
|
|
|
if ((flags & (IOMAP_WRITE | IOMAP_DIRECT)) !=
|
|
|
|
(IOMAP_WRITE | IOMAP_DIRECT))
|
|
|
|
return false;
|
|
|
|
|
|
|
|
/* atomic writes are all-or-nothing */
|
|
|
|
if (flags & IOMAP_ATOMIC)
|
|
|
|
return false;
|
|
|
|
|
|
|
|
/* can only try again if we wrote nothing */
|
|
|
|
return written == 0;
|
|
|
|
}
|
|
|
|
|
2016-11-20 23:09:11 +00:00
|
|
|
static int ext4_iomap_end(struct inode *inode, loff_t offset, loff_t length,
|
|
|
|
ssize_t written, unsigned flags, struct iomap *iomap)
|
|
|
|
{
|
2012-11-30 02:13:48 +00:00
|
|
|
/*
|
2019-11-05 12:02:39 +00:00
|
|
|
* Check to see whether an error occurred while writing out the data to
|
2024-11-05 00:22:59 +00:00
|
|
|
* the allocated blocks. If so, return the magic error code for
|
|
|
|
* non-atomic write so that we fallback to buffered I/O and attempt to
|
|
|
|
* complete the remainder of the I/O.
|
|
|
|
* For non-atomic writes, any blocks that may have been
|
|
|
|
* allocated in preparation for the direct I/O will be reused during
|
|
|
|
* buffered I/O. For atomic write, we never fallback to buffered-io.
|
2012-11-30 02:13:48 +00:00
|
|
|
*/
|
2024-11-05 00:22:59 +00:00
|
|
|
if (ext4_want_directio_fallback(flags, written))
|
2019-11-05 12:02:39 +00:00
|
|
|
return -ENOTBLK;
|
2012-11-30 02:13:48 +00:00
|
|
|
|
2019-11-05 12:01:51 +00:00
|
|
|
return 0;
|
2016-11-20 23:09:11 +00:00
|
|
|
}
|
2012-07-23 00:19:31 +00:00
|
|
|
|
2017-01-28 07:20:26 +00:00
|
|
|
const struct iomap_ops ext4_iomap_ops = {
|
2016-11-20 22:36:06 +00:00
|
|
|
.iomap_begin = ext4_iomap_begin,
|
2016-11-20 23:09:11 +00:00
|
|
|
.iomap_end = ext4_iomap_end,
|
2016-11-20 22:36:06 +00:00
|
|
|
};
|
2009-09-28 19:48:29 +00:00
|
|
|
|
2019-12-18 17:44:33 +00:00
|
|
|
const struct iomap_ops ext4_iomap_overwrite_ops = {
|
|
|
|
.iomap_begin = ext4_iomap_overwrite_begin,
|
|
|
|
.iomap_end = ext4_iomap_end,
|
|
|
|
};
|
|
|
|
|
2019-11-05 12:03:31 +00:00
|
|
|
static int ext4_iomap_begin_report(struct inode *inode, loff_t offset,
|
|
|
|
loff_t length, unsigned int flags,
|
|
|
|
struct iomap *iomap, struct iomap *srcmap)
|
2009-09-28 19:48:41 +00:00
|
|
|
{
|
2019-11-05 12:03:31 +00:00
|
|
|
int ret;
|
|
|
|
struct ext4_map_blocks map;
|
|
|
|
u8 blkbits = inode->i_blkbits;
|
2009-09-28 19:48:41 +00:00
|
|
|
|
2019-11-05 12:03:31 +00:00
|
|
|
if ((offset >> blkbits) > EXT4_MAX_LOGICAL_BLOCK)
|
|
|
|
return -EINVAL;
|
|
|
|
|
|
|
|
if (ext4_has_inline_data(inode)) {
|
|
|
|
ret = ext4_inline_data_iomap(inode, iomap);
|
|
|
|
if (ret != -EAGAIN) {
|
|
|
|
if (ret == 0 && offset >= iomap->length)
|
|
|
|
ret = -ENOENT;
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
}
|
2015-04-12 04:55:10 +00:00
|
|
|
|
2011-08-31 15:56:51 +00:00
|
|
|
/*
|
2019-11-05 12:03:31 +00:00
|
|
|
* Calculate the first and last logical block respectively.
|
2011-08-31 15:56:51 +00:00
|
|
|
*/
|
2019-11-05 12:03:31 +00:00
|
|
|
map.m_lblk = offset >> blkbits;
|
|
|
|
map.m_len = min_t(loff_t, (offset + length - 1) >> blkbits,
|
|
|
|
EXT4_MAX_LOGICAL_BLOCK) - map.m_lblk + 1;
|
2011-08-31 15:56:51 +00:00
|
|
|
|
2020-02-28 09:26:57 +00:00
|
|
|
/*
|
|
|
|
* Fiemap callers may call for offset beyond s_bitmap_maxbytes.
|
|
|
|
* So handle it here itself instead of querying ext4_map_blocks().
|
|
|
|
* Since ext4_map_blocks() will warn about it and will return
|
|
|
|
* -EIO error.
|
|
|
|
*/
|
|
|
|
if (!(ext4_test_inode_flag(inode, EXT4_INODE_EXTENTS))) {
|
|
|
|
struct ext4_sb_info *sbi = EXT4_SB(inode->i_sb);
|
|
|
|
|
|
|
|
if (offset >= sbi->s_bitmap_maxbytes) {
|
|
|
|
map.m_flags = 0;
|
|
|
|
goto set_iomap;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2019-11-05 12:03:31 +00:00
|
|
|
ret = ext4_map_blocks(NULL, inode, &map, 0);
|
|
|
|
if (ret < 0)
|
|
|
|
return ret;
|
2020-02-28 09:26:57 +00:00
|
|
|
set_iomap:
|
2021-11-29 10:22:00 +00:00
|
|
|
ext4_set_iomap(inode, iomap, &map, offset, length, flags);
|
2019-11-05 12:03:31 +00:00
|
|
|
|
|
|
|
return 0;
|
2009-09-28 19:48:41 +00:00
|
|
|
}
|
|
|
|
|
2019-11-05 12:03:31 +00:00
|
|
|
const struct iomap_ops ext4_iomap_report_ops = {
|
|
|
|
.iomap_begin = ext4_iomap_begin_report,
|
|
|
|
};
|
|
|
|
|
2006-10-11 08:20:50 +00:00
|
|
|
/*
|
2023-02-28 05:13:15 +00:00
|
|
|
* For data=journal mode, folio should be marked dirty only when it was
|
|
|
|
* writeably mapped. When that happens, it was already attached to the
|
|
|
|
* transaction and marked as jbddirty (we take care of this in
|
|
|
|
* ext4_page_mkwrite()). On transaction commit, we writeprotect page mappings
|
|
|
|
* so we should have nothing to do here, except for the case when someone
|
|
|
|
* had the page pinned and dirtied the page through this pin (e.g. by doing
|
|
|
|
* direct IO to it). In that case we'd need to attach buffers here to the
|
|
|
|
* transaction but we cannot due to lock ordering. We cannot just dirty the
|
|
|
|
* folio and leave attached buffers clean, because the buffers' dirty state is
|
|
|
|
* "definitive". We cannot just set the buffers dirty or jbddirty because all
|
|
|
|
* the journalling code will explode. So what we do is to mark the folio
|
|
|
|
* "pending dirty" and next time ext4_writepages() is called, attach buffers
|
|
|
|
* to the transaction appropriately.
|
2006-10-11 08:20:50 +00:00
|
|
|
*/
|
2022-02-09 20:22:03 +00:00
|
|
|
static bool ext4_journalled_dirty_folio(struct address_space *mapping,
|
|
|
|
struct folio *folio)
|
2006-10-11 08:20:50 +00:00
|
|
|
{
|
2022-03-29 20:21:53 +00:00
|
|
|
WARN_ON_ONCE(!folio_buffers(folio));
|
2023-02-28 05:13:15 +00:00
|
|
|
if (folio_maybe_dma_pinned(folio))
|
|
|
|
folio_set_checked(folio);
|
2022-02-09 20:22:03 +00:00
|
|
|
return filemap_dirty_folio(mapping, folio);
|
2006-10-11 08:20:50 +00:00
|
|
|
}
|
|
|
|
|
2022-02-09 20:22:12 +00:00
|
|
|
static bool ext4_dirty_folio(struct address_space *mapping, struct folio *folio)
|
2016-12-01 16:46:40 +00:00
|
|
|
{
|
2022-02-09 20:22:12 +00:00
|
|
|
WARN_ON_ONCE(!folio_test_locked(folio) && !folio_test_dirty(folio));
|
|
|
|
WARN_ON_ONCE(!folio_buffers(folio));
|
|
|
|
return block_dirty_folio(mapping, folio);
|
2016-12-01 16:46:40 +00:00
|
|
|
}
|
|
|
|
|
2020-09-04 09:16:53 +00:00
|
|
|
static int ext4_iomap_swap_activate(struct swap_info_struct *sis,
|
|
|
|
struct file *file, sector_t *span)
|
|
|
|
{
|
|
|
|
return iomap_swapfile_activate(sis, file, span,
|
|
|
|
&ext4_iomap_report_ops);
|
|
|
|
}
|
|
|
|
|
2013-04-03 16:39:17 +00:00
|
|
|
static const struct address_space_operations ext4_aops = {
|
2022-04-29 15:12:16 +00:00
|
|
|
.read_folio = ext4_read_folio,
|
2020-06-02 04:47:16 +00:00
|
|
|
.readahead = ext4_readahead,
|
2013-06-06 18:00:46 +00:00
|
|
|
.writepages = ext4_writepages,
|
vfs: pagecache usage optimization for pagesize!=blocksize
When we read some part of a file through pagecache, if there is a
pagecache of corresponding index but this page is not uptodate, read IO
is issued and this page will be uptodate.
I think this is good for pagesize == blocksize environment but there is
room for improvement on pagesize != blocksize environment. Because in
this case a page can have multiple buffers and even if a page is not
uptodate, some buffers can be uptodate.
So I suggest that when all buffers which correspond to a part of a file
that we want to read are uptodate, use this pagecache and copy data from
this pagecache to user buffer even if a page is not uptodate. This can
reduce read IO and improve system throughput.
I wrote a benchmark program and got result number with this program.
This benchmark do:
1: mount and open a test file.
2: create a 512MB file.
3: close a file and umount.
4: mount and again open a test file.
5: pwrite randomly 300000 times on a test file. offset is aligned
by IO size(1024bytes).
6: measure time of preading randomly 100000 times on a test file.
The result was:
2.6.26
330 sec
2.6.26-patched
226 sec
Arch:i386
Filesystem:ext3
Blocksize:1024 bytes
Memory: 1GB
On ext3/4, a file is written through buffer/block. So random read/write
mixed workloads or random read after random write workloads are optimized
with this patch under pagesize != blocksize environment. This test result
showed this.
The benchmark program is as follows:
#include <stdio.h>
#include <sys/types.h>
#include <sys/stat.h>
#include <fcntl.h>
#include <unistd.h>
#include <time.h>
#include <stdlib.h>
#include <string.h>
#include <sys/mount.h>
#define LEN 1024
#define LOOP 1024*512 /* 512MB */
main(void)
{
unsigned long i, offset, filesize;
int fd;
char buf[LEN];
time_t t1, t2;
if (mount("/dev/sda1", "/root/test1/", "ext3", 0, 0) < 0) {
perror("cannot mount\n");
exit(1);
}
memset(buf, 0, LEN);
fd = open("/root/test1/testfile", O_CREAT|O_RDWR|O_TRUNC);
if (fd < 0) {
perror("cannot open file\n");
exit(1);
}
for (i = 0; i < LOOP; i++)
write(fd, buf, LEN);
close(fd);
if (umount("/root/test1/") < 0) {
perror("cannot umount\n");
exit(1);
}
if (mount("/dev/sda1", "/root/test1/", "ext3", 0, 0) < 0) {
perror("cannot mount\n");
exit(1);
}
fd = open("/root/test1/testfile", O_RDWR);
if (fd < 0) {
perror("cannot open file\n");
exit(1);
}
filesize = LEN * LOOP;
for (i = 0; i < 300000; i++){
offset = (random() % filesize) & (~(LEN - 1));
pwrite(fd, buf, LEN, offset);
}
printf("start test\n");
time(&t1);
for (i = 0; i < 100000; i++){
offset = (random() % filesize) & (~(LEN - 1));
pread(fd, buf, LEN, offset);
}
time(&t2);
printf("%ld sec\n", t2-t1);
close(fd);
if (umount("/root/test1/") < 0) {
perror("cannot umount\n");
exit(1);
}
}
Signed-off-by: Hisashi Hifumi <hifumi.hisashi@oss.ntt.co.jp>
Cc: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Jan Kara <jack@ucw.cz>
Cc: <linux-ext4@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-07-28 22:46:36 +00:00
|
|
|
.write_begin = ext4_write_begin,
|
2013-04-03 16:39:17 +00:00
|
|
|
.write_end = ext4_write_end,
|
2022-02-09 20:22:12 +00:00
|
|
|
.dirty_folio = ext4_dirty_folio,
|
vfs: pagecache usage optimization for pagesize!=blocksize
When we read some part of a file through pagecache, if there is a
pagecache of corresponding index but this page is not uptodate, read IO
is issued and this page will be uptodate.
I think this is good for pagesize == blocksize environment but there is
room for improvement on pagesize != blocksize environment. Because in
this case a page can have multiple buffers and even if a page is not
uptodate, some buffers can be uptodate.
So I suggest that when all buffers which correspond to a part of a file
that we want to read are uptodate, use this pagecache and copy data from
this pagecache to user buffer even if a page is not uptodate. This can
reduce read IO and improve system throughput.
I wrote a benchmark program and got result number with this program.
This benchmark do:
1: mount and open a test file.
2: create a 512MB file.
3: close a file and umount.
4: mount and again open a test file.
5: pwrite randomly 300000 times on a test file. offset is aligned
by IO size(1024bytes).
6: measure time of preading randomly 100000 times on a test file.
The result was:
2.6.26
330 sec
2.6.26-patched
226 sec
Arch:i386
Filesystem:ext3
Blocksize:1024 bytes
Memory: 1GB
On ext3/4, a file is written through buffer/block. So random read/write
mixed workloads or random read after random write workloads are optimized
with this patch under pagesize != blocksize environment. This test result
showed this.
The benchmark program is as follows:
#include <stdio.h>
#include <sys/types.h>
#include <sys/stat.h>
#include <fcntl.h>
#include <unistd.h>
#include <time.h>
#include <stdlib.h>
#include <string.h>
#include <sys/mount.h>
#define LEN 1024
#define LOOP 1024*512 /* 512MB */
main(void)
{
unsigned long i, offset, filesize;
int fd;
char buf[LEN];
time_t t1, t2;
if (mount("/dev/sda1", "/root/test1/", "ext3", 0, 0) < 0) {
perror("cannot mount\n");
exit(1);
}
memset(buf, 0, LEN);
fd = open("/root/test1/testfile", O_CREAT|O_RDWR|O_TRUNC);
if (fd < 0) {
perror("cannot open file\n");
exit(1);
}
for (i = 0; i < LOOP; i++)
write(fd, buf, LEN);
close(fd);
if (umount("/root/test1/") < 0) {
perror("cannot umount\n");
exit(1);
}
if (mount("/dev/sda1", "/root/test1/", "ext3", 0, 0) < 0) {
perror("cannot mount\n");
exit(1);
}
fd = open("/root/test1/testfile", O_RDWR);
if (fd < 0) {
perror("cannot open file\n");
exit(1);
}
filesize = LEN * LOOP;
for (i = 0; i < 300000; i++){
offset = (random() % filesize) & (~(LEN - 1));
pwrite(fd, buf, LEN, offset);
}
printf("start test\n");
time(&t1);
for (i = 0; i < 100000; i++){
offset = (random() % filesize) & (~(LEN - 1));
pread(fd, buf, LEN, offset);
}
time(&t2);
printf("%ld sec\n", t2-t1);
close(fd);
if (umount("/root/test1/") < 0) {
perror("cannot umount\n");
exit(1);
}
}
Signed-off-by: Hisashi Hifumi <hifumi.hisashi@oss.ntt.co.jp>
Cc: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Jan Kara <jack@ucw.cz>
Cc: <linux-ext4@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-07-28 22:46:36 +00:00
|
|
|
.bmap = ext4_bmap,
|
2022-02-09 20:21:34 +00:00
|
|
|
.invalidate_folio = ext4_invalidate_folio,
|
2022-05-01 03:33:38 +00:00
|
|
|
.release_folio = ext4_release_folio,
|
2022-06-06 14:20:31 +00:00
|
|
|
.migrate_folio = buffer_migrate_folio,
|
vfs: pagecache usage optimization for pagesize!=blocksize
When we read some part of a file through pagecache, if there is a
pagecache of corresponding index but this page is not uptodate, read IO
is issued and this page will be uptodate.
I think this is good for pagesize == blocksize environment but there is
room for improvement on pagesize != blocksize environment. Because in
this case a page can have multiple buffers and even if a page is not
uptodate, some buffers can be uptodate.
So I suggest that when all buffers which correspond to a part of a file
that we want to read are uptodate, use this pagecache and copy data from
this pagecache to user buffer even if a page is not uptodate. This can
reduce read IO and improve system throughput.
I wrote a benchmark program and got result number with this program.
This benchmark do:
1: mount and open a test file.
2: create a 512MB file.
3: close a file and umount.
4: mount and again open a test file.
5: pwrite randomly 300000 times on a test file. offset is aligned
by IO size(1024bytes).
6: measure time of preading randomly 100000 times on a test file.
The result was:
2.6.26
330 sec
2.6.26-patched
226 sec
Arch:i386
Filesystem:ext3
Blocksize:1024 bytes
Memory: 1GB
On ext3/4, a file is written through buffer/block. So random read/write
mixed workloads or random read after random write workloads are optimized
with this patch under pagesize != blocksize environment. This test result
showed this.
The benchmark program is as follows:
#include <stdio.h>
#include <sys/types.h>
#include <sys/stat.h>
#include <fcntl.h>
#include <unistd.h>
#include <time.h>
#include <stdlib.h>
#include <string.h>
#include <sys/mount.h>
#define LEN 1024
#define LOOP 1024*512 /* 512MB */
main(void)
{
unsigned long i, offset, filesize;
int fd;
char buf[LEN];
time_t t1, t2;
if (mount("/dev/sda1", "/root/test1/", "ext3", 0, 0) < 0) {
perror("cannot mount\n");
exit(1);
}
memset(buf, 0, LEN);
fd = open("/root/test1/testfile", O_CREAT|O_RDWR|O_TRUNC);
if (fd < 0) {
perror("cannot open file\n");
exit(1);
}
for (i = 0; i < LOOP; i++)
write(fd, buf, LEN);
close(fd);
if (umount("/root/test1/") < 0) {
perror("cannot umount\n");
exit(1);
}
if (mount("/dev/sda1", "/root/test1/", "ext3", 0, 0) < 0) {
perror("cannot mount\n");
exit(1);
}
fd = open("/root/test1/testfile", O_RDWR);
if (fd < 0) {
perror("cannot open file\n");
exit(1);
}
filesize = LEN * LOOP;
for (i = 0; i < 300000; i++){
offset = (random() % filesize) & (~(LEN - 1));
pwrite(fd, buf, LEN, offset);
}
printf("start test\n");
time(&t1);
for (i = 0; i < 100000; i++){
offset = (random() % filesize) & (~(LEN - 1));
pread(fd, buf, LEN, offset);
}
time(&t2);
printf("%ld sec\n", t2-t1);
close(fd);
if (umount("/root/test1/") < 0) {
perror("cannot umount\n");
exit(1);
}
}
Signed-off-by: Hisashi Hifumi <hifumi.hisashi@oss.ntt.co.jp>
Cc: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Jan Kara <jack@ucw.cz>
Cc: <linux-ext4@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-07-28 22:46:36 +00:00
|
|
|
.is_partially_uptodate = block_is_partially_uptodate,
|
2023-11-17 16:14:47 +00:00
|
|
|
.error_remove_folio = generic_error_remove_folio,
|
2020-09-04 09:16:53 +00:00
|
|
|
.swap_activate = ext4_iomap_swap_activate,
|
2006-10-11 08:20:50 +00:00
|
|
|
};
|
|
|
|
|
2006-10-11 08:20:53 +00:00
|
|
|
static const struct address_space_operations ext4_journalled_aops = {
|
2022-04-29 15:12:16 +00:00
|
|
|
.read_folio = ext4_read_folio,
|
2020-06-02 04:47:16 +00:00
|
|
|
.readahead = ext4_readahead,
|
2013-06-06 18:00:46 +00:00
|
|
|
.writepages = ext4_writepages,
|
vfs: pagecache usage optimization for pagesize!=blocksize
When we read some part of a file through pagecache, if there is a
pagecache of corresponding index but this page is not uptodate, read IO
is issued and this page will be uptodate.
I think this is good for pagesize == blocksize environment but there is
room for improvement on pagesize != blocksize environment. Because in
this case a page can have multiple buffers and even if a page is not
uptodate, some buffers can be uptodate.
So I suggest that when all buffers which correspond to a part of a file
that we want to read are uptodate, use this pagecache and copy data from
this pagecache to user buffer even if a page is not uptodate. This can
reduce read IO and improve system throughput.
I wrote a benchmark program and got result number with this program.
This benchmark do:
1: mount and open a test file.
2: create a 512MB file.
3: close a file and umount.
4: mount and again open a test file.
5: pwrite randomly 300000 times on a test file. offset is aligned
by IO size(1024bytes).
6: measure time of preading randomly 100000 times on a test file.
The result was:
2.6.26
330 sec
2.6.26-patched
226 sec
Arch:i386
Filesystem:ext3
Blocksize:1024 bytes
Memory: 1GB
On ext3/4, a file is written through buffer/block. So random read/write
mixed workloads or random read after random write workloads are optimized
with this patch under pagesize != blocksize environment. This test result
showed this.
The benchmark program is as follows:
#include <stdio.h>
#include <sys/types.h>
#include <sys/stat.h>
#include <fcntl.h>
#include <unistd.h>
#include <time.h>
#include <stdlib.h>
#include <string.h>
#include <sys/mount.h>
#define LEN 1024
#define LOOP 1024*512 /* 512MB */
main(void)
{
unsigned long i, offset, filesize;
int fd;
char buf[LEN];
time_t t1, t2;
if (mount("/dev/sda1", "/root/test1/", "ext3", 0, 0) < 0) {
perror("cannot mount\n");
exit(1);
}
memset(buf, 0, LEN);
fd = open("/root/test1/testfile", O_CREAT|O_RDWR|O_TRUNC);
if (fd < 0) {
perror("cannot open file\n");
exit(1);
}
for (i = 0; i < LOOP; i++)
write(fd, buf, LEN);
close(fd);
if (umount("/root/test1/") < 0) {
perror("cannot umount\n");
exit(1);
}
if (mount("/dev/sda1", "/root/test1/", "ext3", 0, 0) < 0) {
perror("cannot mount\n");
exit(1);
}
fd = open("/root/test1/testfile", O_RDWR);
if (fd < 0) {
perror("cannot open file\n");
exit(1);
}
filesize = LEN * LOOP;
for (i = 0; i < 300000; i++){
offset = (random() % filesize) & (~(LEN - 1));
pwrite(fd, buf, LEN, offset);
}
printf("start test\n");
time(&t1);
for (i = 0; i < 100000; i++){
offset = (random() % filesize) & (~(LEN - 1));
pread(fd, buf, LEN, offset);
}
time(&t2);
printf("%ld sec\n", t2-t1);
close(fd);
if (umount("/root/test1/") < 0) {
perror("cannot umount\n");
exit(1);
}
}
Signed-off-by: Hisashi Hifumi <hifumi.hisashi@oss.ntt.co.jp>
Cc: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Jan Kara <jack@ucw.cz>
Cc: <linux-ext4@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-07-28 22:46:36 +00:00
|
|
|
.write_begin = ext4_write_begin,
|
|
|
|
.write_end = ext4_journalled_write_end,
|
2022-02-09 20:22:03 +00:00
|
|
|
.dirty_folio = ext4_journalled_dirty_folio,
|
vfs: pagecache usage optimization for pagesize!=blocksize
When we read some part of a file through pagecache, if there is a
pagecache of corresponding index but this page is not uptodate, read IO
is issued and this page will be uptodate.
I think this is good for pagesize == blocksize environment but there is
room for improvement on pagesize != blocksize environment. Because in
this case a page can have multiple buffers and even if a page is not
uptodate, some buffers can be uptodate.
So I suggest that when all buffers which correspond to a part of a file
that we want to read are uptodate, use this pagecache and copy data from
this pagecache to user buffer even if a page is not uptodate. This can
reduce read IO and improve system throughput.
I wrote a benchmark program and got result number with this program.
This benchmark do:
1: mount and open a test file.
2: create a 512MB file.
3: close a file and umount.
4: mount and again open a test file.
5: pwrite randomly 300000 times on a test file. offset is aligned
by IO size(1024bytes).
6: measure time of preading randomly 100000 times on a test file.
The result was:
2.6.26
330 sec
2.6.26-patched
226 sec
Arch:i386
Filesystem:ext3
Blocksize:1024 bytes
Memory: 1GB
On ext3/4, a file is written through buffer/block. So random read/write
mixed workloads or random read after random write workloads are optimized
with this patch under pagesize != blocksize environment. This test result
showed this.
The benchmark program is as follows:
#include <stdio.h>
#include <sys/types.h>
#include <sys/stat.h>
#include <fcntl.h>
#include <unistd.h>
#include <time.h>
#include <stdlib.h>
#include <string.h>
#include <sys/mount.h>
#define LEN 1024
#define LOOP 1024*512 /* 512MB */
main(void)
{
unsigned long i, offset, filesize;
int fd;
char buf[LEN];
time_t t1, t2;
if (mount("/dev/sda1", "/root/test1/", "ext3", 0, 0) < 0) {
perror("cannot mount\n");
exit(1);
}
memset(buf, 0, LEN);
fd = open("/root/test1/testfile", O_CREAT|O_RDWR|O_TRUNC);
if (fd < 0) {
perror("cannot open file\n");
exit(1);
}
for (i = 0; i < LOOP; i++)
write(fd, buf, LEN);
close(fd);
if (umount("/root/test1/") < 0) {
perror("cannot umount\n");
exit(1);
}
if (mount("/dev/sda1", "/root/test1/", "ext3", 0, 0) < 0) {
perror("cannot mount\n");
exit(1);
}
fd = open("/root/test1/testfile", O_RDWR);
if (fd < 0) {
perror("cannot open file\n");
exit(1);
}
filesize = LEN * LOOP;
for (i = 0; i < 300000; i++){
offset = (random() % filesize) & (~(LEN - 1));
pwrite(fd, buf, LEN, offset);
}
printf("start test\n");
time(&t1);
for (i = 0; i < 100000; i++){
offset = (random() % filesize) & (~(LEN - 1));
pread(fd, buf, LEN, offset);
}
time(&t2);
printf("%ld sec\n", t2-t1);
close(fd);
if (umount("/root/test1/") < 0) {
perror("cannot umount\n");
exit(1);
}
}
Signed-off-by: Hisashi Hifumi <hifumi.hisashi@oss.ntt.co.jp>
Cc: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Jan Kara <jack@ucw.cz>
Cc: <linux-ext4@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-07-28 22:46:36 +00:00
|
|
|
.bmap = ext4_bmap,
|
2022-02-09 20:21:43 +00:00
|
|
|
.invalidate_folio = ext4_journalled_invalidate_folio,
|
2022-05-01 03:33:38 +00:00
|
|
|
.release_folio = ext4_release_folio,
|
2022-12-07 11:27:15 +00:00
|
|
|
.migrate_folio = buffer_migrate_folio_norefs,
|
vfs: pagecache usage optimization for pagesize!=blocksize
When we read some part of a file through pagecache, if there is a
pagecache of corresponding index but this page is not uptodate, read IO
is issued and this page will be uptodate.
I think this is good for pagesize == blocksize environment but there is
room for improvement on pagesize != blocksize environment. Because in
this case a page can have multiple buffers and even if a page is not
uptodate, some buffers can be uptodate.
So I suggest that when all buffers which correspond to a part of a file
that we want to read are uptodate, use this pagecache and copy data from
this pagecache to user buffer even if a page is not uptodate. This can
reduce read IO and improve system throughput.
I wrote a benchmark program and got result number with this program.
This benchmark do:
1: mount and open a test file.
2: create a 512MB file.
3: close a file and umount.
4: mount and again open a test file.
5: pwrite randomly 300000 times on a test file. offset is aligned
by IO size(1024bytes).
6: measure time of preading randomly 100000 times on a test file.
The result was:
2.6.26
330 sec
2.6.26-patched
226 sec
Arch:i386
Filesystem:ext3
Blocksize:1024 bytes
Memory: 1GB
On ext3/4, a file is written through buffer/block. So random read/write
mixed workloads or random read after random write workloads are optimized
with this patch under pagesize != blocksize environment. This test result
showed this.
The benchmark program is as follows:
#include <stdio.h>
#include <sys/types.h>
#include <sys/stat.h>
#include <fcntl.h>
#include <unistd.h>
#include <time.h>
#include <stdlib.h>
#include <string.h>
#include <sys/mount.h>
#define LEN 1024
#define LOOP 1024*512 /* 512MB */
main(void)
{
unsigned long i, offset, filesize;
int fd;
char buf[LEN];
time_t t1, t2;
if (mount("/dev/sda1", "/root/test1/", "ext3", 0, 0) < 0) {
perror("cannot mount\n");
exit(1);
}
memset(buf, 0, LEN);
fd = open("/root/test1/testfile", O_CREAT|O_RDWR|O_TRUNC);
if (fd < 0) {
perror("cannot open file\n");
exit(1);
}
for (i = 0; i < LOOP; i++)
write(fd, buf, LEN);
close(fd);
if (umount("/root/test1/") < 0) {
perror("cannot umount\n");
exit(1);
}
if (mount("/dev/sda1", "/root/test1/", "ext3", 0, 0) < 0) {
perror("cannot mount\n");
exit(1);
}
fd = open("/root/test1/testfile", O_RDWR);
if (fd < 0) {
perror("cannot open file\n");
exit(1);
}
filesize = LEN * LOOP;
for (i = 0; i < 300000; i++){
offset = (random() % filesize) & (~(LEN - 1));
pwrite(fd, buf, LEN, offset);
}
printf("start test\n");
time(&t1);
for (i = 0; i < 100000; i++){
offset = (random() % filesize) & (~(LEN - 1));
pread(fd, buf, LEN, offset);
}
time(&t2);
printf("%ld sec\n", t2-t1);
close(fd);
if (umount("/root/test1/") < 0) {
perror("cannot umount\n");
exit(1);
}
}
Signed-off-by: Hisashi Hifumi <hifumi.hisashi@oss.ntt.co.jp>
Cc: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Jan Kara <jack@ucw.cz>
Cc: <linux-ext4@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-07-28 22:46:36 +00:00
|
|
|
.is_partially_uptodate = block_is_partially_uptodate,
|
2023-11-17 16:14:47 +00:00
|
|
|
.error_remove_folio = generic_error_remove_folio,
|
2020-09-04 09:16:53 +00:00
|
|
|
.swap_activate = ext4_iomap_swap_activate,
|
2006-10-11 08:20:50 +00:00
|
|
|
};
|
|
|
|
|
2008-07-11 23:27:31 +00:00
|
|
|
static const struct address_space_operations ext4_da_aops = {
|
2022-04-29 15:12:16 +00:00
|
|
|
.read_folio = ext4_read_folio,
|
2020-06-02 04:47:16 +00:00
|
|
|
.readahead = ext4_readahead,
|
2013-06-06 18:00:46 +00:00
|
|
|
.writepages = ext4_writepages,
|
vfs: pagecache usage optimization for pagesize!=blocksize
When we read some part of a file through pagecache, if there is a
pagecache of corresponding index but this page is not uptodate, read IO
is issued and this page will be uptodate.
I think this is good for pagesize == blocksize environment but there is
room for improvement on pagesize != blocksize environment. Because in
this case a page can have multiple buffers and even if a page is not
uptodate, some buffers can be uptodate.
So I suggest that when all buffers which correspond to a part of a file
that we want to read are uptodate, use this pagecache and copy data from
this pagecache to user buffer even if a page is not uptodate. This can
reduce read IO and improve system throughput.
I wrote a benchmark program and got result number with this program.
This benchmark do:
1: mount and open a test file.
2: create a 512MB file.
3: close a file and umount.
4: mount and again open a test file.
5: pwrite randomly 300000 times on a test file. offset is aligned
by IO size(1024bytes).
6: measure time of preading randomly 100000 times on a test file.
The result was:
2.6.26
330 sec
2.6.26-patched
226 sec
Arch:i386
Filesystem:ext3
Blocksize:1024 bytes
Memory: 1GB
On ext3/4, a file is written through buffer/block. So random read/write
mixed workloads or random read after random write workloads are optimized
with this patch under pagesize != blocksize environment. This test result
showed this.
The benchmark program is as follows:
#include <stdio.h>
#include <sys/types.h>
#include <sys/stat.h>
#include <fcntl.h>
#include <unistd.h>
#include <time.h>
#include <stdlib.h>
#include <string.h>
#include <sys/mount.h>
#define LEN 1024
#define LOOP 1024*512 /* 512MB */
main(void)
{
unsigned long i, offset, filesize;
int fd;
char buf[LEN];
time_t t1, t2;
if (mount("/dev/sda1", "/root/test1/", "ext3", 0, 0) < 0) {
perror("cannot mount\n");
exit(1);
}
memset(buf, 0, LEN);
fd = open("/root/test1/testfile", O_CREAT|O_RDWR|O_TRUNC);
if (fd < 0) {
perror("cannot open file\n");
exit(1);
}
for (i = 0; i < LOOP; i++)
write(fd, buf, LEN);
close(fd);
if (umount("/root/test1/") < 0) {
perror("cannot umount\n");
exit(1);
}
if (mount("/dev/sda1", "/root/test1/", "ext3", 0, 0) < 0) {
perror("cannot mount\n");
exit(1);
}
fd = open("/root/test1/testfile", O_RDWR);
if (fd < 0) {
perror("cannot open file\n");
exit(1);
}
filesize = LEN * LOOP;
for (i = 0; i < 300000; i++){
offset = (random() % filesize) & (~(LEN - 1));
pwrite(fd, buf, LEN, offset);
}
printf("start test\n");
time(&t1);
for (i = 0; i < 100000; i++){
offset = (random() % filesize) & (~(LEN - 1));
pread(fd, buf, LEN, offset);
}
time(&t2);
printf("%ld sec\n", t2-t1);
close(fd);
if (umount("/root/test1/") < 0) {
perror("cannot umount\n");
exit(1);
}
}
Signed-off-by: Hisashi Hifumi <hifumi.hisashi@oss.ntt.co.jp>
Cc: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Jan Kara <jack@ucw.cz>
Cc: <linux-ext4@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-07-28 22:46:36 +00:00
|
|
|
.write_begin = ext4_da_write_begin,
|
|
|
|
.write_end = ext4_da_write_end,
|
2022-02-09 20:22:12 +00:00
|
|
|
.dirty_folio = ext4_dirty_folio,
|
vfs: pagecache usage optimization for pagesize!=blocksize
When we read some part of a file through pagecache, if there is a
pagecache of corresponding index but this page is not uptodate, read IO
is issued and this page will be uptodate.
I think this is good for pagesize == blocksize environment but there is
room for improvement on pagesize != blocksize environment. Because in
this case a page can have multiple buffers and even if a page is not
uptodate, some buffers can be uptodate.
So I suggest that when all buffers which correspond to a part of a file
that we want to read are uptodate, use this pagecache and copy data from
this pagecache to user buffer even if a page is not uptodate. This can
reduce read IO and improve system throughput.
I wrote a benchmark program and got result number with this program.
This benchmark do:
1: mount and open a test file.
2: create a 512MB file.
3: close a file and umount.
4: mount and again open a test file.
5: pwrite randomly 300000 times on a test file. offset is aligned
by IO size(1024bytes).
6: measure time of preading randomly 100000 times on a test file.
The result was:
2.6.26
330 sec
2.6.26-patched
226 sec
Arch:i386
Filesystem:ext3
Blocksize:1024 bytes
Memory: 1GB
On ext3/4, a file is written through buffer/block. So random read/write
mixed workloads or random read after random write workloads are optimized
with this patch under pagesize != blocksize environment. This test result
showed this.
The benchmark program is as follows:
#include <stdio.h>
#include <sys/types.h>
#include <sys/stat.h>
#include <fcntl.h>
#include <unistd.h>
#include <time.h>
#include <stdlib.h>
#include <string.h>
#include <sys/mount.h>
#define LEN 1024
#define LOOP 1024*512 /* 512MB */
main(void)
{
unsigned long i, offset, filesize;
int fd;
char buf[LEN];
time_t t1, t2;
if (mount("/dev/sda1", "/root/test1/", "ext3", 0, 0) < 0) {
perror("cannot mount\n");
exit(1);
}
memset(buf, 0, LEN);
fd = open("/root/test1/testfile", O_CREAT|O_RDWR|O_TRUNC);
if (fd < 0) {
perror("cannot open file\n");
exit(1);
}
for (i = 0; i < LOOP; i++)
write(fd, buf, LEN);
close(fd);
if (umount("/root/test1/") < 0) {
perror("cannot umount\n");
exit(1);
}
if (mount("/dev/sda1", "/root/test1/", "ext3", 0, 0) < 0) {
perror("cannot mount\n");
exit(1);
}
fd = open("/root/test1/testfile", O_RDWR);
if (fd < 0) {
perror("cannot open file\n");
exit(1);
}
filesize = LEN * LOOP;
for (i = 0; i < 300000; i++){
offset = (random() % filesize) & (~(LEN - 1));
pwrite(fd, buf, LEN, offset);
}
printf("start test\n");
time(&t1);
for (i = 0; i < 100000; i++){
offset = (random() % filesize) & (~(LEN - 1));
pread(fd, buf, LEN, offset);
}
time(&t2);
printf("%ld sec\n", t2-t1);
close(fd);
if (umount("/root/test1/") < 0) {
perror("cannot umount\n");
exit(1);
}
}
Signed-off-by: Hisashi Hifumi <hifumi.hisashi@oss.ntt.co.jp>
Cc: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Jan Kara <jack@ucw.cz>
Cc: <linux-ext4@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-07-28 22:46:36 +00:00
|
|
|
.bmap = ext4_bmap,
|
2022-02-09 20:21:34 +00:00
|
|
|
.invalidate_folio = ext4_invalidate_folio,
|
2022-05-01 03:33:38 +00:00
|
|
|
.release_folio = ext4_release_folio,
|
2022-06-06 14:20:31 +00:00
|
|
|
.migrate_folio = buffer_migrate_folio,
|
vfs: pagecache usage optimization for pagesize!=blocksize
When we read some part of a file through pagecache, if there is a
pagecache of corresponding index but this page is not uptodate, read IO
is issued and this page will be uptodate.
I think this is good for pagesize == blocksize environment but there is
room for improvement on pagesize != blocksize environment. Because in
this case a page can have multiple buffers and even if a page is not
uptodate, some buffers can be uptodate.
So I suggest that when all buffers which correspond to a part of a file
that we want to read are uptodate, use this pagecache and copy data from
this pagecache to user buffer even if a page is not uptodate. This can
reduce read IO and improve system throughput.
I wrote a benchmark program and got result number with this program.
This benchmark do:
1: mount and open a test file.
2: create a 512MB file.
3: close a file and umount.
4: mount and again open a test file.
5: pwrite randomly 300000 times on a test file. offset is aligned
by IO size(1024bytes).
6: measure time of preading randomly 100000 times on a test file.
The result was:
2.6.26
330 sec
2.6.26-patched
226 sec
Arch:i386
Filesystem:ext3
Blocksize:1024 bytes
Memory: 1GB
On ext3/4, a file is written through buffer/block. So random read/write
mixed workloads or random read after random write workloads are optimized
with this patch under pagesize != blocksize environment. This test result
showed this.
The benchmark program is as follows:
#include <stdio.h>
#include <sys/types.h>
#include <sys/stat.h>
#include <fcntl.h>
#include <unistd.h>
#include <time.h>
#include <stdlib.h>
#include <string.h>
#include <sys/mount.h>
#define LEN 1024
#define LOOP 1024*512 /* 512MB */
main(void)
{
unsigned long i, offset, filesize;
int fd;
char buf[LEN];
time_t t1, t2;
if (mount("/dev/sda1", "/root/test1/", "ext3", 0, 0) < 0) {
perror("cannot mount\n");
exit(1);
}
memset(buf, 0, LEN);
fd = open("/root/test1/testfile", O_CREAT|O_RDWR|O_TRUNC);
if (fd < 0) {
perror("cannot open file\n");
exit(1);
}
for (i = 0; i < LOOP; i++)
write(fd, buf, LEN);
close(fd);
if (umount("/root/test1/") < 0) {
perror("cannot umount\n");
exit(1);
}
if (mount("/dev/sda1", "/root/test1/", "ext3", 0, 0) < 0) {
perror("cannot mount\n");
exit(1);
}
fd = open("/root/test1/testfile", O_RDWR);
if (fd < 0) {
perror("cannot open file\n");
exit(1);
}
filesize = LEN * LOOP;
for (i = 0; i < 300000; i++){
offset = (random() % filesize) & (~(LEN - 1));
pwrite(fd, buf, LEN, offset);
}
printf("start test\n");
time(&t1);
for (i = 0; i < 100000; i++){
offset = (random() % filesize) & (~(LEN - 1));
pread(fd, buf, LEN, offset);
}
time(&t2);
printf("%ld sec\n", t2-t1);
close(fd);
if (umount("/root/test1/") < 0) {
perror("cannot umount\n");
exit(1);
}
}
Signed-off-by: Hisashi Hifumi <hifumi.hisashi@oss.ntt.co.jp>
Cc: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Jan Kara <jack@ucw.cz>
Cc: <linux-ext4@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-07-28 22:46:36 +00:00
|
|
|
.is_partially_uptodate = block_is_partially_uptodate,
|
2023-11-17 16:14:47 +00:00
|
|
|
.error_remove_folio = generic_error_remove_folio,
|
2020-09-04 09:16:53 +00:00
|
|
|
.swap_activate = ext4_iomap_swap_activate,
|
2008-07-11 23:27:31 +00:00
|
|
|
};
|
|
|
|
|
2017-12-21 20:25:11 +00:00
|
|
|
static const struct address_space_operations ext4_dax_aops = {
|
|
|
|
.writepages = ext4_dax_writepages,
|
2022-02-09 20:22:13 +00:00
|
|
|
.dirty_folio = noop_dirty_folio,
|
2018-09-16 01:23:41 +00:00
|
|
|
.bmap = ext4_bmap,
|
2020-09-04 09:16:53 +00:00
|
|
|
.swap_activate = ext4_iomap_swap_activate,
|
2017-12-21 20:25:11 +00:00
|
|
|
};
|
|
|
|
|
2006-10-11 08:20:53 +00:00
|
|
|
void ext4_set_aops(struct inode *inode)
|
2006-10-11 08:20:50 +00:00
|
|
|
{
|
2012-02-20 22:53:00 +00:00
|
|
|
switch (ext4_inode_journal_mode(inode)) {
|
|
|
|
case EXT4_INODE_ORDERED_DATA_MODE:
|
|
|
|
case EXT4_INODE_WRITEBACK_DATA_MODE:
|
|
|
|
break;
|
|
|
|
case EXT4_INODE_JOURNAL_DATA_MODE:
|
2006-10-11 08:20:53 +00:00
|
|
|
inode->i_mapping->a_ops = &ext4_journalled_aops;
|
2013-04-03 16:39:17 +00:00
|
|
|
return;
|
2012-02-20 22:53:00 +00:00
|
|
|
default:
|
|
|
|
BUG();
|
|
|
|
}
|
2017-12-21 20:25:11 +00:00
|
|
|
if (IS_DAX(inode))
|
|
|
|
inode->i_mapping->a_ops = &ext4_dax_aops;
|
|
|
|
else if (test_opt(inode->i_sb, DELALLOC))
|
2013-04-03 16:39:17 +00:00
|
|
|
inode->i_mapping->a_ops = &ext4_da_aops;
|
|
|
|
else
|
|
|
|
inode->i_mapping->a_ops = &ext4_aops;
|
2006-10-11 08:20:50 +00:00
|
|
|
}
|
|
|
|
|
2023-11-01 16:38:11 +00:00
|
|
|
/*
|
|
|
|
* Here we can't skip an unwritten buffer even though it usually reads zero
|
|
|
|
* because it might have data in pagecache (eg, if called from ext4_zero_range,
|
|
|
|
* ext4_punch_hole, etc) which needs to be properly zeroed out. Otherwise a
|
|
|
|
* racing writeback can come later and flush the stale pagecache to disk.
|
|
|
|
*/
|
2015-02-16 23:59:38 +00:00
|
|
|
static int __ext4_block_zero_page_range(handle_t *handle,
|
2013-05-28 03:32:35 +00:00
|
|
|
struct address_space *mapping, loff_t from, loff_t length)
|
|
|
|
{
|
mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros
PAGE_CACHE_{SIZE,SHIFT,MASK,ALIGN} macros were introduced *long* time
ago with promise that one day it will be possible to implement page
cache with bigger chunks than PAGE_SIZE.
This promise never materialized. And unlikely will.
We have many places where PAGE_CACHE_SIZE assumed to be equal to
PAGE_SIZE. And it's constant source of confusion on whether
PAGE_CACHE_* or PAGE_* constant should be used in a particular case,
especially on the border between fs and mm.
Global switching to PAGE_CACHE_SIZE != PAGE_SIZE would cause to much
breakage to be doable.
Let's stop pretending that pages in page cache are special. They are
not.
The changes are pretty straight-forward:
- <foo> << (PAGE_CACHE_SHIFT - PAGE_SHIFT) -> <foo>;
- <foo> >> (PAGE_CACHE_SHIFT - PAGE_SHIFT) -> <foo>;
- PAGE_CACHE_{SIZE,SHIFT,MASK,ALIGN} -> PAGE_{SIZE,SHIFT,MASK,ALIGN};
- page_cache_get() -> get_page();
- page_cache_release() -> put_page();
This patch contains automated changes generated with coccinelle using
script below. For some reason, coccinelle doesn't patch header files.
I've called spatch for them manually.
The only adjustment after coccinelle is revert of changes to
PAGE_CAHCE_ALIGN definition: we are going to drop it later.
There are few places in the code where coccinelle didn't reach. I'll
fix them manually in a separate patch. Comments and documentation also
will be addressed with the separate patch.
virtual patch
@@
expression E;
@@
- E << (PAGE_CACHE_SHIFT - PAGE_SHIFT)
+ E
@@
expression E;
@@
- E >> (PAGE_CACHE_SHIFT - PAGE_SHIFT)
+ E
@@
@@
- PAGE_CACHE_SHIFT
+ PAGE_SHIFT
@@
@@
- PAGE_CACHE_SIZE
+ PAGE_SIZE
@@
@@
- PAGE_CACHE_MASK
+ PAGE_MASK
@@
expression E;
@@
- PAGE_CACHE_ALIGN(E)
+ PAGE_ALIGN(E)
@@
expression E;
@@
- page_cache_get(E)
+ get_page(E)
@@
expression E;
@@
- page_cache_release(E)
+ put_page(E)
Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Acked-by: Michal Hocko <mhocko@suse.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2016-04-01 12:29:47 +00:00
|
|
|
ext4_fsblk_t index = from >> PAGE_SHIFT;
|
|
|
|
unsigned offset = from & (PAGE_SIZE-1);
|
2015-02-16 23:59:38 +00:00
|
|
|
unsigned blocksize, pos;
|
2013-05-28 03:32:35 +00:00
|
|
|
ext4_lblk_t iblock;
|
|
|
|
struct inode *inode = mapping->host;
|
|
|
|
struct buffer_head *bh;
|
2023-03-24 18:01:20 +00:00
|
|
|
struct folio *folio;
|
2013-05-28 03:32:35 +00:00
|
|
|
int err = 0;
|
|
|
|
|
2023-03-24 18:01:20 +00:00
|
|
|
folio = __filemap_get_folio(mapping, from >> PAGE_SHIFT,
|
|
|
|
FGP_LOCK | FGP_ACCESSED | FGP_CREAT,
|
|
|
|
mapping_gfp_constraint(mapping, ~__GFP_FS));
|
- Nick Piggin's "shoot lazy tlbs" series, to improve the peformance of
switching from a user process to a kernel thread.
- More folio conversions from Kefeng Wang, Zhang Peng and Pankaj Raghav.
- zsmalloc performance improvements from Sergey Senozhatsky.
- Yue Zhao has found and fixed some data race issues around the
alteration of memcg userspace tunables.
- VFS rationalizations from Christoph Hellwig:
- removal of most of the callers of write_one_page().
- make __filemap_get_folio()'s return value more useful
- Luis Chamberlain has changed tmpfs so it no longer requires swap
backing. Use `mount -o noswap'.
- Qi Zheng has made the slab shrinkers operate locklessly, providing
some scalability benefits.
- Keith Busch has improved dmapool's performance, making part of its
operations O(1) rather than O(n).
- Peter Xu adds the UFFD_FEATURE_WP_UNPOPULATED feature to userfaultd,
permitting userspace to wr-protect anon memory unpopulated ptes.
- Kirill Shutemov has changed MAX_ORDER's meaning to be inclusive rather
than exclusive, and has fixed a bunch of errors which were caused by its
unintuitive meaning.
- Axel Rasmussen give userfaultfd the UFFDIO_CONTINUE_MODE_WP feature,
which causes minor faults to install a write-protected pte.
- Vlastimil Babka has done some maintenance work on vma_merge():
cleanups to the kernel code and improvements to our userspace test
harness.
- Cleanups to do_fault_around() by Lorenzo Stoakes.
- Mike Rapoport has moved a lot of initialization code out of various
mm/ files and into mm/mm_init.c.
- Lorenzo Stoakes removd vmf_insert_mixed_prot(), which was added for
DRM, but DRM doesn't use it any more.
- Lorenzo has also coverted read_kcore() and vread() to use iterators
and has thereby removed the use of bounce buffers in some cases.
- Lorenzo has also contributed further cleanups of vma_merge().
- Chaitanya Prakash provides some fixes to the mmap selftesting code.
- Matthew Wilcox changes xfs and afs so they no longer take sleeping
locks in ->map_page(), a step towards RCUification of pagefaults.
- Suren Baghdasaryan has improved mmap_lock scalability by switching to
per-VMA locking.
- Frederic Weisbecker has reworked the percpu cache draining so that it
no longer causes latency glitches on cpu isolated workloads.
- Mike Rapoport cleans up and corrects the ARCH_FORCE_MAX_ORDER Kconfig
logic.
- Liu Shixin has changed zswap's initialization so we no longer waste a
chunk of memory if zswap is not being used.
- Yosry Ahmed has improved the performance of memcg statistics flushing.
- David Stevens has fixed several issues involving khugepaged,
userfaultfd and shmem.
- Christoph Hellwig has provided some cleanup work to zram's IO-related
code paths.
- David Hildenbrand has fixed up some issues in the selftest code's
testing of our pte state changing.
- Pankaj Raghav has made page_endio() unneeded and has removed it.
- Peter Xu contributed some rationalizations of the userfaultfd
selftests.
- Yosry Ahmed has fixed an issue around memcg's page recalim accounting.
- Chaitanya Prakash has fixed some arm-related issues in the
selftests/mm code.
- Longlong Xia has improved the way in which KSM handles hwpoisoned
pages.
- Peter Xu fixes a few issues with uffd-wp at fork() time.
- Stefan Roesch has changed KSM so that it may now be used on a
per-process and per-cgroup basis.
-----BEGIN PGP SIGNATURE-----
iHUEABYIAB0WIQTTMBEPP41GrTpTJgfdBJ7gKXxAjgUCZEr3zQAKCRDdBJ7gKXxA
jlLoAP0fpQBipwFxED0Us4SKQfupV6z4caXNJGPeay7Aj11/kQD/aMRC2uPfgr96
eMG3kwn2pqkB9ST2QpkaRbxA//eMbQY=
=J+Dj
-----END PGP SIGNATURE-----
Merge tag 'mm-stable-2023-04-27-15-30' of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
Pull MM updates from Andrew Morton:
- Nick Piggin's "shoot lazy tlbs" series, to improve the peformance of
switching from a user process to a kernel thread.
- More folio conversions from Kefeng Wang, Zhang Peng and Pankaj
Raghav.
- zsmalloc performance improvements from Sergey Senozhatsky.
- Yue Zhao has found and fixed some data race issues around the
alteration of memcg userspace tunables.
- VFS rationalizations from Christoph Hellwig:
- removal of most of the callers of write_one_page()
- make __filemap_get_folio()'s return value more useful
- Luis Chamberlain has changed tmpfs so it no longer requires swap
backing. Use `mount -o noswap'.
- Qi Zheng has made the slab shrinkers operate locklessly, providing
some scalability benefits.
- Keith Busch has improved dmapool's performance, making part of its
operations O(1) rather than O(n).
- Peter Xu adds the UFFD_FEATURE_WP_UNPOPULATED feature to userfaultd,
permitting userspace to wr-protect anon memory unpopulated ptes.
- Kirill Shutemov has changed MAX_ORDER's meaning to be inclusive
rather than exclusive, and has fixed a bunch of errors which were
caused by its unintuitive meaning.
- Axel Rasmussen give userfaultfd the UFFDIO_CONTINUE_MODE_WP feature,
which causes minor faults to install a write-protected pte.
- Vlastimil Babka has done some maintenance work on vma_merge():
cleanups to the kernel code and improvements to our userspace test
harness.
- Cleanups to do_fault_around() by Lorenzo Stoakes.
- Mike Rapoport has moved a lot of initialization code out of various
mm/ files and into mm/mm_init.c.
- Lorenzo Stoakes removd vmf_insert_mixed_prot(), which was added for
DRM, but DRM doesn't use it any more.
- Lorenzo has also coverted read_kcore() and vread() to use iterators
and has thereby removed the use of bounce buffers in some cases.
- Lorenzo has also contributed further cleanups of vma_merge().
- Chaitanya Prakash provides some fixes to the mmap selftesting code.
- Matthew Wilcox changes xfs and afs so they no longer take sleeping
locks in ->map_page(), a step towards RCUification of pagefaults.
- Suren Baghdasaryan has improved mmap_lock scalability by switching to
per-VMA locking.
- Frederic Weisbecker has reworked the percpu cache draining so that it
no longer causes latency glitches on cpu isolated workloads.
- Mike Rapoport cleans up and corrects the ARCH_FORCE_MAX_ORDER Kconfig
logic.
- Liu Shixin has changed zswap's initialization so we no longer waste a
chunk of memory if zswap is not being used.
- Yosry Ahmed has improved the performance of memcg statistics
flushing.
- David Stevens has fixed several issues involving khugepaged,
userfaultfd and shmem.
- Christoph Hellwig has provided some cleanup work to zram's IO-related
code paths.
- David Hildenbrand has fixed up some issues in the selftest code's
testing of our pte state changing.
- Pankaj Raghav has made page_endio() unneeded and has removed it.
- Peter Xu contributed some rationalizations of the userfaultfd
selftests.
- Yosry Ahmed has fixed an issue around memcg's page recalim
accounting.
- Chaitanya Prakash has fixed some arm-related issues in the
selftests/mm code.
- Longlong Xia has improved the way in which KSM handles hwpoisoned
pages.
- Peter Xu fixes a few issues with uffd-wp at fork() time.
- Stefan Roesch has changed KSM so that it may now be used on a
per-process and per-cgroup basis.
* tag 'mm-stable-2023-04-27-15-30' of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm: (369 commits)
mm,unmap: avoid flushing TLB in batch if PTE is inaccessible
shmem: restrict noswap option to initial user namespace
mm/khugepaged: fix conflicting mods to collapse_file()
sparse: remove unnecessary 0 values from rc
mm: move 'mmap_min_addr' logic from callers into vm_unmapped_area()
hugetlb: pte_alloc_huge() to replace huge pte_alloc_map()
maple_tree: fix allocation in mas_sparse_area()
mm: do not increment pgfault stats when page fault handler retries
zsmalloc: allow only one active pool compaction context
selftests/mm: add new selftests for KSM
mm: add new KSM process and sysfs knobs
mm: add new api to enable ksm per process
mm: shrinkers: fix debugfs file permissions
mm: don't check VMA write permissions if the PTE/PMD indicates write permissions
migrate_pages_batch: fix statistics for longterm pin retry
userfaultfd: use helper function range_in_vma()
lib/show_mem.c: use for_each_populated_zone() simplify code
mm: correct arg in reclaim_pages()/reclaim_clean_pages_from_list()
fs/buffer: convert create_page_buffers to folio_create_buffers
fs/buffer: add folio_create_empty_buffers helper
...
2023-04-28 02:42:02 +00:00
|
|
|
if (IS_ERR(folio))
|
|
|
|
return PTR_ERR(folio);
|
2013-05-28 03:32:35 +00:00
|
|
|
|
|
|
|
blocksize = inode->i_sb->s_blocksize;
|
|
|
|
|
mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros
PAGE_CACHE_{SIZE,SHIFT,MASK,ALIGN} macros were introduced *long* time
ago with promise that one day it will be possible to implement page
cache with bigger chunks than PAGE_SIZE.
This promise never materialized. And unlikely will.
We have many places where PAGE_CACHE_SIZE assumed to be equal to
PAGE_SIZE. And it's constant source of confusion on whether
PAGE_CACHE_* or PAGE_* constant should be used in a particular case,
especially on the border between fs and mm.
Global switching to PAGE_CACHE_SIZE != PAGE_SIZE would cause to much
breakage to be doable.
Let's stop pretending that pages in page cache are special. They are
not.
The changes are pretty straight-forward:
- <foo> << (PAGE_CACHE_SHIFT - PAGE_SHIFT) -> <foo>;
- <foo> >> (PAGE_CACHE_SHIFT - PAGE_SHIFT) -> <foo>;
- PAGE_CACHE_{SIZE,SHIFT,MASK,ALIGN} -> PAGE_{SIZE,SHIFT,MASK,ALIGN};
- page_cache_get() -> get_page();
- page_cache_release() -> put_page();
This patch contains automated changes generated with coccinelle using
script below. For some reason, coccinelle doesn't patch header files.
I've called spatch for them manually.
The only adjustment after coccinelle is revert of changes to
PAGE_CAHCE_ALIGN definition: we are going to drop it later.
There are few places in the code where coccinelle didn't reach. I'll
fix them manually in a separate patch. Comments and documentation also
will be addressed with the separate patch.
virtual patch
@@
expression E;
@@
- E << (PAGE_CACHE_SHIFT - PAGE_SHIFT)
+ E
@@
expression E;
@@
- E >> (PAGE_CACHE_SHIFT - PAGE_SHIFT)
+ E
@@
@@
- PAGE_CACHE_SHIFT
+ PAGE_SHIFT
@@
@@
- PAGE_CACHE_SIZE
+ PAGE_SIZE
@@
@@
- PAGE_CACHE_MASK
+ PAGE_MASK
@@
expression E;
@@
- PAGE_CACHE_ALIGN(E)
+ PAGE_ALIGN(E)
@@
expression E;
@@
- page_cache_get(E)
+ get_page(E)
@@
expression E;
@@
- page_cache_release(E)
+ put_page(E)
Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Acked-by: Michal Hocko <mhocko@suse.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2016-04-01 12:29:47 +00:00
|
|
|
iblock = index << (PAGE_SHIFT - inode->i_sb->s_blocksize_bits);
|
2013-05-28 03:32:35 +00:00
|
|
|
|
2023-03-24 18:01:20 +00:00
|
|
|
bh = folio_buffers(folio);
|
2023-10-16 20:10:51 +00:00
|
|
|
if (!bh)
|
2023-10-16 20:11:14 +00:00
|
|
|
bh = create_empty_buffers(folio, blocksize, 0);
|
2013-05-28 03:32:35 +00:00
|
|
|
|
|
|
|
/* Find the buffer that contains "offset" */
|
|
|
|
pos = blocksize;
|
|
|
|
while (offset >= pos) {
|
|
|
|
bh = bh->b_this_page;
|
|
|
|
iblock++;
|
|
|
|
pos += blocksize;
|
|
|
|
}
|
|
|
|
if (buffer_freed(bh)) {
|
|
|
|
BUFFER_TRACE(bh, "freed: skip");
|
|
|
|
goto unlock;
|
|
|
|
}
|
|
|
|
if (!buffer_mapped(bh)) {
|
|
|
|
BUFFER_TRACE(bh, "unmapped");
|
|
|
|
ext4_get_block(inode, iblock, bh, 0);
|
|
|
|
/* unmapped? It's a hole - nothing to do */
|
|
|
|
if (!buffer_mapped(bh)) {
|
|
|
|
BUFFER_TRACE(bh, "still unmapped");
|
|
|
|
goto unlock;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Ok, it's mapped. Make sure it's up-to-date */
|
2023-03-24 18:01:20 +00:00
|
|
|
if (folio_test_uptodate(folio))
|
2013-05-28 03:32:35 +00:00
|
|
|
set_buffer_uptodate(bh);
|
|
|
|
|
|
|
|
if (!buffer_uptodate(bh)) {
|
2020-09-24 07:33:33 +00:00
|
|
|
err = ext4_read_bh_lock(bh, 0, true);
|
|
|
|
if (err)
|
2013-05-28 03:32:35 +00:00
|
|
|
goto unlock;
|
2020-07-02 01:56:07 +00:00
|
|
|
if (fscrypt_inode_uses_fs_layer_crypto(inode)) {
|
2015-04-12 04:56:10 +00:00
|
|
|
/* We expect the key to be set. */
|
2016-07-10 18:01:03 +00:00
|
|
|
BUG_ON(!fscrypt_has_encryption_key(inode));
|
2023-03-24 18:01:20 +00:00
|
|
|
err = fscrypt_decrypt_pagecache_blocks(folio,
|
2023-01-27 22:25:14 +00:00
|
|
|
blocksize,
|
2019-12-26 15:41:05 +00:00
|
|
|
bh_offset(bh));
|
|
|
|
if (err) {
|
|
|
|
clear_buffer_uptodate(bh);
|
|
|
|
goto unlock;
|
|
|
|
}
|
2015-04-12 04:56:10 +00:00
|
|
|
}
|
2013-05-28 03:32:35 +00:00
|
|
|
}
|
|
|
|
if (ext4_should_journal_data(inode)) {
|
|
|
|
BUFFER_TRACE(bh, "get write access");
|
2021-08-16 09:57:04 +00:00
|
|
|
err = ext4_journal_get_write_access(handle, inode->i_sb, bh,
|
|
|
|
EXT4_JTR_NONE);
|
2013-05-28 03:32:35 +00:00
|
|
|
if (err)
|
|
|
|
goto unlock;
|
|
|
|
}
|
2023-03-24 18:01:20 +00:00
|
|
|
folio_zero_range(folio, offset, length);
|
2013-05-28 03:32:35 +00:00
|
|
|
BUFFER_TRACE(bh, "zeroed end of block");
|
|
|
|
|
|
|
|
if (ext4_should_journal_data(inode)) {
|
2023-03-29 15:49:33 +00:00
|
|
|
err = ext4_dirty_journalled_data(handle, bh);
|
2013-05-28 03:32:35 +00:00
|
|
|
} else {
|
2013-07-01 12:12:39 +00:00
|
|
|
err = 0;
|
2013-05-28 03:32:35 +00:00
|
|
|
mark_buffer_dirty(bh);
|
2016-04-24 04:56:05 +00:00
|
|
|
if (ext4_should_order_data(inode))
|
2019-06-20 21:26:26 +00:00
|
|
|
err = ext4_jbd2_inode_add_write(handle, inode, from,
|
|
|
|
length);
|
2013-05-28 03:32:35 +00:00
|
|
|
}
|
2013-05-28 03:32:35 +00:00
|
|
|
|
|
|
|
unlock:
|
2023-03-24 18:01:20 +00:00
|
|
|
folio_unlock(folio);
|
|
|
|
folio_put(folio);
|
2013-05-28 03:32:35 +00:00
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
2015-02-16 23:59:38 +00:00
|
|
|
/*
|
|
|
|
* ext4_block_zero_page_range() zeros out a mapping of length 'length'
|
|
|
|
* starting from file offset 'from'. The range to be zero'd must
|
|
|
|
* be contained with in one block. If the specified range exceeds
|
|
|
|
* the end of the block it will be shortened to end of the block
|
2021-03-27 10:30:05 +00:00
|
|
|
* that corresponds to 'from'
|
2015-02-16 23:59:38 +00:00
|
|
|
*/
|
|
|
|
static int ext4_block_zero_page_range(handle_t *handle,
|
|
|
|
struct address_space *mapping, loff_t from, loff_t length)
|
|
|
|
{
|
|
|
|
struct inode *inode = mapping->host;
|
mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros
PAGE_CACHE_{SIZE,SHIFT,MASK,ALIGN} macros were introduced *long* time
ago with promise that one day it will be possible to implement page
cache with bigger chunks than PAGE_SIZE.
This promise never materialized. And unlikely will.
We have many places where PAGE_CACHE_SIZE assumed to be equal to
PAGE_SIZE. And it's constant source of confusion on whether
PAGE_CACHE_* or PAGE_* constant should be used in a particular case,
especially on the border between fs and mm.
Global switching to PAGE_CACHE_SIZE != PAGE_SIZE would cause to much
breakage to be doable.
Let's stop pretending that pages in page cache are special. They are
not.
The changes are pretty straight-forward:
- <foo> << (PAGE_CACHE_SHIFT - PAGE_SHIFT) -> <foo>;
- <foo> >> (PAGE_CACHE_SHIFT - PAGE_SHIFT) -> <foo>;
- PAGE_CACHE_{SIZE,SHIFT,MASK,ALIGN} -> PAGE_{SIZE,SHIFT,MASK,ALIGN};
- page_cache_get() -> get_page();
- page_cache_release() -> put_page();
This patch contains automated changes generated with coccinelle using
script below. For some reason, coccinelle doesn't patch header files.
I've called spatch for them manually.
The only adjustment after coccinelle is revert of changes to
PAGE_CAHCE_ALIGN definition: we are going to drop it later.
There are few places in the code where coccinelle didn't reach. I'll
fix them manually in a separate patch. Comments and documentation also
will be addressed with the separate patch.
virtual patch
@@
expression E;
@@
- E << (PAGE_CACHE_SHIFT - PAGE_SHIFT)
+ E
@@
expression E;
@@
- E >> (PAGE_CACHE_SHIFT - PAGE_SHIFT)
+ E
@@
@@
- PAGE_CACHE_SHIFT
+ PAGE_SHIFT
@@
@@
- PAGE_CACHE_SIZE
+ PAGE_SIZE
@@
@@
- PAGE_CACHE_MASK
+ PAGE_MASK
@@
expression E;
@@
- PAGE_CACHE_ALIGN(E)
+ PAGE_ALIGN(E)
@@
expression E;
@@
- page_cache_get(E)
+ get_page(E)
@@
expression E;
@@
- page_cache_release(E)
+ put_page(E)
Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Acked-by: Michal Hocko <mhocko@suse.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2016-04-01 12:29:47 +00:00
|
|
|
unsigned offset = from & (PAGE_SIZE-1);
|
2015-02-16 23:59:38 +00:00
|
|
|
unsigned blocksize = inode->i_sb->s_blocksize;
|
|
|
|
unsigned max = blocksize - (offset & (blocksize - 1));
|
|
|
|
|
|
|
|
/*
|
|
|
|
* correct length if it does not fall between
|
|
|
|
* 'from' and the end of the block
|
|
|
|
*/
|
|
|
|
if (length > max || length < 0)
|
|
|
|
length = max;
|
|
|
|
|
2016-11-20 23:08:05 +00:00
|
|
|
if (IS_DAX(inode)) {
|
2021-11-29 10:21:52 +00:00
|
|
|
return dax_zero_range(inode, from, length, NULL,
|
|
|
|
&ext4_iomap_ops);
|
2016-11-20 23:08:05 +00:00
|
|
|
}
|
2015-02-16 23:59:38 +00:00
|
|
|
return __ext4_block_zero_page_range(handle, mapping, from, length);
|
|
|
|
}
|
|
|
|
|
2014-03-24 19:09:16 +00:00
|
|
|
/*
|
|
|
|
* ext4_block_truncate_page() zeroes out a mapping from file offset `from'
|
|
|
|
* up to the end of the block which corresponds to `from'.
|
|
|
|
* This required during truncate. We need to physically zero the tail end
|
|
|
|
* of that block so it doesn't yield old data if the file is later grown.
|
|
|
|
*/
|
2014-05-12 14:50:23 +00:00
|
|
|
static int ext4_block_truncate_page(handle_t *handle,
|
2014-03-24 19:09:16 +00:00
|
|
|
struct address_space *mapping, loff_t from)
|
|
|
|
{
|
mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros
PAGE_CACHE_{SIZE,SHIFT,MASK,ALIGN} macros were introduced *long* time
ago with promise that one day it will be possible to implement page
cache with bigger chunks than PAGE_SIZE.
This promise never materialized. And unlikely will.
We have many places where PAGE_CACHE_SIZE assumed to be equal to
PAGE_SIZE. And it's constant source of confusion on whether
PAGE_CACHE_* or PAGE_* constant should be used in a particular case,
especially on the border between fs and mm.
Global switching to PAGE_CACHE_SIZE != PAGE_SIZE would cause to much
breakage to be doable.
Let's stop pretending that pages in page cache are special. They are
not.
The changes are pretty straight-forward:
- <foo> << (PAGE_CACHE_SHIFT - PAGE_SHIFT) -> <foo>;
- <foo> >> (PAGE_CACHE_SHIFT - PAGE_SHIFT) -> <foo>;
- PAGE_CACHE_{SIZE,SHIFT,MASK,ALIGN} -> PAGE_{SIZE,SHIFT,MASK,ALIGN};
- page_cache_get() -> get_page();
- page_cache_release() -> put_page();
This patch contains automated changes generated with coccinelle using
script below. For some reason, coccinelle doesn't patch header files.
I've called spatch for them manually.
The only adjustment after coccinelle is revert of changes to
PAGE_CAHCE_ALIGN definition: we are going to drop it later.
There are few places in the code where coccinelle didn't reach. I'll
fix them manually in a separate patch. Comments and documentation also
will be addressed with the separate patch.
virtual patch
@@
expression E;
@@
- E << (PAGE_CACHE_SHIFT - PAGE_SHIFT)
+ E
@@
expression E;
@@
- E >> (PAGE_CACHE_SHIFT - PAGE_SHIFT)
+ E
@@
@@
- PAGE_CACHE_SHIFT
+ PAGE_SHIFT
@@
@@
- PAGE_CACHE_SIZE
+ PAGE_SIZE
@@
@@
- PAGE_CACHE_MASK
+ PAGE_MASK
@@
expression E;
@@
- PAGE_CACHE_ALIGN(E)
+ PAGE_ALIGN(E)
@@
expression E;
@@
- page_cache_get(E)
+ get_page(E)
@@
expression E;
@@
- page_cache_release(E)
+ put_page(E)
Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Acked-by: Michal Hocko <mhocko@suse.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2016-04-01 12:29:47 +00:00
|
|
|
unsigned offset = from & (PAGE_SIZE-1);
|
2014-03-24 19:09:16 +00:00
|
|
|
unsigned length;
|
|
|
|
unsigned blocksize;
|
|
|
|
struct inode *inode = mapping->host;
|
|
|
|
|
ext4: don't BUG when truncating encrypted inodes on the orphan list
Fix a BUG when the kernel tries to mount a file system constructed as
follows:
echo foo > foo.txt
mke2fs -Fq -t ext4 -O encrypt foo.img 100
debugfs -w foo.img << EOF
write foo.txt a
set_inode_field a i_flags 0x80800
set_super_value s_last_orphan 12
quit
EOF
root@kvm-xfstests:~# mount -o loop foo.img /mnt
[ 160.238770] ------------[ cut here ]------------
[ 160.240106] kernel BUG at /usr/projects/linux/ext4/fs/ext4/inode.c:3874!
[ 160.240106] invalid opcode: 0000 [#1] SMP
[ 160.240106] Modules linked in:
[ 160.240106] CPU: 0 PID: 2547 Comm: mount Tainted: G W 4.10.0-rc3-00034-gcdd33b941b67 #227
[ 160.240106] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.10.1-1 04/01/2014
[ 160.240106] task: f4518000 task.stack: f47b6000
[ 160.240106] EIP: ext4_block_zero_page_range+0x1a7/0x2b4
[ 160.240106] EFLAGS: 00010246 CPU: 0
[ 160.240106] EAX: 00000001 EBX: f7be4b50 ECX: f47b7dc0 EDX: 00000007
[ 160.240106] ESI: f43b05a8 EDI: f43babec EBP: f47b7dd0 ESP: f47b7dac
[ 160.240106] DS: 007b ES: 007b FS: 00d8 GS: 0033 SS: 0068
[ 160.240106] CR0: 80050033 CR2: bfd85b08 CR3: 34a00680 CR4: 000006f0
[ 160.240106] Call Trace:
[ 160.240106] ext4_truncate+0x1e9/0x3e5
[ 160.240106] ext4_fill_super+0x286f/0x2b1e
[ 160.240106] ? set_blocksize+0x2e/0x7e
[ 160.240106] mount_bdev+0x114/0x15f
[ 160.240106] ext4_mount+0x15/0x17
[ 160.240106] ? ext4_calculate_overhead+0x39d/0x39d
[ 160.240106] mount_fs+0x58/0x115
[ 160.240106] vfs_kern_mount+0x4b/0xae
[ 160.240106] do_mount+0x671/0x8c3
[ 160.240106] ? _copy_from_user+0x70/0x83
[ 160.240106] ? strndup_user+0x31/0x46
[ 160.240106] SyS_mount+0x57/0x7b
[ 160.240106] do_int80_syscall_32+0x4f/0x61
[ 160.240106] entry_INT80_32+0x2f/0x2f
[ 160.240106] EIP: 0xb76b919e
[ 160.240106] EFLAGS: 00000246 CPU: 0
[ 160.240106] EAX: ffffffda EBX: 08053838 ECX: 08052188 EDX: 080537e8
[ 160.240106] ESI: c0ed0000 EDI: 00000000 EBP: 080537e8 ESP: bfa13660
[ 160.240106] DS: 007b ES: 007b FS: 0000 GS: 0033 SS: 007b
[ 160.240106] Code: 59 8b 00 a8 01 0f 84 09 01 00 00 8b 07 66 25 00 f0 66 3d 00 80 75 61 89 f8 e8 3e e2 ff ff 84 c0 74 56 83 bf 48 02 00 00 00 75 02 <0f> 0b 81 7d e8 00 10 00 00 74 02 0f 0b 8b 43 04 8b 53 08 31 c9
[ 160.240106] EIP: ext4_block_zero_page_range+0x1a7/0x2b4 SS:ESP: 0068:f47b7dac
[ 160.317241] ---[ end trace d6a773a375c810a5 ]---
The problem is that when the kernel tries to truncate an inode in
ext4_truncate(), it tries to clear any on-disk data beyond i_size.
Without the encryption key, it can't do that, and so it triggers a
BUG.
E2fsck does *not* provide this service, and in practice most file
systems have their orphan list processed by e2fsck, so to avoid
crashing, this patch skips this step if we don't have access to the
encryption key (which is the case when processing the orphan list; in
all other cases, we will have the encryption key, or the kernel
wouldn't have allowed the file to be opened).
An open question is whether the fact that e2fsck isn't clearing the
bytes beyond i_size causing problems --- and if we've lived with it
not doing it for so long, can we drop this from the kernel replay of
the orphan list in all cases (not just when we don't have the key for
encrypted inodes).
Addresses-Google-Bug: #35209576
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
2017-02-14 16:31:15 +00:00
|
|
|
/* If we are processing an encrypted inode during orphan list handling */
|
2018-12-12 09:50:10 +00:00
|
|
|
if (IS_ENCRYPTED(inode) && !fscrypt_has_encryption_key(inode))
|
ext4: don't BUG when truncating encrypted inodes on the orphan list
Fix a BUG when the kernel tries to mount a file system constructed as
follows:
echo foo > foo.txt
mke2fs -Fq -t ext4 -O encrypt foo.img 100
debugfs -w foo.img << EOF
write foo.txt a
set_inode_field a i_flags 0x80800
set_super_value s_last_orphan 12
quit
EOF
root@kvm-xfstests:~# mount -o loop foo.img /mnt
[ 160.238770] ------------[ cut here ]------------
[ 160.240106] kernel BUG at /usr/projects/linux/ext4/fs/ext4/inode.c:3874!
[ 160.240106] invalid opcode: 0000 [#1] SMP
[ 160.240106] Modules linked in:
[ 160.240106] CPU: 0 PID: 2547 Comm: mount Tainted: G W 4.10.0-rc3-00034-gcdd33b941b67 #227
[ 160.240106] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.10.1-1 04/01/2014
[ 160.240106] task: f4518000 task.stack: f47b6000
[ 160.240106] EIP: ext4_block_zero_page_range+0x1a7/0x2b4
[ 160.240106] EFLAGS: 00010246 CPU: 0
[ 160.240106] EAX: 00000001 EBX: f7be4b50 ECX: f47b7dc0 EDX: 00000007
[ 160.240106] ESI: f43b05a8 EDI: f43babec EBP: f47b7dd0 ESP: f47b7dac
[ 160.240106] DS: 007b ES: 007b FS: 00d8 GS: 0033 SS: 0068
[ 160.240106] CR0: 80050033 CR2: bfd85b08 CR3: 34a00680 CR4: 000006f0
[ 160.240106] Call Trace:
[ 160.240106] ext4_truncate+0x1e9/0x3e5
[ 160.240106] ext4_fill_super+0x286f/0x2b1e
[ 160.240106] ? set_blocksize+0x2e/0x7e
[ 160.240106] mount_bdev+0x114/0x15f
[ 160.240106] ext4_mount+0x15/0x17
[ 160.240106] ? ext4_calculate_overhead+0x39d/0x39d
[ 160.240106] mount_fs+0x58/0x115
[ 160.240106] vfs_kern_mount+0x4b/0xae
[ 160.240106] do_mount+0x671/0x8c3
[ 160.240106] ? _copy_from_user+0x70/0x83
[ 160.240106] ? strndup_user+0x31/0x46
[ 160.240106] SyS_mount+0x57/0x7b
[ 160.240106] do_int80_syscall_32+0x4f/0x61
[ 160.240106] entry_INT80_32+0x2f/0x2f
[ 160.240106] EIP: 0xb76b919e
[ 160.240106] EFLAGS: 00000246 CPU: 0
[ 160.240106] EAX: ffffffda EBX: 08053838 ECX: 08052188 EDX: 080537e8
[ 160.240106] ESI: c0ed0000 EDI: 00000000 EBP: 080537e8 ESP: bfa13660
[ 160.240106] DS: 007b ES: 007b FS: 0000 GS: 0033 SS: 007b
[ 160.240106] Code: 59 8b 00 a8 01 0f 84 09 01 00 00 8b 07 66 25 00 f0 66 3d 00 80 75 61 89 f8 e8 3e e2 ff ff 84 c0 74 56 83 bf 48 02 00 00 00 75 02 <0f> 0b 81 7d e8 00 10 00 00 74 02 0f 0b 8b 43 04 8b 53 08 31 c9
[ 160.240106] EIP: ext4_block_zero_page_range+0x1a7/0x2b4 SS:ESP: 0068:f47b7dac
[ 160.317241] ---[ end trace d6a773a375c810a5 ]---
The problem is that when the kernel tries to truncate an inode in
ext4_truncate(), it tries to clear any on-disk data beyond i_size.
Without the encryption key, it can't do that, and so it triggers a
BUG.
E2fsck does *not* provide this service, and in practice most file
systems have their orphan list processed by e2fsck, so to avoid
crashing, this patch skips this step if we don't have access to the
encryption key (which is the case when processing the orphan list; in
all other cases, we will have the encryption key, or the kernel
wouldn't have allowed the file to be opened).
An open question is whether the fact that e2fsck isn't clearing the
bytes beyond i_size causing problems --- and if we've lived with it
not doing it for so long, can we drop this from the kernel replay of
the orphan list in all cases (not just when we don't have the key for
encrypted inodes).
Addresses-Google-Bug: #35209576
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
2017-02-14 16:31:15 +00:00
|
|
|
return 0;
|
|
|
|
|
2014-03-24 19:09:16 +00:00
|
|
|
blocksize = inode->i_sb->s_blocksize;
|
|
|
|
length = blocksize - (offset & (blocksize - 1));
|
|
|
|
|
|
|
|
return ext4_block_zero_page_range(handle, mapping, from, length);
|
|
|
|
}
|
|
|
|
|
2013-05-28 03:32:35 +00:00
|
|
|
int ext4_zero_partial_blocks(handle_t *handle, struct inode *inode,
|
|
|
|
loff_t lstart, loff_t length)
|
|
|
|
{
|
|
|
|
struct super_block *sb = inode->i_sb;
|
|
|
|
struct address_space *mapping = inode->i_mapping;
|
2013-07-01 12:12:39 +00:00
|
|
|
unsigned partial_start, partial_end;
|
2013-05-28 03:32:35 +00:00
|
|
|
ext4_fsblk_t start, end;
|
|
|
|
loff_t byte_end = (lstart + length - 1);
|
|
|
|
int err = 0;
|
|
|
|
|
2013-07-01 12:12:39 +00:00
|
|
|
partial_start = lstart & (sb->s_blocksize - 1);
|
|
|
|
partial_end = byte_end & (sb->s_blocksize - 1);
|
|
|
|
|
2013-05-28 03:32:35 +00:00
|
|
|
start = lstart >> sb->s_blocksize_bits;
|
|
|
|
end = byte_end >> sb->s_blocksize_bits;
|
|
|
|
|
|
|
|
/* Handle partial zero within the single block */
|
2013-07-01 12:12:39 +00:00
|
|
|
if (start == end &&
|
|
|
|
(partial_start || (partial_end != sb->s_blocksize - 1))) {
|
2013-05-28 03:32:35 +00:00
|
|
|
err = ext4_block_zero_page_range(handle, mapping,
|
|
|
|
lstart, length);
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
/* Handle partial zero out on the start of the range */
|
2013-07-01 12:12:39 +00:00
|
|
|
if (partial_start) {
|
2013-05-28 03:32:35 +00:00
|
|
|
err = ext4_block_zero_page_range(handle, mapping,
|
|
|
|
lstart, sb->s_blocksize);
|
|
|
|
if (err)
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
/* Handle partial zero out on the end of the range */
|
2013-07-01 12:12:39 +00:00
|
|
|
if (partial_end != sb->s_blocksize - 1)
|
2013-05-28 03:32:35 +00:00
|
|
|
err = ext4_block_zero_page_range(handle, mapping,
|
2013-07-01 12:12:39 +00:00
|
|
|
byte_end - partial_end,
|
|
|
|
partial_end + 1);
|
2013-05-28 03:32:35 +00:00
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
2008-07-11 23:27:31 +00:00
|
|
|
int ext4_can_truncate(struct inode *inode)
|
|
|
|
{
|
|
|
|
if (S_ISREG(inode->i_mode))
|
|
|
|
return 1;
|
|
|
|
if (S_ISDIR(inode->i_mode))
|
|
|
|
return 1;
|
|
|
|
if (S_ISLNK(inode->i_mode))
|
|
|
|
return !ext4_inode_is_fast_symlink(inode);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2015-12-07 19:34:49 +00:00
|
|
|
/*
|
|
|
|
* We have to make sure i_disksize gets properly updated before we truncate
|
|
|
|
* page cache due to hole punching or zero range. Otherwise i_disksize update
|
|
|
|
* can get lost as it may have been postponed to submission of writeback but
|
|
|
|
* that will never happen after we truncate page cache.
|
|
|
|
*/
|
|
|
|
int ext4_update_disksize_before_punch(struct inode *inode, loff_t offset,
|
|
|
|
loff_t len)
|
|
|
|
{
|
|
|
|
handle_t *handle;
|
2020-04-27 01:34:37 +00:00
|
|
|
int ret;
|
|
|
|
|
2015-12-07 19:34:49 +00:00
|
|
|
loff_t size = i_size_read(inode);
|
|
|
|
|
2016-01-22 20:40:57 +00:00
|
|
|
WARN_ON(!inode_is_locked(inode));
|
2015-12-07 19:34:49 +00:00
|
|
|
if (offset > size || offset + len < size)
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
if (EXT4_I(inode)->i_disksize >= size)
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
handle = ext4_journal_start(inode, EXT4_HT_MISC, 1);
|
|
|
|
if (IS_ERR(handle))
|
|
|
|
return PTR_ERR(handle);
|
|
|
|
ext4_update_i_disksize(inode, size);
|
2020-04-27 01:34:37 +00:00
|
|
|
ret = ext4_mark_inode_dirty(handle, inode);
|
2015-12-07 19:34:49 +00:00
|
|
|
ext4_journal_stop(handle);
|
|
|
|
|
2020-04-27 01:34:37 +00:00
|
|
|
return ret;
|
2015-12-07 19:34:49 +00:00
|
|
|
}
|
|
|
|
|
2021-02-04 17:05:42 +00:00
|
|
|
static void ext4_wait_dax_page(struct inode *inode)
|
2018-07-29 21:00:22 +00:00
|
|
|
{
|
2021-02-04 17:05:42 +00:00
|
|
|
filemap_invalidate_unlock(inode->i_mapping);
|
2018-07-29 21:00:22 +00:00
|
|
|
schedule();
|
2021-02-04 17:05:42 +00:00
|
|
|
filemap_invalidate_lock(inode->i_mapping);
|
2018-07-29 21:00:22 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
int ext4_break_layouts(struct inode *inode)
|
|
|
|
{
|
|
|
|
struct page *page;
|
|
|
|
int error;
|
|
|
|
|
2021-02-04 17:05:42 +00:00
|
|
|
if (WARN_ON_ONCE(!rwsem_is_locked(&inode->i_mapping->invalidate_lock)))
|
2018-07-29 21:00:22 +00:00
|
|
|
return -EINVAL;
|
|
|
|
|
|
|
|
do {
|
|
|
|
page = dax_layout_busy_page(inode->i_mapping);
|
|
|
|
if (!page)
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
error = ___wait_var_event(&page->_refcount,
|
|
|
|
atomic_read(&page->_refcount) == 1,
|
|
|
|
TASK_INTERRUPTIBLE, 0, 0,
|
2021-02-04 17:05:42 +00:00
|
|
|
ext4_wait_dax_page(inode));
|
2018-09-11 17:31:16 +00:00
|
|
|
} while (error == 0);
|
2018-07-29 21:00:22 +00:00
|
|
|
|
|
|
|
return error;
|
|
|
|
}
|
|
|
|
|
2011-05-25 11:41:50 +00:00
|
|
|
/*
|
2016-09-22 15:49:38 +00:00
|
|
|
* ext4_punch_hole: punches a hole in a file by releasing the blocks
|
2011-05-25 11:41:50 +00:00
|
|
|
* associated with the given offset and length
|
|
|
|
*
|
|
|
|
* @inode: File inode
|
|
|
|
* @offset: The offset where the hole will begin
|
|
|
|
* @len: The length of the hole
|
|
|
|
*
|
2012-09-01 17:31:09 +00:00
|
|
|
* Returns: 0 on success or negative on failure
|
2011-05-25 11:41:50 +00:00
|
|
|
*/
|
|
|
|
|
2022-03-08 18:50:43 +00:00
|
|
|
int ext4_punch_hole(struct file *file, loff_t offset, loff_t length)
|
2011-05-25 11:41:50 +00:00
|
|
|
{
|
2022-03-08 18:50:43 +00:00
|
|
|
struct inode *inode = file_inode(file);
|
2013-04-03 16:45:17 +00:00
|
|
|
struct super_block *sb = inode->i_sb;
|
|
|
|
ext4_lblk_t first_block, stop_block;
|
|
|
|
struct address_space *mapping = inode->i_mapping;
|
2022-03-31 20:05:15 +00:00
|
|
|
loff_t first_block_offset, last_block_offset, max_length;
|
|
|
|
struct ext4_sb_info *sbi = EXT4_SB(inode->i_sb);
|
2013-04-03 16:45:17 +00:00
|
|
|
handle_t *handle;
|
|
|
|
unsigned int credits;
|
2020-04-27 01:34:37 +00:00
|
|
|
int ret = 0, ret2 = 0;
|
2013-04-03 16:45:17 +00:00
|
|
|
|
2014-03-18 22:05:35 +00:00
|
|
|
trace_ext4_punch_hole(inode, offset, length, 0);
|
2013-01-17 01:21:26 +00:00
|
|
|
|
2013-04-03 16:45:17 +00:00
|
|
|
/*
|
|
|
|
* Write out all dirty pages to avoid race conditions
|
|
|
|
* Then release them.
|
|
|
|
*/
|
2016-09-22 15:49:38 +00:00
|
|
|
if (mapping_tagged(mapping, PAGECACHE_TAG_DIRTY)) {
|
2013-04-03 16:45:17 +00:00
|
|
|
ret = filemap_write_and_wait_range(mapping, offset,
|
|
|
|
offset + length - 1);
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2016-01-22 20:40:57 +00:00
|
|
|
inode_lock(inode);
|
2014-04-12 13:47:00 +00:00
|
|
|
|
2013-04-03 16:45:17 +00:00
|
|
|
/* No need to punch hole beyond i_size */
|
|
|
|
if (offset >= inode->i_size)
|
|
|
|
goto out_mutex;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* If the hole extends beyond i_size, set the hole
|
|
|
|
* to end after the page that contains i_size
|
|
|
|
*/
|
|
|
|
if (offset + length > inode->i_size) {
|
|
|
|
length = inode->i_size +
|
mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros
PAGE_CACHE_{SIZE,SHIFT,MASK,ALIGN} macros were introduced *long* time
ago with promise that one day it will be possible to implement page
cache with bigger chunks than PAGE_SIZE.
This promise never materialized. And unlikely will.
We have many places where PAGE_CACHE_SIZE assumed to be equal to
PAGE_SIZE. And it's constant source of confusion on whether
PAGE_CACHE_* or PAGE_* constant should be used in a particular case,
especially on the border between fs and mm.
Global switching to PAGE_CACHE_SIZE != PAGE_SIZE would cause to much
breakage to be doable.
Let's stop pretending that pages in page cache are special. They are
not.
The changes are pretty straight-forward:
- <foo> << (PAGE_CACHE_SHIFT - PAGE_SHIFT) -> <foo>;
- <foo> >> (PAGE_CACHE_SHIFT - PAGE_SHIFT) -> <foo>;
- PAGE_CACHE_{SIZE,SHIFT,MASK,ALIGN} -> PAGE_{SIZE,SHIFT,MASK,ALIGN};
- page_cache_get() -> get_page();
- page_cache_release() -> put_page();
This patch contains automated changes generated with coccinelle using
script below. For some reason, coccinelle doesn't patch header files.
I've called spatch for them manually.
The only adjustment after coccinelle is revert of changes to
PAGE_CAHCE_ALIGN definition: we are going to drop it later.
There are few places in the code where coccinelle didn't reach. I'll
fix them manually in a separate patch. Comments and documentation also
will be addressed with the separate patch.
virtual patch
@@
expression E;
@@
- E << (PAGE_CACHE_SHIFT - PAGE_SHIFT)
+ E
@@
expression E;
@@
- E >> (PAGE_CACHE_SHIFT - PAGE_SHIFT)
+ E
@@
@@
- PAGE_CACHE_SHIFT
+ PAGE_SHIFT
@@
@@
- PAGE_CACHE_SIZE
+ PAGE_SIZE
@@
@@
- PAGE_CACHE_MASK
+ PAGE_MASK
@@
expression E;
@@
- PAGE_CACHE_ALIGN(E)
+ PAGE_ALIGN(E)
@@
expression E;
@@
- page_cache_get(E)
+ get_page(E)
@@
expression E;
@@
- page_cache_release(E)
+ put_page(E)
Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Acked-by: Michal Hocko <mhocko@suse.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2016-04-01 12:29:47 +00:00
|
|
|
PAGE_SIZE - (inode->i_size & (PAGE_SIZE - 1)) -
|
2013-04-03 16:45:17 +00:00
|
|
|
offset;
|
|
|
|
}
|
|
|
|
|
2022-03-31 20:05:15 +00:00
|
|
|
/*
|
|
|
|
* For punch hole the length + offset needs to be within one block
|
|
|
|
* before last range. Adjust the length if it goes beyond that limit.
|
|
|
|
*/
|
|
|
|
max_length = sbi->s_bitmap_maxbytes - inode->i_sb->s_blocksize;
|
|
|
|
if (offset + length > max_length)
|
|
|
|
length = max_length - offset;
|
|
|
|
|
2013-08-17 01:19:41 +00:00
|
|
|
if (offset & (sb->s_blocksize - 1) ||
|
|
|
|
(offset + length) & (sb->s_blocksize - 1)) {
|
|
|
|
/*
|
|
|
|
* Attach jinode to inode for jbd2 if we do any zeroing of
|
|
|
|
* partial block
|
|
|
|
*/
|
|
|
|
ret = ext4_inode_attach_jinode(inode);
|
|
|
|
if (ret < 0)
|
|
|
|
goto out_mutex;
|
|
|
|
|
|
|
|
}
|
|
|
|
|
2022-01-21 07:06:11 +00:00
|
|
|
/* Wait all existing dio workers, newcomers will block on i_rwsem */
|
2015-12-07 19:28:03 +00:00
|
|
|
inode_dio_wait(inode);
|
|
|
|
|
2022-03-08 18:50:43 +00:00
|
|
|
ret = file_modified(file);
|
|
|
|
if (ret)
|
|
|
|
goto out_mutex;
|
|
|
|
|
2015-12-07 19:28:03 +00:00
|
|
|
/*
|
|
|
|
* Prevent page faults from reinstantiating pages we have released from
|
|
|
|
* page cache.
|
|
|
|
*/
|
2021-02-04 17:05:42 +00:00
|
|
|
filemap_invalidate_lock(mapping);
|
2018-07-29 21:00:22 +00:00
|
|
|
|
|
|
|
ret = ext4_break_layouts(inode);
|
|
|
|
if (ret)
|
|
|
|
goto out_dio;
|
|
|
|
|
2013-05-28 03:32:35 +00:00
|
|
|
first_block_offset = round_up(offset, sb->s_blocksize);
|
|
|
|
last_block_offset = round_down((offset + length), sb->s_blocksize) - 1;
|
2013-04-03 16:45:17 +00:00
|
|
|
|
2013-05-28 03:32:35 +00:00
|
|
|
/* Now release the pages and zero block aligned part of pages*/
|
2015-12-07 19:34:49 +00:00
|
|
|
if (last_block_offset > first_block_offset) {
|
|
|
|
ret = ext4_update_disksize_before_punch(inode, offset, length);
|
|
|
|
if (ret)
|
|
|
|
goto out_dio;
|
2013-05-28 03:32:35 +00:00
|
|
|
truncate_pagecache_range(inode, first_block_offset,
|
|
|
|
last_block_offset);
|
2015-12-07 19:34:49 +00:00
|
|
|
}
|
2013-04-03 16:45:17 +00:00
|
|
|
|
|
|
|
if (ext4_test_inode_flag(inode, EXT4_INODE_EXTENTS))
|
|
|
|
credits = ext4_writepage_trans_blocks(inode);
|
|
|
|
else
|
|
|
|
credits = ext4_blocks_for_truncate(inode);
|
|
|
|
handle = ext4_journal_start(inode, EXT4_HT_TRUNCATE, credits);
|
|
|
|
if (IS_ERR(handle)) {
|
|
|
|
ret = PTR_ERR(handle);
|
|
|
|
ext4_std_error(sb, ret);
|
|
|
|
goto out_dio;
|
|
|
|
}
|
|
|
|
|
2013-05-28 03:32:35 +00:00
|
|
|
ret = ext4_zero_partial_blocks(handle, inode, offset,
|
|
|
|
length);
|
|
|
|
if (ret)
|
|
|
|
goto out_stop;
|
2013-04-03 16:45:17 +00:00
|
|
|
|
|
|
|
first_block = (offset + sb->s_blocksize - 1) >>
|
|
|
|
EXT4_BLOCK_SIZE_BITS(sb);
|
|
|
|
stop_block = (offset + length) >> EXT4_BLOCK_SIZE_BITS(sb);
|
|
|
|
|
2018-05-13 23:28:35 +00:00
|
|
|
/* If there are blocks to remove, do it */
|
|
|
|
if (stop_block > first_block) {
|
2024-01-27 01:58:03 +00:00
|
|
|
ext4_lblk_t hole_len = stop_block - first_block;
|
2013-04-03 16:45:17 +00:00
|
|
|
|
2018-05-13 23:28:35 +00:00
|
|
|
down_write(&EXT4_I(inode)->i_data_sem);
|
2024-01-05 09:21:01 +00:00
|
|
|
ext4_discard_preallocations(inode);
|
2013-04-03 16:45:17 +00:00
|
|
|
|
2024-01-27 01:58:03 +00:00
|
|
|
ext4_es_remove_extent(inode, first_block, hole_len);
|
2013-04-03 16:45:17 +00:00
|
|
|
|
2018-05-13 23:28:35 +00:00
|
|
|
if (ext4_test_inode_flag(inode, EXT4_INODE_EXTENTS))
|
|
|
|
ret = ext4_ext_remove_space(inode, first_block,
|
|
|
|
stop_block - 1);
|
|
|
|
else
|
|
|
|
ret = ext4_ind_remove_space(handle, inode, first_block,
|
|
|
|
stop_block);
|
2013-04-03 16:45:17 +00:00
|
|
|
|
2024-01-27 01:58:03 +00:00
|
|
|
ext4_es_insert_extent(inode, first_block, hole_len, ~0,
|
2024-08-13 12:34:45 +00:00
|
|
|
EXTENT_STATUS_HOLE, 0);
|
2018-05-13 23:28:35 +00:00
|
|
|
up_write(&EXT4_I(inode)->i_data_sem);
|
|
|
|
}
|
2020-11-06 03:58:53 +00:00
|
|
|
ext4_fc_track_range(handle, inode, first_block, stop_block);
|
2013-04-03 16:45:17 +00:00
|
|
|
if (IS_SYNC(inode))
|
|
|
|
ext4_handle_sync(handle);
|
2014-02-20 21:58:05 +00:00
|
|
|
|
2023-10-04 18:52:20 +00:00
|
|
|
inode_set_mtime_to_ts(inode, inode_set_ctime_current(inode));
|
2020-04-27 01:34:37 +00:00
|
|
|
ret2 = ext4_mark_inode_dirty(handle, inode);
|
|
|
|
if (unlikely(ret2))
|
|
|
|
ret = ret2;
|
2017-05-29 17:24:55 +00:00
|
|
|
if (ret >= 0)
|
|
|
|
ext4_update_inode_fsync_trans(handle, inode, 1);
|
2013-04-03 16:45:17 +00:00
|
|
|
out_stop:
|
|
|
|
ext4_journal_stop(handle);
|
|
|
|
out_dio:
|
2021-02-04 17:05:42 +00:00
|
|
|
filemap_invalidate_unlock(mapping);
|
2013-04-03 16:45:17 +00:00
|
|
|
out_mutex:
|
2016-01-22 20:40:57 +00:00
|
|
|
inode_unlock(inode);
|
2013-04-03 16:45:17 +00:00
|
|
|
return ret;
|
2011-05-25 11:41:50 +00:00
|
|
|
}
|
|
|
|
|
2013-08-17 01:19:41 +00:00
|
|
|
int ext4_inode_attach_jinode(struct inode *inode)
|
|
|
|
{
|
|
|
|
struct ext4_inode_info *ei = EXT4_I(inode);
|
|
|
|
struct jbd2_inode *jinode;
|
|
|
|
|
|
|
|
if (ei->jinode || !EXT4_SB(inode->i_sb)->s_journal)
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
jinode = jbd2_alloc_inode(GFP_KERNEL);
|
|
|
|
spin_lock(&inode->i_lock);
|
|
|
|
if (!ei->jinode) {
|
|
|
|
if (!jinode) {
|
|
|
|
spin_unlock(&inode->i_lock);
|
|
|
|
return -ENOMEM;
|
|
|
|
}
|
|
|
|
ei->jinode = jinode;
|
|
|
|
jbd2_journal_init_jbd_inode(ei->jinode, inode);
|
|
|
|
jinode = NULL;
|
|
|
|
}
|
|
|
|
spin_unlock(&inode->i_lock);
|
|
|
|
if (unlikely(jinode != NULL))
|
|
|
|
jbd2_free_inode(jinode);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2006-10-11 08:20:50 +00:00
|
|
|
/*
|
2006-10-11 08:20:53 +00:00
|
|
|
* ext4_truncate()
|
2006-10-11 08:20:50 +00:00
|
|
|
*
|
2006-10-11 08:20:53 +00:00
|
|
|
* We block out ext4_get_block() block instantiations across the entire
|
|
|
|
* transaction, and VFS/VM ensures that ext4_truncate() cannot run
|
2006-10-11 08:20:50 +00:00
|
|
|
* simultaneously on behalf of the same inode.
|
|
|
|
*
|
2011-11-29 04:31:00 +00:00
|
|
|
* As we work through the truncate and commit bits of it to the journal there
|
2006-10-11 08:20:50 +00:00
|
|
|
* is one core, guiding principle: the file's tree must always be consistent on
|
|
|
|
* disk. We must be able to restart the truncate after a crash.
|
|
|
|
*
|
|
|
|
* The file's tree may be transiently inconsistent in memory (although it
|
|
|
|
* probably isn't), but whenever we close off and commit a journal transaction,
|
|
|
|
* the contents of (the filesystem + the journal) must be consistent and
|
|
|
|
* restartable. It's pretty simple, really: bottom up, right to left (although
|
|
|
|
* left-to-right works OK too).
|
|
|
|
*
|
|
|
|
* Note that at recovery time, journal replay occurs *before* the restart of
|
|
|
|
* truncate against the orphan inode list.
|
|
|
|
*
|
|
|
|
* The committed inode has the new, desired i_size (which is the same as
|
2006-10-11 08:20:53 +00:00
|
|
|
* i_disksize in this case). After a crash, ext4_orphan_cleanup() will see
|
2006-10-11 08:20:50 +00:00
|
|
|
* that this inode's truncate did not complete and it will again call
|
2006-10-11 08:20:53 +00:00
|
|
|
* ext4_truncate() to have another go. So there will be instantiated blocks
|
|
|
|
* to the right of the truncation point in a crashed ext4 filesystem. But
|
2006-10-11 08:20:50 +00:00
|
|
|
* that's fine - as long as they are linked from the inode, the post-crash
|
2006-10-11 08:20:53 +00:00
|
|
|
* ext4_truncate() run will find them and release them.
|
2006-10-11 08:20:50 +00:00
|
|
|
*/
|
2016-11-14 03:02:26 +00:00
|
|
|
int ext4_truncate(struct inode *inode)
|
2006-10-11 08:20:50 +00:00
|
|
|
{
|
2013-04-03 16:47:17 +00:00
|
|
|
struct ext4_inode_info *ei = EXT4_I(inode);
|
|
|
|
unsigned int credits;
|
2020-04-27 01:34:37 +00:00
|
|
|
int err = 0, err2;
|
2013-04-03 16:47:17 +00:00
|
|
|
handle_t *handle;
|
|
|
|
struct address_space *mapping = inode->i_mapping;
|
|
|
|
|
2013-04-04 01:58:52 +00:00
|
|
|
/*
|
|
|
|
* There is a possibility that we're either freeing the inode
|
2014-03-24 19:15:07 +00:00
|
|
|
* or it's a completely new inode. In those cases we might not
|
2022-01-21 07:06:11 +00:00
|
|
|
* have i_rwsem locked because it's not necessary.
|
2013-04-04 01:58:52 +00:00
|
|
|
*/
|
|
|
|
if (!(inode->i_state & (I_NEW|I_FREEING)))
|
2016-01-22 20:40:57 +00:00
|
|
|
WARN_ON(!inode_is_locked(inode));
|
2011-03-22 01:38:05 +00:00
|
|
|
trace_ext4_truncate_enter(inode);
|
|
|
|
|
2008-07-11 23:27:31 +00:00
|
|
|
if (!ext4_can_truncate(inode))
|
2020-07-01 08:30:27 +00:00
|
|
|
goto out_trace;
|
2006-10-11 08:20:50 +00:00
|
|
|
|
2009-09-17 13:34:16 +00:00
|
|
|
if (inode->i_size == 0 && !test_opt(inode->i_sb, NO_AUTO_DA_ALLOC))
|
2010-01-24 19:34:07 +00:00
|
|
|
ext4_set_inode_state(inode, EXT4_STATE_DA_ALLOC_CLOSE);
|
2009-02-24 13:21:14 +00:00
|
|
|
|
2012-12-10 19:06:02 +00:00
|
|
|
if (ext4_has_inline_data(inode)) {
|
|
|
|
int has_inline = 1;
|
|
|
|
|
2017-01-23 00:35:49 +00:00
|
|
|
err = ext4_inline_data_truncate(inode, &has_inline);
|
2020-07-01 08:30:27 +00:00
|
|
|
if (err || has_inline)
|
|
|
|
goto out_trace;
|
2012-12-10 19:06:02 +00:00
|
|
|
}
|
|
|
|
|
2013-08-17 01:19:41 +00:00
|
|
|
/* If we zero-out tail of the page, we have to create jinode for jbd2 */
|
|
|
|
if (inode->i_size & (inode->i_sb->s_blocksize - 1)) {
|
2022-11-02 08:06:33 +00:00
|
|
|
err = ext4_inode_attach_jinode(inode);
|
|
|
|
if (err)
|
2020-07-01 08:30:27 +00:00
|
|
|
goto out_trace;
|
2013-08-17 01:19:41 +00:00
|
|
|
}
|
|
|
|
|
2013-04-03 16:47:17 +00:00
|
|
|
if (ext4_test_inode_flag(inode, EXT4_INODE_EXTENTS))
|
|
|
|
credits = ext4_writepage_trans_blocks(inode);
|
|
|
|
else
|
|
|
|
credits = ext4_blocks_for_truncate(inode);
|
|
|
|
|
|
|
|
handle = ext4_journal_start(inode, EXT4_HT_TRUNCATE, credits);
|
2020-07-01 08:30:27 +00:00
|
|
|
if (IS_ERR(handle)) {
|
|
|
|
err = PTR_ERR(handle);
|
|
|
|
goto out_trace;
|
|
|
|
}
|
2013-04-03 16:47:17 +00:00
|
|
|
|
2013-05-28 03:32:35 +00:00
|
|
|
if (inode->i_size & (inode->i_sb->s_blocksize - 1))
|
|
|
|
ext4_block_truncate_page(handle, mapping, inode->i_size);
|
2013-04-03 16:47:17 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* We add the inode to the orphan list, so that if this
|
|
|
|
* truncate spans multiple transactions, and we crash, we will
|
|
|
|
* resume the truncate when the filesystem recovers. It also
|
|
|
|
* marks the inode dirty, to catch the new size.
|
|
|
|
*
|
|
|
|
* Implication: the file must always be in a sane, consistent
|
|
|
|
* truncatable state while each transaction commits.
|
|
|
|
*/
|
2016-11-14 03:02:26 +00:00
|
|
|
err = ext4_orphan_add(handle, inode);
|
|
|
|
if (err)
|
2013-04-03 16:47:17 +00:00
|
|
|
goto out_stop;
|
|
|
|
|
|
|
|
down_write(&EXT4_I(inode)->i_data_sem);
|
|
|
|
|
2024-01-05 09:21:01 +00:00
|
|
|
ext4_discard_preallocations(inode);
|
2013-04-03 16:47:17 +00:00
|
|
|
|
2011-06-27 20:36:31 +00:00
|
|
|
if (ext4_test_inode_flag(inode, EXT4_INODE_EXTENTS))
|
2016-11-14 03:02:28 +00:00
|
|
|
err = ext4_ext_truncate(handle, inode);
|
2011-06-27 20:36:31 +00:00
|
|
|
else
|
2013-04-03 16:47:17 +00:00
|
|
|
ext4_ind_truncate(handle, inode);
|
|
|
|
|
|
|
|
up_write(&ei->i_data_sem);
|
2016-11-14 03:02:28 +00:00
|
|
|
if (err)
|
|
|
|
goto out_stop;
|
2013-04-03 16:47:17 +00:00
|
|
|
|
|
|
|
if (IS_SYNC(inode))
|
|
|
|
ext4_handle_sync(handle);
|
|
|
|
|
|
|
|
out_stop:
|
|
|
|
/*
|
|
|
|
* If this was a simple ftruncate() and the file will remain alive,
|
|
|
|
* then we need to clear up the orphan record which we created above.
|
|
|
|
* However, if this was a real unlink then we were called by
|
2014-11-25 21:17:29 +00:00
|
|
|
* ext4_evict_inode(), and we allow that function to clean up the
|
2013-04-03 16:47:17 +00:00
|
|
|
* orphan info for us.
|
|
|
|
*/
|
|
|
|
if (inode->i_nlink)
|
|
|
|
ext4_orphan_del(handle, inode);
|
|
|
|
|
2023-10-04 18:52:20 +00:00
|
|
|
inode_set_mtime_to_ts(inode, inode_set_ctime_current(inode));
|
2020-04-27 01:34:37 +00:00
|
|
|
err2 = ext4_mark_inode_dirty(handle, inode);
|
|
|
|
if (unlikely(err2 && !err))
|
|
|
|
err = err2;
|
2013-04-03 16:47:17 +00:00
|
|
|
ext4_journal_stop(handle);
|
2006-10-11 08:20:50 +00:00
|
|
|
|
2020-07-01 08:30:27 +00:00
|
|
|
out_trace:
|
2011-03-22 01:38:05 +00:00
|
|
|
trace_ext4_truncate_exit(inode);
|
2016-11-14 03:02:26 +00:00
|
|
|
return err;
|
2006-10-11 08:20:50 +00:00
|
|
|
}
|
|
|
|
|
2021-09-01 02:09:54 +00:00
|
|
|
static inline u64 ext4_inode_peek_iversion(const struct inode *inode)
|
|
|
|
{
|
|
|
|
if (unlikely(EXT4_I(inode)->i_flags & EXT4_EA_INODE_FL))
|
|
|
|
return inode_peek_iversion_raw(inode);
|
|
|
|
else
|
|
|
|
return inode_peek_iversion(inode);
|
|
|
|
}
|
|
|
|
|
|
|
|
static int ext4_inode_blocks_set(struct ext4_inode *raw_inode,
|
|
|
|
struct ext4_inode_info *ei)
|
|
|
|
{
|
|
|
|
struct inode *inode = &(ei->vfs_inode);
|
|
|
|
u64 i_blocks = READ_ONCE(inode->i_blocks);
|
|
|
|
struct super_block *sb = inode->i_sb;
|
|
|
|
|
|
|
|
if (i_blocks <= ~0U) {
|
|
|
|
/*
|
|
|
|
* i_blocks can be represented in a 32 bit variable
|
|
|
|
* as multiple of 512 bytes
|
|
|
|
*/
|
|
|
|
raw_inode->i_blocks_lo = cpu_to_le32(i_blocks);
|
|
|
|
raw_inode->i_blocks_high = 0;
|
|
|
|
ext4_clear_inode_flag(inode, EXT4_INODE_HUGE_FILE);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* This should never happen since sb->s_maxbytes should not have
|
|
|
|
* allowed this, sb->s_maxbytes was set according to the huge_file
|
|
|
|
* feature in ext4_fill_super().
|
|
|
|
*/
|
|
|
|
if (!ext4_has_feature_huge_file(sb))
|
|
|
|
return -EFSCORRUPTED;
|
|
|
|
|
|
|
|
if (i_blocks <= 0xffffffffffffULL) {
|
|
|
|
/*
|
|
|
|
* i_blocks can be represented in a 48 bit variable
|
|
|
|
* as multiple of 512 bytes
|
|
|
|
*/
|
|
|
|
raw_inode->i_blocks_lo = cpu_to_le32(i_blocks);
|
|
|
|
raw_inode->i_blocks_high = cpu_to_le16(i_blocks >> 32);
|
|
|
|
ext4_clear_inode_flag(inode, EXT4_INODE_HUGE_FILE);
|
|
|
|
} else {
|
|
|
|
ext4_set_inode_flag(inode, EXT4_INODE_HUGE_FILE);
|
|
|
|
/* i_block is stored in file system block size */
|
|
|
|
i_blocks = i_blocks >> (inode->i_blkbits - 9);
|
|
|
|
raw_inode->i_blocks_lo = cpu_to_le32(i_blocks);
|
|
|
|
raw_inode->i_blocks_high = cpu_to_le16(i_blocks >> 32);
|
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int ext4_fill_raw_inode(struct inode *inode, struct ext4_inode *raw_inode)
|
|
|
|
{
|
|
|
|
struct ext4_inode_info *ei = EXT4_I(inode);
|
|
|
|
uid_t i_uid;
|
|
|
|
gid_t i_gid;
|
|
|
|
projid_t i_projid;
|
|
|
|
int block;
|
|
|
|
int err;
|
|
|
|
|
|
|
|
err = ext4_inode_blocks_set(raw_inode, ei);
|
|
|
|
|
|
|
|
raw_inode->i_mode = cpu_to_le16(inode->i_mode);
|
|
|
|
i_uid = i_uid_read(inode);
|
|
|
|
i_gid = i_gid_read(inode);
|
|
|
|
i_projid = from_kprojid(&init_user_ns, ei->i_projid);
|
|
|
|
if (!(test_opt(inode->i_sb, NO_UID32))) {
|
|
|
|
raw_inode->i_uid_low = cpu_to_le16(low_16_bits(i_uid));
|
|
|
|
raw_inode->i_gid_low = cpu_to_le16(low_16_bits(i_gid));
|
|
|
|
/*
|
|
|
|
* Fix up interoperability with old kernels. Otherwise,
|
|
|
|
* old inodes get re-used with the upper 16 bits of the
|
|
|
|
* uid/gid intact.
|
|
|
|
*/
|
|
|
|
if (ei->i_dtime && list_empty(&ei->i_orphan)) {
|
|
|
|
raw_inode->i_uid_high = 0;
|
|
|
|
raw_inode->i_gid_high = 0;
|
|
|
|
} else {
|
|
|
|
raw_inode->i_uid_high =
|
|
|
|
cpu_to_le16(high_16_bits(i_uid));
|
|
|
|
raw_inode->i_gid_high =
|
|
|
|
cpu_to_le16(high_16_bits(i_gid));
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
raw_inode->i_uid_low = cpu_to_le16(fs_high2lowuid(i_uid));
|
|
|
|
raw_inode->i_gid_low = cpu_to_le16(fs_high2lowgid(i_gid));
|
|
|
|
raw_inode->i_uid_high = 0;
|
|
|
|
raw_inode->i_gid_high = 0;
|
|
|
|
}
|
|
|
|
raw_inode->i_links_count = cpu_to_le16(inode->i_nlink);
|
|
|
|
|
2023-07-05 19:01:07 +00:00
|
|
|
EXT4_INODE_SET_CTIME(inode, raw_inode);
|
2023-10-04 18:52:20 +00:00
|
|
|
EXT4_INODE_SET_MTIME(inode, raw_inode);
|
|
|
|
EXT4_INODE_SET_ATIME(inode, raw_inode);
|
2021-09-01 02:09:54 +00:00
|
|
|
EXT4_EINODE_SET_XTIME(i_crtime, ei, raw_inode);
|
|
|
|
|
|
|
|
raw_inode->i_dtime = cpu_to_le32(ei->i_dtime);
|
|
|
|
raw_inode->i_flags = cpu_to_le32(ei->i_flags & 0xFFFFFFFF);
|
|
|
|
if (likely(!test_opt2(inode->i_sb, HURD_COMPAT)))
|
|
|
|
raw_inode->i_file_acl_high =
|
|
|
|
cpu_to_le16(ei->i_file_acl >> 32);
|
|
|
|
raw_inode->i_file_acl_lo = cpu_to_le32(ei->i_file_acl);
|
|
|
|
ext4_isize_set(raw_inode, ei->i_disksize);
|
|
|
|
|
|
|
|
raw_inode->i_generation = cpu_to_le32(inode->i_generation);
|
|
|
|
if (S_ISCHR(inode->i_mode) || S_ISBLK(inode->i_mode)) {
|
|
|
|
if (old_valid_dev(inode->i_rdev)) {
|
|
|
|
raw_inode->i_block[0] =
|
|
|
|
cpu_to_le32(old_encode_dev(inode->i_rdev));
|
|
|
|
raw_inode->i_block[1] = 0;
|
|
|
|
} else {
|
|
|
|
raw_inode->i_block[0] = 0;
|
|
|
|
raw_inode->i_block[1] =
|
|
|
|
cpu_to_le32(new_encode_dev(inode->i_rdev));
|
|
|
|
raw_inode->i_block[2] = 0;
|
|
|
|
}
|
|
|
|
} else if (!ext4_has_inline_data(inode)) {
|
|
|
|
for (block = 0; block < EXT4_N_BLOCKS; block++)
|
|
|
|
raw_inode->i_block[block] = ei->i_data[block];
|
|
|
|
}
|
|
|
|
|
|
|
|
if (likely(!test_opt2(inode->i_sb, HURD_COMPAT))) {
|
|
|
|
u64 ivers = ext4_inode_peek_iversion(inode);
|
|
|
|
|
|
|
|
raw_inode->i_disk_version = cpu_to_le32(ivers);
|
|
|
|
if (ei->i_extra_isize) {
|
|
|
|
if (EXT4_FITS_IN_INODE(raw_inode, ei, i_version_hi))
|
|
|
|
raw_inode->i_version_hi =
|
|
|
|
cpu_to_le32(ivers >> 32);
|
|
|
|
raw_inode->i_extra_isize =
|
|
|
|
cpu_to_le16(ei->i_extra_isize);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (i_projid != EXT4_DEF_PROJID &&
|
|
|
|
!ext4_has_feature_project(inode->i_sb))
|
|
|
|
err = err ?: -EFSCORRUPTED;
|
|
|
|
|
|
|
|
if (EXT4_INODE_SIZE(inode->i_sb) > EXT4_GOOD_OLD_INODE_SIZE &&
|
|
|
|
EXT4_FITS_IN_INODE(raw_inode, ei, i_projid))
|
|
|
|
raw_inode->i_projid = cpu_to_le32(i_projid);
|
|
|
|
|
|
|
|
ext4_inode_csum_set(inode, raw_inode, ei);
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
2006-10-11 08:20:50 +00:00
|
|
|
/*
|
2006-10-11 08:20:53 +00:00
|
|
|
* ext4_get_inode_loc returns with an extra refcount against the inode's
|
ext4: prevent getting empty inode buffer
In ext4_get_inode_loc(), we may skip IO and get an zero && uptodate
inode buffer when the inode monopolize an inode block for performance
reason. For most cases, ext4_mark_iloc_dirty() will fill the inode
buffer to make it fine, but we could miss this call if something bad
happened. Finally, __ext4_get_inode_loc_noinmem() may probably get an
empty inode buffer and trigger ext4 error.
For example, if we remove a nonexistent xattr on inode A,
ext4_xattr_set_handle() will return ENODATA before invoking
ext4_mark_iloc_dirty(), it will left an uptodate but zero buffer. We
will get checksum error message in ext4_iget() when getting inode again.
EXT4-fs error (device sda): ext4_lookup:1784: inode #131074: comm cat: iget: checksum invalid
Even worse, if we allocate another inode B at the same inode block, it
will corrupt the inode A on disk when write back inode B.
So this patch initialize the inode buffer by filling the in-mem inode
contents if we skip read I/O, ensure that the buffer is really uptodate.
Signed-off-by: Zhang Yi <yi.zhang@huawei.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20210901020955.1657340-4-yi.zhang@huawei.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
2021-09-01 02:09:55 +00:00
|
|
|
* underlying buffer_head on success. If we pass 'inode' and it does not
|
|
|
|
* have in-inode xattr, we have all inode data in memory that is needed
|
|
|
|
* to recreate the on-disk version of this inode.
|
2006-10-11 08:20:50 +00:00
|
|
|
*/
|
2020-10-15 20:37:59 +00:00
|
|
|
static int __ext4_get_inode_loc(struct super_block *sb, unsigned long ino,
|
ext4: prevent getting empty inode buffer
In ext4_get_inode_loc(), we may skip IO and get an zero && uptodate
inode buffer when the inode monopolize an inode block for performance
reason. For most cases, ext4_mark_iloc_dirty() will fill the inode
buffer to make it fine, but we could miss this call if something bad
happened. Finally, __ext4_get_inode_loc_noinmem() may probably get an
empty inode buffer and trigger ext4 error.
For example, if we remove a nonexistent xattr on inode A,
ext4_xattr_set_handle() will return ENODATA before invoking
ext4_mark_iloc_dirty(), it will left an uptodate but zero buffer. We
will get checksum error message in ext4_iget() when getting inode again.
EXT4-fs error (device sda): ext4_lookup:1784: inode #131074: comm cat: iget: checksum invalid
Even worse, if we allocate another inode B at the same inode block, it
will corrupt the inode A on disk when write back inode B.
So this patch initialize the inode buffer by filling the in-mem inode
contents if we skip read I/O, ensure that the buffer is really uptodate.
Signed-off-by: Zhang Yi <yi.zhang@huawei.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20210901020955.1657340-4-yi.zhang@huawei.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
2021-09-01 02:09:55 +00:00
|
|
|
struct inode *inode, struct ext4_iloc *iloc,
|
2020-10-15 20:37:59 +00:00
|
|
|
ext4_fsblk_t *ret_block)
|
2006-10-11 08:20:50 +00:00
|
|
|
{
|
2008-10-10 03:53:47 +00:00
|
|
|
struct ext4_group_desc *gdp;
|
|
|
|
struct buffer_head *bh;
|
|
|
|
ext4_fsblk_t block;
|
2019-09-30 00:59:23 +00:00
|
|
|
struct blk_plug plug;
|
2008-10-10 03:53:47 +00:00
|
|
|
int inodes_per_block, inode_offset;
|
|
|
|
|
2008-11-22 20:04:59 +00:00
|
|
|
iloc->bh = NULL;
|
2020-10-15 20:37:59 +00:00
|
|
|
if (ino < EXT4_ROOT_INO ||
|
|
|
|
ino > le32_to_cpu(EXT4_SB(sb)->s_es->s_inodes_count))
|
2015-10-17 20:16:04 +00:00
|
|
|
return -EFSCORRUPTED;
|
2006-10-11 08:20:50 +00:00
|
|
|
|
2020-10-15 20:37:59 +00:00
|
|
|
iloc->block_group = (ino - 1) / EXT4_INODES_PER_GROUP(sb);
|
2008-10-10 03:53:47 +00:00
|
|
|
gdp = ext4_get_group_desc(sb, iloc->block_group, NULL);
|
|
|
|
if (!gdp)
|
2006-10-11 08:20:50 +00:00
|
|
|
return -EIO;
|
|
|
|
|
2008-10-10 03:53:47 +00:00
|
|
|
/*
|
|
|
|
* Figure out the offset within the block group inode table
|
|
|
|
*/
|
2011-05-09 14:26:41 +00:00
|
|
|
inodes_per_block = EXT4_SB(sb)->s_inodes_per_block;
|
2020-10-15 20:37:59 +00:00
|
|
|
inode_offset = ((ino - 1) %
|
2008-10-10 03:53:47 +00:00
|
|
|
EXT4_INODES_PER_GROUP(sb));
|
|
|
|
iloc->offset = (inode_offset % inodes_per_block) * EXT4_INODE_SIZE(sb);
|
|
|
|
|
ext4: add inode table check in __ext4_get_inode_loc to aovid possible infinite loop
In do_writepages, if the value returned by ext4_writepages is "-ENOMEM"
and "wbc->sync_mode == WB_SYNC_ALL", retry until the condition is not met.
In __ext4_get_inode_loc, if the bh returned by sb_getblk is NULL,
the function returns -ENOMEM.
In __getblk_slow, if the return value of grow_buffers is less than 0,
the function returns NULL.
When the three processes are connected in series like the following stack,
an infinite loop may occur:
do_writepages <--- keep retrying
ext4_writepages
mpage_map_and_submit_extent
mpage_map_one_extent
ext4_map_blocks
ext4_ext_map_blocks
ext4_ext_handle_unwritten_extents
ext4_ext_convert_to_initialized
ext4_split_extent
ext4_split_extent_at
__ext4_ext_dirty
__ext4_mark_inode_dirty
ext4_reserve_inode_write
ext4_get_inode_loc
__ext4_get_inode_loc <--- return -ENOMEM
sb_getblk
__getblk_gfp
__getblk_slow <--- return NULL
grow_buffers
grow_dev_page <--- return -ENXIO
ret = (block < end_block) ? 1 : -ENXIO;
In this issue, bg_inode_table_hi is overwritten as an incorrect value.
As a result, `block < end_block` cannot be met in grow_dev_page.
Therefore, __ext4_get_inode_loc always returns '-ENOMEM' and do_writepages
keeps retrying. As a result, the writeback process is in the D state due
to an infinite loop.
Add a check on inode table block in the __ext4_get_inode_loc function by
referring to ext4_read_inode_bitmap to avoid this infinite loop.
Cc: stable@kernel.org
Signed-off-by: Baokun Li <libaokun1@huawei.com>
Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
Link: https://lore.kernel.org/r/20220817132701.3015912-3-libaokun1@huawei.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
2022-08-17 13:27:01 +00:00
|
|
|
block = ext4_inode_table(sb, gdp);
|
|
|
|
if ((block <= le32_to_cpu(EXT4_SB(sb)->s_es->s_first_data_block)) ||
|
|
|
|
(block >= ext4_blocks_count(EXT4_SB(sb)->s_es))) {
|
|
|
|
ext4_error(sb, "Invalid inode table block %llu in "
|
|
|
|
"block_group %u", block, iloc->block_group);
|
|
|
|
return -EFSCORRUPTED;
|
|
|
|
}
|
|
|
|
block += (inode_offset / inodes_per_block);
|
|
|
|
|
2008-10-10 03:53:47 +00:00
|
|
|
bh = sb_getblk(sb, block);
|
2013-01-12 21:28:47 +00:00
|
|
|
if (unlikely(!bh))
|
2013-01-12 21:19:36 +00:00
|
|
|
return -ENOMEM;
|
2021-08-26 13:04:08 +00:00
|
|
|
if (ext4_buffer_uptodate(bh))
|
|
|
|
goto has_buffer;
|
2008-07-26 20:39:26 +00:00
|
|
|
|
2021-08-26 13:04:08 +00:00
|
|
|
lock_buffer(bh);
|
2021-09-10 08:03:16 +00:00
|
|
|
if (ext4_buffer_uptodate(bh)) {
|
|
|
|
/* Someone brought it uptodate while we waited */
|
|
|
|
unlock_buffer(bh);
|
|
|
|
goto has_buffer;
|
|
|
|
}
|
|
|
|
|
2021-08-26 13:04:08 +00:00
|
|
|
/*
|
|
|
|
* If we have all information of the inode in memory and this
|
|
|
|
* is the only valid inode in the block, we need not read the
|
|
|
|
* block.
|
|
|
|
*/
|
ext4: prevent getting empty inode buffer
In ext4_get_inode_loc(), we may skip IO and get an zero && uptodate
inode buffer when the inode monopolize an inode block for performance
reason. For most cases, ext4_mark_iloc_dirty() will fill the inode
buffer to make it fine, but we could miss this call if something bad
happened. Finally, __ext4_get_inode_loc_noinmem() may probably get an
empty inode buffer and trigger ext4 error.
For example, if we remove a nonexistent xattr on inode A,
ext4_xattr_set_handle() will return ENODATA before invoking
ext4_mark_iloc_dirty(), it will left an uptodate but zero buffer. We
will get checksum error message in ext4_iget() when getting inode again.
EXT4-fs error (device sda): ext4_lookup:1784: inode #131074: comm cat: iget: checksum invalid
Even worse, if we allocate another inode B at the same inode block, it
will corrupt the inode A on disk when write back inode B.
So this patch initialize the inode buffer by filling the in-mem inode
contents if we skip read I/O, ensure that the buffer is really uptodate.
Signed-off-by: Zhang Yi <yi.zhang@huawei.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20210901020955.1657340-4-yi.zhang@huawei.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
2021-09-01 02:09:55 +00:00
|
|
|
if (inode && !ext4_test_inode_state(inode, EXT4_STATE_XATTR)) {
|
2021-08-26 13:04:08 +00:00
|
|
|
struct buffer_head *bitmap_bh;
|
|
|
|
int i, start;
|
2006-10-11 08:20:50 +00:00
|
|
|
|
2021-08-26 13:04:08 +00:00
|
|
|
start = inode_offset & ~(inodes_per_block - 1);
|
2006-10-11 08:20:50 +00:00
|
|
|
|
2021-08-26 13:04:08 +00:00
|
|
|
/* Is the inode bitmap in cache? */
|
|
|
|
bitmap_bh = sb_getblk(sb, ext4_inode_bitmap(sb, gdp));
|
|
|
|
if (unlikely(!bitmap_bh))
|
|
|
|
goto make_io;
|
2006-10-11 08:20:50 +00:00
|
|
|
|
2021-08-26 13:04:08 +00:00
|
|
|
/*
|
|
|
|
* If the inode bitmap isn't in cache then the
|
|
|
|
* optimisation may end up performing two reads instead
|
|
|
|
* of one, so skip it.
|
|
|
|
*/
|
|
|
|
if (!buffer_uptodate(bitmap_bh)) {
|
2006-10-11 08:20:50 +00:00
|
|
|
brelse(bitmap_bh);
|
2021-08-26 13:04:08 +00:00
|
|
|
goto make_io;
|
2006-10-11 08:20:50 +00:00
|
|
|
}
|
2021-08-26 13:04:08 +00:00
|
|
|
for (i = start; i < start + inodes_per_block; i++) {
|
|
|
|
if (i == inode_offset)
|
|
|
|
continue;
|
|
|
|
if (ext4_test_bit(i, bitmap_bh->b_data))
|
|
|
|
break;
|
2006-10-11 08:20:50 +00:00
|
|
|
}
|
2021-08-26 13:04:08 +00:00
|
|
|
brelse(bitmap_bh);
|
|
|
|
if (i == start + inodes_per_block) {
|
ext4: prevent getting empty inode buffer
In ext4_get_inode_loc(), we may skip IO and get an zero && uptodate
inode buffer when the inode monopolize an inode block for performance
reason. For most cases, ext4_mark_iloc_dirty() will fill the inode
buffer to make it fine, but we could miss this call if something bad
happened. Finally, __ext4_get_inode_loc_noinmem() may probably get an
empty inode buffer and trigger ext4 error.
For example, if we remove a nonexistent xattr on inode A,
ext4_xattr_set_handle() will return ENODATA before invoking
ext4_mark_iloc_dirty(), it will left an uptodate but zero buffer. We
will get checksum error message in ext4_iget() when getting inode again.
EXT4-fs error (device sda): ext4_lookup:1784: inode #131074: comm cat: iget: checksum invalid
Even worse, if we allocate another inode B at the same inode block, it
will corrupt the inode A on disk when write back inode B.
So this patch initialize the inode buffer by filling the in-mem inode
contents if we skip read I/O, ensure that the buffer is really uptodate.
Signed-off-by: Zhang Yi <yi.zhang@huawei.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20210901020955.1657340-4-yi.zhang@huawei.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
2021-09-01 02:09:55 +00:00
|
|
|
struct ext4_inode *raw_inode =
|
|
|
|
(struct ext4_inode *) (bh->b_data + iloc->offset);
|
|
|
|
|
2021-08-26 13:04:08 +00:00
|
|
|
/* all other inodes are free, so skip I/O */
|
|
|
|
memset(bh->b_data, 0, bh->b_size);
|
ext4: prevent getting empty inode buffer
In ext4_get_inode_loc(), we may skip IO and get an zero && uptodate
inode buffer when the inode monopolize an inode block for performance
reason. For most cases, ext4_mark_iloc_dirty() will fill the inode
buffer to make it fine, but we could miss this call if something bad
happened. Finally, __ext4_get_inode_loc_noinmem() may probably get an
empty inode buffer and trigger ext4 error.
For example, if we remove a nonexistent xattr on inode A,
ext4_xattr_set_handle() will return ENODATA before invoking
ext4_mark_iloc_dirty(), it will left an uptodate but zero buffer. We
will get checksum error message in ext4_iget() when getting inode again.
EXT4-fs error (device sda): ext4_lookup:1784: inode #131074: comm cat: iget: checksum invalid
Even worse, if we allocate another inode B at the same inode block, it
will corrupt the inode A on disk when write back inode B.
So this patch initialize the inode buffer by filling the in-mem inode
contents if we skip read I/O, ensure that the buffer is really uptodate.
Signed-off-by: Zhang Yi <yi.zhang@huawei.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20210901020955.1657340-4-yi.zhang@huawei.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
2021-09-01 02:09:55 +00:00
|
|
|
if (!ext4_test_inode_state(inode, EXT4_STATE_NEW))
|
|
|
|
ext4_fill_raw_inode(inode, raw_inode);
|
2021-08-26 13:04:08 +00:00
|
|
|
set_buffer_uptodate(bh);
|
|
|
|
unlock_buffer(bh);
|
|
|
|
goto has_buffer;
|
|
|
|
}
|
|
|
|
}
|
2006-10-11 08:20:50 +00:00
|
|
|
|
|
|
|
make_io:
|
2021-08-26 13:04:08 +00:00
|
|
|
/*
|
|
|
|
* If we need to do any I/O, try to pre-readahead extra
|
|
|
|
* blocks from the inode table.
|
|
|
|
*/
|
|
|
|
blk_start_plug(&plug);
|
|
|
|
if (EXT4_SB(sb)->s_inode_readahead_blks) {
|
|
|
|
ext4_fsblk_t b, end, table;
|
|
|
|
unsigned num;
|
|
|
|
__u32 ra_blks = EXT4_SB(sb)->s_inode_readahead_blks;
|
|
|
|
|
|
|
|
table = ext4_inode_table(sb, gdp);
|
|
|
|
/* s_inode_readahead_blks is always a power of 2 */
|
|
|
|
b = block & ~((ext4_fsblk_t) ra_blks - 1);
|
|
|
|
if (table > b)
|
|
|
|
b = table;
|
|
|
|
end = b + ra_blks;
|
|
|
|
num = EXT4_INODES_PER_GROUP(sb);
|
|
|
|
if (ext4_has_group_desc_csum(sb))
|
|
|
|
num -= ext4_itable_unused_count(sb, gdp);
|
|
|
|
table += num / inodes_per_block;
|
|
|
|
if (end > table)
|
|
|
|
end = table;
|
|
|
|
while (b <= end)
|
|
|
|
ext4_sb_breadahead_unmovable(sb, b++);
|
|
|
|
}
|
2008-10-10 03:53:47 +00:00
|
|
|
|
2021-08-26 13:04:08 +00:00
|
|
|
/*
|
|
|
|
* There are other valid inodes in the buffer, this inode
|
|
|
|
* has in-inode xattrs, or we don't have this inode in memory.
|
|
|
|
* Read the block from disk.
|
|
|
|
*/
|
|
|
|
trace_ext4_load_inode(sb, ino);
|
2024-09-06 09:17:46 +00:00
|
|
|
ext4_read_bh_nowait(bh, REQ_META | REQ_PRIO, NULL,
|
|
|
|
ext4_simulate_fail(sb, EXT4_SIM_INODE_EIO));
|
2021-08-26 13:04:08 +00:00
|
|
|
blk_finish_plug(&plug);
|
|
|
|
wait_on_buffer(bh);
|
|
|
|
if (!buffer_uptodate(bh)) {
|
|
|
|
if (ret_block)
|
|
|
|
*ret_block = block;
|
|
|
|
brelse(bh);
|
|
|
|
return -EIO;
|
2006-10-11 08:20:50 +00:00
|
|
|
}
|
|
|
|
has_buffer:
|
|
|
|
iloc->bh = bh;
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2020-10-15 20:37:59 +00:00
|
|
|
static int __ext4_get_inode_loc_noinmem(struct inode *inode,
|
|
|
|
struct ext4_iloc *iloc)
|
|
|
|
{
|
2021-12-01 16:34:21 +00:00
|
|
|
ext4_fsblk_t err_blk = 0;
|
2020-10-15 20:37:59 +00:00
|
|
|
int ret;
|
|
|
|
|
ext4: prevent getting empty inode buffer
In ext4_get_inode_loc(), we may skip IO and get an zero && uptodate
inode buffer when the inode monopolize an inode block for performance
reason. For most cases, ext4_mark_iloc_dirty() will fill the inode
buffer to make it fine, but we could miss this call if something bad
happened. Finally, __ext4_get_inode_loc_noinmem() may probably get an
empty inode buffer and trigger ext4 error.
For example, if we remove a nonexistent xattr on inode A,
ext4_xattr_set_handle() will return ENODATA before invoking
ext4_mark_iloc_dirty(), it will left an uptodate but zero buffer. We
will get checksum error message in ext4_iget() when getting inode again.
EXT4-fs error (device sda): ext4_lookup:1784: inode #131074: comm cat: iget: checksum invalid
Even worse, if we allocate another inode B at the same inode block, it
will corrupt the inode A on disk when write back inode B.
So this patch initialize the inode buffer by filling the in-mem inode
contents if we skip read I/O, ensure that the buffer is really uptodate.
Signed-off-by: Zhang Yi <yi.zhang@huawei.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20210901020955.1657340-4-yi.zhang@huawei.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
2021-09-01 02:09:55 +00:00
|
|
|
ret = __ext4_get_inode_loc(inode->i_sb, inode->i_ino, NULL, iloc,
|
2020-10-15 20:37:59 +00:00
|
|
|
&err_blk);
|
|
|
|
|
|
|
|
if (ret == -EIO)
|
|
|
|
ext4_error_inode_block(inode, err_blk, EIO,
|
|
|
|
"unable to read itable block");
|
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2006-10-11 08:20:53 +00:00
|
|
|
int ext4_get_inode_loc(struct inode *inode, struct ext4_iloc *iloc)
|
2006-10-11 08:20:50 +00:00
|
|
|
{
|
2021-12-01 16:34:21 +00:00
|
|
|
ext4_fsblk_t err_blk = 0;
|
2020-10-15 20:37:59 +00:00
|
|
|
int ret;
|
|
|
|
|
ext4: prevent getting empty inode buffer
In ext4_get_inode_loc(), we may skip IO and get an zero && uptodate
inode buffer when the inode monopolize an inode block for performance
reason. For most cases, ext4_mark_iloc_dirty() will fill the inode
buffer to make it fine, but we could miss this call if something bad
happened. Finally, __ext4_get_inode_loc_noinmem() may probably get an
empty inode buffer and trigger ext4 error.
For example, if we remove a nonexistent xattr on inode A,
ext4_xattr_set_handle() will return ENODATA before invoking
ext4_mark_iloc_dirty(), it will left an uptodate but zero buffer. We
will get checksum error message in ext4_iget() when getting inode again.
EXT4-fs error (device sda): ext4_lookup:1784: inode #131074: comm cat: iget: checksum invalid
Even worse, if we allocate another inode B at the same inode block, it
will corrupt the inode A on disk when write back inode B.
So this patch initialize the inode buffer by filling the in-mem inode
contents if we skip read I/O, ensure that the buffer is really uptodate.
Signed-off-by: Zhang Yi <yi.zhang@huawei.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20210901020955.1657340-4-yi.zhang@huawei.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
2021-09-01 02:09:55 +00:00
|
|
|
ret = __ext4_get_inode_loc(inode->i_sb, inode->i_ino, inode, iloc,
|
|
|
|
&err_blk);
|
2020-10-15 20:37:59 +00:00
|
|
|
|
|
|
|
if (ret == -EIO)
|
|
|
|
ext4_error_inode_block(inode, err_blk, EIO,
|
|
|
|
"unable to read itable block");
|
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
int ext4_get_fc_inode_loc(struct super_block *sb, unsigned long ino,
|
|
|
|
struct ext4_iloc *iloc)
|
|
|
|
{
|
ext4: prevent getting empty inode buffer
In ext4_get_inode_loc(), we may skip IO and get an zero && uptodate
inode buffer when the inode monopolize an inode block for performance
reason. For most cases, ext4_mark_iloc_dirty() will fill the inode
buffer to make it fine, but we could miss this call if something bad
happened. Finally, __ext4_get_inode_loc_noinmem() may probably get an
empty inode buffer and trigger ext4 error.
For example, if we remove a nonexistent xattr on inode A,
ext4_xattr_set_handle() will return ENODATA before invoking
ext4_mark_iloc_dirty(), it will left an uptodate but zero buffer. We
will get checksum error message in ext4_iget() when getting inode again.
EXT4-fs error (device sda): ext4_lookup:1784: inode #131074: comm cat: iget: checksum invalid
Even worse, if we allocate another inode B at the same inode block, it
will corrupt the inode A on disk when write back inode B.
So this patch initialize the inode buffer by filling the in-mem inode
contents if we skip read I/O, ensure that the buffer is really uptodate.
Signed-off-by: Zhang Yi <yi.zhang@huawei.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20210901020955.1657340-4-yi.zhang@huawei.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
2021-09-01 02:09:55 +00:00
|
|
|
return __ext4_get_inode_loc(sb, ino, NULL, iloc, NULL);
|
2006-10-11 08:20:50 +00:00
|
|
|
}
|
|
|
|
|
2020-05-28 14:59:58 +00:00
|
|
|
static bool ext4_should_enable_dax(struct inode *inode)
|
2017-10-12 16:00:59 +00:00
|
|
|
{
|
2020-05-28 14:59:58 +00:00
|
|
|
struct ext4_sb_info *sbi = EXT4_SB(inode->i_sb);
|
|
|
|
|
2020-05-28 15:00:00 +00:00
|
|
|
if (test_opt2(inode->i_sb, DAX_NEVER))
|
2017-10-12 16:00:59 +00:00
|
|
|
return false;
|
|
|
|
if (!S_ISREG(inode->i_mode))
|
|
|
|
return false;
|
|
|
|
if (ext4_should_journal_data(inode))
|
|
|
|
return false;
|
|
|
|
if (ext4_has_inline_data(inode))
|
|
|
|
return false;
|
2018-12-12 09:50:10 +00:00
|
|
|
if (ext4_test_inode_flag(inode, EXT4_INODE_ENCRYPT))
|
2017-10-12 16:00:59 +00:00
|
|
|
return false;
|
2019-07-22 16:26:24 +00:00
|
|
|
if (ext4_test_inode_flag(inode, EXT4_INODE_VERITY))
|
|
|
|
return false;
|
2020-05-28 14:59:58 +00:00
|
|
|
if (!test_bit(EXT4_FLAGS_BDEV_IS_DAX, &sbi->s_ext4_flags))
|
|
|
|
return false;
|
|
|
|
if (test_opt(inode->i_sb, DAX_ALWAYS))
|
|
|
|
return true;
|
|
|
|
|
2020-05-28 15:00:02 +00:00
|
|
|
return ext4_test_inode_flag(inode, EXT4_INODE_DAX);
|
2017-10-12 16:00:59 +00:00
|
|
|
}
|
|
|
|
|
2020-05-28 14:59:59 +00:00
|
|
|
void ext4_set_inode_flags(struct inode *inode, bool init)
|
2006-10-11 08:20:50 +00:00
|
|
|
{
|
2006-10-11 08:20:53 +00:00
|
|
|
unsigned int flags = EXT4_I(inode)->i_flags;
|
2014-03-30 14:20:01 +00:00
|
|
|
unsigned int new_fl = 0;
|
2006-10-11 08:20:50 +00:00
|
|
|
|
2020-05-28 14:59:59 +00:00
|
|
|
WARN_ON_ONCE(IS_DAX(inode) && init);
|
|
|
|
|
2006-10-11 08:20:53 +00:00
|
|
|
if (flags & EXT4_SYNC_FL)
|
2014-03-30 14:20:01 +00:00
|
|
|
new_fl |= S_SYNC;
|
2006-10-11 08:20:53 +00:00
|
|
|
if (flags & EXT4_APPEND_FL)
|
2014-03-30 14:20:01 +00:00
|
|
|
new_fl |= S_APPEND;
|
2006-10-11 08:20:53 +00:00
|
|
|
if (flags & EXT4_IMMUTABLE_FL)
|
2014-03-30 14:20:01 +00:00
|
|
|
new_fl |= S_IMMUTABLE;
|
2006-10-11 08:20:53 +00:00
|
|
|
if (flags & EXT4_NOATIME_FL)
|
2014-03-30 14:20:01 +00:00
|
|
|
new_fl |= S_NOATIME;
|
2006-10-11 08:20:53 +00:00
|
|
|
if (flags & EXT4_DIRSYNC_FL)
|
2014-03-30 14:20:01 +00:00
|
|
|
new_fl |= S_DIRSYNC;
|
2020-05-28 14:59:59 +00:00
|
|
|
|
|
|
|
/* Because of the way inode_set_flags() works we must preserve S_DAX
|
|
|
|
* here if already set. */
|
|
|
|
new_fl |= (inode->i_flags & S_DAX);
|
|
|
|
if (init && ext4_should_enable_dax(inode))
|
2015-02-16 23:59:38 +00:00
|
|
|
new_fl |= S_DAX;
|
2020-05-28 14:59:59 +00:00
|
|
|
|
2017-10-09 19:15:35 +00:00
|
|
|
if (flags & EXT4_ENCRYPT_FL)
|
|
|
|
new_fl |= S_ENCRYPTED;
|
ext4: Support case-insensitive file name lookups
This patch implements the actual support for case-insensitive file name
lookups in ext4, based on the feature bit and the encoding stored in the
superblock.
A filesystem that has the casefold feature set is able to configure
directories with the +F (EXT4_CASEFOLD_FL) attribute, enabling lookups
to succeed in that directory in a case-insensitive fashion, i.e: match
a directory entry even if the name used by userspace is not a byte per
byte match with the disk name, but is an equivalent case-insensitive
version of the Unicode string. This operation is called a
case-insensitive file name lookup.
The feature is configured as an inode attribute applied to directories
and inherited by its children. This attribute can only be enabled on
empty directories for filesystems that support the encoding feature,
thus preventing collision of file names that only differ by case.
* dcache handling:
For a +F directory, Ext4 only stores the first equivalent name dentry
used in the dcache. This is done to prevent unintentional duplication of
dentries in the dcache, while also allowing the VFS code to quickly find
the right entry in the cache despite which equivalent string was used in
a previous lookup, without having to resort to ->lookup().
d_hash() of casefolded directories is implemented as the hash of the
casefolded string, such that we always have a well-known bucket for all
the equivalencies of the same string. d_compare() uses the
utf8_strncasecmp() infrastructure, which handles the comparison of
equivalent, same case, names as well.
For now, negative lookups are not inserted in the dcache, since they
would need to be invalidated anyway, because we can't trust missing file
dentries. This is bad for performance but requires some leveraging of
the vfs layer to fix. We can live without that for now, and so does
everyone else.
* on-disk data:
Despite using a specific version of the name as the internal
representation within the dcache, the name stored and fetched from the
disk is a byte-per-byte match with what the user requested, making this
implementation 'name-preserving'. i.e. no actual information is lost
when writing to storage.
DX is supported by modifying the hashes used in +F directories to make
them case/encoding-aware. The new disk hashes are calculated as the
hash of the full casefolded string, instead of the string directly.
This allows us to efficiently search for file names in the htree without
requiring the user to provide an exact name.
* Dealing with invalid sequences:
By default, when a invalid UTF-8 sequence is identified, ext4 will treat
it as an opaque byte sequence, ignoring the encoding and reverting to
the old behavior for that unique file. This means that case-insensitive
file name lookup will not work only for that file. An optional bit can
be set in the superblock telling the filesystem code and userspace tools
to enforce the encoding. When that optional bit is set, any attempt to
create a file name using an invalid UTF-8 sequence will fail and return
an error to userspace.
* Normalization algorithm:
The UTF-8 algorithms used to compare strings in ext4 is implemented
lives in fs/unicode, and is based on a previous version developed by
SGI. It implements the Canonical decomposition (NFD) algorithm
described by the Unicode specification 12.1, or higher, combined with
the elimination of ignorable code points (NFDi) and full
case-folding (CF) as documented in fs/unicode/utf8_norm.c.
NFD seems to be the best normalization method for EXT4 because:
- It has a lower cost than NFC/NFKC (which requires
decomposing to NFD as an intermediary step)
- It doesn't eliminate important semantic meaning like
compatibility decompositions.
Although:
- This implementation is not completely linguistic accurate, because
different languages have conflicting rules, which would require the
specialization of the filesystem to a given locale, which brings all
sorts of problems for removable media and for users who use more than
one language.
Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.co.uk>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
2019-04-25 18:12:08 +00:00
|
|
|
if (flags & EXT4_CASEFOLD_FL)
|
|
|
|
new_fl |= S_CASEFOLD;
|
2019-07-22 16:26:24 +00:00
|
|
|
if (flags & EXT4_VERITY_FL)
|
|
|
|
new_fl |= S_VERITY;
|
2014-03-24 18:43:12 +00:00
|
|
|
inode_set_flags(inode, new_fl,
|
2017-10-09 19:15:35 +00:00
|
|
|
S_SYNC|S_APPEND|S_IMMUTABLE|S_NOATIME|S_DIRSYNC|S_DAX|
|
2019-07-22 16:26:24 +00:00
|
|
|
S_ENCRYPTED|S_CASEFOLD|S_VERITY);
|
2006-10-11 08:20:50 +00:00
|
|
|
}
|
|
|
|
|
2008-01-29 04:58:26 +00:00
|
|
|
static blkcnt_t ext4_inode_blocks(struct ext4_inode *raw_inode,
|
2009-06-14 21:45:34 +00:00
|
|
|
struct ext4_inode_info *ei)
|
2008-01-29 04:58:26 +00:00
|
|
|
{
|
|
|
|
blkcnt_t i_blocks ;
|
2008-01-29 04:58:27 +00:00
|
|
|
struct inode *inode = &(ei->vfs_inode);
|
|
|
|
struct super_block *sb = inode->i_sb;
|
2008-01-29 04:58:26 +00:00
|
|
|
|
2015-10-17 20:18:43 +00:00
|
|
|
if (ext4_has_feature_huge_file(sb)) {
|
2008-01-29 04:58:26 +00:00
|
|
|
/* we are using combined 48 bit field */
|
|
|
|
i_blocks = ((u64)le16_to_cpu(raw_inode->i_blocks_high)) << 32 |
|
|
|
|
le32_to_cpu(raw_inode->i_blocks_lo);
|
2010-06-14 13:54:48 +00:00
|
|
|
if (ext4_test_inode_flag(inode, EXT4_INODE_HUGE_FILE)) {
|
2008-01-29 04:58:27 +00:00
|
|
|
/* i_blocks represent file system block size */
|
|
|
|
return i_blocks << (inode->i_blkbits - 9);
|
|
|
|
} else {
|
|
|
|
return i_blocks;
|
|
|
|
}
|
2008-01-29 04:58:26 +00:00
|
|
|
} else {
|
|
|
|
return le32_to_cpu(raw_inode->i_blocks_lo);
|
|
|
|
}
|
|
|
|
}
|
2007-07-18 13:24:20 +00:00
|
|
|
|
2018-05-22 21:14:07 +00:00
|
|
|
static inline int ext4_iget_extra_inode(struct inode *inode,
|
2012-12-02 16:13:24 +00:00
|
|
|
struct ext4_inode *raw_inode,
|
|
|
|
struct ext4_inode_info *ei)
|
|
|
|
{
|
|
|
|
__le32 *magic = (void *)raw_inode +
|
|
|
|
EXT4_GOOD_OLD_INODE_SIZE + ei->i_extra_isize;
|
2018-05-22 21:14:07 +00:00
|
|
|
|
2022-06-16 02:13:58 +00:00
|
|
|
if (EXT4_INODE_HAS_XATTR_SPACE(inode) &&
|
2016-12-01 19:51:58 +00:00
|
|
|
*magic == cpu_to_le32(EXT4_XATTR_MAGIC)) {
|
2023-03-07 01:52:52 +00:00
|
|
|
int err;
|
|
|
|
|
2012-12-02 16:13:24 +00:00
|
|
|
ext4_set_inode_state(inode, EXT4_STATE_XATTR);
|
2023-03-07 01:52:52 +00:00
|
|
|
err = ext4_find_inline_data_nolock(inode);
|
|
|
|
if (!err && ext4_has_inline_data(inode))
|
|
|
|
ext4_set_inode_state(inode, EXT4_STATE_MAY_INLINE_DATA);
|
|
|
|
return err;
|
2012-12-10 19:05:51 +00:00
|
|
|
} else
|
|
|
|
EXT4_I(inode)->i_inline_off = 0;
|
2018-05-22 21:14:07 +00:00
|
|
|
return 0;
|
2012-12-02 16:13:24 +00:00
|
|
|
}
|
|
|
|
|
2016-01-08 21:01:21 +00:00
|
|
|
int ext4_get_projid(struct inode *inode, kprojid_t *projid)
|
|
|
|
{
|
2016-09-06 03:11:58 +00:00
|
|
|
if (!ext4_has_feature_project(inode->i_sb))
|
2016-01-08 21:01:21 +00:00
|
|
|
return -EOPNOTSUPP;
|
|
|
|
*projid = EXT4_I(inode)->i_projid;
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2018-05-10 15:55:31 +00:00
|
|
|
/*
|
|
|
|
* ext4 has self-managed i_version for ea inodes, it stores the lower 32bit of
|
|
|
|
* refcount in i_version, so use raw values if inode has EXT4_EA_INODE_FL flag
|
|
|
|
* set.
|
|
|
|
*/
|
|
|
|
static inline void ext4_inode_set_iversion_queried(struct inode *inode, u64 val)
|
|
|
|
{
|
|
|
|
if (unlikely(EXT4_I(inode)->i_flags & EXT4_EA_INODE_FL))
|
|
|
|
inode_set_iversion_raw(inode, val);
|
|
|
|
else
|
|
|
|
inode_set_iversion_queried(inode, val);
|
|
|
|
}
|
|
|
|
|
2023-05-24 03:49:48 +00:00
|
|
|
static const char *check_igot_inode(struct inode *inode, ext4_iget_flags flags)
|
|
|
|
|
|
|
|
{
|
|
|
|
if (flags & EXT4_IGET_EA_INODE) {
|
|
|
|
if (!(EXT4_I(inode)->i_flags & EXT4_EA_INODE_FL))
|
|
|
|
return "missing EA_INODE flag";
|
2023-05-24 03:49:50 +00:00
|
|
|
if (ext4_test_inode_state(inode, EXT4_STATE_XATTR) ||
|
|
|
|
EXT4_I(inode)->i_file_acl)
|
|
|
|
return "ea_inode with extended attributes";
|
2023-05-24 03:49:48 +00:00
|
|
|
} else {
|
|
|
|
if ((EXT4_I(inode)->i_flags & EXT4_EA_INODE_FL))
|
|
|
|
return "unexpected EA_INODE flag";
|
|
|
|
}
|
|
|
|
if (is_bad_inode(inode) && !(flags & EXT4_IGET_BAD))
|
|
|
|
return "unexpected bad inode w/o EXT4_IGET_BAD";
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
ext4: avoid declaring fs inconsistent due to invalid file handles
If we receive a file handle, either from NFS or open_by_handle_at(2),
and it points at an inode which has not been initialized, and the file
system has metadata checksums enabled, we shouldn't try to get the
inode, discover the checksum is invalid, and then declare the file
system as being inconsistent.
This can be reproduced by creating a test file system via "mke2fs -t
ext4 -O metadata_csum /tmp/foo.img 8M", mounting it, cd'ing into that
directory, and then running the following program.
#define _GNU_SOURCE
#include <fcntl.h>
struct handle {
struct file_handle fh;
unsigned char fid[MAX_HANDLE_SZ];
};
int main(int argc, char **argv)
{
struct handle h = {{8, 1 }, { 12, }};
open_by_handle_at(AT_FDCWD, &h.fh, O_RDONLY);
return 0;
}
Google-Bug-Id: 120690101
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@kernel.org
2018-12-19 17:29:13 +00:00
|
|
|
struct inode *__ext4_iget(struct super_block *sb, unsigned long ino,
|
|
|
|
ext4_iget_flags flags, const char *function,
|
|
|
|
unsigned int line)
|
2006-10-11 08:20:50 +00:00
|
|
|
{
|
2006-10-11 08:20:53 +00:00
|
|
|
struct ext4_iloc iloc;
|
|
|
|
struct ext4_inode *raw_inode;
|
2008-02-07 08:15:37 +00:00
|
|
|
struct ext4_inode_info *ei;
|
2021-08-12 13:31:22 +00:00
|
|
|
struct ext4_super_block *es = EXT4_SB(sb)->s_es;
|
2008-02-07 08:15:37 +00:00
|
|
|
struct inode *inode;
|
2023-05-24 03:49:48 +00:00
|
|
|
const char *err_str;
|
2009-12-09 04:51:10 +00:00
|
|
|
journal_t *journal = EXT4_SB(sb)->s_journal;
|
2008-02-07 08:15:37 +00:00
|
|
|
long ret;
|
2016-12-10 14:55:01 +00:00
|
|
|
loff_t size;
|
2006-10-11 08:20:50 +00:00
|
|
|
int block;
|
2012-02-07 23:41:49 +00:00
|
|
|
uid_t i_uid;
|
|
|
|
gid_t i_gid;
|
2016-01-08 21:01:21 +00:00
|
|
|
projid_t i_projid;
|
2006-10-11 08:20:50 +00:00
|
|
|
|
2019-01-01 03:34:31 +00:00
|
|
|
if ((!(flags & EXT4_IGET_SPECIAL) &&
|
2021-08-12 13:31:22 +00:00
|
|
|
((ino < EXT4_FIRST_INO(sb) && ino != EXT4_ROOT_INO) ||
|
|
|
|
ino == le32_to_cpu(es->s_usr_quota_inum) ||
|
|
|
|
ino == le32_to_cpu(es->s_grp_quota_inum) ||
|
2021-08-16 09:57:06 +00:00
|
|
|
ino == le32_to_cpu(es->s_prj_quota_inum) ||
|
|
|
|
ino == le32_to_cpu(es->s_orphan_file_inum))) ||
|
ext4: avoid declaring fs inconsistent due to invalid file handles
If we receive a file handle, either from NFS or open_by_handle_at(2),
and it points at an inode which has not been initialized, and the file
system has metadata checksums enabled, we shouldn't try to get the
inode, discover the checksum is invalid, and then declare the file
system as being inconsistent.
This can be reproduced by creating a test file system via "mke2fs -t
ext4 -O metadata_csum /tmp/foo.img 8M", mounting it, cd'ing into that
directory, and then running the following program.
#define _GNU_SOURCE
#include <fcntl.h>
struct handle {
struct file_handle fh;
unsigned char fid[MAX_HANDLE_SZ];
};
int main(int argc, char **argv)
{
struct handle h = {{8, 1 }, { 12, }};
open_by_handle_at(AT_FDCWD, &h.fh, O_RDONLY);
return 0;
}
Google-Bug-Id: 120690101
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@kernel.org
2018-12-19 17:29:13 +00:00
|
|
|
(ino < EXT4_ROOT_INO) ||
|
2021-08-12 13:31:22 +00:00
|
|
|
(ino > le32_to_cpu(es->s_inodes_count))) {
|
ext4: avoid declaring fs inconsistent due to invalid file handles
If we receive a file handle, either from NFS or open_by_handle_at(2),
and it points at an inode which has not been initialized, and the file
system has metadata checksums enabled, we shouldn't try to get the
inode, discover the checksum is invalid, and then declare the file
system as being inconsistent.
This can be reproduced by creating a test file system via "mke2fs -t
ext4 -O metadata_csum /tmp/foo.img 8M", mounting it, cd'ing into that
directory, and then running the following program.
#define _GNU_SOURCE
#include <fcntl.h>
struct handle {
struct file_handle fh;
unsigned char fid[MAX_HANDLE_SZ];
};
int main(int argc, char **argv)
{
struct handle h = {{8, 1 }, { 12, }};
open_by_handle_at(AT_FDCWD, &h.fh, O_RDONLY);
return 0;
}
Google-Bug-Id: 120690101
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@kernel.org
2018-12-19 17:29:13 +00:00
|
|
|
if (flags & EXT4_IGET_HANDLE)
|
|
|
|
return ERR_PTR(-ESTALE);
|
2020-11-27 11:33:57 +00:00
|
|
|
__ext4_error(sb, function, line, false, EFSCORRUPTED, 0,
|
ext4: avoid declaring fs inconsistent due to invalid file handles
If we receive a file handle, either from NFS or open_by_handle_at(2),
and it points at an inode which has not been initialized, and the file
system has metadata checksums enabled, we shouldn't try to get the
inode, discover the checksum is invalid, and then declare the file
system as being inconsistent.
This can be reproduced by creating a test file system via "mke2fs -t
ext4 -O metadata_csum /tmp/foo.img 8M", mounting it, cd'ing into that
directory, and then running the following program.
#define _GNU_SOURCE
#include <fcntl.h>
struct handle {
struct file_handle fh;
unsigned char fid[MAX_HANDLE_SZ];
};
int main(int argc, char **argv)
{
struct handle h = {{8, 1 }, { 12, }};
open_by_handle_at(AT_FDCWD, &h.fh, O_RDONLY);
return 0;
}
Google-Bug-Id: 120690101
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@kernel.org
2018-12-19 17:29:13 +00:00
|
|
|
"inode #%lu: comm %s: iget: illegal inode #",
|
|
|
|
ino, current->comm);
|
|
|
|
return ERR_PTR(-EFSCORRUPTED);
|
|
|
|
}
|
|
|
|
|
2008-02-07 08:15:37 +00:00
|
|
|
inode = iget_locked(sb, ino);
|
|
|
|
if (!inode)
|
|
|
|
return ERR_PTR(-ENOMEM);
|
2023-05-24 03:49:48 +00:00
|
|
|
if (!(inode->i_state & I_NEW)) {
|
|
|
|
if ((err_str = check_igot_inode(inode, flags)) != NULL) {
|
|
|
|
ext4_error_inode(inode, function, line, 0, err_str);
|
|
|
|
iput(inode);
|
|
|
|
return ERR_PTR(-EFSCORRUPTED);
|
|
|
|
}
|
2008-02-07 08:15:37 +00:00
|
|
|
return inode;
|
2023-05-24 03:49:48 +00:00
|
|
|
}
|
2008-02-07 08:15:37 +00:00
|
|
|
|
|
|
|
ei = EXT4_I(inode);
|
2011-02-22 02:01:42 +00:00
|
|
|
iloc.bh = NULL;
|
2006-10-11 08:20:50 +00:00
|
|
|
|
2020-10-15 20:37:59 +00:00
|
|
|
ret = __ext4_get_inode_loc_noinmem(inode, &iloc);
|
2008-02-07 08:15:37 +00:00
|
|
|
if (ret < 0)
|
2006-10-11 08:20:50 +00:00
|
|
|
goto bad_inode;
|
2006-10-11 08:20:53 +00:00
|
|
|
raw_inode = ext4_raw_inode(&iloc);
|
2012-04-29 22:31:10 +00:00
|
|
|
|
ext4: avoid declaring fs inconsistent due to invalid file handles
If we receive a file handle, either from NFS or open_by_handle_at(2),
and it points at an inode which has not been initialized, and the file
system has metadata checksums enabled, we shouldn't try to get the
inode, discover the checksum is invalid, and then declare the file
system as being inconsistent.
This can be reproduced by creating a test file system via "mke2fs -t
ext4 -O metadata_csum /tmp/foo.img 8M", mounting it, cd'ing into that
directory, and then running the following program.
#define _GNU_SOURCE
#include <fcntl.h>
struct handle {
struct file_handle fh;
unsigned char fid[MAX_HANDLE_SZ];
};
int main(int argc, char **argv)
{
struct handle h = {{8, 1 }, { 12, }};
open_by_handle_at(AT_FDCWD, &h.fh, O_RDONLY);
return 0;
}
Google-Bug-Id: 120690101
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@kernel.org
2018-12-19 17:29:13 +00:00
|
|
|
if ((flags & EXT4_IGET_HANDLE) &&
|
|
|
|
(raw_inode->i_links_count == 0) && (raw_inode->i_mode == 0)) {
|
|
|
|
ret = -ESTALE;
|
|
|
|
goto bad_inode;
|
|
|
|
}
|
|
|
|
|
2012-04-29 22:31:10 +00:00
|
|
|
if (EXT4_INODE_SIZE(inode->i_sb) > EXT4_GOOD_OLD_INODE_SIZE) {
|
|
|
|
ei->i_extra_isize = le16_to_cpu(raw_inode->i_extra_isize);
|
|
|
|
if (EXT4_GOOD_OLD_INODE_SIZE + ei->i_extra_isize >
|
2016-12-01 19:43:33 +00:00
|
|
|
EXT4_INODE_SIZE(inode->i_sb) ||
|
|
|
|
(ei->i_extra_isize & 3)) {
|
ext4: avoid declaring fs inconsistent due to invalid file handles
If we receive a file handle, either from NFS or open_by_handle_at(2),
and it points at an inode which has not been initialized, and the file
system has metadata checksums enabled, we shouldn't try to get the
inode, discover the checksum is invalid, and then declare the file
system as being inconsistent.
This can be reproduced by creating a test file system via "mke2fs -t
ext4 -O metadata_csum /tmp/foo.img 8M", mounting it, cd'ing into that
directory, and then running the following program.
#define _GNU_SOURCE
#include <fcntl.h>
struct handle {
struct file_handle fh;
unsigned char fid[MAX_HANDLE_SZ];
};
int main(int argc, char **argv)
{
struct handle h = {{8, 1 }, { 12, }};
open_by_handle_at(AT_FDCWD, &h.fh, O_RDONLY);
return 0;
}
Google-Bug-Id: 120690101
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@kernel.org
2018-12-19 17:29:13 +00:00
|
|
|
ext4_error_inode(inode, function, line, 0,
|
|
|
|
"iget: bad extra_isize %u "
|
|
|
|
"(inode size %u)",
|
2016-12-01 19:43:33 +00:00
|
|
|
ei->i_extra_isize,
|
|
|
|
EXT4_INODE_SIZE(inode->i_sb));
|
2015-10-17 20:16:04 +00:00
|
|
|
ret = -EFSCORRUPTED;
|
2012-04-29 22:31:10 +00:00
|
|
|
goto bad_inode;
|
|
|
|
}
|
|
|
|
} else
|
|
|
|
ei->i_extra_isize = 0;
|
|
|
|
|
|
|
|
/* Precompute checksum seed for inode metadata */
|
2014-10-13 07:36:16 +00:00
|
|
|
if (ext4_has_metadata_csum(sb)) {
|
2012-04-29 22:31:10 +00:00
|
|
|
struct ext4_sb_info *sbi = EXT4_SB(inode->i_sb);
|
|
|
|
__u32 csum;
|
|
|
|
__le32 inum = cpu_to_le32(inode->i_ino);
|
|
|
|
__le32 gen = raw_inode->i_generation;
|
|
|
|
csum = ext4_chksum(sbi, sbi->s_csum_seed, (__u8 *)&inum,
|
|
|
|
sizeof(inum));
|
|
|
|
ei->i_csum_seed = ext4_chksum(sbi, csum, (__u8 *)&gen,
|
|
|
|
sizeof(gen));
|
|
|
|
}
|
|
|
|
|
2020-10-15 20:37:59 +00:00
|
|
|
if ((!ext4_inode_csum_verify(inode, raw_inode, ei) ||
|
|
|
|
ext4_simulate_fail(sb, EXT4_SIM_INODE_CRC)) &&
|
|
|
|
(!(EXT4_SB(sb)->s_mount_state & EXT4_FC_REPLAY))) {
|
|
|
|
ext4_error_inode_err(inode, function, line, 0,
|
|
|
|
EFSBADCRC, "iget: checksum invalid");
|
2015-10-17 20:16:04 +00:00
|
|
|
ret = -EFSBADCRC;
|
2012-04-29 22:31:10 +00:00
|
|
|
goto bad_inode;
|
|
|
|
}
|
|
|
|
|
2006-10-11 08:20:50 +00:00
|
|
|
inode->i_mode = le16_to_cpu(raw_inode->i_mode);
|
2012-02-07 23:41:49 +00:00
|
|
|
i_uid = (uid_t)le16_to_cpu(raw_inode->i_uid_low);
|
|
|
|
i_gid = (gid_t)le16_to_cpu(raw_inode->i_gid_low);
|
2016-09-06 03:11:58 +00:00
|
|
|
if (ext4_has_feature_project(sb) &&
|
2016-01-08 21:01:21 +00:00
|
|
|
EXT4_INODE_SIZE(sb) > EXT4_GOOD_OLD_INODE_SIZE &&
|
|
|
|
EXT4_FITS_IN_INODE(raw_inode, ei, i_projid))
|
|
|
|
i_projid = (projid_t)le32_to_cpu(raw_inode->i_projid);
|
|
|
|
else
|
|
|
|
i_projid = EXT4_DEF_PROJID;
|
|
|
|
|
2008-09-09 02:25:24 +00:00
|
|
|
if (!(test_opt(inode->i_sb, NO_UID32))) {
|
2012-02-07 23:41:49 +00:00
|
|
|
i_uid |= le16_to_cpu(raw_inode->i_uid_high) << 16;
|
|
|
|
i_gid |= le16_to_cpu(raw_inode->i_gid_high) << 16;
|
2006-10-11 08:20:50 +00:00
|
|
|
}
|
2012-02-07 23:41:49 +00:00
|
|
|
i_uid_write(inode, i_uid);
|
|
|
|
i_gid_write(inode, i_gid);
|
2016-01-08 21:01:21 +00:00
|
|
|
ei->i_projid = make_kprojid(&init_user_ns, i_projid);
|
2011-10-28 12:13:29 +00:00
|
|
|
set_nlink(inode, le16_to_cpu(raw_inode->i_links_count));
|
2006-10-11 08:20:50 +00:00
|
|
|
|
2011-01-10 17:18:25 +00:00
|
|
|
ext4_clear_state_flags(ei); /* Only relevant on 32-bit archs */
|
2012-12-10 19:04:46 +00:00
|
|
|
ei->i_inline_off = 0;
|
2006-10-11 08:20:50 +00:00
|
|
|
ei->i_dir_start_lookup = 0;
|
|
|
|
ei->i_dtime = le32_to_cpu(raw_inode->i_dtime);
|
|
|
|
/* We now have enough fields to check if the inode was active or not.
|
|
|
|
* This is needed because nfsd might try to access dead inodes
|
|
|
|
* the test is that same one that e2fsck uses
|
|
|
|
* NeilBrown 1999oct15
|
|
|
|
*/
|
|
|
|
if (inode->i_nlink == 0) {
|
2023-01-07 03:21:25 +00:00
|
|
|
if ((inode->i_mode == 0 || flags & EXT4_IGET_SPECIAL ||
|
2013-04-08 16:54:05 +00:00
|
|
|
!(EXT4_SB(inode->i_sb)->s_mount_state & EXT4_ORPHAN_FS)) &&
|
|
|
|
ino != EXT4_BOOT_LOADER_INO) {
|
2023-01-07 03:21:25 +00:00
|
|
|
/* this inode is deleted or unallocated */
|
|
|
|
if (flags & EXT4_IGET_SPECIAL) {
|
|
|
|
ext4_error_inode(inode, function, line, 0,
|
|
|
|
"iget: special inode unallocated");
|
|
|
|
ret = -EFSCORRUPTED;
|
|
|
|
} else
|
|
|
|
ret = -ESTALE;
|
2006-10-11 08:20:50 +00:00
|
|
|
goto bad_inode;
|
|
|
|
}
|
|
|
|
/* The only unlinked inodes we let through here have
|
|
|
|
* valid i_mode and are being read by the orphan
|
|
|
|
* recovery code: that's fine, we're about to complete
|
2013-04-08 16:54:05 +00:00
|
|
|
* the process of deleting those.
|
|
|
|
* OR it is the EXT4_BOOT_LOADER_INO which is
|
|
|
|
* not initialized on a new filesystem. */
|
2006-10-11 08:20:50 +00:00
|
|
|
}
|
|
|
|
ei->i_flags = le32_to_cpu(raw_inode->i_flags);
|
2020-05-28 14:59:59 +00:00
|
|
|
ext4_set_inode_flags(inode, true);
|
2008-01-29 04:58:26 +00:00
|
|
|
inode->i_blocks = ext4_inode_blocks(raw_inode, ei);
|
2008-01-29 04:58:27 +00:00
|
|
|
ei->i_file_acl = le32_to_cpu(raw_inode->i_file_acl_lo);
|
2015-10-17 20:18:43 +00:00
|
|
|
if (ext4_has_feature_64bit(sb))
|
2006-10-11 08:21:09 +00:00
|
|
|
ei->i_file_acl |=
|
|
|
|
((__u64)le16_to_cpu(raw_inode->i_file_acl_high)) << 32;
|
2017-06-22 01:09:57 +00:00
|
|
|
inode->i_size = ext4_isize(sb, raw_inode);
|
2016-12-10 14:55:01 +00:00
|
|
|
if ((size = i_size_read(inode)) < 0) {
|
ext4: avoid declaring fs inconsistent due to invalid file handles
If we receive a file handle, either from NFS or open_by_handle_at(2),
and it points at an inode which has not been initialized, and the file
system has metadata checksums enabled, we shouldn't try to get the
inode, discover the checksum is invalid, and then declare the file
system as being inconsistent.
This can be reproduced by creating a test file system via "mke2fs -t
ext4 -O metadata_csum /tmp/foo.img 8M", mounting it, cd'ing into that
directory, and then running the following program.
#define _GNU_SOURCE
#include <fcntl.h>
struct handle {
struct file_handle fh;
unsigned char fid[MAX_HANDLE_SZ];
};
int main(int argc, char **argv)
{
struct handle h = {{8, 1 }, { 12, }};
open_by_handle_at(AT_FDCWD, &h.fh, O_RDONLY);
return 0;
}
Google-Bug-Id: 120690101
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@kernel.org
2018-12-19 17:29:13 +00:00
|
|
|
ext4_error_inode(inode, function, line, 0,
|
|
|
|
"iget: bad i_size value: %lld", size);
|
2016-12-10 14:55:01 +00:00
|
|
|
ret = -EFSCORRUPTED;
|
|
|
|
goto bad_inode;
|
|
|
|
}
|
2020-02-10 14:43:16 +00:00
|
|
|
/*
|
|
|
|
* If dir_index is not enabled but there's dir with INDEX flag set,
|
|
|
|
* we'd normally treat htree data as empty space. But with metadata
|
|
|
|
* checksumming that corrupts checksums so forbid that.
|
|
|
|
*/
|
|
|
|
if (!ext4_has_feature_dir_index(sb) && ext4_has_metadata_csum(sb) &&
|
|
|
|
ext4_test_inode_flag(inode, EXT4_INODE_INDEX)) {
|
|
|
|
ext4_error_inode(inode, function, line, 0,
|
|
|
|
"iget: Dir with htree data on filesystem without dir_index feature.");
|
|
|
|
ret = -EFSCORRUPTED;
|
|
|
|
goto bad_inode;
|
|
|
|
}
|
2006-10-11 08:20:50 +00:00
|
|
|
ei->i_disksize = inode->i_size;
|
2009-12-14 12:21:14 +00:00
|
|
|
#ifdef CONFIG_QUOTA
|
|
|
|
ei->i_reserved_quota = 0;
|
|
|
|
#endif
|
2006-10-11 08:20:50 +00:00
|
|
|
inode->i_generation = le32_to_cpu(raw_inode->i_generation);
|
|
|
|
ei->i_block_group = iloc.block_group;
|
2009-03-12 16:18:34 +00:00
|
|
|
ei->i_last_alloc_group = ~0;
|
2006-10-11 08:20:50 +00:00
|
|
|
/*
|
|
|
|
* NOTE! The in-memory inode i_data array is in little-endian order
|
|
|
|
* even on big-endian machines: we do NOT byteswap the block numbers!
|
|
|
|
*/
|
2006-10-11 08:20:53 +00:00
|
|
|
for (block = 0; block < EXT4_N_BLOCKS; block++)
|
2006-10-11 08:20:50 +00:00
|
|
|
ei->i_data[block] = raw_inode->i_block[block];
|
|
|
|
INIT_LIST_HEAD(&ei->i_orphan);
|
2020-10-15 20:37:57 +00:00
|
|
|
ext4_fc_init_inode(&ei->vfs_inode);
|
2006-10-11 08:20:50 +00:00
|
|
|
|
2009-12-09 04:51:10 +00:00
|
|
|
/*
|
|
|
|
* Set transaction id's of transactions that have to be committed
|
|
|
|
* to finish f[data]sync. We set them to currently running transaction
|
|
|
|
* as we cannot be sure that the inode or some of its metadata isn't
|
|
|
|
* part of the transaction - the inode could have been reclaimed and
|
|
|
|
* now it is reread from disk.
|
|
|
|
*/
|
|
|
|
if (journal) {
|
|
|
|
transaction_t *transaction;
|
|
|
|
tid_t tid;
|
|
|
|
|
2010-08-04 01:35:12 +00:00
|
|
|
read_lock(&journal->j_state_lock);
|
2009-12-09 04:51:10 +00:00
|
|
|
if (journal->j_running_transaction)
|
|
|
|
transaction = journal->j_running_transaction;
|
|
|
|
else
|
|
|
|
transaction = journal->j_committing_transaction;
|
|
|
|
if (transaction)
|
|
|
|
tid = transaction->t_tid;
|
|
|
|
else
|
|
|
|
tid = journal->j_commit_sequence;
|
2010-08-04 01:35:12 +00:00
|
|
|
read_unlock(&journal->j_state_lock);
|
2009-12-09 04:51:10 +00:00
|
|
|
ei->i_sync_tid = tid;
|
|
|
|
ei->i_datasync_tid = tid;
|
|
|
|
}
|
|
|
|
|
2008-02-06 03:36:43 +00:00
|
|
|
if (EXT4_INODE_SIZE(inode->i_sb) > EXT4_GOOD_OLD_INODE_SIZE) {
|
2006-10-11 08:20:50 +00:00
|
|
|
if (ei->i_extra_isize == 0) {
|
|
|
|
/* The extra space is currently unused. Use it. */
|
2016-12-01 19:43:33 +00:00
|
|
|
BUILD_BUG_ON(sizeof(struct ext4_inode) & 3);
|
2006-10-11 08:20:53 +00:00
|
|
|
ei->i_extra_isize = sizeof(struct ext4_inode) -
|
|
|
|
EXT4_GOOD_OLD_INODE_SIZE;
|
2006-10-11 08:20:50 +00:00
|
|
|
} else {
|
2018-05-22 21:14:07 +00:00
|
|
|
ret = ext4_iget_extra_inode(inode, raw_inode, ei);
|
|
|
|
if (ret)
|
|
|
|
goto bad_inode;
|
2006-10-11 08:20:50 +00:00
|
|
|
}
|
2012-04-29 22:31:10 +00:00
|
|
|
}
|
2006-10-11 08:20:50 +00:00
|
|
|
|
2023-07-05 19:01:07 +00:00
|
|
|
EXT4_INODE_GET_CTIME(inode, raw_inode);
|
2023-10-04 18:52:20 +00:00
|
|
|
EXT4_INODE_GET_ATIME(inode, raw_inode);
|
|
|
|
EXT4_INODE_GET_MTIME(inode, raw_inode);
|
2007-07-18 13:15:20 +00:00
|
|
|
EXT4_EINODE_GET_XTIME(i_crtime, ei, raw_inode);
|
|
|
|
|
2014-03-24 18:09:06 +00:00
|
|
|
if (likely(!test_opt2(inode->i_sb, HURD_COMPAT))) {
|
2018-01-09 13:21:39 +00:00
|
|
|
u64 ivers = le32_to_cpu(raw_inode->i_disk_version);
|
|
|
|
|
2014-03-20 04:32:57 +00:00
|
|
|
if (EXT4_INODE_SIZE(inode->i_sb) > EXT4_GOOD_OLD_INODE_SIZE) {
|
|
|
|
if (EXT4_FITS_IN_INODE(raw_inode, ei, i_version_hi))
|
2018-01-09 13:21:39 +00:00
|
|
|
ivers |=
|
2014-03-20 04:32:57 +00:00
|
|
|
(__u64)(le32_to_cpu(raw_inode->i_version_hi)) << 32;
|
|
|
|
}
|
2018-05-10 15:55:31 +00:00
|
|
|
ext4_inode_set_iversion_queried(inode, ivers);
|
2008-01-29 04:58:27 +00:00
|
|
|
}
|
|
|
|
|
ext4: Do not try to validate extents on special files
The EXTENTS_FL flag should never be set on special files, but if it
is, don't bother trying to validate that the extents tree is valid,
since only files, directories, and non-fast symlinks will ever have an
extent data structure. We perhaps should flag the filesystem as being
corrupted if we see a special file (named pipes, device nodes, Unix
domain sockets, etc.) with the EXTENTS_FL flag, but e2fsck doesn't
currently check this case, so we'll just ignore this for now, since
it's harmless.
Without this fix, a special device with the extents flag is flagged as
an error by the kernel, so it is impossible to access or delete the
inode, but e2fsck doesn't see it as a problem, leading to
confused/frustrated users.
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2009-04-24 22:45:35 +00:00
|
|
|
ret = 0;
|
2009-04-24 17:43:20 +00:00
|
|
|
if (ei->i_file_acl &&
|
2020-07-28 13:04:34 +00:00
|
|
|
!ext4_inode_block_valid(inode, ei->i_file_acl, 1)) {
|
ext4: avoid declaring fs inconsistent due to invalid file handles
If we receive a file handle, either from NFS or open_by_handle_at(2),
and it points at an inode which has not been initialized, and the file
system has metadata checksums enabled, we shouldn't try to get the
inode, discover the checksum is invalid, and then declare the file
system as being inconsistent.
This can be reproduced by creating a test file system via "mke2fs -t
ext4 -O metadata_csum /tmp/foo.img 8M", mounting it, cd'ing into that
directory, and then running the following program.
#define _GNU_SOURCE
#include <fcntl.h>
struct handle {
struct file_handle fh;
unsigned char fid[MAX_HANDLE_SZ];
};
int main(int argc, char **argv)
{
struct handle h = {{8, 1 }, { 12, }};
open_by_handle_at(AT_FDCWD, &h.fh, O_RDONLY);
return 0;
}
Google-Bug-Id: 120690101
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@kernel.org
2018-12-19 17:29:13 +00:00
|
|
|
ext4_error_inode(inode, function, line, 0,
|
|
|
|
"iget: bad extended attribute block %llu",
|
2010-05-17 01:00:00 +00:00
|
|
|
ei->i_file_acl);
|
2015-10-17 20:16:04 +00:00
|
|
|
ret = -EFSCORRUPTED;
|
2009-04-24 17:43:20 +00:00
|
|
|
goto bad_inode;
|
2012-12-10 19:05:51 +00:00
|
|
|
} else if (!ext4_has_inline_data(inode)) {
|
2018-08-02 04:11:16 +00:00
|
|
|
/* validate the block references in the inode */
|
2020-10-15 20:37:59 +00:00
|
|
|
if (!(EXT4_SB(sb)->s_mount_state & EXT4_FC_REPLAY) &&
|
|
|
|
(S_ISREG(inode->i_mode) || S_ISDIR(inode->i_mode) ||
|
|
|
|
(S_ISLNK(inode->i_mode) &&
|
|
|
|
!ext4_inode_is_fast_symlink(inode)))) {
|
2018-08-02 04:11:16 +00:00
|
|
|
if (ext4_test_inode_flag(inode, EXT4_INODE_EXTENTS))
|
2012-12-10 19:05:51 +00:00
|
|
|
ret = ext4_ext_check_inode(inode);
|
2018-08-02 04:11:16 +00:00
|
|
|
else
|
|
|
|
ret = ext4_ind_check_inode(inode);
|
2012-12-10 19:05:51 +00:00
|
|
|
}
|
2009-03-31 12:36:10 +00:00
|
|
|
}
|
2009-11-14 13:19:05 +00:00
|
|
|
if (ret)
|
2009-06-14 21:45:34 +00:00
|
|
|
goto bad_inode;
|
2009-03-27 20:39:58 +00:00
|
|
|
|
2006-10-11 08:20:50 +00:00
|
|
|
if (S_ISREG(inode->i_mode)) {
|
2006-10-11 08:20:53 +00:00
|
|
|
inode->i_op = &ext4_file_inode_operations;
|
2015-04-15 23:15:17 +00:00
|
|
|
inode->i_fop = &ext4_file_operations;
|
2006-10-11 08:20:53 +00:00
|
|
|
ext4_set_aops(inode);
|
2006-10-11 08:20:50 +00:00
|
|
|
} else if (S_ISDIR(inode->i_mode)) {
|
2006-10-11 08:20:53 +00:00
|
|
|
inode->i_op = &ext4_dir_inode_operations;
|
|
|
|
inode->i_fop = &ext4_dir_operations;
|
2006-10-11 08:20:50 +00:00
|
|
|
} else if (S_ISLNK(inode->i_mode)) {
|
2018-05-13 20:45:56 +00:00
|
|
|
/* VFS does not allow setting these so must be corruption */
|
|
|
|
if (IS_APPEND(inode) || IS_IMMUTABLE(inode)) {
|
ext4: avoid declaring fs inconsistent due to invalid file handles
If we receive a file handle, either from NFS or open_by_handle_at(2),
and it points at an inode which has not been initialized, and the file
system has metadata checksums enabled, we shouldn't try to get the
inode, discover the checksum is invalid, and then declare the file
system as being inconsistent.
This can be reproduced by creating a test file system via "mke2fs -t
ext4 -O metadata_csum /tmp/foo.img 8M", mounting it, cd'ing into that
directory, and then running the following program.
#define _GNU_SOURCE
#include <fcntl.h>
struct handle {
struct file_handle fh;
unsigned char fid[MAX_HANDLE_SZ];
};
int main(int argc, char **argv)
{
struct handle h = {{8, 1 }, { 12, }};
open_by_handle_at(AT_FDCWD, &h.fh, O_RDONLY);
return 0;
}
Google-Bug-Id: 120690101
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@kernel.org
2018-12-19 17:29:13 +00:00
|
|
|
ext4_error_inode(inode, function, line, 0,
|
|
|
|
"iget: immutable or append flags "
|
|
|
|
"not allowed on symlinks");
|
2018-05-13 20:45:56 +00:00
|
|
|
ret = -EFSCORRUPTED;
|
|
|
|
goto bad_inode;
|
|
|
|
}
|
2018-12-12 09:50:10 +00:00
|
|
|
if (IS_ENCRYPTED(inode)) {
|
2015-04-27 21:51:30 +00:00
|
|
|
inode->i_op = &ext4_encrypted_symlink_inode_operations;
|
|
|
|
} else if (ext4_inode_is_fast_symlink(inode)) {
|
2015-05-02 14:13:58 +00:00
|
|
|
inode->i_link = (char *)ei->i_data;
|
2006-10-11 08:20:53 +00:00
|
|
|
inode->i_op = &ext4_fast_symlink_inode_operations;
|
2008-12-19 20:47:15 +00:00
|
|
|
nd_terminate_link(ei->i_data, inode->i_size,
|
|
|
|
sizeof(ei->i_data) - 1);
|
|
|
|
} else {
|
2006-10-11 08:20:53 +00:00
|
|
|
inode->i_op = &ext4_symlink_inode_operations;
|
2006-10-11 08:20:50 +00:00
|
|
|
}
|
2009-03-26 04:06:19 +00:00
|
|
|
} else if (S_ISCHR(inode->i_mode) || S_ISBLK(inode->i_mode) ||
|
|
|
|
S_ISFIFO(inode->i_mode) || S_ISSOCK(inode->i_mode)) {
|
2006-10-11 08:20:53 +00:00
|
|
|
inode->i_op = &ext4_special_inode_operations;
|
2006-10-11 08:20:50 +00:00
|
|
|
if (raw_inode->i_block[0])
|
|
|
|
init_special_inode(inode, inode->i_mode,
|
|
|
|
old_decode_dev(le32_to_cpu(raw_inode->i_block[0])));
|
|
|
|
else
|
|
|
|
init_special_inode(inode, inode->i_mode,
|
|
|
|
new_decode_dev(le32_to_cpu(raw_inode->i_block[1])));
|
2013-04-08 16:54:05 +00:00
|
|
|
} else if (ino == EXT4_BOOT_LOADER_INO) {
|
|
|
|
make_bad_inode(inode);
|
2009-03-26 04:06:19 +00:00
|
|
|
} else {
|
2015-10-17 20:16:04 +00:00
|
|
|
ret = -EFSCORRUPTED;
|
ext4: avoid declaring fs inconsistent due to invalid file handles
If we receive a file handle, either from NFS or open_by_handle_at(2),
and it points at an inode which has not been initialized, and the file
system has metadata checksums enabled, we shouldn't try to get the
inode, discover the checksum is invalid, and then declare the file
system as being inconsistent.
This can be reproduced by creating a test file system via "mke2fs -t
ext4 -O metadata_csum /tmp/foo.img 8M", mounting it, cd'ing into that
directory, and then running the following program.
#define _GNU_SOURCE
#include <fcntl.h>
struct handle {
struct file_handle fh;
unsigned char fid[MAX_HANDLE_SZ];
};
int main(int argc, char **argv)
{
struct handle h = {{8, 1 }, { 12, }};
open_by_handle_at(AT_FDCWD, &h.fh, O_RDONLY);
return 0;
}
Google-Bug-Id: 120690101
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@kernel.org
2018-12-19 17:29:13 +00:00
|
|
|
ext4_error_inode(inode, function, line, 0,
|
|
|
|
"iget: bogus i_mode (%o)", inode->i_mode);
|
2009-03-26 04:06:19 +00:00
|
|
|
goto bad_inode;
|
2006-10-11 08:20:50 +00:00
|
|
|
}
|
2023-08-14 18:29:01 +00:00
|
|
|
if (IS_CASEFOLDED(inode) && !ext4_has_feature_casefold(inode->i_sb)) {
|
2019-09-03 05:43:17 +00:00
|
|
|
ext4_error_inode(inode, function, line, 0,
|
|
|
|
"casefold flag without casefold feature");
|
2023-08-14 18:29:01 +00:00
|
|
|
ret = -EFSCORRUPTED;
|
|
|
|
goto bad_inode;
|
|
|
|
}
|
2023-05-24 03:49:48 +00:00
|
|
|
if ((err_str = check_igot_inode(inode, flags)) != NULL) {
|
|
|
|
ext4_error_inode(inode, function, line, 0, err_str);
|
|
|
|
ret = -EFSCORRUPTED;
|
2022-10-26 04:23:09 +00:00
|
|
|
goto bad_inode;
|
|
|
|
}
|
2017-06-22 15:44:55 +00:00
|
|
|
|
2022-10-26 04:23:09 +00:00
|
|
|
brelse(iloc.bh);
|
2008-02-07 08:15:37 +00:00
|
|
|
unlock_new_inode(inode);
|
|
|
|
return inode;
|
2006-10-11 08:20:50 +00:00
|
|
|
|
|
|
|
bad_inode:
|
2009-11-14 13:19:05 +00:00
|
|
|
brelse(iloc.bh);
|
2008-02-07 08:15:37 +00:00
|
|
|
iget_failed(inode);
|
|
|
|
return ERR_PTR(ret);
|
2006-10-11 08:20:50 +00:00
|
|
|
}
|
|
|
|
|
2017-12-01 11:40:16 +00:00
|
|
|
static void __ext4_update_other_inode_time(struct super_block *sb,
|
|
|
|
unsigned long orig_ino,
|
|
|
|
unsigned long ino,
|
|
|
|
struct ext4_inode *raw_inode)
|
2015-02-02 05:37:02 +00:00
|
|
|
{
|
2017-12-01 11:40:16 +00:00
|
|
|
struct inode *inode;
|
|
|
|
|
|
|
|
inode = find_inode_by_ino_rcu(sb, ino);
|
|
|
|
if (!inode)
|
|
|
|
return;
|
2015-02-02 05:37:02 +00:00
|
|
|
|
2021-01-12 19:02:53 +00:00
|
|
|
if (!inode_is_dirtytime_only(inode))
|
2017-12-01 11:40:16 +00:00
|
|
|
return;
|
|
|
|
|
2015-02-02 05:37:02 +00:00
|
|
|
spin_lock(&inode->i_lock);
|
2021-01-12 19:02:53 +00:00
|
|
|
if (inode_is_dirtytime_only(inode)) {
|
2015-02-02 05:37:02 +00:00
|
|
|
struct ext4_inode_info *ei = EXT4_I(inode);
|
|
|
|
|
2020-05-29 14:24:43 +00:00
|
|
|
inode->i_state &= ~I_DIRTY_TIME;
|
2015-02-02 05:37:02 +00:00
|
|
|
spin_unlock(&inode->i_lock);
|
|
|
|
|
|
|
|
spin_lock(&ei->i_raw_lock);
|
2023-07-05 19:01:07 +00:00
|
|
|
EXT4_INODE_SET_CTIME(inode, raw_inode);
|
2023-10-04 18:52:20 +00:00
|
|
|
EXT4_INODE_SET_MTIME(inode, raw_inode);
|
|
|
|
EXT4_INODE_SET_ATIME(inode, raw_inode);
|
2017-12-01 11:40:16 +00:00
|
|
|
ext4_inode_csum_set(inode, raw_inode, ei);
|
2015-02-02 05:37:02 +00:00
|
|
|
spin_unlock(&ei->i_raw_lock);
|
2017-12-01 11:40:16 +00:00
|
|
|
trace_ext4_other_inode_update_time(inode, orig_ino);
|
|
|
|
return;
|
2015-02-02 05:37:02 +00:00
|
|
|
}
|
|
|
|
spin_unlock(&inode->i_lock);
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Opportunistically update the other time fields for other inodes in
|
|
|
|
* the same inode table block.
|
|
|
|
*/
|
|
|
|
static void ext4_update_other_inodes_time(struct super_block *sb,
|
|
|
|
unsigned long orig_ino, char *buf)
|
|
|
|
{
|
|
|
|
unsigned long ino;
|
|
|
|
int i, inodes_per_block = EXT4_SB(sb)->s_inodes_per_block;
|
|
|
|
int inode_size = EXT4_INODE_SIZE(sb);
|
|
|
|
|
2015-07-02 03:37:46 +00:00
|
|
|
/*
|
|
|
|
* Calculate the first inode in the inode table block. Inode
|
|
|
|
* numbers are one-based. That is, the first inode in a block
|
|
|
|
* (assuming 4k blocks and 256 byte inodes) is (n*16 + 1).
|
|
|
|
*/
|
|
|
|
ino = ((orig_ino - 1) & ~(inodes_per_block - 1)) + 1;
|
2017-12-01 11:40:16 +00:00
|
|
|
rcu_read_lock();
|
2015-02-02 05:37:02 +00:00
|
|
|
for (i = 0; i < inodes_per_block; i++, ino++, buf += inode_size) {
|
|
|
|
if (ino == orig_ino)
|
|
|
|
continue;
|
2017-12-01 11:40:16 +00:00
|
|
|
__ext4_update_other_inode_time(sb, orig_ino, ino,
|
|
|
|
(struct ext4_inode *)buf);
|
2015-02-02 05:37:02 +00:00
|
|
|
}
|
2017-12-01 11:40:16 +00:00
|
|
|
rcu_read_unlock();
|
2015-02-02 05:37:02 +00:00
|
|
|
}
|
|
|
|
|
2021-09-01 02:09:53 +00:00
|
|
|
/*
|
|
|
|
* Post the struct inode info into an on-disk inode location in the
|
|
|
|
* buffer-cache. This gobbles the caller's reference to the
|
|
|
|
* buffer_head in the inode location struct.
|
|
|
|
*
|
|
|
|
* The caller must have write access to iloc->bh.
|
|
|
|
*/
|
|
|
|
static int ext4_do_update_inode(handle_t *handle,
|
|
|
|
struct inode *inode,
|
|
|
|
struct ext4_iloc *iloc)
|
|
|
|
{
|
|
|
|
struct ext4_inode *raw_inode = ext4_raw_inode(iloc);
|
|
|
|
struct ext4_inode_info *ei = EXT4_I(inode);
|
|
|
|
struct buffer_head *bh = iloc->bh;
|
|
|
|
struct super_block *sb = inode->i_sb;
|
|
|
|
int err;
|
|
|
|
int need_datasync = 0, set_large_file = 0;
|
|
|
|
|
|
|
|
spin_lock(&ei->i_raw_lock);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* For fields not tracked in the in-memory inode, initialise them
|
|
|
|
* to zero for new inodes.
|
|
|
|
*/
|
|
|
|
if (ext4_test_inode_state(inode, EXT4_STATE_NEW))
|
|
|
|
memset(raw_inode, 0, EXT4_SB(inode->i_sb)->s_inode_size);
|
|
|
|
|
|
|
|
if (READ_ONCE(ei->i_disksize) != ext4_isize(inode->i_sb, raw_inode))
|
|
|
|
need_datasync = 1;
|
|
|
|
if (ei->i_disksize > 0x7fffffffULL) {
|
|
|
|
if (!ext4_has_feature_large_file(sb) ||
|
|
|
|
EXT4_SB(sb)->s_es->s_rev_level == cpu_to_le32(EXT4_GOOD_OLD_REV))
|
|
|
|
set_large_file = 1;
|
|
|
|
}
|
|
|
|
|
|
|
|
err = ext4_fill_raw_inode(inode, raw_inode);
|
2014-04-21 18:37:55 +00:00
|
|
|
spin_unlock(&ei->i_raw_lock);
|
2021-08-26 13:04:09 +00:00
|
|
|
if (err) {
|
|
|
|
EXT4_ERROR_INODE(inode, "corrupted inode contents");
|
|
|
|
goto out_brelse;
|
|
|
|
}
|
|
|
|
|
2017-11-27 21:05:09 +00:00
|
|
|
if (inode->i_sb->s_flags & SB_LAZYTIME)
|
2015-02-02 05:37:02 +00:00
|
|
|
ext4_update_other_inodes_time(inode->i_sb, inode->i_ino,
|
|
|
|
bh->b_data);
|
2014-04-21 18:37:55 +00:00
|
|
|
|
2009-09-29 14:07:47 +00:00
|
|
|
BUFFER_TRACE(bh, "call ext4_handle_dirty_metadata");
|
2021-03-12 06:50:51 +00:00
|
|
|
err = ext4_handle_dirty_metadata(handle, NULL, bh);
|
|
|
|
if (err)
|
2021-08-26 13:04:09 +00:00
|
|
|
goto out_error;
|
2010-01-24 19:34:07 +00:00
|
|
|
ext4_clear_inode_state(inode, EXT4_STATE_NEW);
|
2014-04-21 18:37:55 +00:00
|
|
|
if (set_large_file) {
|
2014-05-13 02:06:43 +00:00
|
|
|
BUFFER_TRACE(EXT4_SB(sb)->s_sbh, "get write access");
|
2021-08-16 09:57:04 +00:00
|
|
|
err = ext4_journal_get_write_access(handle, sb,
|
|
|
|
EXT4_SB(sb)->s_sbh,
|
|
|
|
EXT4_JTR_NONE);
|
2014-04-21 18:37:55 +00:00
|
|
|
if (err)
|
2021-08-26 13:04:09 +00:00
|
|
|
goto out_error;
|
2020-12-16 10:18:39 +00:00
|
|
|
lock_buffer(EXT4_SB(sb)->s_sbh);
|
2015-10-17 20:18:43 +00:00
|
|
|
ext4_set_feature_large_file(sb);
|
2020-12-16 10:18:39 +00:00
|
|
|
ext4_superblock_csum_set(sb);
|
|
|
|
unlock_buffer(EXT4_SB(sb)->s_sbh);
|
2014-04-21 18:37:55 +00:00
|
|
|
ext4_handle_sync(handle);
|
2020-12-16 10:18:44 +00:00
|
|
|
err = ext4_handle_dirty_metadata(handle, NULL,
|
|
|
|
EXT4_SB(sb)->s_sbh);
|
2014-04-21 18:37:55 +00:00
|
|
|
}
|
2012-09-27 01:52:20 +00:00
|
|
|
ext4_update_inode_fsync_trans(handle, inode, need_datasync);
|
2021-08-26 13:04:09 +00:00
|
|
|
out_error:
|
|
|
|
ext4_std_error(inode->i_sb, err);
|
2006-10-11 08:20:50 +00:00
|
|
|
out_brelse:
|
2008-09-09 02:25:24 +00:00
|
|
|
brelse(bh);
|
2006-10-11 08:20:50 +00:00
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
2006-10-11 08:20:53 +00:00
|
|
|
* ext4_write_inode()
|
2006-10-11 08:20:50 +00:00
|
|
|
*
|
|
|
|
* We are called from a few places:
|
|
|
|
*
|
2014-04-08 15:38:28 +00:00
|
|
|
* - Within generic_file_aio_write() -> generic_write_sync() for O_SYNC files.
|
2006-10-11 08:20:50 +00:00
|
|
|
* Here, there will be no transaction running. We wait for any running
|
2012-09-01 17:31:09 +00:00
|
|
|
* transaction to commit.
|
2006-10-11 08:20:50 +00:00
|
|
|
*
|
2014-04-08 15:38:28 +00:00
|
|
|
* - Within flush work (sys_sync(), kupdate and such).
|
|
|
|
* We wait on commit, if told to.
|
2006-10-11 08:20:50 +00:00
|
|
|
*
|
2014-04-08 15:38:28 +00:00
|
|
|
* - Within iput_final() -> write_inode_now()
|
|
|
|
* We wait on commit, if told to.
|
2006-10-11 08:20:50 +00:00
|
|
|
*
|
|
|
|
* In all cases it is actually safe for us to return without doing anything,
|
|
|
|
* because the inode has been copied into a raw inode buffer in
|
2014-04-08 15:38:28 +00:00
|
|
|
* ext4_mark_inode_dirty(). This is a correctness thing for WB_SYNC_ALL
|
|
|
|
* writeback.
|
2006-10-11 08:20:50 +00:00
|
|
|
*
|
|
|
|
* Note that we are absolutely dependent upon all inode dirtiers doing the
|
|
|
|
* right thing: they *must* call mark_inode_dirty() after dirtying info in
|
|
|
|
* which we are interested.
|
|
|
|
*
|
|
|
|
* It would be a bug for them to not do this. The code:
|
|
|
|
*
|
|
|
|
* mark_inode_dirty(inode)
|
|
|
|
* stuff();
|
|
|
|
* inode->i_size = expr;
|
|
|
|
*
|
2014-04-08 15:38:28 +00:00
|
|
|
* is in error because write_inode() could occur while `stuff()' is running,
|
|
|
|
* and the new i_size will be lost. Plus the inode will no longer be on the
|
|
|
|
* superblock's dirty inode list.
|
2006-10-11 08:20:50 +00:00
|
|
|
*/
|
2010-03-05 08:21:37 +00:00
|
|
|
int ext4_write_inode(struct inode *inode, struct writeback_control *wbc)
|
2006-10-11 08:20:50 +00:00
|
|
|
{
|
2009-09-10 02:33:47 +00:00
|
|
|
int err;
|
|
|
|
|
2023-06-16 16:50:55 +00:00
|
|
|
if (WARN_ON_ONCE(current->flags & PF_MEMALLOC))
|
2006-10-11 08:20:50 +00:00
|
|
|
return 0;
|
|
|
|
|
2023-06-16 16:50:49 +00:00
|
|
|
if (unlikely(ext4_forced_shutdown(inode->i_sb)))
|
2018-12-19 19:36:58 +00:00
|
|
|
return -EIO;
|
|
|
|
|
2009-09-10 02:33:47 +00:00
|
|
|
if (EXT4_SB(inode->i_sb)->s_journal) {
|
|
|
|
if (ext4_journal_current_handle()) {
|
2022-06-08 11:23:47 +00:00
|
|
|
ext4_debug("called recursively, non-PF_MEMALLOC!\n");
|
2009-09-10 02:33:47 +00:00
|
|
|
dump_stack();
|
|
|
|
return -EIO;
|
|
|
|
}
|
2006-10-11 08:20:50 +00:00
|
|
|
|
2014-03-04 15:50:50 +00:00
|
|
|
/*
|
|
|
|
* No need to force transaction in WB_SYNC_NONE mode. Also
|
|
|
|
* ext4_sync_fs() will force the commit after everything is
|
|
|
|
* written.
|
|
|
|
*/
|
|
|
|
if (wbc->sync_mode != WB_SYNC_ALL || wbc->for_sync)
|
2009-09-10 02:33:47 +00:00
|
|
|
return 0;
|
|
|
|
|
2020-10-15 20:37:57 +00:00
|
|
|
err = ext4_fc_commit(EXT4_SB(inode->i_sb)->s_journal,
|
2018-12-19 19:36:58 +00:00
|
|
|
EXT4_I(inode)->i_sync_tid);
|
2009-09-10 02:33:47 +00:00
|
|
|
} else {
|
|
|
|
struct ext4_iloc iloc;
|
2006-10-11 08:20:50 +00:00
|
|
|
|
2020-10-15 20:37:59 +00:00
|
|
|
err = __ext4_get_inode_loc_noinmem(inode, &iloc);
|
2009-09-10 02:33:47 +00:00
|
|
|
if (err)
|
|
|
|
return err;
|
2014-03-04 15:50:50 +00:00
|
|
|
/*
|
|
|
|
* sync(2) will flush the whole buffer cache. No need to do
|
|
|
|
* it here separately for each inode.
|
|
|
|
*/
|
|
|
|
if (wbc->sync_mode == WB_SYNC_ALL && !wbc->for_sync)
|
2009-09-29 14:07:47 +00:00
|
|
|
sync_dirty_buffer(iloc.bh);
|
|
|
|
if (buffer_req(iloc.bh) && !buffer_uptodate(iloc.bh)) {
|
2020-03-28 23:33:43 +00:00
|
|
|
ext4_error_inode_block(inode, iloc.bh->b_blocknr, EIO,
|
|
|
|
"IO error syncing inode");
|
2009-09-29 14:07:47 +00:00
|
|
|
err = -EIO;
|
|
|
|
}
|
2010-04-03 21:44:16 +00:00
|
|
|
brelse(iloc.bh);
|
2009-09-10 02:33:47 +00:00
|
|
|
}
|
|
|
|
return err;
|
2006-10-11 08:20:50 +00:00
|
|
|
}
|
|
|
|
|
2012-12-25 18:29:52 +00:00
|
|
|
/*
|
2022-02-09 20:21:43 +00:00
|
|
|
* In data=journal mode ext4_journalled_invalidate_folio() may fail to invalidate
|
|
|
|
* buffers that are attached to a folio straddling i_size and are undergoing
|
2012-12-25 18:29:52 +00:00
|
|
|
* commit. In that case we have to wait for commit to finish and try again.
|
|
|
|
*/
|
|
|
|
static void ext4_wait_for_tail_page_commit(struct inode *inode)
|
|
|
|
{
|
|
|
|
unsigned offset;
|
|
|
|
journal_t *journal = EXT4_SB(inode->i_sb)->s_journal;
|
2024-07-24 16:11:15 +00:00
|
|
|
tid_t commit_tid;
|
2012-12-25 18:29:52 +00:00
|
|
|
int ret;
|
2024-07-24 16:11:15 +00:00
|
|
|
bool has_transaction;
|
2012-12-25 18:29:52 +00:00
|
|
|
|
mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros
PAGE_CACHE_{SIZE,SHIFT,MASK,ALIGN} macros were introduced *long* time
ago with promise that one day it will be possible to implement page
cache with bigger chunks than PAGE_SIZE.
This promise never materialized. And unlikely will.
We have many places where PAGE_CACHE_SIZE assumed to be equal to
PAGE_SIZE. And it's constant source of confusion on whether
PAGE_CACHE_* or PAGE_* constant should be used in a particular case,
especially on the border between fs and mm.
Global switching to PAGE_CACHE_SIZE != PAGE_SIZE would cause to much
breakage to be doable.
Let's stop pretending that pages in page cache are special. They are
not.
The changes are pretty straight-forward:
- <foo> << (PAGE_CACHE_SHIFT - PAGE_SHIFT) -> <foo>;
- <foo> >> (PAGE_CACHE_SHIFT - PAGE_SHIFT) -> <foo>;
- PAGE_CACHE_{SIZE,SHIFT,MASK,ALIGN} -> PAGE_{SIZE,SHIFT,MASK,ALIGN};
- page_cache_get() -> get_page();
- page_cache_release() -> put_page();
This patch contains automated changes generated with coccinelle using
script below. For some reason, coccinelle doesn't patch header files.
I've called spatch for them manually.
The only adjustment after coccinelle is revert of changes to
PAGE_CAHCE_ALIGN definition: we are going to drop it later.
There are few places in the code where coccinelle didn't reach. I'll
fix them manually in a separate patch. Comments and documentation also
will be addressed with the separate patch.
virtual patch
@@
expression E;
@@
- E << (PAGE_CACHE_SHIFT - PAGE_SHIFT)
+ E
@@
expression E;
@@
- E >> (PAGE_CACHE_SHIFT - PAGE_SHIFT)
+ E
@@
@@
- PAGE_CACHE_SHIFT
+ PAGE_SHIFT
@@
@@
- PAGE_CACHE_SIZE
+ PAGE_SIZE
@@
@@
- PAGE_CACHE_MASK
+ PAGE_MASK
@@
expression E;
@@
- PAGE_CACHE_ALIGN(E)
+ PAGE_ALIGN(E)
@@
expression E;
@@
- page_cache_get(E)
+ get_page(E)
@@
expression E;
@@
- page_cache_release(E)
+ put_page(E)
Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Acked-by: Michal Hocko <mhocko@suse.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2016-04-01 12:29:47 +00:00
|
|
|
offset = inode->i_size & (PAGE_SIZE - 1);
|
2012-12-25 18:29:52 +00:00
|
|
|
/*
|
2022-02-09 20:21:43 +00:00
|
|
|
* If the folio is fully truncated, we don't need to wait for any commit
|
|
|
|
* (and we even should not as __ext4_journalled_invalidate_folio() may
|
|
|
|
* strip all buffers from the folio but keep the folio dirty which can then
|
2023-02-28 05:13:19 +00:00
|
|
|
* confuse e.g. concurrent ext4_writepages() seeing dirty folio without
|
ext4: fix a bug in ext4_wait_for_tail_page_commit
No need to wait for any commit once the page is fully truncated.
Besides, it may confuse e.g. concurrent ext4_writepage() with the page
still be dirty (will be cleared by truncate_pagecache() in
ext4_setattr()) but buffers has been freed; and then trigger a bug
show as below:
[ 26.057508] ------------[ cut here ]------------
[ 26.058531] kernel BUG at fs/ext4/inode.c:2134!
...
[ 26.088130] Call trace:
[ 26.088695] ext4_writepage+0x914/0xb28
[ 26.089541] writeout.isra.4+0x1b4/0x2b8
[ 26.090409] move_to_new_page+0x3b0/0x568
[ 26.091338] __unmap_and_move+0x648/0x988
[ 26.092241] unmap_and_move+0x48c/0xbb8
[ 26.093096] migrate_pages+0x220/0xb28
[ 26.093945] kernel_mbind+0x828/0xa18
[ 26.094791] __arm64_sys_mbind+0xc8/0x138
[ 26.095716] el0_svc_common+0x190/0x490
[ 26.096571] el0_svc_handler+0x60/0xd0
[ 26.097423] el0_svc+0x8/0xc
Run the procedure (generate by syzkaller) parallel with ext3.
void main()
{
int fd, fd1, ret;
void *addr;
size_t length = 4096;
int flags;
off_t offset = 0;
char *str = "12345";
fd = open("a", O_RDWR | O_CREAT);
assert(fd >= 0);
/* Truncate to 4k */
ret = ftruncate(fd, length);
assert(ret == 0);
/* Journal data mode */
flags = 0xc00f;
ret = ioctl(fd, _IOW('f', 2, long), &flags);
assert(ret == 0);
/* Truncate to 0 */
fd1 = open("a", O_TRUNC | O_NOATIME);
assert(fd1 >= 0);
addr = mmap(NULL, length, PROT_WRITE | PROT_READ,
MAP_SHARED, fd, offset);
assert(addr != (void *)-1);
memcpy(addr, str, 5);
mbind(addr, length, 0, 0, 0, MPOL_MF_MOVE);
}
And the bug will be triggered once we seen the below order.
reproduce1 reproduce2
... | ...
truncate to 4k |
change to journal data mode |
| memcpy(set page dirty)
truncate to 0: |
ext4_setattr: |
... |
ext4_wait_for_tail_page_commit |
| mbind(trigger bug)
truncate_pagecache(clean dirty)| ...
... |
mbind will call ext4_writepage() since the page still be dirty, and then
report the bug since the buffers has been free. Fix it by return
directly once offset equals to 0 which means the page has been fully
truncated.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: yangerkun <yangerkun@huawei.com>
Link: https://lore.kernel.org/r/20190919063508.1045-1-yangerkun@huawei.com
Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
2019-09-19 06:35:08 +00:00
|
|
|
* buffers). Also we don't need to wait for any commit if all buffers in
|
2022-02-09 20:21:43 +00:00
|
|
|
* the folio remain valid. This is most beneficial for the common case of
|
ext4: fix a bug in ext4_wait_for_tail_page_commit
No need to wait for any commit once the page is fully truncated.
Besides, it may confuse e.g. concurrent ext4_writepage() with the page
still be dirty (will be cleared by truncate_pagecache() in
ext4_setattr()) but buffers has been freed; and then trigger a bug
show as below:
[ 26.057508] ------------[ cut here ]------------
[ 26.058531] kernel BUG at fs/ext4/inode.c:2134!
...
[ 26.088130] Call trace:
[ 26.088695] ext4_writepage+0x914/0xb28
[ 26.089541] writeout.isra.4+0x1b4/0x2b8
[ 26.090409] move_to_new_page+0x3b0/0x568
[ 26.091338] __unmap_and_move+0x648/0x988
[ 26.092241] unmap_and_move+0x48c/0xbb8
[ 26.093096] migrate_pages+0x220/0xb28
[ 26.093945] kernel_mbind+0x828/0xa18
[ 26.094791] __arm64_sys_mbind+0xc8/0x138
[ 26.095716] el0_svc_common+0x190/0x490
[ 26.096571] el0_svc_handler+0x60/0xd0
[ 26.097423] el0_svc+0x8/0xc
Run the procedure (generate by syzkaller) parallel with ext3.
void main()
{
int fd, fd1, ret;
void *addr;
size_t length = 4096;
int flags;
off_t offset = 0;
char *str = "12345";
fd = open("a", O_RDWR | O_CREAT);
assert(fd >= 0);
/* Truncate to 4k */
ret = ftruncate(fd, length);
assert(ret == 0);
/* Journal data mode */
flags = 0xc00f;
ret = ioctl(fd, _IOW('f', 2, long), &flags);
assert(ret == 0);
/* Truncate to 0 */
fd1 = open("a", O_TRUNC | O_NOATIME);
assert(fd1 >= 0);
addr = mmap(NULL, length, PROT_WRITE | PROT_READ,
MAP_SHARED, fd, offset);
assert(addr != (void *)-1);
memcpy(addr, str, 5);
mbind(addr, length, 0, 0, 0, MPOL_MF_MOVE);
}
And the bug will be triggered once we seen the below order.
reproduce1 reproduce2
... | ...
truncate to 4k |
change to journal data mode |
| memcpy(set page dirty)
truncate to 0: |
ext4_setattr: |
... |
ext4_wait_for_tail_page_commit |
| mbind(trigger bug)
truncate_pagecache(clean dirty)| ...
... |
mbind will call ext4_writepage() since the page still be dirty, and then
report the bug since the buffers has been free. Fix it by return
directly once offset equals to 0 which means the page has been fully
truncated.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: yangerkun <yangerkun@huawei.com>
Link: https://lore.kernel.org/r/20190919063508.1045-1-yangerkun@huawei.com
Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
2019-09-19 06:35:08 +00:00
|
|
|
* blocksize == PAGESIZE.
|
2012-12-25 18:29:52 +00:00
|
|
|
*/
|
ext4: fix a bug in ext4_wait_for_tail_page_commit
No need to wait for any commit once the page is fully truncated.
Besides, it may confuse e.g. concurrent ext4_writepage() with the page
still be dirty (will be cleared by truncate_pagecache() in
ext4_setattr()) but buffers has been freed; and then trigger a bug
show as below:
[ 26.057508] ------------[ cut here ]------------
[ 26.058531] kernel BUG at fs/ext4/inode.c:2134!
...
[ 26.088130] Call trace:
[ 26.088695] ext4_writepage+0x914/0xb28
[ 26.089541] writeout.isra.4+0x1b4/0x2b8
[ 26.090409] move_to_new_page+0x3b0/0x568
[ 26.091338] __unmap_and_move+0x648/0x988
[ 26.092241] unmap_and_move+0x48c/0xbb8
[ 26.093096] migrate_pages+0x220/0xb28
[ 26.093945] kernel_mbind+0x828/0xa18
[ 26.094791] __arm64_sys_mbind+0xc8/0x138
[ 26.095716] el0_svc_common+0x190/0x490
[ 26.096571] el0_svc_handler+0x60/0xd0
[ 26.097423] el0_svc+0x8/0xc
Run the procedure (generate by syzkaller) parallel with ext3.
void main()
{
int fd, fd1, ret;
void *addr;
size_t length = 4096;
int flags;
off_t offset = 0;
char *str = "12345";
fd = open("a", O_RDWR | O_CREAT);
assert(fd >= 0);
/* Truncate to 4k */
ret = ftruncate(fd, length);
assert(ret == 0);
/* Journal data mode */
flags = 0xc00f;
ret = ioctl(fd, _IOW('f', 2, long), &flags);
assert(ret == 0);
/* Truncate to 0 */
fd1 = open("a", O_TRUNC | O_NOATIME);
assert(fd1 >= 0);
addr = mmap(NULL, length, PROT_WRITE | PROT_READ,
MAP_SHARED, fd, offset);
assert(addr != (void *)-1);
memcpy(addr, str, 5);
mbind(addr, length, 0, 0, 0, MPOL_MF_MOVE);
}
And the bug will be triggered once we seen the below order.
reproduce1 reproduce2
... | ...
truncate to 4k |
change to journal data mode |
| memcpy(set page dirty)
truncate to 0: |
ext4_setattr: |
... |
ext4_wait_for_tail_page_commit |
| mbind(trigger bug)
truncate_pagecache(clean dirty)| ...
... |
mbind will call ext4_writepage() since the page still be dirty, and then
report the bug since the buffers has been free. Fix it by return
directly once offset equals to 0 which means the page has been fully
truncated.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: yangerkun <yangerkun@huawei.com>
Link: https://lore.kernel.org/r/20190919063508.1045-1-yangerkun@huawei.com
Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
2019-09-19 06:35:08 +00:00
|
|
|
if (!offset || offset > (PAGE_SIZE - i_blocksize(inode)))
|
2012-12-25 18:29:52 +00:00
|
|
|
return;
|
|
|
|
while (1) {
|
2022-02-09 20:21:43 +00:00
|
|
|
struct folio *folio = filemap_lock_folio(inode->i_mapping,
|
mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros
PAGE_CACHE_{SIZE,SHIFT,MASK,ALIGN} macros were introduced *long* time
ago with promise that one day it will be possible to implement page
cache with bigger chunks than PAGE_SIZE.
This promise never materialized. And unlikely will.
We have many places where PAGE_CACHE_SIZE assumed to be equal to
PAGE_SIZE. And it's constant source of confusion on whether
PAGE_CACHE_* or PAGE_* constant should be used in a particular case,
especially on the border between fs and mm.
Global switching to PAGE_CACHE_SIZE != PAGE_SIZE would cause to much
breakage to be doable.
Let's stop pretending that pages in page cache are special. They are
not.
The changes are pretty straight-forward:
- <foo> << (PAGE_CACHE_SHIFT - PAGE_SHIFT) -> <foo>;
- <foo> >> (PAGE_CACHE_SHIFT - PAGE_SHIFT) -> <foo>;
- PAGE_CACHE_{SIZE,SHIFT,MASK,ALIGN} -> PAGE_{SIZE,SHIFT,MASK,ALIGN};
- page_cache_get() -> get_page();
- page_cache_release() -> put_page();
This patch contains automated changes generated with coccinelle using
script below. For some reason, coccinelle doesn't patch header files.
I've called spatch for them manually.
The only adjustment after coccinelle is revert of changes to
PAGE_CAHCE_ALIGN definition: we are going to drop it later.
There are few places in the code where coccinelle didn't reach. I'll
fix them manually in a separate patch. Comments and documentation also
will be addressed with the separate patch.
virtual patch
@@
expression E;
@@
- E << (PAGE_CACHE_SHIFT - PAGE_SHIFT)
+ E
@@
expression E;
@@
- E >> (PAGE_CACHE_SHIFT - PAGE_SHIFT)
+ E
@@
@@
- PAGE_CACHE_SHIFT
+ PAGE_SHIFT
@@
@@
- PAGE_CACHE_SIZE
+ PAGE_SIZE
@@
@@
- PAGE_CACHE_MASK
+ PAGE_MASK
@@
expression E;
@@
- PAGE_CACHE_ALIGN(E)
+ PAGE_ALIGN(E)
@@
expression E;
@@
- page_cache_get(E)
+ get_page(E)
@@
expression E;
@@
- page_cache_release(E)
+ put_page(E)
Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Acked-by: Michal Hocko <mhocko@suse.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2016-04-01 12:29:47 +00:00
|
|
|
inode->i_size >> PAGE_SHIFT);
|
2023-03-07 14:34:10 +00:00
|
|
|
if (IS_ERR(folio))
|
2012-12-25 18:29:52 +00:00
|
|
|
return;
|
2022-02-09 20:21:43 +00:00
|
|
|
ret = __ext4_journalled_invalidate_folio(folio, offset,
|
|
|
|
folio_size(folio) - offset);
|
|
|
|
folio_unlock(folio);
|
|
|
|
folio_put(folio);
|
2012-12-25 18:29:52 +00:00
|
|
|
if (ret != -EBUSY)
|
|
|
|
return;
|
2024-07-24 16:11:15 +00:00
|
|
|
has_transaction = false;
|
2012-12-25 18:29:52 +00:00
|
|
|
read_lock(&journal->j_state_lock);
|
2024-07-24 16:11:15 +00:00
|
|
|
if (journal->j_committing_transaction) {
|
2012-12-25 18:29:52 +00:00
|
|
|
commit_tid = journal->j_committing_transaction->t_tid;
|
2024-07-24 16:11:15 +00:00
|
|
|
has_transaction = true;
|
|
|
|
}
|
2012-12-25 18:29:52 +00:00
|
|
|
read_unlock(&journal->j_state_lock);
|
2024-07-24 16:11:15 +00:00
|
|
|
if (has_transaction)
|
2012-12-25 18:29:52 +00:00
|
|
|
jbd2_log_wait_commit(journal, commit_tid);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2006-10-11 08:20:50 +00:00
|
|
|
/*
|
2006-10-11 08:20:53 +00:00
|
|
|
* ext4_setattr()
|
2006-10-11 08:20:50 +00:00
|
|
|
*
|
|
|
|
* Called from notify_change.
|
|
|
|
*
|
|
|
|
* We want to trap VFS attempts to truncate the file as soon as
|
|
|
|
* possible. In particular, we want to make sure that when the VFS
|
|
|
|
* shrinks i_size, we put the inode on the orphan list and modify
|
|
|
|
* i_disksize immediately, so that during the subsequent flushing of
|
|
|
|
* dirty pages and freeing of disk blocks, we can guarantee that any
|
|
|
|
* commit will leave the blocks being flushed in an unused state on
|
|
|
|
* disk. (On recovery, the inode will get truncated and the blocks will
|
|
|
|
* be freed, so we have a strong guarantee that no future commit will
|
|
|
|
* leave these blocks visible to the user.)
|
|
|
|
*
|
2008-07-11 23:27:31 +00:00
|
|
|
* Another thing we have to assure is that if we are in ordered mode
|
|
|
|
* and inode is still attached to the committing transaction, we must
|
|
|
|
* we start writeout of all the dirty pages which are being truncated.
|
|
|
|
* This way we are sure that all the data written in the previous
|
|
|
|
* transaction are already on disk (truncate waits for pages under
|
|
|
|
* writeback).
|
|
|
|
*
|
2022-01-21 07:06:11 +00:00
|
|
|
* Called with inode->i_rwsem down.
|
2006-10-11 08:20:50 +00:00
|
|
|
*/
|
2023-01-13 11:49:11 +00:00
|
|
|
int ext4_setattr(struct mnt_idmap *idmap, struct dentry *dentry,
|
2021-01-21 13:19:43 +00:00
|
|
|
struct iattr *attr)
|
2006-10-11 08:20:50 +00:00
|
|
|
{
|
2015-03-17 22:25:59 +00:00
|
|
|
struct inode *inode = d_inode(dentry);
|
2006-10-11 08:20:50 +00:00
|
|
|
int error, rc = 0;
|
2010-10-28 02:08:46 +00:00
|
|
|
int orphan = 0;
|
2006-10-11 08:20:50 +00:00
|
|
|
const unsigned int ia_valid = attr->ia_valid;
|
2022-09-08 17:24:42 +00:00
|
|
|
bool inc_ivers = true;
|
2006-10-11 08:20:50 +00:00
|
|
|
|
2023-06-16 16:50:49 +00:00
|
|
|
if (unlikely(ext4_forced_shutdown(inode->i_sb)))
|
2017-02-05 06:28:48 +00:00
|
|
|
return -EIO;
|
|
|
|
|
2019-06-10 02:04:33 +00:00
|
|
|
if (unlikely(IS_IMMUTABLE(inode)))
|
|
|
|
return -EPERM;
|
|
|
|
|
|
|
|
if (unlikely(IS_APPEND(inode) &&
|
|
|
|
(ia_valid & (ATTR_MODE | ATTR_UID |
|
|
|
|
ATTR_GID | ATTR_TIMES_SET))))
|
|
|
|
return -EPERM;
|
|
|
|
|
2023-01-13 11:49:11 +00:00
|
|
|
error = setattr_prepare(idmap, dentry, attr);
|
2006-10-11 08:20:50 +00:00
|
|
|
if (error)
|
|
|
|
return error;
|
|
|
|
|
2017-10-19 00:21:58 +00:00
|
|
|
error = fscrypt_prepare_setattr(dentry, attr);
|
|
|
|
if (error)
|
|
|
|
return error;
|
|
|
|
|
2019-07-22 16:26:24 +00:00
|
|
|
error = fsverity_prepare_setattr(dentry, attr);
|
|
|
|
if (error)
|
|
|
|
return error;
|
|
|
|
|
2023-01-13 11:49:28 +00:00
|
|
|
if (is_quota_modification(idmap, inode, attr)) {
|
2015-06-29 14:22:54 +00:00
|
|
|
error = dquot_initialize(inode);
|
|
|
|
if (error)
|
|
|
|
return error;
|
|
|
|
}
|
2021-12-23 20:21:37 +00:00
|
|
|
|
2023-01-13 11:49:29 +00:00
|
|
|
if (i_uid_needs_update(idmap, attr, inode) ||
|
|
|
|
i_gid_needs_update(idmap, attr, inode)) {
|
2006-10-11 08:20:50 +00:00
|
|
|
handle_t *handle;
|
|
|
|
|
|
|
|
/* (user+group)*(old+new) structure, inode write (sb,
|
|
|
|
* inode block, ? - but truncate inode update has it) */
|
2013-02-09 02:59:22 +00:00
|
|
|
handle = ext4_journal_start(inode, EXT4_HT_QUOTA,
|
|
|
|
(EXT4_MAXQUOTAS_INIT_BLOCKS(inode->i_sb) +
|
|
|
|
EXT4_MAXQUOTAS_DEL_BLOCKS(inode->i_sb)) + 3);
|
2006-10-11 08:20:50 +00:00
|
|
|
if (IS_ERR(handle)) {
|
|
|
|
error = PTR_ERR(handle);
|
|
|
|
goto err_out;
|
|
|
|
}
|
2017-06-22 15:46:48 +00:00
|
|
|
|
|
|
|
/* dquot_transfer() calls back ext4_get_inode_usage() which
|
|
|
|
* counts xattr inode references.
|
|
|
|
*/
|
|
|
|
down_read(&EXT4_I(inode)->xattr_sem);
|
2023-01-13 11:49:28 +00:00
|
|
|
error = dquot_transfer(idmap, inode, attr);
|
2017-06-22 15:46:48 +00:00
|
|
|
up_read(&EXT4_I(inode)->xattr_sem);
|
|
|
|
|
2006-10-11 08:20:50 +00:00
|
|
|
if (error) {
|
2006-10-11 08:20:53 +00:00
|
|
|
ext4_journal_stop(handle);
|
2006-10-11 08:20:50 +00:00
|
|
|
return error;
|
|
|
|
}
|
|
|
|
/* Update corresponding info in inode so that everything is in
|
|
|
|
* one transaction */
|
2023-01-13 11:49:29 +00:00
|
|
|
i_uid_update(idmap, attr, inode);
|
|
|
|
i_gid_update(idmap, attr, inode);
|
2006-10-11 08:20:53 +00:00
|
|
|
error = ext4_mark_inode_dirty(handle, inode);
|
|
|
|
ext4_journal_stop(handle);
|
2021-01-17 08:57:32 +00:00
|
|
|
if (unlikely(error)) {
|
2020-04-27 01:34:37 +00:00
|
|
|
return error;
|
2021-01-17 08:57:32 +00:00
|
|
|
}
|
2006-10-11 08:20:50 +00:00
|
|
|
}
|
|
|
|
|
2015-06-22 04:31:26 +00:00
|
|
|
if (attr->ia_valid & ATTR_SIZE) {
|
2013-08-17 14:07:17 +00:00
|
|
|
handle_t *handle;
|
2015-06-22 04:31:26 +00:00
|
|
|
loff_t oldsize = inode->i_size;
|
2022-03-26 06:53:51 +00:00
|
|
|
loff_t old_disksize;
|
2019-05-30 15:56:23 +00:00
|
|
|
int shrink = (attr->ia_size < inode->i_size);
|
2011-06-24 18:29:45 +00:00
|
|
|
|
2010-05-17 02:00:00 +00:00
|
|
|
if (!(ext4_test_inode_flag(inode, EXT4_INODE_EXTENTS))) {
|
2008-01-29 04:58:27 +00:00
|
|
|
struct ext4_sb_info *sbi = EXT4_SB(inode->i_sb);
|
|
|
|
|
2020-10-15 20:37:57 +00:00
|
|
|
if (attr->ia_size > sbi->s_bitmap_maxbytes) {
|
2010-07-27 15:56:06 +00:00
|
|
|
return -EFBIG;
|
2020-10-15 20:37:57 +00:00
|
|
|
}
|
2008-01-29 04:58:27 +00:00
|
|
|
}
|
2020-10-15 20:37:57 +00:00
|
|
|
if (!S_ISREG(inode->i_mode)) {
|
2015-06-22 04:31:26 +00:00
|
|
|
return -EINVAL;
|
2020-10-15 20:37:57 +00:00
|
|
|
}
|
2013-11-19 15:17:07 +00:00
|
|
|
|
2022-09-08 17:24:42 +00:00
|
|
|
if (attr->ia_size == inode->i_size)
|
|
|
|
inc_ivers = false;
|
2013-11-19 15:17:07 +00:00
|
|
|
|
2019-05-30 15:56:23 +00:00
|
|
|
if (shrink) {
|
|
|
|
if (ext4_should_order_data(inode)) {
|
|
|
|
error = ext4_begin_ordered_truncate(inode,
|
2008-07-11 23:27:31 +00:00
|
|
|
attr->ia_size);
|
2019-05-30 15:56:23 +00:00
|
|
|
if (error)
|
|
|
|
goto err_out;
|
|
|
|
}
|
|
|
|
/*
|
|
|
|
* Blocks are going to be removed from the inode. Wait
|
|
|
|
* for dio in flight.
|
|
|
|
*/
|
|
|
|
inode_dio_wait(inode);
|
|
|
|
}
|
|
|
|
|
2021-02-04 17:05:42 +00:00
|
|
|
filemap_invalidate_lock(inode->i_mapping);
|
2019-05-30 15:56:23 +00:00
|
|
|
|
|
|
|
rc = ext4_break_layouts(inode);
|
|
|
|
if (rc) {
|
2021-02-04 17:05:42 +00:00
|
|
|
filemap_invalidate_unlock(inode->i_mapping);
|
2020-10-15 20:37:57 +00:00
|
|
|
goto err_out;
|
2015-06-22 04:31:26 +00:00
|
|
|
}
|
2019-05-30 15:56:23 +00:00
|
|
|
|
2015-06-22 04:31:26 +00:00
|
|
|
if (attr->ia_size != inode->i_size) {
|
2024-09-19 16:07:40 +00:00
|
|
|
/* attach jbd2 jinode for EOF folio tail zeroing */
|
|
|
|
if (attr->ia_size & (inode->i_sb->s_blocksize - 1) ||
|
|
|
|
oldsize & (inode->i_sb->s_blocksize - 1)) {
|
|
|
|
error = ext4_inode_attach_jinode(inode);
|
|
|
|
if (error)
|
|
|
|
goto err_out;
|
|
|
|
}
|
|
|
|
|
2013-08-17 14:07:17 +00:00
|
|
|
handle = ext4_journal_start(inode, EXT4_HT_INODE, 3);
|
|
|
|
if (IS_ERR(handle)) {
|
|
|
|
error = PTR_ERR(handle);
|
2019-05-30 15:56:23 +00:00
|
|
|
goto out_mmap_sem;
|
2013-08-17 14:07:17 +00:00
|
|
|
}
|
2015-06-22 04:31:26 +00:00
|
|
|
if (ext4_handle_valid(handle) && shrink) {
|
2013-08-17 14:07:17 +00:00
|
|
|
error = ext4_orphan_add(handle, inode);
|
|
|
|
orphan = 1;
|
|
|
|
}
|
2015-07-28 19:08:41 +00:00
|
|
|
/*
|
2024-09-19 16:07:40 +00:00
|
|
|
* Update c/mtime and tail zero the EOF folio on
|
|
|
|
* truncate up. ext4_truncate() handles the shrink case
|
|
|
|
* below.
|
2015-07-28 19:08:41 +00:00
|
|
|
*/
|
2024-09-19 16:07:40 +00:00
|
|
|
if (!shrink) {
|
2023-10-04 18:52:20 +00:00
|
|
|
inode_set_mtime_to_ts(inode,
|
|
|
|
inode_set_ctime_current(inode));
|
2024-09-19 16:07:40 +00:00
|
|
|
if (oldsize & (inode->i_sb->s_blocksize - 1))
|
|
|
|
ext4_block_truncate_page(handle,
|
|
|
|
inode->i_mapping, oldsize);
|
|
|
|
}
|
2020-10-15 20:37:57 +00:00
|
|
|
|
|
|
|
if (shrink)
|
2020-11-06 03:58:53 +00:00
|
|
|
ext4_fc_track_range(handle, inode,
|
2020-10-15 20:37:57 +00:00
|
|
|
(attr->ia_size > 0 ? attr->ia_size - 1 : 0) >>
|
|
|
|
inode->i_sb->s_blocksize_bits,
|
2021-12-23 03:23:37 +00:00
|
|
|
EXT_MAX_BLOCKS - 1);
|
2020-10-15 20:37:57 +00:00
|
|
|
else
|
|
|
|
ext4_fc_track_range(
|
2020-11-06 03:58:53 +00:00
|
|
|
handle, inode,
|
2020-10-15 20:37:57 +00:00
|
|
|
(oldsize > 0 ? oldsize - 1 : oldsize) >>
|
|
|
|
inode->i_sb->s_blocksize_bits,
|
|
|
|
(attr->ia_size > 0 ? attr->ia_size - 1 : 0) >>
|
|
|
|
inode->i_sb->s_blocksize_bits);
|
|
|
|
|
2013-08-17 14:09:31 +00:00
|
|
|
down_write(&EXT4_I(inode)->i_data_sem);
|
2022-03-26 06:53:51 +00:00
|
|
|
old_disksize = EXT4_I(inode)->i_disksize;
|
2013-08-17 14:07:17 +00:00
|
|
|
EXT4_I(inode)->i_disksize = attr->ia_size;
|
|
|
|
rc = ext4_mark_inode_dirty(handle, inode);
|
|
|
|
if (!error)
|
|
|
|
error = rc;
|
2013-08-17 14:09:31 +00:00
|
|
|
/*
|
|
|
|
* We have to update i_size under i_data_sem together
|
|
|
|
* with i_disksize to avoid races with writeback code
|
|
|
|
* running ext4_wb_update_i_disksize().
|
|
|
|
*/
|
|
|
|
if (!error)
|
|
|
|
i_size_write(inode, attr->ia_size);
|
2022-03-26 06:53:51 +00:00
|
|
|
else
|
|
|
|
EXT4_I(inode)->i_disksize = old_disksize;
|
2013-08-17 14:09:31 +00:00
|
|
|
up_write(&EXT4_I(inode)->i_data_sem);
|
2013-08-17 14:07:17 +00:00
|
|
|
ext4_journal_stop(handle);
|
2019-05-30 15:56:23 +00:00
|
|
|
if (error)
|
|
|
|
goto out_mmap_sem;
|
|
|
|
if (!shrink) {
|
|
|
|
pagecache_isize_extended(inode, oldsize,
|
|
|
|
inode->i_size);
|
|
|
|
} else if (ext4_should_journal_data(inode)) {
|
|
|
|
ext4_wait_for_tail_page_commit(inode);
|
2008-07-11 23:27:31 +00:00
|
|
|
}
|
2014-10-02 01:49:46 +00:00
|
|
|
}
|
2018-07-29 21:00:22 +00:00
|
|
|
|
2013-08-17 14:07:17 +00:00
|
|
|
/*
|
|
|
|
* Truncate pagecache after we've waited for commit
|
|
|
|
* in data=journal mode to make pages freeable.
|
|
|
|
*/
|
2015-02-16 23:59:38 +00:00
|
|
|
truncate_pagecache(inode, inode->i_size);
|
2019-05-30 15:56:23 +00:00
|
|
|
/*
|
|
|
|
* Call ext4_truncate() even if i_size didn't change to
|
|
|
|
* truncate possible preallocated blocks.
|
|
|
|
*/
|
|
|
|
if (attr->ia_size <= oldsize) {
|
2016-11-14 03:02:26 +00:00
|
|
|
rc = ext4_truncate(inode);
|
|
|
|
if (rc)
|
|
|
|
error = rc;
|
|
|
|
}
|
2019-05-30 15:56:23 +00:00
|
|
|
out_mmap_sem:
|
2021-02-04 17:05:42 +00:00
|
|
|
filemap_invalidate_unlock(inode->i_mapping);
|
2011-05-23 19:13:02 +00:00
|
|
|
}
|
2006-10-11 08:20:50 +00:00
|
|
|
|
2016-11-14 03:02:26 +00:00
|
|
|
if (!error) {
|
2022-09-08 17:24:42 +00:00
|
|
|
if (inc_ivers)
|
|
|
|
inode_inc_iversion(inode);
|
2023-01-13 11:49:11 +00:00
|
|
|
setattr_copy(idmap, inode, attr);
|
2010-06-04 09:30:02 +00:00
|
|
|
mark_inode_dirty(inode);
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* If the call to ext4_truncate failed to get a transaction handle at
|
|
|
|
* all, we need to clean up the in-core orphan list manually.
|
|
|
|
*/
|
2010-10-28 02:08:46 +00:00
|
|
|
if (orphan && inode->i_nlink)
|
2006-10-11 08:20:53 +00:00
|
|
|
ext4_orphan_del(NULL, inode);
|
2006-10-11 08:20:50 +00:00
|
|
|
|
2016-11-14 03:02:26 +00:00
|
|
|
if (!error && (ia_valid & ATTR_MODE))
|
2023-01-13 11:49:20 +00:00
|
|
|
rc = posix_acl_chmod(idmap, dentry, inode->i_mode);
|
2006-10-11 08:20:50 +00:00
|
|
|
|
|
|
|
err_out:
|
2020-10-15 20:37:57 +00:00
|
|
|
if (error)
|
|
|
|
ext4_std_error(inode->i_sb, error);
|
2006-10-11 08:20:50 +00:00
|
|
|
if (!error)
|
|
|
|
error = rc;
|
|
|
|
return error;
|
|
|
|
}
|
|
|
|
|
2022-08-27 06:58:47 +00:00
|
|
|
u32 ext4_dio_alignment(struct inode *inode)
|
|
|
|
{
|
|
|
|
if (fsverity_active(inode))
|
|
|
|
return 0;
|
|
|
|
if (ext4_should_journal_data(inode))
|
|
|
|
return 0;
|
|
|
|
if (ext4_has_inline_data(inode))
|
|
|
|
return 0;
|
|
|
|
if (IS_ENCRYPTED(inode)) {
|
|
|
|
if (!fscrypt_dio_supported(inode))
|
|
|
|
return 0;
|
|
|
|
return i_blocksize(inode);
|
|
|
|
}
|
|
|
|
return 1; /* use the iomap defaults */
|
|
|
|
}
|
|
|
|
|
2023-01-13 11:49:12 +00:00
|
|
|
int ext4_getattr(struct mnt_idmap *idmap, const struct path *path,
|
2021-01-21 13:19:43 +00:00
|
|
|
struct kstat *stat, u32 request_mask, unsigned int query_flags)
|
2008-07-11 23:27:31 +00:00
|
|
|
{
|
2017-03-31 17:31:56 +00:00
|
|
|
struct inode *inode = d_inode(path->dentry);
|
|
|
|
struct ext4_inode *raw_inode;
|
|
|
|
struct ext4_inode_info *ei = EXT4_I(inode);
|
|
|
|
unsigned int flags;
|
|
|
|
|
2019-11-29 03:26:51 +00:00
|
|
|
if ((request_mask & STATX_BTIME) &&
|
|
|
|
EXT4_FITS_IN_INODE(raw_inode, ei, i_crtime)) {
|
2017-03-31 17:31:56 +00:00
|
|
|
stat->result_mask |= STATX_BTIME;
|
|
|
|
stat->btime.tv_sec = ei->i_crtime.tv_sec;
|
|
|
|
stat->btime.tv_nsec = ei->i_crtime.tv_nsec;
|
|
|
|
}
|
|
|
|
|
2022-08-27 06:58:47 +00:00
|
|
|
/*
|
|
|
|
* Return the DIO alignment restrictions if requested. We only return
|
|
|
|
* this information when requested, since on encrypted files it might
|
|
|
|
* take a fair bit of work to get if the file wasn't opened recently.
|
|
|
|
*/
|
|
|
|
if ((request_mask & STATX_DIOALIGN) && S_ISREG(inode->i_mode)) {
|
|
|
|
u32 dio_align = ext4_dio_alignment(inode);
|
|
|
|
|
|
|
|
stat->result_mask |= STATX_DIOALIGN;
|
|
|
|
if (dio_align == 1) {
|
|
|
|
struct block_device *bdev = inode->i_sb->s_bdev;
|
|
|
|
|
|
|
|
/* iomap defaults */
|
|
|
|
stat->dio_mem_align = bdev_dma_alignment(bdev) + 1;
|
|
|
|
stat->dio_offset_align = bdev_logical_block_size(bdev);
|
|
|
|
} else {
|
|
|
|
stat->dio_mem_align = dio_align;
|
|
|
|
stat->dio_offset_align = dio_align;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2024-11-05 00:22:57 +00:00
|
|
|
if ((request_mask & STATX_WRITE_ATOMIC) && S_ISREG(inode->i_mode)) {
|
|
|
|
struct ext4_sb_info *sbi = EXT4_SB(inode->i_sb);
|
|
|
|
unsigned int awu_min = 0, awu_max = 0;
|
|
|
|
|
|
|
|
if (ext4_inode_can_atomic_write(inode)) {
|
|
|
|
awu_min = sbi->s_awu_min;
|
|
|
|
awu_max = sbi->s_awu_max;
|
|
|
|
}
|
|
|
|
|
|
|
|
generic_fill_statx_atomic_writes(stat, awu_min, awu_max);
|
|
|
|
}
|
|
|
|
|
2017-03-31 17:31:56 +00:00
|
|
|
flags = ei->i_flags & EXT4_FL_USER_VISIBLE;
|
|
|
|
if (flags & EXT4_APPEND_FL)
|
|
|
|
stat->attributes |= STATX_ATTR_APPEND;
|
|
|
|
if (flags & EXT4_COMPR_FL)
|
|
|
|
stat->attributes |= STATX_ATTR_COMPRESSED;
|
|
|
|
if (flags & EXT4_ENCRYPT_FL)
|
|
|
|
stat->attributes |= STATX_ATTR_ENCRYPTED;
|
|
|
|
if (flags & EXT4_IMMUTABLE_FL)
|
|
|
|
stat->attributes |= STATX_ATTR_IMMUTABLE;
|
|
|
|
if (flags & EXT4_NODUMP_FL)
|
|
|
|
stat->attributes |= STATX_ATTR_NODUMP;
|
2019-10-29 20:41:39 +00:00
|
|
|
if (flags & EXT4_VERITY_FL)
|
|
|
|
stat->attributes |= STATX_ATTR_VERITY;
|
2008-07-11 23:27:31 +00:00
|
|
|
|
2017-03-31 17:32:17 +00:00
|
|
|
stat->attributes_mask |= (STATX_ATTR_APPEND |
|
|
|
|
STATX_ATTR_COMPRESSED |
|
|
|
|
STATX_ATTR_ENCRYPTED |
|
|
|
|
STATX_ATTR_IMMUTABLE |
|
2019-10-29 20:41:39 +00:00
|
|
|
STATX_ATTR_NODUMP |
|
|
|
|
STATX_ATTR_VERITY);
|
2017-03-31 17:32:17 +00:00
|
|
|
|
2023-08-07 19:38:33 +00:00
|
|
|
generic_fillattr(idmap, request_mask, inode, stat);
|
2017-03-31 17:31:56 +00:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2023-01-13 11:49:12 +00:00
|
|
|
int ext4_file_getattr(struct mnt_idmap *idmap,
|
2021-01-21 13:19:43 +00:00
|
|
|
const struct path *path, struct kstat *stat,
|
2017-03-31 17:31:56 +00:00
|
|
|
u32 request_mask, unsigned int query_flags)
|
|
|
|
{
|
|
|
|
struct inode *inode = d_inode(path->dentry);
|
|
|
|
u64 delalloc_blocks;
|
|
|
|
|
2023-01-13 11:49:12 +00:00
|
|
|
ext4_getattr(idmap, path, stat, request_mask, query_flags);
|
2008-07-11 23:27:31 +00:00
|
|
|
|
2013-11-12 03:38:12 +00:00
|
|
|
/*
|
|
|
|
* If there is inline data in the inode, the inode will normally not
|
|
|
|
* have data blocks allocated (it may have an external xattr block).
|
|
|
|
* Report at least one sector for such files, so tools like tar, rsync,
|
2017-03-25 21:33:31 +00:00
|
|
|
* others don't incorrectly think the file is completely sparse.
|
2013-11-12 03:38:12 +00:00
|
|
|
*/
|
|
|
|
if (unlikely(ext4_has_inline_data(inode)))
|
|
|
|
stat->blocks += (stat->size + 511) >> 9;
|
|
|
|
|
2008-07-11 23:27:31 +00:00
|
|
|
/*
|
|
|
|
* We can't update i_blocks if the block allocation is delayed
|
|
|
|
* otherwise in the case of system crash before the real block
|
|
|
|
* allocation is done, we will have i_blocks inconsistent with
|
|
|
|
* on-disk file blocks.
|
|
|
|
* We always keep i_blocks updated together with real
|
|
|
|
* allocation. But to not confuse with user, stat
|
|
|
|
* will return the blocks that include the delayed allocation
|
|
|
|
* blocks for this file.
|
|
|
|
*/
|
2012-06-01 02:54:16 +00:00
|
|
|
delalloc_blocks = EXT4_C2B(EXT4_SB(inode->i_sb),
|
2013-11-12 03:38:12 +00:00
|
|
|
EXT4_I(inode)->i_reserved_data_blocks);
|
|
|
|
stat->blocks += delalloc_blocks << (inode->i_sb->s_blocksize_bits - 9);
|
2008-07-11 23:27:31 +00:00
|
|
|
return 0;
|
|
|
|
}
|
2006-10-11 08:20:50 +00:00
|
|
|
|
2013-06-04 17:01:11 +00:00
|
|
|
static int ext4_index_trans_blocks(struct inode *inode, int lblocks,
|
|
|
|
int pextents)
|
ext4: journal credits calulation cleanup and fix for non-extent writepage
When considering how many journal credits are needed for modifying a
chunk of data, we need to account for the super block, inode block,
quota blocks and xattr block, indirect/index blocks, also, group bitmap
and group descriptor blocks for new allocation (including data and
indirect/index blocks). There are many places in ext4 do the calculation
on their own and often missed one or two meta blocks, and often they
assume single block allocation, and did not considering the multile
chunk of allocation case.
This patch is trying to cleanup current journal credit code, provides
some common helper funtion to calculate the journal credits, to be used
for writepage, writepages, DIO, fallocate, migration, defrag, and for
both nonextent and extent files.
This patch modified the writepage/write_begin credit caculation for
nonextent files, to use the new helper function. It also fixed the
problem that writepage on nonextent files did not consider the case
blocksize <pagesize, thus could possibelly need multiple block
allocation in a single transaction.
Signed-off-by: Mingming Cao <cmm@us.ibm.com>
Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2008-08-20 02:16:07 +00:00
|
|
|
{
|
2010-05-17 02:00:00 +00:00
|
|
|
if (!(ext4_test_inode_flag(inode, EXT4_INODE_EXTENTS)))
|
2013-06-04 17:01:11 +00:00
|
|
|
return ext4_ind_trans_blocks(inode, lblocks);
|
|
|
|
return ext4_ext_index_trans_blocks(inode, pextents);
|
ext4: journal credits calulation cleanup and fix for non-extent writepage
When considering how many journal credits are needed for modifying a
chunk of data, we need to account for the super block, inode block,
quota blocks and xattr block, indirect/index blocks, also, group bitmap
and group descriptor blocks for new allocation (including data and
indirect/index blocks). There are many places in ext4 do the calculation
on their own and often missed one or two meta blocks, and often they
assume single block allocation, and did not considering the multile
chunk of allocation case.
This patch is trying to cleanup current journal credit code, provides
some common helper funtion to calculate the journal credits, to be used
for writepage, writepages, DIO, fallocate, migration, defrag, and for
both nonextent and extent files.
This patch modified the writepage/write_begin credit caculation for
nonextent files, to use the new helper function. It also fixed the
problem that writepage on nonextent files did not consider the case
blocksize <pagesize, thus could possibelly need multiple block
allocation in a single transaction.
Signed-off-by: Mingming Cao <cmm@us.ibm.com>
Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2008-08-20 02:16:07 +00:00
|
|
|
}
|
2008-11-06 21:49:36 +00:00
|
|
|
|
2006-10-11 08:20:50 +00:00
|
|
|
/*
|
ext4: journal credits calulation cleanup and fix for non-extent writepage
When considering how many journal credits are needed for modifying a
chunk of data, we need to account for the super block, inode block,
quota blocks and xattr block, indirect/index blocks, also, group bitmap
and group descriptor blocks for new allocation (including data and
indirect/index blocks). There are many places in ext4 do the calculation
on their own and often missed one or two meta blocks, and often they
assume single block allocation, and did not considering the multile
chunk of allocation case.
This patch is trying to cleanup current journal credit code, provides
some common helper funtion to calculate the journal credits, to be used
for writepage, writepages, DIO, fallocate, migration, defrag, and for
both nonextent and extent files.
This patch modified the writepage/write_begin credit caculation for
nonextent files, to use the new helper function. It also fixed the
problem that writepage on nonextent files did not consider the case
blocksize <pagesize, thus could possibelly need multiple block
allocation in a single transaction.
Signed-off-by: Mingming Cao <cmm@us.ibm.com>
Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2008-08-20 02:16:07 +00:00
|
|
|
* Account for index blocks, block groups bitmaps and block group
|
|
|
|
* descriptor blocks if modify datablocks and index blocks
|
|
|
|
* worse case, the indexs blocks spread over different block groups
|
2006-10-11 08:20:50 +00:00
|
|
|
*
|
ext4: journal credits calulation cleanup and fix for non-extent writepage
When considering how many journal credits are needed for modifying a
chunk of data, we need to account for the super block, inode block,
quota blocks and xattr block, indirect/index blocks, also, group bitmap
and group descriptor blocks for new allocation (including data and
indirect/index blocks). There are many places in ext4 do the calculation
on their own and often missed one or two meta blocks, and often they
assume single block allocation, and did not considering the multile
chunk of allocation case.
This patch is trying to cleanup current journal credit code, provides
some common helper funtion to calculate the journal credits, to be used
for writepage, writepages, DIO, fallocate, migration, defrag, and for
both nonextent and extent files.
This patch modified the writepage/write_begin credit caculation for
nonextent files, to use the new helper function. It also fixed the
problem that writepage on nonextent files did not consider the case
blocksize <pagesize, thus could possibelly need multiple block
allocation in a single transaction.
Signed-off-by: Mingming Cao <cmm@us.ibm.com>
Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2008-08-20 02:16:07 +00:00
|
|
|
* If datablocks are discontiguous, they are possible to spread over
|
2012-09-01 17:31:09 +00:00
|
|
|
* different block groups too. If they are contiguous, with flexbg,
|
ext4: journal credits calulation cleanup and fix for non-extent writepage
When considering how many journal credits are needed for modifying a
chunk of data, we need to account for the super block, inode block,
quota blocks and xattr block, indirect/index blocks, also, group bitmap
and group descriptor blocks for new allocation (including data and
indirect/index blocks). There are many places in ext4 do the calculation
on their own and often missed one or two meta blocks, and often they
assume single block allocation, and did not considering the multile
chunk of allocation case.
This patch is trying to cleanup current journal credit code, provides
some common helper funtion to calculate the journal credits, to be used
for writepage, writepages, DIO, fallocate, migration, defrag, and for
both nonextent and extent files.
This patch modified the writepage/write_begin credit caculation for
nonextent files, to use the new helper function. It also fixed the
problem that writepage on nonextent files did not consider the case
blocksize <pagesize, thus could possibelly need multiple block
allocation in a single transaction.
Signed-off-by: Mingming Cao <cmm@us.ibm.com>
Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2008-08-20 02:16:07 +00:00
|
|
|
* they could still across block group boundary.
|
2006-10-11 08:20:50 +00:00
|
|
|
*
|
ext4: journal credits calulation cleanup and fix for non-extent writepage
When considering how many journal credits are needed for modifying a
chunk of data, we need to account for the super block, inode block,
quota blocks and xattr block, indirect/index blocks, also, group bitmap
and group descriptor blocks for new allocation (including data and
indirect/index blocks). There are many places in ext4 do the calculation
on their own and often missed one or two meta blocks, and often they
assume single block allocation, and did not considering the multile
chunk of allocation case.
This patch is trying to cleanup current journal credit code, provides
some common helper funtion to calculate the journal credits, to be used
for writepage, writepages, DIO, fallocate, migration, defrag, and for
both nonextent and extent files.
This patch modified the writepage/write_begin credit caculation for
nonextent files, to use the new helper function. It also fixed the
problem that writepage on nonextent files did not consider the case
blocksize <pagesize, thus could possibelly need multiple block
allocation in a single transaction.
Signed-off-by: Mingming Cao <cmm@us.ibm.com>
Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2008-08-20 02:16:07 +00:00
|
|
|
* Also account for superblock, inode, quota and xattr blocks
|
|
|
|
*/
|
2017-06-22 15:44:55 +00:00
|
|
|
static int ext4_meta_trans_blocks(struct inode *inode, int lblocks,
|
2013-06-04 17:01:11 +00:00
|
|
|
int pextents)
|
ext4: journal credits calulation cleanup and fix for non-extent writepage
When considering how many journal credits are needed for modifying a
chunk of data, we need to account for the super block, inode block,
quota blocks and xattr block, indirect/index blocks, also, group bitmap
and group descriptor blocks for new allocation (including data and
indirect/index blocks). There are many places in ext4 do the calculation
on their own and often missed one or two meta blocks, and often they
assume single block allocation, and did not considering the multile
chunk of allocation case.
This patch is trying to cleanup current journal credit code, provides
some common helper funtion to calculate the journal credits, to be used
for writepage, writepages, DIO, fallocate, migration, defrag, and for
both nonextent and extent files.
This patch modified the writepage/write_begin credit caculation for
nonextent files, to use the new helper function. It also fixed the
problem that writepage on nonextent files did not consider the case
blocksize <pagesize, thus could possibelly need multiple block
allocation in a single transaction.
Signed-off-by: Mingming Cao <cmm@us.ibm.com>
Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2008-08-20 02:16:07 +00:00
|
|
|
{
|
2009-05-01 12:50:38 +00:00
|
|
|
ext4_group_t groups, ngroups = ext4_get_groups_count(inode->i_sb);
|
|
|
|
int gdpblocks;
|
ext4: journal credits calulation cleanup and fix for non-extent writepage
When considering how many journal credits are needed for modifying a
chunk of data, we need to account for the super block, inode block,
quota blocks and xattr block, indirect/index blocks, also, group bitmap
and group descriptor blocks for new allocation (including data and
indirect/index blocks). There are many places in ext4 do the calculation
on their own and often missed one or two meta blocks, and often they
assume single block allocation, and did not considering the multile
chunk of allocation case.
This patch is trying to cleanup current journal credit code, provides
some common helper funtion to calculate the journal credits, to be used
for writepage, writepages, DIO, fallocate, migration, defrag, and for
both nonextent and extent files.
This patch modified the writepage/write_begin credit caculation for
nonextent files, to use the new helper function. It also fixed the
problem that writepage on nonextent files did not consider the case
blocksize <pagesize, thus could possibelly need multiple block
allocation in a single transaction.
Signed-off-by: Mingming Cao <cmm@us.ibm.com>
Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2008-08-20 02:16:07 +00:00
|
|
|
int idxblocks;
|
2023-01-04 05:52:29 +00:00
|
|
|
int ret;
|
ext4: journal credits calulation cleanup and fix for non-extent writepage
When considering how many journal credits are needed for modifying a
chunk of data, we need to account for the super block, inode block,
quota blocks and xattr block, indirect/index blocks, also, group bitmap
and group descriptor blocks for new allocation (including data and
indirect/index blocks). There are many places in ext4 do the calculation
on their own and often missed one or two meta blocks, and often they
assume single block allocation, and did not considering the multile
chunk of allocation case.
This patch is trying to cleanup current journal credit code, provides
some common helper funtion to calculate the journal credits, to be used
for writepage, writepages, DIO, fallocate, migration, defrag, and for
both nonextent and extent files.
This patch modified the writepage/write_begin credit caculation for
nonextent files, to use the new helper function. It also fixed the
problem that writepage on nonextent files did not consider the case
blocksize <pagesize, thus could possibelly need multiple block
allocation in a single transaction.
Signed-off-by: Mingming Cao <cmm@us.ibm.com>
Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2008-08-20 02:16:07 +00:00
|
|
|
|
|
|
|
/*
|
2013-06-04 17:01:11 +00:00
|
|
|
* How many index blocks need to touch to map @lblocks logical blocks
|
|
|
|
* to @pextents physical extents?
|
ext4: journal credits calulation cleanup and fix for non-extent writepage
When considering how many journal credits are needed for modifying a
chunk of data, we need to account for the super block, inode block,
quota blocks and xattr block, indirect/index blocks, also, group bitmap
and group descriptor blocks for new allocation (including data and
indirect/index blocks). There are many places in ext4 do the calculation
on their own and often missed one or two meta blocks, and often they
assume single block allocation, and did not considering the multile
chunk of allocation case.
This patch is trying to cleanup current journal credit code, provides
some common helper funtion to calculate the journal credits, to be used
for writepage, writepages, DIO, fallocate, migration, defrag, and for
both nonextent and extent files.
This patch modified the writepage/write_begin credit caculation for
nonextent files, to use the new helper function. It also fixed the
problem that writepage on nonextent files did not consider the case
blocksize <pagesize, thus could possibelly need multiple block
allocation in a single transaction.
Signed-off-by: Mingming Cao <cmm@us.ibm.com>
Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2008-08-20 02:16:07 +00:00
|
|
|
*/
|
2013-06-04 17:01:11 +00:00
|
|
|
idxblocks = ext4_index_trans_blocks(inode, lblocks, pextents);
|
ext4: journal credits calulation cleanup and fix for non-extent writepage
When considering how many journal credits are needed for modifying a
chunk of data, we need to account for the super block, inode block,
quota blocks and xattr block, indirect/index blocks, also, group bitmap
and group descriptor blocks for new allocation (including data and
indirect/index blocks). There are many places in ext4 do the calculation
on their own and often missed one or two meta blocks, and often they
assume single block allocation, and did not considering the multile
chunk of allocation case.
This patch is trying to cleanup current journal credit code, provides
some common helper funtion to calculate the journal credits, to be used
for writepage, writepages, DIO, fallocate, migration, defrag, and for
both nonextent and extent files.
This patch modified the writepage/write_begin credit caculation for
nonextent files, to use the new helper function. It also fixed the
problem that writepage on nonextent files did not consider the case
blocksize <pagesize, thus could possibelly need multiple block
allocation in a single transaction.
Signed-off-by: Mingming Cao <cmm@us.ibm.com>
Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2008-08-20 02:16:07 +00:00
|
|
|
|
|
|
|
ret = idxblocks;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Now let's see how many group bitmaps and group descriptors need
|
|
|
|
* to account
|
|
|
|
*/
|
2013-06-04 17:01:11 +00:00
|
|
|
groups = idxblocks + pextents;
|
ext4: journal credits calulation cleanup and fix for non-extent writepage
When considering how many journal credits are needed for modifying a
chunk of data, we need to account for the super block, inode block,
quota blocks and xattr block, indirect/index blocks, also, group bitmap
and group descriptor blocks for new allocation (including data and
indirect/index blocks). There are many places in ext4 do the calculation
on their own and often missed one or two meta blocks, and often they
assume single block allocation, and did not considering the multile
chunk of allocation case.
This patch is trying to cleanup current journal credit code, provides
some common helper funtion to calculate the journal credits, to be used
for writepage, writepages, DIO, fallocate, migration, defrag, and for
both nonextent and extent files.
This patch modified the writepage/write_begin credit caculation for
nonextent files, to use the new helper function. It also fixed the
problem that writepage on nonextent files did not consider the case
blocksize <pagesize, thus could possibelly need multiple block
allocation in a single transaction.
Signed-off-by: Mingming Cao <cmm@us.ibm.com>
Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2008-08-20 02:16:07 +00:00
|
|
|
gdpblocks = groups;
|
2009-05-01 12:50:38 +00:00
|
|
|
if (groups > ngroups)
|
|
|
|
groups = ngroups;
|
ext4: journal credits calulation cleanup and fix for non-extent writepage
When considering how many journal credits are needed for modifying a
chunk of data, we need to account for the super block, inode block,
quota blocks and xattr block, indirect/index blocks, also, group bitmap
and group descriptor blocks for new allocation (including data and
indirect/index blocks). There are many places in ext4 do the calculation
on their own and often missed one or two meta blocks, and often they
assume single block allocation, and did not considering the multile
chunk of allocation case.
This patch is trying to cleanup current journal credit code, provides
some common helper funtion to calculate the journal credits, to be used
for writepage, writepages, DIO, fallocate, migration, defrag, and for
both nonextent and extent files.
This patch modified the writepage/write_begin credit caculation for
nonextent files, to use the new helper function. It also fixed the
problem that writepage on nonextent files did not consider the case
blocksize <pagesize, thus could possibelly need multiple block
allocation in a single transaction.
Signed-off-by: Mingming Cao <cmm@us.ibm.com>
Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2008-08-20 02:16:07 +00:00
|
|
|
if (groups > EXT4_SB(inode->i_sb)->s_gdb_count)
|
|
|
|
gdpblocks = EXT4_SB(inode->i_sb)->s_gdb_count;
|
|
|
|
|
|
|
|
/* bitmaps and block group descriptor blocks */
|
|
|
|
ret += groups + gdpblocks;
|
|
|
|
|
|
|
|
/* Blocks for super block, inode, quota and xattr blocks */
|
|
|
|
ret += EXT4_META_TRANS_BLOCKS(inode->i_sb);
|
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
2011-03-31 01:57:33 +00:00
|
|
|
* Calculate the total number of credits to reserve to fit
|
2008-08-20 02:16:03 +00:00
|
|
|
* the modification of a single pages into a single transaction,
|
|
|
|
* which may include multiple chunks of block allocations.
|
2006-10-11 08:20:50 +00:00
|
|
|
*
|
2008-08-20 02:15:58 +00:00
|
|
|
* This could be called via ext4_write_begin()
|
2006-10-11 08:20:50 +00:00
|
|
|
*
|
2008-08-20 02:15:58 +00:00
|
|
|
* We need to consider the worse case, when
|
ext4: journal credits calulation cleanup and fix for non-extent writepage
When considering how many journal credits are needed for modifying a
chunk of data, we need to account for the super block, inode block,
quota blocks and xattr block, indirect/index blocks, also, group bitmap
and group descriptor blocks for new allocation (including data and
indirect/index blocks). There are many places in ext4 do the calculation
on their own and often missed one or two meta blocks, and often they
assume single block allocation, and did not considering the multile
chunk of allocation case.
This patch is trying to cleanup current journal credit code, provides
some common helper funtion to calculate the journal credits, to be used
for writepage, writepages, DIO, fallocate, migration, defrag, and for
both nonextent and extent files.
This patch modified the writepage/write_begin credit caculation for
nonextent files, to use the new helper function. It also fixed the
problem that writepage on nonextent files did not consider the case
blocksize <pagesize, thus could possibelly need multiple block
allocation in a single transaction.
Signed-off-by: Mingming Cao <cmm@us.ibm.com>
Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2008-08-20 02:16:07 +00:00
|
|
|
* one new block per extent.
|
2006-10-11 08:20:50 +00:00
|
|
|
*/
|
2006-10-11 08:21:03 +00:00
|
|
|
int ext4_writepage_trans_blocks(struct inode *inode)
|
2006-10-11 08:20:50 +00:00
|
|
|
{
|
2006-10-11 08:20:53 +00:00
|
|
|
int bpp = ext4_journal_blocks_per_page(inode);
|
2006-10-11 08:20:50 +00:00
|
|
|
int ret;
|
|
|
|
|
2013-06-04 17:01:11 +00:00
|
|
|
ret = ext4_meta_trans_blocks(inode, bpp, bpp);
|
2006-10-11 08:21:03 +00:00
|
|
|
|
ext4: journal credits calulation cleanup and fix for non-extent writepage
When considering how many journal credits are needed for modifying a
chunk of data, we need to account for the super block, inode block,
quota blocks and xattr block, indirect/index blocks, also, group bitmap
and group descriptor blocks for new allocation (including data and
indirect/index blocks). There are many places in ext4 do the calculation
on their own and often missed one or two meta blocks, and often they
assume single block allocation, and did not considering the multile
chunk of allocation case.
This patch is trying to cleanup current journal credit code, provides
some common helper funtion to calculate the journal credits, to be used
for writepage, writepages, DIO, fallocate, migration, defrag, and for
both nonextent and extent files.
This patch modified the writepage/write_begin credit caculation for
nonextent files, to use the new helper function. It also fixed the
problem that writepage on nonextent files did not consider the case
blocksize <pagesize, thus could possibelly need multiple block
allocation in a single transaction.
Signed-off-by: Mingming Cao <cmm@us.ibm.com>
Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2008-08-20 02:16:07 +00:00
|
|
|
/* Account for data blocks for journalled mode */
|
2006-10-11 08:20:53 +00:00
|
|
|
if (ext4_should_journal_data(inode))
|
ext4: journal credits calulation cleanup and fix for non-extent writepage
When considering how many journal credits are needed for modifying a
chunk of data, we need to account for the super block, inode block,
quota blocks and xattr block, indirect/index blocks, also, group bitmap
and group descriptor blocks for new allocation (including data and
indirect/index blocks). There are many places in ext4 do the calculation
on their own and often missed one or two meta blocks, and often they
assume single block allocation, and did not considering the multile
chunk of allocation case.
This patch is trying to cleanup current journal credit code, provides
some common helper funtion to calculate the journal credits, to be used
for writepage, writepages, DIO, fallocate, migration, defrag, and for
both nonextent and extent files.
This patch modified the writepage/write_begin credit caculation for
nonextent files, to use the new helper function. It also fixed the
problem that writepage on nonextent files did not consider the case
blocksize <pagesize, thus could possibelly need multiple block
allocation in a single transaction.
Signed-off-by: Mingming Cao <cmm@us.ibm.com>
Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2008-08-20 02:16:07 +00:00
|
|
|
ret += bpp;
|
2006-10-11 08:20:50 +00:00
|
|
|
return ret;
|
|
|
|
}
|
2008-08-20 02:16:03 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Calculate the journal credits for a chunk of data modification.
|
|
|
|
*
|
|
|
|
* This is called from DIO, fallocate or whoever calling
|
2010-07-27 15:56:07 +00:00
|
|
|
* ext4_map_blocks() to map/allocate a chunk of contiguous disk blocks.
|
2008-08-20 02:16:03 +00:00
|
|
|
*
|
|
|
|
* journal buffers for data blocks are not included here, as DIO
|
|
|
|
* and fallocate do no need to journal data buffers.
|
|
|
|
*/
|
|
|
|
int ext4_chunk_trans_blocks(struct inode *inode, int nrblocks)
|
|
|
|
{
|
|
|
|
return ext4_meta_trans_blocks(inode, nrblocks, 1);
|
|
|
|
}
|
|
|
|
|
2006-10-11 08:20:50 +00:00
|
|
|
/*
|
2006-10-11 08:20:53 +00:00
|
|
|
* The caller must have previously called ext4_reserve_inode_write().
|
2006-10-11 08:20:50 +00:00
|
|
|
* Give this, we know that the caller already has write access to iloc->bh.
|
|
|
|
*/
|
2006-10-11 08:20:53 +00:00
|
|
|
int ext4_mark_iloc_dirty(handle_t *handle,
|
2009-06-14 21:45:34 +00:00
|
|
|
struct inode *inode, struct ext4_iloc *iloc)
|
2006-10-11 08:20:50 +00:00
|
|
|
{
|
|
|
|
int err = 0;
|
|
|
|
|
2023-06-16 16:50:49 +00:00
|
|
|
if (unlikely(ext4_forced_shutdown(inode->i_sb))) {
|
2018-11-06 21:49:50 +00:00
|
|
|
put_bh(iloc->bh);
|
2017-02-05 06:28:48 +00:00
|
|
|
return -EIO;
|
2018-11-06 21:49:50 +00:00
|
|
|
}
|
2020-11-06 03:58:53 +00:00
|
|
|
ext4_fc_track_inode(handle, inode);
|
2020-10-15 20:37:57 +00:00
|
|
|
|
2006-10-11 08:20:50 +00:00
|
|
|
/* the do_update_inode consumes one bh->b_count */
|
|
|
|
get_bh(iloc->bh);
|
|
|
|
|
2006-10-11 08:21:01 +00:00
|
|
|
/* ext4_do_update_inode() does jbd2_journal_dirty_metadata */
|
2009-09-29 14:07:47 +00:00
|
|
|
err = ext4_do_update_inode(handle, inode, iloc);
|
2006-10-11 08:20:50 +00:00
|
|
|
put_bh(iloc->bh);
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* On success, We end up with an outstanding reference count against
|
|
|
|
* iloc->bh. This _must_ be cleaned up later.
|
|
|
|
*/
|
|
|
|
|
|
|
|
int
|
2006-10-11 08:20:53 +00:00
|
|
|
ext4_reserve_inode_write(handle_t *handle, struct inode *inode,
|
|
|
|
struct ext4_iloc *iloc)
|
2006-10-11 08:20:50 +00:00
|
|
|
{
|
2009-01-07 05:06:22 +00:00
|
|
|
int err;
|
|
|
|
|
2023-06-16 16:50:49 +00:00
|
|
|
if (unlikely(ext4_forced_shutdown(inode->i_sb)))
|
2017-02-05 06:28:48 +00:00
|
|
|
return -EIO;
|
|
|
|
|
2009-01-07 05:06:22 +00:00
|
|
|
err = ext4_get_inode_loc(inode, iloc);
|
|
|
|
if (!err) {
|
|
|
|
BUFFER_TRACE(iloc->bh, "get_write_access");
|
2021-08-16 09:57:04 +00:00
|
|
|
err = ext4_journal_get_write_access(handle, inode->i_sb,
|
|
|
|
iloc->bh, EXT4_JTR_NONE);
|
2009-01-07 05:06:22 +00:00
|
|
|
if (err) {
|
|
|
|
brelse(iloc->bh);
|
|
|
|
iloc->bh = NULL;
|
2006-10-11 08:20:50 +00:00
|
|
|
}
|
|
|
|
}
|
2006-10-11 08:20:53 +00:00
|
|
|
ext4_std_error(inode->i_sb, err);
|
2006-10-11 08:20:50 +00:00
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
2017-08-06 05:00:49 +00:00
|
|
|
static int __ext4_expand_extra_isize(struct inode *inode,
|
|
|
|
unsigned int new_extra_isize,
|
|
|
|
struct ext4_iloc *iloc,
|
|
|
|
handle_t *handle, int *no_expand)
|
|
|
|
{
|
|
|
|
struct ext4_inode *raw_inode;
|
|
|
|
struct ext4_xattr_ibody_header *header;
|
2019-11-08 02:43:41 +00:00
|
|
|
unsigned int inode_size = EXT4_INODE_SIZE(inode->i_sb);
|
|
|
|
struct ext4_inode_info *ei = EXT4_I(inode);
|
2017-08-06 05:00:49 +00:00
|
|
|
int error;
|
|
|
|
|
2019-11-08 02:43:41 +00:00
|
|
|
/* this was checked at iget time, but double check for good measure */
|
|
|
|
if ((EXT4_GOOD_OLD_INODE_SIZE + ei->i_extra_isize > inode_size) ||
|
|
|
|
(ei->i_extra_isize & 3)) {
|
|
|
|
EXT4_ERROR_INODE(inode, "bad extra_isize %u (inode size %u)",
|
|
|
|
ei->i_extra_isize,
|
|
|
|
EXT4_INODE_SIZE(inode->i_sb));
|
|
|
|
return -EFSCORRUPTED;
|
|
|
|
}
|
|
|
|
if ((new_extra_isize < ei->i_extra_isize) ||
|
|
|
|
(new_extra_isize < 4) ||
|
|
|
|
(new_extra_isize > inode_size - EXT4_GOOD_OLD_INODE_SIZE))
|
|
|
|
return -EINVAL; /* Should never happen */
|
|
|
|
|
2017-08-06 05:00:49 +00:00
|
|
|
raw_inode = ext4_raw_inode(iloc);
|
|
|
|
|
|
|
|
header = IHDR(inode, raw_inode);
|
|
|
|
|
|
|
|
/* No extended attributes present */
|
|
|
|
if (!ext4_test_inode_state(inode, EXT4_STATE_XATTR) ||
|
|
|
|
header->h_magic != cpu_to_le32(EXT4_XATTR_MAGIC)) {
|
|
|
|
memset((void *)raw_inode + EXT4_GOOD_OLD_INODE_SIZE +
|
|
|
|
EXT4_I(inode)->i_extra_isize, 0,
|
|
|
|
new_extra_isize - EXT4_I(inode)->i_extra_isize);
|
|
|
|
EXT4_I(inode)->i_extra_isize = new_extra_isize;
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2022-12-07 11:59:28 +00:00
|
|
|
/*
|
|
|
|
* We may need to allocate external xattr block so we need quotas
|
|
|
|
* initialized. Here we can be called with various locks held so we
|
|
|
|
* cannot affort to initialize quotas ourselves. So just bail.
|
|
|
|
*/
|
|
|
|
if (dquot_initialize_needed(inode))
|
|
|
|
return -EAGAIN;
|
|
|
|
|
2017-08-06 05:00:49 +00:00
|
|
|
/* try to expand with EAs present */
|
|
|
|
error = ext4_expand_extra_isize_ea(inode, new_extra_isize,
|
|
|
|
raw_inode, handle);
|
|
|
|
if (error) {
|
|
|
|
/*
|
|
|
|
* Inode size expansion failed; don't try again
|
|
|
|
*/
|
|
|
|
*no_expand = 1;
|
|
|
|
}
|
|
|
|
|
|
|
|
return error;
|
|
|
|
}
|
|
|
|
|
2007-07-18 13:19:57 +00:00
|
|
|
/*
|
|
|
|
* Expand an inode by new_extra_isize bytes.
|
|
|
|
* Returns 0 on success or negative error number on failure.
|
|
|
|
*/
|
2017-08-06 04:40:01 +00:00
|
|
|
static int ext4_try_to_expand_extra_isize(struct inode *inode,
|
|
|
|
unsigned int new_extra_isize,
|
|
|
|
struct ext4_iloc iloc,
|
|
|
|
handle_t *handle)
|
2007-07-18 13:19:57 +00:00
|
|
|
{
|
2017-08-06 04:27:38 +00:00
|
|
|
int no_expand;
|
|
|
|
int error;
|
2007-07-18 13:19:57 +00:00
|
|
|
|
2017-08-06 04:40:01 +00:00
|
|
|
if (ext4_test_inode_state(inode, EXT4_STATE_NO_EXPAND))
|
|
|
|
return -EOVERFLOW;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* In nojournal mode, we can immediately attempt to expand
|
|
|
|
* the inode. When journaled, we first need to obtain extra
|
|
|
|
* buffer credits since we may write into the EA block
|
|
|
|
* with this same handle. If journal_extend fails, then it will
|
|
|
|
* only result in a minor loss of functionality for that inode.
|
|
|
|
* If this is felt to be critical, then e2fsck should be run to
|
|
|
|
* force a large enough s_min_extra_isize.
|
|
|
|
*/
|
2019-11-05 16:44:14 +00:00
|
|
|
if (ext4_journal_extend(handle,
|
2019-11-05 16:44:29 +00:00
|
|
|
EXT4_DATA_TRANS_BLOCKS(inode->i_sb), 0) != 0)
|
2017-08-06 04:40:01 +00:00
|
|
|
return -ENOSPC;
|
2007-07-18 13:19:57 +00:00
|
|
|
|
2017-08-06 04:27:38 +00:00
|
|
|
if (ext4_write_trylock_xattr(inode, &no_expand) == 0)
|
2017-08-06 04:40:01 +00:00
|
|
|
return -EBUSY;
|
2017-08-06 04:27:38 +00:00
|
|
|
|
2017-08-06 05:00:49 +00:00
|
|
|
error = __ext4_expand_extra_isize(inode, new_extra_isize, &iloc,
|
|
|
|
handle, &no_expand);
|
|
|
|
ext4_write_unlock_xattr(inode, &no_expand);
|
2007-07-18 13:19:57 +00:00
|
|
|
|
2017-08-06 05:00:49 +00:00
|
|
|
return error;
|
|
|
|
}
|
2007-07-18 13:19:57 +00:00
|
|
|
|
2017-08-06 05:00:49 +00:00
|
|
|
int ext4_expand_extra_isize(struct inode *inode,
|
|
|
|
unsigned int new_extra_isize,
|
|
|
|
struct ext4_iloc *iloc)
|
|
|
|
{
|
|
|
|
handle_t *handle;
|
|
|
|
int no_expand;
|
|
|
|
int error, rc;
|
|
|
|
|
|
|
|
if (ext4_test_inode_state(inode, EXT4_STATE_NO_EXPAND)) {
|
|
|
|
brelse(iloc->bh);
|
|
|
|
return -EOVERFLOW;
|
2007-07-18 13:19:57 +00:00
|
|
|
}
|
|
|
|
|
2017-08-06 05:00:49 +00:00
|
|
|
handle = ext4_journal_start(inode, EXT4_HT_INODE,
|
|
|
|
EXT4_DATA_TRANS_BLOCKS(inode->i_sb));
|
|
|
|
if (IS_ERR(handle)) {
|
|
|
|
error = PTR_ERR(handle);
|
|
|
|
brelse(iloc->bh);
|
|
|
|
return error;
|
|
|
|
}
|
|
|
|
|
|
|
|
ext4_write_lock_xattr(inode, &no_expand);
|
|
|
|
|
2019-02-21 16:29:10 +00:00
|
|
|
BUFFER_TRACE(iloc->bh, "get_write_access");
|
2021-08-16 09:57:04 +00:00
|
|
|
error = ext4_journal_get_write_access(handle, inode->i_sb, iloc->bh,
|
|
|
|
EXT4_JTR_NONE);
|
2017-08-06 04:27:38 +00:00
|
|
|
if (error) {
|
2017-08-06 05:00:49 +00:00
|
|
|
brelse(iloc->bh);
|
2019-12-13 18:50:11 +00:00
|
|
|
goto out_unlock;
|
2017-08-06 04:27:38 +00:00
|
|
|
}
|
2017-08-06 04:40:01 +00:00
|
|
|
|
2017-08-06 05:00:49 +00:00
|
|
|
error = __ext4_expand_extra_isize(inode, new_extra_isize, iloc,
|
|
|
|
handle, &no_expand);
|
|
|
|
|
|
|
|
rc = ext4_mark_iloc_dirty(handle, inode, iloc);
|
|
|
|
if (!error)
|
|
|
|
error = rc;
|
|
|
|
|
2019-12-13 18:50:11 +00:00
|
|
|
out_unlock:
|
2017-08-06 05:00:49 +00:00
|
|
|
ext4_write_unlock_xattr(inode, &no_expand);
|
|
|
|
ext4_journal_stop(handle);
|
2017-08-06 04:27:38 +00:00
|
|
|
return error;
|
2007-07-18 13:19:57 +00:00
|
|
|
}
|
|
|
|
|
2006-10-11 08:20:50 +00:00
|
|
|
/*
|
|
|
|
* What we do here is to mark the in-core inode as clean with respect to inode
|
|
|
|
* dirtiness (it may still be data-dirty).
|
|
|
|
* This means that the in-core inode may be reaped by prune_icache
|
|
|
|
* without having to perform any I/O. This is a very good thing,
|
|
|
|
* because *any* task may call prune_icache - even ones which
|
|
|
|
* have a transaction open against a different journal.
|
|
|
|
*
|
|
|
|
* Is this cheating? Not really. Sure, we haven't written the
|
|
|
|
* inode out, but prune_icache isn't a user-visible syncing function.
|
|
|
|
* Whenever the user wants stuff synced (sys_sync, sys_msync, sys_fsync)
|
|
|
|
* we start and wait on commits.
|
|
|
|
*/
|
2020-04-27 01:34:37 +00:00
|
|
|
int __ext4_mark_inode_dirty(handle_t *handle, struct inode *inode,
|
|
|
|
const char *func, unsigned int line)
|
2006-10-11 08:20:50 +00:00
|
|
|
{
|
2006-10-11 08:20:53 +00:00
|
|
|
struct ext4_iloc iloc;
|
2007-07-18 13:19:57 +00:00
|
|
|
struct ext4_sb_info *sbi = EXT4_SB(inode->i_sb);
|
2017-08-06 04:40:01 +00:00
|
|
|
int err;
|
2006-10-11 08:20:50 +00:00
|
|
|
|
|
|
|
might_sleep();
|
2010-11-08 18:51:33 +00:00
|
|
|
trace_ext4_mark_inode_dirty(inode, _RET_IP_);
|
2006-10-11 08:20:53 +00:00
|
|
|
err = ext4_reserve_inode_write(handle, inode, &iloc);
|
2016-03-13 02:40:32 +00:00
|
|
|
if (err)
|
2020-04-27 01:34:37 +00:00
|
|
|
goto out;
|
2017-08-06 04:40:01 +00:00
|
|
|
|
|
|
|
if (EXT4_I(inode)->i_extra_isize < sbi->s_want_extra_isize)
|
|
|
|
ext4_try_to_expand_extra_isize(inode, sbi->s_want_extra_isize,
|
|
|
|
iloc, handle);
|
|
|
|
|
2020-04-27 01:34:37 +00:00
|
|
|
err = ext4_mark_iloc_dirty(handle, inode, &iloc);
|
|
|
|
out:
|
|
|
|
if (unlikely(err))
|
|
|
|
ext4_error_inode_err(inode, func, line, 0, err,
|
|
|
|
"mark_inode_dirty error");
|
|
|
|
return err;
|
2006-10-11 08:20:50 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
2006-10-11 08:20:53 +00:00
|
|
|
* ext4_dirty_inode() is called from __mark_inode_dirty()
|
2006-10-11 08:20:50 +00:00
|
|
|
*
|
|
|
|
* We're really interested in the case where a file is being extended.
|
|
|
|
* i_size has been changed by generic_commit_write() and we thus need
|
|
|
|
* to include the updated inode in the current transaction.
|
|
|
|
*
|
2010-03-03 14:05:00 +00:00
|
|
|
* Also, dquot_alloc_block() will always dirty the inode when blocks
|
2006-10-11 08:20:50 +00:00
|
|
|
* are allocated to the file.
|
|
|
|
*
|
|
|
|
* If the inode is marked synchronous, we don't honour that here - doing
|
|
|
|
* so would cause a commit on atime updates, which we don't bother doing.
|
|
|
|
* We handle synchronous inodes at the highest possible level.
|
|
|
|
*/
|
2011-05-27 10:53:02 +00:00
|
|
|
void ext4_dirty_inode(struct inode *inode, int flags)
|
2006-10-11 08:20:50 +00:00
|
|
|
{
|
|
|
|
handle_t *handle;
|
|
|
|
|
2013-02-09 02:59:22 +00:00
|
|
|
handle = ext4_journal_start(inode, EXT4_HT_INODE, 2);
|
2006-10-11 08:20:50 +00:00
|
|
|
if (IS_ERR(handle))
|
2021-01-12 19:02:47 +00:00
|
|
|
return;
|
2009-09-29 20:06:01 +00:00
|
|
|
ext4_mark_inode_dirty(handle, inode);
|
2006-10-11 08:20:53 +00:00
|
|
|
ext4_journal_stop(handle);
|
2006-10-11 08:20:50 +00:00
|
|
|
}
|
|
|
|
|
2006-10-11 08:20:53 +00:00
|
|
|
int ext4_change_inode_journal_flag(struct inode *inode, int val)
|
2006-10-11 08:20:50 +00:00
|
|
|
{
|
|
|
|
journal_t *journal;
|
|
|
|
handle_t *handle;
|
|
|
|
int err;
|
2023-05-04 12:47:23 +00:00
|
|
|
int alloc_ctx;
|
2006-10-11 08:20:50 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* We have to be very careful here: changing a data block's
|
|
|
|
* journaling status dynamically is dangerous. If we write a
|
|
|
|
* data block to the journal, change the status and then delete
|
|
|
|
* that block, we risk forgetting to revoke the old log record
|
|
|
|
* from the journal and so a subsequent replay can corrupt data.
|
|
|
|
* So, first we make sure that the journal is empty and that
|
|
|
|
* nobody is changing anything.
|
|
|
|
*/
|
|
|
|
|
2006-10-11 08:20:53 +00:00
|
|
|
journal = EXT4_JOURNAL(inode);
|
2009-01-07 05:06:22 +00:00
|
|
|
if (!journal)
|
|
|
|
return 0;
|
2007-07-18 12:33:51 +00:00
|
|
|
if (is_journal_aborted(journal))
|
2006-10-11 08:20:50 +00:00
|
|
|
return -EROFS;
|
|
|
|
|
2012-09-29 04:41:21 +00:00
|
|
|
/* Wait for all existing dio workers */
|
|
|
|
inode_dio_wait(inode);
|
|
|
|
|
ext4: handle unwritten or delalloc buffers before enabling data journaling
We already allocate delalloc blocks before changing the inode mode into
"per-file data journal" mode to prevent delalloc blocks from remaining
not allocated, but another issue concerned with "BH_Unwritten" status
still exists. For example, by fallocate(), several buffers' status
change into "BH_Unwritten", but these buffers cannot be processed by
ext4_alloc_da_blocks(). So, they still remain in unwritten status after
per-file data journaling is enabled and they cannot be changed into
written status any more and, if they are journaled and eventually
checkpointed, these unwritten buffer will cause a kernel panic by the
below BUG_ON() function of submit_bh_wbc() when they are submitted
during checkpointing.
static int submit_bh_wbc(int rw, struct buffer_head *bh,...
{
...
BUG_ON(buffer_unwritten(bh));
Moreover, when "dioread_nolock" option is enabled, the status of a
buffer is changed into "BH_Unwritten" after write_begin() completes and
the "BH_Unwritten" status will be cleared after I/O is done. Therefore,
if a buffer's status is changed into unwrutten but the buffer's I/O is
not submitted and completed, it can cause the same problem after
enabling per-file data journaling. You can easily generate this bug by
executing the following command.
./kvm-xfstests -C 10000 -m nodelalloc,dioread_nolock generic/269
To resolve these problems and define a boundary between the previous
mode and per-file data journaling mode, we need to flush and wait all
the I/O of buffers of a file before enabling per-file data journaling
of the file.
Signed-off-by: Daeho Jeong <daeho.jeong@samsung.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Reviewed-by: Jan Kara <jack@suse.cz>
2016-04-26 03:21:00 +00:00
|
|
|
/*
|
|
|
|
* Before flushing the journal and switching inode's aops, we have
|
|
|
|
* to flush all dirty data the inode has. There can be outstanding
|
|
|
|
* delayed allocations, there can be unwritten extents created by
|
|
|
|
* fallocate or buffered writes in dioread_nolock mode covered by
|
|
|
|
* dirty data which can be converted only after flushing the dirty
|
|
|
|
* data (and journalled aops don't know how to handle these cases).
|
|
|
|
*/
|
|
|
|
if (val) {
|
2021-02-04 17:05:42 +00:00
|
|
|
filemap_invalidate_lock(inode->i_mapping);
|
ext4: handle unwritten or delalloc buffers before enabling data journaling
We already allocate delalloc blocks before changing the inode mode into
"per-file data journal" mode to prevent delalloc blocks from remaining
not allocated, but another issue concerned with "BH_Unwritten" status
still exists. For example, by fallocate(), several buffers' status
change into "BH_Unwritten", but these buffers cannot be processed by
ext4_alloc_da_blocks(). So, they still remain in unwritten status after
per-file data journaling is enabled and they cannot be changed into
written status any more and, if they are journaled and eventually
checkpointed, these unwritten buffer will cause a kernel panic by the
below BUG_ON() function of submit_bh_wbc() when they are submitted
during checkpointing.
static int submit_bh_wbc(int rw, struct buffer_head *bh,...
{
...
BUG_ON(buffer_unwritten(bh));
Moreover, when "dioread_nolock" option is enabled, the status of a
buffer is changed into "BH_Unwritten" after write_begin() completes and
the "BH_Unwritten" status will be cleared after I/O is done. Therefore,
if a buffer's status is changed into unwrutten but the buffer's I/O is
not submitted and completed, it can cause the same problem after
enabling per-file data journaling. You can easily generate this bug by
executing the following command.
./kvm-xfstests -C 10000 -m nodelalloc,dioread_nolock generic/269
To resolve these problems and define a boundary between the previous
mode and per-file data journaling mode, we need to flush and wait all
the I/O of buffers of a file before enabling per-file data journaling
of the file.
Signed-off-by: Daeho Jeong <daeho.jeong@samsung.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Reviewed-by: Jan Kara <jack@suse.cz>
2016-04-26 03:21:00 +00:00
|
|
|
err = filemap_write_and_wait(inode->i_mapping);
|
|
|
|
if (err < 0) {
|
2021-02-04 17:05:42 +00:00
|
|
|
filemap_invalidate_unlock(inode->i_mapping);
|
ext4: handle unwritten or delalloc buffers before enabling data journaling
We already allocate delalloc blocks before changing the inode mode into
"per-file data journal" mode to prevent delalloc blocks from remaining
not allocated, but another issue concerned with "BH_Unwritten" status
still exists. For example, by fallocate(), several buffers' status
change into "BH_Unwritten", but these buffers cannot be processed by
ext4_alloc_da_blocks(). So, they still remain in unwritten status after
per-file data journaling is enabled and they cannot be changed into
written status any more and, if they are journaled and eventually
checkpointed, these unwritten buffer will cause a kernel panic by the
below BUG_ON() function of submit_bh_wbc() when they are submitted
during checkpointing.
static int submit_bh_wbc(int rw, struct buffer_head *bh,...
{
...
BUG_ON(buffer_unwritten(bh));
Moreover, when "dioread_nolock" option is enabled, the status of a
buffer is changed into "BH_Unwritten" after write_begin() completes and
the "BH_Unwritten" status will be cleared after I/O is done. Therefore,
if a buffer's status is changed into unwrutten but the buffer's I/O is
not submitted and completed, it can cause the same problem after
enabling per-file data journaling. You can easily generate this bug by
executing the following command.
./kvm-xfstests -C 10000 -m nodelalloc,dioread_nolock generic/269
To resolve these problems and define a boundary between the previous
mode and per-file data journaling mode, we need to flush and wait all
the I/O of buffers of a file before enabling per-file data journaling
of the file.
Signed-off-by: Daeho Jeong <daeho.jeong@samsung.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Reviewed-by: Jan Kara <jack@suse.cz>
2016-04-26 03:21:00 +00:00
|
|
|
return err;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2023-05-04 12:47:23 +00:00
|
|
|
alloc_ctx = ext4_writepages_down_write(inode->i_sb);
|
2006-10-11 08:21:01 +00:00
|
|
|
jbd2_journal_lock_updates(journal);
|
2006-10-11 08:20:50 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* OK, there are no updates running now, and all cached data is
|
|
|
|
* synced to disk. We are now in a completely consistent state
|
|
|
|
* which doesn't have anything in the journal, and we know that
|
|
|
|
* no filesystem updates are running, so it is safe to modify
|
|
|
|
* the inode's in-core data-journaling state flag now.
|
|
|
|
*/
|
|
|
|
|
|
|
|
if (val)
|
2010-05-17 02:00:00 +00:00
|
|
|
ext4_set_inode_flag(inode, EXT4_INODE_JOURNAL_DATA);
|
2011-12-28 18:55:51 +00:00
|
|
|
else {
|
2021-05-18 15:13:25 +00:00
|
|
|
err = jbd2_journal_flush(journal, 0);
|
2014-10-30 14:53:17 +00:00
|
|
|
if (err < 0) {
|
|
|
|
jbd2_journal_unlock_updates(journal);
|
2023-05-04 12:47:23 +00:00
|
|
|
ext4_writepages_up_write(inode->i_sb, alloc_ctx);
|
2014-10-30 14:53:17 +00:00
|
|
|
return err;
|
|
|
|
}
|
2010-05-17 02:00:00 +00:00
|
|
|
ext4_clear_inode_flag(inode, EXT4_INODE_JOURNAL_DATA);
|
2011-12-28 18:55:51 +00:00
|
|
|
}
|
2006-10-11 08:20:53 +00:00
|
|
|
ext4_set_aops(inode);
|
2006-10-11 08:20:50 +00:00
|
|
|
|
2006-10-11 08:21:01 +00:00
|
|
|
jbd2_journal_unlock_updates(journal);
|
2023-05-04 12:47:23 +00:00
|
|
|
ext4_writepages_up_write(inode->i_sb, alloc_ctx);
|
2016-04-26 03:22:35 +00:00
|
|
|
|
ext4: handle unwritten or delalloc buffers before enabling data journaling
We already allocate delalloc blocks before changing the inode mode into
"per-file data journal" mode to prevent delalloc blocks from remaining
not allocated, but another issue concerned with "BH_Unwritten" status
still exists. For example, by fallocate(), several buffers' status
change into "BH_Unwritten", but these buffers cannot be processed by
ext4_alloc_da_blocks(). So, they still remain in unwritten status after
per-file data journaling is enabled and they cannot be changed into
written status any more and, if they are journaled and eventually
checkpointed, these unwritten buffer will cause a kernel panic by the
below BUG_ON() function of submit_bh_wbc() when they are submitted
during checkpointing.
static int submit_bh_wbc(int rw, struct buffer_head *bh,...
{
...
BUG_ON(buffer_unwritten(bh));
Moreover, when "dioread_nolock" option is enabled, the status of a
buffer is changed into "BH_Unwritten" after write_begin() completes and
the "BH_Unwritten" status will be cleared after I/O is done. Therefore,
if a buffer's status is changed into unwrutten but the buffer's I/O is
not submitted and completed, it can cause the same problem after
enabling per-file data journaling. You can easily generate this bug by
executing the following command.
./kvm-xfstests -C 10000 -m nodelalloc,dioread_nolock generic/269
To resolve these problems and define a boundary between the previous
mode and per-file data journaling mode, we need to flush and wait all
the I/O of buffers of a file before enabling per-file data journaling
of the file.
Signed-off-by: Daeho Jeong <daeho.jeong@samsung.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Reviewed-by: Jan Kara <jack@suse.cz>
2016-04-26 03:21:00 +00:00
|
|
|
if (val)
|
2021-02-04 17:05:42 +00:00
|
|
|
filemap_invalidate_unlock(inode->i_mapping);
|
2006-10-11 08:20:50 +00:00
|
|
|
|
|
|
|
/* Finally we can mark the inode as dirty. */
|
|
|
|
|
2013-02-09 02:59:22 +00:00
|
|
|
handle = ext4_journal_start(inode, EXT4_HT_INODE, 1);
|
2006-10-11 08:20:50 +00:00
|
|
|
if (IS_ERR(handle))
|
|
|
|
return PTR_ERR(handle);
|
|
|
|
|
2020-10-15 20:37:57 +00:00
|
|
|
ext4_fc_mark_ineligible(inode->i_sb,
|
2022-01-17 09:36:54 +00:00
|
|
|
EXT4_FC_REASON_JOURNAL_FLAG_CHANGE, handle);
|
2006-10-11 08:20:53 +00:00
|
|
|
err = ext4_mark_inode_dirty(handle, inode);
|
2009-01-07 05:06:22 +00:00
|
|
|
ext4_handle_sync(handle);
|
2006-10-11 08:20:53 +00:00
|
|
|
ext4_journal_stop(handle);
|
|
|
|
ext4_std_error(inode->i_sb, err);
|
2006-10-11 08:20:50 +00:00
|
|
|
|
|
|
|
return err;
|
|
|
|
}
|
2008-07-11 23:27:31 +00:00
|
|
|
|
2021-08-16 09:57:04 +00:00
|
|
|
static int ext4_bh_unmapped(handle_t *handle, struct inode *inode,
|
|
|
|
struct buffer_head *bh)
|
2008-07-11 23:27:31 +00:00
|
|
|
{
|
|
|
|
return !buffer_mapped(bh);
|
|
|
|
}
|
|
|
|
|
2018-10-03 02:20:50 +00:00
|
|
|
vm_fault_t ext4_page_mkwrite(struct vm_fault *vmf)
|
2008-07-11 23:27:31 +00:00
|
|
|
{
|
2017-02-24 22:56:41 +00:00
|
|
|
struct vm_area_struct *vma = vmf->vma;
|
2023-03-24 18:01:25 +00:00
|
|
|
struct folio *folio = page_folio(vmf->page);
|
2008-07-11 23:27:31 +00:00
|
|
|
loff_t size;
|
|
|
|
unsigned long len;
|
2018-10-03 02:20:50 +00:00
|
|
|
int err;
|
|
|
|
vm_fault_t ret;
|
2008-07-11 23:27:31 +00:00
|
|
|
struct file *file = vma->vm_file;
|
2013-01-23 22:07:38 +00:00
|
|
|
struct inode *inode = file_inode(file);
|
2008-07-11 23:27:31 +00:00
|
|
|
struct address_space *mapping = inode->i_mapping;
|
2011-06-24 18:29:41 +00:00
|
|
|
handle_t *handle;
|
|
|
|
get_block_t *get_block;
|
|
|
|
int retries = 0;
|
2008-07-11 23:27:31 +00:00
|
|
|
|
2019-06-10 02:04:33 +00:00
|
|
|
if (unlikely(IS_IMMUTABLE(inode)))
|
|
|
|
return VM_FAULT_SIGBUS;
|
|
|
|
|
2012-06-12 14:20:38 +00:00
|
|
|
sb_start_pagefault(inode->i_sb);
|
2012-10-01 03:04:56 +00:00
|
|
|
file_update_time(vma->vm_file);
|
2015-12-07 19:28:03 +00:00
|
|
|
|
2021-02-04 17:05:42 +00:00
|
|
|
filemap_invalidate_lock_shared(mapping);
|
2017-04-30 04:10:50 +00:00
|
|
|
|
2018-10-03 02:20:50 +00:00
|
|
|
err = ext4_convert_inline_data(inode);
|
|
|
|
if (err)
|
2017-04-30 04:10:50 +00:00
|
|
|
goto out_ret;
|
|
|
|
|
ext4: data=journal: fixes for ext4_page_mkwrite()
These are two fixes for data journalling required by
the next patch, discovered while testing it.
First, the optimization to return early if all buffers
are mapped is not appropriate for the next patch:
The inode _must_ be added to the transaction's list in
data=journal mode (so to write-protect pages on commit)
thus we cannot return early there.
Second, once that optimization to reduce transactions
was disabled for data=journal mode, more transactions
happened, and occasionally hit this warning message:
'JBD2: Spotted dirty metadata buffer'.
Reason is, block_page_mkwrite() will set_buffer_dirty()
before do_journal_get_write_access() that is there to
prevent it. This issue was masked by the optimization.
So, on data=journal use __block_write_begin() instead.
This also requires page locking and len recalculation.
(see block_page_mkwrite() for implementation details.)
Finally, as Jan noted there is little sharing between
data=journal and other modes in ext4_page_mkwrite().
However, a prototype of ext4_journalled_page_mkwrite()
showed there still would be lots of duplicated lines
(tens of) that didn't seem worth it.
Thus this patch ends up with an ugly goto to skip all
non-data journalling code (to avoid long indentations,
but that can be changed..) in the beginning, and just
a conditional in the transaction section.
Well, we skip a common part to data journalling which
is the page truncated check, but we do it again after
ext4_journal_start() when we re-acquire the page lock
(so not to acquire the page lock twice needlessly for
data journalling.)
Signed-off-by: Mauricio Faria de Oliveira <mfo@canonical.com>
Suggested-by: Jan Kara <jack@suse.cz>
Reviewed-by: Jan Kara <jack@suse.cz>
Reviewed-by: Andreas Dilger <adilger@dilger.ca>
Link: https://lore.kernel.org/r/20201006004841.600488-4-mfo@canonical.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
2020-10-06 00:48:40 +00:00
|
|
|
/*
|
|
|
|
* On data journalling we skip straight to the transaction handle:
|
|
|
|
* there's no delalloc; page truncated will be checked later; the
|
|
|
|
* early return w/ all buffers mapped (calculates size/len) can't
|
|
|
|
* be used; and there's no dioread_nolock, so only ext4_get_block.
|
|
|
|
*/
|
|
|
|
if (ext4_should_journal_data(inode))
|
|
|
|
goto retry_alloc;
|
|
|
|
|
2011-06-24 18:29:41 +00:00
|
|
|
/* Delalloc case is easy... */
|
|
|
|
if (test_opt(inode->i_sb, DELALLOC) &&
|
|
|
|
!ext4_nonda_switch(inode->i_sb)) {
|
|
|
|
do {
|
2018-10-03 02:20:50 +00:00
|
|
|
err = block_page_mkwrite(vma, vmf,
|
2011-06-24 18:29:41 +00:00
|
|
|
ext4_da_get_block_prep);
|
2018-10-03 02:20:50 +00:00
|
|
|
} while (err == -ENOSPC &&
|
2011-06-24 18:29:41 +00:00
|
|
|
ext4_should_retry_alloc(inode->i_sb, &retries));
|
|
|
|
goto out_ret;
|
2008-07-11 23:27:31 +00:00
|
|
|
}
|
2011-05-18 17:55:20 +00:00
|
|
|
|
2023-03-24 18:01:25 +00:00
|
|
|
folio_lock(folio);
|
2011-06-24 18:29:41 +00:00
|
|
|
size = i_size_read(inode);
|
|
|
|
/* Page got truncated from under us? */
|
2023-03-24 18:01:25 +00:00
|
|
|
if (folio->mapping != mapping || folio_pos(folio) > size) {
|
|
|
|
folio_unlock(folio);
|
2011-06-24 18:29:41 +00:00
|
|
|
ret = VM_FAULT_NOPAGE;
|
|
|
|
goto out;
|
2011-05-18 17:55:20 +00:00
|
|
|
}
|
2008-07-11 23:27:31 +00:00
|
|
|
|
2023-03-24 18:01:25 +00:00
|
|
|
len = folio_size(folio);
|
|
|
|
if (folio_pos(folio) + len > size)
|
|
|
|
len = size - folio_pos(folio);
|
2009-09-10 02:36:03 +00:00
|
|
|
/*
|
2011-06-24 18:29:41 +00:00
|
|
|
* Return if we have all the buffers mapped. This avoids the need to do
|
|
|
|
* journal_start/journal_stop which can block and take a long time
|
ext4: data=journal: fixes for ext4_page_mkwrite()
These are two fixes for data journalling required by
the next patch, discovered while testing it.
First, the optimization to return early if all buffers
are mapped is not appropriate for the next patch:
The inode _must_ be added to the transaction's list in
data=journal mode (so to write-protect pages on commit)
thus we cannot return early there.
Second, once that optimization to reduce transactions
was disabled for data=journal mode, more transactions
happened, and occasionally hit this warning message:
'JBD2: Spotted dirty metadata buffer'.
Reason is, block_page_mkwrite() will set_buffer_dirty()
before do_journal_get_write_access() that is there to
prevent it. This issue was masked by the optimization.
So, on data=journal use __block_write_begin() instead.
This also requires page locking and len recalculation.
(see block_page_mkwrite() for implementation details.)
Finally, as Jan noted there is little sharing between
data=journal and other modes in ext4_page_mkwrite().
However, a prototype of ext4_journalled_page_mkwrite()
showed there still would be lots of duplicated lines
(tens of) that didn't seem worth it.
Thus this patch ends up with an ugly goto to skip all
non-data journalling code (to avoid long indentations,
but that can be changed..) in the beginning, and just
a conditional in the transaction section.
Well, we skip a common part to data journalling which
is the page truncated check, but we do it again after
ext4_journal_start() when we re-acquire the page lock
(so not to acquire the page lock twice needlessly for
data journalling.)
Signed-off-by: Mauricio Faria de Oliveira <mfo@canonical.com>
Suggested-by: Jan Kara <jack@suse.cz>
Reviewed-by: Jan Kara <jack@suse.cz>
Reviewed-by: Andreas Dilger <adilger@dilger.ca>
Link: https://lore.kernel.org/r/20201006004841.600488-4-mfo@canonical.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
2020-10-06 00:48:40 +00:00
|
|
|
*
|
|
|
|
* This cannot be done for data journalling, as we have to add the
|
|
|
|
* inode to the transaction's list to writeprotect pages on commit.
|
2009-09-10 02:36:03 +00:00
|
|
|
*/
|
2023-03-24 18:01:25 +00:00
|
|
|
if (folio_buffers(folio)) {
|
|
|
|
if (!ext4_walk_page_buffers(NULL, inode, folio_buffers(folio),
|
2012-12-10 19:05:51 +00:00
|
|
|
0, len, NULL,
|
|
|
|
ext4_bh_unmapped)) {
|
2011-06-24 18:29:41 +00:00
|
|
|
/* Wait so that we don't change page under IO */
|
2023-03-24 18:01:25 +00:00
|
|
|
folio_wait_stable(folio);
|
2011-06-24 18:29:41 +00:00
|
|
|
ret = VM_FAULT_LOCKED;
|
|
|
|
goto out;
|
2009-09-10 02:36:03 +00:00
|
|
|
}
|
2008-07-11 23:27:31 +00:00
|
|
|
}
|
2023-03-24 18:01:25 +00:00
|
|
|
folio_unlock(folio);
|
2011-06-24 18:29:41 +00:00
|
|
|
/* OK, we need to fill the hole... */
|
|
|
|
if (ext4_should_dioread_nolock(inode))
|
2016-03-09 04:08:10 +00:00
|
|
|
get_block = ext4_get_block_unwritten;
|
2011-06-24 18:29:41 +00:00
|
|
|
else
|
|
|
|
get_block = ext4_get_block;
|
|
|
|
retry_alloc:
|
2013-02-09 02:59:22 +00:00
|
|
|
handle = ext4_journal_start(inode, EXT4_HT_WRITE_PAGE,
|
|
|
|
ext4_writepage_trans_blocks(inode));
|
2011-06-24 18:29:41 +00:00
|
|
|
if (IS_ERR(handle)) {
|
2009-03-31 22:23:21 +00:00
|
|
|
ret = VM_FAULT_SIGBUS;
|
2011-06-24 18:29:41 +00:00
|
|
|
goto out;
|
|
|
|
}
|
ext4: data=journal: fixes for ext4_page_mkwrite()
These are two fixes for data journalling required by
the next patch, discovered while testing it.
First, the optimization to return early if all buffers
are mapped is not appropriate for the next patch:
The inode _must_ be added to the transaction's list in
data=journal mode (so to write-protect pages on commit)
thus we cannot return early there.
Second, once that optimization to reduce transactions
was disabled for data=journal mode, more transactions
happened, and occasionally hit this warning message:
'JBD2: Spotted dirty metadata buffer'.
Reason is, block_page_mkwrite() will set_buffer_dirty()
before do_journal_get_write_access() that is there to
prevent it. This issue was masked by the optimization.
So, on data=journal use __block_write_begin() instead.
This also requires page locking and len recalculation.
(see block_page_mkwrite() for implementation details.)
Finally, as Jan noted there is little sharing between
data=journal and other modes in ext4_page_mkwrite().
However, a prototype of ext4_journalled_page_mkwrite()
showed there still would be lots of duplicated lines
(tens of) that didn't seem worth it.
Thus this patch ends up with an ugly goto to skip all
non-data journalling code (to avoid long indentations,
but that can be changed..) in the beginning, and just
a conditional in the transaction section.
Well, we skip a common part to data journalling which
is the page truncated check, but we do it again after
ext4_journal_start() when we re-acquire the page lock
(so not to acquire the page lock twice needlessly for
data journalling.)
Signed-off-by: Mauricio Faria de Oliveira <mfo@canonical.com>
Suggested-by: Jan Kara <jack@suse.cz>
Reviewed-by: Jan Kara <jack@suse.cz>
Reviewed-by: Andreas Dilger <adilger@dilger.ca>
Link: https://lore.kernel.org/r/20201006004841.600488-4-mfo@canonical.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
2020-10-06 00:48:40 +00:00
|
|
|
/*
|
|
|
|
* Data journalling can't use block_page_mkwrite() because it
|
|
|
|
* will set_buffer_dirty() before do_journal_get_write_access()
|
|
|
|
* thus might hit warning messages for dirty metadata buffers.
|
|
|
|
*/
|
|
|
|
if (!ext4_should_journal_data(inode)) {
|
|
|
|
err = block_page_mkwrite(vma, vmf, get_block);
|
|
|
|
} else {
|
2023-03-24 18:01:25 +00:00
|
|
|
folio_lock(folio);
|
ext4: data=journal: fixes for ext4_page_mkwrite()
These are two fixes for data journalling required by
the next patch, discovered while testing it.
First, the optimization to return early if all buffers
are mapped is not appropriate for the next patch:
The inode _must_ be added to the transaction's list in
data=journal mode (so to write-protect pages on commit)
thus we cannot return early there.
Second, once that optimization to reduce transactions
was disabled for data=journal mode, more transactions
happened, and occasionally hit this warning message:
'JBD2: Spotted dirty metadata buffer'.
Reason is, block_page_mkwrite() will set_buffer_dirty()
before do_journal_get_write_access() that is there to
prevent it. This issue was masked by the optimization.
So, on data=journal use __block_write_begin() instead.
This also requires page locking and len recalculation.
(see block_page_mkwrite() for implementation details.)
Finally, as Jan noted there is little sharing between
data=journal and other modes in ext4_page_mkwrite().
However, a prototype of ext4_journalled_page_mkwrite()
showed there still would be lots of duplicated lines
(tens of) that didn't seem worth it.
Thus this patch ends up with an ugly goto to skip all
non-data journalling code (to avoid long indentations,
but that can be changed..) in the beginning, and just
a conditional in the transaction section.
Well, we skip a common part to data journalling which
is the page truncated check, but we do it again after
ext4_journal_start() when we re-acquire the page lock
(so not to acquire the page lock twice needlessly for
data journalling.)
Signed-off-by: Mauricio Faria de Oliveira <mfo@canonical.com>
Suggested-by: Jan Kara <jack@suse.cz>
Reviewed-by: Jan Kara <jack@suse.cz>
Reviewed-by: Andreas Dilger <adilger@dilger.ca>
Link: https://lore.kernel.org/r/20201006004841.600488-4-mfo@canonical.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
2020-10-06 00:48:40 +00:00
|
|
|
size = i_size_read(inode);
|
|
|
|
/* Page got truncated from under us? */
|
2023-03-24 18:01:25 +00:00
|
|
|
if (folio->mapping != mapping || folio_pos(folio) > size) {
|
ext4: data=journal: fixes for ext4_page_mkwrite()
These are two fixes for data journalling required by
the next patch, discovered while testing it.
First, the optimization to return early if all buffers
are mapped is not appropriate for the next patch:
The inode _must_ be added to the transaction's list in
data=journal mode (so to write-protect pages on commit)
thus we cannot return early there.
Second, once that optimization to reduce transactions
was disabled for data=journal mode, more transactions
happened, and occasionally hit this warning message:
'JBD2: Spotted dirty metadata buffer'.
Reason is, block_page_mkwrite() will set_buffer_dirty()
before do_journal_get_write_access() that is there to
prevent it. This issue was masked by the optimization.
So, on data=journal use __block_write_begin() instead.
This also requires page locking and len recalculation.
(see block_page_mkwrite() for implementation details.)
Finally, as Jan noted there is little sharing between
data=journal and other modes in ext4_page_mkwrite().
However, a prototype of ext4_journalled_page_mkwrite()
showed there still would be lots of duplicated lines
(tens of) that didn't seem worth it.
Thus this patch ends up with an ugly goto to skip all
non-data journalling code (to avoid long indentations,
but that can be changed..) in the beginning, and just
a conditional in the transaction section.
Well, we skip a common part to data journalling which
is the page truncated check, but we do it again after
ext4_journal_start() when we re-acquire the page lock
(so not to acquire the page lock twice needlessly for
data journalling.)
Signed-off-by: Mauricio Faria de Oliveira <mfo@canonical.com>
Suggested-by: Jan Kara <jack@suse.cz>
Reviewed-by: Jan Kara <jack@suse.cz>
Reviewed-by: Andreas Dilger <adilger@dilger.ca>
Link: https://lore.kernel.org/r/20201006004841.600488-4-mfo@canonical.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
2020-10-06 00:48:40 +00:00
|
|
|
ret = VM_FAULT_NOPAGE;
|
2020-10-06 00:48:41 +00:00
|
|
|
goto out_error;
|
2011-06-24 18:29:41 +00:00
|
|
|
}
|
ext4: data=journal: fixes for ext4_page_mkwrite()
These are two fixes for data journalling required by
the next patch, discovered while testing it.
First, the optimization to return early if all buffers
are mapped is not appropriate for the next patch:
The inode _must_ be added to the transaction's list in
data=journal mode (so to write-protect pages on commit)
thus we cannot return early there.
Second, once that optimization to reduce transactions
was disabled for data=journal mode, more transactions
happened, and occasionally hit this warning message:
'JBD2: Spotted dirty metadata buffer'.
Reason is, block_page_mkwrite() will set_buffer_dirty()
before do_journal_get_write_access() that is there to
prevent it. This issue was masked by the optimization.
So, on data=journal use __block_write_begin() instead.
This also requires page locking and len recalculation.
(see block_page_mkwrite() for implementation details.)
Finally, as Jan noted there is little sharing between
data=journal and other modes in ext4_page_mkwrite().
However, a prototype of ext4_journalled_page_mkwrite()
showed there still would be lots of duplicated lines
(tens of) that didn't seem worth it.
Thus this patch ends up with an ugly goto to skip all
non-data journalling code (to avoid long indentations,
but that can be changed..) in the beginning, and just
a conditional in the transaction section.
Well, we skip a common part to data journalling which
is the page truncated check, but we do it again after
ext4_journal_start() when we re-acquire the page lock
(so not to acquire the page lock twice needlessly for
data journalling.)
Signed-off-by: Mauricio Faria de Oliveira <mfo@canonical.com>
Suggested-by: Jan Kara <jack@suse.cz>
Reviewed-by: Jan Kara <jack@suse.cz>
Reviewed-by: Andreas Dilger <adilger@dilger.ca>
Link: https://lore.kernel.org/r/20201006004841.600488-4-mfo@canonical.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
2020-10-06 00:48:40 +00:00
|
|
|
|
2023-03-24 18:01:25 +00:00
|
|
|
len = folio_size(folio);
|
|
|
|
if (folio_pos(folio) + len > size)
|
|
|
|
len = size - folio_pos(folio);
|
ext4: data=journal: fixes for ext4_page_mkwrite()
These are two fixes for data journalling required by
the next patch, discovered while testing it.
First, the optimization to return early if all buffers
are mapped is not appropriate for the next patch:
The inode _must_ be added to the transaction's list in
data=journal mode (so to write-protect pages on commit)
thus we cannot return early there.
Second, once that optimization to reduce transactions
was disabled for data=journal mode, more transactions
happened, and occasionally hit this warning message:
'JBD2: Spotted dirty metadata buffer'.
Reason is, block_page_mkwrite() will set_buffer_dirty()
before do_journal_get_write_access() that is there to
prevent it. This issue was masked by the optimization.
So, on data=journal use __block_write_begin() instead.
This also requires page locking and len recalculation.
(see block_page_mkwrite() for implementation details.)
Finally, as Jan noted there is little sharing between
data=journal and other modes in ext4_page_mkwrite().
However, a prototype of ext4_journalled_page_mkwrite()
showed there still would be lots of duplicated lines
(tens of) that didn't seem worth it.
Thus this patch ends up with an ugly goto to skip all
non-data journalling code (to avoid long indentations,
but that can be changed..) in the beginning, and just
a conditional in the transaction section.
Well, we skip a common part to data journalling which
is the page truncated check, but we do it again after
ext4_journal_start() when we re-acquire the page lock
(so not to acquire the page lock twice needlessly for
data journalling.)
Signed-off-by: Mauricio Faria de Oliveira <mfo@canonical.com>
Suggested-by: Jan Kara <jack@suse.cz>
Reviewed-by: Jan Kara <jack@suse.cz>
Reviewed-by: Andreas Dilger <adilger@dilger.ca>
Link: https://lore.kernel.org/r/20201006004841.600488-4-mfo@canonical.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
2020-10-06 00:48:40 +00:00
|
|
|
|
2024-08-30 05:37:38 +00:00
|
|
|
err = ext4_block_write_begin(handle, folio, 0, len,
|
|
|
|
ext4_get_block);
|
ext4: data=journal: fixes for ext4_page_mkwrite()
These are two fixes for data journalling required by
the next patch, discovered while testing it.
First, the optimization to return early if all buffers
are mapped is not appropriate for the next patch:
The inode _must_ be added to the transaction's list in
data=journal mode (so to write-protect pages on commit)
thus we cannot return early there.
Second, once that optimization to reduce transactions
was disabled for data=journal mode, more transactions
happened, and occasionally hit this warning message:
'JBD2: Spotted dirty metadata buffer'.
Reason is, block_page_mkwrite() will set_buffer_dirty()
before do_journal_get_write_access() that is there to
prevent it. This issue was masked by the optimization.
So, on data=journal use __block_write_begin() instead.
This also requires page locking and len recalculation.
(see block_page_mkwrite() for implementation details.)
Finally, as Jan noted there is little sharing between
data=journal and other modes in ext4_page_mkwrite().
However, a prototype of ext4_journalled_page_mkwrite()
showed there still would be lots of duplicated lines
(tens of) that didn't seem worth it.
Thus this patch ends up with an ugly goto to skip all
non-data journalling code (to avoid long indentations,
but that can be changed..) in the beginning, and just
a conditional in the transaction section.
Well, we skip a common part to data journalling which
is the page truncated check, but we do it again after
ext4_journal_start() when we re-acquire the page lock
(so not to acquire the page lock twice needlessly for
data journalling.)
Signed-off-by: Mauricio Faria de Oliveira <mfo@canonical.com>
Suggested-by: Jan Kara <jack@suse.cz>
Reviewed-by: Jan Kara <jack@suse.cz>
Reviewed-by: Andreas Dilger <adilger@dilger.ca>
Link: https://lore.kernel.org/r/20201006004841.600488-4-mfo@canonical.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
2020-10-06 00:48:40 +00:00
|
|
|
if (!err) {
|
2020-10-06 00:48:41 +00:00
|
|
|
ret = VM_FAULT_SIGBUS;
|
2023-05-15 10:40:43 +00:00
|
|
|
if (ext4_journal_folio_buffers(handle, folio, len))
|
2020-10-06 00:48:41 +00:00
|
|
|
goto out_error;
|
ext4: data=journal: fixes for ext4_page_mkwrite()
These are two fixes for data journalling required by
the next patch, discovered while testing it.
First, the optimization to return early if all buffers
are mapped is not appropriate for the next patch:
The inode _must_ be added to the transaction's list in
data=journal mode (so to write-protect pages on commit)
thus we cannot return early there.
Second, once that optimization to reduce transactions
was disabled for data=journal mode, more transactions
happened, and occasionally hit this warning message:
'JBD2: Spotted dirty metadata buffer'.
Reason is, block_page_mkwrite() will set_buffer_dirty()
before do_journal_get_write_access() that is there to
prevent it. This issue was masked by the optimization.
So, on data=journal use __block_write_begin() instead.
This also requires page locking and len recalculation.
(see block_page_mkwrite() for implementation details.)
Finally, as Jan noted there is little sharing between
data=journal and other modes in ext4_page_mkwrite().
However, a prototype of ext4_journalled_page_mkwrite()
showed there still would be lots of duplicated lines
(tens of) that didn't seem worth it.
Thus this patch ends up with an ugly goto to skip all
non-data journalling code (to avoid long indentations,
but that can be changed..) in the beginning, and just
a conditional in the transaction section.
Well, we skip a common part to data journalling which
is the page truncated check, but we do it again after
ext4_journal_start() when we re-acquire the page lock
(so not to acquire the page lock twice needlessly for
data journalling.)
Signed-off-by: Mauricio Faria de Oliveira <mfo@canonical.com>
Suggested-by: Jan Kara <jack@suse.cz>
Reviewed-by: Jan Kara <jack@suse.cz>
Reviewed-by: Andreas Dilger <adilger@dilger.ca>
Link: https://lore.kernel.org/r/20201006004841.600488-4-mfo@canonical.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
2020-10-06 00:48:40 +00:00
|
|
|
} else {
|
2023-03-24 18:01:25 +00:00
|
|
|
folio_unlock(folio);
|
ext4: data=journal: fixes for ext4_page_mkwrite()
These are two fixes for data journalling required by
the next patch, discovered while testing it.
First, the optimization to return early if all buffers
are mapped is not appropriate for the next patch:
The inode _must_ be added to the transaction's list in
data=journal mode (so to write-protect pages on commit)
thus we cannot return early there.
Second, once that optimization to reduce transactions
was disabled for data=journal mode, more transactions
happened, and occasionally hit this warning message:
'JBD2: Spotted dirty metadata buffer'.
Reason is, block_page_mkwrite() will set_buffer_dirty()
before do_journal_get_write_access() that is there to
prevent it. This issue was masked by the optimization.
So, on data=journal use __block_write_begin() instead.
This also requires page locking and len recalculation.
(see block_page_mkwrite() for implementation details.)
Finally, as Jan noted there is little sharing between
data=journal and other modes in ext4_page_mkwrite().
However, a prototype of ext4_journalled_page_mkwrite()
showed there still would be lots of duplicated lines
(tens of) that didn't seem worth it.
Thus this patch ends up with an ugly goto to skip all
non-data journalling code (to avoid long indentations,
but that can be changed..) in the beginning, and just
a conditional in the transaction section.
Well, we skip a common part to data journalling which
is the page truncated check, but we do it again after
ext4_journal_start() when we re-acquire the page lock
(so not to acquire the page lock twice needlessly for
data journalling.)
Signed-off-by: Mauricio Faria de Oliveira <mfo@canonical.com>
Suggested-by: Jan Kara <jack@suse.cz>
Reviewed-by: Jan Kara <jack@suse.cz>
Reviewed-by: Andreas Dilger <adilger@dilger.ca>
Link: https://lore.kernel.org/r/20201006004841.600488-4-mfo@canonical.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
2020-10-06 00:48:40 +00:00
|
|
|
}
|
2011-06-24 18:29:41 +00:00
|
|
|
}
|
|
|
|
ext4_journal_stop(handle);
|
2018-10-03 02:20:50 +00:00
|
|
|
if (err == -ENOSPC && ext4_should_retry_alloc(inode->i_sb, &retries))
|
2011-06-24 18:29:41 +00:00
|
|
|
goto retry_alloc;
|
|
|
|
out_ret:
|
2023-08-01 17:21:57 +00:00
|
|
|
ret = vmf_fs_error(err);
|
2011-06-24 18:29:41 +00:00
|
|
|
out:
|
2021-02-04 17:05:42 +00:00
|
|
|
filemap_invalidate_unlock_shared(mapping);
|
2012-06-12 14:20:38 +00:00
|
|
|
sb_end_pagefault(inode->i_sb);
|
2008-07-11 23:27:31 +00:00
|
|
|
return ret;
|
2020-10-06 00:48:41 +00:00
|
|
|
out_error:
|
2023-03-24 18:01:25 +00:00
|
|
|
folio_unlock(folio);
|
2020-10-06 00:48:41 +00:00
|
|
|
ext4_journal_stop(handle);
|
|
|
|
goto out;
|
2008-07-11 23:27:31 +00:00
|
|
|
}
|