Kernel/linux
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-01-16 01:54:00 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

lib: packing: catch kunit_kzalloc() failure in the pack() test

Browse Source 
kunit_kzalloc() may fail. Other call sites verify that this is the case,
either using a direct comparison with the NULL pointer, or the
KUNIT_ASSERT_NOT_NULL() or KUNIT_ASSERT_NOT_ERR_OR_NULL().

Pick KUNIT_ASSERT_NOT_NULL() as the error handling method that made most
sense to me. It's an unlikely thing to happen, but at least we call
__kunit_abort() instead of dereferencing this NULL pointer.

Fixes: e9502ea6db8a ("lib: packing: add KUnit tests adapted from selftests")
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Link: https://patch.msgid.link/20241004110012.1323427-1-vladimir.oltean@nxp.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
Vladimir Oltean 2024-10-04 14:00:12 +03:00 committed by Jakub Kicinski
parent bec2a32145
commit 1405981bbb
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
lib/packing_test.c
View File

@ -375,6 +375,7 @@ static void packing_test_pack(struct kunit *test)
int err; int err;
pbuf = kunit_kzalloc(test, params->pbuf_size, GFP_KERNEL); pbuf = kunit_kzalloc(test, params->pbuf_size, GFP_KERNEL);
KUNIT_ASSERT_NOT_NULL(test, pbuf);
err = pack(pbuf, params->uval, params->start_bit, params->end_bit, err = pack(pbuf, params->uval, params->start_bit, params->end_bit,
params->pbuf_size, params->quirks); params->pbuf_size, params->quirks);