Kernel/linux
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-01-16 01:54:00 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

llc: Improve setsockopt() handling of malformed user input

Browse Source 
copy_from_sockptr() is used incorrectly: return value is the number of
bytes that could not be copied. Since it's deprecated, switch to
copy_safe_from_sockptr().

Note: Keeping the `optlen != sizeof(int)` check as copy_safe_from_sockptr()
by itself would also accept optlen > sizeof(int). Which would allow a more
lenient handling of inputs.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Suggested-by: David Wei <dw@davidwei.uk>
Signed-off-by: Michal Luczaj <mhal@rbox.co>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
This commit is contained in:
Michal Luczaj 2024-11-19 14:31:41 +01:00 committed by Paolo Abeni
parent 5dfd7d9400
commit 1465036b10
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
net/llc/af_llc.c
View File

@ -1098,7 +1098,7 @@ static int llc_ui_setsockopt(struct socket *sock, int level, int optname,
lock_sock(sk); lock_sock(sk);
if (unlikely(level != SOL_LLC || optlen != sizeof(int))) if (unlikely(level != SOL_LLC || optlen != sizeof(int)))
goto out; goto out;
rc = copy_from_sockptr(&opt, optval, sizeof(opt)); rc = copy_safe_from_sockptr(&opt, sizeof(opt), optval, optlen);
if (rc) if (rc)
goto out; goto out;
rc = -EINVAL; rc = -EINVAL;