Kernel/linux
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2024-12-29 09:13:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

net: kcm: kcmproc.c: Fix RCU list suspicious usage warning

Browse Source 
This path fixes the suspicious RCU usage warning reported by
kernel test robot.

net/kcm/kcmproc.c:#RCU-list_traversed_in_non-reader_section

There is no need to use list_for_each_entry_rcu() in
kcm_stats_seq_show() as the list is always traversed under
knet->mutex held.

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Madhuparna Bhowmik 2020-03-16 22:43:52 +05:30 committed by David S. Miller
parent 10ee4b87f5
commit 1963507e62
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
net/kcm/kcmproc.c
View File

@ -261,7 +261,7 @@ static int kcm_stats_seq_show(struct seq_file *seq, void *v)
aggregate_strp_stats(&knet->aggregate_strp_stats, aggregate_strp_stats(&knet->aggregate_strp_stats,
&strp_stats); &strp_stats);
list_for_each_entry_rcu(mux, &knet->mux_list, kcm_mux_list) { list_for_each_entry(mux, &knet->mux_list, kcm_mux_list) {
spin_lock_bh(&mux->lock); spin_lock_bh(&mux->lock);
aggregate_mux_stats(&mux->stats, &mux_stats); aggregate_mux_stats(&mux->stats, &mux_stats);
aggregate_psock_stats(&mux->aggregate_psock_stats, aggregate_psock_stats(&mux->aggregate_psock_stats,