Kernel/linux
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-01-14 17:14:09 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

gpio: cs5535: Switch to using managed resources with devm_

Browse Source 
This change switches to devm_request_region to request region
and hence simplifies the module unload and does away with
release_region in remove function.

Cc: linux-gpio@vger.kernel.org
Signed-off-by: Pramod Gurav <pramod.gurav@smartplayin.com>
Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
This commit is contained in:
Pramod Gurav 2014-10-01 16:16:33 +05:30 committed by Linus Walleij
parent 4515b76d9b
commit 3eebd61322
1 changed files with 3 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
drivers/gpio/gpio-cs5535.c
View File

@ -322,7 +322,8 @@ static int cs5535_gpio_probe(struct platform_device *pdev)
goto done; goto done;
} }
if (!request_region(res->start, resource_size(res), pdev->name)) { if (!devm_request_region(&pdev->dev, res->start, resource_size(res),
pdev->name)) {
dev_err(&pdev->dev, "can't request region\n"); dev_err(&pdev->dev, "can't request region\n");
goto done; goto done;
} }
@ -348,24 +349,18 @@ static int cs5535_gpio_probe(struct platform_device *pdev)
/* finally, register with the generic GPIO API */ /* finally, register with the generic GPIO API */
err = gpiochip_add(&cs5535_gpio_chip.chip); err = gpiochip_add(&cs5535_gpio_chip.chip);
if (err) if (err)
goto release_region; goto done;
return 0; return 0;
release_region:
release_region(res->start, resource_size(res));
done: done:
return err; return err;
} }
static int cs5535_gpio_remove(struct platform_device *pdev) static int cs5535_gpio_remove(struct platform_device *pdev)
{ {
struct resource *r;
gpiochip_remove(&cs5535_gpio_chip.chip); gpiochip_remove(&cs5535_gpio_chip.chip);
r = platform_get_resource(pdev, IORESOURCE_IO, 0);
release_region(r->start, resource_size(r));
return 0; return 0;
} }