Kernel/linux
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-01-09 14:50:19 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

mm/migration: fix potential invalid node access for reclaim-based migration

Browse Source 
If we failed to setup hotplug state callbacks for mm/demotion:online in
some corner cases, node_demotion will be left uninitialized.  Invalid node
might be returned from the next_demotion_node() when doing reclaim-based
migration.  Use kcalloc to allocate node_demotion to fix the issue.

Link: https://lkml.kernel.org/r/20220318111709.60311-11-linmiaohe@huawei.com
Fixes: ac16ec835314 ("mm: migrate: support multiple target nodes demotion")
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Reviewed-by: "Huang, Ying" <ying.huang@intel.com>
Cc: Alistair Popple <apopple@nvidia.com>
Cc: Baolin Wang <baolin.wang@linux.alibaba.com>
Cc: Muchun Song <songmuchun@bytedance.com>
Cc: Zi Yan <ziy@nvidia.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
This commit is contained in:
Miaohe Lin 2022-04-28 23:16:08 -07:00 committed by akpm
parent 69a041ff50
commit 3f26c88bd6
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
mm/migrate.c
View File

@ -2479,9 +2479,9 @@ static int __meminit migrate_on_reclaim_callback(struct notifier_block *self,
void __init migrate_on_reclaim_init(void) void __init migrate_on_reclaim_init(void)
{ {
node_demotion = kmalloc_array(nr_node_ids, node_demotion = kcalloc(nr_node_ids,
sizeof(struct demotion_nodes), sizeof(struct demotion_nodes),
GFP_KERNEL); GFP_KERNEL);
WARN_ON(!node_demotion); WARN_ON(!node_demotion);
hotplug_memory_notifier(migrate_on_reclaim_callback, 100); hotplug_memory_notifier(migrate_on_reclaim_callback, 100);