Kernel/linux
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-01-17 18:36:00 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[PATCH] proc: Remove tasklist_lock from proc_pid_readdir

Browse Source 
We don't need the tasklist_lock to safely iterate through processes
anymore.

This depends on my previous to task patches that make get_task_struct rcu
safe, and that make next_task() rcu safe.  I haven't gotten
first_tid/next_tid yet only because next_thread is missing an
rcu_dereference.

Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
This commit is contained in:
Eric W. Biederman 2006-06-26 00:25:51 -07:00 committed by Linus Torvalds
parent 0bc58a9102
commit 454cc105ef
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
fs/proc/base.c
View File

@ -2043,7 +2043,7 @@ out:
static struct task_struct *first_tgid(int tgid, int nr)
{
struct task_struct *pos = NULL;
read_lock(&tasklist_lock);
rcu_read_lock();
if (tgid && nr) {
pos = find_task_by_pid(tgid);
if (pos && !thread_group_leader(pos))
@ -2069,7 +2069,7 @@ static struct task_struct *first_tgid(int tgid, int nr)
}
pos = NULL;
done:
read_unlock(&tasklist_lock);
rcu_read_unlock();
return pos;
}
@ -2082,7 +2082,7 @@ done:
static struct task_struct *next_tgid(struct task_struct *start)
{
struct task_struct *pos;
read_lock(&tasklist_lock);
rcu_read_lock();
pos = start;
if (pid_alive(start))
pos = next_task(start);
@ -2092,7 +2092,7 @@ static struct task_struct *next_tgid(struct task_struct *start)
}
pos = NULL;
done:
read_unlock(&tasklist_lock);
rcu_read_unlock();
put_task_struct(start);
return pos;
}