Kernel/linux
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2024-12-29 09:13:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

ALSA: hda: cs35l56: Remove calls to cs35l56_force_sync_asp1_registers_from_cache()

Browse Source 
Commit 5d7e328e20 ("ASoC: cs35l56: Revert support for dual-ownership
of ASP registers")
replaced cs35l56_force_sync_asp1_registers_from_cache() with a dummy
implementation so that the HDA driver would continue to build.

Remove the calls from HDA and remove the stub function.

Signed-off-by: Simon Trimmer <simont@opensource.cirrus.com>
Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Link: https://patch.msgid.link/20241206105757.718750-1-rf@opensource.cirrus.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
Simon Trimmer 2024-12-06 10:57:57 +00:00 committed by Takashi Iwai
parent c34e9ab9a6
commit 47b17ba05a
2 changed files with 0 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
include/sound/cs35l56.h
View File

@ -271,12 +271,6 @@ struct cs35l56_base {
struct gpio_desc *reset_gpio; struct gpio_desc *reset_gpio;
}; };
/* Temporary to avoid a build break with the HDA driver */
static inline int cs35l56_force_sync_asp1_registers_from_cache(struct cs35l56_base *cs35l56_base)
{
return 0;
}
static inline bool cs35l56_is_otp_register(unsigned int reg) static inline bool cs35l56_is_otp_register(unsigned int reg)
{ {
return (reg >> 16) == 3; return (reg >> 16) == 3;

8
sound/pci/hda/cs35l56_hda.c
View File

@ -151,10 +151,6 @@ static int cs35l56_hda_runtime_resume(struct device *dev)
} }
} }
ret = cs35l56_force_sync_asp1_registers_from_cache(&cs35l56->base);
if (ret)
goto err;
return 0; return 0;
err: err:
@ -1059,9 +1055,6 @@ int cs35l56_hda_common_probe(struct cs35l56_hda *cs35l56, int hid, int id)
regmap_multi_reg_write(cs35l56->base.regmap, cs35l56_hda_dai_config, regmap_multi_reg_write(cs35l56->base.regmap, cs35l56_hda_dai_config,
ARRAY_SIZE(cs35l56_hda_dai_config)); ARRAY_SIZE(cs35l56_hda_dai_config));
ret = cs35l56_force_sync_asp1_registers_from_cache(&cs35l56->base);
if (ret)
goto dsp_err;
/* /*
* By default only enable one ASP1TXn, where n=amplifier index, * By default only enable one ASP1TXn, where n=amplifier index,
@ -1087,7 +1080,6 @@ int cs35l56_hda_common_probe(struct cs35l56_hda *cs35l56, int hid, int id)
pm_err: pm_err:
pm_runtime_disable(cs35l56->base.dev); pm_runtime_disable(cs35l56->base.dev);
dsp_err:
cs_dsp_remove(&cs35l56->cs_dsp); cs_dsp_remove(&cs35l56->cs_dsp);
err: err:
gpiod_set_value_cansleep(cs35l56->base.reset_gpio, 0); gpiod_set_value_cansleep(cs35l56->base.reset_gpio, 0);