Kernel/linux
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-01-06 05:13:18 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

iio: dac: ltc2664: Fix off by one in ltc2664_channel_config()

Browse Source 
This comparison should be >= ARRAY_SIZE() instead of >.  The "mspan"
variable is later used as an array index into ltc2664_mspan_lut[] so
this is an off by one bug.

Fixes: 4cc2fc445d ("iio: dac: ltc2664: Add driver for LTC2664 and LTC2672")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://patch.msgid.link/5727ab54-6280-466e-b107-1b6006e5ab29@stanley.mountain
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
This commit is contained in:
Dan Carpenter 2024-08-09 15:28:30 +03:00 committed by Jonathan Cameron
parent b09999ee1e
commit 4f6ca3464d
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/iio/dac/ltc2664.c
View File

@ -526,7 +526,7 @@ static int ltc2664_channel_config(struct ltc2664_state *st)
return dev_err_probe(dev, -EINVAL,
"adi,manual-span-operation-config not supported\n");
if (mspan > ARRAY_SIZE(ltc2664_mspan_lut))
if (mspan >= ARRAY_SIZE(ltc2664_mspan_lut))
return dev_err_probe(dev, -EINVAL,
"adi,manual-span-operation-config not in range\n");
}