Kernel/linux
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-01-18 10:56:14 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

pinctrl: cy8c95x0: Lock register accesses in cy8c95x0_set_mux()

Browse Source 
It seems that cy8c95x0_set_mux() missed serialization of IO access.
And its implementation looks half-baked. Add locking to the function.

Fixes: e6cbbe42944d ("pinctrl: Add Cypress cy8c95x0 support")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20220916205450.86278-1-andriy.shevchenko@linux.intel.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
This commit is contained in:
Andy Shevchenko 2022-09-16 23:54:48 +03:00 committed by Linus Walleij
parent 35b871f72a
commit 56e380cfcd
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/pinctrl/pinctrl-cy8c95x0.c
View File

@ -1152,8 +1152,13 @@ static int cy8c95x0_set_mux(struct pinctrl_dev *pctldev, unsigned int selector,
unsigned int group)
{
struct cy8c95x0_pinctrl *chip = pinctrl_dev_get_drvdata(pctldev);
int ret;
return cy8c95x0_pinmux_cfg(chip, selector, group);
mutex_lock(&chip->i2c_lock);
ret = cy8c95x0_pinmux_cfg(chip, selector, group);
mutex_unlock(&chip->i2c_lock);
return ret;
}
static const struct pinmux_ops cy8c95x0_pmxops = {