Kernel/linux
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-01-10 07:10:27 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

block: warn if tag is greater than real_max_depth.

Browse Source 
In case tag depth is reduced, it is max_depth not real_max_depth.
So we should allow a request with tag >= max_depth, but for a
tag >= real_max_depth, there really should be some problem.

Signed-off-by: Tao Ma <boyu.mt@taobao.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
This commit is contained in:
Tao Ma 2011-10-25 10:20:05 +02:00 committed by Jens Axboe
parent 83157223de
commit 5e08159197
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
block/blk-tag.c
View File

@ -286,12 +286,14 @@ void blk_queue_end_tag(struct request_queue *q, struct request *rq)
BUG_ON(tag == -1); BUG_ON(tag == -1);
if (unlikely(tag >= bqt->real_max_depth)) if (unlikely(tag >= bqt->max_depth)) {
/* /*
* This can happen after tag depth has been reduced. * This can happen after tag depth has been reduced.
* FIXME: how about a warning or info message here? * But tag shouldn't be larger than real_max_depth.
*/ */
WARN_ON(tag >= bqt->real_max_depth);
return; return;
}
list_del_init(&rq->queuelist); list_del_init(&rq->queuelist);
rq->cmd_flags &= ~REQ_QUEUED; rq->cmd_flags &= ~REQ_QUEUED;