Kernel/linux
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-01-18 02:46:06 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

net: linkwatch: add net device refcount tracker

Browse Source 
Add a netdevice_tracker inside struct net_device, to track
the self reference when a device is in lweventlist.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
Eric Dumazet 2021-12-04 20:22:14 -08:00 committed by Jakub Kicinski
parent 606509f27f
commit 63f13937cb
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
include/linux/netdevice.h
View File

@ -1950,6 +1950,7 @@ enum netdev_ml_priv_type {
* keep a list of interfaces to be deleted. * keep a list of interfaces to be deleted.
* *
* @dev_addr_shadow: Copy of @dev_addr to catch direct writes. * @dev_addr_shadow: Copy of @dev_addr to catch direct writes.
* @linkwatch_dev_tracker: refcount tracker used by linkwatch.
* *
* FIXME: cleanup struct net_device such that network protocol info * FIXME: cleanup struct net_device such that network protocol info
* moves out. * moves out.
@ -2280,6 +2281,7 @@ struct net_device {
struct bpf_xdp_entity xdp_state[__MAX_XDP_MODE]; struct bpf_xdp_entity xdp_state[__MAX_XDP_MODE];
u8 dev_addr_shadow[MAX_ADDR_LEN]; u8 dev_addr_shadow[MAX_ADDR_LEN];
netdevice_tracker linkwatch_dev_tracker;
}; };
#define to_net_dev(d) container_of(d, struct net_device, dev) #define to_net_dev(d) container_of(d, struct net_device, dev)

4
net/core/link_watch.c
View File

@ -109,7 +109,7 @@ static void linkwatch_add_event(struct net_device *dev)
spin_lock_irqsave(&lweventlist_lock, flags); spin_lock_irqsave(&lweventlist_lock, flags);
if (list_empty(&dev->link_watch_list)) { if (list_empty(&dev->link_watch_list)) {
list_add_tail(&dev->link_watch_list, &lweventlist); list_add_tail(&dev->link_watch_list, &lweventlist);
dev_hold(dev); dev_hold_track(dev, &dev->linkwatch_dev_tracker, GFP_ATOMIC);
} }
spin_unlock_irqrestore(&lweventlist_lock, flags); spin_unlock_irqrestore(&lweventlist_lock, flags);
} }
@ -166,7 +166,7 @@ static void linkwatch_do_dev(struct net_device *dev)
netdev_state_change(dev); netdev_state_change(dev);
} }
dev_put(dev); dev_put_track(dev, &dev->linkwatch_dev_tracker);
} }
static void __linkwatch_run_queue(int urgent_only) static void __linkwatch_run_queue(int urgent_only)