Kernel/linux
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-01-14 17:14:09 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Staging: gdm72xx: silence underflow warning in netlink_send()

Browse Source 
The value of "group" comes from "idx" in __gdm_wimax_event_send():

	if (sscanf(e->dev->name, "wm%d", &idx) == 1)

Smatch marks sscanf values as user controlled.  It's supposed to be a
number in 0-30 range.  We cap the upper bound but allow negatives.  Fix
this by making it type u16 instead.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Dan Carpenter 2016-02-22 22:31:31 +03:00 committed by Greg Kroah-Hartman
parent c688671d89
commit 724dfc25f5
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/staging/gdm72xx/netlink_k.c
View File

@ -114,7 +114,7 @@ void netlink_exit(struct sock *sock)
netlink_kernel_release(sock);
}
int netlink_send(struct sock *sock, int group, u16 type, void *msg, int len)
int netlink_send(struct sock *sock, u16 group, u16 type, void *msg, int len)
{
static u32 seq;
struct sk_buff *skb = NULL;

2
drivers/staging/gdm72xx/netlink_k.h
View File

@ -20,6 +20,6 @@
struct sock *netlink_init(int unit, void (*cb)(struct net_device *dev, u16 type,
void *msg, int len));
void netlink_exit(struct sock *sock);
int netlink_send(struct sock *sock, int group, u16 type, void *msg, int len);
int netlink_send(struct sock *sock, u16 group, u16 type, void *msg, int len);
#endif /* __GDM72XX_NETLINK_K_H__ */