Kernel/linux
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-01-10 07:10:27 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

xfs: fix incorrect test in xfs_alloc_ag_vextent_lastblock

Browse Source 
When I lifted the code in xfs_alloc_ag_vextent_lastblock out of a loop,
I forgot to convert all the accesses to len to be pointer dereferences.

Coverity-id: 1457918
Fixes: 5113f8ec3753ed ("xfs: clean up weird while loop in xfs_alloc_ag_vextent_near")
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
This commit is contained in:
Darrick J. Wong 2020-03-13 13:57:58 -07:00
parent faf8ee8476
commit 77ca1eed5a
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
fs/xfs/libxfs/xfs_alloc.c
View File

@ -1514,7 +1514,7 @@ xfs_alloc_ag_vextent_lastblock(
* maxlen, go to the start of this block, and skip all those smaller * maxlen, go to the start of this block, and skip all those smaller
* than minlen. * than minlen.
*/ */
if (len || args->alignment > 1) { if (*len || args->alignment > 1) {
acur->cnt->bc_ptrs[0] = 1; acur->cnt->bc_ptrs[0] = 1;
do { do {
error = xfs_alloc_get_rec(acur->cnt, bno, len, &i); error = xfs_alloc_get_rec(acur->cnt, bno, len, &i);