Kernel/linux
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-01-11 07:39:47 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

igmp: Namespaceify igmp_llm_reports sysctl knob

Browse Source 
This was initially introduced in df2cf4a78e488d26 ("IGMP: Inhibit
reports for local multicast groups") by defining the sysctl in the
ipv4_net_table array, however it was never implemented to be
namespace aware. Fix this by changing the code accordingly.

Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Nikolay Borisov 2016-02-09 00:13:50 +02:00 committed by David S. Miller
parent 166b6b2d6f
commit 87a8a2ae65
5 changed files with 19 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
include/linux/igmp.h
View File

@ -37,7 +37,6 @@ static inline struct igmpv3_query *
return (struct igmpv3_query *)skb_transport_header(skb); return (struct igmpv3_query *)skb_transport_header(skb);
} }
extern int sysctl_igmp_llm_reports;
extern int sysctl_igmp_qrv; extern int sysctl_igmp_qrv;
struct ip_sf_socklist { struct ip_sf_socklist {

1
include/net/netns/ipv4.h
View File

@ -110,6 +110,7 @@ struct netns_ipv4 {
int sysctl_igmp_max_memberships; int sysctl_igmp_max_memberships;
int sysctl_igmp_max_msf; int sysctl_igmp_max_msf;
int sysctl_igmp_llm_reports;
struct ping_group_range ping_group_range; struct ping_group_range ping_group_range;

26
net/ipv4/igmp.c
View File

@ -107,9 +107,6 @@
#include <linux/seq_file.h> #include <linux/seq_file.h>
#endif #endif
/* IGMP reports for link-local multicast groups are enabled by default */
int sysctl_igmp_llm_reports __read_mostly = 1;
#ifdef CONFIG_IP_MULTICAST #ifdef CONFIG_IP_MULTICAST
/* Parameter names and values are taken from igmp-v2-06 draft */ /* Parameter names and values are taken from igmp-v2-06 draft */
@ -430,6 +427,7 @@ static struct sk_buff *add_grec(struct sk_buff *skb, struct ip_mc_list *pmc,
int type, int gdeleted, int sdeleted) int type, int gdeleted, int sdeleted)
{ {
struct net_device *dev = pmc->interface->dev; struct net_device *dev = pmc->interface->dev;
struct net *net = dev_net(dev);
struct igmpv3_report *pih; struct igmpv3_report *pih;
struct igmpv3_grec *pgr = NULL; struct igmpv3_grec *pgr = NULL;
struct ip_sf_list *psf, *psf_next, *psf_prev, **psf_list; struct ip_sf_list *psf, *psf_next, *psf_prev, **psf_list;
@ -437,7 +435,7 @@ static struct sk_buff *add_grec(struct sk_buff *skb, struct ip_mc_list *pmc,
if (pmc->multiaddr == IGMP_ALL_HOSTS) if (pmc->multiaddr == IGMP_ALL_HOSTS)
return skb; return skb;
if (ipv4_is_local_multicast(pmc->multiaddr) && !sysctl_igmp_llm_reports) if (ipv4_is_local_multicast(pmc->multiaddr) && !net->ipv4.sysctl_igmp_llm_reports)
return skb; return skb;
isquery = type == IGMPV3_MODE_IS_INCLUDE || isquery = type == IGMPV3_MODE_IS_INCLUDE ||
@ -540,6 +538,7 @@ empty_source:
static int igmpv3_send_report(struct in_device *in_dev, struct ip_mc_list *pmc) static int igmpv3_send_report(struct in_device *in_dev, struct ip_mc_list *pmc)
{ {
struct sk_buff *skb = NULL; struct sk_buff *skb = NULL;
struct net *net = dev_net(in_dev->dev);
int type; int type;
if (!pmc) { if (!pmc) {
@ -548,7 +547,7 @@ static int igmpv3_send_report(struct in_device *in_dev, struct ip_mc_list *pmc)
if (pmc->multiaddr == IGMP_ALL_HOSTS) if (pmc->multiaddr == IGMP_ALL_HOSTS)
continue; continue;
if (ipv4_is_local_multicast(pmc->multiaddr) && if (ipv4_is_local_multicast(pmc->multiaddr) &&
!sysctl_igmp_llm_reports) !net->ipv4.sysctl_igmp_llm_reports)
continue; continue;
spin_lock_bh(&pmc->lock); spin_lock_bh(&pmc->lock);
if (pmc->sfcount[MCAST_EXCLUDE]) if (pmc->sfcount[MCAST_EXCLUDE])
@ -684,7 +683,7 @@ static int igmp_send_report(struct in_device *in_dev, struct ip_mc_list *pmc,
if (type == IGMPV3_HOST_MEMBERSHIP_REPORT) if (type == IGMPV3_HOST_MEMBERSHIP_REPORT)
return igmpv3_send_report(in_dev, pmc); return igmpv3_send_report(in_dev, pmc);
if (ipv4_is_local_multicast(group) && !sysctl_igmp_llm_reports) if (ipv4_is_local_multicast(group) && !net->ipv4.sysctl_igmp_llm_reports)
return 0; return 0;
if (type == IGMP_HOST_LEAVE_MESSAGE) if (type == IGMP_HOST_LEAVE_MESSAGE)
@ -855,12 +854,13 @@ static int igmp_marksources(struct ip_mc_list *pmc, int nsrcs, __be32 *srcs)
static bool igmp_heard_report(struct in_device *in_dev, __be32 group) static bool igmp_heard_report(struct in_device *in_dev, __be32 group)
{ {
struct ip_mc_list *im; struct ip_mc_list *im;
struct net *net = dev_net(in_dev->dev);
/* Timers are only set for non-local groups */ /* Timers are only set for non-local groups */
if (group == IGMP_ALL_HOSTS) if (group == IGMP_ALL_HOSTS)
return false; return false;
if (ipv4_is_local_multicast(group) && !sysctl_igmp_llm_reports) if (ipv4_is_local_multicast(group) && !net->ipv4.sysctl_igmp_llm_reports)
return false; return false;
rcu_read_lock(); rcu_read_lock();
@ -884,6 +884,7 @@ static bool igmp_heard_query(struct in_device *in_dev, struct sk_buff *skb,
__be32 group = ih->group; __be32 group = ih->group;
int max_delay; int max_delay;
int mark = 0; int mark = 0;
struct net *net = dev_net(in_dev->dev);
if (len == 8) { if (len == 8) {
@ -969,7 +970,7 @@ static bool igmp_heard_query(struct in_device *in_dev, struct sk_buff *skb,
if (im->multiaddr == IGMP_ALL_HOSTS) if (im->multiaddr == IGMP_ALL_HOSTS)
continue; continue;
if (ipv4_is_local_multicast(im->multiaddr) && if (ipv4_is_local_multicast(im->multiaddr) &&
!sysctl_igmp_llm_reports) !net->ipv4.sysctl_igmp_llm_reports)
continue; continue;
spin_lock_bh(&im->lock); spin_lock_bh(&im->lock);
if (im->tm_running) if (im->tm_running)
@ -1184,6 +1185,7 @@ static void igmp_group_dropped(struct ip_mc_list *im)
{ {
struct in_device *in_dev = im->interface; struct in_device *in_dev = im->interface;
#ifdef CONFIG_IP_MULTICAST #ifdef CONFIG_IP_MULTICAST
struct net *net = dev_net(in_dev->dev);
int reporter; int reporter;
#endif #endif
@ -1195,7 +1197,7 @@ static void igmp_group_dropped(struct ip_mc_list *im)
#ifdef CONFIG_IP_MULTICAST #ifdef CONFIG_IP_MULTICAST
if (im->multiaddr == IGMP_ALL_HOSTS) if (im->multiaddr == IGMP_ALL_HOSTS)
return; return;
if (ipv4_is_local_multicast(im->multiaddr) && !sysctl_igmp_llm_reports) if (ipv4_is_local_multicast(im->multiaddr) && !net->ipv4.sysctl_igmp_llm_reports)
return; return;
reporter = im->reporter; reporter = im->reporter;
@ -1220,6 +1222,7 @@ static void igmp_group_dropped(struct ip_mc_list *im)
static void igmp_group_added(struct ip_mc_list *im) static void igmp_group_added(struct ip_mc_list *im)
{ {
struct in_device *in_dev = im->interface; struct in_device *in_dev = im->interface;
struct net *net = dev_net(in_dev->dev);
if (im->loaded == 0) { if (im->loaded == 0) {
im->loaded = 1; im->loaded = 1;
@ -1229,7 +1232,7 @@ static void igmp_group_added(struct ip_mc_list *im)
#ifdef CONFIG_IP_MULTICAST #ifdef CONFIG_IP_MULTICAST
if (im->multiaddr == IGMP_ALL_HOSTS) if (im->multiaddr == IGMP_ALL_HOSTS)
return; return;
if (ipv4_is_local_multicast(im->multiaddr) && !sysctl_igmp_llm_reports) if (ipv4_is_local_multicast(im->multiaddr) && !net->ipv4.sysctl_igmp_llm_reports)
return; return;
if (in_dev->dead) if (in_dev->dead)
@ -1530,6 +1533,7 @@ static void ip_mc_rejoin_groups(struct in_device *in_dev)
#ifdef CONFIG_IP_MULTICAST #ifdef CONFIG_IP_MULTICAST
struct ip_mc_list *im; struct ip_mc_list *im;
int type; int type;
struct net *net = dev_net(in_dev->dev);
ASSERT_RTNL(); ASSERT_RTNL();
@ -1537,7 +1541,7 @@ static void ip_mc_rejoin_groups(struct in_device *in_dev)
if (im->multiaddr == IGMP_ALL_HOSTS) if (im->multiaddr == IGMP_ALL_HOSTS)
continue; continue;
if (ipv4_is_local_multicast(im->multiaddr) && if (ipv4_is_local_multicast(im->multiaddr) &&
!sysctl_igmp_llm_reports) !net->ipv4.sysctl_igmp_llm_reports)
continue; continue;
/* a failover is happening and switches /* a failover is happening and switches

2
net/ipv4/sysctl_net_ipv4.c
View File

@ -852,7 +852,7 @@ static struct ctl_table ipv4_net_table[] = {
}, },
{ {
.procname = "igmp_link_local_mcast_reports", .procname = "igmp_link_local_mcast_reports",
.data = &sysctl_igmp_llm_reports, .data = &init_net.ipv4.sysctl_igmp_llm_reports,
.maxlen = sizeof(int), .maxlen = sizeof(int),
.mode = 0644, .mode = 0644,
.proc_handler = proc_dointvec .proc_handler = proc_dointvec

2
net/ipv4/tcp_ipv4.c
View File

@ -2401,6 +2401,8 @@ static int __net_init tcp_sk_init(struct net *net)
net->ipv4.sysctl_igmp_max_memberships = 20; net->ipv4.sysctl_igmp_max_memberships = 20;
net->ipv4.sysctl_igmp_max_msf = 10; net->ipv4.sysctl_igmp_max_msf = 10;
/* IGMP reports for link-local multicast groups are enabled by default */
net->ipv4.sysctl_igmp_llm_reports = 1;
return 0; return 0;
fail: fail: