Kernel/linux
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-01-17 02:15:57 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

irqchip/qcom-mpm: Fix IS_ERR() vs NULL check in qcom_mpm_init()

Browse Source 
devm_ioremap() doesn't return error pointers, it returns NULL on error.
Update the check accordingly.

Fixes: 221b110d87c2 ("irqchip/qcom-mpm: Support passing a slice of SRAM as reg space")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Link: https://lore.kernel.org/r/22e1f4de-edce-4791-bd2d-2b2e98529492@moroto.mountain
This commit is contained in:
Dan Carpenter 2024-02-01 15:17:50 +03:00 committed by Thomas Gleixner
parent f1c2765c6a
commit 8ad032cc8c
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/irqchip/irq-qcom-mpm.c
View File

@ -389,8 +389,8 @@ static int qcom_mpm_init(struct device_node *np, struct device_node *parent)
/* Don't use devm_ioremap_resource, as we're accessing a shared region. */ /* Don't use devm_ioremap_resource, as we're accessing a shared region. */
priv->base = devm_ioremap(dev, res.start, resource_size(&res)); priv->base = devm_ioremap(dev, res.start, resource_size(&res));
of_node_put(msgram_np); of_node_put(msgram_np);
if (IS_ERR(priv->base)) if (!priv->base)
return PTR_ERR(priv->base); return -ENOMEM;
} else { } else {
/* Otherwise, fall back to simple MMIO. */ /* Otherwise, fall back to simple MMIO. */
priv->base = devm_platform_ioremap_resource(pdev, 0); priv->base = devm_platform_ioremap_resource(pdev, 0);