Kernel/linux
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2024-12-28 16:53:49 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

lib: devres: Simplify API devm_ioport_unmap() implementation

Browse Source 
Simplify devm_ioport_unmap() implementation by dedicated API
devres_release(), compared with current solution, namely
ioport_unmap() + devres_destroy(), devres_release() has below advantages:

- it is simpler if devm_ioport_unmap()'s parameter @addr was ever
  returned by devm_ioport_map().

- it can avoid unnecessary ioport_unmap(@addr) if @addr was not
  ever returned by devm_ioport_map().

Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
Link: https://lore.kernel.org/r/20240918-fix_lib_devres-v1-2-e696ab5486e6@quicinc.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Zijun Hu 2024-09-18 22:48:14 +08:00 committed by Greg Kroah-Hartman
parent 0ee4dcafda
commit 9bd133f05b
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/devres.c
View File

@ -307,8 +307,7 @@ EXPORT_SYMBOL(devm_ioport_map);
*/ */
void devm_ioport_unmap(struct device *dev, void __iomem *addr) void devm_ioport_unmap(struct device *dev, void __iomem *addr)
{ {
ioport_unmap(addr); WARN_ON(devres_release(dev, devm_ioport_map_release,
WARN_ON(devres_destroy(dev, devm_ioport_map_release,
devm_ioport_map_match, (__force void *)addr)); devm_ioport_map_match, (__force void *)addr));
} }
EXPORT_SYMBOL(devm_ioport_unmap); EXPORT_SYMBOL(devm_ioport_unmap);