Kernel/linux
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-01-14 17:14:09 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[POWERPC] mpc5200-fec: Fix possible NULL dereference in mdio driver

Browse Source 
If the reg property is missing from the phy node (unlikely, but possible),
then the kernel will oops with a NULL pointer dereference.  This fixes
it by checking the pointer first.

Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
Signed-off-by: Paul Mackerras <paulus@samba.org>
This commit is contained in:
Grant Likely 2008-03-22 14:20:29 +11:00 committed by Paul Mackerras
parent 1428a9fa58
commit b8c19eb16a
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
drivers/net/fec_mpc52xx_phy.c
View File

@ -109,6 +109,7 @@ static int mpc52xx_fec_mdio_probe(struct of_device *of, const struct of_device_i
int irq = irq_of_parse_and_map(child, 0); int irq = irq_of_parse_and_map(child, 0);
if (irq != NO_IRQ) { if (irq != NO_IRQ) {
const u32 *id = of_get_property(child, "reg", NULL); const u32 *id = of_get_property(child, "reg", NULL);
if (id)
bus->irq[*id] = irq; bus->irq[*id] = irq;
} }
} }