Kernel/linux
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-01-10 15:19:51 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

panasonic-laptop: use snprintf with PAGE_SIZE in sysfs attributes

Browse Source 
Instead of just sprintf() into the page-sized buffer provided
by the sysfs/device_attribute API, we use snprintf with PAGE_SIZE
as an additional safeguard.

Signed-off-by: Martin Lucina <mato@kotelna.sk>
Signed-off-by: Harald Welte <laforge@gnumonks.org>
Signed-off-by: Len Brown <len.brown@intel.com>
This commit is contained in:
Harald Welte 2009-01-14 14:01:17 +08:00 committed by Len Brown
parent c542aadeb4
commit ba256b41bd
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/platform/x86/panasonic-laptop.c
View File

@ -367,7 +367,7 @@ static ssize_t show_numbatt(struct device *dev, struct device_attribute *attr,
if (!acpi_pcc_retrieve_biosdata(pcc, pcc->sinf)) if (!acpi_pcc_retrieve_biosdata(pcc, pcc->sinf))
return -EIO; return -EIO;
return sprintf(buf, "%u\n", pcc->sinf[SINF_NUM_BATTERIES]); return snprintf(buf, PAGE_SIZE, "%u\n", pcc->sinf[SINF_NUM_BATTERIES]);
} }
static ssize_t show_lcdtype(struct device *dev, struct device_attribute *attr, static ssize_t show_lcdtype(struct device *dev, struct device_attribute *attr,
@ -379,7 +379,7 @@ static ssize_t show_lcdtype(struct device *dev, struct device_attribute *attr,
if (!acpi_pcc_retrieve_biosdata(pcc, pcc->sinf)) if (!acpi_pcc_retrieve_biosdata(pcc, pcc->sinf))
return -EIO; return -EIO;
return sprintf(buf, "%u\n", pcc->sinf[SINF_LCD_TYPE]); return snprintf(buf, PAGE_SIZE, "%u\n", pcc->sinf[SINF_LCD_TYPE]);
} }
static ssize_t show_mute(struct device *dev, struct device_attribute *attr, static ssize_t show_mute(struct device *dev, struct device_attribute *attr,
@ -391,7 +391,7 @@ static ssize_t show_mute(struct device *dev, struct device_attribute *attr,
if (!acpi_pcc_retrieve_biosdata(pcc, pcc->sinf)) if (!acpi_pcc_retrieve_biosdata(pcc, pcc->sinf))
return -EIO; return -EIO;
return sprintf(buf, "%u\n", pcc->sinf[SINF_MUTE]); return snprintf(buf, PAGE_SIZE, "%u\n", pcc->sinf[SINF_MUTE]);
} }
static ssize_t show_sticky(struct device *dev, struct device_attribute *attr, static ssize_t show_sticky(struct device *dev, struct device_attribute *attr,
@ -403,7 +403,7 @@ static ssize_t show_sticky(struct device *dev, struct device_attribute *attr,
if (!acpi_pcc_retrieve_biosdata(pcc, pcc->sinf)) if (!acpi_pcc_retrieve_biosdata(pcc, pcc->sinf))
return -EIO; return -EIO;
return sprintf(buf, "%u\n", pcc->sinf[SINF_STICKY_KEY]); return snprintf(buf, PAGE_SIZE, "%u\n", pcc->sinf[SINF_STICKY_KEY]);
} }
static ssize_t set_sticky(struct device *dev, struct device_attribute *attr, static ssize_t set_sticky(struct device *dev, struct device_attribute *attr,